[00:48] I wrote a simple .desktop file that I've put in ~/.local/share/applications but unity's dash does not find it [00:48] why? [00:51] xclaesse: Anything special about the .desktop file? The various Steam .desktops in ~/.local/share/applications work for me. [01:06] RAOF, nothing special, I just want to launch my python script from unity's launchers [01:07] You could always try logging out and back in again. Presumably unity watches that path, but maybe reloading the scopes will fix it [01:07] ? [01:17] RAOF, ah I understand [01:18] it does not accept if the exec binary is in ~/.local/bin [01:18] Is ~/.local/bin in your path? [01:21] RAOF, I set the path in my .bashrc for that [01:21] it's probably not in unity's path [01:21] ok, setting the full path to the python script and it works [01:21] would be nice to have it relative though [01:23] did you try to use "bar" or ".local/bin/bar" or "~/.local/bin/bar" or "/home/foo/.local/bin/bar" ? [01:30] sarnold, ah ".local/bin/bar" works [01:31] cool :) [01:31] ok, next step: add an action in the context menu [08:45] good morning desktopers! === kgunn is now known as Guest15371 === psivaa-afk is now known as psivaa [09:04] morning! [09:08] Laney, good morning, how are you? [09:08] seb128: alright thanks, although I think my arm got bruised when I gave blood last night [09:08] so that hurts a bit [09:08] you? [09:10] I'm good thanks! [09:15] pitti: Good morning! [09:16] hey RAOF, how are you? [09:16] pitti: You've got a merge request and a bug for umockdev awaiting you :) [09:16] RAOF: thanks for your umockdev fixes [09:16] RAOF: no, I don't :) [09:16] :) [09:16] RAOF: it's all in 0.4.7, I uploaded that to Debian and it'll autosync in a few hours [09:16] Bitchn. [09:17] So, by the time I'm ready to propose this Mir branch, the valgrind tests should not fail in umockdev :) [09:19] robru: Was using sbuild [09:28] didrocks, btw on fully updated trusty I can still tap "alt" in g-c-c [09:28] works in a guest session as well [09:28] seb128: hum, let me try today [09:28] not sure what's the difference between our systems [09:28] still not working and update today [09:29] yeah, as Laney confirms, I'm wondering [09:29] I'll try a guest later [09:29] needs debugging by somebody having the issue [09:29] hint hint hint ;-) [09:29] heh, I'll have a look [09:47] mhr3, hey [09:48] mhr3, just as a FYI, the gvfsd-http leaks/non closing fds issues should be fixed in trusty, I would appreciate if you could verify/confirm during the cycle [09:49] larsu, hey [09:49] larsu, how is GTK 3.10 going? [09:49] larsu, still working on it/on what specific issues? [09:52] seb128: yes. I have a hard time figuring the update-manager list view issue out [09:53] larsu, that doesn't seem a blocker ... maybe we could just upstream that one? [09:53] larsu, and gently ping mclasen/Company saying it's a blocker to get the update in Ubuntu [09:54] well, not a blocker for the ppa I mean [09:54] maybe it's this one: https://bugzilla.gnome.org/show_bug.cgi?id=712220 [09:54] Gnome bug 712220 in GtkScrolledWindow "GtkScrolledWindow has incorrect minimal size" [Normal,Unconfirmed] [09:54] larsu, did you notice that it takes the correct space if you expend the details t the bottom? [09:54] ya [09:54] which is the weirdest part :-/ [09:55] seb128: okay, let me push that back. Then I'd only consider the scrollbar theme thing to be a blocker [09:56] larsu, right, I was going to say the same [09:56] I assume this is something that needs to be fixed in the theme though [09:56] I'll investigate :) [09:58] larsu, I would assume it's something to be fix in GTK/o-s code [09:58] but let's see [09:58] o-s ? [09:58] overlay-scrollbars [09:58] ah :) [09:59] seb128, cool, got a link to a bgo bug? [10:00] mhr3, https://bugzilla.gnome.org/show_bug.cgi?id=706225#c7 [10:00] Gnome bug 706225 in general "gvfsd-http crashed with signal 5 in g_cancellable_make_pollfd()" [Major,Resolved: duplicate] [10:01] mhr3, https://bugzilla.gnome.org/show_bug.cgi?id=695652#c44 [10:01] Gnome bug 695652 in HTTP Transport "Indefinite hang in run_sync_state_machine() on close()" [Normal,Resolved: fixed] [10:01] mhr3, I've commented on that second bug to see if we can get some of the fixes cherrypicked in the serie used in saucy [10:01] so we can SRU [10:02] mhr3, the commit Dan backported to fc19 seems to be https://git.gnome.org/browse/libsoup/commit/?id=96da2df64c9dd8cc52e97ce73e54615d6b520664 [10:22] larsu, do you need help on GTK for anything? Like do you want me to spend some time to see if I can get a small testcase example of the update-manager issue? [10:25] seb128: I've already found one: the test case in overlay-scrollbar [10:25] convergence! [10:25] lol [10:26] Laney, so new webkitgtk isn't happy on arm64 :/ [10:26] ../Source/WTF/wtf/dtoa/utils.h:64:2: error: #error Target architecture was not detected as supported by Double-Conversion. [10:27] Laney, it also made powerpc unhappy [10:29] seb128: yeah, checking it [10:29] I see the arm64 fix I think [10:29] ppc test building on partch [10:29] probably a missing #if somewhere [10:32] mhr3, don't run away like that :p [10:32] mhr3, did you get my reply? [10:32] seb128, saw the commit link as last thing [10:32] my internet died :/ [10:32] mhr3, ok, so you got it all, 2 bugs and 1 commit [10:32] using phone data now [10:33] seb128, when is that going to work with ubuntu phones btw? :) [10:33] what? sharing datas? [10:33] yep, usb tethering [10:33] or wifi [10:34] or bluetooth :) [10:34] mhr3, don't seem to be on the els prd list, so maybe not this cycle :/ [10:34] strangely sharing my phone's wifi over usb is my most used feature on android [10:35] mostly caused bcm wifi sucks so bad [10:37] seb128, anyway, i'm not sure whether it's the same issue, the bug is mentioning something that got broken and is now fixed [10:37] afaik the fd leaking has been there since at least 12.10 [10:38] mhr3, well, Ross it's easy to reproduce the issue, so should be easy to test on trusty? [10:40] seb128, well, it should be easy to see on errors.ubuntu.com :) [10:40] last time i checked that bug was high on the list [10:41] mhr3, yeah, it's first or second on gvfs issues for saucy, which is what made me comment upstream/ping about it yesterday [10:41] mhr3, I'm trying to work a bit on the e.u.c list every day [10:42] seb128, great, it's an awesome source of data [10:42] makes bug prioritization a walk in park :) [10:54] hum [10:54] I don't trust lightdm on trusty anymore, I swear it's doing weird stuff on user switches sometimes [10:54] I just had my session closed when logging out of a guest session [10:57] mhr3, is that normal that dash filters change (e.g new category got added) during the session? [11:01] seb128, yes [11:01] mhr3, that's weird :p [11:01] seb128, well, categories should be stable, sources will get added [11:02] mhr3, I've "news" added to the categories [11:02] e.g if I do [11:02] - log into a guest session [11:02] - open the dash [11:02] - look at filters [11:02] it starts with "aide" (help) [11:02] oh right [11:02] - type something in the search entry, clean it [11:03] -> "actualité" (news) is added to the categories [11:03] if a category has 0 sources it's not displayed, and since later a source is added, it becomes visible [11:03] ok, I see [11:03] that's a bit weird since it changes the layouting of the filters [11:03] thanks [11:04] * seb128 also noticed that turning the online data makes the dash snappy to return results again and is pondering to just do that [11:04] seb128, but if it was there all the time it'd be even worse (returning no results ever) [11:06] shrug [11:07] mhr3, so I set 'remote-content-search' to 'none' ... I did a query "pdf", which listed me some pdf I opened recently (great) [11:07] mhr3, now I open the dash again, type "pdf" and it lists no file, the "files" filter is off (I didn't change), dispite having 'files.scopes' in the 'always-search' gsettings [11:08] sounds like a bug [11:08] mhr3, do you think it's the same issue than the one from yesterday? [11:08] might very well be [11:08] :/ [11:08] seb128, can you get bustle log for that? [11:09] and attach it to the bug you opened [11:09] mhr3, oh, it works if I see the "remote-content-search' back to 'all' [11:09] mhr3, can you reproduce if you change the key to none? [11:09] * mhr3 tries [11:12] seb128, nope [11:12] :-( [11:12] anyway, the bustle log should help [11:13] just try to describe very precisely what you did and what you saw [11:13] there'll be a mismatch somewhere [11:13] seb128, perhaps even record a video while capturing the log [11:14] mhr3, is that going to "leak" all my dash content? not sure I want to put all my filenames online :p [11:14] seb128, mark it private then [11:33] larsu, I keep (ab)using your merge request to discuss GTK 3.10 issues, let me know if you prefer moving to a bug? (e.g should we rather use https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1171587) [11:33] Launchpad bug 1171587 in gtk+3.0 (Ubuntu) "update to GTK 3.9 and the issues to resolve for it" [Wishlist,Confirmed] [11:33] in fact that would make sense, let me comment on that bug ;-) [11:37] seb128: I don't mind either way [11:37] * larsu is bisecting the o-s issue [11:37] I hate o-s [11:40] * seb128 hugs larsu [11:41] talk to desrt about that [11:41] you can always try to ping that italian guy who wrote it :p [11:41] but I bet the reply is going to be "it was working, it's a bug in GTK" [11:42] I'm sure he'll be happy about that :) [11:42] to his defence that's what happened with GTK 3.8 and he was right :p [11:42] seems like the same here [11:42] the bug that make o-s buggy by then was an annoying one in GTK which impacted on other apps as well [11:43] 7 steps left. If only gtk built faster :) [11:48] -j8 FTW! [11:48] (and build in tmpfs) [11:48] larsu, just doing git bisect&make ought to not be that slow [11:49] seb128: slow enough to annoy me :) [11:50] * larsu is not a very patient person === MacSlow is now known as MacSlow|lunch [12:30] bregma, hey, could you get somebody assigned to https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1047517? that's the most reported unity issue on e.u.c/saucy [12:30] Launchpad bug 1047517 in unity (Ubuntu) "compiz crashed with SIGSEGV in g_mount_spec_to_dbus_with_path() ... from unity::IconLoader::Impl::IconLoaderTask::LoaderJobFunc()" [High,Confirmed] [12:31] seb128, we'll discuss it today [12:31] bregma, thanks === alan_g is now known as alan_g|lunch [12:51] mhr3, I've added bustle and video on https://bugs.launchpad.net/ubuntu/+source/unity-scope-home/+bug/1223933 ... let me know if you need more info or if you prefer a new bug since that's not strictly the same issue [12:51] Launchpad bug 1223933 in libunity "sometimes the dash home list "no result matching your query" string" [Undecided,Triaged] [12:52] seb128, thx [12:56] seb128, hm, it doesn't even try to search files [12:57] pstolowski, the log is odd ^^ [12:58] pstolowski, home scope sends query to apps scope, and then the same query to the scopes scope (even though that's supposed to be apps child) [12:59] mhr3, oh, if it's the case then it's indeed odd, looking [13:00] oh wait [13:00] nevermind [13:00] it's the apps master querying its children [13:02] pstolowski, nonetheless, later it doesn't send the query to files (which is in always-search according to seb) [13:02] later == when there's an actual search string [13:02] seb128, btw is the files scope running? === MacSlow|lunch is now known as MacSlow [13:02] pgrep unity-files-daemon? [13:02] mhr3, I guess so, the file lens is working [13:03] hm, interesting [13:03] yeah, it's running [13:04] seb128, but judging from your description, gsettings get com.canonical.Unity.Lenses home-lens-default-view doesn't show files.scope now? [13:05] pstolowski, [13:05] ['help.scope', 'help-askubuntu.scope', 'help-texdoc.scope', 'help-yelp.scope', 'news.scope', 'news-googlenews.scope', 'news-yahoostock.scope', 'applications.scope', 'applications-applications.scope', 'applications-scopes.scope'] [13:05] which matches the filters showed active on the ui [13:06] is it supposed to use the "always-search" ones as well? (that has apps/music/video/files) [13:06] seb128, right, and you never de-selected files in previous searches? [13:06] no [13:06] ah wait, it's not surfacing [13:07] so right, always-search should be used [13:13] seb128, just to make sure, can you paste the value of always-search as well? [13:16] mhr3, http://paste.ubuntu.com/6415785/ [13:17] great, thx [13:17] yw [13:17] seb128, and is this now reproducible on every search? [13:17] pstolowski, yes, it's stucked in that buggy situation [13:18] I've not tried to manually click on filters or restart processes though [13:18] in case you guys need more debug infos [13:18] but it's not going away by using the dash or typing stuff in the entry [13:19] seb128, mhr3 ok, I suspect filter state handler in home scope got confused, grr === alan_g|lunch is now known as alan_g [13:28] seb128, i'll look at this, probably next week [13:29] pstolowski, ok, let me know if you need more debug infos/want me to build a special versions with extra prints for example [13:29] seb128: So I checked the libs that LO brings its own copies, for the debian sync and MIR dance. libodfgen needs 0.0.3 which is not in debian exp. yet, libmwaw is uptodate in universe/just needs MIR, libmdds is outdated in universe, needs a sync of 0.9.1 from in debian experimental, libcmis needs 0.4.1 which is not in experimental yet. libenotyek and libfreehand are new with 4.2 -> lets postpone those. [13:29] I wonder if my config is special in any regards [13:30] Sweetshark, ok, should we do the libmdds sync? [13:32] seb128: yep, would be one thing of the list. [13:33] so on big bertha doing a release build of LibreOffice takes 30min. Building a package takes 106min. as xz compression of the result takes ages :/ [13:36] seb128, what would definitely help is if you run home scope with HOME_SCOPE_VERBOSE=1 env var set; and capture all the output from start till when the problem shows up (there will be lots of output, so just 2>&1 to a logfile) [13:37] pstolowski, ok, I can do that [13:37] seb128, so just kill home-scope and re-run it from a terminal === pstolowski is now known as pstolowski|lunch [13:43] pstolowski|lunch, mhr3: it's trivial to reproduce here [13:44] seb128, good, you'll be asked to send your laptop to poland then ;) [13:45] mhr3, pstolowski|lunch: I wonder if that's a locale stuff, I restarted the home scope with the debug env, I typed "pdf" and I had files, then I did "esc" ... the filters changes with "actualité" ("news" in french) added as the first category and files&folders got unselected at the same time [13:45] mhr3, pstolowski|lunch: http://ubuntuone.com/3tC2suxeWymsYaBbFkjGhf is the log [13:46] see l1337 [13:46] is that normal that this query is only apps scope? [13:47] l1321: 13:43:07.936785Z unity-scope-home: search-util.vala:180: Setting sources filter files-gdrive.scope: false [13:48] l1318 I mean [13:48] the files-local.scope is set to false [13:56] s/of/off/ === pstolowski|lunch is now known as pstolowski [14:32] seb128, no, it got confused after esc. thanks for the log, I think I have all the needed info [14:34] pstolowski, great, yw [14:35] good morning [14:35] let's drop overlay-scrollbars [14:38] larsu tells me i get free steak if this happens... so... soon, please? [14:39] desrt: only of you had verifiable influence on that decision ;) [14:40] larsu: butterfly effect, dude [14:40] heh [14:40] not really verifiable [14:40] given you dont have wings, how do you do that ? [14:41] fart and it will change eventually ? [14:42] desrt, good morning [14:43] seb128: hey. i'd be happy if you could now say "we will get rid of them, but only because desrt asked so nicely" [14:43] desrt, let's not start trolling, new GTK is making me less happy by the day, I could start ranting soon :p [14:43] * seb128 just opened https://bugzilla.gnome.org/show_bug.cgi?id=712302 [14:43] Gnome bug 712302 in GtkFileChooser "GtkPlacesSideBar showing "Desktop" or not shouldn't be a by-application setting" [Normal,Unconfirmed] [14:43] wth GNOME [14:43] oh. this is fun :) [14:43] uh oh. I guess I should stop ranting then... [14:44] seb128: if i fix this bug, will you let larsu drop overlay-scrollbars? :) [14:44] they made the default to be "don't show a desktop, because GNOME3 doesn't have one" [14:44] and the solution is to patch every app [14:44] just use QtFilechooser ;) [14:45] seb128: i guess you want XSETTINGS stuff here [14:45] desrt, no dropping of anything [14:45] desrt, yeah, but isn't xsettings being killed because it doesn't work in wayland? [14:45] desrt: why not a gsetting? The file chooser already has a schema (and federico said so in that commit) [14:45] larsu, because schemas are not by desktop [14:46] larsu, e.g a xfce user wants that item, an Unity user wants it, a GNOME3 doesn't [14:46] argh, right [14:46] well.... in fairness, it sort of makes sense to bind this to the "icons on desktop" setting that already exists [14:46] if the user turns off viewing their desktop then that should be the indication not to show it in the chooser [14:46] regardless of environment [14:47] good idea, but this is a nautilus setting, no? [14:47] no [14:47] I was going to say [14:47] i think it's in org.gnome.desktop.interface [14:47] org.gnome.desktop.background show-desktop-icons false [14:47] * desrt was close [14:48] is that installed on an xfce desktop? [14:49] no [14:49] neither on win32 [14:49] nor macOS [14:49] * desrt already raised this point in the bug [14:49] we need an equivalent to shell-shows-menubar [14:49] adding XSETTINGS back to gtk seems to be popular these days.... [14:53] dobey, my wife is angry with you! :-p [14:53] she couldn't figure out how to buy music anymore... she's on precise [14:57] larsu, kenvandine, charles, tedg, Laney, let's skip the settings meeting, I don't think anyone worked on this week (I didn't see any activity and CI is down), seems everybody is busy catching up with other topics/start of cycle work [14:57] cyphermox, attente, didrocks: ^ [14:57] seb128, ack [14:58] ok [14:58] sure [14:58] seb128: btw, looking at wpa... [14:58] cyphermox, hey! oh, thanks ;-) [14:59] +1 [15:00] seb128: it's that bug that failed to retrace everywhere in all cases [15:00] something broke maybe in libnl === didrocks1 is now known as didrocks [15:13] seb128: be happy. this problem will be solved by end of day. [15:14] desrt, thanks a lot for dealing with it! [15:14] seb128: so... about those overlay-scrollbars..... [15:14] ;) [15:15] desrt, *lalalalala* [15:15] ;-) [15:16] geesh. you do a nice thing, and this is what happens [15:16] seb128: *the keg* is on the line here [15:16] seb128: in fairness, probably larsu would treat you as well... [15:16] * larsu confirms [15:16] you don't want me to get fired, do you? ;-) [15:17] 'accepting bribes' [15:20] I think getting rid of scrollbars entirely is more sane than getting rid of overlay-scrollbars :P [15:21] mdeslaur: and how do you show how far along a document you are? [15:21] larsu, mdeslaur: let's stop trolling, friday is tomorrow :p [15:21] larsu: oh, you leave the indication there, you just don't pop anything up over it :P [15:21] larsu, btw I just tested on raring, seems to be that the thumb behaves/looks the same way [15:22] larsu, the orange portion was not animated, it was just always there to show the position [15:22] * mdeslaur suspends further trolling until tomorrow [15:22] mdeslaur: ah, that would have been part of the "scrollbar" term for me. I totally agree then [15:22] seb128: cool. Thank you. I guess I misremembered [15:24] seb128: this is what I meant: http://vimeo.com/30210146 [15:28] larsu, is that the orange/grey line and the way it's displayed/fading away? [15:28] seb128: yes, the gray one is missing for me when using 3.8 [15:35] larsu, work in a saucy vm (sorry got sidetracked while the vm was loading) [15:36] larsu, let me downgrade gtk on trusty and see [15:43] larsu, I'm testing with "nautilus /usr/share", works fine on trusty with the trusty GTK (you just need to aim close from the border and slowly) [15:44] seb128: do you get the gray bar as well? [15:46] larsu, yes [15:46] meh :/ [15:46] seb128: thanks for testing that, [15:48] larsu, http://ubuntuone.com/5VrE9JH4FuK1VIMIZrSvxG [15:48] larsu, that's trusty with the trusty gtk version [15:49] seb128: weirdly enough, I don't get that with upstream gtk 3.8. Might be one of our patches. [15:54] larsu, I don't really see which patch in our stack could make a difference there :/ [15:55] me neither. I'll find out after I get the trough visible at all [15:55] larsu, what application are you testing with? [15:56] seb128: the tester inside of overlay-scrollbars source tree [15:56] tests/test-os [16:00] larsu, that test app is weird/buggy [16:00] how so? [16:00] larsu, http://ubuntuone.com/4fHJW2VMDIXLYhQDoGxlMN [16:01] is that how it looks like for you? [16:01] ya, it seems to be the bug that we also see in update-manager [16:01] I patched the tester :) [16:01] larsu, that screenshot is using GTK 3.8... [16:02] how did you patch it ? [16:02] then it's definitely not the same bug :D [16:02] http://paste.debian.net/65856/ [16:02] I made it so that there's only one listview [16:02] good enough for testing [16:03] larsu, ok, I do get the grey bar/animation on that as well [16:03] just wanted to rule out the test to be buggy [16:03] I'm going to let you debug then, let me know if I can help for anything else [16:03] yep. Thanks a lot for testing! [16:05] yw! === gatox is now known as gatox_lunch === greyback is now known as greyback|away [16:24] seb128: I did some analysis on bug 1221593 (my last comment), and can only pick up it again next week cuz I'm at Changsha for the meeting from today to the weekend. [16:24] Launchpad bug 1221593 in ibus (Ubuntu) "ibus-ui-gtk3 crashed with SIGABRT in _g_log_abort()" [High,Triaged] https://launchpad.net/bugs/1221593 [16:25] happyaron, hey, thanks ... is the issue fixed in 1.5.4? [16:26] mterry: so the icon theme uninstallability is fixed, now https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-deja-dup/14/? failed with a test failure; would you mind having a look? [16:26] happyaron, I wonder if the error is worth asserting on, what would happen if we only g_warning there? would it pick the config once the daemon writes it? [16:27] seb128: I haven't tested the latest patchset ofr 1.5.4, anyway it's not fully a part of the released version of ibus, but need some patch that fujiwara apply to F19. [16:27] seb128: not tested yet, but that's worth to try. [16:28] happyaron, why is fujiwara not upstream those changes? do they still have them in f20? [16:29] seb128: fujiwara cannot commit those changes directly, need code review from phuang (original author of ibus). So all the distros are carrying fujiwara's patches for certain features/fixes. [16:30] it's more obvious since gnome decides to do the integration. [16:30] happyaron, is that because phuang is not active for reviews? [16:30] k [16:30] happyaron, thanks for the update [16:30] seb128: he's active, but not that interested on those kindia integrations. [16:30] he cares more about the framework [16:30] ok [16:31] happyaron, can you check, next week, what happens if we just return in that function instead of asserting? [16:31] seb128: sure [16:31] happyaron, that might be good enough as a solution [16:31] happyaron, thanks [16:32] with pleasure [16:34] * seb128 shakes the fist to lightdm in trusty === hggdh_ is now known as hggdh [16:57] seb128: got patches up for the GtkPlacesSidebar issue [16:57] testing appreciated [16:57] desrt, excellent, thanks [16:57] (they seem to work in my jhbuild) [16:57] desrt, I was about to go for some exercice but I do that next once I'm back [16:57] cool [16:58] looks like they'll go upstream pretty quickly so i don't know if there is much value in patching them in our packages except for local testing === gatox_lunch is now known as gatox === greyback|away is now known as greyback === Ursinha is now known as Ursinha-afk [17:12] desrt: hey, how are you? [17:12] good. [17:12] * desrt is doing job #1 today [17:12] desrt: I pushed an updated patch to -shim, FYI [17:13] oh. great. [17:13] desrt: oh, what's that? [17:13] * desrt checked last night, didn't see it [17:13] pitti: making seb happy [17:13] "watch latest BBT episode"? [17:13] ooh [17:13] desrt: no, did it this moring [17:13] morning, too [17:13] some 11 hours ago [17:14] desrt: if you are happy with it, could we just do a version 5? [17:14] * desrt would have preferred a chance to review it [17:14] although i suppose that's inconsistent with my previous hopes of passing off maintainership to you :) [17:14] desrt: ah, I thought you were content with our discussion how to do it yesterday [17:15] desrt: but it's not yet released or uploaded or anything [17:15] desrt: it's git, so we can change it :) [17:15] pitti: i'm pretty strong into the "no non-trivial commits without code review" mindset these days [17:15] desrt: ok, noted for the future [17:15] desrt: (good thing!) [17:15] looks more or less fine, though... i'd only have minor tweaks to it [17:15] I should try that with my projects too, I just find it hard to find someone who wants to bother with reading apport or umockdev patches [17:16] printf("%u", getpid()) is possibly undefined, for example [17:16] if sizeof(pid_t) != sizeof(int) [17:16] but i guess in our case they're the same [17:16] desrt: undefined? [17:16] ah [17:16] pitti: if you had a platform where pid_t was a long, for example [17:17] so that would need an (unsigned) cast [17:17] then passing the result of getpid() directly as the argument for "%u" would be an error [17:17] as there's no printf macro for pid_t [17:17] yes. you'd normally want a cast in this case. [17:17] i'd also have used g_strdup_printf() instead of mucking around with the static buffer [17:17] and i'd have written 'GError *error' instead of 'GError* error' [17:17] as i said -- all minor complaints :) [17:18] probably not worth changing [17:18] nah, I'll do it anyway [17:18] i assume you tested it and it works? [17:18]