/srv/irclogs.ubuntu.com/2013/11/14/#ubuntu-quality.txt

balloonsnot you forestpiskie, just elfy00:27
elfyI saw that too :p00:28
=== chihchun_afk is now known as chihchun
jibelGood morning06:30
DanChapmangood morning07:40
elfymorning DanChapman07:40
DanChapmanhey there elfy :-)07:41
=== iahmad_ is now known as iahmad
=== iahmad is now known as iahmad|afk
=== psivaa-afk is now known as psivaa
=== iahmad|afk is now known as iahmad
elfyubuntu-bug is fighting me and unfortunately winning - won't let me report something10:03
jpdsAre you experiencing a bug while running ubuntu-bug?10:08
slickymastergood morning all10:09
DanChapmanmorning slickymaster o/10:10
elfyjpds: it refuses to do anything - it refuses to do anything even if I try and manually push the crash report10:10
slickymastermorning DanChapman10:11
elfyjpds: but - time is my enemy just now - back later to read backlog if you can think of anything :)10:11
davmor2Morning all10:59
=== _salem is now known as salem_
=== chihchun is now known as chihchun_afk
elopiogood morning.13:56
balloonselfy, congrats15:44
elfythanks balloons :)15:45
DanChapmanballoons, what are we congratulating elfy on?15:45
elfyI rid myself of forestpiskie :p15:45
elfyDanChapman: I got voted onto the Community Council for my sins :)15:46
DanChapmanlol. Oh awesome! congratulations! \o/15:46
knomesomething fishy going on there15:47
elfyI'm English, not schooled at Eton so tend to not blow my own trumpet and didn't say anything :)15:47
knomeare you sure the polling website is fine?15:47
elfyapprently not knome15:47
knomeyeah15:47
knome:/15:47
knomehave to avoid that in the future15:47
knomeotherwise it'll raffles you as the xubuntu project lead next15:47
balloonsyes, apparently the last minute campaigning worked :-p15:48
elfyno it won't knome ;)15:48
balloonsseriously tho, congrats..15:48
elfythanks :)15:48
knomei'm serious! who the heck voted for him!15:48
knomewait, i did15:48
knome:|15:48
elfy:)15:48
knomemy bad!15:48
* elfy had a block vote too 15:48
* balloons says he did too15:49
elfyreminiscent of trade unions15:49
knomeballoons, you just "say", but didn't?15:49
* elfy voted for everyone on the list15:49
knomeme too, just *down*voted some15:49
knomehar har15:49
knome:P15:49
balloonsyep.. I voted for everyone15:49
knomeyou kind of have to do that with the CIVS15:49
balloonsnot everyone I voted for made it tho15:49
knomeballoons, of course not if you voted for everyone :P15:50
elfyknome: well you kind of do - but you could mark one as 1 and the others as last15:50
elfywhich is kind of silly15:50
knomeelfy, which is the same as marking them one 1 and rest 215:50
elfyI guess15:50
knomeelfy, which is really close to just voting for one person regularly15:50
knomeit is, because CIVS is about preference15:51
knomeit doesn't matter if it's 1/2 or 12/1315:51
knomeyou still prefer the guy in 1/1215:51
knomeor gal15:51
elfyconfuses me - so I sorted everyone out :)15:51
knomehehe15:51
knomewell that's fair as well15:51
balloonsI put 1 through 12 in15:51
balloonsyes, I like the system15:51
knomeif you can make a difference, you probably should15:51
knomei couldn't on a few occasions15:52
balloonselfy, btw now I get to refer to you in fun ways; https://plus.google.com/104307250302998042813/posts/G8dqRSJamwL15:56
elfy:)15:56
DanChapmanballoons, I'm just going through all the ubuntu-autopilot-tests creating a list of todo's, So first they are all going to need porting to 1.4 but what is the choice on python version are we wanting to port them to py3 at the same time. Not much really needs changing for that, so my question is rather which py version are we to suggest writing tests with going forward?16:29
balloonspython3 :-) Starting with 1.4 we should look to python316:29
balloonsthat said, I've not converted any tests just yet16:30
balloonsthey have to be run with the py3 runner as well16:30
balloonsI would say something to keep in mind.. as of now I don't know of concrete plans to rid all py2 tests this cycle16:31
balloonshttps://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/124923516:31
ubot5Ubuntu bug 1249235 in Ubuntu UI Toolkit "Need a python3 version of ubuntu-ui-toolkit-autopilot" [Undecided,Confirmed]16:31
DanChapmanballoons, ok cool, well if we are going to look to py3 for ap-1.4 for new tests then really the current ones will need to be ported at some point, so we don't have a mixture of py2/3 in ubuntu-ap-tests.16:36
balloonsDanChapman, I would look to port them all at once I think.. the py2 -> py3 work is simple enough16:36
DanChapmanballoons, thats what i was thinking16:37
DanChapman:-)16:37
balloonsstill, let's note it's something to be done :-)16:37
balloonsnot completely trivial16:37
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== hggdh_ is now known as hggdh
=== Ursinha is now known as Ursinha-afk
cgoldbergballoons.. porting to Py3 is usually simple (a cutover).... but using a single code base that runs under Py2 *and* Py3 is not always simple17:16
cgoldbergso if it all possible... drop Py217:16
balloonsI tried to do the dual py2 and pt3 thing once17:17
cgoldbergballoons, it usually the best upgrade path.. but it's tricker17:17
cgoldbergtrickier even17:17
balloonsit worked for a little bit, but it was annoying. you would break one or the other quite often17:22
=== Ursinha-afk is now known as Ursinha
Letozaf_balloons, buonasera20:04
balloonsLetozaf_, buonasera20:04
Letozaf_balloons, howzit ?20:05
balloonsLetozaf_, good.. just looking at rssreader actually20:06
Letozaf_balloons, oh thanks, was about to ask you about it20:07
balloonsthe wait_until_destroyed isn't doing it as-is, but now I'm hitting other things20:07
balloonswait.select_single should be wait_select_single20:07
balloons:-)20:07
Letozaf_balloons, where, let me check...20:08
balloonsin emulators20:08
Letozaf_balloons, found it :(20:08
Letozaf_balloons, I will re-run the tests20:09
balloonstrying to use the wait_until_destroyed20:10
Letozaf_balloons, I keep on getting that IndexError: list index out of range for ActionSelectionPopover20:15
balloonsI'm not getting that at all20:15
Letozaf_balloons, are you running the tests on the Desktop or the device ?20:15
balloonsdesktop for now.. I'm trying to get the activity indicator check to work20:16
balloonsit doesn't for me atm20:16
Letozaf_balloons, see this drives me mad, now I had no failures, and I didn't change the code, just re-ran the test20:18
Letozaf_balloons, I'm also running them on the dekstop20:19
balloonsLetozaf_, yes it simply means we need some more asserts20:19
balloonsthe tests don't run reliably20:19
balloonswell, lol, it might not be asserts we need, I simplify too much20:20
balloonsbut yes, we need them to run reliably20:20
Letozaf_balloons, ok, let me see if I can fix something...20:22
balloonshmm20:24
balloonsI really want this activity indicator check to work20:25
balloonswe could use it several spots20:25
Letozaf_balloons, it's hard to write something on ActivityIndicator as it disappears and cannot see it in vis20:34
Letozaf_balloons, I can only see the running property form the QML20:35
balloonsright20:35
balloonsyou can do it in vis, but20:35
balloonshmm.. got something I like20:41
Letozaf_balloons, what ?20:41
balloonsI'll push if it works20:43
Letozaf_balloons, ok20:43
balloonssweetness20:52
Letozaf_balloons, for what ?20:52
balloonsbzr merge lp:~nskaggs/ubuntu-rssreader-app/add-activity-indicator-check20:53
balloonsLetozaf_, I added a _wait_for_refresh function, and tweaked the check for the activity indicators20:54
balloonsseems to work20:54
balloonsfull test checks now, then on the phone20:54
Letozaf_balloons, let me try :)20:55
balloonsLetozaf_,  what is the Not(Is([]))?20:56
Letozaf_balloons, I copied it from somewhere, do not remember where, wanted to avoid a Not(Is(None)) I think20:57
Letozaf_balloons, is that bad ?20:58
balloonsLetozaf_, just different, hah..20:58
balloonsI'm open to why you didn't want to use a Not(Is(None)). but anyways we can probably add wait_select_single's in there instead and drop them all20:58
balloonsso it worked, save for test_view_feed failed because the editFeed was null21:00
balloonsprobably just a timing thing.. so I think we can clean those up and hopefully be set21:01
Letozaf_balloons, just ran the test now and saw the failure21:02
Letozaf_balloons, weired now it worked fine all 3 tests21:05
balloonsLetozaf_, that's not weird.. it's a timing issue, which sometimes occurs and sometimes doesn't21:10
balloonswe need to squelch them all so it will run reliably21:10
Letozaf_balloons, yes ok got it, I will run the test again an again to veryfy it does not happen, if it does fix the timing issue21:11
balloonsLetozaf_, yep.. but basically just go cleanup anything like this: self.assertThat(editFeed, Not(Is([])))21:12
Letozaf_balloons, yea already done that21:13
balloonsLetozaf_, alrighty :-)21:26
=== salem_ is now known as _salem
Letozaf_balloons, nope I have two issues now,21:35
Letozaf_balloons, CanonicalTopic is not removed21:35
Letozaf_balloons, and I have a    raise MismatchError(matchee, matcher, mismatch, verbose)21:37
Letozaf_MismatchError: None matches Is(None)21:37
Letozaf_balloons, if I put self.assertThat(editFeed, Not(Is(None)))21:37
Letozaf_balloons, I get failure using Not(Is(None)) instead of Not(Is([])) but do not understand why21:40
Letozaf_balloons, MismatchError: After 10.0 seconds test failed: <testtools.matchers._higherorder.Not object at 0x2f38bd0> != [21:40
balloonsLetozaf_, ohh I would do it differently.. let me see21:42
balloonsLetozaf_, I'm changing get_feed_in_feedlist to always return something21:46
balloonsand eliminate the check21:46
Letozaf_balloons, so you will check that the feed is different form the one deleted ?21:48
balloonshmm.. actually not so easy21:48
balloonsI think i will use the not is none21:48
balloonsI'm confused by this test now21:52
balloons#click on list view toolbar button21:52
balloons        toolbar.click_button("changemodebutton")21:52
Letozaf_balloons, it's to change from shorts view to list view21:52
balloonsok, but I'm confused what you are trying to do in that test21:54
Letozaf_balloons, well I think you don't have to do it, I just chose to do it21:54
Letozaf_balloons, I think the test works all the same if you remove that21:54
Letozaf_balloons, it was just for changing view type21:55
balloonsLetozaf_, :-) What are you trying to do with the selecting a feed? you never make it to the edittopic tab21:55
balloonsit's just really confusing21:55
Letozaf_balloons, I was changing from the shorts view to the list view of the topics21:56
balloonsWhat I'm trying to say is what does "test_view_feeds" test?21:57
Letozaf_balloons, it's  a way to check that it works21:57
balloonsdo we just want to make sure we can change the view?21:57
balloonsif so, we can radically simplify this testcase21:57
Letozaf_balloons, oh, it just tests that you open the feed to read it21:57
Letozaf_balloons, I both test it opens a feed and changes view mode21:57
Letozaf_balloons, maybe the test name should be changed21:58
balloonsyea, we could be more desciptive21:58
balloonsok, so test switching the view21:58
balloonsthen open a feed and view an article?21:58
Letozaf_balloons, yes21:58
balloonswow, ok.. good test, but I don't see where this test does that, hah21:58
Letozaf_balloons, for this : https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/118871322:01
ubot5Ubuntu bug 1188713 in Ubuntu RSS Feed Reader App "Autopilot Testcase Needed: Test feed list view" [High,In progress]22:01
balloonsLetozaf_, k. So, do we need to add a topic and feed first? there are default feeds22:01
balloonsI'd guess we can use one of those22:01
balloonsthat will simplify things22:02
Letozaf_balloons, I used the canonical ones as in the beginning there weren't only canonical and ubuntu ones22:02
Letozaf_balloons, but also other ones22:02
Letozaf_balloons, then they changed22:02
Letozaf_balloons, so on every test I added the canonical feed to test on those22:03
Letozaf_balloons, in other words I wanted to test the same feed on every test and so used the canonical one everywhere22:05
Letozaf_balloons, added it at the beginning and tested on that one and then removed it at the end22:06
balloonshmm22:07
balloonsok, fair enough. I'll playing around with it22:07
Letozaf_balloons, it's late for me now, I will be back tomorrow. let me know what you decide22:09
Letozaf_balloons, going to bed22:10
Letozaf_balloons, good night22:10
balloonsLetozaf_, ciao.22:10
balloonsthanks for your help22:10
Letozaf_balloons, ciao22:10
Letozaf_balloons, yw22:10

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!