[00:27] not you forestpiskie, just elfy [00:28] I saw that too :p === chihchun_afk is now known as chihchun [06:30] Good morning [07:40] good morning [07:40] morning DanChapman [07:41] hey there elfy :-) === iahmad_ is now known as iahmad === iahmad is now known as iahmad|afk === psivaa-afk is now known as psivaa === iahmad|afk is now known as iahmad [10:03] ubuntu-bug is fighting me and unfortunately winning - won't let me report something [10:08] Are you experiencing a bug while running ubuntu-bug? [10:09] good morning all [10:10] morning slickymaster o/ [10:10] jpds: it refuses to do anything - it refuses to do anything even if I try and manually push the crash report [10:11] morning DanChapman [10:11] jpds: but - time is my enemy just now - back later to read backlog if you can think of anything :) [10:59] Morning all === _salem is now known as salem_ === chihchun is now known as chihchun_afk [13:56] good morning. [15:44] elfy, congrats [15:45] thanks balloons :) [15:45] balloons, what are we congratulating elfy on? [15:45] I rid myself of forestpiskie :p [15:46] DanChapman: I got voted onto the Community Council for my sins :) [15:46] lol. Oh awesome! congratulations! \o/ [15:47] something fishy going on there [15:47] I'm English, not schooled at Eton so tend to not blow my own trumpet and didn't say anything :) [15:47] are you sure the polling website is fine? [15:47] apprently not knome [15:47] yeah [15:47] :/ [15:47] have to avoid that in the future [15:47] otherwise it'll raffles you as the xubuntu project lead next [15:48] yes, apparently the last minute campaigning worked :-p [15:48] no it won't knome ;) [15:48] seriously tho, congrats.. [15:48] thanks :) [15:48] i'm serious! who the heck voted for him! [15:48] wait, i did [15:48] :| [15:48] :) [15:48] my bad! [15:48] * elfy had a block vote too [15:49] * balloons says he did too [15:49] reminiscent of trade unions [15:49] balloons, you just "say", but didn't? [15:49] * elfy voted for everyone on the list [15:49] me too, just *down*voted some [15:49] har har [15:49] :P [15:49] yep.. I voted for everyone [15:49] you kind of have to do that with the CIVS [15:49] not everyone I voted for made it tho [15:50] balloons, of course not if you voted for everyone :P [15:50] knome: well you kind of do - but you could mark one as 1 and the others as last [15:50] which is kind of silly [15:50] elfy, which is the same as marking them one 1 and rest 2 [15:50] I guess [15:50] elfy, which is really close to just voting for one person regularly [15:51] it is, because CIVS is about preference [15:51] it doesn't matter if it's 1/2 or 12/13 [15:51] you still prefer the guy in 1/12 [15:51] or gal [15:51] confuses me - so I sorted everyone out :) [15:51] hehe [15:51] well that's fair as well [15:51] I put 1 through 12 in [15:51] yes, I like the system [15:51] if you can make a difference, you probably should [15:52] i couldn't on a few occasions [15:56] elfy, btw now I get to refer to you in fun ways; https://plus.google.com/104307250302998042813/posts/G8dqRSJamwL [15:56] :) [16:29] balloons, I'm just going through all the ubuntu-autopilot-tests creating a list of todo's, So first they are all going to need porting to 1.4 but what is the choice on python version are we wanting to port them to py3 at the same time. Not much really needs changing for that, so my question is rather which py version are we to suggest writing tests with going forward? [16:29] python3 :-) Starting with 1.4 we should look to python3 [16:30] that said, I've not converted any tests just yet [16:30] they have to be run with the py3 runner as well [16:31] I would say something to keep in mind.. as of now I don't know of concrete plans to rid all py2 tests this cycle [16:31] https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1249235 [16:31] Ubuntu bug 1249235 in Ubuntu UI Toolkit "Need a python3 version of ubuntu-ui-toolkit-autopilot" [Undecided,Confirmed] [16:36] balloons, ok cool, well if we are going to look to py3 for ap-1.4 for new tests then really the current ones will need to be ported at some point, so we don't have a mixture of py2/3 in ubuntu-ap-tests. [16:36] DanChapman, I would look to port them all at once I think.. the py2 -> py3 work is simple enough [16:37] balloons, thats what i was thinking [16:37] :-) [16:37] still, let's note it's something to be done :-) [16:37] not completely trivial === salem_ is now known as _salem === _salem is now known as salem_ === hggdh_ is now known as hggdh === Ursinha is now known as Ursinha-afk [17:16] balloons.. porting to Py3 is usually simple (a cutover).... but using a single code base that runs under Py2 *and* Py3 is not always simple [17:16] so if it all possible... drop Py2 [17:17] I tried to do the dual py2 and pt3 thing once [17:17] balloons, it usually the best upgrade path.. but it's tricker [17:17] trickier even [17:22] it worked for a little bit, but it was annoying. you would break one or the other quite often === Ursinha-afk is now known as Ursinha [20:04] balloons, buonasera [20:04] Letozaf_, buonasera [20:05] balloons, howzit ? [20:06] Letozaf_, good.. just looking at rssreader actually [20:07] balloons, oh thanks, was about to ask you about it [20:07] the wait_until_destroyed isn't doing it as-is, but now I'm hitting other things [20:07] wait.select_single should be wait_select_single [20:07] :-) [20:08] balloons, where, let me check... [20:08] in emulators [20:08] balloons, found it :( [20:09] balloons, I will re-run the tests [20:10] trying to use the wait_until_destroyed [20:15] balloons, I keep on getting that IndexError: list index out of range for ActionSelectionPopover [20:15] I'm not getting that at all [20:15] balloons, are you running the tests on the Desktop or the device ? [20:16] desktop for now.. I'm trying to get the activity indicator check to work [20:16] it doesn't for me atm [20:18] balloons, see this drives me mad, now I had no failures, and I didn't change the code, just re-ran the test [20:19] balloons, I'm also running them on the dekstop [20:19] Letozaf_, yes it simply means we need some more asserts [20:19] the tests don't run reliably [20:20] well, lol, it might not be asserts we need, I simplify too much [20:20] but yes, we need them to run reliably [20:22] balloons, ok, let me see if I can fix something... [20:24] hmm [20:25] I really want this activity indicator check to work [20:25] we could use it several spots [20:34] balloons, it's hard to write something on ActivityIndicator as it disappears and cannot see it in vis [20:35] balloons, I can only see the running property form the QML [20:35] right [20:35] you can do it in vis, but [20:41] hmm.. got something I like [20:41] balloons, what ? [20:43] I'll push if it works [20:43] balloons, ok [20:52] sweetness [20:52] balloons, for what ? [20:53] bzr merge lp:~nskaggs/ubuntu-rssreader-app/add-activity-indicator-check [20:54] Letozaf_, I added a _wait_for_refresh function, and tweaked the check for the activity indicators [20:54] seems to work [20:54] full test checks now, then on the phone [20:55] balloons, let me try :) [20:56] Letozaf_, what is the Not(Is([]))? [20:57] balloons, I copied it from somewhere, do not remember where, wanted to avoid a Not(Is(None)) I think [20:58] balloons, is that bad ? [20:58] Letozaf_, just different, hah.. [20:58] I'm open to why you didn't want to use a Not(Is(None)). but anyways we can probably add wait_select_single's in there instead and drop them all [21:00] so it worked, save for test_view_feed failed because the editFeed was null [21:01] probably just a timing thing.. so I think we can clean those up and hopefully be set [21:02] balloons, just ran the test now and saw the failure [21:05] balloons, weired now it worked fine all 3 tests [21:10] Letozaf_, that's not weird.. it's a timing issue, which sometimes occurs and sometimes doesn't [21:10] we need to squelch them all so it will run reliably [21:11] balloons, yes ok got it, I will run the test again an again to veryfy it does not happen, if it does fix the timing issue [21:12] Letozaf_, yep.. but basically just go cleanup anything like this: self.assertThat(editFeed, Not(Is([]))) [21:13] balloons, yea already done that [21:26] Letozaf_, alrighty :-) === salem_ is now known as _salem [21:35] balloons, nope I have two issues now, [21:35] balloons, CanonicalTopic is not removed [21:37] balloons, and I have a raise MismatchError(matchee, matcher, mismatch, verbose) [21:37] MismatchError: None matches Is(None) [21:37] balloons, if I put self.assertThat(editFeed, Not(Is(None))) [21:40] balloons, I get failure using Not(Is(None)) instead of Not(Is([])) but do not understand why [21:40] balloons, MismatchError: After 10.0 seconds test failed: != [ [21:42] Letozaf_, ohh I would do it differently.. let me see [21:46] Letozaf_, I'm changing get_feed_in_feedlist to always return something [21:46] and eliminate the check [21:48] balloons, so you will check that the feed is different form the one deleted ? [21:48] hmm.. actually not so easy [21:48] I think i will use the not is none [21:52] I'm confused by this test now [21:52] #click on list view toolbar button [21:52] toolbar.click_button("changemodebutton") [21:52] balloons, it's to change from shorts view to list view [21:54] ok, but I'm confused what you are trying to do in that test [21:54] balloons, well I think you don't have to do it, I just chose to do it [21:54] balloons, I think the test works all the same if you remove that [21:55] balloons, it was just for changing view type [21:55] Letozaf_, :-) What are you trying to do with the selecting a feed? you never make it to the edittopic tab [21:55] it's just really confusing [21:56] balloons, I was changing from the shorts view to the list view of the topics [21:57] What I'm trying to say is what does "test_view_feeds" test? [21:57] balloons, it's a way to check that it works [21:57] do we just want to make sure we can change the view? [21:57] if so, we can radically simplify this testcase [21:57] balloons, oh, it just tests that you open the feed to read it [21:57] balloons, I both test it opens a feed and changes view mode [21:58] balloons, maybe the test name should be changed [21:58] yea, we could be more desciptive [21:58] ok, so test switching the view [21:58] then open a feed and view an article? [21:58] balloons, yes [21:58] wow, ok.. good test, but I don't see where this test does that, hah [22:01] balloons, for this : https://bugs.launchpad.net/ubuntu-rssreader-app/+bug/1188713 [22:01] Ubuntu bug 1188713 in Ubuntu RSS Feed Reader App "Autopilot Testcase Needed: Test feed list view" [High,In progress] [22:01] Letozaf_, k. So, do we need to add a topic and feed first? there are default feeds [22:01] I'd guess we can use one of those [22:02] that will simplify things [22:02] balloons, I used the canonical ones as in the beginning there weren't only canonical and ubuntu ones [22:02] balloons, but also other ones [22:02] balloons, then they changed [22:03] balloons, so on every test I added the canonical feed to test on those [22:05] balloons, in other words I wanted to test the same feed on every test and so used the canonical one everywhere [22:06] balloons, added it at the beginning and tested on that one and then removed it at the end [22:07] hmm [22:07] ok, fair enough. I'll playing around with it [22:09] balloons, it's late for me now, I will be back tomorrow. let me know what you decide [22:10] balloons, going to bed [22:10] balloons, good night [22:10] Letozaf_, ciao. [22:10] thanks for your help [22:10] balloons, ciao [22:10] balloons, yw