=== duflu_ is now known as duflu === thumper is now known as thumper-afk === jono is now known as ubuntu-goldfish === thumper-afk is now known as thumper [09:01] good morning desktopers [09:04] hey! [09:04] greetings from my new markus ;-) [09:05] Laney: \o/ [09:05] didrocks: thanks for the advice! [09:05] you like it? ;) [09:06] I guess always better than the one which was broken during the week-end anyway :p [09:06] yep, enjoying the lumbar support [09:06] yesterday I was sitting on a garden chair ... [09:06] glad to hear it! [09:06] ahah ;) [09:11] Laney, didrocks: you tall guys :p [09:11] seb128: heh, sorry dude! [09:11] :P [09:11] I've to admit the support is almost ok if I sit correctly [09:11] I'm still a hunched over nerd though, so I probably won't make the best use of it [09:11] but I tend to be lazy and "slip down" a bit [09:12] especially the head bit [09:20] oh hey, webkit built on ppc [09:25] omg [09:25] another spontaneous reboot [09:28] is there any reason stated in your logs? [09:30] don't see anything in old syslog or dmesg [09:34] one of the drives took a while to mount when it rebooted [09:34] larsu, wdyt about https://code.launchpad.net/~larsu/indicator-appmenu/stop-using-stock/+merge/194872? should we just do -Wno-error=deprecated-declarations? do you want me to mp that? [09:34] maybe it's a hw problem [09:34] Laney, yeah, I was going to say that usually those are hw issues (if there is nothing sending a reboot signal/command, which would be weird) [09:37] seb128: we should just set the gtk max version, then we won't get the warnings [09:37] seb128: ah wait, this is 3.8 still. Ya, do no-error [09:37] larsu, ;-) [09:37] k [09:38] larsu, btw that makes https://code.launchpad.net/~larsu/indicator-appmenu/insert-action-groups-on-menus/+merge/194901 not merge because it depends on the other branch, you are going to need to rebase [09:39] seb128: yep I'll do that. I'm planning on catching up with MRs now anyway (charles sent me a few as well) [09:39] seb128: if you do the no-error, can you let me know when the MR is up? (I can do it too if you want) [09:48] larsu, https://code.launchpad.net/~seb128/indicator-appmenu/dont-error-out-on-deprecations/+merge/195728 [10:04] didrocks, want to help reviewing https://code.launchpad.net/~diegosarmentero/ubuntu-system-settings/click-updates/+merge/195729 ? [10:05] 42 files changed, 2762 insertions(+), 369 deletions(-) [10:05] shrug [10:05] seb128: I'm not sure I've time TBH, you are owning the system-settings more than ever I guess, so I'll let you in your capable hands :) [10:05] roooh [10:05] especially as my qml skills are not up to yours :p [10:05] didrocks, thanks :p [10:05] seb128: yw! I hope that mpt reviewed the design btw [10:05] didrocks, I see what you are doing! === vrruiz_ is now known as rvr [10:11] yeah that's quite some change! [10:13] didrocks, Laney: I did add a comment asking for a summary of the changes and some details on how to test (I hope they have mocks to simulate installs/updates) [10:14] yeah [10:14] seb128: btw, I told them multiple times to ping you (a month ago) about this intrusive change, didn't they do it? [10:15] didrocks, they pînged me like friday to ask how they summit for review/who they should ping [10:15] argh, yeah for coordination [10:15] right... [10:15] seb128: more than a month in fact from my logs [10:23] hum [10:23] seb128: resubmitted: https://code.launchpad.net/~larsu/indicator-appmenu/insert-action-groups-on-menus/+merge/195741 [10:23] telepathy-mission-control started sigabrt for me today (in the greeter apparently, get the report when I log in) [10:24] Laney, ^ did you see something like that? (I wonder if that could be the e-d-s transition, I updated to your ppa yesterday evening) [10:25] seb128: nope [10:26] :( [10:26] can you get a trace? [10:26] Laney, looking to the bt there is nothing edsish in there, tmc doesn't even depends on that stack, likely a coincidence [10:27] mmm === Ursinha-afk is now known as Ursinha [11:17] jodh: I wonder if you're interested in glancing at https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/967229 too at https://blueprints.launchpad.net/ubuntu/+spec/core-1311-boot-ui ? not sure if it fits the scope, but it's an OEM priority bug. [11:17] Launchpad bug 967229 in plymouth (Ubuntu) "Text mode shown briefly with various "cryptic" texts when logging out or shutting down" [High,Triaged] [11:18] it has already been looked at before, and the shutdown text mode issue is still there but no easy solution visible [11:26] mvo, hey, could you have a look to https://code.launchpad.net/~tjguthrie4600/ubuntu/trusty/apt/bug-1206047/+merge/195553 (should be a trivial one to review) [11:32] Laney, ok, so the new e-d-s seems fine to me ... should we upload to trusty? ;-) [11:32] won't it get blocked behind webkit? [11:32] because the new evolution requires the new webkit? [11:36] I'm thinking something might need webkit2 on arm64 [11:36] Laney, 2.2 is in trusty ... do we have anything requiring 2.3? e.g why would it block the evo stack? [11:36] * Laney checks [11:36] oh, right, 2.2 didn't build on arm64 either [11:36] nope [11:37] doesn't look like anything does though [11:37] should be fine then [11:37] well, then the transition is going to stay in proposed until we force things in or resolve the issue ... is that an issue? [11:38] means that you can't make other fixes [11:38] right, we should stay in a buggy situation [11:38] but I don't see anything depending on that at least on my system [11:38] so I think it should be ok [11:38] but it seems we should be fine, and if we are not we need to work our way out anyway... [11:39] feel free to start uploading [11:39] something should pull in e-d-s-uoa [11:39] do you have Vcs-es? or should we just take stuff from your ppa for the updates? [11:40] -uoa, I guess we should restore the e-d-s depends we had before saucy [11:40] ok, first lunch and then I look at that [11:40] no vcs right now [11:40] will push stuff as it's uploaded === MacSlow is now known as MacSlow|lunch [12:08] sil2100, reviewing zmqpp in NEW for you [12:08] License: GPL-3 [12:08] ... [12:08] Public License version 2 can be found in "/usr/share/common-licenses/GPL-2". [12:08] [12:08] version mismatch there [12:08] (not a blocker but please fix for the next upload) [12:09] seb128: ah, damn... ok, fixing that now [12:09] seb128: thanks! [12:09] yw [12:10] sil2100, it's usually fine to put the debian packaging under the same license as the upstream one btw [12:10] seb128: as mentioned before, there's a dep-tweak waiting for release as well [12:10] no need to use GPL when upstream is using BSD [12:10] Oh, ok [12:10] Thought that by default we should license GPL-3 our packaging [12:11] I've no strong opinion on that, just saying [12:11] sil2100, ok, NEWed [12:11] seb128: thank you! Pushing the fix to the packaging trunk in the meantime [12:12] Laney, do you know what's the situation of mono? do we want to follow Debian/go for the new version for the LTS? [12:12] both [12:12] directhex is going to handle it [12:12] sorry, that was not an "or" :p [12:12] it was "do we want the new version, which is what is in Debian" ;-) [12:13] ok, great [12:13] thanks [12:13] I think he plans to upload once 3.2 is in unstable [12:45] larsu, http://paste.ubuntu.com/6442592/ ... does it seems like the same lock issue? (that's a bt from indicator-session-service with indicator missing in trusty) [12:47] seb128: yes, it's waiting in a cond in g_dbus_connection_get_type [12:48] seb128: do you know when desrt is planning on fixing this in glib? He said something about this cycle [12:49] larsu, need to ask him again, we didn't talk about it since Montréal [12:49] larsu, I wonder why that's still happening with the workaround :/ [12:52] seb128: good question. Is that from a version after the fix landed? [12:52] larsu, it's trusty, let me check again, but I think yes [12:53] seb128: no, it seems earlier [12:53] from your bt: indicator-session-12.10.5+14.04.20131029 [12:53] and the commit is from November 5th [12:54] and didn't land in trusty yet?! [12:54] larsu, hum, another case where saucy is more uptodate than trusty [12:54] * larsu suspects his checkout is borked [12:54] https://launchpadlibrarian.net/155247618/indicator-session_12.10.5%2B13.10.20131004-0ubuntu1_12.10.5%2B13.10.20131023.1-0ubuntu1.diff.gz [12:54] seb128: shouldn't that autoland?` [12:55] larsu, let's not start another argument on the landing ask table, we had one a few days ago here (one part of the issue atm is that CI has been moving to the datacenter and offline for > week and they didn't prepare the migration well so there are still fallouts) [12:55] larsu, there is no autolanding anymore :-( we are still under landing ask rules [12:56] seb128: sorry to hear. I won't start another discussion. I was just curious. === MacSlow|lunch is now known as MacSlow === alan_g is now known as alan_g|lunch [13:06] didrocks, so we really need to land some indicators fixes to trusty (basically stuff that got SRUed in saucy but didn't made it to trusty yet due to CI migration etc) ... what do you recommend doing? do you think we should try to get an indicator stack landing or just do some selected uploads with merging back changelogs to trunk. [13:06] ? [13:20] seb128: if you can list on the landing ask the components to upload, I'll assign that to ken to selection for today's [13:20] (and we'll used cu2d) [13:20] use* [13:21] (sorry, was in hangout for the landing btw ;)) [13:21] seb128: btw, I'm going to launch a general build. Maybe you want to publish system-settings before? [13:27] didrocks, yeah, let me have a look (I went for lunch while it was still building) [13:28] didrocks, @re indicator; the thing is that indicator trunks are migrated to use upstart management, which requires the indicator stack to land synchronize with e.g unity-greeter and other stuff I think [13:28] do we feel like we are ready to tackle this one? [13:28] seb128: I think we are, just need to carefully have the list of everything needed :) [13:29] (I think we'll have one image with only that, but it's fine) [13:29] ok === olli_ is now known as olli [14:08] seb128: can I run the global build? [14:08] didrocks, oh, sorry, got sidetracked ... give me one minute, thanks! [14:09] seb128: keep me posted :) [14:09] didrocks, or rather give me a bit more, I just remember why I got sidetracked :p [14:09] seb128: heh, ok ;) [14:09] didrocks, I wanted to check with kenvandine if he tested the current online account version [14:09] there are quite some changes in there [14:09] kenvandine, hey! [14:09] ah, ok! [14:09] hey [14:10] i tested them in little chunks :) [14:10] kenvandine, I wanted to do a settings stack publication [14:10] kenvandine, how confident are you that the current trunk if working as it should? ;-) [14:10] seb128, for uss-oa? [14:11] * kenvandine checks trunk [14:11] kenvandine, yes [14:11] very confident [14:11] ok [14:12] i tested that on the device before it merged, only change since then was the translation merge [14:12] kenvandine, thanks [14:12] kenvandine: hey! btw, you have Mir on your feet with robru (you should have all infos on the landing spreadsheet, we need to work with the CI guys to get one merge done before building Mir) ;) [14:12] kenvandine: so, just one thing to land (well 4 components), but that will be already a big win! [14:12] 4 scary components ;) [14:12] ;) [14:13] kenvandine: communicate heavily with the CI guy to ensure that the MP is merged [14:13] please oh please ;) [14:13] cyphermox, hey, can we get the indicator stack published to trusty this week? [14:14] didrocks, hum, does that look fine? [14:14] $ ./cu2d-run -P settings [14:14] 2013-11-19 15:12:35,678 INFO Triggering build: cu2d-settings-head === alan_g|lunch is now known as alan_g [14:14] didrocks, why "triggering build"? [14:15] http://q-jenkins.ubuntu-ci:8080/view/cu2d/view/Head/view/Settings/ doesn't seem to change [14:15] seb128: just checked, generic message [14:15] so, we're fine :) [14:15] ok [14:15] the web view is not changing though [14:15] maybe taking a bit? [14:15] not changing? [14:16] started 3 minutes ago [14:16] nah it should be just about instant [14:16] I guess it's your run? [14:16] didrocks, why is the publish still yellow then? [14:16] seb128: did you force the publication? [14:16] you have packaging changes [14:16] I did [14:16] $ ./cu2d-run -P settings [14:16] which is what https://wiki.ubuntu.com/DailyRelease/FAQ has for "Forcing a stack publication" [14:17] argh, this part isn't up to date [14:17] it's been a long time you didn't publish :) [14:17] --force [14:17] * didrocks updates the wiki [14:17] right [14:17] thanks [14:17] seb128: updated, thanks! [14:18] didrocks, still not correct :p [14:18] seb128: didrocks: starting indicators nao [14:18] seb128: urgh? how? [14:18] seb128: do you have latest lp:cupstream2distro? [14:18] didrocks, it wants me to list the sources [14:18] didrocks, KeyError: 'projects' [14:18] yeah, you need to specify which packages [14:18] args = {'ON_PACKAGES': kwargs['projects'], # optionnally only publish those projects [14:18] logging.error("You can only specify partial projects to publish with the force parameter. Otherwise, use a normal publication.") [14:18] ah indeed :) [14:18] seb128: I force that :p [14:19] seb128: i'll have a look, please use the webui ;) [14:19] didrocks, oh, right, you told me that last time, I remember ;-) [14:19] didrocks, cyphermox, kenvandine: ok, it worked this time, thanks! [14:19] yw! [14:20] cyphermox: I'm rebuilding everything first [14:20] cyphermox: to stress the system a little bit :) [14:20] ah, ok [14:20] I'll wait then... since you'll rebuild indicators for4 me [14:20] yep ;) [14:20] doing it all 4 you! [14:21] :) [14:21] weee [14:23] seb128: do we have the list of what needs to be released at the same time for indicators? [14:24] tedg, ^ [14:25] tedg, hey, what needs to be lock-released for the indicators/upstart transition? indicators-*, unity-greeter ... what else? [14:26] seb128, didrocks, really as long as the greeter goes first, everything else can go anytime after. [14:26] tedg, the greeter can alone before indicators? [14:26] mterry, hey, can we get an unity-greeter upload with upstart support? [14:26] seb128, Yeah, it'll dbus-activate them as a fallback. [14:27] seb128, that landed in trunk, right? You just want an upload to trusty? [14:28] mterry, tedg: ignore that, it's already in trusty, robert_ancell did an upload for the session dialogs [14:28] tedg, are untiy7/unity8 in trusty both ready as well? [14:28] seb128, Yeah, they were ready in saucy :-) [14:28] tedg, thanks [14:29] didrocks, cyphermox: ok, so seems like we are ready, we can lead indicators without anything else [14:29] \o/ [14:30] yay [14:30] stay tuned for the surprises Mark was sad to not see in saucy :) [14:31] * tedg is on it [14:31] seb128: tedg: thanks! [14:32] yw! [14:36] Laney, kenvandine, tedg, charles, cyphermox: btw the touch settings vUDS session is in half an hour, would be nice if you could come ;-) (I'm not sure what to discuss, out of going over the plans for the cycle and ask if anyone has feedback) [14:37] mmm, ok [14:37] Laney, "mmm"? ;-) (yeah, same here, I'm not the one who put that session on the schedule :p) [14:37] seb128, K, I wasn't planning on doing the hangout, but I was going to watch :-) [14:37] seb128, i'll be there [14:38] tedg, please come, so we can get something going on [14:38] * seb128 not sure how we can fill the hour [14:38] * tedg works on his singing [14:38] kenvandine, tedg, Laney, charles: bonus point if some want to talk about the stuff on their todo for the cycle [14:40] karaoke hour? [14:40] wfm if you guys want to sing [14:40] * seb128 is not going to sing, enough rain this month [14:40] seb128: tedg will be able to talk with no content for an hor, don't worry :) [14:42] * tedg starts humming "I'm too sexy for this hangout, too sexy indeed!" [14:42] lol [14:45] bah, firefox became a piece of crap since chrisccoulson stopped maintaining it :/ [14:45] it keeps hanging for me for some weeks [14:45] seb128: can you set up the hangout? [14:45] :( [14:45] Laney, now? [14:46] might take me a while to get in [14:46] * Laney coughs [14:46] lol [14:46] seb128, try setting "ui.use_unity_menubar" to false in about:config [14:46] Laney, give me some minutes [14:46] it massively speeds things up for me and jdstrand [14:46] chrisccoulson, lol, you are joking right? ;-) [14:46] seb128, no, the hud keeps requesting menus [14:47] chrisccoulson, well, it's not slow, it's locking (e.g I had Mark's keynote in a tab and that stopped doing audio) [14:47] and I've no bookmark [14:47] or almost none, like 30 [14:54] that's a fun u-s-s landing [14:56] Laney, I hope "fun" doesn't mean buggy :p [14:56] haha [14:56] a lot of it is mine, so definitly zero bugs there :-) [14:56] ;-) [14:59] Laney, kenvandine, tedg, others: https://plus.google.com/hangouts/_/76cpi5e1q127qe0elqtkkts9ls?authuser=0 [15:00] seb128, thx [15:00] shrug, pad not working? [15:00] "404 not found: /ep/pad/view/uds-1311-client-s-system-settings-panels/latest" [15:00] seb128, didn't jono say something about there being a button to join the hangout? [15:00] * kenvandine looked all over for it... [15:00] kenvandine, I need to add the hangout URL to summit first for that I guess [15:00] ah... so it's your fault :) [15:00] doesn't work [15:01] going to have to piss about [15:01] ALL PART OF THE CANONICAL CONSPIRACY [15:01] oops [15:01] I mean, hey guys [15:01] haha :) [15:01] jono, hey, do you know about the pad not working? [15:01] jono, You should really disable that hotkey [15:01] seb128, should work, ask mhall119 he takes care of summit [15:01] tedg, lol [15:02] I have an XChat plugin that has a direct line to my brain [15:02] hence, not much content on IRC [15:02] seb128: go to pad.ubuntu.com and login with SSO [15:02] SSO no longer supports the login redirect within an iframe [15:02] jono, Then for music you pipe it through autotune, for documents through autocorrect? ;-) [15:02] tedg, absolutely [15:02] mhall119, I'm logged in with sso [15:03] can you hear me on the hangout? [15:03] guessing not [15:03] FOR GODS SAKE === alan_g is now known as alan_g|tea === mjohnson15_2 is now known as mjohnson15 === alan_g|tea is now known as alan_g [15:44] kenvandine, hum, I think we didn't take notes for the background since we rediscussed it with mpt later on (and nobody took notes then) [15:44] kenvandine, can you just add some to the blueprint? [15:45] kenvandine, in fact I had those notes in http://pad.ubuntu.com/settings-saucy [15:45] oh, ignore that, those are the testing items [15:46] seb128, i will [15:50] kenvandine, thanks === bdrung_ is now known as bdrung [16:11] seb128: hello! :) [16:11] sil2100, hey [16:11] seb128: could you take a look at a packaging-review merge I made and do a preNEW review for this package basing on this branch? [16:11] seb128: https://code.launchpad.net/~sil2100/unity-scopes-shell/packaging_review/+merge/195815 <- in preparation for daily-release [16:14] Thanks! [16:19] sil2100, the debian/rules change seems backward, but didrocks likes it this way, right? [16:21] yeah I dislike that standard, it's weird [16:21] it hides what the fail-missing is doing [16:22] seb128: I guess so, I remember that we settled on this format of using --fail-missing, so it's something like a standard for us [16:22] sil2100, what's the motivation? just make the rules a bit shorter? [16:24] seb128: yes [16:25] seb128: it might be a bit non-optimal since it gets passed to every dh wrapper, but well... [16:27] sil2100, yeah, it seems wrong optimization, do the wrong thing to spare a line in rules [16:28] seb128: I guess I can revert that back to the dh_install override, since we allowed that as well - just wanted to make it consistent with the last packages ;) [16:28] sil2100, let's wait for that session to finish and discuss it with didrocks [16:28] But it's certainly not something I would block on, since I don't care about either approac ;) [16:37] seb128: in the meantime! I think this package got already preNEWed by either you or didrocks, but could you just take a look if lp:ubuntu-settings-components is ok? [16:37] sil2100, sure [16:37] seb128: thank you! ;) [16:38] seb128: I think I did some packaging fixes some time ago, before trusty even [16:38] cyphermox_, could you look at https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1198315 to see if it's an nm or g-c-c issue? [16:38] Launchpad bug 1198315 in gnome-control-center (Ubuntu) "[network]: gnome-control-center crashed with SIGSEGV in append_escaped_text()" [Medium,Confirmed] [16:38] cyphermox_, ssid_text = 0x7f97df57dec0 "B\374ro" [16:38] the code does [16:38] ssid = nm_setting_wireless_get_ssid (NM_SETTING_WIRELESS (setting)); [16:38] ssid_text = nm_utils_escape_ssid (ssid->data, ssid->len); [16:38] title = g_markup_escape_text (ssid_text, -1); [16:39] cyphermox_, it looks like nm_setting_wireless_get_ssid() returns an non UTF8 string ... is that considered as nm bug? [16:51] seb128: maybe not. you could have SSIDs with weird caracters [16:52] cyphermox_, https://projects.gnome.org/NetworkManager/developers/libnm-util/09/libnm-util-nm-utils.html#nm-utils-escape-ssid says [16:52] "simply replacing embedded NULLs and non-printable characters with the hexadecimal representation of that character. " [16:53] right [16:53] non-printable [16:53] desrt, is g_markup_escape_text("B\374ro", -1) valid? [16:53] https://launchpadlibrarian.net/144270915/Stacktrace.txt [16:54] 374 is ʹ [16:55] cyphermox_, is there a way to "emulate" a ssid? [16:55] what do you mean? === cyphermox_ is now known as cyphermox [16:55] cyphermox: like to make nm believes I've a ssid "bugʹs ssid" [16:55] not really no [16:55] create one with another system as a ad-hoc network? [16:55] I guess I need to change the config of one of my aps to test :p [16:57] seb128: just to clarify, I should see a capital Y circumflex? [16:57] cyphermox, no [16:58] cyphermox, go in gucharmap and search for 374 [16:58] U+0374 GREEK NUMERAL SIGN [16:58] it's a fancy "'" [16:58] mmkay [17:03] seb128: yeah, finished the session [17:04] seb128: yes? [17:04] desrt, does the bt there makes any sense to you? [17:05] seb128: nope :) [17:05] :-( [17:05] the code is [17:05] ssid = nm_setting_wireless_get_ssid (NM_SETTING_WIRELESS (setting)); [17:05] ssid_text = nm_utils_escape_ssid (ssid->data, ssid->len); [17:05] title = g_markup_escape_text (ssid_text, -1); [17:05] and somewhat it doesn't like what seems like nonutf ssid [17:05] well I assume that from the bts we have [17:05] ssid_text = 0x7f99a6e75ec0 "AgnetaBj\366rn" [17:06] oh. interesting. [17:06] "B\374ro" is actually someone's ssid? [17:06] yes ;-) [17:06] okay [17:07] that's definitely invalid, by the docs [17:07] g_markup_escape_text() says it only takes utf8 [17:07] that said, i'm not sure what it would be doing internally that would make a difference [17:08] (0x7f <= c && c <= 0x84) || [17:08] (0x86 <= c && c <= 0x9f)) [17:08] really gmarkup? really? [17:08] seb128: ... btw, I think you have the wrong chars [17:08] desrt, the bt has \374, I don't know if that means "\" "3" "7" "4" or the "\374" [17:09] cyphermox, could be [17:09] this is octal [17:09] when you look it up in charmap you need to convert to hex [17:09] not that it would make much of a difference though [17:09] but it's valid utf8 AFAICT [17:09] either way, it has a high bit set and it's a single byte [17:09] ain't no way that's utf8 [17:10] and the inner loop there does a lot of g_utf8_get_char() [17:10] which could easily crash on that byte [17:10] uh, right [17:10] i hate this loop [17:10] it's doing utf8 processing for excessively trivial reasons [17:10] we're looking at U+00FC and U+00F6 [17:10] either it should step up its game and do proper handling of unicode non-printables or it should just deal in ascii [17:11] cyphermox: you could just escape everything outside of 0x20..0x7f [17:11] ie: ascii printable range [17:12] desrt: well, g_markup_escape does get escaped stuff [17:12] cyphermox: but the input to nm_utils_escape_ssid() can clearly be non-utf8 [17:12] I wonder if "\374" is one non utf symbol or if it's the marker expressed over 4 chars [17:12] and it doesn't do its escaping in a way that will convert non-utf8 into valid utf8 [17:12] seb128: that's an octal escape, for sure [17:13] itś ü and ö [17:13] nothing fancy [17:13] desrt, https://projects.gnome.org/NetworkManager/developers/libnm-util/09/libnm-util-nm-utils.html#nm-utils-escape-ssid says [17:13] " simply replacing embedded NULLs and non-printable characters with the hexadecimal representation of that character. " [17:13] right [17:14] ....when in doubt [17:14] use the source [17:14] while (len--) { [17:14] if (*s == '\0') { [17:14] *d++ = '\\'; [17:14] *d++ = '0'; [17:14] s++; [17:14] } else { [17:14] right [17:14] *d++ = *s++; [17:14] also [17:14] * This function does a quick printable character conversion of the SSID, simply [17:14] * replacing embedded NULLs and non-printable characters with the hexadecimal [17:14] * representation of that character. Intended for debugging only, should not [17:14] } [17:14] * be used for display of SSIDs. [17:15] this function does more or less nothing [17:15] other than "\0" -> "\\0" [17:15] I guess bugs in nm for not doing what the API says [17:15] and g-c-c for using it [17:15] title = g_markup_escape_text (ssid_text, -1); [17:15] this is g-c-c code? [17:16] desrt, yes [17:16] bug is _entirely_ in g-c-c [17:16] n-m is doing exactly what it says it will [17:16] g-c-cjust shouldn't be using nm_utils_escape_ssid [17:16] well, nm_utils_escape_ssid () should return valid utf [17:16] yup [17:16] seb128: says who? [17:16] * desrt sees no docs to this effect [17:16] that would make sense :p [17:16] the only docs i do see say "don't use this" :p [17:16] right [17:17] I'm going to GNOME upstream that [17:17] desrt, cyphermox: thanks [17:17] seb128: well... if you want to assume that it returns valid utf8 without having explicitly said it then you'd also assume that you must pass valid utf8 without it being explicitly stated, as well [17:17] and if you pass valid utf8, it would return valid utf8.... [17:17] I got confused by the "simply replacing embedded NULLs and non-printable characters with the hexadecimal representation of that character." [17:18] but non printable != invalid utf8 and hexadecimal representation !⁼ valid utf8 [17:18] 'printable' has no proper definition here [17:19] btw https://developer.gnome.org/libnm-util/unstable/libnm-util-nm-utils.html#nm-utils-ssid-to-utf8 [17:19] admittedly, the docs are a mess as well [17:19] cyphermox wins [17:19] except jesus.... dude... GByteArray? ouch. [17:19] hehe [17:19] i guess GBytes didn't exist [17:19] you get used to it if you deal with NM :) [17:19] (GBytes = best API on earth, btw. use it.) [17:20] fun [17:20] it's exactly what you want in situations like this [17:20] anyway, that's another debug-only function though [17:20] no. it's not [17:20] it says: [17:20] Again, this function should be used for debugging and display purposes _only_. [17:20] note "...and display purposes" [17:20] which i think is what they're going for here? [17:20] ah, indeed, EPARSE [17:21] yeah, seems like it's what's needed, probably [17:21] cyphermox, do you want to make the patch/file the bug there? [17:21] seb128: yeah [17:21] cyphermox, thanks [17:21] is that for SRU as well? [17:22] cyphermox, let's get it fixed in trunk/trusty to start [17:22] yes, I see [17:22] cyphermox, it doesn't seem ranked high enough on e.u.c to SRU it [17:22] * cyphermox starts editing his wifi config [17:22] cyphermox, I mostly picked it up because an user filed a bug on launchpad about not being able to open the control center panel and has been active on the report [17:23] the real source of this bug is ieee [17:23] for failing to define a character set for use with 802.11 [17:23] d'oh [17:24] macs and linux use utf8 [17:24] windows uses whatever the system characterset is [17:24] desrt: my router with linksys firmware enforces ascii >.< [17:24] ie: probably some iso-8859-n variant [17:24] no [17:24] cyphermox: that's a pretty reasonable solution :) [17:24] sil2100: the QPA plugin is mentioned at the http://summit.ubuntu.com/uds-1311/meeting/21986/core-1311-qt5-versions-in-ubuntu/ session in 1.5h [17:24] (the blueprint of it) [17:24] windows uses a weird-ass charset, at least it does in java [17:24] cyphermox, just hack the code to inject a fake ssid? :p [17:25] to test the patch [17:25] seb128: I'll just grab another wireless router [17:25] cyphermox: i'm pretty sure it depends on what language you're using [17:25] Mirv: awww... :< [17:25] I have multiple [17:25] unless they just hardcode to latin1 [17:25] desrt: guess it could be the case [17:25] Mirv: I thought it will be tomorrow or something... [17:25] i know my ssid shows up as one of those weird Å© type things when i view it on a windows machine [17:25] I recall it wasn't latin1 or iso*, something weird, because I would get java source files all garbled with french accents missing [17:25] (it has a é in it) [17:26] and I'd headdesk everytime I'd be asked to write comments and code in french :/ [17:26] cyphermox: but this is quebec, man!! [17:26] erm... [17:26] québec, sorry [17:26] sil2100: there's another session tomorrow, but this one is about the co-operation with eg. Kubuntu and upstream [17:27] :< [17:27] desrt: yeah, but you have no idea how much of an effort it is when coding to think of using french variable names and commenting in french [17:28] electroshocks, like [17:28] hmmm.. no router in sight [17:29] Mirv: I might try being around in like 1.5h [17:31] didrocks, did you read the scrollback about debian/rules --fail-missing use? [17:31] Mirv: will you be on the meeting as well? Since it has to be like, late-night at your place then [17:33] seb128: yeah, seems like it's the preferred way for all the packages I encountered on debian, and it's less lines for simple packages, so seems to make more sense to me [17:34] one line with all the rules instead of 3 [17:34] I'm not too attached to it, but I prefer we follow the same rule if possible everywhere :) [17:35] didrocks, ok, I'm not going to argue over it, feels buggy though ;-) [17:35] you've seen that in debian?! [17:35] why? it's the way dh defines parameters like --parallel [17:35] Laney: yeah, it's where I've seen it first, I will need to grep though [17:36] don't bother [17:36] I always thought it was odd though [17:36] didrocks, because --fail-missing is not a dh parameter, it's a dh_install one [17:36] fail-missing is an argument to one particular script, not to dh in general which --parallel is [17:36] seb128: valid argument, again, I don't care too much, I just don't want that we bring confusion to upstream, so do whatever you think is the best [17:37] * Laney apt-get dist-upgrade → new u-s-s [17:37] \o/ [17:37] nice to see updates rolling in :) [17:37] sil2100: I have to I guess, but it'll be the very last thing before sleep [17:38] kenvandine: all spots on you for Mir! :) [17:38] didrocks, it's building [17:38] I hope "nicely building" :) [17:38] i hope... i couple hours ago it failed to build in the ppa [17:38] test failure [17:58] Laney, so for eds and co, should I just get the source from your ppa, tweak the versions and "sponsor" the uploads? (e.g debsign&dput) === alan_g is now known as alan_g|EOD [17:59] seb128: yeah, and do what you want with uoa [17:59] I tried to make it so that most of the upload could be copied (not binaries) out of the PPA [17:59] but some failed to build so I mangled the versions [17:59] if you want I'll work on the uploads tomorrow though [17:59] Laney, you current build it as a separate package and don't pull it in if I'm correct? that seems what we should do until issues are resolved [18:00] yeah [18:00] a non-default option, seems ok to me [18:00] Laney, today/tomorrow ... your call [18:00] I guess we can wait tomorrow morning [18:01] to point starting a transition just before eod [18:01] if we start in the morning we might have it done by the end of the day [18:02] that'd be smooth [18:02] yeah, let's see what happens :p [18:03] alright on that note, got to go cook some steak [18:03] (ping jasoncwarner_ ;-) [18:03] see you! [18:33] sil2100, ubuntu-settings-component has GPLv3 sources that need to be listed in the debian/copyright or relicensed (mostly the tests), needs a COPYING.GPL as well if you keep the GPL sources [18:34] seb128: ok, will fix that in a moment, thanks for the review! [18:34] sil2100, uw [18:34] yw [18:44] seb128: btw, many indicators ftbfs due to missing b-deps or failed tests, I'll look at them again shortly [18:44] cyphermox, do you have an example? [18:44] sure [18:44] https://launchpadlibrarian.net/156926877/buildlog_ubuntu-trusty-i386.indicator-keyboard_0.0.0%2B14.04.20131119-0ubuntu1_FAILEDTOBUILD.txt.gz [18:44] what sort of missing b-d? [18:44] well, I was unclear [18:44] accountsservice vala can't be found [18:45] shrug, that one is due to the new accountsservice [18:45] yeah [18:45] I'll do the merges, just want to finish with g-c-c first to get that out of the way [18:45] ok [18:45] cyphermox, attente: that's the issue there [18:45] http://cgit.freedesktop.org/accountsservice/commit/?id=17af4612e877c3a5c6bff67064d648f0eb2ea0cc [18:46] * cyphermox sigh [18:46] so I guess we should put a copy of that vapi in indicator-keyboard? [18:46] sounds right [18:46] attente, can you do that? [18:46] i'll add it [18:46] attente, thanks [18:46] sure [18:46] this is bs... so much code duplication for no good reason === Rodge is now known as Rodge_ [19:06] seb128, Laney, did one fo you want to join the developer mode session (including UI enablement etc) [19:07] ogra_, I can't, I'm hosting client 1 :/ [19:08] seb128, what about Laney then ? [19:09] ogra_, he was talking about going for dinner, not sure if he's still around/was planning to join that one... [19:09] Laney, ^? [19:15] cyphermox, seems to fix it: https://code.launchpad.net/~attente/indicator-keyboard/add-accountsservice-vapi/+merge/195847 [19:53] * didrocks waves good evening and good night === dpm is now known as dpm-afk === alex-abreu is now known as alex-abreu|afk === tkamppeter_ is now known as tkamppeter === thumper is now known as thumper-afk