=== jono is now known as ubuntu-goldfish [09:50] good morning all [09:51] morning [09:52] morning ochosi. Good to have you here because I noticed that there's a correction that has to be made to the formatting of http://docs.xfce.org/apps/parole/usage [09:53] ochosi: right now the audio section isn't formatted as a title, it's in the continuation of the last paragraph of the DVD section [09:53] brainwash: i know that currently the screen gets blanked twice, it even gets blanked twice on every display. kinda busy atm so i don't know when i'll really get to looking at the background-setting you mentioned ... [09:55] slickymaster: thanks, good catch! fixed [09:55] ochosi: ^^^^ [09:55] ochosi: np [09:55] knome: ping [09:56] slickymaster: i just realised now, but we'll have to add a "playback" section to the keyboard shortcuts [09:57] "Right arrow" > skip ahead 10secs [09:57] etc [09:58] ochosi: you mean another table named playback to that section? [09:58] yeah, i'm currently working on it [09:58] thought i'd just quickly chuck it in, it's rather easy to do [09:58] ochosi, if you feel like there's already plenty in your hands to deal with, I'll be glad to do it for you [10:00] slickymaster: actually, yeah, if you can/want... :) [10:01] i'll have to link you to the section of parole's code though that explains that [10:01] ochosi: No worries, I'll do it [10:01] I would appreciate the link [10:03] they start here: http://git.xfce.org/apps/parole/tree/src/parole-player.c#n2441 [10:04] and: seek_short = 10, seek_medium = 60, seek_long = 600 [10:04] (seconds) [10:04] as you can see there are more shortcuts that aren't in the docs right now [10:04] (f for fullscreen) [10:04] (p for playpause) [10:05] ochosi: I'll add those to the already existing tables [10:07] ochosi: I'll need just another thing though, the link to bluesabre's dokuwiki. I've lost it :( [10:09] hehe, no worries [10:10] slickymaster: http://smdavis.us/doku/doku.php?id=usage&#keyboard_shortcuts [10:11] ochosi: thks [11:30] ochosi: mmh, simply move the first set_background call and use it as fallback if there is no user background set via accountsservice? [11:31] ochosi: well, currently I simply commented the first call :D [11:31] out [11:32] but you will have to fix this, because it does cause the strange unblank behavior on two different systems [11:33] bug report required? [11:40] looks familiar -> http://ubuntuforums.org/showthread.php?t=2188790 === brainwash_ is now known as brainwash [11:55] slickymaster, pong [11:56] knome, good morning [11:56] g'day [11:56] brainwash: ok, i'll try to check it a bit later today then ;) [11:57] so I've speak with balloons regarding https://bugs.launchpad.net/ubuntu/+source/xubuntu-docs/+bug/1251332 and his opinion is that he should go with [11:57] sudo -i to get to a root prompt and there launch whatever graphical application [11:57] Ubuntu bug 1251332 in xubuntu-docs (Ubuntu) "Use of gksudo in Chapter 7. Printing and Scanning" [Undecided,New] [11:58] knome: so, if there's no objections from you I'll go ahead with that to re-write the documentation [11:58] slickymaster, ok [11:59] knome: I'll do it then and later on I'll propose a merge [12:04] slickymaster, ok, thanks [12:06] knome: np [12:57] brainwash: wanna show me the patch that worked for you? [13:24] ochosi: there is none yet, I simply commented out the first set_background call [13:24] that one was actually added to help with nouveau drivers when setting the background... [13:24] that's obviously not the best solution [13:25] it's a bit of a tricky situation, not everything seems to work with all drivers [13:25] I mean the part in the main function [13:25] to set the background which is specified in the config file [13:26] which is why i'm a bit hesitant to touch this stuff, i only have one laptop to test things on [13:27] well, create an extra branch :) [13:27] I can test it [13:28] hmpf yeah, all rather time-consuming and much tapping in the dark [13:34] what's this bug about backgrounds? [13:38] ali1234: well it's an issue in lightdm-gtk-greeter [13:38] lightdm always faded nicely from the default background to the user specified one for me [13:38] i thought it was supposed to do that [13:38] what greeter are you using? [13:38] i guess unity-greeter, right? [13:38] yeah [13:38] (lightdm-gtk-greeter doesn't fade) [13:38] what's the difference? [13:39] i thought unity used lightdm [13:41] lightdm is the display server [13:41] the rest are greeters [13:41] so the greeter is like a modular component? [13:41] yeah [13:41] ok, got it [13:41] the visual component [13:41] so the lightdm-gtk-greeter was written by ligthdm's author as a reference greeter [13:41] so who else uses the gtk one? [13:42] bluesabre and me picked it up and started improving it bit by bit [13:42] lubuntu i think [13:42] and maybe even distros outside ubuntu [13:42] (i think lunar linux, not sure anymore) [13:43] any reason why we don't use unity-greeter? [13:43] it's pretty nice... [13:43] well, firstly it depends on indicators [13:44] which we couldn't use for ages now [13:44] basically since they were ported to gtk3 [13:44] i think -gtk-greeter fits better with our style anyway, at least now that we've worked with it [13:45] the other thing is that the gtk-greeter is a component we control, so we can also introduce changes that make sense for xubuntu [13:45] e.g. introducing screen-blanking in case it's used as a lockscreen would be somewhat harder to get into unity-greeter [13:45] random: if the greeter can read the user's background, can it also read their theme? [13:46] it can read whatever accountsservice allows [13:47] accountsservice documentation isn't online except in source form [13:47] yeah, it's indeed not very well documented (it's been a while since i dealt with it) [13:48] and the package doesn't include the built docs [13:48] oh, and the user-wallpaper isn't in accountsservice upstream [13:48] so pretty much no chance then [13:48] that's an ubuntu-specific patch that never made it upstream (for whatever reason [13:48] ) [13:49] so anyway... if we can't fix the double background bug, how about implementing the fade/transition instead? [13:50] why can't we fix it? o.o [13:50] well, it sounds like the code is a bit fragile with all different drivers === olli_ is now known as olli [13:55] so we should disable the accountsservice part? [13:57] i'm not sure why we should disable the accountsservice part [13:57] it's not fragile at all [13:57] fix it then :) [13:57] yeah, i said i'll try to do so once i have more time [13:57] and testing resources are quite limited for me also [13:58] i already added a patch recently that should improve things, but it seems it doesn't work for everybody [13:58] I can write a patch (the way I like it to be fixed) [13:58] sure, go ahead [13:58] we can do it in a branch and try to get some testing [13:58] i'm all for fixing things [13:59] ali1234: fwiw, transitions and fades tend to produce lots of code. be my guest if you wanna submit a patch ;) (you could even use parts of thunar-desktop i guess) [14:01] is this thing really only 2000 lines of C code? [14:02] hehe [14:02] well personally i think if we wanna do fancy stuff like that, we should switch to the html engine [14:03] or even just fork unity-greeter and make it behave/look the way we want... [14:03] so every time you change the user selection it changes the background too [14:04] yup [14:05] making it do a fade would probably add like 5 lines of code [14:06] i'm totally happy to test and merge patches ;) [14:08] i am confused what this is supposed to achieve: http://bazaar.launchpad.net/~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk/view/head:/src/lightdm-gtk-greeter.c#L1310 [14:10] what do you mean specifically? [14:10] the if(!matched) part [14:10] (just as a note in advance: as i mentioned before, we're not the authors of the greeter, we're just maintaining it as it was dropped by robert_ancell a longer while ago) [14:10] if you type a wrong username, it uses the first user's background? [14:11] well [14:11] the thing is: in xubuntu we use the user-list (in e.g. debian they don't they use the user-entry) [14:12] with the user-list, you could only type a wrong username when using "other" [14:12] as a few of the last patches by our debian maintainer have shown, we didn't really take care of the user-entry enough [14:12] actually, i understand it [14:12] oh, ok [14:12] it's the initially selected user [14:14] what if there are no users though? [14:15] something to test: install in a vm, usermod your UID to <1000, see if greeter crashes [14:19] is there some kind of testing harness for this? [14:20] "lightdm --test-mode --debug" apparently [14:21] indeed, it shows the bug [14:23] hm [14:25] so where do you maintain it if upstream dropped it? [14:25] in the same place, bzr [14:25] (i meant launchpad) [14:25] ok [14:26] lp:lightdm-gtk-greeter [14:31] what do all the files in /etc/lightdm/*.conf do? [14:34] you can use them to select the greeter / configure lightdm / configure the greeter/s [14:34] so how do i make it load ~/Source/lightdm-gtk-greeter/src/lightdm-gtk-greeter [14:34] so e.g. in /etc/lightdm/lightdm.conf you can select the greeter [14:35] did you install the greeter? [14:35] or what setting do you want to change specifically? [14:35] i want to use the greeter i just built without installing it [14:36] ah... it needs a .desktop file specially named [14:38] hmm that's interesting [14:39] it looks very different with default settings [14:39] yeah [14:39] it does [14:39] lack of icon-theme, gtk-theme etc are the usual issues [14:40] i considered providing a good fallback gtk-theme [14:40] it looks ok [14:40] yeah, could be better though [14:40] just different [14:40] and also some fallback icons, to be sure [14:40] otoh so far no-one has complained about it ;) [14:41] to be honest i think i prefer the defaults to the way xubuntu configures it [14:45] fine by me [14:45] we considered letting greeter-themes even change the UI file [14:46] in general, it wouldn't be hard to ship multiple configuration files and let the user choose [14:46] so why does it look different even after make install? [14:47] because the xubuntu config file isn't in the bzr repo [14:47] but it is still in my filesystem [14:47] not sure i get it [14:47] if you install the greeter, it overwrites the lightdm-gtk-greeter.conf file [14:48] as in: the one that was shipped with xubuntu-default-settings [14:48] it didn't [14:48] then you didn't add prefix=/usr maybe? [14:48] /etc/lightdm/lightdm-gtk-greeter.conf is unchanged [14:48] maybe wrong prefix, it should change that file [14:49] oh i see [14:49] so it's really reading the config from somewhere completely different because i built it with the wrong prefix [14:50] yeah, i'd say so [14:50] yeah, fixed [14:51] good === cyphermox_ is now known as cyphermox [17:11] I'm going to have to look at LP Bug 1252800 later today [17:11] Launchpad bug 1252800 in xubuntu-docs (Ubuntu) "/usr/share/xubuntu-docs/about/xubuntu-index.html packed in Trusty Daily still refers to Xubuntu 13.10" [Undecided,New] https://launchpad.net/bugs/1252800 [17:12] skellat, new doc package isn't uploaded to trusty yet. [17:18] knome: I'm not 100% sure, but apparently no [17:54] ok, so what exactly is so terrible about simply not making the first call to draw the background? [17:55] if it fixes some driver bug, what about if we draw a black background here instead [17:55] and then draw the user or default background later [17:56] tbh i think the call didn't really help with nouveau [17:56] so i think we can also look into restructuring that [17:57] i can't see a reason why just skipping that draw will hurt anything [17:57] but drivers are weird so who knows [17:57] yeah, they are... [17:57] well i'd suggest we work in a branch and then do testing with all drivers we can [18:00] it's important though to keep in mind that the greeter shall not fail [18:00] it's too important [18:01] well the easiest way to guarantee that is to not functionally change it [18:01] ie by drawing a black pixmap on that first call, and only the first call [18:01] which is what bluesabre and me have done mostly [18:04] i can also imagine doing functional changes, as long as there's someone at work who feels confident with that (i don't) [18:09] @2000 lines of code there's a limit to how many bugs there can possibly be [18:09] ali1234: Error: "2000" is not a valid command. [18:09] indeed [18:10] depending though on what kind of other stuff you involve [18:10] many of our bugs have been lightdm bugs === J21_ is now known as J21 [20:03] hi sergiobenrocha2 [20:03] knome: sergiobenrocha2 is looking to get more involved with us :) [20:03] hey sergiobenrocha2 [20:03] I've been moving him about freenode ... we've come here now [20:04] welcome [20:04] Hah. [20:04] Welcome to another channel! [20:04] quick line from another channel - which sums it up [20:04] why didn't i get that tour? [20:04] elfy: ok, is possible that I create an wishlist in launchpad, and appears in this page, if the feature is good? [20:04] knome: please join #ubuntu+1 [20:05] then when you've done that - can you come here :p [20:06] lol [20:06] thanks everyone [20:06] done [20:06] :) [20:06] *that* was all of freenode? [20:07] no - just the bits I dragged sergiobenrocha2 around to [20:07] he started in #xubuntu [20:09] sergiobenrocha2, we basically just finished creating roadmap [20:09] sergiobenrocha2, was there something specific you had in your mind for the wishlist? [20:09] humm, yes, a thing or 2... or more [20:10] to make xubuntu more friendly [20:10] would you like to share them with us here or want to keep secrets? [20:10] :) [20:10] haha [20:11] so: [20:14] 1 - create launchers in panel would be more friendly in right-click, it is better to pop-up a configuration window that create a complete launcher, and not only an empty gray icon [20:14] sergiobenrocha2, did you know you can drag-and-drop launchers from the menu to the panl? [20:14] *panel too [20:14] sorry for english... portuguese is my language [20:14] Translator standing there ^ ;) [20:15] knome: but it possible to drag-and-drop from whiskermenu? I'm using it [20:15] * knome shrugs [20:15] i don't use a menu at all, so i don't know [20:16] maybe somebody who uses whiskermenu knows [20:16] possibly [20:16] maybe you should try. :) [20:17] I can drag-and-drop only favorites apps from whiskermenu, like terminal and thunar. Others, in sub-categories, it not possible [20:17] you should file a wishlist bug against whiskermenu for that [20:17] because it works with the regular xfce menu [20:18] ok [20:18] but whiskermenu is from ppa, how can ubuntu-bug will report that? [20:19] i don't think it can... you have to report manually [20:19] do it manually - if you can [20:19] https://github.com/gottcode/xfce4-whiskermenu-plugin/issues?labels=bug&state=open [20:19] file a new issue. [20:20] humm, ok [20:20] probably tag it with "feature" [20:24] ochosi: as usual, when i start looking closely at some code, i start to notice it's kinda funky [20:25] i have a feeling this thing leaks a display-sized xlib surface every time it changes the background [20:25] the set_background code also does a bunch of surface setup, before which things may not work properly [20:32] I created the issue [20:33] but I can not see, if i click in "Issues" tab [20:33] it's the number 37 [20:34] oh, ok, not worry [20:40] confirmed, lightdm-gtk-greeter leaks memory like crazy. [20:43] ali1234: surprise? :) [20:43] never :( [20:43] so you plan to fix the background part? [20:43] i'm not sure i want to touch this code [20:44] all this background stuff is related [20:44] the only easy fix is to replace that first sat_background() with something like clear_background() which will just clear it to black but otherwise do the exact same as set_background [20:45] ie all the memory leaking and stuff [20:45] the alternative is to rewrite it so that allocation and drawing are separate [20:45] this would fix both problems [20:45] but it's a quite big refactoring [20:46] allocation of the background image? [20:46] and i'm not sure if i really care for something i see for 10 seconds twice a month [20:46] so, when the greeter starts up it makes a pixmap which is the background [20:46] actually, set_background() does this [20:47] it creates a xlib pixmap, then draws the background into it with cairo [20:47] but the problem is that the next time you call it, it makes another new pixmap and does not free the old one [20:47] yes, but the greeter does it twice, if accountsservice provides an user background [20:47] I accidentally created a duplicate, but I changed it to an another issue, it is Issue #37. Can someone take the duplicate label? [20:47] yes, it does it every time you select a different user from the list [20:48] right [20:48] if you sit and click different users you can make it leak hundreds of mb if you are patient [20:48] no one does that [20:48] ali1234, we would be grateful if you fixed that [20:49] brainwash: could be a security vuln, i dunno... [20:49] who knows what happens if the display is locked and you crash lightdm... [20:49] anyway the thing is, it has to allocate and leave allocated that pixmap [20:49] it might even be necessary that the pixmap exists before you start doing gtk stuff [20:50] the background won't change if the screen is locked via greeter [20:50] this might be the nouveau bug that was mentioned [20:50] so this means you can't just defer drawing the background, because it also *creates* the background [20:51] I simply want this bug to be fixed -> bug 1251431 [20:51] bug 1251431 in LightDM GTK+ Greeter "user background gets painted over background specified in config file" [Undecided,New] https://launchpad.net/bugs/1251431 [20:51] this also fixes the light-locker issue for me [20:51] what does? [20:52] ochosi made a change, so that light-locker blanks the screen after locking it [20:52] it only works for me, if the background is set only once [20:53] right yeah, that makes sense [20:53] you know what i said about those pixmaps getting leaked? [20:53] uhm, it's bad [20:53] well, i bet the patch he made expects there to be only one [20:53] so it hides the top one [20:53] but there's still a stack of leaked ones behind it [20:53] so to fix *that* [20:54] requires the "proper" (but harder) fix of refactoring this thing [20:54] I mean this here "XForceScreenSaver(display,ScreenSaverActive);" [20:55] called twice unblanks the screen [20:56] at least for me [20:56] on two different systems [20:56] yeah [20:56] not this particular line, but the code part [20:56] hmm [20:56] no sure what you mean really [20:56] the communication with X [20:57] the thing is that all those leaked background pixmaps persist after the greeter exits [20:57] yes, but that's not related to the blanking issue :) [20:57] well, why did you mention it then? [20:58] it's related to bug 1251431 [20:58] bug 1251431 in LightDM GTK+ Greeter "user background gets painted over background specified in config file" [Undecided,New] https://launchpad.net/bugs/1251431 [20:58] ok. i don't understand how it is related... [20:58] so we really need to cleanup the code [20:59] unless you mean it's related in a general sense of "this code sucks and has lots of problems" [20:59] which is fair enough [20:59] take a look at the create_root_surface function [21:00] this function contains the line to blank the screen (after locking it) [21:00] so it behaves like xscreensaver [21:00] yeah [21:00] if you call set_background, you also call create_root_surface [21:01] ok... [21:02] and this is bad, because my screen does not remain blanked [21:02] ok, see that's where you lost me [21:02] if I call set_background only once, it works [21:02] screen stays blanked [21:02] ok, so on startup you mean [21:02] right [21:03] startup after yu pressed "lock screen" that is [21:03] yes [21:03] the normal screen lock does no allow user switching anyway [21:03] yeah but that's irrelevant [21:04] the problem is it sets the background to default, then creates a bunch of widgets, then sets background to the user one [21:04] so... we can fix many problems with a code cleanup :D [21:04] but it can't get the user background until after it did all that widget stuff [21:05] can't we set the background to default only as fallback option, if the user background is not available? [21:05] yes [21:05] but that means defering it [21:05] until after the point where we usually load the user background [21:05] yes, won't hurt or? [21:06] well, it might do, because there's no root pixmap until after set_background [21:06] currently I've simply commented the default background call out [21:06] yes [21:06] actually what you need to do is move the set_background to... [21:07] yeah [21:07] if (lightdm_greeter_get_hide_users_hint (greeter)) [21:07] which is much further down the functions [21:07] around 1890 [21:08] the solution is quite easy [21:09] go on... [21:09] looks like you are very interested in fixing this :D [21:09] it's fairly simple to fix, just a lot of refactoring [21:10] you are more skilled, I would mess up and break the code :/ [21:10] that's the problem with refactoring things [21:11] that's why nobody ever wants to do it [21:11] usually you have some tests to verify the functionality [21:13] but I'll try to write a patch later (to at least provide a fix for my bug report) [21:13] part of the problem is that it doesn't just use one pixmap [21:13] it makes one per screen [21:13] so then you have to have an array to keep track of them [21:14] and you have to handle screens getting added and removed [21:14] ouch [21:14] currently it does none of this, it just blasts all over whatvever exists "right now" and then leaks it [21:15] what about the unity-greeter? is it more mature? [21:15] dunno. it's vala, and huge [21:15] it's written in vala [21:15] yes [21:15] i'd rather fix this code i think [21:15] i bet unity-greeter has just as many problems [21:19] actually it's even worse than i thought, because it disconnects from the xserver after dumping the pixmap on it [21:19] so if you keep a reference to it, it can go invalid without warning [21:20] this is really hairy... [21:20] elfy, ping [21:21] you should ge a cup of coffee [21:21] get [21:21] * genii readies the coffeepot [21:21] i just realised this while i was brewing some tea [21:21] s'up knome [21:21] elfy, you worked with the community wiki i assume? [21:21] elfy, the community *help* wiki [21:21] once or twice [21:22] elfy, aha, okay [21:22] elfy, i still might need your opinion.. [21:22] well - that was a figure of speech :) quite a bit :) [21:22] but i'll get back to you later on that [21:22] lol [21:22] haha, in that case [21:22] i'll get to you now :) [21:22] lol [21:22] noticed i took a work item on refreshing the frontpage? [21:23] https://help.ubuntu.com/community/FrontPageRefresh [21:23]