| wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/antibfjo-1-set/+merge/195886 https://code.launchpad.net/~wgrant/launchpad/antibfjo-2-garbo/+merge/195887 https://code.launchpad.net/~wgrant/launchpad/antibfjo-2.5-no-garbo/+merge/195888 | 01:11 |
|---|---|---|
| StevenK | wgrant: I'm just about to head off for ~15, I'll cast my eyes over them when I return. | 01:12 |
| wgrant | kk | 01:12 |
| StevenK | wgrant: I'm not sure whether to ostracise or congratulate you for use of a local variable 'bbq' | 01:51 |
| maxb | lol | 01:52 |
| StevenK | wgrant: r=me * 3, -1-set has a comment | 01:53 |
| wgrant | StevenK: Thanks | 02:06 |
| wgrant | That comment isn't actually mine; it's copied from the Job.status equivalent. But it means "this %s is going to be replaced with self.id" | 02:06 |
| wgrant | StevenK: https://code.launchpad.net/~wgrant/launchpad/antibfjo-3-branch-deletion/+merge/195890 https://code.launchpad.net/~wgrant/launchpad/antibfjo-4-use/+merge/195891 https://code.launchpad.net/~wgrant/launchpad/antibfjo-5-use-more/+merge/195892 | 02:28 |
| wgrant | And https://code.launchpad.net/~wgrant/launchpad/antibfjo-7-no-set-pls/+merge/195894 | 02:38 |
| StevenK | wgrant: What about asserting that the TTB no longer exists after the destroySelf() call? | 02:54 |
| wgrant | StevenK: The FK proves that it's gone. | 02:55 |
| StevenK | wgrant: In -4-use, you remove SPRB.buildqueue_record, but then use it? | 03:16 |
| wgrant | StevenK: I pushed it up to BuildFarmJobMixin | 03:19 |
| wgrant | As it's now common | 03:19 |
| StevenK | Ah, right. | 03:19 |
| StevenK | wgrant: -3-branch-deletion and -4-use are approved, moving onto -5-use-more | 03:20 |
| StevenK | I guess -6-blah is a DB patch? | 03:20 |
| wgrant | -0, -6, -8, -10 are DB patches | 03:20 |
| StevenK | When does BPJ die a horrible death? | 03:20 |
| wgrant | -10 drops the tables and columns | 03:21 |
| StevenK | Is -10 up yet? | 03:21 |
| wgrant | No. | 03:21 |
| StevenK | Diff against target: 817 lines (+95/-164) 22 files modified | 03:21 |
| StevenK | You are a terrible person. | 03:21 |
| wgrant | Ah | 03:21 |
| wgrant | I split it, but I guess it crept back over | 03:21 |
| StevenK | I have fear that the query changes are in one hunk, and the sqlvalues() changes are in the next hunk | 03:23 |
| StevenK | Argh, -7-no-set is even worse | 03:26 |
| wgrant | Mostly deletions, though | 03:26 |
| StevenK | Right | 03:27 |
| StevenK | job_type will die horribly, too? | 03:27 |
| wgrant | Yes | 03:29 |
| wgrant | But it's still needed in -7 so we know how to look up the BFJO to destroy it. | 03:29 |
| StevenK | That's all of them approved | 03:31 |
| StevenK | One niggle in -6 | 03:31 |
| StevenK | Er, -7 | 03:31 |
| wgrant | I will decline to address it; I feel the unwrapping under the same name at the very start of the method is justified. | 03:32 |
| wgrant | But thanks | 03:33 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!