[04:39] <wgrant> StevenK: https://code.launchpad.net/~wgrant/launchpad/antibfjo-8-kill/+merge/196053
[04:46] <StevenK> I don't think you've deleted quite enough. :-P
[04:47] <StevenK> wgrant: r=me
[04:54] <wgrant> thanks
[10:02] <cjwatson> StevenK: Thanks for the testfix.  I ran out of time yesterday.
[10:23] <StevenK> cjwatson: No worries. I couldn't work out which change broke it, but looking at what was returned with and without your rev made it obvious it was a bong test
[10:24] <cjwatson> StevenK: *nod*
[10:24] <cjwatson> Now I wonder why qas hasn't picked it up
[10:24] <cjwatson> Oh, asuka buggered?
[10:25] <wgrant> and then some
[10:27]  * cjwatson runs into bug 612287
[10:27] <_mup_> Bug #612287: Unable to view failed imports if there are private imports in the list <403> <branches> <code-import> <lp-code> <privacy> <Launchpad itself:Triaged> <https://launchpad.net/bugs/612287>
[10:28] <cjwatson> That seems to have got sidetracked into whether specific branches should or shouldn't be private, but isn't the right resolution for that bug to show them redacted in +code-imports or skip them entirely?
[10:28] <wgrant> You can usually mangle batches manually to get everything except the private one.
[10:28] <wgrant> Probably.
[10:28] <cjwatson> Well, yeah, but it's silly to have to
[10:29] <cjwatson> Reminds me of the now-fixed /builders thing.
[10:37] <cjwatson> Is there a pattern somewhere for filtering batched DB queries by visibility?
[10:39] <StevenK> Most of the sharing stuff will do it
[10:41] <wgrant> cjwatson: BranchCollection can do it, but I'm not sure if +code-imports uses BranchCollection.
[10:44] <cjwatson> Thanks, will ponder
[10:47] <wgrant> cjwatson: get_branch_privacy_filter is the guts of the query.
[10:48] <cjwatson> Yeah, might need to use that directly
[10:50] <wgrant> stub: Could you please review https://code.launchpad.net/~wgrant/launchpad/antibfjo-0-db/+merge/195885 and https://code.launchpad.net/~wgrant/launchpad/antibfjo-6-db-prekill/+merge/195893?
[10:50]  * stub has a look
[10:56] <stub> wgrant: that is all fine.
[10:57] <wgrant> stub: Thanks
[11:09] <wgrant> Oh amazing
[11:09] <wgrant> the JS test failure on precise goes away if you show the browser window.