[13:02] <allenap> rvba, gmb: lp:maas has lint in it. Any idea how that happened, given that we have a test to avoid that?
[13:03] <rvba> allenap: make lint returns '' here… ?
[13:04] <rvba> Revision 1747.
[13:04] <allenap> rvba: I get two complaints about src/provisioningserver/dhcp/detect.py
[13:05] <rvba> Weird, I see nothing.
[13:05] <allenap> rvba: Can you check your ~/.flake8rc?
[13:07] <allenap> rvba: Ah, interesting. I have 'ignore = E123' in my .flake8rc. If I comment that out, the lint report goes silent.
[13:08] <allenap> I guess there's a default list of things to ignore.
[13:08] <rvba> o_O
[13:08] <rvba> Probably
[13:08] <rvba> I don't have a ~/.flake8rc.
[13:09] <gmb> me either.
[13:15] <rvba> gmb: would you mind having a look at: https://code.launchpad.net/~rvb/maas-test/warn-not-block/+merge/197186 ? I'm changing a bit of code you wrote and I'd like you to review that if you have time.
[13:15] <gmb> rvba: Sure, I'll take a look now.
[13:19] <gmb> rvba: Approved. Looks good to me.
[13:20] <rvba> gmb: fun fact about drive by fix #2: virt-what wasn't a dependency of the package so check_hardware_is_physical was always returning True :).
[13:20] <rvba> Thanks.
[13:20] <gmb> rvba: AAAAARGH. Thanks for catching that :)
[13:21] <rvba> gmb: since you're there, care to also have a look at this one-liner? https://code.launchpad.net/~rvb/maas-test/better-create/+merge/197196
[13:21] <rvba> :)
[13:21] <gmb> Sure :)
[13:21] <rvba> Thanks.
[13:22] <gmb> Approved.
[13:22] <gmb> rvba: ^^
[13:22] <rvba> Thanks again.
[13:22] <rvba> Let's see if the lander works…
[13:22] <gmb> Fingers crossed
[13:26] <rvba> The lander works.
[14:08] <rvba> allenap: gmb: Quick reminder: don't forget to update the packaging each time you had a new dependency to maas-test (the package was broken because python-xdg was missing from the dependency list).
[14:09] <gmb> rvba: Ok, thanks for the reminder.
[14:09] <rvba> Would be nice to get a warning (from a bzr hook or something) each time we modify packages.txt.
[14:09] <rvba> s/had/add/