=== freeflying is now known as freeflying_away === freeflying_away is now known as freeflying === freeflying is now known as freeflying_away === CyberJacob|Away is now known as CyberJacob === freeflying_away is now known as freeflying === freeflying is now known as freeflying_away [13:02] rvba, gmb: lp:maas has lint in it. Any idea how that happened, given that we have a test to avoid that? [13:03] allenap: make lint returns '' here… ? [13:04] Revision 1747. [13:04] rvba: I get two complaints about src/provisioningserver/dhcp/detect.py [13:05] Weird, I see nothing. [13:05] rvba: Can you check your ~/.flake8rc? [13:07] rvba: Ah, interesting. I have 'ignore = E123' in my .flake8rc. If I comment that out, the lint report goes silent. [13:08] I guess there's a default list of things to ignore. [13:08] o_O [13:08] Probably [13:08] I don't have a ~/.flake8rc. [13:09] me either. [13:15] gmb: would you mind having a look at: https://code.launchpad.net/~rvb/maas-test/warn-not-block/+merge/197186 ? I'm changing a bit of code you wrote and I'd like you to review that if you have time. [13:15] rvba: Sure, I'll take a look now. [13:19] rvba: Approved. Looks good to me. [13:20] gmb: fun fact about drive by fix #2: virt-what wasn't a dependency of the package so check_hardware_is_physical was always returning True :). [13:20] Thanks. [13:20] rvba: AAAAARGH. Thanks for catching that :) [13:21] gmb: since you're there, care to also have a look at this one-liner? https://code.launchpad.net/~rvb/maas-test/better-create/+merge/197196 [13:21] :) [13:21] Sure :) [13:21] Thanks. [13:22] Approved. [13:22] rvba: ^^ [13:22] Thanks again. [13:22] Let's see if the lander works… [13:22] Fingers crossed [13:26] The lander works. [14:08] allenap: gmb: Quick reminder: don't forget to update the packaging each time you had a new dependency to maas-test (the package was broken because python-xdg was missing from the dependency list). [14:09] rvba: Ok, thanks for the reminder. [14:09] Would be nice to get a warning (from a bzr hook or something) each time we modify packages.txt. [14:09] s/had/add/ === _jmp__ is now known as _jmp_ === freeflying_away is now known as freeflying === Spideyman is now known as Spideyman_afk === Spideyman_afk is now known as Spideyman === Spideyman is now known as Spideyman_afk === Spideyman_afk is now known as Spideyman === Spideyman is now known as Spideyman_afk === Spideyman_afk is now known as Spideyman === Spideyman is now known as Spideyman_afk