=== iahmad is now known as iahmad|afk | ||
tsdgeos | Saviq: https://code.launchpad.net/~aacid/unity8/remove_unused_applications_folder/+merge/197058 up | 08:39 |
---|---|---|
Saviq | tsdgeos, cheers | 08:39 |
mhr3 | sil2100, still no unity-scopes-api? :/ | 08:48 |
sil2100 | didrocks: could you maybe NEW unity-scopes-api from the queue? As it seems people were a bit busyish yesterday :) | 08:50 |
didrocks | sil2100: was it preNEWed? | 08:51 |
seb128 | didrocks, yes, I +1ed it | 08:52 |
didrocks | ok, pushing buttons then | 08:52 |
sil2100 | didrocks: yes, before releasing by seb128, so it's all ok - it's waiting in the queue since 2 days | 08:52 |
sil2100 | didrocks: thank you! | 08:52 |
didrocks | sil2100: done :) | 08:52 |
didrocks | well, seb128 did the hard work ;) | 08:52 |
sil2100 | mhr3: tadaah! | 08:52 |
didrocks | I just pushed a button | 08:52 |
seb128 | ;-) | 08:52 |
sil2100 | ;) | 08:52 |
didrocks | (well 2 a checkbox + a button) | 08:52 |
mhr3 | weeeeeee! | 08:52 |
didrocks | phew | 08:52 |
didrocks | can go on week-end I gues now :p | 08:52 |
seb128 | sil2100, mhr3, didrocks: good morning, happy friday! | 08:52 |
didrocks | happy friday seb128 ;) | 08:52 |
didrocks | guess* | 08:52 |
sil2100 | Good morning! And a happy Friday indeed ;) | 08:53 |
mhr3 | seb128, a very black friday to you as well! | 08:53 |
seb128 | mhr3, you must be confused, I'm not one of those turkey eaters | 08:53 |
seb128 | we don't do that here | 08:53 |
* seb128 doesn't shop today | 08:53 | |
mhr3 | seb128, but you're still in northern hemisphere so it's dark-ish these days :) | 08:54 |
seb128 | I guess one can say that ... | 08:54 |
Saviq | Black Friday will find you when you least expect it! | 08:55 |
Saviq | like amazon.co.uk has BF deals ;) | 08:56 |
Saviq | tsdgeos, mzanetti, hey, could one of you do https://code.launchpad.net/~gerboland/unity-mir/more-robust-desktop-file-parsing/+merge/190917 ? it's partly my code, so... | 09:05 |
tsdgeos | sure | 09:06 |
tsdgeos | i'll do | 09:06 |
mzanetti | tsdgeos: please wait before approving. need to check something | 09:08 |
tsdgeos | no no no | 09:09 |
tsdgeos | i'll approve right away :-P | 09:09 |
Saviq | mzanetti, dandrader you have a weird definition of "disregard" ;) | 09:12 |
mzanetti | :P | 09:12 |
Saviq | but thanks! ;) | 09:12 |
dandrader | Saviq, I'm missing context | 09:13 |
dandrader | cannot parse :) | 09:13 |
Saviq | dandrader, the email last night | 09:14 |
Saviq | dandrader, the testing one | 09:14 |
dandrader | Saviq, ah right | 09:14 |
dandrader | I just love replying to e-mail | 09:14 |
Saviq | dandrader, oh, want some of mine? ;D | 09:14 |
tsdgeos | Saviq: no tests in https://code.launchpad.net/~gerboland/unity-mir/more-robust-desktop-file-parsing/+merge/190917 ?¿ | 09:15 |
dandrader | Saviq, I would probably not be able to fill those replies with useful content though :) | 09:15 |
Saviq | tsdgeos, right | 09:16 |
Saviq | tsdgeos, ok leave a comment about that | 09:16 |
Saviq | tsdgeos, good time as any to add them | 09:16 |
Saviq | or actually the best time | 09:16 |
tsdgeos | at least for the thing we're supposing to fix | 09:17 |
tsdgeos | not for the whole thing | 09:17 |
Saviq | tsdgeos, yeah | 09:18 |
Cimi | Saviq, did I receive a mail at your 2:46am?? | 09:18 |
Cimi | Saviq, or is it your bot? :) | 09:18 |
Saviq | Cimi, WHAAAAAT?! | 09:18 |
Cimi | Saviq, the testing testing | 09:19 |
Saviq | Cimi, read into the WHAAAAT | 09:19 |
Saviq | ;P | 09:19 |
Cimi | Saviq, go to bed and sleep boss :P | 09:20 |
Saviq | Cimi, I did, soon thereafter | 09:21 |
Cimi | I slept nothing, Evan invited me for the Thanksgiving turkey | 09:22 |
Cimi | I had that much food I'm still digestng | 09:22 |
Cimi | that was tough | 09:22 |
Saviq | Cimi, shouldn't you be knifing your way through a mall now, then? | 09:24 |
Cimi | Saviq, all I can say now is "burp" | 09:24 |
Saviq | :D | 09:25 |
Cimi | Saviq, I learnt so much last night about american traditions | 09:25 |
Cimi | Saviq, for example why all americans take the whole week off to face thanksgiving | 09:26 |
Saviq | ;) | 09:26 |
Cimi | Saviq, and that's it's basically just an excuse to train your body for xmas lunch | 09:26 |
Cimi | burp | 09:27 |
tsdgeos | do you guys know if there's a launchpad page with "reviews i'm doing"? | 09:27 |
Cimi | mmm | 09:27 |
tsdgeos | i usually use https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews and then head over the "Reviews I am doing" section | 09:27 |
tsdgeos | but then https://code.launchpad.net/~gerboland/unity-mir/more-robust-desktop-file-parsing/+merge/190917 doesn't show up there | 09:27 |
tsdgeos | because it's unity-mir and not unity8 | 09:28 |
Cimi | tsdgeos, https://code.launchpad.net/~cimi/+activereviews | 09:28 |
tsdgeos | awesome! | 09:28 |
tsdgeos | now that list some old old old reviews :D | 09:28 |
Cimi | tsdgeos, yeah I realised it's kind of embarrassing :D | 09:29 |
sil2100 | hmmm | 09:29 |
sil2100 | Hi guys, did anyone of you notice unity7/bamf acting strangely since a while on the desktop? | 09:30 |
seb128 | sil2100, define "strangely", and no | 09:30 |
tsdgeos | sil2100: like dropping all the indicators? | 09:30 |
tsdgeos | at the moment i only have the messaging and keyboard one around | 09:30 |
sil2100 | seb128: for instance, if I open nautilus from the launcher, close it, and then click on the nautilus icon again - it doesn't want to start the app | 09:30 |
tsdgeos | don't even know what time it is damnit! | 09:30 |
sil2100 | tsdgeos: that as well, but rarely! | 09:31 |
seb128 | tsdgeos, stop playing with unity8 in your sessions :p | 09:31 |
sil2100 | seb128: as if the launcher (bamf) didn't register that I closed the nautilus window | 09:31 |
sil2100 | I think I'll have to fill in a bug | 09:31 |
seb128 | sil2100, nop, no such issue here (and I didn't see any complain about it) | 09:31 |
seb128 | sil2100, are you running trusty or daily-build ppa? | 09:31 |
sil2100 | seb128: trusty, without daily-build | 09:32 |
seb128 | weird | 09:32 |
seb128 | is the issue specific to nautilus? | 09:32 |
sil2100 | seb128: no, it happens for every app here - like firefox as well, I have to open up firefox by middle-clicking on the icon as if I want to open a new window | 09:33 |
seb128 | weird | 09:33 |
seb128 | no, definitively not happening here | 09:33 |
seb128 | I would have noticed | 09:33 |
sil2100 | hmm, ok, I'll ask around and fill in a bug, maybe something wrong on my system | 09:33 |
seb128 | sil2100, does it happen in a guest session? | 09:34 |
sil2100 | seb128: I guess that's a good idea, I'll check that after the meeting | 09:34 |
tsdgeos | Cimi: you proposed https://code.launchpad.net/~unity-team/unity/phablet.delay-highlight/+merge/150867 can we kill it? | 09:37 |
* mzanetti wonders why an upgrade brings back the ebay app but doesn't bring back the amazon app | 09:39 | |
Cimi | tsdgeos, mmm how about the comment of that guy? | 09:39 |
mzanetti | Cimi: tsdgeos: imho this is a bad thing to change | 09:41 |
mzanetti | because the highlight is supposed to indicate that it will execute a press if you release now | 09:41 |
mzanetti | there is no point in delaying that | 09:41 |
tsdgeos | +1 | 09:42 |
tsdgeos | basically my "You can click on it without it ever being highlighed (not sure if that's bad, but seems weird to me)" | 09:42 |
tsdgeos | Cimi: anyway i'm rejecting since it's against the wrong project | 09:42 |
tsdgeos | "lp:unity/phablet" | 09:42 |
Cimi | tsdgeos, ok | 09:42 |
Saviq | mzanetti, tsdgeos, Cimi, yeah, the Flickable::pressDelay is meant to cater for that http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-flickable.html#pressDelay-prop | 09:46 |
Saviq | but all in all, I don't think this is an issue any more, as we're not highlighting the whole items | 09:46 |
tsdgeos | ok https://code.launchpad.net/~aacid/+activereviews is looking much better now that we've reject very old stuff :D | 09:47 |
Saviq | and even if it is an issue, we'd need to solve it across the board, not just for unity8 | 09:47 |
tsdgeos | +1 | 09:47 |
Saviq | tsdgeos, what do you think we could do about the default Flickable velocities? | 09:49 |
tsdgeos | Saviq: make them pixel density dependant | 09:49 |
Saviq | tsdgeos, upstream, that is | 09:49 |
tsdgeos | Saviq: there's a patch by Florian to properly implement that | 09:49 |
Saviq | tsdgeos, ah ok | 09:49 |
tsdgeos | in 5.[1|2] | 09:49 |
tsdgeos | Saviq: that = proper pixel density reporting to Qt | 09:50 |
tsdgeos | not sure it does indeed fix the flickable velocity | 09:50 |
tsdgeos | but once we do report the proper pixel density stuff in the QPA | 09:50 |
tsdgeos | if it doesn't work | 09:50 |
tsdgeos | we should fix it upstream | 09:50 |
tsdgeos | yes | 09:50 |
Saviq | tsdgeos, works for me | 09:51 |
tsdgeos | Saviq: mind if i reject https://code.launchpad.net/~paulliu/unity/phablet-fake-peoplepreviewdata/+merge/161514 ? since all the people* stuff is gone | 09:51 |
Saviq | tsdgeos, +1 | 09:52 |
=== dandrader is now known as dandrader|afk | ||
=== rachelliu_ is now known as rachelliu | ||
=== dandrader|afk is now known as dandrader | ||
tsdgeos | dandrader: hi ho | 10:20 |
dandrader | tsdgeos, hi ho | 10:22 |
tsdgeos | dandrader: do you think it'd make sense to add to https://code.launchpad.net/~dandrader/unity8/runningAppsEndClose/+merge/196257 one test that uses touch and not mouseClick? | 10:22 |
tsdgeos | Saviq: https://code.launchpad.net/~aacid/unity8/remove_unused_applications_folder/+merge/197058 aborted? | 10:28 |
dandrader | tsdgeos, didn't get it | 10:28 |
dandrader | tsdgeos, there are tests for mousePress and touch press | 10:29 |
tsdgeos | are tehre? | 10:29 |
dandrader | tsdgeos, yes | 10:29 |
Saviq | tsdgeos, folks are fighting with some instabilities in CI AFAICT | 10:29 |
tsdgeos | dandrader: not in tst_RunningApplicationsGrid.qml ? | 10:29 |
Saviq | tsdgeos, I'll be monitoring | 10:29 |
Saviq | /food, first | 10:29 |
dandrader | tsdgeos, ah, I'm talking about tst_PressedOutsideNotifier.cpp | 10:29 |
tsdgeos | dandrader: so you think there's any value at all adding the test? or the one in tst_PressedOutsideNotifier.cpp should be enough? | 10:30 |
dandrader | tsdgeos, yeah, I think tst_PressedOutsideNotifier on that regard | 10:34 |
dandrader | is enough | 10:34 |
tsdgeos | oki | 10:34 |
MacSlow | Saviq, I've put up an unity-notifications-MR for for LP: #1256011 ... but what about LP: #1239421? I'm not sure what's required there... or can I leave that for Jussi? | 11:01 |
ubot5 | Launchpad bug 1256011 in unity-notifications (Ubuntu) "Should install shell-facing plugins in plugin path from libunity-api-dev" [Low,In progress] https://launchpad.net/bugs/1256011 | 11:01 |
ubot5 | Launchpad bug 1239421 in unity-notifications "unity-notifications isn't using unity-apis" [Undecided,New] https://launchpad.net/bugs/1239421 | 11:01 |
tsdgeos | dandrader: what's the timer in tst_PressedOutsideNotifier.qml for? | 11:03 |
* dandrader checks | 11:03 | |
dandrader | tsdgeos, ah, it's for the effect to be visible when manually testing | 11:04 |
tsdgeos | right | 11:04 |
dandrader | tsdgeos, otherwise you won't see it red for long enough | 11:04 |
Saviq | MacSlow, the latter is about extracting abstract base classes from unity-notifications into unity-api (or well, adapting the ones that are already there) | 11:11 |
Saviq | MacSlow, and making use of them in unity-notifications, as well as running the test suite from unity-api against unity-notifications | 11:11 |
nic-doffay__ | greyback, ping | 11:11 |
MacSlow | Saviq, ok | 11:12 |
Saviq | MacSlow, but yeah, it's not necessarily something you should be doing | 11:13 |
MacSlow | Saviq, true... I don't want to "hijack" lp:unity-notifications ... | 11:14 |
MacSlow | Saviq, the CMakeFile fix was harmless... but 1239421 look more involved and I rather leave that to the API-team | 11:14 |
tsdgeos | dandrader: technically window(); could return null in setupEventFiltering when removed from a scene, do we care about that? | 11:14 |
Saviq | MacSlow, +1 | 11:15 |
MacSlow | Saviq, today is review/cleanup-day anyway | 11:15 |
dandrader | tsdgeos, it's only called from within " if (isEnabled() && window()) {} " | 11:17 |
dandrader | tsdgeos, so if window() returns null there it *should* crash | 11:17 |
tsdgeos | dandrader: it certainly is | 11:17 |
tsdgeos | ok | 11:17 |
dandrader | tsdgeos, but maybe a Q_ASSERT(currentWindow) would go in order to state intention | 11:19 |
tsdgeos | dandrader: it's ok to me either way | 11:19 |
Saviq | MacSlow, did you test https://code.launchpad.net/~mzanetti/unity8/desktopfile-to-appid/+merge/197154 extensively on the device? That launcher, home apps, installed apps, webapps all still work fine? | 11:24 |
Saviq | mzanetti, think we could test ↑? | 11:24 |
mzanetti | Saviq: this only names the arguments actually | 11:24 |
mzanetti | doesn't really change anything in the logic | 11:24 |
mzanetti | but sure. I'll do another test run | 11:25 |
Saviq | mzanetti, no I mean if we have some automated tests for this - if not, now would be a good time to add them | 11:26 |
mzanetti | Saviq: yep. there are tests | 11:28 |
Saviq | mzanetti, ok | 11:29 |
mzanetti | Saviq: tst_Shell.qml: test_tapOnAppIconInLauncher() | 11:29 |
mzanetti | Saviq: that runs through this | 11:29 |
=== dandrader is now known as dandrader|lunch | ||
MacSlow | Saviq, not all... but I can repeat it with more checks | 11:34 |
=== _salem is now known as salem_ | ||
tsdgeos | dandrader|lunch: how are you ahving lunch before me if you're like more to the west? | 11:37 |
tsdgeos | :D | 11:37 |
tsdgeos | dandrader|lunch: anyway, i was wondering if we can't just hijack the touch event by returning true at some point in the evenFilter and save us from all that timer stuff which looks a bit hacky | 11:38 |
MacSlow | tsdgeos, by being really hungry? ;) | 11:38 |
Saviq | tsdgeos, MacSlow and getting up at 4am ;) | 11:39 |
tsdgeos | that too | 11:39 |
MacSlow | Saviq, an empty stomach make one do crazy things :) | 11:39 |
MacSlow | today is also "let's forget 3rd-person s"-day | 11:41 |
Saviq | [08:29:48] *** Joins: dandrader | 11:43 |
Saviq | http://www.timeanddate.com/worldclock/converted.html?iso=20131129T0830&p1=664&p2=213 | 11:43 |
Saviq | he's preventing jetlag ;) | 11:44 |
MacSlow | Saviq, mzanetti: really nothing fails with lp:~mzanetti/unity8/desktopfile-to-appid | 11:45 |
Saviq | MacSlow, that's good 'innit | 11:45 |
=== MacSlow is now known as MacSlow|lunch | ||
=== dandrader|lunch is now known as dandrader | ||
dandrader | tsdgeos, I started working at 5:30 am, so lunch at 9:30 am :) | 12:12 |
dandrader | tsdgeos, and as a bonus a nice sunny afternoon to go outside after work | 12:13 |
tsdgeos | +1 | 12:14 |
dandrader | tsdgeos, the point is to not interfere with the normal event processing. we're just monitoring it, not filtering it out | 12:14 |
dandrader | tsdgeos, but I do agree that that timer is not the best thing in the world, thus the big comment | 12:16 |
tsdgeos | dandrader: ok, can you write that comment "the not interfere" thing in the MR so it's there for posterity if we ever go back and wonder why it was done that way? | 12:19 |
dandrader | tsdgeos, done | 12:28 |
nic-doffay__ | Saviq, the filters should be testable in a couple of days again. | 12:35 |
mhr3 | sil2100, ping? | 12:50 |
sil2100 | mhr3: pung | 12:50 |
mhr3 | sil2100, which was the ppa i can use? | 12:50 |
sil2100 | mhr3: ppa:ubuntu-unity/daily-build-next | 12:51 |
mhr3 | sil2100, i'm afraid i don't have upload rights there | 12:51 |
sil2100 | Wait, you're not part of ubuntu-unity? | 12:51 |
mhr3 | doesn't seem so | 12:52 |
mhr3 | can someone add me? | 12:52 |
mhr3 | didrocks, ^? | 12:52 |
sil2100 | I guess you should be, as you're working on unity stuff | 12:52 |
=== MacSlow|lunch is now known as MacSlow | ||
sil2100 | didrocks: you think that's possible to do? Need to check who's an admin as well | 12:53 |
mhr3 | didrocks is admin :) | 12:53 |
didrocks | mhr3: hum, I can't add you to that team for policy reason | 12:53 |
didrocks | because it would give an indirect way for you to upload to the archive :) | 12:53 |
mhr3 | didrocks, you don't trusty me? :P | 12:54 |
didrocks | mhr3: ahah, not that question, but I don't want to rediscuss with the tech board about who can be in that team :p | 12:54 |
mhr3 | can someone with proper rights create the recipe and i'll be just firing it from time to time? | 12:56 |
mzanetti | bbiab | 12:56 |
mhr3 | not sure if that would work | 12:57 |
mhr3 | but let's give it a try? | 12:57 |
mhr3 | sil2100, ^ | 12:57 |
didrocks | mhr3: yep, neat idea! | 12:58 |
mhr3 | and i hope you guys made sure that pkgs from that ppa won't bubble through some script to the distro automagically | 12:59 |
didrocks | mhr3: well, as long as it's in daily-build-next, it won't | 12:59 |
mhr3 | good | 12:59 |
didrocks | we only wire up daily-build ppa | 12:59 |
didrocks | but we can't have per ppa upload rights | 13:00 |
mhr3 | i guess ubuntu-unity has to own the recipe though, otherwise i'll fail to upload? | 13:01 |
=== pete-woods1 is now known as pete-woods | ||
=== _salem is now known as salem_ | ||
sil2100 | Uuuu | 13:07 |
sil2100 | I forgot that ubuntu-unity became so important ;p | 13:07 |
=== dandrader is now known as dandrader|afk | ||
Saviq | didrocks, think we should put "kill timeout 30" by default in the unity8 upstart job? | 13:47 |
Saviq | didrocks, so that we get meaningful .crash files from QA? | 13:48 |
didrocks | Saviq: is 30 enough? | 13:48 |
didrocks | on maguro? | 13:48 |
Saviq | didrocks, will test first | 13:48 |
didrocks | Saviq: yeah, try maguro first I guess, and tweak the value for it | 13:48 |
didrocks | on the idea +1 | 13:48 |
Saviq | didrocks, there can even be a test for it, FWIW | 13:48 |
Saviq | didrocks, ok, will ponder some | 13:49 |
didrocks | you send a SIGINT to unity8, ask upstart to stop it, yeah ;) | 13:49 |
Saviq | didrocks, actually no, I though of sending SIGSEGV | 13:52 |
Saviq | didrocks, and making sure apport completes before unity8 is killed | 13:53 |
didrocks | Saviq: yeah, that's another way of seeing it (not sure all stacktraces are equals though! ;)) | 13:53 |
Saviq | didrocks, will wait for the shell to be ready first | 13:53 |
Saviq | didrocks, and that should make it pretty real | 13:54 |
* Saviq needs a HOWTO for working with errors.u.c | 13:56 | |
mhr3 | saviq, you can ask ev next week :) | 13:57 |
Saviq | mhr3, yeah | 13:57 |
=== dandrader|afk is now known as dandrader | ||
Saviq | didrocks, only thing I'm worried about is that if we let it linger for 30s, the screen might go to sleep before apport completes :/ | 13:59 |
didrocks | Saviq: shouldn't whoopsie blocks suspend? | 14:00 |
didrocks | I meant, this is in the kernel | 14:00 |
didrocks | not whoopsie | 14:00 |
didrocks | so should be fine and not powering off? | 14:00 |
Saviq | didrocks, different than screen being turned off | 14:00 |
Saviq | didrocks, I don't mean the whole device | 14:00 |
Saviq | didrocks, but just the screen | 14:00 |
didrocks | what's the issue then? | 14:01 |
=== salem_ is now known as _salem | ||
Saviq | didrocks, when it turns off, u8 will fail to start next time | 14:12 |
greyback | Saviq: I find your lack of respect for Y-fronts disturbing | 14:37 |
nic-doffay__ | Saviq, can you recall where the sdk icons are installed to? | 14:37 |
nic-doffay__ | greyback, lool | 14:38 |
Saviq | greyback, I googled y-front | 14:38 |
Saviq | greyback, I blame YOU | 14:38 |
greyback | Saviq: XD | 14:38 |
nic-doffay__ | Saviq, >_< | 14:38 |
Saviq | greyback, you owe me for therapy | 14:38 |
nic-doffay__ | Saviq, try magic underpants | 14:38 |
Saviq | nic-doffay__, no. kthxbai | 14:38 |
nic-doffay__ | greyback, distress | 14:39 |
nic-doffay__ | mzanetti, can you recall where the icons are installed which the Icon class accesses? | 14:41 |
nic-doffay__ | I remember chatting about this to you before. | 14:41 |
mzanetti | nic-doffay__: dpkg -L ubuntu-mobile-icons | 14:43 |
nic-doffay__ | mzanetti, cheers | 14:43 |
=== _salem is now known as salem_ | ||
nic-doffay__ | Saviq, re your comment in the filters 'We've decided this will have to wait for the upcoming new scope backend.' | 14:50 |
nic-doffay__ | Can you let me know when I should take up development on the branch actively again? | 14:50 |
Saviq | nic-doffay__, of course, will do | 14:50 |
nic-doffay__ | Saviq, wicked | 14:50 |
Saviq | mhr3, pstolowski looking at https://launchpadlibrarian.net/157889220/StacktraceSource.txt | 15:09 |
Saviq | bug #1256342 is actually a mediascanner one then | 15:09 |
ubot5 | bug 1256342 in libunity (Ubuntu) "unity-scope-loader crashed with SIGABRT in __gnu_cxx::__verbose_terminate_handler()" [Medium,New] https://launchpad.net/bugs/1256342 | 15:09 |
Saviq | potentially a dupe of 1239561 ? | 15:10 |
Saviq | bug #1239561 | 15:10 |
ubot5 | bug 1239561 in mediascanner (Ubuntu) "mediascanner-service crashed with SIGABRT in raise()" [High,Confirmed] https://launchpad.net/bugs/1239561 | 15:10 |
mhr3 | hard to say from that bug | 15:11 |
mhr3 | anyway, mediascanner is waving byebye | 15:11 |
mhr3 | so i guess we don't care | 15:11 |
pstolowski | :) | 15:11 |
tsdgeos | Saviq: ok, so here it is https://code.launchpad.net/~aacid/dee-qt/more_tests/+merge/197220 who do you think can review? | 15:24 |
Saviq | tsdgeos, try forcing mhr3's or pstolowski's hand for this ;) | 15:25 |
tsdgeos | pstolowski: do you think you can review https://code.launchpad.net/~aacid/dee-qt/more_tests/+merge/197220 ? It's an old branch from kalikiana that i've reused some tests | 15:26 |
mhr3 | tsdgeos, last time i checked dee-qt had ~96% test coverage | 15:27 |
tsdgeos | mhr3: feel free to reject it :D | 15:27 |
tsdgeos | i'm just trying to salvage the tests | 15:28 |
tsdgeos | but if you don't think we need them | 15:28 |
tsdgeos | fine | 15:28 |
mhr3 | it has lots of changes that are clearly not just test-related | 15:29 |
tsdgeos | like? | 15:30 |
tsdgeos | i can count 2 changes that are not test related | 15:30 |
tsdgeos | 3 | 15:31 |
mhr3 | append() remove() model() | 15:31 |
tsdgeos | they are totally test related | 15:31 |
tsdgeos | i even say so on the comment i made | 15:31 |
mhr3 | but that turns read-only dee wrapper into read-write, which i'd say is a big thing | 15:32 |
tsdgeos | well if you read the comment i made | 15:32 |
tsdgeos | it would be great | 15:32 |
mhr3 | oh :) | 15:32 |
mhr3 | i read only description on new mps :P | 15:32 |
mhr3 | which isn't there btw | 15:32 |
tsdgeos | it's not my fault you decide to read only half of the stuff | 15:32 |
mhr3 | replied | 15:35 |
didrocks | Saviq: urgh, right, can you kick as post-stop script the screen on? | 15:38 |
Saviq | didrocks, pre-start rather, but I'm not sure i want to... | 15:38 |
Saviq | didrocks, the bug just needs to be fixed, bug #1235000 | 15:39 |
ubot5 | bug 1236525 in unity-mir "duplicate for #1235000 unity8 killed/crash then restart can result in mir unable "could not unblank display"" [Critical,Fix released] https://launchpad.net/bugs/1236525 | 15:39 |
didrocks | Saviq: yeah, agreed | 15:39 |
Saviq | didrocks, it got converted into a blueprint WI, actually | 15:40 |
didrocks | Saviq: do you know about the priority? | 15:40 |
didrocks | I guess it's what making the tests flacky on our infra sometimes | 15:41 |
Saviq | didrocks, it involves a bigger move of responsibility from powerd to the shell | 15:41 |
didrocks | so, you think not going to happen anytime soon? | 15:42 |
Saviq | didrocks, no one is working on it atm AFAIK | 15:42 |
didrocks | Saviq: maybe the workaround (dully commented) would make sense then, wdyt? | 15:42 |
Saviq | didrocks, let's see next week, we might just schedule that work instead | 15:43 |
didrocks | Saviq: ok, let's keep in touch | 15:43 |
didrocks | Saviq: but come on, it's Friday evening, it's time to take important decision :) | 15:43 |
didrocks | upload | 15:43 |
didrocks | and forget ;) | 15:43 |
Saviq | didrocks, also, I'm not sure I want to make people wait for 30s for their shell to restart... | 15:44 |
Saviq | didrocks, by default, that is | 15:44 |
didrocks | Saviq: hum, maybe autopilot should ship a different upstart job | 15:44 |
didrocks | Saviq: that would make sense | 15:44 |
didrocks | or ogra's developer mode | 15:44 |
didrocks | let me put that on a sticky note | 15:44 |
Saviq | didrocks, just an .override is enough | 15:45 |
Saviq | didrocks, yeah, I'd say dev mode | 15:45 |
didrocks | Saviq: yeah, I wonder just if that should be in autopilot or in a "developer mode" | 15:45 |
didrocks | yeah, I would tend for the second as well | 15:45 |
pstolowski | tsdgeos, added a comment | 16:05 |
tsdgeos | tx | 16:05 |
Saviq | greyback, bug #1256360 - somewhere between u-mir and mir? | 16:10 |
ubot5 | bug 1256360 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in glDeleteTextures()" [Medium,New] https://launchpad.net/bugs/1256360 | 16:10 |
Saviq | greyback, happens *rarely* on shutdown | 16:10 |
greyback | Saviq: whoa | 16:10 |
Saviq | greyback, yeah | 16:10 |
greyback | Saviq: I'd guess more a Mir bug. Will reassign | 16:11 |
Saviq | greyback, yeah, indeed | 16:11 |
* Saviq is happy with our release yesterday - a ton of bugs fixed, quite some new features *and* no apparent regressions :) | 16:14 | |
tsdgeos | noones mad yet? | 16:15 |
Saviq | tsdgeos, exactly! | 16:17 |
* Saviq pressed ctrl+shift+m in Firefox... nice! | 16:17 | |
Saviq | tsdgeos, btw, when reading the dash doc, please do comment anywhere you have doubts | 16:20 |
tsdgeos | ok | 16:20 |
tsdgeos | anyone has a clue of what "Smart casual" means as dress code in the x-mas party? | 16:29 |
tsdgeos | so i need to bring my suit? | 16:29 |
Saviq | tsdgeos, http://lmgtfy.com/?q=smart+casual :) | 16:32 |
tsdgeos | Saviq: it has *evetything* in it | 16:32 |
tsdgeos | not really helpful :D | 16:33 |
Saviq | tsdgeos, exactly :) | 16:33 |
Saviq | tsdgeos, !shorts, basically ;) | 16:33 |
tsdgeos | damn! here i was in london december hoping to wear shorts | 16:33 |
Saviq | tsdgeos, you'll be amazed! ;D | 16:34 |
tsdgeos | i'm not from the north pole :D | 16:35 |
mhr3 | tsdgeos, just yesterday i saw a guy walking in shorts and tshirt :P | 16:43 |
tsdgeos | mhr3: he most have been from the north pole | 16:43 |
tsdgeos | or he was incredibly drunk | 16:43 |
tsdgeos | Saviq: can't find any real doubt that you have not asked already | 16:44 |
mhr3 | tsdgeos, it's actually surprisingly warm for end of november | 16:44 |
mhr3 | although not shorts-warm | 16:44 |
Saviq | tsdgeos, good :) | 16:45 |
tsdgeos | that said i'm got to head off for a nice eod | 16:45 |
tsdgeos | talk to you on sunday/monday | 16:45 |
tsdgeos | s/talk/see | 16:45 |
* tsdgeos waves | 16:46 | |
mhr3 | robru, ping? | 17:15 |
robru | mhr3, hey | 17:15 |
om26er | JFYI -- new unity8 is crashy. | 17:58 |
mzanetti | om26er: hmm... details? | 18:11 |
om26er | mzanetti, the number of random crashes have topped with the latest release. I am going to start reporting bugs for that. | 18:12 |
om26er | Also it seems Music scope is broken. You can see music carousel but you cannot open any preview | 18:13 |
mzanetti | om26er: hmm... what version are you talking about? | 18:13 |
om26er | mzanetti, 7.84+14.04.20131128.2-0ubuntu1 | 18:14 |
mhr3 | saviq, i have a new job title for you "merge re-approver" ;) | 18:15 |
mzanetti | mhr3: I'm sure he has a bot for that | 18:16 |
mzanetti | unless Cimi's suspicion is true indeed | 18:16 |
mhr3 | mzanetti, i think he has bot for all the other stuff and reapproving merges is the only thing he does ;) | 18:16 |
mzanetti | :D | 18:16 |
Saviq | shh | 18:17 |
mhr3 | saviq, btw does https://launchpadlibrarian.net/157894305/buildlog.txt.gz rings any bells? | 18:22 |
Saviq | mhr3, nope, what that? | 18:53 |
Saviq | mhr3, can try to see in local sbuild | 18:53 |
Saviq | ah lp:~unity-team/unity8/new-scopes | 18:53 |
=== salem_ is now known as _salem | ||
Saviq | aaaargh | 18:57 |
Saviq | why does bzr bd suddenly complain about changes grrrh | 18:57 |
Saviq | mhr3, built just fine here | 19:07 |
Saviq | mhr3, it looks like some python package failure | 19:07 |
Saviq | since python:any (>= 2.7) which is a virtual package., python3:any which is a virtual package. | 19:08 |
Saviq | mhr3, does that go into daily-build-next? | 19:09 |
Saviq | mhr3, maybe that's why it fails? | 19:09 |
Saviq | hmm no, the ppa is almost empty for trusty.. | 19:11 |
Saviq | aargh and now timeouts and OOPSes from LP | 19:12 |
Saviq | oh and I can't even restart it :/ | 19:13 |
Saviq | mhr3, there seems to have been some python transition happening (I just got new py3.3), maybe that's why | 19:14 |
Saviq | robru, hey, could you please kick another build of https://code.launchpad.net/~ubuntu-unity/+recipe/unity8-daily-custom ? | 19:15 |
=== _salem is now known as salem_ | ||
Saviq | or shed any light on the dependency wait... | 19:15 |
robru | Saviq, were any steps taken to fix the dependencies? | 19:16 |
Saviq | robru, probably not... the deps are fine, it just built in sbuild for me locally | 19:16 |
Saviq | wonder if W: GPG error: http://ppa.launchpad.net trusty Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 4551428E52D62F45 has any bearing | 19:16 |
robru | Saviq, ok i can kick the build but i'm not very familiar with that recipe. the missing dependencies don't make sense to me | 19:18 |
Saviq | robru, yeah they don't | 19:18 |
Saviq | robru, most probably the kick won't do anything | 19:18 |
robru | Saviq, ask sil2100 i guess? he made the recipe. | 19:19 |
Saviq | robru, doesn't matter the recipe, really... it's just unity8 + some changes on top | 19:19 |
Saviq | robru, and python:any (>= 2.7)... kind of should be there | 19:19 |
Saviq | robru, anyway, nevermind, we'll see next week | 19:20 |
robru | Saviq, last time i saw an error like that, it was because the version being depended on hadn't finished building in the archive yet. | 19:20 |
Saviq | robru, yeah, I just got py3.3 update | 19:20 |
Saviq | robru, so the builds will kick in again when the dependency is fulfilled? | 19:21 |
robru | Saviq, i mean more like this kind of thing: http://bazaar.launchpad.net/~unity-team/unity8/new-scopes/view/head:/debian/control#L71 where you specify a certain version. although that one is months old so i don't see why it would hold it back... | 19:21 |
robru | Saviq, mmm, no, launchpad recipes only rebuild when there are commits to the branches references in the recipe. it won't know anything about the dependencies. | 19:21 |
Saviq | robru, ok, please just kick a build for the sake of making sure that (doesn't) help | 19:22 |
robru | Saviq, yeah, already did | 19:22 |
Saviq | robru, ok thanks | 19:22 |
Saviq | alesage, https://code.launchpad.net/~allanlesage/unity8/indicator-stubs/+merge/192059/comments/456254 | 19:25 |
Saviq | alesage, got lost in all the jenkins messages | 19:25 |
Saviq | alesage, just drop the ": undefined" | 19:25 |
alesage | Saviq, o ok, my mistake, I see | 19:25 |
alesage | Saviq, yes I confess to scrolling too much :/ | 19:26 |
Saviq | alesage, no worries :) | 19:31 |
mhr3 | saviq, i already brought it up with seb and on #ubuntu-devel, might be something with the builders, was just wondering if you haven't seen it before | 19:50 |
mhr3 | simple no would do :) | 19:51 |
=== salem_ is now known as _salem | ||
=== _salem is now known as salem_ | ||
Saviq | mhr3, I don't do "simple no" ;) | 20:32 |
Saviq | no go, unfortunately | 20:32 |
=== salem_ is now known as _salem |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!