=== iahmad is now known as iahmad|afk [08:39] Saviq: https://code.launchpad.net/~aacid/unity8/remove_unused_applications_folder/+merge/197058 up [08:39] tsdgeos, cheers [08:48] sil2100, still no unity-scopes-api? :/ [08:50] didrocks: could you maybe NEW unity-scopes-api from the queue? As it seems people were a bit busyish yesterday :) [08:51] sil2100: was it preNEWed? [08:52] didrocks, yes, I +1ed it [08:52] ok, pushing buttons then [08:52] didrocks: yes, before releasing by seb128, so it's all ok - it's waiting in the queue since 2 days [08:52] didrocks: thank you! [08:52] sil2100: done :) [08:52] well, seb128 did the hard work ;) [08:52] mhr3: tadaah! [08:52] I just pushed a button [08:52] ;-) [08:52] ;) [08:52] (well 2 a checkbox + a button) [08:52] weeeeeee! [08:52] phew [08:52] can go on week-end I gues now :p [08:52] sil2100, mhr3, didrocks: good morning, happy friday! [08:52] happy friday seb128 ;) [08:52] guess* [08:53] Good morning! And a happy Friday indeed ;) [08:53] seb128, a very black friday to you as well! [08:53] mhr3, you must be confused, I'm not one of those turkey eaters [08:53] we don't do that here [08:53] * seb128 doesn't shop today [08:54] seb128, but you're still in northern hemisphere so it's dark-ish these days :) [08:54] I guess one can say that ... [08:55] Black Friday will find you when you least expect it! [08:56] like amazon.co.uk has BF deals ;) [09:05] tsdgeos, mzanetti, hey, could one of you do https://code.launchpad.net/~gerboland/unity-mir/more-robust-desktop-file-parsing/+merge/190917 ? it's partly my code, so... [09:06] sure [09:06] i'll do [09:08] tsdgeos: please wait before approving. need to check something [09:09] no no no [09:09] i'll approve right away :-P [09:12] mzanetti, dandrader you have a weird definition of "disregard" ;) [09:12] :P [09:12] but thanks! ;) [09:13] Saviq, I'm missing context [09:13] cannot parse :) [09:14] dandrader, the email last night [09:14] dandrader, the testing one [09:14] Saviq, ah right [09:14] I just love replying to e-mail [09:14] dandrader, oh, want some of mine? ;D [09:15] Saviq: no tests in https://code.launchpad.net/~gerboland/unity-mir/more-robust-desktop-file-parsing/+merge/190917 ?¿ [09:15] Saviq, I would probably not be able to fill those replies with useful content though :) [09:16] tsdgeos, right [09:16] tsdgeos, ok leave a comment about that [09:16] tsdgeos, good time as any to add them [09:16] or actually the best time [09:17] at least for the thing we're supposing to fix [09:17] not for the whole thing [09:18] tsdgeos, yeah [09:18] Saviq, did I receive a mail at your 2:46am?? [09:18] Saviq, or is it your bot? :) [09:18] Cimi, WHAAAAAT?! [09:19] Saviq, the testing testing [09:19] Cimi, read into the WHAAAAT [09:19] ;P [09:20] Saviq, go to bed and sleep boss :P [09:21] Cimi, I did, soon thereafter [09:22] I slept nothing, Evan invited me for the Thanksgiving turkey [09:22] I had that much food I'm still digestng [09:22] that was tough [09:24] Cimi, shouldn't you be knifing your way through a mall now, then? [09:24] Saviq, all I can say now is "burp" [09:25] :D [09:25] Saviq, I learnt so much last night about american traditions [09:26] Saviq, for example why all americans take the whole week off to face thanksgiving [09:26] ;) [09:26] Saviq, and that's it's basically just an excuse to train your body for xmas lunch [09:27] burp [09:27] do you guys know if there's a launchpad page with "reviews i'm doing"? [09:27] mmm [09:27] i usually use https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews and then head over the "Reviews I am doing" section [09:27] but then https://code.launchpad.net/~gerboland/unity-mir/more-robust-desktop-file-parsing/+merge/190917 doesn't show up there [09:28] because it's unity-mir and not unity8 [09:28] tsdgeos, https://code.launchpad.net/~cimi/+activereviews [09:28] awesome! [09:28] now that list some old old old reviews :D [09:29] tsdgeos, yeah I realised it's kind of embarrassing :D [09:29] hmmm [09:30] Hi guys, did anyone of you notice unity7/bamf acting strangely since a while on the desktop? [09:30] sil2100, define "strangely", and no [09:30] sil2100: like dropping all the indicators? [09:30] at the moment i only have the messaging and keyboard one around [09:30] seb128: for instance, if I open nautilus from the launcher, close it, and then click on the nautilus icon again - it doesn't want to start the app [09:30] don't even know what time it is damnit! [09:31] tsdgeos: that as well, but rarely! [09:31] tsdgeos, stop playing with unity8 in your sessions :p [09:31] seb128: as if the launcher (bamf) didn't register that I closed the nautilus window [09:31] I think I'll have to fill in a bug [09:31] sil2100, nop, no such issue here (and I didn't see any complain about it) [09:31] sil2100, are you running trusty or daily-build ppa? [09:32] seb128: trusty, without daily-build [09:32] weird [09:32] is the issue specific to nautilus? [09:33] seb128: no, it happens for every app here - like firefox as well, I have to open up firefox by middle-clicking on the icon as if I want to open a new window [09:33] weird [09:33] no, definitively not happening here [09:33] I would have noticed [09:33] hmm, ok, I'll ask around and fill in a bug, maybe something wrong on my system [09:34] sil2100, does it happen in a guest session? [09:34] seb128: I guess that's a good idea, I'll check that after the meeting [09:37] Cimi: you proposed https://code.launchpad.net/~unity-team/unity/phablet.delay-highlight/+merge/150867 can we kill it? [09:39] * mzanetti wonders why an upgrade brings back the ebay app but doesn't bring back the amazon app [09:39] tsdgeos, mmm how about the comment of that guy? [09:41] Cimi: tsdgeos: imho this is a bad thing to change [09:41] because the highlight is supposed to indicate that it will execute a press if you release now [09:41] there is no point in delaying that [09:42] +1 [09:42] basically my "You can click on it without it ever being highlighed (not sure if that's bad, but seems weird to me)" [09:42] Cimi: anyway i'm rejecting since it's against the wrong project [09:42] "lp:unity/phablet" [09:42] tsdgeos, ok [09:46] mzanetti, tsdgeos, Cimi, yeah, the Flickable::pressDelay is meant to cater for that http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-flickable.html#pressDelay-prop [09:46] but all in all, I don't think this is an issue any more, as we're not highlighting the whole items [09:47] ok https://code.launchpad.net/~aacid/+activereviews is looking much better now that we've reject very old stuff :D [09:47] and even if it is an issue, we'd need to solve it across the board, not just for unity8 [09:47] +1 [09:49] tsdgeos, what do you think we could do about the default Flickable velocities? [09:49] Saviq: make them pixel density dependant [09:49] tsdgeos, upstream, that is [09:49] Saviq: there's a patch by Florian to properly implement that [09:49] tsdgeos, ah ok [09:49] in 5.[1|2] [09:50] Saviq: that = proper pixel density reporting to Qt [09:50] not sure it does indeed fix the flickable velocity [09:50] but once we do report the proper pixel density stuff in the QPA [09:50] if it doesn't work [09:50] we should fix it upstream [09:50] yes [09:51] tsdgeos, works for me [09:51] Saviq: mind if i reject https://code.launchpad.net/~paulliu/unity/phablet-fake-peoplepreviewdata/+merge/161514 ? since all the people* stuff is gone [09:52] tsdgeos, +1 === dandrader is now known as dandrader|afk === rachelliu_ is now known as rachelliu === dandrader|afk is now known as dandrader [10:20] dandrader: hi ho [10:22] tsdgeos, hi ho [10:22] dandrader: do you think it'd make sense to add to https://code.launchpad.net/~dandrader/unity8/runningAppsEndClose/+merge/196257 one test that uses touch and not mouseClick? [10:28] Saviq: https://code.launchpad.net/~aacid/unity8/remove_unused_applications_folder/+merge/197058 aborted? [10:28] tsdgeos, didn't get it [10:29] tsdgeos, there are tests for mousePress and touch press [10:29] are tehre? [10:29] tsdgeos, yes [10:29] tsdgeos, folks are fighting with some instabilities in CI AFAICT [10:29] dandrader: not in tst_RunningApplicationsGrid.qml ? [10:29] tsdgeos, I'll be monitoring [10:29] /food, first [10:29] tsdgeos, ah, I'm talking about tst_PressedOutsideNotifier.cpp [10:30] dandrader: so you think there's any value at all adding the test? or the one in tst_PressedOutsideNotifier.cpp should be enough? [10:34] tsdgeos, yeah, I think tst_PressedOutsideNotifier on that regard [10:34] is enough [10:34] oki [11:01] Saviq, I've put up an unity-notifications-MR for for LP: #1256011 ... but what about LP: #1239421? I'm not sure what's required there... or can I leave that for Jussi? [11:01] Launchpad bug 1256011 in unity-notifications (Ubuntu) "Should install shell-facing plugins in plugin path from libunity-api-dev" [Low,In progress] https://launchpad.net/bugs/1256011 [11:01] Launchpad bug 1239421 in unity-notifications "unity-notifications isn't using unity-apis" [Undecided,New] https://launchpad.net/bugs/1239421 [11:03] dandrader: what's the timer in tst_PressedOutsideNotifier.qml for? [11:03] * dandrader checks [11:04] tsdgeos, ah, it's for the effect to be visible when manually testing [11:04] right [11:04] tsdgeos, otherwise you won't see it red for long enough [11:11] MacSlow, the latter is about extracting abstract base classes from unity-notifications into unity-api (or well, adapting the ones that are already there) [11:11] MacSlow, and making use of them in unity-notifications, as well as running the test suite from unity-api against unity-notifications [11:11] greyback, ping [11:12] Saviq, ok [11:13] MacSlow, but yeah, it's not necessarily something you should be doing [11:14] Saviq, true... I don't want to "hijack" lp:unity-notifications ... [11:14] Saviq, the CMakeFile fix was harmless... but 1239421 look more involved and I rather leave that to the API-team [11:14] dandrader: technically window(); could return null in setupEventFiltering when removed from a scene, do we care about that? [11:15] MacSlow, +1 [11:15] Saviq, today is review/cleanup-day anyway [11:17] tsdgeos, it's only called from within " if (isEnabled() && window()) {} " [11:17] tsdgeos, so if window() returns null there it *should* crash [11:17] dandrader: it certainly is [11:17] ok [11:19] tsdgeos, but maybe a Q_ASSERT(currentWindow) would go in order to state intention [11:19] dandrader: it's ok to me either way [11:24] MacSlow, did you test https://code.launchpad.net/~mzanetti/unity8/desktopfile-to-appid/+merge/197154 extensively on the device? That launcher, home apps, installed apps, webapps all still work fine? [11:24] mzanetti, think we could test ↑? [11:24] Saviq: this only names the arguments actually [11:24] doesn't really change anything in the logic [11:25] but sure. I'll do another test run [11:26] mzanetti, no I mean if we have some automated tests for this - if not, now would be a good time to add them [11:28] Saviq: yep. there are tests [11:29] mzanetti, ok [11:29] Saviq: tst_Shell.qml: test_tapOnAppIconInLauncher() [11:29] Saviq: that runs through this === dandrader is now known as dandrader|lunch [11:34] Saviq, not all... but I can repeat it with more checks === _salem is now known as salem_ [11:37] dandrader|lunch: how are you ahving lunch before me if you're like more to the west? [11:37] :D [11:38] dandrader|lunch: anyway, i was wondering if we can't just hijack the touch event by returning true at some point in the evenFilter and save us from all that timer stuff which looks a bit hacky [11:38] tsdgeos, by being really hungry? ;) [11:39] tsdgeos, MacSlow and getting up at 4am ;) [11:39] that too [11:39] Saviq, an empty stomach make one do crazy things :) [11:41] today is also "let's forget 3rd-person s"-day [11:43] [08:29:48] *** Joins: dandrader [11:43] http://www.timeanddate.com/worldclock/converted.html?iso=20131129T0830&p1=664&p2=213 [11:44] he's preventing jetlag ;) [11:45] Saviq, mzanetti: really nothing fails with lp:~mzanetti/unity8/desktopfile-to-appid [11:45] MacSlow, that's good 'innit === MacSlow is now known as MacSlow|lunch === dandrader|lunch is now known as dandrader [12:12] tsdgeos, I started working at 5:30 am, so lunch at 9:30 am :) [12:13] tsdgeos, and as a bonus a nice sunny afternoon to go outside after work [12:14] +1 [12:14] tsdgeos, the point is to not interfere with the normal event processing. we're just monitoring it, not filtering it out [12:16] tsdgeos, but I do agree that that timer is not the best thing in the world, thus the big comment [12:19] dandrader: ok, can you write that comment "the not interfere" thing in the MR so it's there for posterity if we ever go back and wonder why it was done that way? [12:28] tsdgeos, done [12:35] Saviq, the filters should be testable in a couple of days again. [12:50] sil2100, ping? [12:50] mhr3: pung [12:50] sil2100, which was the ppa i can use? [12:51] mhr3: ppa:ubuntu-unity/daily-build-next [12:51] sil2100, i'm afraid i don't have upload rights there [12:51] Wait, you're not part of ubuntu-unity? [12:52] doesn't seem so [12:52] can someone add me? [12:52] didrocks, ^? [12:52] I guess you should be, as you're working on unity stuff === MacSlow|lunch is now known as MacSlow [12:53] didrocks: you think that's possible to do? Need to check who's an admin as well [12:53] didrocks is admin :) [12:53] mhr3: hum, I can't add you to that team for policy reason [12:53] because it would give an indirect way for you to upload to the archive :) [12:54] didrocks, you don't trusty me? :P [12:54] mhr3: ahah, not that question, but I don't want to rediscuss with the tech board about who can be in that team :p [12:56] can someone with proper rights create the recipe and i'll be just firing it from time to time? [12:56] bbiab [12:57] not sure if that would work [12:57] but let's give it a try? [12:57] sil2100, ^ [12:58] mhr3: yep, neat idea! [12:59] and i hope you guys made sure that pkgs from that ppa won't bubble through some script to the distro automagically [12:59] mhr3: well, as long as it's in daily-build-next, it won't [12:59] good [12:59] we only wire up daily-build ppa [13:00] but we can't have per ppa upload rights [13:01] i guess ubuntu-unity has to own the recipe though, otherwise i'll fail to upload? === pete-woods1 is now known as pete-woods === _salem is now known as salem_ [13:07] Uuuu [13:07] I forgot that ubuntu-unity became so important ;p === dandrader is now known as dandrader|afk [13:47] didrocks, think we should put "kill timeout 30" by default in the unity8 upstart job? [13:48] didrocks, so that we get meaningful .crash files from QA? [13:48] Saviq: is 30 enough? [13:48] on maguro? [13:48] didrocks, will test first [13:48] Saviq: yeah, try maguro first I guess, and tweak the value for it [13:48] on the idea +1 [13:48] didrocks, there can even be a test for it, FWIW [13:49] didrocks, ok, will ponder some [13:49] you send a SIGINT to unity8, ask upstart to stop it, yeah ;) [13:52] didrocks, actually no, I though of sending SIGSEGV [13:53] didrocks, and making sure apport completes before unity8 is killed [13:53] Saviq: yeah, that's another way of seeing it (not sure all stacktraces are equals though! ;)) [13:53] didrocks, will wait for the shell to be ready first [13:54] didrocks, and that should make it pretty real [13:56] * Saviq needs a HOWTO for working with errors.u.c [13:57] saviq, you can ask ev next week :) [13:57] mhr3, yeah === dandrader|afk is now known as dandrader [13:59] didrocks, only thing I'm worried about is that if we let it linger for 30s, the screen might go to sleep before apport completes :/ [14:00] Saviq: shouldn't whoopsie blocks suspend? [14:00] I meant, this is in the kernel [14:00] not whoopsie [14:00] so should be fine and not powering off? [14:00] didrocks, different than screen being turned off [14:00] didrocks, I don't mean the whole device [14:00] didrocks, but just the screen [14:01] what's the issue then? === salem_ is now known as _salem [14:12] didrocks, when it turns off, u8 will fail to start next time [14:37] Saviq: I find your lack of respect for Y-fronts disturbing [14:37] Saviq, can you recall where the sdk icons are installed to? [14:38] greyback, lool [14:38] greyback, I googled y-front [14:38] greyback, I blame YOU [14:38] Saviq: XD [14:38] Saviq, >_< [14:38] greyback, you owe me for therapy [14:38] Saviq, try magic underpants [14:38] nic-doffay__, no. kthxbai [14:39] greyback, distress [14:41] mzanetti, can you recall where the icons are installed which the Icon class accesses? [14:41] I remember chatting about this to you before. [14:43] nic-doffay__: dpkg -L ubuntu-mobile-icons [14:43] mzanetti, cheers === _salem is now known as salem_ [14:50] Saviq, re your comment in the filters 'We've decided this will have to wait for the upcoming new scope backend.' [14:50] Can you let me know when I should take up development on the branch actively again? [14:50] nic-doffay__, of course, will do [14:50] Saviq, wicked [15:09] mhr3, pstolowski looking at https://launchpadlibrarian.net/157889220/StacktraceSource.txt [15:09] bug #1256342 is actually a mediascanner one then [15:09] bug 1256342 in libunity (Ubuntu) "unity-scope-loader crashed with SIGABRT in __gnu_cxx::__verbose_terminate_handler()" [Medium,New] https://launchpad.net/bugs/1256342 [15:10] potentially a dupe of 1239561 ? [15:10] bug #1239561 [15:10] bug 1239561 in mediascanner (Ubuntu) "mediascanner-service crashed with SIGABRT in raise()" [High,Confirmed] https://launchpad.net/bugs/1239561 [15:11] hard to say from that bug [15:11] anyway, mediascanner is waving byebye [15:11] so i guess we don't care [15:11] :) [15:24] Saviq: ok, so here it is https://code.launchpad.net/~aacid/dee-qt/more_tests/+merge/197220 who do you think can review? [15:25] tsdgeos, try forcing mhr3's or pstolowski's hand for this ;) [15:26] pstolowski: do you think you can review https://code.launchpad.net/~aacid/dee-qt/more_tests/+merge/197220 ? It's an old branch from kalikiana that i've reused some tests [15:27] tsdgeos, last time i checked dee-qt had ~96% test coverage [15:27] mhr3: feel free to reject it :D [15:28] i'm just trying to salvage the tests [15:28] but if you don't think we need them [15:28] fine [15:29] it has lots of changes that are clearly not just test-related [15:30] like? [15:30] i can count 2 changes that are not test related [15:31] 3 [15:31] append() remove() model() [15:31] they are totally test related [15:31] i even say so on the comment i made [15:32] but that turns read-only dee wrapper into read-write, which i'd say is a big thing [15:32] well if you read the comment i made [15:32] it would be great [15:32] oh :) [15:32] i read only description on new mps :P [15:32] which isn't there btw [15:32] it's not my fault you decide to read only half of the stuff [15:35] replied [15:38] Saviq: urgh, right, can you kick as post-stop script the screen on? [15:38] didrocks, pre-start rather, but I'm not sure i want to... [15:39] didrocks, the bug just needs to be fixed, bug #1235000 [15:39] bug 1236525 in unity-mir "duplicate for #1235000 unity8 killed/crash then restart can result in mir unable "could not unblank display"" [Critical,Fix released] https://launchpad.net/bugs/1236525 [15:39] Saviq: yeah, agreed [15:40] didrocks, it got converted into a blueprint WI, actually [15:40] Saviq: do you know about the priority? [15:41] I guess it's what making the tests flacky on our infra sometimes [15:41] didrocks, it involves a bigger move of responsibility from powerd to the shell [15:42] so, you think not going to happen anytime soon? [15:42] didrocks, no one is working on it atm AFAIK [15:42] Saviq: maybe the workaround (dully commented) would make sense then, wdyt? [15:43] didrocks, let's see next week, we might just schedule that work instead [15:43] Saviq: ok, let's keep in touch [15:43] Saviq: but come on, it's Friday evening, it's time to take important decision :) [15:43] upload [15:43] and forget ;) [15:44] didrocks, also, I'm not sure I want to make people wait for 30s for their shell to restart... [15:44] didrocks, by default, that is [15:44] Saviq: hum, maybe autopilot should ship a different upstart job [15:44] Saviq: that would make sense [15:44] or ogra's developer mode [15:44] let me put that on a sticky note [15:45] didrocks, just an .override is enough [15:45] didrocks, yeah, I'd say dev mode [15:45] Saviq: yeah, I wonder just if that should be in autopilot or in a "developer mode" [15:45] yeah, I would tend for the second as well [16:05] tsdgeos, added a comment [16:05] tx [16:10] greyback, bug #1256360 - somewhere between u-mir and mir? [16:10] bug 1256360 in unity8 (Ubuntu) "unity8 crashed with SIGSEGV in glDeleteTextures()" [Medium,New] https://launchpad.net/bugs/1256360 [16:10] greyback, happens *rarely* on shutdown [16:10] Saviq: whoa [16:10] greyback, yeah [16:11] Saviq: I'd guess more a Mir bug. Will reassign [16:11] greyback, yeah, indeed [16:14] * Saviq is happy with our release yesterday - a ton of bugs fixed, quite some new features *and* no apparent regressions :) [16:15] noones mad yet? [16:17] tsdgeos, exactly! [16:17] * Saviq pressed ctrl+shift+m in Firefox... nice! [16:20] tsdgeos, btw, when reading the dash doc, please do comment anywhere you have doubts [16:20] ok [16:29] anyone has a clue of what "Smart casual" means as dress code in the x-mas party? [16:29] so i need to bring my suit? [16:32] tsdgeos, http://lmgtfy.com/?q=smart+casual :) [16:32] Saviq: it has *evetything* in it [16:33] not really helpful :D [16:33] tsdgeos, exactly :) [16:33] tsdgeos, !shorts, basically ;) [16:33] damn! here i was in london december hoping to wear shorts [16:34] tsdgeos, you'll be amazed! ;D [16:35] i'm not from the north pole :D [16:43] tsdgeos, just yesterday i saw a guy walking in shorts and tshirt :P [16:43] mhr3: he most have been from the north pole [16:43] or he was incredibly drunk [16:44] Saviq: can't find any real doubt that you have not asked already [16:44] tsdgeos, it's actually surprisingly warm for end of november [16:44] although not shorts-warm [16:45] tsdgeos, good :) [16:45] that said i'm got to head off for a nice eod [16:45] talk to you on sunday/monday [16:45] s/talk/see [16:46] * tsdgeos waves [17:15] robru, ping? [17:15] mhr3, hey [17:58] JFYI -- new unity8 is crashy. [18:11] om26er: hmm... details? [18:12] mzanetti, the number of random crashes have topped with the latest release. I am going to start reporting bugs for that. [18:13] Also it seems Music scope is broken. You can see music carousel but you cannot open any preview [18:13] om26er: hmm... what version are you talking about? [18:14] mzanetti, 7.84+14.04.20131128.2-0ubuntu1 [18:15] saviq, i have a new job title for you "merge re-approver" ;) [18:16] mhr3: I'm sure he has a bot for that [18:16] unless Cimi's suspicion is true indeed [18:16] mzanetti, i think he has bot for all the other stuff and reapproving merges is the only thing he does ;) [18:16] :D [18:17] shh [18:22] saviq, btw does https://launchpadlibrarian.net/157894305/buildlog.txt.gz rings any bells? [18:53] mhr3, nope, what that? [18:53] mhr3, can try to see in local sbuild [18:53] ah lp:~unity-team/unity8/new-scopes === salem_ is now known as _salem [18:57] aaaargh [18:57] why does bzr bd suddenly complain about changes grrrh [19:07] mhr3, built just fine here [19:07] mhr3, it looks like some python package failure [19:08] since python:any (>= 2.7) which is a virtual package., python3:any which is a virtual package. [19:09]