=== duflu_ is now known as duflu === m_conley is now known as m_conley_away === m_conley_away is now known as m_conley === _thumper_ is now known as thumper === m_conley is now known as m_conley_away [05:16] Laney: sure you can mock upower in autopilot tests; whatever makes sense (i. e. unless you are testing upower itself) === tvoss|dinner is now known as tvoss === tvoss is now known as tvoss|test === tvoss|test is now known as tvoss [09:04] morning [09:05] hey pitti, thanks - was just wondering if that kind of thing is usually done for those tests, or if it should be testing the whole system [09:05] Laney: usually not; if you try to test too many things at once, tests tend to become flaky and too hard to analyze [09:05] indeed [09:06] Laney: I have this "ladder" picture: [09:07] test the kernel against real hw, test system services like upower against simulated kernel output (like with umockdev), test userspace/session stuff like indicator-*-service against mocked d-bus services (dbusmock), test UIs against session d-bus mocks [09:08] Laney: so if your autopilot test is supposed to check the UI, feel free to mock anything underneath it where the real thing is impractical to set up [09:09] seb128: bonjour, ça va ? [09:09] pitti, salut, oui, et toi ? [09:10] seb128: FYI, I uploaded autopkgtest, but from your POV this is mostly a cosmetical fix [09:10] pitti: neat, I want to do that because we have UIs which respond to the number of batteries and things so it'd be good to test the different scenarios [09:10] hey seb128 [09:10] pitti, right, I just saw the emails, thanks! (and yeah, that's orthogonal to the bug) [09:10] hey Laney, how are you? [09:10] seb128: you need to fix the stderr output for gtk, by either updating the test to avoid the deprecation warning, or by redirecting stderr [09:10] pitti, I fixed that yesterday, and wanted to test another change and then it was eod and I didn't manage to upload [09:10] seb128: (the former obviously being better, as we want to fail on unexpected warnings) [09:11] seb128: and gnargh for gcc not respecting the locale :) [09:11] seb128: ah, great [09:11] I'm going to upload in a bit [09:11] * seb128 reads http://news.cnet.com/8301-1035_3-57615107-94/ubuntu-touch-os-wins-its-first-smartphone-partner/ [09:11] Laney: yes, that's precisely the case where a mock is better; we have tests to ensure that the mock is compatible to the real upower [09:11] seb128: just did that as well [09:11] seb128: my first thought: "OMG, would you give this man $5M?" :-) [09:12] hahaha [09:12] * pitti liked sabdfl better without the beard [09:12] pitti++ [09:12] hahaha [09:12] it's trendy these days you know [09:13] Movember is over. [09:14] nah, it's wider than that - see Paxman, Ben Affleck etc [09:27] pitti: my mailer sucks -> for i in `ls /run/user/*/upstart/sessions/*.session`; do (export `cat $i`; initctl restart indicator-session) ; done [09:27] one-liner. [09:28] can't system upstart rebroadcast events to session upstart? [09:29] xnox, pitti, Laney: we should just tell the user to restart the session [09:29] other stuff are not going to work [09:30] e.g nautilus "change background" desktop menu [09:30] yup [09:36] Laney: it rebroadcasts events, but "restarting" something is not an event. [09:37] you could have an event which causes that to happen [09:37] Laney: it's a direct action / changing goals which only controlling init can do via dbus api. I guess we could make restart honour "--global" and do it across all active sessions. [09:37] Laney: there is no "restart on", only start on and stop on. [09:38] exec restart foo [09:38] how is that any better than doing it byhand for each session? =) [09:39] we already have one such restart job though (it's to tell inits to reconnect to system init, upon system init re-exec) [09:39] Laney: i presume you mean add a user-session job task which does: exec restart $JOB_TO_RESTART. And then system init just emits an event for that to happen. [09:40] Some generic thing like that, yeah [09:40] well we can even do $COMMAND_TO_RUN $JOB_TO_RESTART as well. [09:41] Not sure what I think about it philosophically [09:41] the golden rule and all [09:42] it does sound to me as abusing the rules, on the other hand the postinst only need to succeed / check that it emitted the system event successfully, and need not to care if there are any session inits running, or whether they have indicator-session running, if whether that restarted or not. So it would be embracing the event base pagadim. [09:42] not sure if that is taking it too far or not ;-) [09:43] then again on touch, i hope we will stop apps on upgrade via upstart. [09:47] didrocks, sil2100, Mirv: hey, so ubuntu-system-settings trunk has an autopilot packages with some tests now ... how do we get that plugged into CI? [09:48] ara, cyphermox: For bug 861171, have you decided whether the confirmation of terminating other sessions should require you to authenticate or not? [09:48] Launchpad bug 861171 in OEM Priority Project precise "Shutdown from greeter does nothing when multiple accounts open" [High,In progress] https://launchpad.net/bugs/861171 [09:49] seb128: I guess for CI-per-merge we would need to poke Francis (or someone else from the QA team that knows his way around) - as for cu2d, we can do that [09:49] cu2d part via lp:cupstream2distro-config indeed [09:49] seb128: but we're not really using cu2d that much for testing as we were in the past [09:50] sil2100, well, I'm not uptodate on those stuff, when are autopilot tests run nowadays and how do we get u-s-s ones added there? [09:50] e.g what do you recommend to do? [09:50] first test that they pass in whatever configuration they will be run in [09:50] ;-) [09:50] wfm [09:51] Laney, are you speaking about your uitk bug with /usr/local? [09:51] I don't think that should block CI enablement [09:51] seb128: ok, we can add those to cu2d if anything, can do that in a moment [09:51] sil2100, thanks! [09:52] Laney, I hope CI machines don't have stuff sudo make installed in /usr/local :p (not cookie to you for doing that btw, even if it allowed you to find a bug ;-) [09:52] haha [09:52] sil2100: can you take care of that one please? :) [09:53] thanks! [09:53] I am not blocking anything [09:53] I'm just saying that it should actually pass before turning it on [09:53] also it was from bisecting evolution to find a bug [09:53] also you only need to have an empty directory there, not even anything installed! [09:54] and lastly the tests fail if you don't have a battery ;-) [09:55] Laney, well, tests pass for Victor (who submitted them) and for me [09:55] Laney, I didn't know about the battery one, seems like one thing to fix indeed [09:55] you're arguing for not trying them out? [09:56] Laney, are they working for you out of that one? or do you have other issues? [09:56] hum [09:56] just that one [09:56] no, I'm not "arguing" [09:56] for me they are passing [09:56] so I didn't understand your "I'm just saying that it should actually pass before turning it on" [09:56] I mean that we should know they pass in the test environment [09:56] oh [09:56] I suppose we'll get that at the first run anyway [09:56] how do we do that? [09:57] but it'll be annoying if it all explodes [09:57] e.g can we connect to the test environment and run them there manually? [09:57] not sure [09:57] sil2100, ^ [09:58] seb128: yes, it can be done [09:58] seb128: once the stack is redeployed with the config we can do a manual run of the tests there [09:58] sil2100, can anyone do that/how? [09:59] sounds fine [09:59] seb128: anyone that has cu2d power can do that by going to the AP trusty jobs and firing them manually with stack parameters [10:00] sil2100, ok, I'm not sure I want to look at that today, can you do it for us? ;-) [10:00] seb128: sure :) I'll do it right after the setup and inform you [10:00] * Laney is looking at mocking upower atm to test the battery / no battery case [10:00] ogra_, hey, new webkit in trusty should fix the software-center issues, let me know if it works for you (I want confirmation before SRUing to saucy) [10:00] then soon other things [10:01] seb128, wil test [10:01] Laney, I'm sure there are upower mocks you can copy from other places (maybe indicator-power?) [10:01] yes, afaik dbusmock already has a template [10:01] using that one [10:01] good [10:01] Laney, https://blueprints.launchpad.net/ubuntu/+spec/client-t-system-settings-testing [10:02] [seb128] power - use pitti's upower mock to test current charge/status: TODO [10:02] ah [10:02] this isn't that, can leave that for you if you want [10:02] that's what we wrote down back then [10:02] no, that's fine [10:02] it's for the visibility of the battery panel [10:02] still testing the main screen [10:02] I had a feeling we discussed that topic a bit on Oakland, I was looking if the notes had details [10:02] right, please do it [10:03] I doubt I'm going to work on that before holidays [10:03] nod [10:03] so feel free to also steal the other ones from me [10:03] e.g if you are started on that and feel bored next week [10:03] ogra_, thanks [10:03] I'll likely do the ones I'm assigned to first [10:03] but we'll at least have examples of using dbusmock by then [10:04] yep, sounds good [10:26] Laney: python[3]-dbusmock ships a standard upower template, with some convenience functions [10:26] ah, you found out already [10:26] yeah [10:38] seb128, Laney: I have some test results: http://q-jenkins.ubuntu-ci:8080/job/autopilot-trusty-daily_release/920/ - there seems to be 1 test failing per platform [10:38] The battery plugin one [10:39] nod [10:39] where can I see the run? [10:40] the console output is super verbose [10:40] Laney: go to nvidia for insantce, you can then click on the specific test that failed [10:40] Laney: e.g. http://q-jenkins.ubuntu-ci:8080/job/autopilot-trusty-daily_release/920/label=autopilot-nvidia/testReport/junit/ubuntu_system_settings.tests.test_plugins/SystemSettingsTestCases/test_battery_plugin/ [10:40] k [10:40] fixing that one atm anyway [10:40] Thanks :) [10:41] those people have no battery :p [10:42] sil2100, thanks for running the tests! [10:42] seb128: yw! [10:48] sil2100, didrocks: could you review/ack https://code.launchpad.net/~seb128/gnome-control-center-unity/gettext-and-intltool/+merge/196545 ? [10:49] seb128: I guess you tested it? :) [10:50] didrocks, sure, CI also confirmed the fix [10:50] since it built [10:50] where https://code.launchpad.net/~seb128/gnome-control-center-unity/launcher-minimal-value hit the error [10:50] approved [10:50] 'ci [10:50] de rien ;) [11:09] happyaron, hey, could you look at https://launchpad.net/ubuntu/+source/libchewing/0.3.5-3, the autopkgtest added seems to lack build-depends (on pkg-config at least, see https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-libchewing/) [11:10] seb128: ok, will do [11:10] happyaron, thanks [11:11] happyaron, https://launchpad.net/ubuntu/+source/ibus-chewing/1.4.3-4 as well would be nice [11:11] seems an incompatibility with our ibus version? [11:12] didn't see incompatibility in Debian (binary works), but will check again in trusty [11:13] well, it fails to build on undefined stuff so I was guessing [11:13] the failing point looks like "IBUS_INPUT_PURPOSE" related, so it's the 1.5.4 CVE related I think. [11:14] thinks I need to try all ibus-* to see what happen. [11:14] mpt, I don't have a strong opinion, but I prefer your version "B" (need the person's password, but not admin rights) [11:14] ok [11:15] mpt, I think that requiring a password will make people read the message [11:15] if a password is not required, people won't read and think that it is a normal confirmation for shutdown dialog [11:17] makes sense [11:19] ara, the tradeoff is that a PolicyKit dialog can’t include a button to log out instead (or to switch user account, if the other account(s) belongs to you as well) [11:19] neat, got u-s-s to believe it has a battery [11:22] mpt, yeah, I still think having a password is better. what's your opinion? [11:24] agreed === HughHefner is now known as Alin` === Alin` is now known as Alin === Alin is now known as Guest35882 === Guest35882 is now known as constantin === constantin is now known as AlinConstantin === AlinConstantin is now known as HughHefner === HughHefner is now known as Predator === Predator is now known as Alin_ === Alin_ is now known as Constantin === Constantin is now known as AlinConstantin === AlinConstantin is now known as Alin69 === Alin69 is now known as Alin_ === alan_g is now known as alan_g|afk [12:07] seb128: hey, is there any plan to include cairo 1.14 in trusty? It supports surface_device_{set,get}_scale that is used by gtk-3.10 for hight-dpi screens...? [12:08] (and we might reuse it as well) [12:10] hey, I want to set some system-wide defaults for our users (for example gnome-terminal).. is it preferable to set them in /etc/dconf or /usr/share/glib-2.0/schemas ? [12:11] Laney, seb128: do you plan a glib2.0 upload soon? [12:11] if not, I'd do one for bug 1259721 [12:11] Launchpad bug 1259721 in glib2.0 (Ubuntu) "Executing autopilot test suite fails to close when piped to tee" [Medium,In progress] https://launchpad.net/bugs/1259721 === alan_g|afk is now known as alan_g [12:11] actually no, it's sufficient to just add them in gobject-introspection [12:13] nod === MacSlow is now known as MacSlow|lunch [12:34] seb128, works fine ! thanks a lot [12:38] pitti: what about something like this: http://paste.ubuntu.com/6555832/? [12:40] I would have liked to have been able to just annotate the testcases that explicitly want or don't want a battery somehow but I didn't see a way to do that [12:40] as the setUp() launches u-s-s so you have to do it before that [12:43] Laney: I don't understand -- usually you'd call Add*Battery() in the actual test case, not in setUp() or so [12:44] Trevinho, hey, is there a such release? there was not a few days ago, I pinged #cairo to ask if they still plan to make those changes into a stable release but got no reply [12:44] ogra_, \o/ [12:44] ogra_, thanks for testing [12:44] pitti, no plan to upload glib, that's Laney's nowadays ;-) [12:45] Laney: btw, with the recent version this can become easier -- start the mock in setUpClass(), in setUp() or tearDown(), call self.obj_upower.Reset(), and drop the other cleanup and wait()/terminate() [12:45] np :) [12:45] seb128: oh.. I'm not sure about releases... I was checking on the git repo and it was targetted as that release [12:45] Laney: well, if u-s-s doesn't react to adding a battery, that's a bug [12:45] seb128: I see tarballs at http://cgit.freedesktop.org/cairo/ [12:45] Laney: you mean u-s-s only reads the battery props at startup? [12:45] Laney: running out for some (overdue) lunch, bbl [12:46] Trevinho, where? I only see 1.12 ones there [12:46] seb128: yeah, right... [12:46] seb128: the minor version confused me [12:46] pitti: Hrm, interesting [12:46] Trevinho, http://lists.cairographics.org/archives/cairo/2013-September/024594.html [12:46] Trevinho, that was the plan but that never happened [12:46] pitti: We ask if there's a battery at startup but don't carry on checking it after that [12:47] Trevinho, but otherwise yes, one of the reason we updated GTK to 3.10 was to have better hdpi support in the LTS [12:47] Laney: that's a bug (and nice that you just wrote a test for it :) ) [12:47] haha [12:48] hmmmm [12:48] yeah, I never even thought of that [12:48] interesting [12:48] veeeeeeeeeeeeeeeery interesting [12:49] ok, let's fix that :P [12:49] Laney: you can add/remove batteries during runtime, you know [12:49] I never ever even considered that [12:49] hotplugging batteries? madness! [12:49] ya, it's becoming more unusual (and I don't think it's possible on mobile devices) [12:49] Laney: but in a way, both tests are useful, coldplug and hotplug [12:50] Laney: you might get the hotplugging right and still do something wrong at coldplugging [12:50] right [12:50] Laney: so for the coldplugging case, either do two classes (with/without battery) as you did, or start u-s-s after configuring upower [12:50] * pitti hotplugs his laptop battery all the time *shrug* [12:51] I'll make the hotplugging case work and move the battery adding code up into the parent class where you can call it after starting u-s-s [12:51] exciting [12:51] I'd have to unscrew my laptop to take the battery out [12:51] apple :( [12:51] english speakers: "scroll backward" or "scroll backwards"? [12:51] what is u-s-s anyway? ubuntu-system-service? unity-screen-saver? [12:51] system-settings [12:52] Laney: non-replacable battery> cf. "bug" :) [12:52] larsu: backwards sounds better to me, but I'd probably need to see a full sentence [12:52] * pitti really lunch now & [12:52] gerrout of here [12:52] Laney: it's just for an action name, so only these two words. I lean towards scroll backwards as well, but it was "backward" before [12:52] Laney: thanks :) [12:56] np1 [12:56] ! === alan_g is now known as alan_g|lunch === MacSlow|lunch is now known as MacSlow === alan_g|lunch is now known as alan_g [14:18] Laney, I guess you are going to review https://code.launchpad.net/~attente/ubuntu-system-settings/1252489/+merge/198335 ? (I didn't follow the details of that discussion) [14:18] seb128: Will do in a bit, yeah [14:18] heinously sidetracked atm [14:18] Laney, no hurry, I was just stating that I'm going to let it to you [14:19] I'm doing the review of ken's background-art one [14:19] neat [14:20] kenvandine, I still think that header styling business is going to bite us back at some point, can you open a toolkit wishlist? [14:27] seb128, sure [14:28] seb128, bill liked the idea of splitting a component out of gallery-app to make it reusable, so i've started on that [14:29] kenvandine, ok, cool [14:29] it might make that code cleaner in gallery-app too... it's kind of a mess right now [14:41] seb128, bug 1259953 [14:41] Launchpad bug 1259953 in Ubuntu UI Toolkit "Provide overrides for header style properties" [Wishlist,New] https://launchpad.net/bugs/1259953 [14:42] kenvandine, thanks === tvoss is now known as tvoss|food === alan_g is now known as alan_g|tea [15:30] dobey, hey [15:30] dobey, just for info, https://launchpad.net/ubuntu/+source/webkitgtk/2.3.2-1ubuntu4 [15:30] dobey, that should fix the cairo/s-c issues [15:35] seb128: great, thanks [15:35] dobey, yw ;-) === alan_g|tea is now known as alan_g === gatox is now known as gatox_lunch === Sweetsha1k is now known as Sweetshark [16:12] Hello, I have an ubuntu 12.04 installation and I'm trying to give it a desktop environment. I started by installing ubuntu-desktop and making a couple changes to lightdm.conf, but when I log in, the menu in the upper right is empty: http://i.imgur.com/JB2ShYv.png Does anybody know how I can start trying to fix this? === m_conley_away is now known as m_conley === gatox_lunch is now known as gatox [16:57] arg [16:57] 'o' != 's' [17:00] finally it works [17:00] pitti: it's sensible to have the upower template emit the DeviceAdded/DeviceRemoved signals, right? [17:02] * Laney assumes so and prepares a merge === chrisccoulson_ is now known as chrisccoulson === Ursinha is now known as Ursinha-afk [20:25] oi, discourse.ubuntu.com down? === Ursinha-afk is now known as Ursinha === tkamppeter_ is now known as tkamppeter === Ursinha is now known as Ursinha-afk