=== _salem is now known as salem_ === salem_ is now known as _salem [01:11] anybody have an idea why an application menu would be titled "Unknown Application Name" instead of the name of the application? [01:12] I'm trying to add application menus to Geary, and it's working, just showing up with the wrong name, and I don't know how to make it see the correct name === duflu_ is now known as duflu === tvoss|dinner is now known as tvoss === karni is now known as Guest16420 === tvoss is now known as tvoss|test === tvoss|test is now known as tvoss [08:23] mornin' [08:23] tsdgeos, better today? [08:23] almost there [08:23] my throat still not happy [08:23] got some kind of infection i'd say, but head's mostly fine [08:23] so it's a good thing we don't talk that much in here :D [08:24] tsdgeos, good ;D [08:24] seen https://code.launchpad.net/~aacid/unity8/more_filter_fixes/+merge/198427/comments/459996 ? === iahmad_ is now known as iahmad|afk [08:24] yep [08:25] i guess the tests are not as separate one from eachoer as they should be [08:25] and i only was testing my new test isolated [08:25] should be an easy matter to make the test be self contained [08:25] on it [08:51] actually it's weird, a mouseClick is not getting where it should :-S [08:55] actually it's weird, a mouseClick is not getting where it should :-S [08:55] err [08:55] i meant [08:55] ok, found out what's wrong [08:55] \o/ [09:04] pushed [09:04] should fix it [09:04] now let's see the tabbar ones [09:04] that have the problem that pass here afair [09:10] we still don't have videos for the qml tests, right? [09:14] interesting adding a waitForRendering i can make it fail here too [09:14] good [09:52] Saviq: https://code.launchpad.net/~aacid/unity8/more_filter_fixes/+merge/198427 passed now [09:52] tsdgeos, thanks [10:15] dednick, ping [10:15] Saviq: yo [10:16] dednick, hey, did you see my comment on the messaging app time issue? [10:16] bug #1253810 [10:16] bug 1253810 in unity8 (Ubuntu) "Messages in Incoming not always display the correct date and content" [High,In progress] https://launchpad.net/bugs/1253810 [10:17] dednick, I got kinda lost in the menu vs. model vs. modelIndex and which model is it supposed to call the loadExtendedAttributes on... [10:17] dednick, it could use some streamlining... [10:19] dednick, but to start with, in all the Component.onCompleted:, you need to check whether model is there already, and also react to modelChanged - so you basically need BaseMenuItem to introduce a property that will hold that model (and modelIndex, for that matter), and have those bound in onLoaded [10:20] Saviq: can you give me a few minutes. Just going into a meeting with john. [10:20] dednick, I know it's not entirely your code, but remember the rule of thumb: never reach outside of the current file - if you need something - bind it [10:20] dednick, sure [10:28] tsdgeos, still one failure in tabbar dash [10:28] yeah [10:28] bit lost tbh [10:28] pushed a small change to try to find out if it's the tab not changing [10:29] or the tab change not propagating to the dash [10:29] let's see what the next run says [10:37] tsdgeos, cheers [10:37] * Saviq builds qt5 release for i386 to see if it helps with bug #1258057 [10:37] bug 1258057 in Unity API "unity-api fails to build against Qt 5.2" [Critical,In progress] https://launchpad.net/bugs/1258057 [10:38] oh no /me isn't ;? [10:39] ok back in the game [10:52] Saviq: hm. ok, trying to sort out the naming and "outside of source", but I don't think we need to react to modelChanged. if it does, all the items will invalidate anyway. [10:53] dednick, somehow model is null in onCompleted [10:53] dednick, I did find it weird indeed [10:53] dednick, especially since it was reaching out of scope [10:54] I don't want to put the model or anything like that into the items. That adds impl detail. all impl detail properties are added to the Components in the Factory. [10:54] dednick, s/null/undefined/ [10:54] Saviq: hm. weird. [10:54] EphemeralNotificationsTests is also unstable now? [10:55] tsdgeos, shouldn't be [10:55] Saviq: oh, model, or modelIndex undefined? [10:55] dednick, model [10:55] Saviq: for messaging items? [10:55] Saviq: it failed twice in my tabbar branch, which has nothing to do with notifications :-/ [10:55] tsdgeos, only jenkins, of course? [10:55] Saviq: of course [10:56] tsdgeos, ah autopilot? [10:56] Saviq: model is defined in the Factory, so i'm not sure why it's out of scope. [10:56] Saviq: yep [10:57] dednick, what I *think* might be happening there [10:57] dednick, is that model is ambiguous [10:57] dednick, remember "model" is something a ListView provides in delegates' context [10:57] dednick, so maybe it's enough to just prefix it with menuFactory [10:57] Saviq: ok. well I'm changing the names. let me see if that fixes it. [10:58] dednick, yeah, I was quite lost what was what [11:01] tsdgeos, hm? https://code.launchpad.net/~aacid/unity8/tabbar_dash/+merge/192505/comments/460186 [11:02] that's the last one [11:02] but see http://s-jenkins:8080/job/unity8-ci/1865/console [11:03] and also i have seen it somewere else [11:03] greyback: Saviq: https://code.launchpad.net/~mzanetti/unity-api/new-screenshot-api/+merge/198536 [11:03] If you're happy with this I'd go ahead updating tests and changing unity-mir to reflect it [11:03] tsdgeos, it looks like a crash or something === rachelliu_ is now known as rachelliu [11:04] mzanetti, looks good [11:04] ok, so ui tests failed again, obviously [11:05] confusing [11:15] mzanetti: +1 from me [11:17] nice. thanks === _salem is now known as salem_ [11:29] ok, new iteration in the way [11:34] tsdgeos, seen http://pastebin.ubuntu.com/6555591/ ? [11:36] hmmm [11:36] nope [11:36] but tbh i don't usually compile webkit [11:39] Saviq, question about the json validation - how much validation do you think it should do? just ensuring that keys have proper types, or check values as well? [11:39] Saviq, ie should a "card-size": "xx-large" cause an error? [11:40] mhr3_, if we use the json schema, that would be an error, yes [11:41] mhr3_, or we can say that this is just a string and not an enum [11:41] mhr3_, at which point we'd need to warn outside of the schema validation, that this is an incorrect value [11:41] Saviq, the way i see it is that the validation is a top-level thing, and if it fails, things are too bad, you can no longer just fallback to a default for one key [11:42] the question is really about extensibility [11:42] mhr3_, yeah, that's why I'm saying it could be a warning at a higher level [11:42] when we do add support for xx-large, we want the old devices to still work with that scope, don't we? [11:43] mhr3_, but yes, IMO it should check the values and any other rules we might have (say you're required to map at least one of title, price, rating, or that you can only map subtitle if you've mapped title as well) [11:43] mhr3_, that would be a new version of the schema, though [11:44] Saviq, but then it's for sure that the old device wouldn't support it [11:44] mhr3_, right [11:44] mhr3_, so... maybe the client needs to send the highest version it supports, then? [11:45] mhr3_, and we might have conversion rules === iahmad|afk is now known as iahmad [11:45] mhr3_, but anyway, still, we need to discern between a recoverable and non-recoverable errors [11:45] mhr3_, i.e. we can recover from xx-large [11:46] sure, it's just starting to sound like too much work for the scope authors [11:46] mhr3_, by falling back to the default medium [11:46] mhr3_, the conversion rules would be our side [11:46] mhr3_, so you get results v10 from the scope [11:46] mhr3_, but client only supports v8 [11:46] then you don't have code that understands v10 [11:47] mhr3_, well, you won't have a v10 scope in that case [11:47] mhr3_, I'm thinking SSS [11:47] i'm thinking scopes in app store [11:47] mhr3_, yeah, that's framework version, though [11:48] mhr3_, they would require 14.04 or 14.10 - and won't be available for older devices [11:48] hm, ok that solves that part [11:48] mhr3_, for SSS, we'd need v10-to-v8 conversion code [11:48] weeee, "fun" [11:49] indeed [11:49] mhr3_, still better than us requiring scope authors to support multiple versions [11:49] think sss will just hide those scopes for the older devices :) [11:49] mhr3_, that can work as well, yeah [11:49] it's supposed to be s, after all [11:50] mhr3_, so, done! ;) [11:50] mhr3_, bu [11:50] t [11:50] mhr3_, error vs. warning [11:50] aah, no buts [11:50] mhr3_, xx-large size would be a warning, fallback to default [11:50] mhr3_, but mapping only subtitle would be error [11:50] sounds reasonable [11:51] mhr3_, so we can't do "real" schema for card-size [11:51] the schema will be super complex for such checks though [11:51] mhr3_, we need a sanitizer layer on top of the schema [11:52] mhr3_, so yeah, schema could not error out for any recoverable error [11:52] mhr3_, the sanitizer layer could do both warning and error [11:52] Saviq, i'm just doing http://paste.ubuntu.com/6555663/ [11:52] so wondering how much it'll grow in the future [11:53] mhr3_, yeah, that will grow a lot, I'm afraid... [11:53] mhr3_, especially if we say some things are recoverable errors [11:53] mhr3_, but then... do we really want that? [11:54] future me will be pissed when he has to implement it [11:54] mhr3_, couldn't we say that "dude, you've seen the errors in the dev tool, sod off"? [11:54] well, something still has to produce those [11:54] mhr3_, the schema would, tehn [11:54] then [11:55] mhr3_, and on top of that only stuff the schema can't catch [11:55] so we'd maintain a super-strict and a regular schema? [11:55] mhr3_, yeah [11:55] mhr3_, wait [11:55] no [11:55] one schema [11:55] mhr3_, we just say no-fallbacks, your stuff needs to be correct [11:56] hmm [11:56] mhr3_, and if it's not, we ignore results from your scope completely [11:56] mhr3_, if we do the dev tool right, that *could* be enough [11:56] yea, just wondering whether i'm happy or sad about that :) [11:57] mhr3_, it's either that or a thick sanitizer layer [11:57] but ok, i see your point [12:00] mhr3_, Saviq, my two cents as an author: if you are going with the no-fallbacks road, awesome docs please :) [12:00] davidcalle, I know :) [12:00] davidcalle, it's just for the JSON definitions, though, and will be validated by a JSON schema that we maintain and agree to [12:01] davidcalle, so basically, if we failed to do the schema right, and you have something that passes the schema and sanitization checks - it's our responsibility to deal with it [12:01] davidcalle, but as long as you don't pass the schema, you're on your own ;) [12:02] davidcalle, that schema will be documented, too, btw [12:02] the schema *check* that is === alan_g is now known as alan_g|afk [12:02] mhr3_, yes, validation and sanitization [12:02] clarifying cause it sounded like you need to pass some kind of schema [12:03] ok yeah, sorry [12:04] Authors can still pass the layout - according to the specs - they want, right ? [12:06] davidcalle, yes yes [12:06] Saviq, ok [12:07] Saviq: https://code.launchpad.net/~nick-dedekind/qmenumodel/loadExtAttributes-dataChanged/+merge/198549 [12:08] dednick, cool [12:08] dednick, did you manage to verify it fixes the bug? [12:08] dednick, or is that just a road to that? [12:08] Saviq: it's only part of it. [12:08] dednick, ok [12:08] Saviq: is there actually a bug? or is it just log messages? [12:09] dednick, https://launchpad.net/bugs/1253810 [12:09] Ubuntu bug 1253810 in unity8 (Ubuntu) "Messages in Incoming not always display the correct date and content" [High,In progress] [12:09] Saviq: ah, yeah, i ddint see that in original comment [12:10] biab === alan_g|afk is now known as alan_g [12:14] Saviq: is there a way you can reproduce reliably? [12:16] hm. just realised my nexus 10 doesnt have sim, so no messaging... boo [12:16] but of an issue [12:16] s/but/bit [12:22] mzanetti, are music previews supposed to work? i.e. able to play a song in the dash ? [12:24] yes === MacSlow is now known as MacSlow|lunch [12:31] om26er: yes. it doesn't work? === dandrader is now known as dandrader|afk [12:31] hmm... it doesn't indeed [12:35] greyback: how do you test unity-mir changes on the device? Do you sync code manually and compile on the device or is there some run_on_device thingie for it? [12:36] mzanetti: sync usually. === dandrader|afk is now known as dandrader [12:50] mzanetti: ? works here (desktop) [12:57] dednick, you don't have a phone at all? [12:57] dednick, I can reproduce semi-reliably [12:58] dednick, so I can test anything you need [12:59] Saviq: yeah, i have a galaxy nexus, but didnt bring it to the office with me today :( [12:59] dednick, well, there's bound to be *someone* with a phone in the office ;) [12:59] dednick, but regardless - let me know, I can test [13:00] Saviq: cool. i can't seem to reproduce with the test app. [13:01] dednick, it's a race, basically, so makes sense that it only happens on some devices but not others [13:01] dednick, you can try restarting unity8 while things stay in the indicator to see - happened for me some times, too === alan_g is now known as alan_g|lunch === MacSlow|lunch is now known as MacSlow [13:27] Saviq: you mind checking if trunk qmenumodel fixes the issue for you? Will most likely still get nasty log messages though. [13:27] when you have a few minutes free of course [13:28] dednick_, will do [13:29] Saviq: thanks === Guest16420 is now known as karni [13:40] tsdgeos, how do I tell Qt to use a certain QPA plugin path? i.e. a locally built one? [13:47] Saviq, I think you have to install it [13:48] dandrader, yeah, it's installed in a prefix [13:48] dandrader, but I now need to tell Qt what that prefix is... [13:48] Saviq, I mean that I think it must be installed in Qt's regular plugin path [13:48] dandrader, ugh [13:49] that can't be :/ [13:49] Saviq, one way to avoid messing up things is giving your QPA a different name [13:49] Saviq, so that you can choose when to use it with the QT_QPA_PLATFORM env var [13:53] dandrader, yeah, thing is... if I set the prefix during building Qt, shouldn't the "regular plugin path" be under that prefix anyway? [13:53] Saviq, I guess so [13:54] dandrader, yeah, which is why I'm surprised it doesn't *just work* [13:59] Saviq: there's some envvar [13:59] Saviq: have you found it? [13:59] tsdgeos, no [13:59] let me check [14:00] QT_QPA_PLATFORM_PLUGIN_PATH [14:00] not sure what you have to make it point to [14:01] or oyu can use -platformpluginpath to the binary [14:01] tsdgeos, thanks, will check it out in a bit [14:01] tsdgeos, weird that it wouldn't pick them up from the default prefix by default, 'innit? [14:01] it is [14:08] wow now the tabbar test crashed [14:08] do we keep the .crash files for them? === alan_g|lunch is now known as alan_g [14:29] Saviq, mumble doesn't start here... keep trying [14:29] MacSlow, tsdgeos, mzanetti, we're in a meeting still with greyback and kgunn [14:30] ok [14:30] Saviq, ok [14:32] hm... -> "Settings schema 'com.canonical.unity-gtk-module' is not installed" [14:59] tvoss, btw, added benefit for out-of-process content picker → it can be contained read-only, so it can't b0rk the app's data [15:00] Saviq, I'm just thinking that it really is the right way of doing it for tight integration [15:01] tvoss, "it" → separate process? [15:01] Saviq, separate process, with the app providing a "factory" for a content picker that runs under read-only confinement and probably resource limited [15:01] Saviq, with the content hub providing the "executor" [15:01] tvoss, yeah, and that can actually be stateful as well [15:02] tvoss, per-content-picking sessions [15:02] -s [15:02] Saviq, sure, that's what I mean [15:02] tvoss, so actual app and its content picking sessions can be archived separately [15:02] tvoss, archived, killed, resumed etc. [15:02] tvoss, without affecting any of the other content pickers or the app itself [15:03] Saviq, yup, but I still think the vanilla picker integration would be a good first cut, too, as it would work for all apps regardless [15:03] tvoss, sure [15:03] Saviq, okay, I will note down those thoughts [15:03] tvoss, first step → single instance [15:03] Saviq, ack [15:03] Saviq, driving use-case for second step: gallery [15:03] tvoss, yup [15:04] DONE ... almost ;) === tvoss is now known as tvoss|food === alan_g is now known as alan_g|tea === alan_g|tea is now known as alan_g === dandrader is now known as dandrader|lunch [15:54] Saviq, mzanetti, https://code.launchpad.net/~mhr3/unity-scopes-shell/json-defaults/+merge/198591 [16:07] looks like Qt5.2 is out [16:10] Saviq: https://code.launchpad.net/~nick-dedekind/unity8/indicator-menuitems-lp1253810/+merge/198597 [16:10] it's probably a bit more than you hoped for though [16:10] mhr3_, cheers [16:10] dednick_ conflicts? [16:10] ... [16:21] Saviq: ok, fixed conflicts [16:55] mzanetti, hm, know about https://code.launchpad.net/~sil2100/unity-scopes-shell/revert_25/+merge/198595 ? [16:55] mhr3_, mzanetti: testing this revert on my phone to make sure [16:57] Saviq: ^ [16:57] i just don't see why it shouldn't work... unless the unity8 part didn't get merged [16:58] hrmpf [16:59] mhr3_, http://bazaar.launchpad.net/~unity-team/unity8/trunk/revision/563 did get merged [17:00] Saviq: mhr3_ so we had all the relevant merges but we didn't test if a click package could launch ? [17:00] mhr3_, Saviq: but we're not releasing unity8 now [17:00] kgunn, we did [17:00] sil2100, it was released already [17:00] weird [17:00] kgunn, something else must be in play [17:00] kgunn, the unity8 change was safe either way [17:00] Then something's wrong, somewhere else it seems [17:00] Saviq, was that the only thing? doesn't seem enough [17:00] Saviq: right...so are we reverting the correct thing? or are we just reacting to fast ? [17:01] can we bisect ? [17:01] mhr3_, 562, too [17:01] mhr3_, http://bazaar.launchpad.net/~unity-team/unity8/trunk/revision/562 [17:02] mhr3_, sil2100, do we need to release scopes-shell today? [17:02] Saviq: we released it already [17:02] ah [17:02] Saviq: since no AP tests caught this behavior [17:02] :/ [17:02] :| [17:03] Saviq, mhr3_, kgunn: the revert works fine and fixes the issue, so we'll be pushing it out as a temporary solution [17:03] sil2100: Saviq ...does AP test cover this behavior ? [17:03] sil2100, ok [17:03] Sadly... [17:03] sil2100: ok [17:03] sil2100, ok [17:03] kgunn, we're launching apps, apparently not click ones [17:03] kgunn, sounds like it doesn't [17:03] kgunn, although for that there's no excuse - we just have low integration coverage all over [17:04] https://bugs.launchpad.net/bugs/+bugs?field.tag=needs-ap-test FWIW [17:05] Saviq: ok, no time like the present...can we elect someone from our team to add an AP test to download a known click and launch it ? [17:06] kgunn, don't even need to download [17:06] kgunn, there's some preinstalled [17:06] sweet...1/2 done [17:06] surely...even when this was on trunk, someone tried to launch a click app ? [17:08] kgunn, it was in trunk unity8 (safe), unity-scopes-shell (apparently non-safe) was just tested during the review [17:09] Saviq: ok...well, let's pick a victim for tomorrow to go add a specific AP test [17:11] Saviq, it's weird though, if ap is launching at least non-clicks it should catch the issue [17:11] both are launched the same way [17:12] mhr3_, it's launching them directly [17:12] mhr3_, not from the shell [17:12] then we really want a test to do it via shell [17:12] mhr3_, oh yeah, definitely [17:16] Saviq: would zanetti be best for this ? [17:16] i added a critical bug https://bugs.launchpad.net/unity8/+bug/1260013 [17:16] Ubuntu bug 1260013 in Unity 8 "[ap test] need to test click package app launching from dash" [Critical,Triaged] [17:16] kgunn, actually we can ask veebers to get this overnight [17:16] ok...will put his name on it [17:17] except... [17:17] I can launch clicks fine from the launcher [17:17] kgunn, mhr3_, Saviq: thanks guys, the revert is in the build right now [17:17] right...need to launch from the dash right ? [17:18] kgunn, right, it doesn't go through the scopes.. [17:18] Saviq, how can the revert even work? shouldn't it blow up because unity expects just app_id now? [17:18] launched fine [17:19] from dash [17:19] mhr3_, shell doesn't really care [17:20] sil2100, is there a bug reporting that issue? [17:20] Saviq: let me file it [17:23] Saviq, mhr3_: https://bugs.launchpad.net/unity-scopes-shell/+bug/1260020 [17:23] Ubuntu bug 1260020 in unity-scopes-shell "After revision 25 cannot launch click applications from the unity8 scopes" [High,New] [17:25] * Saviq no get it... [17:25] can confirm with released unity8, trunk works fine, with no related change between the last release and now :? [17:28] Saviq: what do you mean? [17:29] sil2100, I mean that it works fine when I run unity8 trunk with the release of unity-scopes-shell [17:29] Ah [17:29] hm [17:29] sil2100, but not when running released unity8, where there's nothing in trunk unity8 related to it at all [17:30] sil2100, might be my env is unclean [17:30] sil2100, building from scratch now [17:32] sil2100, yeah, something must've remained in my environment [17:32] kgunn, ↑ that could've bit us when testing, FWIW === dandrader|lunch is now known as dandrader [17:37] davidcalle, is there a list of keywords somewhere for the server-side scopes? [17:37] i know for local ones you can just rgrep keyword in /usr/share/unity/scopes/ [17:37] cwayne : https://productsearch.staging.ubuntu.com/smartscopes/v1/remote-scopes here you go :) [17:38] cwayne_, wait, remove the staging from the uri [17:38] davidcalle, awesome, thanks! [17:43] davidcalle, some of them never seem to return anything, (e.g. stackexchange: and grooveshark:) [17:45] mhr3_, activating "/com.ubuntu.weather_weather_1.0.158.desktop" [17:45] :/ [17:49] Saviq, ehm? but the code did .basename() [17:49] mhr3_, yeah [17:49] so... wtf? [17:49] which seems to not do what it's expected to [17:50] cwayne_, yes, they are part of the API limited scopes, so they will work again in a few hours, when they don't hit their queries limits anymore. There is some caching work going on, to make these outages less noticeable. [17:51] mhr3_, ah wait, that's *before* the basename [17:52] Saviq, aah... dots [17:52] will try to activate "com" [17:54] needs to be .completeBaseName() [17:57] * mhr3_ out [18:01] uh :/ [18:12] alesage, dednick is back this week [18:12] Saviq, ok super, shall we get a review from him? [18:16] alesage, yeah, we need to get indicator-stubs through, first... [18:17] alesage, and I've completely no idea what's happening there :/ [18:17] Saviq, ok understood--so it is the test failures that are blocking us [18:17] alesage, yeah [18:17] Saviq, I'll try to take it up with CI [18:22] alesage, I don't think they can do anything there - I can reproduce it locally - just have no idea what's happening [18:22] kgunn, FWIW https://code.launchpad.net/~saviq/unity-scopes-shell/fixed-click-launch/+merge/198626 [18:23] .baseName() vs. .completeBaseName() [18:23] Saviq, weird, but is it just our (i.e. my) branch? [18:23] alesage, yeah, that's the thing [18:23] alesage, your tests do *something* to the test env that makes them fail [18:23] alesage, they pass in isolation, of course [18:23] Saviq grr ok [18:24] alesage, so it's pretty difficult to pin down, I just need to sit down and look at the phone while it's doing the tests at least [18:25] Saviq ok right I haven't run the whole suite, will do so this afternoon and get some help === jhodapp is now known as jhodapp|afk === jhodapp|afk is now known as jhodapp === salem_ is now known as _salem [19:42] Saviq: did you get a chance to work on a Unity 8 Saucy PPA today? [19:43] mhall119, I'm afraid not, was a hot day [19:43] no worries, just let me know when it's there and I'll go back and update the documentation (after trying it, of course) [19:44] mhall119, do you think daily recipes from trunks would be ok? [19:45] what's going into trusty's archives currently? [19:45] mhall119, manual releases [19:45] mhall119, but that would add burden on that process, if it was to go to saucy, too [19:46] right, do we want *only* saucy builds in the PPA then, or saucy *and* trusty from trunk? [19:46] mhall119, I'd say saucy only [19:46] mhall119, as a "try this, but if it doesn't work, it's not our top priority" [19:46] mhall119, we basically can't maintain both [19:50] ok, that's fine with me [20:02] mhall119, ok, I put unity-api and unity-scopes-shell in recipes for https://code.launchpad.net/~phablet-team/+archive/desktop-deps [20:02] mhall119, at least temporarily (I'd like to move it under ~unity-team) [20:03] why didn't you put it under ~unity-team to begin with? [20:03] mhall119, that PPA I had already, and it has increased points [20:03] mhall119, those two should be all that's needed to build unity8 on saucy, will verify later today [20:04] points == build score [20:04] ok, I'll try from there [20:42] http://download.qt-project.org/official_releases/qt/ cool beanz [20:43]