=== duflu_ is now known as duflu [01:52] Eeek, brown-out [01:57] Win! [02:10] The mediumtests-trusty-touch and mediumtests-runner-mako CI jobs are just failing at the moment, aren't they? That's not an issue with my code? [02:15] RAOF: They are indeed just failing :/ [02:15] in 80-90% of cases... [02:16] So you can retry :) === chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk [03:27] RAOF: Could you kindly give the changelog and version proposals an honorary approval? === chihchun_afk is now known as chihchun [03:29] There you go. [03:47] RAOF: Ta [03:48] I know *why* we have debian/ in the repository, I just continue to think it's a bad idea ;) [03:48] RAOF: If we continue with the two separate branches then I agree. But while the goal is to ideally have one, then I disagree [03:49] Hmm, we *could* hide debian/ in dev and just quietly maintain it in lp:mir :) [03:50] Yes, we could. [03:50] Although that makes code reviews of packaging changes impossible [03:50] Umm, less convenient [03:50] Not really? We just review on lp:mir [03:51] I don't think it's a bad idea to have packaging changes reviewed in a different place to code changes; our developer skill sets are almost entirely disjoint, too. [03:51] Surely debian/ as a subdirectory is designed that way so you can keep it with your code without stepping on any toes [03:52] Historically it has not been; we're being an unhelpful upstream by including it. [03:52] (This is mostly fixed with deb src 3.0, though) [03:52] RAOF: I hate to say it, but code reviews are even more scarce on lp:mir than dev. [03:53] Are there any reviews to *do* on lp:mir? [03:53] I mean, if you rely on the subset of developers with the skills to review packaging changes, then you don't have enough reviewers [03:54] Ah, but we can get potentially get didrocks and other distro people to review those changes. [03:54] Because he loves us so much already [03:54] And rightly so [03:54] I mean that both ways [03:55] No one from distro is going to regularly check merges that are almost all code changes unrelated to distro work; if we separate out those quite-infrequent changes it's more likely we can shanghai people to do them. === sfeole` is now known as sfeole [06:58] duflu: What's the typo? [06:58] RAOF: construtor ? [06:59] AHA! [06:59] Or is it copy-construe-er? [07:00] If all else fails, copy and paste into an edit field with spell-checking [07:02] Hm. I do appear to have dropped into my native braces style a bit there, don't I? [07:04] Also, I'm pretty sure our style guide suggests 120 characters ;) [07:06] RAOF: On the theme of readability, not style compliance :) [07:07] Though I've already spent enough of my life trying to explain to people why a limit of 80 cols is important. I won't waste my breathe (much) more [07:08] breath too [07:13] * RAOF wonders if we should set up clang-format as a precommit hook. [07:22] RAOF: I suspect we have too many exceptions we'd like to keep :) [07:23] Including 3rd party, which we wish to not touch where possible [07:44] RAOF, +1 on clang-format [08:38] is there a rule for curly braces placement .. egyptian vs on the same column? [08:39] Is egyptian [08:39] if (foo) [08:39] { [08:39] hello(); [08:39] } [08:39] ? [08:39] If so, yes, we use Egyptian :) [08:39] nope [08:39] if (foo) { [08:39] hello(); [08:39] } [08:40] http://www.codinghorror.com/blog/2012/07/new-programming-jargon.html [08:48] anpok: http://unity.ubuntu.com/mir/cppguide/index.html [08:51] olli, ping [08:51] alf_: yes, but it only states it for function definitions.. and some examples use { on the same line.. [08:52] anpok: they are wrong :) [08:52] obviously [08:54] Awesome. Now I can code like an Egyptian and party like it's 1986 simultaneously [08:57] alf_: I'd like a second opinion on GLContext { void make_current() const; }; duflu has suggested that having it be const is an artefact of using non-C++ types, and I can see that, but I vacillated when writing the commit message for unconstifying it. [08:57] alf_: cf: https://code.launchpad.net/~raof/mir/check-for-surfaceless/+merge/198510 [08:58] RAOF: I'm happy to keep const. Just expect it to be non-const if the implementation changes [09:00] duflu: Ok then. I think conceptually const makes more sense, and it's an implementation detail if it isn't. [09:00] Yeah const is always a maintenance risk in that way [09:01] There's a reasonable argument for not having const in the language :) [09:01] Although I think having const with clearly defined policy is better [09:14] it is always simpler to explain the usage of const_cast / mutable if it is to fulfill a const in the problem domain, than because of a possible trivial implementation [09:16] duflu: any suggestions on the pixel format encoding? should I only take RGB based formats into account now.. [09:16] or look for something that also adresses yuv .. [09:17] anpok: I suggest sticking with what you have (don't change MirPixelFormat for now). It's nice and forward compatible to just define query functions like you have [09:17] Fitting all the info we need into 32-bits is quite difficult actually [09:18] SDL2 does something similar .. but they dont encode shift values directly [09:20] anpok: The panacea is an accurate set of instructions for interpreting/encoding any pixel :) [09:20] Without switch/case [09:21] We should probably look at gallium's format descriptor infrastructure. [09:22] anpok: That's what your merge proposal triggered for me. [09:22] the one in gbm.h [09:22] ? [09:23] I think fourcc is kind of OK, but fails to resolve the bug really. You have to switch on all known fourcc's. It's ugly [09:23] anpok: No... let me hunt it down. [09:23] Hmm SDL_pixels.h is interesting [09:26] https://github.com/RAOF/mesa/tree/egl-platform-mir/src/gallium/auxiliary/util - u_format.{c,h,csv} [09:28] A bunch of that is driver-implementation-specific, but the general gist could be useful. [09:32] hm there are also compressed formats [09:32] hm those would not be needed ... [09:34] Right. There are a huge number of formats there, most of which we wouldn't need. [09:35] Also, we (probably?) don't need all that description; block width and height, channel swizzle, layouts that aren't ‘plain’ [09:36] that reminds me of https://github.com/laanwj/etna_viv/blob/master/doc/hardware.md [09:37] if I am not mistaken the device can render to super tiled frame buffers.. and the optional composition gpu can do scanouts on those [09:48] that might be relevant again with hwc on android [09:49] different topic in some code parts DisplayConfigurationPolicy is named "initial" conf.. why only initial? [09:50] i initially assumed that.. if changes to the available displays happen the policy would querried again [09:53] anpok: No; that's only used for initial configuration, and something else is assumed to handle configuration on hotplug events. [10:00] * RAOF EODs [10:26] * duflu too. Overdue for cooking a healthy meal [11:45] RAOF: grrr! fix your trailing whitespace === RoddieKieley1 is now known as RoddieKieley [12:31] RAOF: anway xorg-server for saucy-proposed, pixman and libdrm for all supported releases in the release queue:) === chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun [13:19] i am a bit concerned about the conversion operator usage [13:19] in EGLDisplayHandle and similar... not widely used. it seems odd to have conversion operators for typedefs of void* === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader [15:16] bregma: did RAOF get you the mesa you needed for nested mir on desktop ? [15:16] never saw a follow up === dandrader is now known as dandrader|lunch [15:22] kgunn: iirc nested mir on desktop also needs a small change in mesa platform which is currently in review [15:23] anpok: exactly, this is what i was asking about [15:23] anpok: i looked at raof's github but didn't see any reference [15:23] but maybe i don't know where to look exactly ? [15:24] can you share if you do ? [15:25] sorry my wording was ambigiuous .. [15:25] mir/mesa needed another change [15:25] there is some utility class that needs surfaceless context, but creates a pbuffer surface which is not supported by mesa. [15:26] https://code.launchpad.net/~raof/mir/check-for-surfaceless/+merge/198510 thats the change === penghuan_ is now known as penghuan [15:40] Does mir at all can export / has api to query detected screen resolution and the DPI setting? [15:44] you can querry that through the mir client api - take a look at demo_client_display_config.c in the examples folder === Saviq_ is now known as Saviq === chihchun is now known as chihchun_afk [16:09] yay https://lists.ubuntu.com/archives/ubuntu-devel/2013-December/037904.html [16:10] =) [16:11] i was just looking up who to +1... i'll see if i can drop my amateur cmake cross compile file from mir === Saviq_ is now known as Saviq === dandrader_ is now known as dandrader [16:26] kdub: so did you say if you put in some logic to "ignore" the second "on"...display turns on but then hangs ? [16:27] kgunn, right [16:28] like, the problem is [16:28] kdub: damn...that's just weird...so not only does powerd send it...it meant to send it :) [16:28] right [16:28] i'm still poking around powerd trying to understand [16:29] ricmm, ping [16:35] kdub: anything I could do to help? [16:36] greyback, don't know of anything at the moment [16:37] kdub: ok [16:37] unity-mir's role seems to be pretty straightforward === chihchun_afk is now known as chihchun === FunnyLookinHat__ is now known as FunnyLookinHat === chihchun is now known as chihchun_afk [17:33] * mterry pokes ricmm about libhybris [17:34] mterry, what about hybris? [17:35] kdub, that libhybris fix that ricmm identified during the sprint, to allow two different users (root and phablet) to access hw on maguro [17:36] It's the last fix needed for nested mode to land [17:37] ah, okay [17:37] mterry, is screen on/off with nested working okay? i have some concerns about that [17:38] eh, actually, i'd expect it to work [17:39] its just funny that we make the power request to a nested client who asks the host server [17:39] too many hops [17:40] kdub, no, UCS is actually the one that will host the dbus interface [17:40] kdub, the unity-mir code to do it is still there, but will gracefully fail once UCS already owns it [17:40] kdub, and then we can remove that codee [17:40] mterry, great, sounds good === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader === fginther` is now known as fginther === csslayer_ is now known as csslayer [20:57] kdub: so i was just trying your instructions...i'm on N4 with todays devel-proposed image...after i install mir-test-tools [20:58] the only mir test i see is mir_stress [20:58] any ideas? [20:58] https://docs.google.com/a/canonical.com/document/d/1oxXDxehRQ35rYRwkuBCy1ZNmB_IBpg5UhE3jvNHEk_0/edit [21:00] * kdub looks [21:07] they were added in rev 1256 [21:07] and it looks like 1248 was the last merge to lp:mir [21:08] kgunn^^ [21:09] kdub: heh [21:09] fell victim === slangase` is now known as slangasek