| rick_h__ | gary_poster|away: yep, the idea crossed my mind setting up the azure stuff today. Could just be like charmworld staging but on the azure setup | 00:11 |
|---|---|---|
| rick_h__ | hatch: around? | 06:15 |
| rick_h__ | hatch: replied to your email, updated pull request to #33. Sorry for the trouble. Will look into it, but should unblock and be able to move forward while getting the patterns/workflow straight. | 06:25 |
| dimitern | hatch, you around? | 09:09 |
| dimitern | or any gui guys in fact? | 09:10 |
| dimitern | I'm in the process of changing ServiceDeploy not to upload charm store charms | 09:11 |
| dimitern | there will be a dedicated AddCharm API call that will do that and needs to be called before ServiceDeploy | 09:12 |
| dimitern | this is just a heads up, nothing changed yet | 09:12 |
| dimitern | i'll send a mail as wel | 09:15 |
| rick_h__ | thanks for the heads up and appreciate the email dimitern | 11:45 |
| dimitern | sorry I didn't include you rick_h__ , I'll forward it | 11:45 |
| rick_h__ | dimitern: all, all good. I was just trying to let you know we're listening. Most of us are later time zones so it's an empty space time of day to catch us in irc :) | 11:46 |
| dimitern | rick_h__, cheers | 11:47 |
| === gary_poster|away is now known as gary_poster | ||
| gary_poster | dimitern, hi. ack. sounds dangerous for backwards compatibility, though fine otherwise. I'll look for the email and reply. When you get a chance, I'd also like a reply from you to the thread with the subject "Proposed juju core feature: serve arbitrary charm contents, or only icon" | 13:11 |
| dimitern | gary_poster, hi, so about the GET functionality of the API server to fetch a file from within the charm | 13:12 |
| gary_poster | yeah | 13:12 |
| dimitern | gary_poster, I think we decided you guys can do it? | 13:12 |
| gary_poster | dimitern, yes, but the discussion is about the spelling and approach, I think. | 13:13 |
| dimitern | gary_poster, ah, ok, will take a look one more time | 13:13 |
| gary_poster | cool thanks | 13:13 |
| dimitern | gary_poster, I couldn't see any specific naming suggestions | 13:17 |
| dimitern | gary_poster, but I seem to recall from previous discussions we thought of something like GET /charms?url=<charm-url> | 13:18 |
| gary_poster | and what would that return? | 13:18 |
| gary_poster | and/or where could I read about that, or who would know more :-) | 13:18 |
| dimitern | gary_poster, perhaps we can add a &file=icon.svg (or any path relative to the root of the charm) | 13:18 |
| dimitern | gary_poster, well, if you need both the full charm and a specific file from it | 13:19 |
| gary_poster | dimitern, all we need are two things | 13:19 |
| gary_poster | (1) specific file | 13:19 |
| dimitern | gary_poster, if no &file= is given, it'll return an application/zip body with the binary archive of the charm | 13:19 |
| gary_poster | (2) ls-style functionality | 13:19 |
| dimitern | gary_poster, ah | 13:19 |
| dimitern | gary_poster, so for (1), both url= and file= should be given and it can return the content in the response body, with the corresponding Content-Type set | 13:20 |
| gary_poster | where url is, e.g., "cs:precise/juju-gui"? | 13:21 |
| dimitern | gary_poster, and for (2) I guess we can have url= and &list perhaps? returning something you can display | 13:21 |
| dimitern | gary_poster, yes | 13:21 |
| dimitern | gary_poster, no, actually, it has to have a revision as well | 13:21 |
| gary_poster | dimitern, I think it would be nicer if this were paths | 13:21 |
| dimitern | gary_poster, so cs:precise/juju-gui-42 | 13:21 |
| gary_poster | GET /charms/cs/precise/juju-gui/42/icon.svg | 13:22 |
| gary_poster | GET /charms/cs/precise/juju-gui/42/ (returns ls for that dir) | 13:22 |
| gary_poster | GET /charms/cs/precise/juju-gui/42/hooks/start | 13:22 |
| gary_poster | GET /charms/cs/precise/juju-gui/42/hooks/ (returns ls for that dir) | 13:22 |
| gary_poster | with ContentType specifying json | 13:23 |
| dimitern | gary_poster, so how about a json-encoded response in the form of {Files: [{Path: "rel-path-inside-charm"}, {Path: ...}]} | 13:23 |
| dimitern | gary_poster, hmm | 13:23 |
| dimitern | gary_poster, that might be a bit more difficult | 13:23 |
| gary_poster | oh, too bad | 13:23 |
| gary_poster | prettier in the abstract IMO, but practicality is important :-) | 13:24 |
| dimitern | gary_poster, what's wrong with GET /charms?url=cs:precise/juju-gui-42&file=icon.svg ? | 13:24 |
| dimitern | gary_poster, no conversions between charm urls and paths | 13:24 |
| gary_poster | IMO that is a path | 13:25 |
| gary_poster | you are dividing up the path into a query string | 13:25 |
| gary_poster | when in reality there's a single resource you want | 13:25 |
| dimitern | gary_poster, it can be a path, if properly escaped, but it really isn't | 13:25 |
| gary_poster | which is great for a ptha | 13:25 |
| gary_poster | how not? a path identifies a resource | 13:25 |
| dimitern | gary_poster, charm urls are more like urls than file names/paths | 13:26 |
| dimitern | gary_poster, they have a schema for example | 13:26 |
| dimitern | gary_poster, to do what you propose the server-side handler has to be able to handle /charms/ and anything below it and convert that to a charm URL, then validate it, and most importantly not allow arbitrary other paths, like /charms/something/or/other | 13:28 |
| gary_poster | dimitern, that's exactly true for the other spelling. I think we simply disagree on the fact that one maps cleanly to the other, and that a path is preferable to a query string for identifying a resource, when possible. | 13:28 |
| gary_poster | dimitern, how would you suggest I proceed? | 13:29 |
| dimitern | gary_poster, well, it's ultimately up to who implements it | 13:30 |
| gary_poster | dimitern, is not. ;-) | 13:30 |
| dimitern | gary_poster, I don't really strongly object towards having a bit weird urls that look like paths | 13:30 |
| gary_poster | heh | 13:30 |
| dimitern | gary_poster, inside state/apiserver/charms.go is the place to start basically | 13:31 |
| dimitern | gary_poster, there's the POST handler, a similar one needs to be implemented for GET and the I can see 2 less-than-trivial bits in its implementation | 13:32 |
| dimitern | gary_poster, the proper url parsing and the actual fetching and extracting what's needed (either not a big deal) | 13:33 |
| gary_poster | dimitern, cool. So here's my takeaway from our conversation. (1) broadly, you like the idea of adding a GET to somewhat mirror the POST. (2) no-one needs the ability to download a zip, so we should not implement it right now. (3) We should discuss the spelling a bit more with you and WIlliam over email and see where it goes. (4) technical details above (doesn't sound too bad; thank you) | 13:35 |
| gary_poster | dimitern, is there already an API that says "show me all the charms you currently have"? | 13:37 |
| dimitern | gary_poster, no | 13:37 |
| gary_poster | dimitern, that sounds like another one we'd need then | 13:37 |
| gary_poster | dimitern, any technical challanges there? | 13:37 |
| dimitern | gary_poster, re (2) above, we might eventually need the ability to get charms from the API server as the single normative source of all charms in the environment, but we don't need it right away | 13:38 |
| gary_poster | dimitern, ah ok. so we'd want to make sure the spelling supports it, even if we don't implement it yet | 13:39 |
| dimitern | gary_poster, it depends on what do you mean by "all charms" ? - just the URLs currently in state and the environment or more? | 13:39 |
| dimitern | gary_poster, yeah, and that's a point against using "canonical" urls/paths - how can you distinguish between "list me the files" and "get me the charm" ? | 13:40 |
| gary_poster | dimitern, good question. contenttype would be my first answer. | 13:40 |
| dimitern | gary_poster, using a trickery like "no slash => get the charm", "with trailing slash => list the files" seems horrible :) | 13:40 |
| dimitern | gary_poster, you mean Accepts ? | 13:40 |
| gary_poster | application/zip: get the charm | 13:40 |
| gary_poster | json: get the metadata | 13:41 |
| gary_poster | yeah | 13:41 |
| dimitern | gary_poster, that's possible i guess | 13:41 |
| * dimitern sorry, brb | 13:41 | |
| gary_poster | dimitern, np. when you return, "all charms": our only real interest right now is local charms. we want to know what non-charm-store (local) charms are available to deploy. | 13:43 |
| gary_poster | in the future there's lots of other possibilities | 13:43 |
| gary_poster | such as the environment replacing charm store and charm world as a source of truth | 13:44 |
| gary_poster | for the GUI | 13:44 |
| gary_poster | but that's not where we are right now | 13:44 |
| dimitern | gary_poster, back | 13:45 |
| gary_poster | cool | 13:45 |
| dimitern | gary_poster, so we can have a call like ListCharmURLs(schema string) []string -> json returning all charm URLs with a given schema | 13:46 |
| gary_poster | sounds perfect dimitern, yeah | 13:46 |
| gary_poster | I assume that would be pretty easy? | 13:47 |
| gary_poster | (for us to do) | 13:47 |
| gary_poster | (in GUI :-) ) | 13:47 |
| dimitern | gary_poster, and re Accepts, etc. above, i'd still prefer to have a ?list or something as part of the url to mean "get me the file list" otherwise, we'll get the zip | 13:47 |
| dimitern | gary_poster, it'll need a state call to list them all and a couple of server/client API methods, but doesn't look hard | 13:48 |
| gary_poster | ok cool | 13:48 |
| dimitern | gary_poster, using ?list as part of the url we make the urls idempotent, which is important for a rest api imho | 13:48 |
| gary_poster | dimitern, re preferring list over Accepts: ack. May I treat you as my technical contact for this, officially approving and blessing designs, or do I need to include William? | 13:50 |
| gary_poster | dimitern, don't see how the Accepts approach hinders idempotence. What do you mean? | 13:50 |
| dimitern | gary_poster, by all means, include william as well :) | 13:51 |
| gary_poster | ok :-) | 13:51 |
| dimitern | gary_poster, i mean /charms/cs/precise/juju-gui/42/ as an URL means different things depending on headers, which apart from the authentication code shouldn't have to happen | 13:52 |
| gary_poster | dimitern, that's pretty common AFAIK. Might be wrong there, and happy to do some research (and maybe come up with a solution better than one off-the-cuff :-) ), but it doesn't affect idempotence in the slightest, yeah? | 13:53 |
| dimitern | gary_poster, well, for me returning different response bodies for the same URL seems a violation of idempotence, but maybe it's just me :) | 13:55 |
| gary_poster | dimitern, the calls don't mutate state, and always return the same value for path plus content type. Idempotent, open and shut, afaik, but I'm leaving it. ;-) I'll document these two approaches and see if I can come up with any other good ideas with the GUI team and then send them to you and William. | 13:58 |
| gary_poster | thank you for the discussion and help dimitern! Really appreciate it. | 14:00 |
| dimitern | gary_poster, great, thanks for the discussion! | 14:00 |
| hatch | rick_h__ wow you were up late :) | 14:18 |
| rick_h__ | hatch: meh, drugs made me crash in the evening and ended up getting up for a bit | 14:19 |
| rick_h__ | hatch: still trying to kick the last of this crud :/ | 14:19 |
| hatch | I hear ya, thanks for the fix | 14:19 |
| hatch | last night I found out that python-selenium pkg is not available on 12.04 | 14:25 |
| hatch | is this something we should add to the hacking docs? | 14:25 |
| rick_h__ | it's in the archive in the tree | 14:26 |
| rick_h__ | so you don't get it from apt | 14:26 |
| hatch | ohh, well the hacking docs say otherwise :) | 14:26 |
| * rick_h__ knows because he's just updated to .39 in his current branch | 14:26 | |
| hatch | also python-yaml is already installed so we can remove that from the list | 14:27 |
| rick_h__ | that depends on the system? | 14:28 |
| hatch | I THINK it is installed with juju | 14:28 |
| gary_poster | email, email, email, email...email, email, email, email...come on, everybody can sing it! :-) | 14:28 |
| benji | rick_h__: let me know when you have time to pair on the bundle indexing issue | 14:28 |
| hatch | I basically went through the hacking docs from top to bottom | 14:28 |
| rick_h__ | hatch: which you don't have to have to dev on the gui | 14:28 |
| rick_h__ | benji: rgr, few minutes. | 14:28 |
| gary_poster | python-yaml would be installed with old juju but not juju-core I think | 14:28 |
| hatch | I also didn't add the gophers/go ppa | 14:29 |
| hatch | I'd also propose we remove the sudo from the npm -g install and instead add instructions on chowning the proper dir's | 14:30 |
| hatch | I of course would be more than happy to modify the doc :) | 14:30 |
| gary_poster | +1 on principle | 14:30 |
| hatch | gary_poster is there anything specific you'd like me to do now? | 14:37 |
| gary_poster | hatch, is "Get rid of full browser mode" done? Green card is still there, but I know that is pretty far along, if not done | 14:38 |
| hatch | gary_poster I left the green card there until the charm flag is removed | 14:38 |
| hatch | other than that it's all gone | 14:38 |
| hatch | I think the total result was a -1600ln diff :) | 14:39 |
| hatch | it's like rick_h__ didn't do anything for a month or so lol | 14:39 |
| hatch | now* | 14:39 |
| rick_h__ | hatch: careful buddy | 14:39 |
| rick_h__ | hatch: a lot of that was working around tools I was given by a certain member of the team :P | 14:40 |
| hatch | hahaha | 14:40 |
| hatch | maybe I could work on getting rid of double dispatch | 14:40 |
| gary_poster | hatch, oh cool and yay. Options: (1) get rid of pre-inspector code. (2) consider getting rid of namespace routing. (3) display unit errors on relation tab (that's not done, right?) (4) get rid of double dispatch (5) inspector unit destroy story: add “X units being destroyed” section | 14:41 |
| rick_h__ | hatch: I'm not going to get to the search results thing with show/hide the sidebar for a while | 14:41 |
| rick_h__ | hatch: and there's the bugs around fixing the quick search UX | 14:41 |
| hatch | gary_poster 3) the aggregate unit status is shown on the relations tab. 5) it shows them in the 'dying' category (at least it did, does it not any longer?) | 14:42 |
| gary_poster | we agreed those quick search bugs were lower in priority than the others I mentioned, I think, though could be wrong. | 14:42 |
| rick_h__ | gary_poster: yea sorry, typing while you're typing | 14:42 |
| rick_h__ | trying to keep hatch from deleting more crap I've done :P | 14:43 |
| gary_poster | lol | 14:43 |
| hatch | lol | 14:43 |
| hatch | gary_poster I'll run through the code for 1) | 14:43 |
| gary_poster | hatch, (3) great. (5) I believe it does, but luca's design includes what I described in addition | 14:43 |
| gary_poster | hatch, wait, (3) | 14:43 |
| hatch | waiting | 14:44 |
| gary_poster | hatch: that's supposed to show all units with errors as well--not just the aggregate. that's what #3 is | 14:44 |
| gary_poster | sorry, you can still do #1--that's my pref, actually--but wanted to clarify #3 :-) | 14:44 |
| hatch | ohh, do we have a design for that? I dont' think I've seen anything along those lines before | 14:44 |
| hatch | ok will do 1 until we clarify 3 | 14:45 |
| gary_poster | yeah, lemme go to the folder | 14:45 |
| rick_h__ | benji: going to get a drink and then can chat. Let me know how you want to connect. hangout/rtc/etc | 14:46 |
| benji | rick_h__: cool; I'll make a hangout | 14:46 |
| gary_poster | hatch, go to https://drive.google.com/a/canonical.com/?tab=co#folders/0B7XG_QBXNwY1cWQ4TmRmRXJBc0E , click on "Inspector," and see seventh inspector image from left | 14:47 |
| hatch | ohh right | 14:48 |
| gary_poster | #5 is on far right, hatch | 14:48 |
| hatch | I think #5 is as simple as changing a few css classes and whatnot when the status is dying | 14:49 |
| hatch | right now it's under the 'pending' styles | 14:49 |
| gary_poster | well, plus the message at the top, yeah? also trivial, but another item | 14:49 |
| hatch | yes yes, ok I'll create cards for these | 14:50 |
| rick_h__ | benji: rgr | 14:50 |
| gary_poster | thanks hatch. those are in the spreadsheet, fwiw, I've only been transferring things when I thought we'd actually get to them ;-) | 14:50 |
| hatch | haha, well I have 3 more days | 14:51 |
| hatch | so I'll start knocking them off as best I can | 14:51 |
| rick_h__ | benji: BradCrittenden the ingest queue's on mjc are huge? queued charms: 8992, queued baskets: 353. | 14:51 |
| benji | rick_h__: pfft! that's not huge, call me when it gets to 1 million (I'm not kidding) :) | 14:52 |
| rick_h__ | :/ | 14:52 |
| benji | the ingest might have died again | 14:52 |
| rick_h__ | it's a cron job, did it get removed? | 14:52 |
| benji | I thought it was under suporvisord. IIRC, last time supervisord decided it had failed one too many times and stopped running it | 14:52 |
| benji | rick_h__: https://plus.google.com/hangouts/_/72cpj9hm6qk6ajmdqd78d81lrc?hl=en | 14:53 |
| rick_h__ | jujugui small review please for saucelabs ci timeout joys https://github.com/juju/juju-gui/pull/34 | 15:23 |
| gary_poster | rick_h__, +1 | 15:27 |
| hatch | in typical Sublime Text fashion, 6 months have passed so there is an update, *see you in 6 months* | 15:28 |
| hatch | :P | 15:28 |
| gary_poster | hatch if you follow the dev releases it's a bit more exciting :-) | 15:28 |
| gary_poster | not a *lot* more exciting | 15:28 |
| gary_poster | but a bit | 15:28 |
| hatch | haha colour me skeptical :P | 15:29 |
| gary_poster | about what? | 15:29 |
| hatch | that anything will change after ST3's release | 15:29 |
| hatch | it'll probably stall again | 15:29 |
| gary_poster | oh | 15:30 |
| gary_poster | maybe | 15:30 |
| gary_poster | dev releases have been happening once every 1.5 months or so, not counting bug fixes | 15:30 |
| hatch | yeah that's what ST2 was like too | 15:31 |
| hatch | I have little faith :) | 15:31 |
| rick_h__ | could be vim releases... "Oh hey, a new vim release. I didn't think they were still working on that." | 15:31 |
| gary_poster | heh | 15:32 |
| hatch | rick_h__ haha right but they aren't selling vim :D | 15:32 |
| rick_h__ | it's more of a "wtf more could they possibly add to it?" | 15:32 |
| hatch | sane defaults? | 15:32 |
| hatch | ooooo zing! | 15:32 |
| gary_poster | test failure: sadness, rick_h__ :-/ | 15:32 |
| rick_h__ | don't get me started "I bought a new laptop and nothing works" boy :P | 15:32 |
| gary_poster | oh looks...unrelated to the timeout | 15:33 |
| rick_h__ | gary_poster: ah, I missed adding the makefile update to the new version of the file | 15:33 |
| hatch | rick_h__ lol! | 15:33 |
| gary_poster | oh ok cool | 15:34 |
| gary_poster | rick_h__, why did pr test work then? | 15:34 |
| rick_h__ | gary_poster: it's not make cleaning atm but the -merge one is | 15:34 |
| gary_poster | ah, gotcha | 15:34 |
| rick_h__ | gary_poster: wanted to see how it worked on -merge since it's the more careful one | 15:34 |
| gary_poster | gotcha | 15:35 |
| rick_h__ | so good job -merge job! caught it | 15:35 |
| gary_poster | heh | 15:35 |
| rick_h__ | oh bah, why can't I get all cards done at once | 15:41 |
| hatch | rick_h__ sounds like you need to goroutine your brain | 15:42 |
| rick_h__ | having fragile ci is almost worse than no ci | 15:42 |
| rick_h__ | and man it's getting cold again, to the fireplace! | 15:43 |
| gary_poster | fragile almost worse than no: yup | 15:43 |
| frankban | guihelp: I need two reviews + QA for https://codereview.appspot.com/43860044 (quickstart Environment list/selection view). Anyone available? thank you! | 15:45 |
| hatch | rick_h__ you should buy a toque :) | 15:45 |
| gary_poster | I will | 15:45 |
| gary_poster | review | 15:45 |
| frankban | gary_poster: thanks | 15:46 |
| gary_poster | welcome :-) | 15:46 |
| rick_h__ | hatch: :P I did just scratch my pebble badly dealing with the fireplace the other day | 15:46 |
| rick_h__ | frankban: looking | 15:46 |
| frankban | rick_h__: thank you | 15:46 |
| rick_h__ | namedtuples ftw! :) | 15:47 |
| * rick_h__ <3's them | 15:47 | |
| frankban | :-) | 15:48 |
| gary_poster | jujugui call in 10 | 15:50 |
| hatch | one of the very odd things about this MBP is it has no-friggen-idea how much time is left on the battery | 15:51 |
| hatch | the 'time to empty' will vary by hours over the course of just minutes | 15:52 |
| gary_poster | hatch in os x or ubuntu? | 15:52 |
| gary_poster | have found ubuntu to have no idea | 15:52 |
| hatch | osx | 15:52 |
| hatch | ubuntu has it down | 15:52 |
| gary_poster | but is x to be reasonable | 15:52 |
| gary_poster | huh | 15:52 |
| hatch | I know right? haha, my experience was similar to yours on my other machine | 15:53 |
| gary_poster | :-) | 15:53 |
| hatch | for example 3 minutes ago I had 9:05H left on the battery, and now I have 3:50 | 15:56 |
| rick_h__ | quit playing games on it :P | 15:57 |
| gary_poster | :-( that sounds its worth taking it to the apple store | 15:57 |
| gary_poster | it's | 15:57 |
| hatch | Ubuntu says 4.9H which makes sense | 15:57 |
| hatch | because there is 85% left | 15:57 |
| gary_poster | jujugui call in 2 | 15:58 |
| hatch | BOOM http://www.youtube.com/watch?v=1cOT4T2jDho ! RABBIT! | 16:29 |
| rick_h__ | http://www.amazon.com/s/ref=nb_sb_noss_1?url=search-alias%3Daps&field-keywords=little%20bunny%20foo%20foo&sprefix=little+bun%2Caps&rh=i%3Aaps%2Ck%3Alittle%20bunny%20foo%20foo | 16:29 |
| gary_poster | hatch, um, sorry, but http://en.wikipedia.org/wiki/Little_Rabbit_Foo_Foo redirects to http://en.wikipedia.org/wiki/Little_Bunny_Foo_Foo | 16:29 |
| gary_poster | open and shut, man | 16:29 |
| rick_h__ | wikipedia smack down | 16:29 |
| hatch | I dont' think so, this is clearly a video and a song which says Rabbit | 16:30 |
| hatch | and with almost 500,000 views! | 16:30 |
| rick_h__ | *couugh* made by a canuck *cough* | 16:30 |
| gary_poster | lol | 16:30 |
| hatch | hahaha | 16:30 |
| hatch | actually Michael Rosen is British | 16:30 |
| rick_h__ | ok fine, your kind then | 16:31 |
| rick_h__ | king | 16:31 |
| hatch | lol | 16:31 |
| hatch | thats a very odd cultural difference haha | 16:31 |
| rick_h__ | I'm tired, medicated, and you keep killing my work. Are you expecting better? :P | 16:32 |
| hatch | haha | 16:32 |
| rick_h__ | and damn it Dell, a monitor doesn't need to be 'in production' for 3 days. Either you've got it in a box or you don't. *grumble* | 16:32 |
| hatch | uh oh | 16:33 |
| hatch | you bought the 4k didn't you? | 16:33 |
| rick_h__ | ummm, maybe...want to buy a HD 21.5" on a monitor arm? | 16:34 |
| gary_poster | heh | 16:34 |
| * gary_poster jealous | 16:34 | |
| gary_poster | my old Dell 27" flakes out now and then and is pixel-y but haven't felt the need to spend the $$ | 16:35 |
| hatch | haha nice | 16:35 |
| hatch | I would like some monitor arms for my monitors | 16:35 |
| hatch | but I have too many monitors sitting around to buy more | 16:35 |
| rick_h__ | <3 monitor arms. Helps with a large desk surface since you can bring the monitor closer | 16:36 |
| hatch | yeah for sure | 16:36 |
| rick_h__ | and for aligning nicely | 16:36 |
| hatch | I need to find a cheapish one for my 31" though | 16:36 |
| rick_h__ | but the ones I have aren't meant for a 24" display | 16:36 |
| hatch | the monitor is very heavy and so the arms are very expensive :( | 16:36 |
| rick_h__ | remember it's the weight withuot the base on it | 16:37 |
| hatch | yeah it's still heavy | 16:37 |
| rick_h__ | the new one is 20# but only 10# once the base is removed | 16:37 |
| hatch | let me know what arms you pick | 16:38 |
| hatch | :) | 16:38 |
| rick_h__ | http://goo.gl/OnG7mi | 16:38 |
| rick_h__ | it's on the way | 16:38 |
| rick_h__ | http://goo.gl/ytQhIw | 16:39 |
| rick_h__ | is what I have now | 16:39 |
| hatch | That damn force field on the 49th parallel """Shipping: Currently, item can be shipped only within the U.S.""" | 16:41 |
| rick_h__ | come on down, we've got snow and cold too | 16:41 |
| hatch | lol | 16:41 |
| hatch | rick_h__ so when merging upstream into my local develop branch there was a conflict caused by the rebase I think | 16:42 |
| rick_h__ | k | 16:43 |
| BradCrittenden | benji: if you look at the staging heartbeat and refresh every few seconds you see the charm queued count go down. | 16:44 |
| === BradCrittenden is now known as bac | ||
| benji | bac: that makes me lean toward the "we can't keep up any more" hypothesis | 16:45 |
| bac | benji: if we're just not keeping up, it should increase again *now* :45 and then start going down again | 16:45 |
| benji | yep | 16:45 |
| bac | benji: yes, when the q cron started it jumped by a few thousand, and now the charm count is slowly decreasing. | 16:46 |
| bac | benji: i think we'll also see the bundle count always goes up and never decreases | 16:46 |
| frankban | Makyo: perhaps ssh-add cannot find the agent because we don't pass the env vars (SSH_AGENT_PID, etc.) when we run call(... ? | 16:47 |
| rick_h__ | a few thousand? ouch. I didn't think we had that many to ingest still. Wasn't it in the 300's? | 16:47 |
| bac | benji: i'm tempted to run dequeue on staging | 16:47 |
| benji | so, the next question is "does the count go down continually or does it plateau?" | 16:47 |
| bac | rick_h__: but we're queueing charm * up to ten versions | 16:47 |
| benji | if it plateaus, then for some reason the ingest job stops processing at some point | 16:48 |
| benji | (suggesting it hits some bad data or a bug that stops it from draining the queue as much as it otherwise could) | 16:48 |
| bac | benji: well we'd probably just have to watch for a 15 minute cycle | 16:48 |
| Makyo | frankban, I thought so too, but it can if we run our own agent, so I'm not sure. Running it manually in ipython always gives me rc 2 even if I start an agent manually before starting ipython. | 16:48 |
| bac | benji, rick_h__: we may just be bumping against the design issues that curtis mentioned a few weeks ago wrt the way we handle versions and overloading | 16:49 |
| Makyo | I'll keep investigating, though | 16:49 |
| bac | benji: so the number of bundles went up from 1056 before the latest queue run to 1078, an increase of 22. | 16:57 |
| benji | bac: and the bundle queue length never decreases? | 16:57 |
| bac | benji: so assume we really have 22 bundles. 1078 / 22 = exactly 49. | 16:58 |
| bac | so 49 runs ago we started seeing a backlog. a little over 12 hours | 16:58 |
| benji | if so, that suggests that the ingest is failing in the middle because charms are handled first and then bundles | 16:58 |
| bac | it suggests to me that it doesn't mean we're simply too slow | 16:58 |
| bac | benji: otherwise the backlog would've happened earlier. does that make sense? | 16:59 |
| rick_h__ | Makyo: can you link the qa you need please? | 16:59 |
| Makyo | https://codereview.appspot.com/39610049/ | 16:59 |
| rick_h__ | thanks | 17:00 |
| benji | bac: yep that makes sense; in other words, if we were to graph the backlog there is no straight-line slope that would get us back to the last time the queue was empty, implying something happened in the meantime | 17:00 |
| bac | benji: basket count just jumped by 22 again to 1100 | 17:00 |
| bac | benji: yes | 17:01 |
| bac | more elegantly stated, but yes | 17:01 |
| benji | so it would seem that ingest is stopping in the middle | 17:01 |
| bac | without logging | 17:01 |
| bac | unless that beaker exception is relevant | 17:01 |
| bac | benji: http://paste.ubuntu.com/6595233/ | 17:03 |
| benji | bac: but that exception is in the web app, right? not in the ingest job | 17:04 |
| bac | benji: yep. ingest is not creating any logs. grasping here. | 17:05 |
| hatch | finally working on the new machine....wow this thing is fast | 17:06 |
| hatch | now I see what rick_h__ works like | 17:07 |
| hatch | like holy crap it's easily 2x as fast | 17:07 |
| gary_poster | frankban, you got two LGTMs :-) | 17:08 |
| frankban | Makyo: 2 comments: 1) we should catch for KeyboardInterrupt also when keys are not found (create_keys = raw_input...) and 2) if I hit "s" and I create the key, quickstart asks me for a passphrase again, even if the agent is started. Is this ok? | 17:09 |
| frankban | gary_poster: great, thank you | 17:10 |
| Makyo | frankban, 1) on it. 2) I think so, though maybe we should be clear to the user about which command we're running when the passwords are asked. This might be fixed by further investigation of agents. | 17:11 |
| frankban | Makyo: +1 | 17:11 |
| frankban | gary_poster: the return value from the views is what show(view) returns if you hit ^X (as opposed to an explicit AppExit raised from the views). all the env views return (env_db, env_data), the latter being none if no environment has been selected. since each view can be used as an application entry point, even the return value from env_detail can be used. we might want to decide, e.g. that if quickstart is run wi | 17:22 |
| frankban | th -e we start the app showing the environment details. thoughts? | 17:22 |
| * gary_poster looking fwiw | 17:26 | |
| hatch | gary_poster https://bugs.launchpad.net/juju-gui/+bug/1262295 blocking release? | 17:27 |
| _mup_ | Bug #1262295: Logging out/in causes canvas help overlay to reappear <juju-gui:New> <https://launchpad.net/bugs/1262295> | 17:27 |
| gary_poster | frankban, I guess I don't understand how the return values are consumed by the loop. I assume it will work once we allow edits because we are mutating the (function-local copy of the) env_db dict? | 17:29 |
| gary_poster | hatch, if it affects a live environment, blocking. otherwise high. it will not affect jujucharms because we don't have a logout button, so if it doesn't affect a live environment then it only affects dev and comingsoon | 17:32 |
| hatch | ok I'll fire up a live env and give it a check | 17:33 |
| gary_poster | thank you | 17:33 |
| hatch | yay Saskatchewan http://www.techvibes.com/blog/first-province-to-allow-equity-based-crowdfunding-2013-12-09 | 17:35 |
| frankban | gary_poster: I think this needs to be changed, we need a more explicit way for views to set a return value for when the user quits with ^X, I'll think about that | 17:35 |
| gary_poster | cool thanks frankban | 17:35 |
| hatch | oh right I have to deploy the new gui the hard way in the charm | 17:38 |
| hatch | boooo | 17:39 |
| hatch | hmm I'm having no luck setting this up on lxc using the `NO_BZR=1 BRANCH_IS_GOOD=1 make distfile` technique | 17:59 |
| hatch | after installing make and node/npm imagemagik won't run | 17:59 |
| hatch | does that not work on lxc? ec2 only? | 18:00 |
| gary_poster | NO_BZR=1 should no longer be necessary. Note that you do this *on your dev box* | 18:05 |
| gary_poster | is that what you are doing? | 18:05 |
| gary_poster | 'Cause I don't quite understand your lxc/ec2 questions yet | 18:06 |
| rick_h__ | hatch: let me know if you want to hangout and walk through it | 18:07 |
| rick_h__ | hatch: I don't recall if we get a loading xv file right now since we don't yet have a tag. So might need to rename that file to be picked up during the make deploy in the charm | 18:09 |
| hatch | I'm doing it in the lxc juju-gui instance | 18:09 |
| rick_h__ | hatch: and you can or cannot generate a xv file? | 18:10 |
| hatch | rick_h__ hangout? | 18:10 |
| rick_h__ | hatch: rgr | 18:10 |
| hatch | https://plus.google.com/hangouts/_/7acpj4qna7ell1e9ovto0fmj8g?hl=en | 18:11 |
| hatch | new git alias `cf = "grep -n --color"` :) | 18:38 |
| rick_h__ | alias grep = "grep -n --color" :P | 18:38 |
| rick_h__ | pretty sure you can alias over itself | 18:38 |
| hatch | negative | 18:40 |
| hatch | tried that already heh | 18:40 |
| rick_h__ | Makyo: comments inbound. I got picky on the UX, let me know if it's more than you were looking for or anything is confusing/etc | 18:40 |
| Makyo | rick_h__, cheers, that's fine. | 18:40 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1262315 | 18:45 |
| _mup_ | Bug #1262315: inspector charm details breakout maxes at the max height of the inspector <juju-gui:New> <https://launchpad.net/bugs/1262315> | 18:45 |
| gary_poster | argh. worked through lunch again. :-( | 18:50 |
| hatch | oh crap so did I | 18:51 |
| hatch | haha | 18:51 |
| gary_poster | heh | 18:51 |
| bac | benji: we seem to have rallied. charm queue down to ~10K from 24K two hours ago | 19:10 |
| benji | heh | 19:10 |
| bac | bundles still growing | 19:10 |
| bac | benji: did you get a chance to look at the logging config? | 19:10 |
| benji | bac: nope, I lunched too and then went back to the missing bundle issue | 19:11 |
| benji | do you want to pair on this? | 19:11 |
| bac | benji: yes | 19:11 |
| bac | benji: give me 5 minutes? | 19:11 |
| benji | Sure. I bet today's hangout is still up. | 19:11 |
| bac | benji: yep and i'm in there | 19:18 |
| benji | on my way | 19:18 |
| hatch | gary_poster test-prod is 20s so not much faster than your desktop :) | 19:52 |
| gary_poster | hatch, that's awesome :-) | 19:52 |
| hatch | that is only single core though, I have 4(8)....clearly there is room for improvement :P | 19:52 |
| gary_poster | :-) | 19:53 |
| hatch | rick_h__ hey so my develop fork is totally borked, the pr of my recent branch shows like 30 commits when there was only one...can I delete my current fork, create a new one then cherry pick the commit to apply to the new branch? | 20:06 |
| gary_poster | yeah rick_h__ my local repo is hosed. was going to ask you to help me work through it, but been busy with other things, and still want lunch :-P | 20:07 |
| * gary_poster lunches | 20:09 | |
| rick_h__ | hatch: rgr | 20:17 |
| hatch | yeah? ok cool | 20:17 |
| rick_h__ | gary_poster: :( ok, let me know when you get back from lunch and will try to keep an eye out | 20:17 |
| hatch | I'm going to grab some lunch now too then I'll give it a go | 20:17 |
| rick_h__ | hatch: yea, that's basically what I did last night | 20:17 |
| rick_h__ | created a new branch, cherry picked. You might have to pull down the bad branch into your local workspace so it knows the sha reference to cherry pick | 20:18 |
| rick_h__ | hatch: see my email from last night on it | 20:18 |
| hatch | cool will do | 20:18 |
| hatch | so new rule "no rebasing develop" | 20:18 |
| hatch | lol | 20:18 |
| rick_h__ | heh, yea | 20:19 |
| rick_h__ | though I do want to try to take the time to walk the process and make sure exactly what step led astray | 20:19 |
| rick_h__ | hatch: do me a favor though, look at the git log and see if it lines up with the github display | 20:22 |
| rick_h__ | the thing that got me last night was that git log seemed fine, but github seemed confused and I wonder if it's doing something 'magic' in pull requests that I missed/need to take into account | 20:22 |
| hatch | rick_h__ these commits don't line up at all | 20:24 |
| hatch | they are all from days ago | 20:25 |
| bac | benji: argh, we lost ground on staging b/c ingest run by hand finished! | 20:32 |
| benji | heh | 20:32 |
| bac | benji: at the end of the unified run, anything left in the queue can be declared to be stuck and purged. | 20:36 |
| benji | bac: yep (and logged as an ERROR) | 20:36 |
| bac | yeah, that too | 20:37 |
| bac | benji: do you know what basket is stuck? | 20:37 |
| benji | bac: I have it around here somewhere, but I have to leave now for my appointment | 20:37 |
| bac | benji: i don't care as long as you do know. | 20:37 |
| gary_poster | hey rick_h__ should I just delete my local repo and github repo and start again? | 20:50 |
| rick_h__ | gary_poster: that'll work. The other thing you can try to do is to delete just the develop branch | 21:00 |
| rick_h__ | git push origin :develop (make sure origin is YOUR fork) | 21:00 |
| rick_h__ | gary_poster: and then | 21:00 |
| gary_poster | rick_h__, locally, in github, or both | 21:00 |
| rick_h__ | git pull juju develop | 21:00 |
| rick_h__ | git push origin develop | 21:00 |
| rick_h__ | gary_poster: all commands from your local clone of your fork on github | 21:00 |
| gary_poster | ack | 21:00 |
| gary_poster | rick_h__, so the first thing I do is git brancgh -d develop, right? | 21:01 |
| rick_h__ | gary_poster: yes | 21:01 |
| gary_poster | k trying | 21:02 |
| gary_poster | argh | 21:07 |
| rick_h__ | gary_poster: hangout? | 21:08 |
| gary_poster | sure | 21:08 |
| * hatch would like to join as well | 21:08 | |
| rick_h__ | hatch: https://plus.google.com/hangouts/_/7acpjddus2dgtntjhhvbmu6qvs?hl=en | 21:08 |
| === hatch_ is now known as hatch | ||
| hatch | gary_poster hey re the charm details bug that you just closed - Do you think that maybe we should get their input on that? If you saw the photo you can see that it's hardly ideal :) | 21:31 |
| hatch | jujugui I need two reviews/qa's on https://github.com/juju/juju-gui/pull/36 it removes all of the old inspector templates and code which was left | 21:32 |
| gary_poster | hatch, we already have gotten their input. you know I go to them when we have an issue. This is exactly what they told us to do. We did something different at first and they had us change it. If you want to bring it up with Luca yourself, it's ok, but be aware of history, and for me it's closed. | 21:33 |
| gary_poster | I mean, | 21:33 |
| gary_poster | for me, I think this issue is won't fix, as I marked the bug. | 21:34 |
| hatch | alrighty no problem | 21:34 |
| gary_poster | hatch I'll do a review | 21:34 |
| gary_poster | 646 lines, woohoo | 21:34 |
| hatch | haha yup and none of it is rick_h__ 's code lol | 21:35 |
| hatch | see rick_h__ i'm an equal opportunity code remover ;) | 21:37 |
| gary_poster | hatch trvial but I think you can remove line 1398 ("'juju-view-service',") from /home/gary/dev/juju-gui/app/views/inspector.js | 21:42 |
| hatch | yes you're right, nice catch | 21:43 |
| hatch | thanks | 21:43 |
| gary_poster | welcome | 21:44 |
| gary_poster | hatch, fwiw, it is all code deletion. I think one review is OK if no one else has stepped up | 21:51 |
| hatch | ok cool as long as it qa's ok, it all worked well here | 21:51 |
| gary_poster | yup | 21:52 |
| gary_poster | shipit | 21:52 |
| gary_poster | not the most useful graph: https://github.com/juju/juju-gui/graphs/code-frequency | 21:54 |
| gary_poster | noise at the beginning | 21:54 |
| hatch | haha | 22:01 |
| hatch | gary_poster rick_h__ mind proofing before I send plz https://gist.github.com/hatched/1d624a34c13553882ee4 | 22:01 |
| gary_poster | reading | 22:02 |
| gary_poster | I used push --force. More explicit. <shrug> | 22:03 |
| hatch | changed | 22:04 |
| gary_poster | actually hatch you can delete lines 24 and 25, and make line 31 have the --force. That's what I did. Fewer steos, and no downside that I see | 22:04 |
| hatch | agreed | 22:05 |
| rick_h__ | hatch: step 1: git co master (or some branch other than develop) | 22:16 |
| rick_h__ | hatch: so you can do the deletion | 22:16 |
| hatch | updated https://gist.github.com/hatched/1d624a34c13553882ee4 | 22:17 |
| rick_h__ | hatch: https://gist.github.com/mitechie/0285d9d0b407ba3ab97f | 22:18 |
| hatch | I think we both made the same change at the same time lol | 22:18 |
| rick_h__ | hatch: k, I also deduped a step since you only need to push once | 22:20 |
| rick_h__ | simpler > * | 22:20 |
| hatch | yup I also removed that in the most recent version | 22:20 |
| hatch | cool I'll send this version | 22:21 |
| hatch | snet | 22:23 |
| hatch | sent even | 22:23 |
| rick_h__ | cnblndriunvtnkivldurjldundhftejkr | 22:27 |
| hatch | i agree | 22:32 |
| hatch | lol | 22:32 |
| gary_poster | hi yubico! we missed you too | 22:32 |
| gary_poster | and with that, I am off! | 22:35 |
| gary_poster | bye | 22:35 |
| === gary_poster is now known as gary_poster|away | ||
| Makyo | rick_h__, if you're around, did things look good with your proposed changes? Missed a portion of the afternoon and may be submitting late. | 22:59 |
| Makyo | Figured I'd ask if you're still around :) | 22:59 |
| hatch | Makyo hey so what time is it there now? | 23:00 |
| hatch | 3? | 23:00 |
| Makyo | 4. | 23:00 |
| hatch | ohh ok | 23:00 |
| hatch | I can't keep other timezones straight :) | 23:00 |
| Makyo | Neither can I :) | 23:01 |
| hatch | haha | 23:01 |
| Makyo | Trying to taper meds, just lost track of a few hours. Will get it in the next little bit, just may be late. | 23:01 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!