| === CyberJacob is now known as CyberJacob|Away | ||
| === CyberJacob|Away is now known as CyberJacob | ||
| gmb | jtv: Thanks for fixing that bug. | 08:31 |
|---|---|---|
| jtv | Pure self-interest, believe you me. | 08:31 |
| jtv | *After* I fixed that, with a mild guilty feeling because it's not our priority right now (again), I found I was yet again completely stuck without the fix. | 08:31 |
| jtv | So thanks for the review! | 08:31 |
| gmb | jtv: You did the right thing. | 08:32 |
| jtv | It's a change I made... some decisions are the engineer's own responsibility. | 08:32 |
| * gmb stares incredulously at Django | 08:33 | |
| gmb | Returning a 302 when it should be a 403 is... Odd. | 08:33 |
| jtv | Rather. | 08:33 |
| jtv | For a moment I thought it was an Unauthorised. | 08:34 |
| jtv | But no, it's a Found. | 08:34 |
| jtv | It's a bit like replying with a link to lmgtfy.com | 08:34 |
| gmb | lol | 08:34 |
| jtv | Oh, and I see you gave me another review. Sorry about the one-sidedness of this working relationship... time zones can be cruel mistresses. | 08:47 |
| gmb | jtv: Believe me, I'd rather wake up to a bunch of reviews than nothing at all. Come january, I'll endeavour to leave things for you to do when you get up, if that makes you feel better :) | 08:49 |
| jtv | Less guilty, yes. Better, only one way to find out. :) | 08:50 |
| jtv | Ohhhh yes this TDD stuff is so much easier with that stupid bug fixed. | 09:01 |
| jtv | A bit of background in formal specification really affects one's perspective on TDD... | 09:02 |
| gmb | jtv: Ah, formal specification... Some days I miss specifying things in Z. | 09:04 |
| gmb | Very rare days. | 09:04 |
| jtv | You did Z? I'd sort of given up hope that I'd ever meet anybody else again who had! | 09:09 |
| jtv | Just finding LaTeX macros to support it was fun in itself... | 09:09 |
| gmb | Yep, it was required for my degree. | 09:11 |
| jtv | I think it was in an optional course for mine, but not sure. | 09:11 |
| jtv | I just loved the expressive power of quantors. | 09:12 |
| jtv | And with Python, list comprehensions in tests can get you pretty close to that power. | 09:12 |
| jtv | allenap, gmb: my final branch for the year, I hope, is up for review — a Delete view for availability zones. | 12:22 |
| allenap | jtv: I’ll have a look. Anything but more Django. | 12:22 |
| jtv | The remaining known problem is that sorting the nodes listing by zone seems to sort by the zones' IDs, not by their names. | 12:23 |
| jtv | allenap: ahem. | 12:23 |
| jtv | This is a bit heavy on the Django side. But you might get a sympathetic laugh out of it. | 12:23 |
| jtv | Because there's a little Django boo-boo in there. :-) | 12:23 |
| jtv | Thanks for the review Gavin! And Graham, I reviewed your maas-test branch. | 13:05 |
| jtv | gmb: and don't forget to set a commit message on your maas-test branch, or it will just sulk quietly instead of landing. | 13:09 |
| allenap | jtv: You’re welcome. | 13:11 |
| allenap | jtv: Thank you for reviewing my branch :) | 13:11 |
| allenap | gmb: I’m assuming that jtv probably wants to start his holiday, so would you mind reviewing https://code.launchpad.net/~allenap/maas/zone-sort-by-name--bug-1262160/+merge/199460? | 13:36 |
| jtv | Well assumed! | 13:37 |
| jtv | allenap: oh wow, it's that easy? | 13:38 |
| allenap | jtv: I was suprised; I just tried it on the off chance. I guess this is one of those areas where Django works well, once you know the hidden magic behind it all. | 13:38 |
| * allenap is no longer able to give unqualified praise to Django. | 13:40 | |
| jtv | Yeah. As we said a few years back, Django shifts the work from writing the code you need to knowing about the helpers you need. | 13:40 |
| jtv | BTW I did review it after all. | 13:40 |
| jtv | Because I'm so excited. | 13:40 |
| allenap | gmb: I fink you was beeten to eet. | 13:44 |
| === freeflying is now known as freeflying_away | ||
| === mgz_ is now known as mgz | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!