| hatch | jujugui lf a quick doc review https://github.com/juju/juju-gui/pull/37 | 00:48 |
|---|---|---|
| Makyo | On it. | 00:48 |
| hatch | thanks | 00:48 |
| hatch | looks like I need to make some changes to get the docs to compile so I'll make any other changes you find too | 00:51 |
| Makyo | hatch, +1 otherwise. | 00:53 |
| hatch | Makyo curious - it's under the Bit rotted instructions along with a lot of other stuff | 00:54 |
| hatch | should I just leave it? | 00:54 |
| rick_h__ | Makyo: I'm out. I can qa again in the morning. I didn't see a reply back sorry | 00:55 |
| Makyo | rick_h__, np, be well | 00:55 |
| rick_h__ | Makyo: have a good night. The stuff in there ok? | 00:56 |
| Makyo | rick_h__, Yep, just making sure it was basically LGTM otherwise, could submit tonight with those changes, on for another few hours. | 00:57 |
| rick_h__ | Makyo: yea, sorry. I wasn't sure if there was back story to any of it and such. Like the escape things, the shortcuts used | 00:57 |
| rick_h__ | I'll LGTM with comments | 00:57 |
| Makyo | Cool, thanks :) | 00:57 |
| rick_h__ | done | 00:58 |
| Makyo | hatch, If the fix is quick, go ahead, otherwise, remove. | 00:58 |
| rick_h__ | hatch: if those aren't system installed don't you have to find the path in the node_modules to run them? | 00:59 |
| rick_h__ | e.g. lint and such? | 00:59 |
| rick_h__ | hatch: I'm nervous about that change off the top of my head without matching updates to some bin scripts | 01:00 |
| hatch | rick_h__ when you install something with npm -g it's available to any node script | 01:00 |
| rick_h__ | hmmm, you still -g, but it has to be sudo do write to the lib dir | 01:00 |
| hatch | not if you change the permissions | 01:00 |
| rick_h__ | it installs in /usr/lib doesn't it? only root can write there | 01:01 |
| rick_h__ | ugh, bad form to charm perms on /usr/lib man | 01:01 |
| hatch | usr/local/lib | 01:01 |
| hatch | and no, giving sudo to any node script on npm is bad form :P | 01:02 |
| rick_h__ | hmmm, http://paste.ubuntu.com/6597268/ | 01:02 |
| rick_h__ | I'm not a fan of this move | 01:02 |
| hatch | interesting... | 01:02 |
| hatch | rick_h__ you must be running an older install https://npmjs.org/doc/files/npm-folders.html | 01:03 |
| hatch | usr/local is the prefix now | 01:04 |
| hatch | hmm the python tests are failing | 01:06 |
| rick_h__ | hatch: yea, this machine is still 13.04 I think. | 01:07 |
| rick_h__ | hatch: but still, installing something globally in ubuntu is always a sudo thing | 01:07 |
| hatch | I mean version of npm/node when it was installed originally | 01:07 |
| rick_h__ | I'm not a fan of changing that by messing with permissions in system level directories (outside of ~) | 01:07 |
| hatch | agree to disagree? ;P | 01:08 |
| rick_h__ | heh, not without a card to talk about it on standup so I can get reinforcements :) | 01:08 |
| hatch | tbh I don't see where the disadvantage is here | 01:09 |
| rick_h__ | and the test that failed was saucelabs | 01:09 |
| hatch | if anything, restricting it's permissions is better | 01:09 |
| rick_h__ | it's monkeying with standard linux practices | 01:09 |
| rick_h__ | the old issue you had to chown one directory in your home | 01:10 |
| rick_h__ | this is playing outside of home, it's breaking multi-usre systems | 01:10 |
| rick_h__ | user | 01:10 |
| rick_h__ | if user rharding owns the global node modules, how can user mitechie install/use them | 01:10 |
| rick_h__ | it's kind of fundamental to how this stuff works | 01:10 |
| hatch | if root owns them neither user can without sudo | 01:10 |
| rick_h__ | right, but you can grant sudo to muliple users | 01:11 |
| rick_h__ | and if sudo does something, everyone gets access and shares | 01:11 |
| hatch | you can also create a node-dev user group and assign it to them :) | 01:11 |
| rick_h__ | this is setting things to one user, and the wrong one. It's a big breach of linuxy | 01:11 |
| rick_h__ | fine, then update the instructions to use sudo to create a node-dev group, assign permissions to that folder to that group, and add your user account to that group :) | 01:12 |
| rick_h__ | bath time, bbl, but veto without discussion on the change please | 01:12 |
| hatch | lol I think at that point the user knows what to do | 01:12 |
| hatch | ok I'll leave the PR open | 01:12 |
| rick_h__ | and the user knew what to do the old way :) | 01:16 |
| rick_h__ | plus tests still don't pass :P | 01:16 |
| hatch | hey thats your fault those are the sauce labs tests :P | 01:19 |
| hatch | ok I could do something like "Don't want random js scripts from running with sudo? Then you can do this...." :P | 01:19 |
| rick_h__ | bah, it is a timeout isn't it. Crap | 01:24 |
| rick_h__ | I had hoped my branch today would stop that. Oh well, going to production tomorrow should help | 01:25 |
| hatch | :) till tomorrow | 01:25 |
| hatch | cya | 01:25 |
| rick_h__ | jujugui updating FF testing from 16 v16 to 26. Any objections? | 13:14 |
| rick_h__ | actually 25, they don't have 26 | 13:16 |
| === gary_poster|away is now known as gary_poster | ||
| * benji reboots to finish installing updates. | 13:24 | |
| gary_poster | frankban, rick_h__ sorry, family issues made me start late. joining, frankban; may be late rick_h__ | 13:24 |
| frankban | gary_poster: np | 13:24 |
| rick_h__ | gary_poster: rgr | 13:25 |
| bac | hey y'all it's quiz time. who can guess why 'q' as a variable name is bad? | 13:55 |
| benji | bac: because when you're in pdb you'll type "q" expecting to see its contents but instead you "q"uit the debugger | 13:57 |
| benji | (not to mention that single-char variable names are almost always a bad idea) | 13:57 |
| bac | benji: yes, you win a valuable prize! | 13:58 |
| bac | benji: i've only done it three times this morning. (not a quick learner.) | 13:58 |
| benji | heh | 13:59 |
| benji | I've tried to train mayself to use "p q" and "! q = foo" all the time in pdb so as not to have that problem. I've not succeeded. | 14:00 |
| bac | conflicts with other pdb commands are annoying but not quite as much as q. | 14:00 |
| benji | I love the gmail mute-a-thread function. It's great when someone leaves the company or has a baby. | 14:27 |
| hatch | lol | 14:29 |
| hatch | rick_h__ did you see http://stridercd.com/ looks like a node version of jenkins | 14:34 |
| rick_h__ | hatch: yea, and I talked with the dev about our landing issue | 14:35 |
| rick_h__ | hatch: and he was interested in getting a plugin to do it | 14:35 |
| hatch | landing issue? | 14:35 |
| rick_h__ | hatch: but it's not charmed, running nodejs (non-approved tech technically), and was a bigger learning curve | 14:36 |
| rick_h__ | hatch: the jenkins-github-lander stuff. Automated github merge based on test run | 14:36 |
| hatch | ohh right right | 14:36 |
| rick_h__ | so yea, I did look into it and talked with the dev. It's interesting, would have loved to had more time to follow that route as I'm not really a jenkins fan, but this was closer to working then strider for our needs | 14:37 |
| hatch | you probably didnt choose it because it was node.js lol | 14:37 |
| rick_h__ | :P | 14:38 |
| rick_h__ | Honestly, the fact that it would make it harder to get into general use and for juju-core played a factor | 14:38 |
| rick_h__ | but personally, I went through the code and found it cool. | 14:38 |
| hatch | I wish we could have icons for unapproved charms | 14:39 |
| hatch | totally unrelated heh | 14:39 |
| hatch | but with these new must-have-tests rules my ghost charm will never get approced | 14:40 |
| hatch | approved* | 14:40 |
| hatch | jujugui I made some changes to the hacking doc which involve changing permissions on a /usr/local/lib dir instead of using npm with sudo, can you check it out and give your opinion plz https://github.com/juju/juju-gui/pull/37 | 14:42 |
| bac | hatch: why is using sudo to modify directory ownership better than using sudo to install globally? | 14:49 |
| hatch | bac because when running npm under sudo your js script has root privileges - whereas the other way around it can only execute stuff your user can | 14:50 |
| bac | hatch: excellent | 14:51 |
| Makyo | We | 14:53 |
| Makyo | We're not running our script under sudo ?.? | 14:53 |
| Makyo | We shouldn't be, at least. | 14:53 |
| hatch | Makyo `sudo npm -g install jshint` executes the install script under sudo | 14:54 |
| hatch | so it can do what it wants | 14:54 |
| rick_h__ | right, and we've selected jshint to be able to do things...like install a system (all user) available bin/jshint | 14:54 |
| Makyo | Isn't that part of the contract of using npm? Same with apt-get, same with juju on a local provider... | 14:54 |
| rick_h__ | it's the way it works. Just as you sudo apt-get install xxxxx does the same | 14:54 |
| rick_h__ | or sudo pip install pyscss | 14:54 |
| rick_h__ | it's the expected process. We're not doing "sudo npm install -g $user-supplied-thing" | 14:55 |
| Makyo | If the node community doesn't have a framework for dealing with malicious packages in their management system, perhaps we should move away from node. | 14:55 |
| hatch | ok how about this.... I'll change it back to read with sudo then add "If you are not comfortable with giving npm install scripts root you can change the permissions of these directories..." | 14:56 |
| hatch | Makyo it doesn't anyone can upload anything to npm | 14:56 |
| Makyo | Then perhaps we should move away from Node. | 14:56 |
| hatch | you can even override old versions on npm with new code | 14:56 |
| rick_h__ | then add it to to anything installing python or system packages as well hatch | 14:56 |
| rick_h__ | any time you install any software you're doing this | 14:56 |
| hatch | well I was under the assumption that the apt packages were reviewed | 14:56 |
| Makyo | I was under the impression that npm packages were reviewed :) | 14:58 |
| hatch | haha, nope they are not | 14:58 |
| Makyo | :T | 14:58 |
| hatch | I'm assuming the same with apt then? :) | 14:58 |
| Makyo | Apt's reviewed. In order to make it in a release, a package has to be submitted and approved, thus juju-core requiring a PPA for a while. | 14:59 |
| rick_h__ | well, main is. universe isnot so much. pypi is not reviewed | 15:01 |
| rick_h__ | go get is definitely not reviewed | 15:01 |
| hatch | I've never run go get with sudo before | 15:02 |
| Makyo | Hah | 15:02 |
| hatch | pypi requires sudo? | 15:02 |
| Makyo | Outside of a virtualenv. | 15:02 |
| rick_h__ | to install globally, which is why we use virtualenvs | 15:02 |
| rick_h__ | what I would LOVE to see is using npm sans -g and building our scripts to use the node_modules dir | 15:02 |
| rick_h__ | that's the *right* fix imo | 15:02 |
| rick_h__ | this is just breaking linux for the sake of not doing ^ | 15:03 |
| Makyo | +1 | 15:03 |
| hatch | I'm assuming we don't because it's a heavy install? | 15:03 |
| rick_h__ | huh? no, we don't because -g means it's automatically on our system path | 15:03 |
| rick_h__ | and otherwise you have to find the bin/xxxx in the node_modules path | 15:04 |
| rick_h__ | at least that's my guess, I didn't write it out this way | 15:04 |
| bac | gary_poster: call in a few? | 15:04 |
| gary_poster | bac yes, almost | 15:04 |
| bac | gary_poster: ok, ping me here when ready. i'm there but not paying attention to it. | 15:06 |
| gary_poster | ack | 15:06 |
| gary_poster | bac, halloo | 15:20 |
| rick_h__ | benji: got a sec? | 15:38 |
| benji | rick_h__: sure | 15:39 |
| rick_h__ | benji: I'm trying to see where the url the sauce labs tests hit gets set | 15:39 |
| rick_h__ | benji: it looks like in browser.py it looks for $APP_URL | 15:39 |
| rick_h__ | but I don't see it set anywhere | 15:39 |
| benji | rick_h__: IIRC, the Jenkins config sets it when running "make ci-check" | 15:41 |
| rick_h__ | bah, that's right. gotcha | 15:42 |
| Makyo | jujugui call in 10, kanban now. | 15:50 |
| gary_poster | jujugui call in 1 | 15:58 |
| gary_poster | frankban, ping | 16:01 |
| bac | Makyo: i'm interested to hear about your truck stop food. | 16:08 |
| Makyo | bac, I convinced them to switch to Greek food, thankfully :D | 16:08 |
| bac | a greek truck stop would be interesting | 16:08 |
| gary_poster | rick_h__, chrome and ff tests working, yay :-) | 16:14 |
| hatch | rick_h__ apparently Netfilix is going to start streaming 4k sometime soon....good for your new monitor ;) | 16:21 |
| hatch | assuming of course you don't have one of those life sucking isps which limit your bandwidth | 16:21 |
| rick_h__ | hatch: :P | 16:39 |
| rick_h__ | hatch: heh, are there any other kinds | 16:39 |
| rick_h__ | and I don't watch tv on my monitors. I've actually got kind of low ens 720p tvs in the house | 16:40 |
| rick_h__ | maybe one day I'll upgrade to a 'real' tv | 16:40 |
| hatch | hah, well it could be worse, we could life in the Orwellian future which is the UK's current internet | 16:40 |
| rick_h__ | speaking of...curse you dell! still in 'production' | 16:42 |
| hatch | it'll probably be a while, it's very likely made in China, so it'll take a while to boat over here | 16:46 |
| hatch | ohhh d3 | 16:51 |
| hatch | Makyo we should probably update d3 we are a few versions back | 16:52 |
| Makyo | hatch, agreed. | 16:52 |
| Makyo | Will look into it; should be just a drop-in-place. | 16:52 |
| hatch | yeah we will need to make a new shrinkwrap so at the same time it probably wouldn't hurt to revisit the other deps | 16:53 |
| hatch | yui and the like | 16:53 |
| hatch | we HAVE to update YUI to 3.14.1 to support IE11 anyways | 16:53 |
| hatch | heh | 16:53 |
| rick_h__ | hatch: heh, that answers a question about adding IE11 tests I guess then :) | 17:01 |
| hatch | rick_h__ hah yup | 17:01 |
| hatch | I mean to have us support it is pretty trivial upgrade | 17:02 |
| * hatch crosses fingers | 17:02 | |
| hatch | heh | 17:02 |
| hatch | anyone here use znc? | 18:10 |
| rick_h__ | hatch: I think jcsackett used to | 18:10 |
| hatch | I can't figure out how to connect to it heh | 18:10 |
| hatch | it 'should' work from what I can tell but I keep getting rejected | 18:10 |
| rick_h__ | jujugui anyone care to chat and help me think through a decent way of bending the make/build system to my will of running make prod but with the debug config.js? | 18:12 |
| gary_poster | rick_h__, I can and would be happy to in a few--maybe 17 min. | 18:13 |
| rick_h__ | gary_poster: rgr, appreciate it | 18:13 |
| gary_poster | np | 18:13 |
| gary_poster | if anyone else wants to do it that's cool too :-) | 18:13 |
| rick_h__ | definitely, someone must have a tricky non fugly way to to this hidden in their head. All mine suck | 18:14 |
| hatch | rick_h__ make-prod --config debug then in the linked files have a switch :) | 18:15 |
| hatch | of course that would be a lot easier if we didn't use make | 18:15 |
| hatch | heh | 18:15 |
| * rick_h__ is going to come over there and cut your new powercord | 18:16 | |
| hatch | hey it's a good idea! | 18:16 |
| gary_poster | hey rick_h__ do you have a hangout or hall I make one? | 18:31 |
| gary_poster | shall | 18:31 |
| rick_h__ | gary_poster: can make one up, sec | 18:31 |
| gary_poster | cool | 18:31 |
| rick_h__ | https://plus.google.com/hangouts/_/7acpjrujr1s6qjbhlf3kvuegro?hl=en | 18:31 |
| hatch | anyone know iptables well? I think my znc issue is that it's not allowing the data through the port https://gist.github.com/hatched/4c2effe2e92e9487bf13 can you see anything wrong with this output? | 18:39 |
| frankban_ | guihelp: I need two reviews + QA for https://codereview.appspot.com/44310043 (quickstart remove env). Anyone? no rush, thank you and have a nice evening! | 18:40 |
| bac | frankban_: i'll do one later | 18:41 |
| gary_poster | frankban I will take one later | 18:41 |
| frankban_ | bac, gary_poster thanks | 18:41 |
| hatch | welp it's definitely a ip tables issue because I can't even get nc to connect | 18:59 |
| hatch | but lunch over, back to work | 18:59 |
| rick_h__ | jujugui CI branch update review please. https://github.com/juju/juju-gui/pull/38 | 19:32 |
| rick_h__ | two successful test runs in a row woot! | 19:32 |
| gary_poster | woot :-) | 19:32 |
| bac | yay | 19:32 |
| hatch | on it | 19:32 |
| hatch | wow two in a row? That's gota be a first in MONTHS!!! | 19:33 |
| hatch | lol | 19:33 |
| rick_h__ | hah! 10min run time atm with all three browsers only on build prod | 19:33 |
| rick_h__ | added a card for adding back in build-debug, but was having timeout issues on that and prod is working nicely. Want to reevaluate once this proves stable-ish | 19:33 |
| hatch | rick_h__ looks like IE is last? | 19:34 |
| rick_h__ | hatch: yes | 19:34 |
| hatch | We used to run it first because it was the most likely to fail | 19:34 |
| hatch | I'll add a comment but I wanted to hear if you had any input | 19:34 |
| rick_h__ | well, I figure if it's last then you know the test runs itself was good, just IE hates you | 19:34 |
| rick_h__ | if the first one blows up, you're not sure if it's CI in general or just IE failing a test | 19:34 |
| rick_h__ | and the time diff of a coupe of minutes isn't going to make a big diff imo | 19:34 |
| gary_poster | rick_h__, +1 on prod only. we can move debug to aggregated post-commit perhaps, at some point (and maybe prod too if it becaomes too annoying) | 19:35 |
| rick_h__ | I'll work on some instructions for running locally. I was running IE sauce tests from my local environment IE only so I think that's a "better" way to debug IE failures | 19:35 |
| rick_h__ | hatch: so I'm -1 on moving it up the list imo | 19:35 |
| hatch | lgtmd | 19:44 |
| rick_h__ | hah, poking at the github graphs. Go hatch go "On develop, 50 files have changed and there have been 343 additions and 1,302 deletions" | 19:45 |
| hatch | rick_h__ hah this is a little disturbing https://github.com/juju/juju-gui/graphs/contributors we remove more than 50% of the code we write! | 19:46 |
| hatch | bac has almost removed 100% of the loc that he has written lol | 19:47 |
| gary_poster | it's a good thing | 19:47 |
| rick_h__ | hah, well that's some damn fine refactoring | 19:47 |
| hatch | lol is it? Aren't we supposed to do it right the first time....measure twice, cut once sort of thing ;) | 19:47 |
| rick_h__ | though you're getting credit for removing the code I wrote. So wonder how that balances out over time. | 19:47 |
| rick_h__ | hatch: nope, we're agile. We build, test, refactor, build, test, refactor | 19:47 |
| * bac rock! | 19:48 | |
| hatch | haha | 19:48 |
| gary_poster | hatch, our last project would not allow you to add code unless you had removed an equivalent amount | 19:48 |
| hatch | haha oh really? Interesting | 19:48 |
| bac | gary_poster: did you ever track that? | 19:48 |
| bac | gary_poster: it happened as we were fading away | 19:48 |
| gary_poster | bac, true | 19:48 |
| rick_h__ | orange squad had a bzr command we ran so we could justify crap | 19:48 |
| rick_h__ | sucked because we kept claiming exceptions to get private projects finished | 19:48 |
| rick_h__ | "I know this adds code, but private projects must go on....move aside" | 19:49 |
| bac | anyone using clef, phone-based oauth tool? | 19:51 |
| rick_h__ | nope, just lastpass mobile for that stuff | 19:52 |
| gary_poster | yeah lp me 2 | 19:52 |
| rick_h__ | well, I guess that's a 2fa ish lastpass merged thingy | 19:52 |
| bac | yeah, but clef automates the communication between site and phone by talking via squiggly lines | 19:52 |
| rick_h__ | I don't get how it's 2fa though if it only requires your phone? | 19:53 |
| rick_h__ | what's the second factor? | 19:53 |
| hatch | your FIST! | 19:53 |
| bac | it's not 2fa afaict | 19:53 |
| rick_h__ | Secure, easy, passwordless 2-factor authentication in less than 10 minutes. | 19:53 |
| rick_h__ | from the website :/ | 19:53 |
| bac | oh | 19:53 |
| bac | seems like they are just an oauth service and they use your phone as identity rather than a password | 19:54 |
| bac | rick_h__: i guess they consider the 4 digit passcode to get into the app as 1 factor | 19:55 |
| rick_h__ | bac: ah, gotcha | 19:55 |
| hatch | it's interesting | 19:57 |
| hatch | I could see lastpass and that type of system working really well | 19:57 |
| hatch | although pattern is far more secure than 4 digit pin heh | 19:57 |
| bac | rick_h__: i'm proposing the charmworld qa branch. would you have time to review it, being the godfather of all that stuff + migrations? | 19:57 |
| rick_h__ | bac: sure thing, ok for it to be first thing in the morning? | 19:58 |
| bac | rick_h__: yeah, i guess. charmworld isn't landing before monday | 19:58 |
| bac | if then | 19:58 |
| rick_h__ | I just got CI landed with IE support and want to drop the mic and EOD feeling all badass atm. :) and I have to run an errand to get presents in the mail atm | 19:58 |
| bac | np | 19:58 |
| rick_h__ | bac: thanks, I'll hit it up either later tonight or first thing in the morning. | 19:58 |
| rick_h__ | jujugui all three browser saucelabs has landed. and if we want to add safari it's one step away as well. landing/test times are around 10min now | 19:59 |
| hatch | love it | 20:00 |
| * rick_h__ runs away before something breaks | 20:00 | |
| gary_poster | thank you rick_h__ ! Very cool | 20:00 |
| benji | very nice | 20:00 |
| bac | cool | 20:02 |
| hatch | I'm actually surprised we didn't have CI for so long and everything we have still passes | 20:07 |
| hatch | how awesome are we??? | 20:07 |
| benji | level of awesome: lucky | 20:07 |
| hatch | PFFT | 20:09 |
| hazmat | very cool | 20:14 |
| bac | benji i sometimes wish your irc comments came with a 'like' button. | 20:20 |
| benji | That's how I'll make my millions: IRC + Like Button | 20:21 |
| rick_h__ | hatch: remember, we're running what, 6 tests? | 20:21 |
| rick_h__ | :P | 20:21 |
| bac | i'd buy one.[*] | 20:21 |
| bac | [*] requisite daily Raising Arizona reference | 20:21 |
| bac | rick_h__: at your leisure https://codereview.appspot.com/44070045 | 20:22 |
| hatch | rick_h__ ohh you aren't running the unit tests in each browser? | 20:24 |
| hatch | I can't seem to write d3 code that looks good | 21:03 |
| hatch | no matter what chaining just looks horrible :/ | 21:03 |
| hatch | Makyo are you around? | 21:08 |
| hatch | Makyo when you get back from lunch I have a question about d3 not noticing a data change | 21:08 |
| Makyo | What's up? | 21:09 |
| hatch | Makyo doh nm I screwed up, I forgot I was still in the d3 'enter' phase | 21:14 |
| hatch | sorry to botha | 21:14 |
| Makyo | Glad I could help :D | 21:14 |
| hatch | haha rubber duck debugging :D | 21:15 |
| hatch | I'm switching the relations tab to use d3....wow there is a LOT more loc than just using a template haha | 21:15 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!