/srv/irclogs.ubuntu.com/2013/12/28/#ubuntu-motu.txt

TheLordOfTimei have a general question, if only half of a patch applies, what should one do?03:54
TheLordOfTime(if i'm patching for, say, an SRU or a security update debdiff)03:54
Noskcaj10As in half is fixed already, or the patch needs work03:55
TheLordOfTimeNoskcaj10: as in, the patch from upstream (Debian in this case) only half works03:55
TheLordOfTimelemme grab the diff i'm looking at and explain what i mean03:55
TheLordOfTimehttp://anonscm.debian.org/gitweb/?p=collab-maint/nginx.git;a=commitdiff_plain;h=3a4f08671c87b7fc89e077542edfd6eb651f1803 is the debian commit for this...03:56
Noskcaj10I'm guessing you do whatever is needed to the patch for the expected results to work03:56
TheLordOfTimeignoring the news file, the nginx-common.postinst changes apply03:56
TheLordOfTimebut the preinst ones don't (nonexistent code, so the patch is trying to remove something that doesn't exist)03:56
TheLordOfTimekinda uncertain how to proceed there03:56
TheLordOfTimeNoskcaj10: ehh, that's what i was hoping *not* to have to hear...03:56
TheLordOfTimebecause I don't know how to "fix" the patch to apply it, the expected result is to remove code from the preinst... but the preinst doesn't have that code it's trying to remove (in Precise)03:57
TheLordOfTimeso `patch` says "It looks like this is already applied..."03:57
Noskcaj10Does the current debian preinst match the one you're trying to patch? If so, you're all good. If not, further investigation needed04:00
TheLordOfTimeNoskcaj10: i could always skip working on Precise, and work from Saucy backwards until i run into this problem again, then ask the sec team for guidance04:00
Noskcaj10if you want04:00
TheLordOfTimeNoskcaj10: no, it doesn't match, but there's substantial delta between 1.1.19 (Ubuntu Precise) and 1.4.4 (in Debian)04:00
TheLordOfTime(I'm ignoring Trusty because i already requested a merge of 1.4.4-2 from Debian to Trusty)04:01
TheLordOfTimemeh, either way, probably shouldn't be coding at 11 PM,  since i'm kinda tired >.>04:01
TheLordOfTimemaybe I'm missing something somewhere...04:01
Noskcaj10have a look again tomorrow. And i think you need to SRU to saucy before precise04:03
TheLordOfTimeNoskcaj10: considering this is a security fix, the debdiffs for all releases get attached to the bug at the same time04:08
TheLordOfTime(so the sec team can review them all at once)04:08
TheLordOfTimeexcept Trusty, because merging04:08
TheLordOfTime(which cjwatson is going to handle)04:08
TheLordOfTime(sorry for the ping)04:08
=== jalcine is now known as jacky
cjwatsonTheLordOfTime: uploaded10:31
=== paddy_ is now known as paddy
kalon33hello everybody, somebody else experiencing 404 errors when refreshing updates list?17:06
kalon33using archive.ubuntu.com17:06
=== yofel_ is now known as yofel

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!