=== jono is now known as Guest94995
=== duflu_ is now known as duflu
Saviqtsdgeos, question: now that we have delegateCreationBegin/End, do we actually gain much by filtering the actual model instead of just clipping it?08:54
Saviq"it" being the view08:54
tsdgeosSaviq: you save having to do the math of how tall two rows are08:57
tsdgeosand also delegateCreationBegin/End still do buffering outside the delegateCreationBegin/End area08:57
tsdgeosso you'd end up with a row more08:57
Saviqtsdgeos, but I do have do to the math for how tall the full view is going to be ;)08:58
tsdgeosbut for the VerticalJournal we'll need clip08:58
tsdgeossince they want "half" items there08:58
Saviqtsdgeos, and then do the proxying with the LimitProxy08:58
tsdgeosyeah haven't thought about it but it's a possibility yeah08:59
Saviqtsdgeos, yeah, for VJournal we'll need to clip - and we'd need to calculate how many items to show anyway, which would be pretty tricky, too08:59
Saviqtsdgeos, if we wanted to filter, that is08:59
tsdgeosSaviq: can we get a test for making sure no like is longer than 120 chars? that'd way i'd hate the rule and not the messenger09:00
Saviqtsdgeos, you mean dandrader? ;D09:00
tsdgeosi mean the messenger :)09:02
Saviqtsdgeos, I'm not sure - we could, of course, but did we ever actually agree to impose that limit...09:04
Saviqtsdgeos, would you have time to review https://code.launchpad.net/~unity-team/unity8/unity-scope-tool/+merge/199831 ?09:06
tsdgeosSaviq: sure09:09
Saviqtsdgeos, thanks09:10
Saviqtsdgeos, does the fact that PathView is always looped feel weird to you, too? do you know if there's any reason (like it being difficult otherwise) to not allow disabling it via a property or something?09:23
tsdgeosSaviq: yeah i see it's a bit weird, but haven't looked at it in detail so no idea if it'd be hard to fix or not09:27
Saviqtsdgeos, ok thanks09:28
* Saviq just looked at Carousel.qml and longed for using a PathView there ;P09:28
tsdgeosyeah :D09:29
=== dandrader is now known as dandrader|afk
Saviqtsdgeos, is GenericName required at all?10:01
tsdgeosSaviq: nope10:01
Saviqtsdgeos, dropping, it doesn't make sense10:01
Saviqtsdgeos, done10:02
tsdgeosSaviq: do we care for i18n of the unity-scope-tool ?10:04
Saviqtsdgeos, hmm we should - domain not set, is it?10:04
Saviqtsdgeos, or no i18n at all is there...10:05
tsdgeosSaviq: we are not calling i18n at all no10:05
tsdgeosthat's what i was asking10:06
tsdgeosshould we10:06
tsdgeosand if we should10:06
tsdgeosshould we extract to the same .pot or to a different one10:06
tsdgeosmy vote is for yes and different10:06
Saviqtsdgeos, yeah, that's what I was thinking, which means we need a separate qml dir for it10:06
tsdgeosbut that's just me, i can understand if we say "dev tool, learn english"10:06
Saviqtsdgeos, I think let's go for english now, as it's not trivial to have a separate .po*10:07
Saviqand wouldn't like to "pollute" the unity8 domain10:07
Saviqand we can always add it later10:09
tsdgeosthe time test fails here btw10:14
tsdgeosis it locale dependent?10:14
tsdgeos   Actual   (formatter.timeString()): 03-01-2014 11:0510:14
tsdgeos   Expected (time.toString("dd-MM-yyyy hh:mmAP")): 03-01-2014 11:05AM10:14
Saviqtsdgeos, yes it is10:16
Saviqtsdgeos, should pass under LANG=en_US.UTF-810:16
tsdgeoscan we force that in the make test step?10:17
Saviqtsdgeos, we should, yes10:17
Cimiwhen should (if it) input fall through? https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/125731210:22
ubot5Ubuntu bug 1257312 in unity8 (Ubuntu) "Input going through the wifi connection dialog when not in any input field" [Medium,In progress]10:22
SaviqCimi, never10:23
SaviqCimi, the bubble should be input-opaque, basically10:23
tsdgeosSaviq: i'd go with http://paste.ubuntu.com/6683685/ but if you don't agree that's fine :D10:23
CimiSaviq, and on desktop?10:24
SaviqCimi, we don't really support that use case yet (it doesn't blur / go transparent)10:25
Saviqtsdgeos, that's copy/paste ;)10:25
Saviqtsdgeos, from main.cpp10:25
Saviqtsdgeos, but yeah, let's10:25
Saviqtsdgeos, fixed10:26
tsdgeosSaviq: i'm getting lots of "<Unknown File>: SyntaxError: Unexpected token u"10:27
tsdgeoswhen running the tool10:28
tsdgeosany idea where that comes from10:28
Saviqtsdgeos, JSON parsing10:28
tsdgeosso which json is wrong?10:30
Saviqtsdgeos, none should be wrong, maybe the overridden one?10:30
tsdgeosdo i have a too old unity-scopes-shell?10:31
Saviqtsdgeos, possibly10:31
Saviqtsdgeos, try running under UNITY_FORCE_NEW_SCOPES=110:31
mhr3i was getting that error too10:32
mhr3always wondered where is it from :)10:32
tsdgeosit gets very unhappy then10:32
tsdgeosSaviq: http://paste.ubuntu.com/6683708/10:32
Saviqtsdgeos, yeah, you don't have any scope10:32
Saviqtsdgeos, you need the onlinemusic scope from ppa:ubuntu-unity/demo-stuff10:33
Saviqtsdgeos, sorry about missing that detail :)10:33
mhr3you can also use the awesome --scope-dir param10:33
Saviqmhr3, assuming you build it somewhere locally, that is?10:34
mhr3a built checkout of lp:unity-scopes-api would do10:34
Saviqmhr3, is "overrideCategoryJson" available anywhere already?10:35
Saviqmhr3, as in, in a package?10:35
tsdgeosSaviq: mhr3: so i need ppa:ubuntu-unity/demo-stuff or lp:unity-scopes-api or both?10:35
mhr3Saviq, you approved it yesterday, so should be in demo-stuff10:35
Saviqtsdgeos, just the ppa should be enough, /me checks10:35
mhr3yep, ppa only should suffice10:36
Saviqsomehow I didn't get the package :/10:36
tsdgeosis ppa:ubuntu-unity/demo-stuf the correct name?10:36
tsdgeosadd-apt-repository complaiined10:37
mhr3Saviq, oh, i did some renames, it's now considered older than what was there10:37
mhr3Saviq, so just force reinstall10:37
Saviqmhr3, yup, see that10:37
Saviqtsdgeos, +f10:37
Saviqtsdgeos, but unity-team10:37
tsdgeosi had the f there10:37
Saviqtsdgeos, ppa:unity-team/demo-stuff, sorry10:37
tsdgeosthat worked10:38
tsdgeosSaviq: apt-get tells me i already had unity-scope-onlinemusic installed10:38
mhr3tsdgeos, the new one?10:39
Saviqtsdgeos, yes, different version10:39
tsdgeosso how do i install the new one?10:39
mhr3tsdgeos, apt-cache policy unity-scope-onlinemusic?10:40
Saviqtsdgeos, 0.1+14.04.20131129.1~bzr59-0ubuntu1~ubuntu14.04.1 is there in the ppa, is higher version than in archive10:41
tsdgeosi guess i needed an apt-get update...10:41
Saviqtsdgeos, that helps, yes10:41
Saviqmhr3, why do we need the popup for overriding the category?10:41
mhr3Saviq, cause i wanted "apply" button :)10:42
Saviqmhr3, we can have the apply button without the popup ;)10:42
mhr3Saviq, also, you get more real estate :)10:42
Saviqmhr3, yeah, but then should we maybe drop the one from the side bar altogether10:42
Saviqmhr3, as it's confusing10:43
mhr3Saviq, maybe, i considered that a view-only10:43
Saviqmhr3, should've made it so ;D10:43
mhr3though couldn't find editable property10:43
mhr3not that i looked for it too much10:43
Saviqmhr3, activeFocusOnPress: false should work10:44
Saviqmhr3, or well... file:///usr/share/ubuntu-ui-toolkit/doc/html/qml-ubuntu-components0-textarea.html#readOnly-prop10:45
mhr3yea, i imagined that it'll be very accurate naming :P10:45
Saviquh, still displays the cursor10:47
tsdgeosSaviq: that didn't help at all10:50
tsdgeosSaviq: http://paste.ubuntu.com/6683774/10:50
Saviqtsdgeos, `status scope-registry`?10:51
mhr3Saviq, btw why are the card titles so broken? the antialiasing seems to be majorly broken10:51
mhr3tsdgeos, `restart scope-registry`10:51
Saviqmhr3, because it's not using cards, but the old UI10:52
Saviqmhr3, merge into new-scopes and try there?10:52
mhr3Saviq, nope, it's using cards for me10:52
mhr3it's just terrible on the white background10:52
mhr3oh wait10:53
mhr3no you're right10:53
mhr3wrong branch10:53
tsdgeosSaviq: ok, the restart worked10:54
mhr3Saviq, still bad on category titles though10:54
Saviqmhr3, yeah, probably a shadow or some such10:54
Saviqmhr3,             style: Text.Raised10:56
Saviq            styleColor: "black"10:56
Saviqtsdgeos, mhr3, bug #126576610:57
ubot5bug 1265766 in ubuntu-ui-toolkit (Ubuntu) "Read-only TextArea gets focus and displays the text cursor" [Undecided,New] https://launchpad.net/bugs/126576610:57
Saviqplease confirm10:57
mhr3done, thx10:58
Saviqtsdgeos, you still won't be able to override the categories10:59
tsdgeostbh i don't think that's a bug10:59
Saviqtsdgeos, not unless you rebase onto lp:~unity-team/unity8/new-scopes10:59
tsdgeosif you don't want to get the focus, disable it :D10:59
Saviqtsdgeos, should default to false if read only, IMO11:00
mhr3Saviq, i guess the "black" should be a global const11:03
mhr3it's on too many places11:03
Saviqmhr3, true11:03
Saviqmhr3, should be part of the palette11:03
mhr3didn't know there's such a thing, but sure :)11:04
Saviqmhr3, file:///usr/share/ubuntu-ui-toolkit/doc/html/qml-ubuntu-components-themes0-palettevalues.html11:05
Saviqmhr3, used like so file:///usr/share/ubuntu-ui-toolkit/doc/html/qml-ubuntu-components-themes0-palette.html11:05
* Saviq finds it funny that he can link to a file on his own file drive ;)11:06
mhr3Saviq, though shell palette and apps palette should be different, no?11:06
Saviqmhr3, it is11:06
Saviqmhr3, they're per-theme11:07
mhr3ah, ok11:07
mhr3heh, i noticed just now that these were file:/// urls11:08
tsdgeosthe repeater thing for the textarea is a bit weird11:08
mhr3weird, but works :)11:08
mhr3and it wasn't easy to get it into that state :P11:09
Saviqmhr3, h4x0red you ;D11:14
mhr3Saviq, grrr, i knew unity8 is just a trojan!11:15
Saviqmhr3, it's unity7 that spies on us all the time!11:15
mhr3ah, so you're saying we just took it further? :)11:20
mhr3more "features" :)11:20
tsdgeosSaviq: mhr3: ok, added a final comment and my approval, if you want i can top approve too11:20
Saviqtsdgeos, thanks!11:20
Saviqtsdgeos, mhr3, +1 on Q_INVOKABLE data() instead of the repeater11:22
mhr3i'd prefer QVariantMap get(int index) then11:24
Saviqmhr3, that's something that we try not to do11:31
Saviqmhr3, to not encourage getting the whole dataset unnecessarily11:31
SaviqCimi, you should've re-submitted Mirco's merge proposal, not do a new one11:32
=== dandrader is now known as dandrader|lunch
SaviqCimi, /me does11:32
SaviqCimi, and next time please just branch from the branch in question and commit on top of it, to not lose the history11:34
mhr3Saviq, but it's just one row of the dataset11:49
Saviqmhr3, that's still more than just one role11:49
mhr3one role is ENOTENOUGH :P11:50
CimiSaviq, I redid the branch11:50
SaviqCimi, thanks11:50
CimiSaviq, I did not use his11:50
SaviqCimi, yes I know, that's what I said - you should have used his, merge trunk, do your changes11:50
CimiSaviq, there were conflicts11:50
SaviqCimi, so that his commit is still there in the history11:50
SaviqCimi, not important, just in general we should try and maintain the history11:51
CimiSaviq, https://code.launchpad.net/~unity-team/unity8/carousel-shader/+merge/196942 ?12:13
=== _salem is now known as salem_
SaviqCimi, animation still missing?12:13
Cimioh ok12:14
tsdgeosdandrader|lunch: i think i've addressed all your concerns12:36
tsdgeosdandrader|lunch: can you please recheck?12:36
=== alex-abreu is now known as alex-abreu|off
=== dandrader|lunch is now known as dandrader
=== greyback_ is now known as greyback|lunch
Saviqmhr3, back to data() vs. get() etc., maybe it'd be enough if picked the value from the option selector?14:04
Saviq mhr3, by adding a property on the selector delegates?14:04
Saviq or properties, for that matter14:04
Saviqmhr3, if the selector doesn't give you access to the selected item, just go 'onSelectedChanged: categorySelector.selectedItem = categoryDelegate' or so14:06
Zhenechwhat's to do to get a package from "proposed" to "release" in trusty?14:07
tsdgeosZhenech: i'd say probably #ubuntu-devel is a better channel to ask that question14:14
Zhenechups, i thoght this is actually -motu14:14
=== greyback|lunch is now known as greyback
tsdgeosSaviq: standup?14:33
tsdgeosCimi: ↑14:33
Saviqtsdgeos, rigt14:33
Saviqmhr3, tsdgeos I just pushed a simplified "get data from the model" approach to the scope tool14:38
tsdgeoslet me see14:40
mhr3Saviq, aaah, clever14:46
Saviqmhr3, ;)14:47
Saviqmhr3, offtopic, got a SA power adapter?14:47
Saviqif not, it's about time14:48
mhr3Saviq, that reminds me, what SA power adapters look like?14:48
Saviqnothing universal will work14:48
Saviqmhr3, https://www.google.com/search?q=south+africa+plug&client=ubuntu&hs=A0m&channel=fs&tbm=isch&source=iu&imgil=ROKN542cw-aGfM%253A%253Bhttps%253A%252F%252Fencrypted-tbn1.gstatic.com%252Fimages%253Fq%253Dtbn%253AANd9GcQrjgzIyU1wIrARhw2YsoPCvNW8ktNhNOVJfn_MfQvpFxUuxkf4%253B346%253B346%253Bho-Yz_gQZBODQM%253Bhttp%25253A%25252F%25252Fwww.power-cord.org%25252Fsouth-africa-plug.html&sa=X&ei=rs3GUsW4O-m04ASQ0IGIBQ&ved=0CDIQ9QEwAg&biw=1219&bih=781#facrc=_&i14:48
Saviqmhr3, it's a huge 3-prong one14:48
mhr3Saviq, think dednick will have one, will try to borrow from him14:48
Saviqmhr3, right, makes sense14:48
mardylarsu: hi! Do you have a minute for a question about indicator-messages?15:09
tsdgeosSaviq: that looks more reasonable :-)15:11
tsdgeosmhr3: Saviq: so want me to top-approve?15:11
mhr3tsdgeos, fine by me15:11
mardytedg: or do you (see 4 lines above ^)?15:12
mardycharles: or you ^ :-)15:14
tedgmardy, What's up?15:15
mardytedg: I'm having a look at bug 113008415:16
ubot5bug 1130084 in unity (Ubuntu) "restore IM presence at startup" [Medium,Triaged] https://launchpad.net/bugs/113008415:16
mardytedg: I'm trying to understand how things work15:16
mardytedg: so, it seems that indicator-messages fires a DBus signal (StatusChanged), but there's no one listening to it15:17
tedgmardy, For the most part we just try to reflect what telepathy has as it's state.15:17
tedgmardy, It seems to me that telepathy should be saving that state and restoring it.15:17
mardytedg: because telepathy-indicator.desktop has X-GNOME-Autostart-Delay=1515:17
mardytedg: is there a way for telepathy-indicator to get the current status from messages-indicator? I tried inspecting the latter with d-feet, but I couldn't find any DBus properties15:18
tedgmardy, It could just look at the status of the action.  But, really, indicator-messages shouldn't be driving the state.  It should be representing the state that telepathy has.15:20
tedgmardy, So telepathy-indicator should look to telepathy to find out what the state is.  And request and update based on that.15:21
mardytedg: ah, then I understood it the other way round15:21
tedgmardy, For debugging you can get the state with: $ gdbus call --session --dest com.canonical.indicator.messages --object-path /com/canonical/indicator/messages --method org.gtk.Actions.Describe status15:23
mardytedg: so, when the user changes the presence status from the indicator, a signal is emitted, and any presence-capable app should try to match that status and save it in its config?15:23
tedgmardy, Correct, we don't require a save, but that makes sense to me.15:24
mardytedg: I see... I'll try to fix telepathy-indicator then.15:25
mardytedg: and do you know the reason of that 15 seconds delay? Isn't that a bit too much? (or is msecs?)15:25
tedgmardy, Why not fix telepathy?15:25
tedgSeems this should be a mission-control feature more than a bridge feature.15:26
tedgmardy, Not sure, I'm guessing it was a boot optimization thing.  kenvandine might know.15:26
mardytedg: I don't think so, mission-control probably doesn't even start by default.15:27
tedgmardy, We should really switching it an upstart job that is "start on started indicator-messages"15:27
kenvandineit was for boot speed15:27
kenvandinewe delayed a bunch of things like that15:27
kenvandineto let stuff settle more15:27
mardytedg: I disagree; mission-control doesn't save its presence status, and starting it by default would be annoying for people who don't use it15:28
tedgmardy, Hmm, seems you're right.  IMHO, kinda silly, but eh, okay.15:28
tedgmardy, It shuts down if there are no accounts.  So really it'd just check to see if it's configured and die.15:28
tedgmardy, I don't think that'd be too annoying.15:28
mardytedg: I'd actually like if instead of reacting to a StatusChanged signal these bridges could register itself as DBus activatable, and indicator messages invoke a method on them when needed15:29
tedgmardy, If they're connected they need to be running, so I'm not sure dbus activatable is the right choice.15:30
tedgmardy, For instance you wouldn't want to start up XChat just to see if it wanted to change the status.15:30
tedgmardy, When it's only a bridge, that makes sense.  But I'd rather have bridge be the minority case.15:30
mardytedg: exactly, I would like them *not* to be running by default, but started on demand, if needed15:30
tedgmardy, How would we know if they're needed?15:31
mardytedg: we always invoke SetStatus(...) on them, when the user changes the status from the menu; if they are running, they'll react to it (and maybe quit if the status is "offline"), if they aren't they'll be started15:32
mardytedg: compare it to the current situation, where the *need* to be running15:32
mardyall the time15:33
tedgmardy, If they're connected to an IM network, they need to be running to keep the socket to the network open.15:33
mardytedg: yes. But if the status is "offline", it would be nice if they quit15:33
tedgmardy, And you want us to restart everything possible if you set to "Available" ?15:34
mardytedg: D-Bus doesn't restart already running services15:34
tedgmardy, I mean, I have IM clients installed that I'm not using.  They shouldn't start.15:35
mardytedg: mmm... I'm starting to see your point15:36
mardytedg: I was assuming that this indicator-messages was written especially for things like telepathy, but now I realize that maybe telepathy is the weird one. Right?15:36
tedgInterestingly someone could set up an upstart job to start when it sees the DBus signal.15:36
tedgI think that telepathy kinda is.  Though, frankly it's our biggest user.15:37
mardytedg: I'm thinking about the telepathy-indicator bridge; my point is that if the status is "offline", it should not be running15:37
tedgAnd perhaps that's the special case.  We should start only those special cases when going to an active status.15:38
mardytedg: what about this: we keep everything as it is, but we add a way for presence-aware apps to register themselves, and get their SetStatus() DBus method called at the same time as StatusChanged is emitted15:39
tedgI wonder if the real solution here is just to bless telepathy is the ruler of everything status, and tell others to integrate there.15:39
mardytedg: and we make telepathy be one (the only one?) of the implementors of this interface15:40
tedgI'd say that we destroy the interface and call telepathy directly.15:40
mardytedg: +115:41
tedgI think that I need to think about the implications there a bit... but, it doesn't seem crazy right now :-)15:42
mardytedg: on the practical side, I think I can quickly fix bug 1130084 in telepathy-indicator, without much effort; for the rest, maybe I can file a wishlist bug, and let's see who gets the time to do it?15:43
ubot5bug 1130084 in unity (Ubuntu) "restore IM presence at startup" [Medium,Triaged] https://launchpad.net/bugs/113008415:43
tedgmardy, Makes sense.  I think charles is the one scheduled to open up indicator-messages next.15:49
tedgThough that's for greeter work.15:49
mardytedg: OK, thanks15:51
kenvandinemardy, how do you plan to store the last presence?15:51
kenvandineit's annoyed me for ages, i had considered storing that in gsettings but someone convinced me not to15:52
mardykenvandine: not sure. Just an .ini file, unless telepathy-indicator is already using other stuff (DConf?)15:52
* kenvandine wonders if accountsservice has anything for that15:52
Saviqkenvandine, sure, you can story any property you want in accountsservice15:52
kenvandinei really want a global presence15:52
mardykenvandine: if telepathy-indicator is the one who stores the settings and reads it, I think it can be a file private to it15:53
kenvandinewe weren't really using accountsservice when i was looking into this15:53
tedgI think that you want to store the user selected status, not generally the status in GSettings.15:53
tedgThe reason is that you don't want to store when the screensaver sets you to away.15:54
kenvandinegood point15:54
tedgWhere in account service you'd want to have the current status.15:54
kenvandinewhat does gnome-shell and kde do?15:55
CimiSaviq, re-run carousel shader, but I only see mocks on the desktop, no icons or so... what change?17:09
elopioHello, anybody around for a review?18:26
elopioCimi: ping? ^18:33
larsumardy: sorry I was out before. Are you still around?19:42
mardylarsu: hi! No problem, I already solved the issue with tedg19:43
larsumardy: awesome :) And happy new year!19:43
mardylarsu: thanks, same to you!19:44
=== salem_ is now known as _salem

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!