=== gary_poster is now known as gary_poster|away | ||
axw | thumper, wallyworld_: I think the authorisation worker should be enabled for null | 01:15 |
---|---|---|
axw | the ubuntu user is there, after all | 01:15 |
dimitern | morning all! | 06:40 |
rogpeppe | dimitern: yo! | 08:44 |
rogpeppe | dimitern: did you have a good one? | 08:44 |
dimitern | rogpeppe, hey | 08:44 |
dimitern | rogpeppe, oh yeah :) and much needed at that | 08:44 |
rogpeppe | dimitern: cool | 08:44 |
dimitern | rogpeppe, yourself? | 08:45 |
rogpeppe | dimitern: yeah, good thanks | 08:45 |
dimitern | rogpeppe, so what's cookin' ? i've been catching up on emails | 08:45 |
rogpeppe | dimitern: same old same old, really | 08:46 |
rogpeppe | dimitern: HA is coming along | 08:46 |
dimitern | rogpeppe, sweet! | 08:46 |
rogpeppe | dimitern: there was an interesting discussion about charms vs default series on the juju mailing list yesterday | 08:46 |
rogpeppe | dimitern: you might want to contribute | 08:46 |
dimitern | rogpeppe, yeah I read through it | 08:46 |
dimitern | rogpeppe, weekly meeting is in 1 hour, right? | 09:04 |
rogpeppe | dimitern: i think so | 09:04 |
rogpeppe | dimitern: yeah | 09:04 |
dimitern | rogpeppe, cheers | 09:07 |
fwereade | morning everybody | 09:11 |
dimitern | fwereade, morning! | 09:11 |
* fwereade is having a happy fun water-main-leaking-into-electrics day | 09:12 | |
fwereade | dimitern, happy new year :) | 09:12 |
dimitern | fwereade, to you too :) | 09:12 |
dimitern | fwereade, that sounds dangerous | 09:13 |
fwereade | dimitern, just got dominion hinterlands, looks interesting, haven't played it yet | 09:13 |
fwereade | dimitern, indeed | 09:13 |
dimitern | fwereade, sweet! | 09:13 |
fwereade | dimitern, well the circuit breaker works at least | 09:13 |
dimitern | fwereade, so in addition to leaky drains now the mains are causing issues | 09:13 |
fwereade | dimitern, and we're ok for the moment because the water is off | 09:13 |
fwereade | dimitern, well, we fixed the drains and they seem ok now | 09:14 |
fwereade | dimitern, and hopefully it's just the one pipe | 09:14 |
fwereade | dimitern, but, well, we shall see | 09:14 |
dimitern | fwereade, *fingers crossed* | 09:14 |
fwereade | cheers :) | 09:14 |
=== _thumper_ is now known as thumper | ||
jam | standup time | 09:59 |
jam | https://plus.google.com/hangouts/_/calendar/bWFyay5yYW1tLWNocmlzdGVuc2VuQGNhbm9uaWNhbC5jb20.sbtpoheo4q7i7atbvk9gtnb3cc | 09:59 |
jam | welcome back dimitern | 09:59 |
dimitern | thanks jam | 09:59 |
jam | mgz: poke ^^ | 10:00 |
axw | I can't get back onto the hangout, Internet access is very flaky | 10:14 |
jam | axw: no problem, we'll just assign all the work to you :) | 10:15 |
axw | hah | 10:15 |
axw | I got on :) | 10:15 |
jam | axw: did you get the !dead stuff sorted out? | 10:17 |
jam | I managed to land the other changes for add-machine compatibility, but that is now the blocking point | 10:17 |
axw | jam: yes, there's a CL up | 10:18 |
axw | jam: it was pretty trivial, and there's a test now | 10:18 |
axw | jam: https://codereview.appspot.com/48670045/ | 10:19 |
jam | axw: why are you passing "Dying" to the $unset? | 10:23 |
axw | jam: the value is arbitrary, and ignored by $unset (but required, AFAIK) | 10:24 |
jam | axw: its a JSON object so it does need a value in the key: value context. | 10:24 |
axw | right, that makes sense | 10:24 |
axw | I suppose it could've been nil | 10:25 |
jam | axw: I'd prefer it be not something that looks like it might be a value, so "" or nil is fine | 10:29 |
jam | Dying made me wonder if it was only unsetting it if it was Dying, or etc | 10:29 |
axw | jam: no worries, will update before landing | 10:29 |
axw | yep, fair point | 10:29 |
mgz | gah, dammit | 10:56 |
jam | mgz: well there you are | 10:57 |
natefinch | rogpeppe: btw, the pastebin in the meeting - most of those are git failures. I was going to fix them this morning, since they obscure real failures for me | 10:59 |
rogpeppe | natefinch: cool, thanks | 11:00 |
jamespage | anyone fancy helping me with an odd juju/gccgo build issue? - https://launchpadlibrarian.net/162007788/buildlog_ubuntu-trusty-i386.juju-core_1.17.0-0ubuntu1~gccgo4_FAILEDTOBUILD.txt.gz | 12:58 |
jamespage | can't reproduce this outside of a launchpad builder which is awkward | 12:58 |
mgz | I shall look at it, and not be helpful am sure | 13:00 |
=== gary_poster|away is now known as gary_poster | ||
mgz | src/launchpad.net/juju-core/charm/config.go:14:32: error: $WORK/launchpad.net/juju-core/schema exists but does not contain any Go export data | 13:03 |
jam | jamespage: src/launchpad.net/goose/http/client.go:12:21: error: $WORK/launchpad.net/goose exists but does not contain any Go export data "launchpad.net/goose" | 13:03 |
jam | sounds like you have a stale build file | 13:03 |
jam | ? | 13:03 |
mgz | several modules | 13:03 |
jamespage | jam: maybe - but the errors jump around | 13:03 |
jamespage | so I suspect something toolish | 13:03 |
mgz | does feel ording related or something, if you diff with a local build log that worked, are the modules coming up in the same sequence? | 13:05 |
jamespage | mgz, broadley yes - I've tried a few things such as tweaking the -p flag - I think in a launchpad builder it default to -p 1 (single cpu) | 13:07 |
mgz | you might be at the email-dave point then | 13:08 |
jamespage | mgz, yeah - that's what I guess - I already pinged him | 13:08 |
jamespage | mgz, trying to pull together a package that supplies both gccgo and golang-go built binaries | 13:09 |
jamespage | well I have it locally | 13:09 |
=== BradCrittenden is now known as bac | ||
natefinch | rogpeppe: have you gotten a chance to look at the additions I made to replicaset? https://codereview.appspot.com/49290043 | 13:18 |
rogpeppe | natefinch: oops, perhaps i haven't published my comments | 13:19 |
rogpeppe | natefinch: one mo | 13:19 |
natefinch | rogpeppe: cool | 13:19 |
rogpeppe | natefinch: reviewed | 13:23 |
* rogpeppe goes for lunch | 14:37 | |
natefinch | arg, this kills me: // The Attempt and AttemptStrategy types are copied from those in launchpad.net/goamz/aws | 16:00 |
rogpeppe | mgz: there's a bit of confusion between hostname:port and hostname only in our code. i wonder if we should consistently name the former "Address" (fitting in with the "address" as passed to net.Dial) and the latter "HostName" | 16:43 |
rogpeppe | mgz: as it is, we've got net.Dial and now replicaset.Member.Address that hold a hostname:port combi, but instance.Address and state.Machine.PrivateAddress and others which hold host names only | 16:45 |
mgz | rogpeppe: that sounds sensible | 16:45 |
mgz | well, isn't there a better term... | 16:46 |
* mgz goes to look at rfcs | 16:46 | |
rogpeppe | mgz: quite possibly | 16:46 |
rogpeppe | mgz: net.Dial calls it "host" | 16:47 |
mgz | 'authority' would be correct for the combo | 16:47 |
mgz | [ userinfo "@" ] host [ ":" port ] | 16:47 |
rogpeppe | mgz: maybe somehow "instance.HostName" seems a better fit than "instance.Host" to me though | 16:47 |
rogpeppe | mgz: i think we should go with the Go convention of "address" for host:port | 16:48 |
rogpeppe | mgz: it's used all over the place, and we can't change that in the Go tree | 16:49 |
mgz | host is ipvX / ipv6 / ipv4 / reg-name | 16:49 |
rogpeppe | mgz: alternatively we could use "HostPort" | 16:49 |
rogpeppe | mgz: yeah | 16:49 |
mgz | so, "registered name" where we explicitly mean not a ip address | 16:50 |
mgz | I quite like hostport | 16:50 |
rogpeppe | mgz: hostport is also used in go stdlib too, e.g. http://golang.org/pkg/net/#JoinHostPort | 16:51 |
mgz | (looking at rfc 3986 btw, there have been several url ones that somewhat update each time) | 16:51 |
rogpeppe | mgz: but it's not so widespread | 16:51 |
rogpeppe | mgz: maybe we *should* consistently use Host and HostPort throughout | 16:52 |
rogpeppe | mgz: it mirrors the string concatenation nicely | 16:52 |
mgz | that sounds like a plan | 16:53 |
rogpeppe | mgz: and instance.Host could grow on me, i think | 16:53 |
rogpeppe | mgz: thanks | 16:53 |
rogpeppe | mgz: i'll file a bug, and conform to that convention in new code | 16:53 |
rogpeppe | https://bugs.launchpad.net/juju-core/+bug/1267541 | 16:56 |
_mup_ | Bug #1267541: The name "Address" is used inconsistently <juju-core:New> <https://launchpad.net/bugs/1267541> | 16:56 |
rogpeppe | mgz: the only problem with "host" is that it sounds like you're talking about the signified object, not the signifier. so "SelectInternalHost" sounds like it's looking for a particular host that happens to be internal, rather than looking for a host address that can be used internally. | 16:58 |
mgz | right, works less well compounded, hostport likewise | 17:00 |
rogpeppe | perhaps hostName (hostname?) and hostPort might be better | 17:02 |
mgz | dstroppa: you have review | 17:48 |
mgz | er... if codereview is actually up atm | 17:49 |
mgz | okay, now it's back and the post went through | 17:50 |
dstroppa | mgz: got that, thanks | 17:52 |
fwereade | arosales, cmars, mgz, mramm2, I apologize for my absence this afternoon, the whole island had a power cut :/ | 19:32 |
mramm2 | fwereade: no problem! | 19:32 |
mramm2 | randomly, friend of mine just messaged me a malta related video: https://www.youtube.com/watch?v=LXfVlCuWG6g | 19:33 |
arosales | fwereade, no worries, thanks for the fyi | 19:34 |
fwereade | mramm2, haha, I recognise that one :) | 19:34 |
cmars | fwereade, no prob, we'll resched | 19:35 |
fwereade | cmars, most of tomorrow is free for me I think | 19:36 |
fwereade | (a 132kV something-or-other tripped at the delimara power station... 132kV seems like quite enough voltage for me to forget the other details) | 19:37 |
thumper | 'ello | 19:48 |
* thumper looks at the modest proposal email thread and gives it a miss | 19:48 | |
* thumper looks at the juju run work and tries to split it up into three chunks for review | 19:59 | |
thumper | also realised I missed some tests... | 19:59 |
thumper | although in the last pipe | 20:00 |
* thumper gets to work | 20:00 | |
* thumper things of music, perhaps dubstep | 20:00 | |
jcastro | thumper, ok, I am just going to use the vagrant image for everything | 20:13 |
thumper | :) | 20:14 |
jcastro | I don't understand why juju needs to put stuff all over the disk | 20:14 |
jcastro | the minute something goes wrong the entire installation is worthless | 20:14 |
thumper | jcastro: there are reasons... | 20:18 |
thumper | perhaps we can discuss over a beer sometime | 20:18 |
jcastro | sure | 20:18 |
jcastro | maybe we should just tell people to always use vagrant? | 20:19 |
jcastro | I've had to reinstall twice this cycle already. :-/ | 20:19 |
thumper | ?! | 20:19 |
thumper | really? | 20:19 |
thumper | that seems real screwy | 20:19 |
jcastro | well, you couldn't fix it the first time | 20:19 |
natefinch | thumper: what does git --version return for you? I'm trying to figure out some of the tests that fail due to a newer version of git | 20:48 |
thumper | natefinch: $ git --version | 20:48 |
thumper | git version 1.8.3.2 | 20:48 |
natefinch | thumper: and I presume uniter tests pass for you? specifically the tests in worker/uniter/charm ? | 20:49 |
thumper | natefinch: yep, all passing | 20:49 |
thumper | just ran them :) | 20:49 |
natefinch | thumper: cool | 20:49 |
thumper | busy breaking things up for review | 20:49 |
natefinch | thumper: they're broken with git 1.8.5 for whatever reason... one fix was easy, the other... well, I'm not sure yet | 20:49 |
thumper | ack | 20:50 |
natefinch | thumper: ahh, I see it. "git add -A ." used to be a NOOP if there were no files to add.... now in 1.8.5 it errors out saying "no files match filespec '.'" | 21:23 |
thumper | ha | 21:23 |
natefinch | it bugs me that "apt-get upgrade foo" does not work the way "apt-get install foo" or "apt-get remove foo" works. Inconsistent UI is aggravating | 21:28 |
thumper | :) | 21:34 |
thumper | you have seen git koans right? | 21:35 |
natefinch | thumper: sounds familiar | 21:46 |
* thumper needs another coffee, and some food | 21:49 | |
mramm2 | thumper: how are you on the networking stuff? | 22:04 |
mramm2 | looks like MaaS folks have scheduled an emergency huddle in 25 min | 22:05 |
thumper | mramm2: not too hot, but I'm good at bluffing | 22:05 |
bigjools | o/ mramm2 | 22:05 |
mramm2 | ;) | 22:05 |
thumper | bugger, games up | 22:05 |
bigjools | I talked to thumper before xmas | 22:05 |
bigjools | you were useless :) | 22:05 |
mramm2 | kapil is the best to talk to | 22:06 |
mramm2 | he wrote most of the existing network sketch | 22:06 |
thumper | I'll come along to throw comments from the sideline | 22:06 |
mramm2 | but... he is in london at a sprint this week | 22:06 |
thumper | not sure how much help I'll be | 22:06 |
bigjools | yeah he was a "tentative" on the invite | 22:06 |
* bigjools in another call until :30 | 22:06 | |
mramm2 | thumper: bigjools: I have a candidate who would like to talk to me in 30 min | 22:12 |
thumper | bwahaha | 22:12 |
mramm2 | do you think I can duck out after the first few min of our call? | 22:12 |
bigjools | thanks mramm2 | 22:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!