| === duflu_ is now known as duflu | ||
| mzanetti | Saviq: o/ | 08:26 |
|---|---|---|
| mzanetti | https://code.launchpad.net/~mzanetti/unity8/tests-qml-in-cmake/+merge/200872 | 08:26 |
| Saviq | mzanetti, yup, saw that | 08:26 |
| Saviq | mzanetti, there's images in there, too, shall we go for /tests/qmltests/* as well? | 08:27 |
| Saviq | mzanetti, or explicit .png, .svg, .sci? | 08:28 |
| Saviq | Mirv, just tried to build unity-api i386 in a local sbuild with the latest qtdeclarative - it worked fine, so thumbs up! | 08:41 |
| Saviq | mzanetti, could you look at https://code.launchpad.net/~unity-team/unity8/new-scopes-horizontal-card-layout/+merge/200910 - I've put too much of my hands into that for a clean-conscience review ;) | 08:44 |
| mzanetti | Saviq: ack | 08:44 |
| mzanetti | Saviq: updated the other one btw | 08:45 |
| Saviq | mzanetti, cheers | 08:45 |
| mzanetti | Saviq: I went for * to be in line with the qml dir | 08:45 |
| Saviq | mzanetti, uh oh I don't think that's gonna work | 08:45 |
| Saviq | mzanetti, you just added all the mocks' .h and .cpp to the unity8 executable | 08:45 |
| mzanetti | oh crap. you're right | 08:46 |
| Saviq | mzanetti, that's why I said tests/qmltests/*, but tests/*.qml, tests/*.js | 08:46 |
| mzanetti | yeah, makes sense | 08:47 |
| tsdgeos | ouch | 08:47 |
| tsdgeos | our ci is looking too red http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/ | 08:47 |
| Saviq | tsdgeos, indeed :/ | 08:47 |
| tsdgeos | too much autopilot failures it seems | 08:48 |
| tsdgeos | Saviq: that thing is conflicting, no? | 08:49 |
| Saviq | tsdgeos, "that thing"? | 08:49 |
| tsdgeos | Saviq: new-scopes-horizontal-card-layout | 08:50 |
| Saviq | tsdgeos, yeah just saw | 08:50 |
| Saviq | interesting | 08:50 |
| tsdgeos | Saviq: but i see the CI was from an old rev | 08:50 |
| tsdgeos | so the two new revs maybe fix it | 08:50 |
| Mirv | Saviq: yeah, unity-api seems good now! so it's a definite improvement, but gsettings-qt is still blocking progress from here (to eg. a point where Unity would need to be uninstalled when upgrading to Qt 5.2) | 08:50 |
| Saviq | tsdgeos, well, I manually launched ci for it, and it's not going into lp:unity8 directly but in the new-scopes branch | 08:50 |
| Saviq | tsdgeos, so that might be why | 08:50 |
| Saviq | Mirv, :/ | 08:51 |
| Mirv | Saviq: I needed to force Qt Declarative version number to 5.2.0 from 5.2.1, since otherwise CMake would error out on incompatible versions. I hope this system works. | 08:51 |
| tsdgeos | Mirv: gsettings-qt is failing even with "qtdeclarative stable branch"? | 08:51 |
| Mirv | tsdgeos: yes | 08:51 |
| tsdgeos | weird | 08:51 |
| tsdgeos | Mirv: what's the error? | 08:51 |
| tsdgeos | still that xvfb thing? | 08:51 |
| Mirv | tsdgeos: still that. bug #1259145 | 08:52 |
| ubot5 | bug 1259145 in gsettings-qt "gsettings-qt fails to build (run tests) against Qt 5.2" [Critical,Confirmed] https://launchpad.net/bugs/1259145 | 08:52 |
| Saviq | mzanetti, does qmluitests have lp:unity8 hardcoded somewhere? | 08:52 |
| Saviq | mzanetti, could it use target_branch instead? | 08:52 |
| Saviq | mzanetti, seems that's where the failure in https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/850/console comes from - it's merging lp:unity8 into it instead of the new-scopes branch | 08:53 |
| tsdgeos | Mirv: maybe indeed it's the "can't access X" thing and not the problem with qqmlpropertymap that is causing that, tests pass locally here in my machine | 08:53 |
| tsdgeos | but indeed i do have X around | 08:54 |
| tsdgeos | :D | 08:54 |
| Mirv | the builders don't have, although they should have xvfb (but no 3d acceleration) - like I mention in the bug report, I have a vague memory SDK team battled with something similar in ubuntu-ui-toolkit | 08:55 |
| tsdgeos | for 5.2? or in the beginning? | 08:56 |
| tsdgeos | i mean why would have this changed in 5.2? | 08:56 |
| tsdgeos | besides because "everything broke" :D | 08:56 |
| Mirv | tsdgeos: around 5.2, like when they were testing building against RC1 | 08:57 |
| tsdgeos | i see | 08:58 |
| tsdgeos | then it may very well be yeah | 08:58 |
| mzanetti | Saviq: fixed | 08:59 |
| mzanetti | ci, that is ^^ | 08:59 |
| tsdgeos | Mirv: can you test this patch? http://paste.ubuntu.com/6719664/ | 09:02 |
| tsdgeos | Mirv: or you prefer me to get it into gsettings-qt ? | 09:03 |
| tsdgeos | Mirv: i can reproduce the error if no X is avaiable here and this patch fixes it | 09:03 |
| tsdgeos | larsu: ↑↑↑↑ ? | 09:03 |
| Mirv | tsdgeos: that would make sense, since the QA team adding tests into Qt modules is using QT_QPA_PLATFORM=minimal as well | 09:04 |
| Mirv | I can test in a PPA | 09:04 |
| larsu | tsdgeos: sounds sane to me | 09:04 |
| tsdgeos | larsu: Mirv: so want me to propose the merge first or first check the patch in a ppa quick? | 09:05 |
| Saviq | mzanetti, thanks | 09:06 |
| larsu | tsdgeos, Mirv: I don't care. This looks like a good idea in any case so feel free to propose the merge | 09:07 |
| Saviq | chain reaction of cats scaring themselves and each other... plus hardfloors... priceless | 09:08 |
| Mirv | tsdgeos: building now https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily/+sourcepub/3808316/+listing-archive-extra | 09:08 |
| Mirv | seems good now | 09:12 |
| tsdgeos | \o/ | 09:13 |
| tsdgeos | larsu: Mirv: https://code.launchpad.net/~aacid/gsettings-qt/use_minimal_qpa_for_test/+merge/200971 | 09:15 |
| tsdgeos | can anyone remind me how i run autopilot manually in a unity8 builddir? | 09:15 |
| tsdgeos | Saviq: mzanetti: ↑↑ | 09:18 |
| Saviq | nope | 09:19 |
| mzanetti | now he's gone | 09:19 |
| tsdgeos | oh man, running autopilot killed my X :-S | 09:21 |
| tsdgeos | if i disappear again | 09:21 |
| tsdgeos | you know why | 09:22 |
| tsdgeos | i'm doing something very wrong or we don't support running the tests on the desktop? | 09:25 |
| tsdgeos | Ran 52 tests in 112.281s | 09:25 |
| tsdgeos | FAILED (failures=46) | 09:25 |
| tsdgeos | Saviq: your input needed at https://bugs.launchpad.net/unity8/+bug/1267135 | 09:27 |
| ubot5 | Ubuntu bug 1267135 in Network Menu "network-indicator should provide the "Please enter SIM PIN" text" [Undecided,Incomplete] | 09:27 |
| Saviq | tsdgeos, done | 09:32 |
| Saviq | tsdgeos, you need to make -C builddir install first | 09:33 |
| tsdgeos | Saviq: hmmmmmm, looking at the text it may not even be "correct" | 09:33 |
| Saviq | tsdgeos, and then PYTHONPATH=tests/autopilot autopilot list unity8 | 09:33 |
| tsdgeos | or maybe it is | 09:33 |
| Saviq | tsdgeos, sure, but that's orthogonal to the fact that unity8 should have no knowledge of those strings | 09:33 |
| Saviq | tsdgeos, that will list you the tests, s/list/run/ will run them | 09:34 |
| tsdgeos | agreed | 09:34 |
| tsdgeos | just saying that maybe is just some placeholder | 09:34 |
| tsdgeos | ok, let me see | 09:34 |
| tsdgeos | see about the autopilot, not about the text :D | 09:35 |
| tsdgeos | Saviq: i guess we should document that PYTHONPATH stuff somewhere | 09:36 |
| tsdgeos | i'll forget to the next time :D | 09:36 |
| Saviq | tsdgeos, you should do more python, you won't forget then ;) | 09:38 |
| tsdgeos | oh no | 09:44 |
| tsdgeos | i know about PYTHONPATH | 09:44 |
| tsdgeos | it's just about the whole lot | 09:44 |
| tsdgeos | of installing | 09:44 |
| tsdgeos | and bla bla | 09:44 |
| tsdgeos | larsu: Mirv: top-approve? https://code.launchpad.net/~aacid/gsettings-qt/use_minimal_qpa_for_test/+merge/200971 | 09:50 |
| larsu | tsdgeos: ah sorry. Done. | 09:51 |
| Cimi | seb128, https://code.launchpad.net/~unity-team/ubuntu-system-settings/welcome-wizard/+merge/186862 :) | 09:51 |
| Mirv | yeah I thought to give the top-approve honor to lar_su | 09:51 |
| seb128 | Cimi, it's on my list, quite some backlog after holidays | 09:51 |
| Cimi | seb128, good it's on your list | 09:52 |
| Cimi | seb128, let me know when you're planning to review it | 09:52 |
| seb128 | Cimi, and we had to spend time fixing ubuntu-themes issues, since you don't do it, which means less cycles for reviews... | 09:52 |
| Cimi | seb128, in case I'll branch and propose something dependent on it | 09:52 |
| seb128 | Cimi, if you were doing your job I could be reviewing that... | 09:52 |
| Cimi | seb128, I am doing my job | 09:52 |
| larsu | Mirv: thanks :) I feel honored! | 09:52 |
| seb128 | Cimi, the theme bug larsu fixed yesterday were assigned to you since novembre and you didn't act on them | 09:53 |
| Cimi | seb128, because we have other priorities | 09:53 |
| Cimi | it's not the only bug I have assigned and I didn't act yet | 09:54 |
| seb128 | k | 09:54 |
| seb128 | well, anyway, the wizard in on my todolist | 09:54 |
| seb128 | I'm going to try to get to it today | 09:54 |
| Cimi | seb128, good!! | 09:54 |
| Cimi | seb128, I'll work on add the wifi page correctly | 09:54 |
| seb128 | great | 09:55 |
| Cimi | seb128, btw | 09:55 |
| Cimi | seb128, I saw marco's work on the css decorations | 09:55 |
| Cimi | seb128, it looks really cool and no more aliased corners :) | 09:55 |
| Cimi | seb128, he stayed at mine for the new years eve | 09:55 |
| Cimi | and was working on that! | 09:56 |
| seb128 | you crazy Italians ;-) | 09:56 |
| tsdgeos | Saviq: https://code.launchpad.net/~aacid/unity8/coding_autopilot_docu/+merge/200974 ? | 09:59 |
| Saviq | tsdgeos, we also have a "make -C builddir autopilot" target, could you check out whether it works - and if not - see why? | 10:06 |
| tsdgeos | sure | 10:07 |
| tsdgeos | Saviq: nah, nope working | 10:11 |
| tsdgeos | checking why | 10:11 |
| tsdgeos | funny thing is that with ninja it works | 10:25 |
| tsdgeos | Saviq: bascially it seems "it can't be done" | 10:34 |
| tsdgeos | install is not a target you can depend on in cmake | 10:35 |
| tsdgeos | if you're using make | 10:35 |
| tsdgeos | for some reason | 10:35 |
| Saviq | tsdgeos, we can have a custom target that will run cmake --build --target install, though | 10:35 |
| Saviq | tsdgeos, a custom command or whatnot | 10:36 |
| tsdgeos | hmmm | 10:36 |
| tsdgeos | let me see | 10:36 |
| Saviq | tsdgeos, or actually make the autopilot target do that | 10:36 |
| Saviq | tsdgeos, otherwise it wouldn't be called every time | 10:36 |
| tsdgeos | yeah that'd work | 10:38 |
| tsdgeos | or should :D | 10:38 |
| tsdgeos | Saviq: updated https://code.launchpad.net/~aacid/unity8/coding_autopilot_docu/+merge/200974 | 11:00 |
| === davmor2_ is now known as davmor2 | ||
| tsdgeos | and another one | 11:23 |
| tsdgeos | https://code.launchpad.net/~aacid/unity8/timeformattertest_LCALL_C/+merge/200991 | 11:23 |
| === _salem is now known as salem_ | ||
| Mirv | greyback: can you get a manager add platform-api to Landing Asks in case https://code.launchpad.net/~ricmm/platform-api/set-dimensions/+merge/198490 is meant to go in? (landed after platform-api was released yesterday) | 11:42 |
| Mirv | ricardo mentioned that commit so in case it's useful to have it fast it's better to add it already to the list | 11:43 |
| greyback | Mirv: ok. kgunn ^^ | 11:44 |
| === pete-woods is now known as pete-woods|fight | ||
| === pete-woods|fight is now known as pete-woods|away | ||
| tsdgeos | Saviq: so was thinking about the organic positioner and how it's supposed to get bigger as the width increases and until two modules fit in the width | 12:34 |
| Saviq | tsdgeos, again, I don't think it's your concern | 12:35 |
| Saviq | tsdgeos, I think a QML wrapper will do that | 12:35 |
| tsdgeos | Saviq: and was wondering if we can just do that in the QML side and on the C++ side we just have size and spacing | 12:35 |
| tsdgeos | and someone cares about making it match | 12:35 |
| tsdgeos | ok, same thought then | 12:35 |
| Saviq | tsdgeos, yeah, justs have a prop "moduleSize" or so | 12:35 |
| Saviq | or width | 12:35 |
| Saviq | and spacing, exactly | 12:35 |
| Saviq | tsdgeos, same spacing between items as well as between modules, right? | 12:36 |
| tsdgeos | Saviq: i was thinkin on having spacing (for in between delagates) and then smallSize and bigSize properties | 12:36 |
| tsdgeos | and with that i can calculate everything and see if i can have one or more modules per row | 12:36 |
| Saviq | tsdgeos, ok, that's maybe even better | 12:36 |
| Saviq | it's not as if it's going to be difficult to calculate | 12:37 |
| Saviq | tsdgeos, +q | 12:37 |
| Saviq | +1 even | 12:37 |
| tsdgeos | D: | 12:37 |
| === Trevinho_ is now known as Trevinho | ||
| === pete-woods|away is now known as pete-woods | ||
| === zequence_ is now known as zequence | ||
| === alan_g is now known as alan_g|lunch | ||
| Saviq | tsdgeos, https://code.launchpad.net/~allanlesage/unity8/autopilot-indicator-page-title-matches-widget/+merge/196991/comments/467382 | 13:25 |
| === dandrader is now known as dandrader|afk | ||
| Saviq | Wellark_, bug-chat seems to have problems ;) | 13:40 |
| Saviq | Wellark_, the SIM PIN *dialog* is part of unity8 | 13:40 |
| Saviq | already | 13:40 |
| Saviq | Wellark_, and the UI is displayed as the screenshots show (they're screenshot from a real phone) | 13:40 |
| Saviq | Wellark_, the only thing is the string, which is now hardcoded in unity8, but should be provided by whoever requests that dialog (most probably indicator-network) | 13:41 |
| Saviq | Wellark_, is that somewhat more clear? | 13:41 |
| Wellark_ | Saviq: yes, I got that it's already part of unity8 | 13:41 |
| Wellark_ | I'm just trying to figure out what you want changed :) | 13:41 |
| Wellark_ | and if it's just the hardcoded string | 13:41 |
| Wellark_ | then fine :) | 13:41 |
| Saviq | Wellark_, yes, only that - which means changes in unity8, unity-notifications potentially, and indicator-network | 13:42 |
| Wellark_ | Saviq: yeah. the dialog needs a dbus interface also | 13:42 |
| Wellark_ | so that indicator-network can update the values and provide the modem state | 13:42 |
| Saviq | Wellark_, it already does - it really really actually works already ;) | 13:42 |
| Wellark_ | I'm skeptical ;) | 13:42 |
| Saviq | Wellark_, over a snap decision + UnityMenuModel | 13:42 |
| Saviq | so "extended snap decision" | 13:43 |
| Wellark_ | Saviq: ok. I'm working on the connectivity api atm, until the end of next week | 13:43 |
| Wellark_ | then it's 100% for indicator-network for me | 13:44 |
| Wellark_ | Saviq: how much in a hurry are you with this? | 13:44 |
| Saviq | Wellark_, not at all ;) | 13:44 |
| Saviq | dednick, http://ddebs.ubuntu.com/pool/main/m/mir/ btw :/ | 13:44 |
| dednick | Saviq: thanks | 13:45 |
| Wellark_ | Saviq: ok. let's leave the bug open then and make the hardcoded string dissapear in near future | 13:45 |
| Saviq | Wellark_, +1, that's all I needed :) | 13:45 |
| Saviq | dednick, apparently index generation didn't catch up yet | 13:45 |
| kgunn | greyback: about to run the boy up to school....so i assume you want that papi mp ? | 13:50 |
| greyback | kgunn: yes, that and https://code.launchpad.net/~ricmm/qtubuntu/papi-setdimensions/+merge/198498 | 13:50 |
| === dandrader|afk is now known as dandrader | ||
| kgunn | greyback: thanks...sidestage i assume | 13:55 |
| Saviq | tsdgeos, re: open_scope tests... if you look at https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1871/artifact/results/autopilot/artifacts/unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_urgency_order%20%28Desktop%20Nexus%204%29.ogv - it looks like the test is interrupted somehow | 13:55 |
| greyback | kgunn: yep | 13:55 |
| Saviq | tsdgeos, apparently we don't get unity8.log there unfortunately | 13:56 |
| tsdgeos | oh :/ | 13:56 |
| tsdgeos | yeah it looks like it ends "too early" | 13:56 |
| Saviq | tsdgeos, I've seen that a few times already, no idea where it comes from | 13:57 |
| kgunn | greyback: before i top approve...any idea why that qtubuntu ci has failed so many times? | 13:58 |
| Saviq | fginther, does testrunner-otto collect .crash files? and could it collect unity8.log from .cache/upstart/? | 13:58 |
| Saviq | fginther, we have trouble understanding / reproducing https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1871/ :/ | 13:58 |
| greyback | kgunn: it depends on that papi change to land first. | 13:58 |
| kgunn | greyback: thank you sir | 13:58 |
| fginther | Saviq, I'll check on that, if it's not collecting them, it should be easy to add them | 13:59 |
| kgunn | Mirv: ok...added "set dimension" support mp's to landing ask for papi & qtubuntu | 14:00 |
| tsdgeos | Mirv: https://code.launchpad.net/~aacid/qml-friends/use_minimal_qpa_for_test/+merge/201009 same trick worked | 14:12 |
| Saviq | woohoo, stuff is looking greener in qt5-beta2 | 14:14 |
| === alan_g|lunch is now known as alan_g | ||
| Saviq | mzanetti, re: new-scopes-horizontal | 14:18 |
| Saviq | mzanetti, you sure the tests pass regardless? do you have an explanation? | 14:19 |
| mzanetti | Saviq: probably that function() in data() doesn't work | 14:19 |
| Saviq | mzanetti, it doesn't have to "work" and well, why wouldn't it? | 14:19 |
| mzanetti | Saviq: I tried to just removing the functions in there for consistency and noticed the tests were failing | 14:19 |
| Saviq | mzanetti, the reason for using a lambda there is that the values used to compute change in _test() when the selectedIndex is changed | 14:19 |
| mzanetti | then I reverted and made the functions return bullshit | 14:20 |
| mzanetti | still passing | 14:20 |
| Saviq | mzanetti, humm | 14:20 |
| Saviq | mzanetti, interesting, me checks | 14:20 |
| Saviq | karni, ↑ | 14:20 |
| mzanetti | Saviq: I'm quite sure you can achieve the same without lambdas | 14:20 |
| * greyback thinks it would be nice if unity8 binary could let you specify a custom directory to load the qml from | 14:21 | |
| * karni reads | 14:21 | |
| Saviq | mzanetti, I'm all ears | 14:21 |
| mzanetti | heh | 14:21 |
| mzanetti | ok. need to try then. but so far I haven't come across a situation where I would have needed this | 14:21 |
| karni | mzanetti: Saviq: I still wanted to revert the changes and make sure tests would fail, was late yesterday. I'm happy to get on this now, I should have left a comment. | 14:22 |
| mzanetti | Saviq: esp. things like "return 0". why a lambda? | 14:22 |
| Saviq | mzanetti, that was just so that I don't have to do the "if typeof === "function"" | 14:23 |
| mzanetti | Saviq: you can define a property int expectedHeaderPos: art.x + art.width | 14:24 |
| Saviq | mzanetti, the situation here is simple: the index: part of the data actually changes the layout | 14:24 |
| mzanetti | and then just refer to that property in the data | 14:24 |
| mzanetti | or something like that | 14:24 |
| Saviq | mzanetti, nope, that won't work, 'cause it would get the value in _data() | 14:24 |
| Saviq | mzanetti, well, you'd need to refer to it by name, not | 14:24 |
| Saviq | value | 14:24 |
| karni | Like Saviq said, first line setting the selector index changes layout. | 14:24 |
| Saviq | mzanetti, so not a nicer solution that the lambda IMO | 14:25 |
| Saviq | but /me needs to look | 14:25 |
| mzanetti | no... not really nicer... | 14:25 |
| mzanetti | anyways... either lambdas in there don't work at all or there is some other mistake | 14:25 |
| * karni is looking into it | 14:26 | |
| === rachelliu_ is now known as rachelliu | ||
| karni | FTR changing the return 0 to return anything else makes the test fail. | 14:26 |
| * karni looks at another lambda | 14:27 | |
| Saviq | mzanetti, changed the tests, FAIL | 14:27 |
| mzanetti | I tried this in line 291: | 14:27 |
| mzanetti | { tag: "Horizontal", left: function() { return art.width * 2 }, index: 5 } | 14:27 |
| mzanetti | note the *2 | 14:27 |
| mzanetti | still passing | 14:27 |
| karni | mzanetti: that makes it fail | 14:27 |
| mzanetti | dafuq | 14:27 |
| * mzanetti tries again | 14:27 | |
| Saviq | mzanetti, line 291? | 14:28 |
| mzanetti | what the heck is going on | 14:28 |
| mzanetti | it fails somethimes here | 14:28 |
| mzanetti | Saviq: in tst_Card.qml | 14:28 |
| Saviq | mzanetti, right, I merged it on top of new-scopes | 14:28 |
| mzanetti | yep. now it passed again _with_ the *2 | 14:29 |
| Saviq | karni, can you please do merge lp:~unity-team/unity8/new-scopes | 14:29 |
| mzanetti | but sometimes it fails indeed | 14:29 |
| karni | Saviq: into that MP branch? sure | 14:29 |
| mzanetti | hmm... maybe the tryCompare stops by the value with *2 too | 14:29 |
| Saviq | mzanetti, indeed it does | 14:29 |
| Saviq | mzanetti, right, tryCompareFunction then... | 14:30 |
| karni | Saviq: done | 14:30 |
| Saviq | karni, thanks | 14:30 |
| karni | anytime | 14:30 |
| Saviq | mzanetti, chicken'n'egg problem here, really... | 14:31 |
| mzanetti | yeah... guess so | 14:31 |
| Saviq | mzanetti, so the other possibility is to just use hardcoded units.gu() values if you think it better | 14:31 |
| Saviq | I didn't want to do that | 14:31 |
| mzanetti | hmm... dunno | 14:32 |
| karni | Saviq: that would be then specific to a particular card-size, right? | 14:32 |
| karni | if we wanted to hardcode these values. | 14:32 |
| Saviq | mzanetti, hmm now it reliably fails | 14:32 |
| Saviq | mzanetti, pull please | 14:32 |
| mzanetti | I guess now that we know the lambdas are working and the issue was another one I guess I'm fine with it | 14:33 |
| Saviq | mzanetti, well, the fact that it's a chicken'n'egg problem is still an issue | 14:33 |
| greyback | Saviq: mzanetti standup | 14:33 |
| greyback | quit talking about food and get back to work | 14:33 |
| karni | haha | 14:33 |
| Saviq | karni, wanna join? | 14:34 |
| Saviq | karni, Standup on Canonical mumble | 14:34 |
| karni | Saviq: hangout? oh, lemme see quickly if I have it set up | 14:34 |
| karni | sure | 14:34 |
| karni | been a while I used mumble | 14:34 |
| karni | which room would that be? | 14:35 |
| karni | hrm.. mumble just hung | 14:35 |
| Saviq | karni, kill, start again ;) | 14:35 |
| * karni does just that, another hang. gives it a sec. | 14:35 | |
| Saviq | karni, try again ;) | 14:36 |
| karni | there :) | 14:37 |
| mzanetti | greyback: I'm worried that we'll never ever get our stuff merged again | 14:42 |
| greyback | mzanetti: "we" as in you? :) | 14:43 |
| mzanetti | thanks | 14:43 |
| mzanetti | :P | 14:43 |
| greyback | mzanetti: I'm only making the tiniest changes here and there, nothing major at all | 14:43 |
| greyback | mzanetti: I'm keeping eye on your branch | 14:43 |
| mzanetti | greyback: ah, that sounds good :) | 14:44 |
| mzanetti | greyback: are you mostly working in unity-mir or unity8 (aka. ApplicationManagerWrapper)? | 14:44 |
| Saviq | mzanetti, so, what I meant was... if the target value is moving ('cause it depends on the layout) and the tested value is moving, they might "meet" and pass somewhere in the middle... | 14:46 |
| Saviq | mzanetti, although in this case there's no animation, so that should be fine, but still... | 14:46 |
| greyback | mzanetti: yep, most LOC changed are not in unity8 at all. | 14:46 |
| greyback | mzanetti: how close would your work be to landing? | 14:46 |
| mzanetti | greyback: ah ok... my changes in unity-mir are rather small | 14:46 |
| mzanetti | greyback: unfortunately rather far away | 14:47 |
| mzanetti | greyback: I don't think I should still re-implement the old school side stage in my branch | 14:47 |
| mzanetti | greyback: and I don't have a design for the new one yet | 14:47 |
| mzanetti | greyback: the phone stuff is getting closer tho, but our no-breakage policy wouldn't allow it to land without implementing the tablet stage too first | 14:48 |
| greyback | mzanetti: ok. Then I'll be making a couple of minor tweaks to shell.qml and stage.qml probably, that might cause you pain | 14:48 |
| mzanetti | greyback: I've deleted stage.qml in my branch | 14:48 |
| greyback | minor tweaks = 2-3 lines of code changes | 14:48 |
| greyback | mzanetti: yep, so it's only shell.qml really we need to be careful about I think | 14:49 |
| mzanetti | yeah. sounds ok | 14:49 |
| mzanetti | cool | 14:49 |
| greyback | yep | 14:49 |
| mzanetti | Saviq: hmm... I'm sure you'll figure a solution :P | 14:49 |
| * mzanetti prepares for the design meeting | 14:49 | |
| Saviq | mzanetti, just using you as a sounding board ;P | 14:49 |
| mzanetti | do I? | 14:49 |
| mzanetti | oh... read wrong.. | 14:50 |
| mzanetti | got it | 14:50 |
| mzanetti | brain FEC is scary sometimes... I read "..as you are sounding bored" | 14:51 |
| Saviq | ;D | 14:52 |
| Saviq | tsdgeos, what was the _BAD_RENDER_LOOP thing again? | 14:53 |
| tsdgeos | Saviq: you mean the full name? | 14:54 |
| Saviq | tsdgeos, yeah | 14:54 |
| tsdgeos | QML_BAD_GUI_RENDER_LOOP | 14:54 |
| Saviq | tsdgeos, is it somewhere on doc.qt-project btw? | 14:54 |
| tsdgeos | not sure | 14:54 |
| tsdgeos | i just grepped the sources :D | 14:54 |
| Saviq | tsdgeos, as in that, the RENDER_TIMING one... I always seem to forget them | 14:54 |
| Saviq | tsdgeos, yeah ;) | 14:55 |
| Saviq | karni, you might want to export ↑↑ =1 after having shelved qml/ changes | 14:56 |
| Saviq | karni, otherwise qmltestrunner crashes for me her | 14:56 |
| Saviq | e | 14:56 |
| * karni notes | 14:56 | |
| karni | writing an e-mail for a person Alex might be hiring, I'll get my hands on the shelving part real soon. | 14:56 |
| === dandrader is now known as dandrader|lunch | ||
| Saviq | karni, but yeah, http://paste.ubuntu.com/6721162/ adds some robustness to the tests | 15:04 |
| Saviq | tsdgeos, check this out http://paste.ubuntu.com/6721167/ | 15:06 |
| Saviq | uh oh 5.2? | 15:06 |
| Saviq | I'm not on 5.2, WTH? | 15:06 |
| tsdgeos | that's a crash? | 15:07 |
| Saviq | tsdgeos, yeah | 15:07 |
| Saviq | tsdgeos, but the retrace seems bogus | 15:07 |
| tsdgeos | :D | 15:07 |
| Saviq | tsdgeos, somehow the retracer decided to pick up qt5.2 instead of the one I had installed... | 15:08 |
| tsdgeos | bad retracer bad! | 15:11 |
| Saviq | tsdgeos, indeed, apparently it always picks up latest packages (I had the 5.2 PPA enabled for the retracer - a thing to remember) | 15:14 |
| Saviq | tsdgeos, http://paste.ubuntu.com/6721216/ | 15:14 |
| Saviq | tsdgeos, less scary, and solved by BAD_RENDER | 15:14 |
| tsdgeos | Saviq: may even be a problem of UCFontUtils::sizeToPixels ? | 15:15 |
| tsdgeos | not being thread-safe/reentrant/whatever? | 15:15 |
| Saviq | tsdgeos, true | 15:21 |
| * Saviq files a bug just in case | 15:21 | |
| * karni gets to those tests | 15:22 | |
| Saviq | tsdgeos, and now for something completely different! the launchpad retracer decided it's nothing relevant to the UCFont... but the Shape instead... https://launchpadlibrarian.net/162021731/Stacktrace.txt | 15:45 |
| tsdgeos | that is weird :S | 15:45 |
| elopio | tsdgeos: thanks for the review. | 15:46 |
| elopio | I've been trying to reproduce the mako errors since yesterday, and I have finally done it. It only fails when I run the whole suite, it seems one test fails to swipe the greeter, then the screen will go blank and all the following tests will fail too :/ | 15:46 |
| tsdgeos | elopio: no worries | 15:46 |
| tsdgeos | ouch | 15:46 |
| tsdgeos | Saviq: is that the bug you mentioned ↑↑↑ in the other autopilot merge request? | 15:46 |
| tsdgeos | what, i'm running on battery¿? | 15:47 |
| tsdgeos | not anymore | 15:47 |
| === alan_g is now known as alan_g|tea | ||
| Saviq | tsdgeos, no, something that happened locally | 15:47 |
| tsdgeos | ok | 15:48 |
| karni | Saviq: I have standup in 3 minutes, but I'll try to be first, and join you guys asap. The meeting you scheduled is in a moment, right? | 15:57 |
| Saviq | karni, we just moved it to tomorrow | 16:00 |
| Saviq | karni, 10am UTC | 16:00 |
| Saviq | karni, katie couldn't make i | 16:00 |
| Saviq | t | 16:00 |
| karni | Saviq: perfect, thanks :) | 16:00 |
| === greyback is now known as greyback|away | ||
| === alan_g|tea is now known as alan_g | ||
| elopio | tsdgeos: can we prevent the screen to go blank in these tests? | 16:11 |
| tsdgeos | elopio: sure | 16:11 |
| tsdgeos | i mean | 16:11 |
| tsdgeos | well there's a command line call that makes it not go blank | 16:11 |
| tsdgeos | you should be using it | 16:11 |
| tsdgeos | which i don't remember | 16:12 |
| tsdgeos | powerd-cli | 16:12 |
| tsdgeos | and some argument | 16:12 |
| tsdgeos | powerd-cli display on | 16:12 |
| tsdgeos | elopio: ↑ | 16:12 |
| elopio | tsdgeos: thanks, that will help a little. | 16:13 |
| dednick | Saviq: why did we drop the qmlproject? | 16:27 |
| Saviq | dednick, to not have two separate projects in qtcreator | 16:28 |
| Saviq | dednick, they are part of the CMake project now | 16:28 |
| Saviq | dednick, although mzanetti's still fixing a few issues with that | 16:28 |
| mzanetti | branch updated btw | 16:28 |
| Saviq | dednick, you might need to right-click on the project → Run CMake to get them | 16:28 |
| mzanetti | Saviq: ^ | 16:28 |
| dednick | Saviq: how do I actually open the project? :) | 16:29 |
| kgunn | kdub: ^^ see tsdgeos | 16:29 |
| mzanetti | dednick: just open the cmakeLists.txt | 16:29 |
| kgunn | talking about the powerd issue above | 16:29 |
| mzanetti | the top level one | 16:29 |
| Saviq | mzanetti, no it's not https://code.launchpad.net/~mzanetti/unity8/tests-qml-in-cmake/+merge/200872 | 16:29 |
| Saviq | mzanetti, still includes all the .cpp .h files in the executable | 16:30 |
| mzanetti | hmm... seems I pushed to the wrong branch then | 16:30 |
| dednick | Saviq: ahh, didnt even know you could do that | 16:30 |
| Saviq | dednick, you couldn't ;) | 16:30 |
| Saviq | dednick, but mzanetti managed to | 16:30 |
| kdub | tsdgeos, i think that should work | 16:30 |
| dednick | yay. source files! | 16:30 |
| tsdgeos | kdub: yes it does | 16:30 |
| tsdgeos | kdub: wasn't complaining | 16:30 |
| tsdgeos | was just telling elopio | 16:30 |
| kdub | right :) | 16:30 |
| mzanetti | Saviq: pushed now | 16:32 |
| Saviq | mzanetti, ack | 16:32 |
| elopio | what I found is that when there are 6 tests left, the autopilot Touch stops working. | 16:32 |
| Saviq | mzanetti, hrm, in that case we can drop the special case for qmltests can't we | 16:33 |
| Saviq | mzanetti, ah wait | 16:33 |
| Saviq | mzanetti, ignore | 16:33 |
| Saviq | is good | 16:33 |
| mzanetti | tests/modules | 16:33 |
| mzanetti | UntiyTestCase.qml | 16:33 |
| kgunn | kdub: i was just pointing it out...b/c we really shouldn't need to be using powerd cli to get past it... | 16:34 |
| kgunn | related to https://bugs.launchpad.net/mir/+bug/1236525 | 16:34 |
| ubot5 | Ubuntu bug 1236525 in unity-mir "unity8 killed/crash then restart can result in mir unable "could not unblank display"" [Medium,Triaged] | 16:34 |
| kgunn | anyway...it'll be interesting to hear if you find this is now effecting mir ci as well | 16:35 |
| karni | Saviq: validated tests against your changes. test_art_size_data() with "Horizontal" tag would only verify that art.height == header.height (good, along the spec). But I can't make it fail, because we actually wanted to test anchors.horizontalCenter using x (and/or width), while width and height already well defined in the code. In other words, can't make the test fail for missing line 9 here, although the tests in lines 22,23 verify UI against ... | 16:49 |
| karni | ... spec. http://paste.ubuntu.com/6721694/ | 16:49 |
| karni | Saviq: pushed revno 575 to that MR, I got no further improvements. | 16:51 |
| karni | Saviq: just read the comment on MR regarding what we talked before about lambdas. let me try make em fail. | 16:52 |
| Saviq | karni, don't over-do :) | 16:53 |
| karni | Saviq: I mean, if it's seriously an issue, I should see where stuff fails. | 16:53 |
| Saviq | karni, I'm afraid I didn't follow your sentence above, but that might be EOD creeping up on me | 16:55 |
| fginther | Saviq, the otto jobs are already saving crash files if they exist (the build you specified didn't have any). I have a change ready to collect the unity8.log | 16:57 |
| fginther | Saviq, here's an example: http://s-jenkins.ubuntu-ci:8080/job/autopilot-testrunner-otto-trusty-fjg/3/ | 16:57 |
| Saviq | fginther, awesome, thanks! | 16:57 |
| ChrisTownsend | I have a question about the SoundCloud scope. I was supposedly deprecated by the Home Scope here: http://bazaar.launchpad.net/~unity-team/unity-scope-home/trunk/revision/146 | 17:00 |
| ChrisTownsend | I don't see how to get results from Soundcloud though. How do I get results from Soundcloud? | 17:00 |
| ChrisTownsend | mhr3: pstolowski: Perhaps you can answer my question above? ^^^^ | 17:01 |
| mhr3 | ChrisTownsend, "soundcloud:foo" in dash home | 17:02 |
| ChrisTownsend | oh, no automatic way via filter though, right? | 17:02 |
| mhr3 | no | 17:02 |
| pstolowski | ChrisTownsend, or by typing a query. and *then* selecting it from filters in home | 17:02 |
| ChrisTownsend | mhr3: Ok, thanks | 17:03 |
| mhr3 | ChrisTownsend, well, not sure what you meant by "automatic" | 17:03 |
| ChrisTownsend | pstolowski: Soundcloud is not listed as a filter though. | 17:03 |
| mhr3 | it is here | 17:03 |
| ChrisTownsend | mhr3: I get it if install unity-scope-onlinemusic from Universe. | 17:04 |
| === greyback|away is now known as greyback | ||
| ChrisTownsend | But I don't see it if I don't have that installed. | 17:04 |
| mhr3 | hmm, doesn't sound right | 17:04 |
| mhr3 | although i do have that installed | 17:05 |
| ChrisTownsend | mhr3: I didn't think that sounded right either. That's why I'm asking:) | 17:05 |
| ChrisTownsend | mhr3: However, Soundcloud:foo does work without the onlinemusic scope. | 17:06 |
| pstolowski | ChrisTownsend, yeah, onlinemusic has nothing to do with it, it was implemented specifically for the phone (although it works on the desktop of course) | 17:07 |
| ChrisTownsend | mhr3: Well, it this all back. I now see the filter. | 17:07 |
| ChrisTownsend | Why did I not see that before. | 17:07 |
| mhr3 | dee-tool -m "com.canonical.Unity.SmartScopes.RemoteScopesModel" | grep -q -i "soundcloud" && echo "It's there" || echo "Not there" | 17:08 |
| ChrisTownsend | mhr3: I ran that, got a dee-tool crash and it printed out Not there | 17:11 |
| ChrisTownsend | mhr3: Sorry, I entered something wrong. | 17:11 |
| ChrisTownsend | mhr3: It's there | 17:11 |
| mhr3 | then it is there :) | 17:12 |
| karni | mzanetti: FYI In each single lambda these new tests contain I added +1 in the return value. Each test would consistently fail. Considering your comment on the MR, does that mean we're good? | 17:12 |
| ChrisTownsend | mhr3: lol, yeah | 17:12 |
| * karni just pushed last revno | 17:12 | |
| * karni wants to move forward :) | 17:12 | |
| ChrisTownsend | mhr3: So my other question is if I'm in the Music scope, and I enter a search term, it won't automatically search Soundcloud though, right? | 17:13 |
| mhr3 | ChrisTownsend, right, it won't | 17:13 |
| mhr3 | though it should according to design | 17:14 |
| mhr3 | EDIDNOTHAPPEN | 17:14 |
| ChrisTownsend | mhr3: Ok, that is where I was going with this:) | 17:14 |
| ChrisTownsend | mhr3: Thanks | 17:15 |
| mhr3 | np | 17:15 |
| tsdgeos | dandrader|lunch: can you do https://code.launchpad.net/~aacid/unity8/hjournalbugfix/+merge/201047 ? | 17:17 |
| tsdgeos | and with that | 17:18 |
| tsdgeos | eod! | 17:18 |
| mhall119 | Saviq: I want to file a bug against the fact that the HUD changes from bottom-aligned to top-aligned while you're using it, should that go against ubuntu-ux or unity8? | 17:58 |
| Saviq | mhall119, ubuntu-ux and unity8 | 17:58 |
| Saviq | mhall119, it's per design, so the design needs to change | 17:58 |
| mhall119 | both? | 17:58 |
| mhall119 | ok | 17:58 |
| kgunn | mhall119: ubuntu-ux....and assign to johnlea | 18:00 |
| mhall119 | ok | 18:01 |
| === alan_g is now known as alan_g|EOD | ||
| mhall119 | Saviq: how about all of the Unity7 integration points that Unity8 currently doesn't have, are there bugs for each of those? | 18:07 |
| Saviq | mhall119, no, no bugs for all of those | 18:09 |
| Saviq | mhall119, they're handled in bprints mostly | 18:09 |
| mhall119 | Saviq: do you want bugs for them (I'm filing a lot today)? | 18:11 |
| Saviq | mhall119, not sure it will help us manage everything | 18:11 |
| Saviq | mhall119, not when the bug is going to be "missing foo" | 18:11 |
| mhall119 | ok, I'll refrain from those then, do you have a BP link where they are work items? | 18:12 |
| Saviq | mhall119, here's a mother-blueprint https://blueprints.launchpad.net/ubuntu/+spec/topic-s-unity-next-ui | 18:15 |
| Saviq | mhall119, most of them should be covered, if you find something that isn't - feel free to add | 18:15 |
| mhall119 | thanks Saviq | 18:16 |
| mhall119 | Saviq: so https://blueprints.launchpad.net/ubuntu/+spec/client-1303-unity-ui-launcher has everything currently DONE for the launcher, but doesn't have any plans or work items for adding count/progress/urgent API support to it, are those things in a BP somewhere? | 18:18 |
| Saviq | mhall119, https://blueprints.launchpad.net/ubuntu/+spec/client-1404-unity-ui-launcher | 18:19 |
| Saviq | mhall119, so yeah https://blueprints.launchpad.net/ubuntu/+spec/topic-t-unity-ui is the mother-blueprint for T | 18:19 |
| mhall119 | ah, thanks, looks like https://blueprints.launchpad.net/ubuntu/+spec/topic-t-unity-ui is the new mother-blueprint | 18:19 |
| mhall119 | ah, what you said | 18:20 |
| * mhall119 fails reading comprehension 101 | 18:20 | |
| mhall119 | thanks again Saviq | 18:20 |
| kgunn | greyback: thanks hopping on that one | 18:25 |
| kgunn | osk hiding when app is killed | 18:25 |
| greyback | kgunn: np | 18:25 |
| === dandrader|lunch is now known as dandrader | ||
| mhall119 | Saviq: I don't see anything for the counter and progress bar on Launcher icons in https://blueprints.launchpad.net/ubuntu/+spec/client-1404-unity-ui-launcher, can I add them as TODO work items? | 19:13 |
| mhall119 | there is one for the "urgent" state though | 19:14 |
| mhall119 | there's also nothing for supporting static or dynamic quicklists | 19:14 |
| elopio | hah! so I've proved that it's not possible to add any autopilot tests to unity8: | 19:28 |
| elopio | https://code.launchpad.net/~elopio/unity8/confirm_6_failure/+merge/201040 | 19:28 |
| elopio | sadly, now there's nobody around to blame :( | 19:28 |
| thomi | elopio: this is the input device issue? | 19:30 |
| thomi | Saviq was looking at that yesterday, was going to try a suggestion of mine, but I think he may be sleeping for once :) | 19:30 |
| elopio | thomi: it is one input device issue, I'm not sure it's the same one you are talking about. | 19:31 |
| elopio | thomi: it seems that after the current amount of tests, when I add a new one, the Touch will stop working. | 19:31 |
| elopio | thomi: what was your suggestion to Saviq? | 19:31 |
| thomi | elopio: right, we know why, and there's a couple of ideas | 19:31 |
| thomi | elopio: it's due to the fact that the u8 AP tests use a hacky workaround to get mir to recognise the input device | 19:32 |
| thomi | however, this workaround leaks input device s | 19:32 |
| thomi | so after a certain number of tests, we can no longer create any more input devices | 19:32 |
| elopio | thomi: ok. So can we delete input devices? | 19:33 |
| thomi | elopio: call close(0 on themn | 19:34 |
| thomi | ugh | 19:34 |
| thomi | typing is hard | 19:34 |
| thomi | "call close() on them" | 19:34 |
| thomi | before you create the new one | 19:34 |
| elopio | self.touch = Touch.create() | 19:35 |
| elopio | self.addCleanup(self.touch.close) | 19:35 |
| elopio | thomi: like that? | 19:35 |
| thomi | elopio: not quite... there's a workaround in the u8 codebase that calls _create_touch_device every test | 19:35 |
| thomi | this needs to be called on the underlying uinput device, with is an AP internal | 19:36 |
| thomi | AP never calls it because AP only ever creates a single instance :) | 19:36 |
| thomi | greap for "create_touch_device" | 19:36 |
| elopio | thomi: looking at it | 19:36 |
| thomi | cool | 19:36 |
| elopio | it happens only on the phone, makes sense | 19:36 |
| thomi | make sure "_touch_device.close()" is called before the new one is created | 19:37 |
| thomi | should do the trick, I think | 19:37 |
| * elopio tries. | 19:38 | |
| fipioni | i want to ask something about unity am i at the right place if yes why no one is | 20:01 |
| fipioni | replying to my pm | 20:01 |
| fipioni | :'( | 20:01 |
| karni | fipioni: If it's a technical question, you're at the right place. Bare in mind people live in different time zones. Just ask your question here, and you might get an answer. | 20:04 |
| ChrisTownsend | fipioni: Any reason why you can't ask here and can only ask via PM? | 20:07 |
| mhall119 | he's asking about the game engine Unity, not our Unity | 20:09 |
| fipioni | i asked something about crack software in the previous room and got bully | 20:09 |
| ChrisTownsend | fipioni: Yeah, sorry, this channel is for the desktop environment Unity for Ubuntu, not the game engine. | 20:10 |
| karni | oh | 20:10 |
| ChrisTownsend | fipioni: Sorry we can't help/ | 20:10 |
| karni | fipioni: My bad, like ChrisTownsend said, this is a wrong channel :/ Sorry. | 20:11 |
| fipioni | no i want to know something is there a way to check weather your code is comile using paid or free software | 20:12 |
| fipioni | *compile | 20:12 |
| mhall119 | fipioni: I don't think anybody here can answer questions about the game engine | 20:14 |
| fipioni | but what about compilation | 20:14 |
| karni | fipioni: You sure you talking about https://unity.ubuntu.com/ ? | 20:15 |
| fipioni | what about compilation from higher language to lower language that is understandable for certain operating system | 20:15 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| elopio | thomi: it works! thanks, you are the coolest one again. | 21:14 |
| elopio | thomi: do you have permissions to approve? | 21:25 |
| elopio | https://code.launchpad.net/~elopio/unity8/fix1267600-close_touch/+merge/201105 | 21:25 |
| === salem_ is now known as _salem | ||
| thomi | elopio: let me see | 21:49 |
| thomi | veebers: can you look at that please? LGTM, but you should be the one to review it I think | 21:50 |
| veebers | thomi: sure I can take a look | 21:50 |
| veebers | elopio: I have top-approved that. Thanks for that :-) | 21:54 |
| mhall119 | does the unity8 project still contain the welcome screen, or has that been broken out? | 21:58 |
| Saviq | mhall119, sorry, have reassigned most of your bugs ;) | 22:31 |
| mhall119 | Saviq: that's fine, I expected that to happen, I just didn't know what functionality lives in what project | 22:35 |
| Saviq | mhall119, j/k | 22:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!