=== duflu_ is now known as duflu [08:26] Saviq: o/ [08:26] https://code.launchpad.net/~mzanetti/unity8/tests-qml-in-cmake/+merge/200872 [08:26] mzanetti, yup, saw that [08:27] mzanetti, there's images in there, too, shall we go for /tests/qmltests/* as well? [08:28] mzanetti, or explicit .png, .svg, .sci? [08:41] Mirv, just tried to build unity-api i386 in a local sbuild with the latest qtdeclarative - it worked fine, so thumbs up! [08:44] mzanetti, could you look at https://code.launchpad.net/~unity-team/unity8/new-scopes-horizontal-card-layout/+merge/200910 - I've put too much of my hands into that for a clean-conscience review ;) [08:44] Saviq: ack [08:45] Saviq: updated the other one btw [08:45] mzanetti, cheers [08:45] Saviq: I went for * to be in line with the qml dir [08:45] mzanetti, uh oh I don't think that's gonna work [08:45] mzanetti, you just added all the mocks' .h and .cpp to the unity8 executable [08:46] oh crap. you're right [08:46] mzanetti, that's why I said tests/qmltests/*, but tests/*.qml, tests/*.js [08:47] yeah, makes sense [08:47] ouch [08:47] our ci is looking too red http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/ [08:47] tsdgeos, indeed :/ [08:48] too much autopilot failures it seems [08:49] Saviq: that thing is conflicting, no? [08:49] tsdgeos, "that thing"? [08:50] Saviq: new-scopes-horizontal-card-layout [08:50] tsdgeos, yeah just saw [08:50] interesting [08:50] Saviq: but i see the CI was from an old rev [08:50] so the two new revs maybe fix it [08:50] Saviq: yeah, unity-api seems good now! so it's a definite improvement, but gsettings-qt is still blocking progress from here (to eg. a point where Unity would need to be uninstalled when upgrading to Qt 5.2) [08:50] tsdgeos, well, I manually launched ci for it, and it's not going into lp:unity8 directly but in the new-scopes branch [08:50] tsdgeos, so that might be why [08:51] Mirv, :/ [08:51] Saviq: I needed to force Qt Declarative version number to 5.2.0 from 5.2.1, since otherwise CMake would error out on incompatible versions. I hope this system works. [08:51] Mirv: gsettings-qt is failing even with "qtdeclarative stable branch"? [08:51] tsdgeos: yes [08:51] weird [08:51] Mirv: what's the error? [08:51] still that xvfb thing? [08:52] tsdgeos: still that. bug #1259145 [08:52] bug 1259145 in gsettings-qt "gsettings-qt fails to build (run tests) against Qt 5.2" [Critical,Confirmed] https://launchpad.net/bugs/1259145 [08:52] mzanetti, does qmluitests have lp:unity8 hardcoded somewhere? [08:52] mzanetti, could it use target_branch instead? [08:53] mzanetti, seems that's where the failure in https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/850/console comes from - it's merging lp:unity8 into it instead of the new-scopes branch [08:53] Mirv: maybe indeed it's the "can't access X" thing and not the problem with qqmlpropertymap that is causing that, tests pass locally here in my machine [08:54] but indeed i do have X around [08:54] :D [08:55] the builders don't have, although they should have xvfb (but no 3d acceleration) - like I mention in the bug report, I have a vague memory SDK team battled with something similar in ubuntu-ui-toolkit [08:56] for 5.2? or in the beginning? [08:56] i mean why would have this changed in 5.2? [08:56] besides because "everything broke" :D [08:57] tsdgeos: around 5.2, like when they were testing building against RC1 [08:58] i see [08:58] then it may very well be yeah [08:59] Saviq: fixed [08:59] ci, that is ^^ [09:02] Mirv: can you test this patch? http://paste.ubuntu.com/6719664/ [09:03] Mirv: or you prefer me to get it into gsettings-qt ? [09:03] Mirv: i can reproduce the error if no X is avaiable here and this patch fixes it [09:03] larsu: ↑↑↑↑ ? [09:04] tsdgeos: that would make sense, since the QA team adding tests into Qt modules is using QT_QPA_PLATFORM=minimal as well [09:04] I can test in a PPA [09:04] tsdgeos: sounds sane to me [09:05] larsu: Mirv: so want me to propose the merge first or first check the patch in a ppa quick? [09:06] mzanetti, thanks [09:07] tsdgeos, Mirv: I don't care. This looks like a good idea in any case so feel free to propose the merge [09:08] chain reaction of cats scaring themselves and each other... plus hardfloors... priceless [09:08] tsdgeos: building now https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily/+sourcepub/3808316/+listing-archive-extra [09:12] seems good now [09:13] \o/ [09:15] larsu: Mirv: https://code.launchpad.net/~aacid/gsettings-qt/use_minimal_qpa_for_test/+merge/200971 [09:15] can anyone remind me how i run autopilot manually in a unity8 builddir? [09:18] Saviq: mzanetti: ↑↑ [09:19] nope [09:19] now he's gone [09:21] oh man, running autopilot killed my X :-S [09:21] if i disappear again [09:22] you know why [09:25] i'm doing something very wrong or we don't support running the tests on the desktop? [09:25] Ran 52 tests in 112.281s [09:25] FAILED (failures=46) [09:27] Saviq: your input needed at https://bugs.launchpad.net/unity8/+bug/1267135 [09:27] Ubuntu bug 1267135 in Network Menu "network-indicator should provide the "Please enter SIM PIN" text" [Undecided,Incomplete] [09:32] tsdgeos, done [09:33] tsdgeos, you need to make -C builddir install first [09:33] Saviq: hmmmmmm, looking at the text it may not even be "correct" [09:33] tsdgeos, and then PYTHONPATH=tests/autopilot autopilot list unity8 [09:33] or maybe it is [09:33] tsdgeos, sure, but that's orthogonal to the fact that unity8 should have no knowledge of those strings [09:34] tsdgeos, that will list you the tests, s/list/run/ will run them [09:34] agreed [09:34] just saying that maybe is just some placeholder [09:34] ok, let me see [09:35] see about the autopilot, not about the text :D [09:36] Saviq: i guess we should document that PYTHONPATH stuff somewhere [09:36] i'll forget to the next time :D [09:38] tsdgeos, you should do more python, you won't forget then ;) [09:44] oh no [09:44] i know about PYTHONPATH [09:44] it's just about the whole lot [09:44] of installing [09:44] and bla bla [09:50] larsu: Mirv: top-approve? https://code.launchpad.net/~aacid/gsettings-qt/use_minimal_qpa_for_test/+merge/200971 [09:51] tsdgeos: ah sorry. Done. [09:51] seb128, https://code.launchpad.net/~unity-team/ubuntu-system-settings/welcome-wizard/+merge/186862 :) [09:51] yeah I thought to give the top-approve honor to lar_su [09:51] Cimi, it's on my list, quite some backlog after holidays [09:52] seb128, good it's on your list [09:52] seb128, let me know when you're planning to review it [09:52] Cimi, and we had to spend time fixing ubuntu-themes issues, since you don't do it, which means less cycles for reviews... [09:52] seb128, in case I'll branch and propose something dependent on it [09:52] Cimi, if you were doing your job I could be reviewing that... [09:52] seb128, I am doing my job [09:52] Mirv: thanks :) I feel honored! [09:53] Cimi, the theme bug larsu fixed yesterday were assigned to you since novembre and you didn't act on them [09:53] seb128, because we have other priorities [09:54] it's not the only bug I have assigned and I didn't act yet [09:54] k [09:54] well, anyway, the wizard in on my todolist [09:54] I'm going to try to get to it today [09:54] seb128, good!! [09:54] seb128, I'll work on add the wifi page correctly [09:55] great [09:55] seb128, btw [09:55] seb128, I saw marco's work on the css decorations [09:55] seb128, it looks really cool and no more aliased corners :) [09:55] seb128, he stayed at mine for the new years eve [09:56] and was working on that! [09:56] you crazy Italians ;-) [09:59] Saviq: https://code.launchpad.net/~aacid/unity8/coding_autopilot_docu/+merge/200974 ? [10:06] tsdgeos, we also have a "make -C builddir autopilot" target, could you check out whether it works - and if not - see why? [10:07] sure [10:11] Saviq: nah, nope working [10:11] checking why [10:25] funny thing is that with ninja it works [10:34] Saviq: bascially it seems "it can't be done" [10:35] install is not a target you can depend on in cmake [10:35] if you're using make [10:35] for some reason [10:35] tsdgeos, we can have a custom target that will run cmake --build --target install, though [10:36] tsdgeos, a custom command or whatnot [10:36] hmmm [10:36] let me see [10:36] tsdgeos, or actually make the autopilot target do that [10:36] tsdgeos, otherwise it wouldn't be called every time [10:38] yeah that'd work [10:38] or should :D [11:00] Saviq: updated https://code.launchpad.net/~aacid/unity8/coding_autopilot_docu/+merge/200974 === davmor2_ is now known as davmor2 [11:23] and another one [11:23] https://code.launchpad.net/~aacid/unity8/timeformattertest_LCALL_C/+merge/200991 === _salem is now known as salem_ [11:42] greyback: can you get a manager add platform-api to Landing Asks in case https://code.launchpad.net/~ricmm/platform-api/set-dimensions/+merge/198490 is meant to go in? (landed after platform-api was released yesterday) [11:43] ricardo mentioned that commit so in case it's useful to have it fast it's better to add it already to the list [11:44] Mirv: ok. kgunn ^^ === pete-woods is now known as pete-woods|fight === pete-woods|fight is now known as pete-woods|away [12:34] Saviq: so was thinking about the organic positioner and how it's supposed to get bigger as the width increases and until two modules fit in the width [12:35] tsdgeos, again, I don't think it's your concern [12:35] tsdgeos, I think a QML wrapper will do that [12:35] Saviq: and was wondering if we can just do that in the QML side and on the C++ side we just have size and spacing [12:35] and someone cares about making it match [12:35] ok, same thought then [12:35] tsdgeos, yeah, justs have a prop "moduleSize" or so [12:35] or width [12:35] and spacing, exactly [12:36] tsdgeos, same spacing between items as well as between modules, right? [12:36] Saviq: i was thinkin on having spacing (for in between delagates) and then smallSize and bigSize properties [12:36] and with that i can calculate everything and see if i can have one or more modules per row [12:36] tsdgeos, ok, that's maybe even better [12:37] it's not as if it's going to be difficult to calculate [12:37] tsdgeos, +q [12:37] +1 even [12:37] D: === Trevinho_ is now known as Trevinho === pete-woods|away is now known as pete-woods === zequence_ is now known as zequence === alan_g is now known as alan_g|lunch [13:25] tsdgeos, https://code.launchpad.net/~allanlesage/unity8/autopilot-indicator-page-title-matches-widget/+merge/196991/comments/467382 === dandrader is now known as dandrader|afk [13:40] Wellark_, bug-chat seems to have problems ;) [13:40] Wellark_, the SIM PIN *dialog* is part of unity8 [13:40] already [13:40] Wellark_, and the UI is displayed as the screenshots show (they're screenshot from a real phone) [13:41] Wellark_, the only thing is the string, which is now hardcoded in unity8, but should be provided by whoever requests that dialog (most probably indicator-network) [13:41] Wellark_, is that somewhat more clear? [13:41] Saviq: yes, I got that it's already part of unity8 [13:41] I'm just trying to figure out what you want changed :) [13:41] and if it's just the hardcoded string [13:41] then fine :) [13:42] Wellark_, yes, only that - which means changes in unity8, unity-notifications potentially, and indicator-network [13:42] Saviq: yeah. the dialog needs a dbus interface also [13:42] so that indicator-network can update the values and provide the modem state [13:42] Wellark_, it already does - it really really actually works already ;) [13:42] I'm skeptical ;) [13:42] Wellark_, over a snap decision + UnityMenuModel [13:43] so "extended snap decision" [13:43] Saviq: ok. I'm working on the connectivity api atm, until the end of next week [13:44] then it's 100% for indicator-network for me [13:44] Saviq: how much in a hurry are you with this? [13:44] Wellark_, not at all ;) [13:44] dednick, http://ddebs.ubuntu.com/pool/main/m/mir/ btw :/ [13:45] Saviq: thanks [13:45] Saviq: ok. let's leave the bug open then and make the hardcoded string dissapear in near future [13:45] Wellark_, +1, that's all I needed :) [13:45] dednick, apparently index generation didn't catch up yet [13:50] greyback: about to run the boy up to school....so i assume you want that papi mp ? [13:50] kgunn: yes, that and https://code.launchpad.net/~ricmm/qtubuntu/papi-setdimensions/+merge/198498 === dandrader|afk is now known as dandrader [13:55] greyback: thanks...sidestage i assume [13:55] tsdgeos, re: open_scope tests... if you look at https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1871/artifact/results/autopilot/artifacts/unity8.shell.tests.test_notifications.EphemeralNotificationsTests.test_urgency_order%20%28Desktop%20Nexus%204%29.ogv - it looks like the test is interrupted somehow [13:55] kgunn: yep [13:56] tsdgeos, apparently we don't get unity8.log there unfortunately [13:56] oh :/ [13:56] yeah it looks like it ends "too early" [13:57] tsdgeos, I've seen that a few times already, no idea where it comes from [13:58] greyback: before i top approve...any idea why that qtubuntu ci has failed so many times? [13:58] fginther, does testrunner-otto collect .crash files? and could it collect unity8.log from .cache/upstart/? [13:58] fginther, we have trouble understanding / reproducing https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1871/ :/ [13:58] kgunn: it depends on that papi change to land first. [13:58] greyback: thank you sir [13:59] Saviq, I'll check on that, if it's not collecting them, it should be easy to add them [14:00] Mirv: ok...added "set dimension" support mp's to landing ask for papi & qtubuntu [14:12] Mirv: https://code.launchpad.net/~aacid/qml-friends/use_minimal_qpa_for_test/+merge/201009 same trick worked [14:14] woohoo, stuff is looking greener in qt5-beta2 === alan_g|lunch is now known as alan_g [14:18] mzanetti, re: new-scopes-horizontal [14:19] mzanetti, you sure the tests pass regardless? do you have an explanation? [14:19] Saviq: probably that function() in data() doesn't work [14:19] mzanetti, it doesn't have to "work" and well, why wouldn't it? [14:19] Saviq: I tried to just removing the functions in there for consistency and noticed the tests were failing [14:19] mzanetti, the reason for using a lambda there is that the values used to compute change in _test() when the selectedIndex is changed [14:20] then I reverted and made the functions return bullshit [14:20] still passing [14:20] mzanetti, humm [14:20] mzanetti, interesting, me checks [14:20] karni, ↑ [14:20] Saviq: I'm quite sure you can achieve the same without lambdas [14:21] * greyback thinks it would be nice if unity8 binary could let you specify a custom directory to load the qml from [14:21] * karni reads [14:21] mzanetti, I'm all ears [14:21] heh [14:21] ok. need to try then. but so far I haven't come across a situation where I would have needed this [14:22] mzanetti: Saviq: I still wanted to revert the changes and make sure tests would fail, was late yesterday. I'm happy to get on this now, I should have left a comment. [14:22] Saviq: esp. things like "return 0". why a lambda? [14:23] mzanetti, that was just so that I don't have to do the "if typeof === "function"" [14:24] Saviq: you can define a property int expectedHeaderPos: art.x + art.width [14:24] mzanetti, the situation here is simple: the index: part of the data actually changes the layout [14:24] and then just refer to that property in the data [14:24] or something like that [14:24] mzanetti, nope, that won't work, 'cause it would get the value in _data() [14:24] mzanetti, well, you'd need to refer to it by name, not [14:24] value [14:24] Like Saviq said, first line setting the selector index changes layout. [14:25] mzanetti, so not a nicer solution that the lambda IMO [14:25] but /me needs to look [14:25] no... not really nicer... [14:25] anyways... either lambdas in there don't work at all or there is some other mistake [14:26] * karni is looking into it === rachelliu_ is now known as rachelliu [14:26] FTR changing the return 0 to return anything else makes the test fail. [14:27] * karni looks at another lambda [14:27] mzanetti, changed the tests, FAIL [14:27] I tried this in line 291: [14:27] { tag: "Horizontal", left: function() { return art.width * 2 }, index: 5 } [14:27] note the *2 [14:27] still passing [14:27] mzanetti: that makes it fail [14:27] dafuq [14:27] * mzanetti tries again [14:28] mzanetti, line 291? [14:28] what the heck is going on [14:28] it fails somethimes here [14:28] Saviq: in tst_Card.qml [14:28] mzanetti, right, I merged it on top of new-scopes [14:29] yep. now it passed again _with_ the *2 [14:29] karni, can you please do merge lp:~unity-team/unity8/new-scopes [14:29] but sometimes it fails indeed [14:29] Saviq: into that MP branch? sure [14:29] hmm... maybe the tryCompare stops by the value with *2 too [14:29] mzanetti, indeed it does [14:30] mzanetti, right, tryCompareFunction then... [14:30] Saviq: done [14:30] karni, thanks [14:30] anytime [14:31] mzanetti, chicken'n'egg problem here, really... [14:31] yeah... guess so [14:31] mzanetti, so the other possibility is to just use hardcoded units.gu() values if you think it better [14:31] I didn't want to do that [14:32] hmm... dunno [14:32] Saviq: that would be then specific to a particular card-size, right? [14:32] if we wanted to hardcode these values. [14:32] mzanetti, hmm now it reliably fails [14:32] mzanetti, pull please [14:33] I guess now that we know the lambdas are working and the issue was another one I guess I'm fine with it [14:33] mzanetti, well, the fact that it's a chicken'n'egg problem is still an issue [14:33] Saviq: mzanetti standup [14:33] quit talking about food and get back to work [14:33] haha [14:34] karni, wanna join? [14:34] karni, Standup on Canonical mumble [14:34] Saviq: hangout? oh, lemme see quickly if I have it set up [14:34] sure [14:34] been a while I used mumble [14:35] which room would that be? [14:35] hrm.. mumble just hung [14:35] karni, kill, start again ;) [14:35] * karni does just that, another hang. gives it a sec. [14:36] karni, try again ;) [14:37] there :) [14:42] greyback: I'm worried that we'll never ever get our stuff merged again [14:43] mzanetti: "we" as in you? :) [14:43] thanks [14:43] :P [14:43] mzanetti: I'm only making the tiniest changes here and there, nothing major at all [14:43] mzanetti: I'm keeping eye on your branch [14:44] greyback: ah, that sounds good :) [14:44] greyback: are you mostly working in unity-mir or unity8 (aka. ApplicationManagerWrapper)? [14:46] mzanetti, so, what I meant was... if the target value is moving ('cause it depends on the layout) and the tested value is moving, they might "meet" and pass somewhere in the middle... [14:46] mzanetti, although in this case there's no animation, so that should be fine, but still... [14:46] mzanetti: yep, most LOC changed are not in unity8 at all. [14:46] mzanetti: how close would your work be to landing? [14:46] greyback: ah ok... my changes in unity-mir are rather small [14:47] greyback: unfortunately rather far away [14:47] greyback: I don't think I should still re-implement the old school side stage in my branch [14:47] greyback: and I don't have a design for the new one yet [14:48] greyback: the phone stuff is getting closer tho, but our no-breakage policy wouldn't allow it to land without implementing the tablet stage too first [14:48] mzanetti: ok. Then I'll be making a couple of minor tweaks to shell.qml and stage.qml probably, that might cause you pain [14:48] greyback: I've deleted stage.qml in my branch [14:48] minor tweaks = 2-3 lines of code changes [14:49] mzanetti: yep, so it's only shell.qml really we need to be careful about I think [14:49] yeah. sounds ok [14:49] cool [14:49] yep [14:49] Saviq: hmm... I'm sure you'll figure a solution :P [14:49] * mzanetti prepares for the design meeting [14:49] mzanetti, just using you as a sounding board ;P [14:49] do I? [14:50] oh... read wrong.. [14:50] got it [14:51] brain FEC is scary sometimes... I read "..as you are sounding bored" [14:52] ;D [14:53] tsdgeos, what was the _BAD_RENDER_LOOP thing again? [14:54] Saviq: you mean the full name? [14:54] tsdgeos, yeah [14:54] QML_BAD_GUI_RENDER_LOOP [14:54] tsdgeos, is it somewhere on doc.qt-project btw? [14:54] not sure [14:54] i just grepped the sources :D [14:54] tsdgeos, as in that, the RENDER_TIMING one... I always seem to forget them [14:55] tsdgeos, yeah ;) [14:56] karni, you might want to export ↑↑ =1 after having shelved qml/ changes [14:56] karni, otherwise qmltestrunner crashes for me her [14:56] e [14:56] * karni notes [14:56] writing an e-mail for a person Alex might be hiring, I'll get my hands on the shelving part real soon. === dandrader is now known as dandrader|lunch [15:04] karni, but yeah, http://paste.ubuntu.com/6721162/ adds some robustness to the tests [15:06] tsdgeos, check this out http://paste.ubuntu.com/6721167/ [15:06] uh oh 5.2? [15:06] I'm not on 5.2, WTH? [15:07] that's a crash? [15:07] tsdgeos, yeah [15:07] tsdgeos, but the retrace seems bogus [15:07] :D [15:08] tsdgeos, somehow the retracer decided to pick up qt5.2 instead of the one I had installed... [15:11] bad retracer bad! [15:14] tsdgeos, indeed, apparently it always picks up latest packages (I had the 5.2 PPA enabled for the retracer - a thing to remember) [15:14] tsdgeos, http://paste.ubuntu.com/6721216/ [15:14] tsdgeos, less scary, and solved by BAD_RENDER [15:15] Saviq: may even be a problem of UCFontUtils::sizeToPixels ? [15:15] not being thread-safe/reentrant/whatever? [15:21] tsdgeos, true [15:21] * Saviq files a bug just in case [15:22] * karni gets to those tests [15:45] tsdgeos, and now for something completely different! the launchpad retracer decided it's nothing relevant to the UCFont... but the Shape instead... https://launchpadlibrarian.net/162021731/Stacktrace.txt [15:45] that is weird :S [15:46] tsdgeos: thanks for the review. [15:46] I've been trying to reproduce the mako errors since yesterday, and I have finally done it. It only fails when I run the whole suite, it seems one test fails to swipe the greeter, then the screen will go blank and all the following tests will fail too :/ [15:46] elopio: no worries [15:46] ouch [15:46] Saviq: is that the bug you mentioned ↑↑↑ in the other autopilot merge request? [15:47] what, i'm running on battery¿? [15:47] not anymore === alan_g is now known as alan_g|tea [15:47] tsdgeos, no, something that happened locally [15:48] ok [15:57] Saviq: I have standup in 3 minutes, but I'll try to be first, and join you guys asap. The meeting you scheduled is in a moment, right? [16:00] karni, we just moved it to tomorrow [16:00] karni, 10am UTC [16:00] karni, katie couldn't make i [16:00] t [16:00] Saviq: perfect, thanks :) === greyback is now known as greyback|away === alan_g|tea is now known as alan_g [16:11] tsdgeos: can we prevent the screen to go blank in these tests? [16:11] elopio: sure [16:11] i mean [16:11] well there's a command line call that makes it not go blank [16:11] you should be using it [16:12] which i don't remember [16:12] powerd-cli [16:12] and some argument [16:12] powerd-cli display on [16:12] elopio: ↑ [16:13] tsdgeos: thanks, that will help a little. [16:27] Saviq: why did we drop the qmlproject? [16:28] dednick, to not have two separate projects in qtcreator [16:28] dednick, they are part of the CMake project now [16:28] dednick, although mzanetti's still fixing a few issues with that [16:28] branch updated btw [16:28] dednick, you might need to right-click on the project → Run CMake to get them [16:28] Saviq: ^ [16:29] Saviq: how do I actually open the project? :) [16:29] kdub: ^^ see tsdgeos [16:29] dednick: just open the cmakeLists.txt [16:29] talking about the powerd issue above [16:29] the top level one [16:29] mzanetti, no it's not https://code.launchpad.net/~mzanetti/unity8/tests-qml-in-cmake/+merge/200872 [16:30] mzanetti, still includes all the .cpp .h files in the executable [16:30] hmm... seems I pushed to the wrong branch then [16:30] Saviq: ahh, didnt even know you could do that [16:30] dednick, you couldn't ;) [16:30] dednick, but mzanetti managed to [16:30] tsdgeos, i think that should work [16:30] yay. source files! [16:30] kdub: yes it does [16:30] kdub: wasn't complaining [16:30] was just telling elopio [16:30] right :) [16:32] Saviq: pushed now [16:32] mzanetti, ack [16:32] what I found is that when there are 6 tests left, the autopilot Touch stops working. [16:33] mzanetti, hrm, in that case we can drop the special case for qmltests can't we [16:33] mzanetti, ah wait [16:33] mzanetti, ignore [16:33] is good [16:33] tests/modules [16:33] UntiyTestCase.qml [16:34] kdub: i was just pointing it out...b/c we really shouldn't need to be using powerd cli to get past it... [16:34] related to https://bugs.launchpad.net/mir/+bug/1236525 [16:34] Ubuntu bug 1236525 in unity-mir "unity8 killed/crash then restart can result in mir unable "could not unblank display"" [Medium,Triaged] [16:35] anyway...it'll be interesting to hear if you find this is now effecting mir ci as well [16:49] Saviq: validated tests against your changes. test_art_size_data() with "Horizontal" tag would only verify that art.height == header.height (good, along the spec). But I can't make it fail, because we actually wanted to test anchors.horizontalCenter using x (and/or width), while width and height already well defined in the code. In other words, can't make the test fail for missing line 9 here, although the tests in lines 22,23 verify UI against ... [16:49] ... spec. http://paste.ubuntu.com/6721694/ [16:51] Saviq: pushed revno 575 to that MR, I got no further improvements. [16:52] Saviq: just read the comment on MR regarding what we talked before about lambdas. let me try make em fail. [16:53] karni, don't over-do :) [16:53] Saviq: I mean, if it's seriously an issue, I should see where stuff fails. [16:55] karni, I'm afraid I didn't follow your sentence above, but that might be EOD creeping up on me [16:57] Saviq, the otto jobs are already saving crash files if they exist (the build you specified didn't have any). I have a change ready to collect the unity8.log [16:57] Saviq, here's an example: http://s-jenkins.ubuntu-ci:8080/job/autopilot-testrunner-otto-trusty-fjg/3/ [16:57] fginther, awesome, thanks! [17:00] I have a question about the SoundCloud scope. I was supposedly deprecated by the Home Scope here: http://bazaar.launchpad.net/~unity-team/unity-scope-home/trunk/revision/146 [17:00] I don't see how to get results from Soundcloud though. How do I get results from Soundcloud? [17:01] mhr3: pstolowski: Perhaps you can answer my question above? ^^^^ [17:02] ChrisTownsend, "soundcloud:foo" in dash home [17:02] oh, no automatic way via filter though, right? [17:02] no [17:02] ChrisTownsend, or by typing a query. and *then* selecting it from filters in home [17:03] mhr3: Ok, thanks [17:03] ChrisTownsend, well, not sure what you meant by "automatic" [17:03] pstolowski: Soundcloud is not listed as a filter though. [17:03] it is here [17:04] mhr3: I get it if install unity-scope-onlinemusic from Universe. === greyback|away is now known as greyback [17:04] But I don't see it if I don't have that installed. [17:04] hmm, doesn't sound right [17:05] although i do have that installed [17:05] mhr3: I didn't think that sounded right either. That's why I'm asking:) [17:06] mhr3: However, Soundcloud:foo does work without the onlinemusic scope. [17:07] ChrisTownsend, yeah, onlinemusic has nothing to do with it, it was implemented specifically for the phone (although it works on the desktop of course) [17:07] mhr3: Well, it this all back. I now see the filter. [17:07] Why did I not see that before. [17:08] dee-tool -m "com.canonical.Unity.SmartScopes.RemoteScopesModel" | grep -q -i "soundcloud" && echo "It's there" || echo "Not there" [17:11] mhr3: I ran that, got a dee-tool crash and it printed out Not there [17:11] mhr3: Sorry, I entered something wrong. [17:11] mhr3: It's there [17:12] then it is there :) [17:12] mzanetti: FYI In each single lambda these new tests contain I added +1 in the return value. Each test would consistently fail. Considering your comment on the MR, does that mean we're good? [17:12] mhr3: lol, yeah [17:12] * karni just pushed last revno [17:12] * karni wants to move forward :) [17:13] mhr3: So my other question is if I'm in the Music scope, and I enter a search term, it won't automatically search Soundcloud though, right? [17:13] ChrisTownsend, right, it won't [17:14] though it should according to design [17:14] EDIDNOTHAPPEN [17:14] mhr3: Ok, that is where I was going with this:) [17:15] mhr3: Thanks [17:15] np [17:17] dandrader|lunch: can you do https://code.launchpad.net/~aacid/unity8/hjournalbugfix/+merge/201047 ? [17:18] and with that [17:18] eod! [17:58] Saviq: I want to file a bug against the fact that the HUD changes from bottom-aligned to top-aligned while you're using it, should that go against ubuntu-ux or unity8? [17:58] mhall119, ubuntu-ux and unity8 [17:58] mhall119, it's per design, so the design needs to change [17:58] both? [17:58] ok [18:00] mhall119: ubuntu-ux....and assign to johnlea [18:01] ok === alan_g is now known as alan_g|EOD [18:07] Saviq: how about all of the Unity7 integration points that Unity8 currently doesn't have, are there bugs for each of those? [18:09] mhall119, no, no bugs for all of those [18:09] mhall119, they're handled in bprints mostly [18:11] Saviq: do you want bugs for them (I'm filing a lot today)? [18:11] mhall119, not sure it will help us manage everything [18:11] mhall119, not when the bug is going to be "missing foo" [18:12] ok, I'll refrain from those then, do you have a BP link where they are work items? [18:15] mhall119, here's a mother-blueprint https://blueprints.launchpad.net/ubuntu/+spec/topic-s-unity-next-ui [18:15] mhall119, most of them should be covered, if you find something that isn't - feel free to add [18:16] thanks Saviq [18:18] Saviq: so https://blueprints.launchpad.net/ubuntu/+spec/client-1303-unity-ui-launcher has everything currently DONE for the launcher, but doesn't have any plans or work items for adding count/progress/urgent API support to it, are those things in a BP somewhere? [18:19] mhall119, https://blueprints.launchpad.net/ubuntu/+spec/client-1404-unity-ui-launcher [18:19] mhall119, so yeah https://blueprints.launchpad.net/ubuntu/+spec/topic-t-unity-ui is the mother-blueprint for T [18:19] ah, thanks, looks like https://blueprints.launchpad.net/ubuntu/+spec/topic-t-unity-ui is the new mother-blueprint [18:20] ah, what you said [18:20] * mhall119 fails reading comprehension 101 [18:20] thanks again Saviq [18:25] greyback: thanks hopping on that one [18:25] osk hiding when app is killed [18:25] kgunn: np === dandrader|lunch is now known as dandrader [19:13] Saviq: I don't see anything for the counter and progress bar on Launcher icons in https://blueprints.launchpad.net/ubuntu/+spec/client-1404-unity-ui-launcher, can I add them as TODO work items? [19:14] there is one for the "urgent" state though [19:14] there's also nothing for supporting static or dynamic quicklists [19:28] hah! so I've proved that it's not possible to add any autopilot tests to unity8: [19:28] https://code.launchpad.net/~elopio/unity8/confirm_6_failure/+merge/201040 [19:28] sadly, now there's nobody around to blame :( [19:30] elopio: this is the input device issue? [19:30] Saviq was looking at that yesterday, was going to try a suggestion of mine, but I think he may be sleeping for once :) [19:31] thomi: it is one input device issue, I'm not sure it's the same one you are talking about. [19:31] thomi: it seems that after the current amount of tests, when I add a new one, the Touch will stop working. [19:31] thomi: what was your suggestion to Saviq? [19:31] elopio: right, we know why, and there's a couple of ideas [19:32] elopio: it's due to the fact that the u8 AP tests use a hacky workaround to get mir to recognise the input device [19:32] however, this workaround leaks input device s [19:32] so after a certain number of tests, we can no longer create any more input devices [19:33] thomi: ok. So can we delete input devices? [19:34] elopio: call close(0 on themn [19:34] ugh [19:34] typing is hard [19:34] "call close() on them" [19:34] before you create the new one [19:35] self.touch = Touch.create() [19:35] self.addCleanup(self.touch.close) [19:35] thomi: like that? [19:35] elopio: not quite... there's a workaround in the u8 codebase that calls _create_touch_device every test [19:36] this needs to be called on the underlying uinput device, with is an AP internal [19:36] AP never calls it because AP only ever creates a single instance :) [19:36] greap for "create_touch_device" [19:36] thomi: looking at it [19:36] cool [19:36] it happens only on the phone, makes sense [19:37] make sure "_touch_device.close()" is called before the new one is created [19:37] should do the trick, I think [19:38] * elopio tries. [20:01] i want to ask something about unity am i at the right place if yes why no one is [20:01] replying to my pm [20:01] :'( [20:04] fipioni: If it's a technical question, you're at the right place. Bare in mind people live in different time zones. Just ask your question here, and you might get an answer. [20:07] fipioni: Any reason why you can't ask here and can only ask via PM? [20:09] he's asking about the game engine Unity, not our Unity [20:09] i asked something about crack software in the previous room and got bully [20:10] fipioni: Yeah, sorry, this channel is for the desktop environment Unity for Ubuntu, not the game engine. [20:10] oh [20:10] fipioni: Sorry we can't help/ [20:11] fipioni: My bad, like ChrisTownsend said, this is a wrong channel :/ Sorry. [20:12] no i want to know something is there a way to check weather your code is comile using paid or free software [20:12] *compile [20:14] fipioni: I don't think anybody here can answer questions about the game engine [20:14] but what about compilation [20:15] fipioni: You sure you talking about https://unity.ubuntu.com/ ? [20:15] what about compilation from higher language to lower language that is understandable for certain operating system === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader [21:14] thomi: it works! thanks, you are the coolest one again. [21:25] thomi: do you have permissions to approve? [21:25] https://code.launchpad.net/~elopio/unity8/fix1267600-close_touch/+merge/201105 === salem_ is now known as _salem [21:49] elopio: let me see [21:50] veebers: can you look at that please? LGTM, but you should be the one to review it I think [21:50] thomi: sure I can take a look [21:54] elopio: I have top-approved that. Thanks for that :-) [21:58] does the unity8 project still contain the welcome screen, or has that been broken out? [22:31] mhall119, sorry, have reassigned most of your bugs ;) [22:35] Saviq: that's fine, I expected that to happen, I just didn't know what functionality lives in what project [22:35] mhall119, j/k