[00:36] thomi, the test from lp:autopilot fail for me [00:37] cjwatson: yes, I suspect this is a naming collision. Sorry if I caused any confusion [00:37] sergiusens: which ones, and how? also, perhaps #ubuntu-autopilot is a better channel for this? [00:37] thomi, http://paste.ubuntu.com/6747837/ [00:38] sergiusens: do you have all the build-deps installed? [00:38] looks to me like you're missing python-junitxml and/or python3-junitxml [00:38] thomi, I did apt-get build-dep python-autopilot [00:39] thomi, that was it. [00:39] sergiusens: that will get the build-dep for autopilot in archive [00:39] sudo mk-build-deps -i [00:39] is the magic you want :) [00:45] thomi: ok [07:33] ev, no, I did not === psivaa changed the topic of #ubuntu-ci-eng to: Ubuntu CI Engineering Team | Vanguard: psivaa | Landing instructions: http://paste.ubuntu.com/6292280/ | Known issues: - [09:33] Saviq: fginther is still looking into it: https://app.asana.com/0/8736198969650/9504356304887 [09:34] psivaa: I'm getting alerts on PD for wazn-adt - can you have a look? [09:38] ev, yes I saw, thanks [09:39] ev: i'm on it [09:39] thanks guys [09:52] ev: ok, i was unaware that the acknowledgement will be unacknowledged if that's not resolved within 30 mins. may be it's better to increase that timeout to reduce the hassle to you [09:52] that's now resolved btw [09:59] psivaa: no, I definitely want to know if no one has ack'ed it within 30 minutes [09:59] and whoop! thanks [10:02] ev: i acked at 0903 but that got unacked at 0933 because it was n't resolved. but fine if you want to keep it that way [10:03] not sure if we'll be able to resolve all the issues within 30 mins after ack'ing [10:03] oh, right [10:03] I see your point now [10:03] :) [10:03] retoaded: any thoughts on what we should do here? Should the policy be to downtime the check in nagios when you're investigating and it'll take more than 30 minutes? [11:21] rsalveti: bug updated with the unity8.log and unity8.log.1.gz I'm assuming the latter will contain yesterdays log but I put them both up to be sure :) [11:29] didrocks: any images you plan on promoting today? I spent yesterdays time digging into the app failing to start. :( on a plus side looks like it is only maguro and might explain the random failures again. Me can't wait for his n4 to arrive now :) [11:30] davmor2: there is a rssreader promoition [11:30] sorry, reformulating [11:30] davmor2: there is rssreader AP tests failure blocking promotion [11:33] didrocks: okay I don't want to upgrade just yet incase rsalveti needs me to look at anything else. So I'll leave testing till latter on then :) [11:34] ok [11:37] psivaa, ev. I don't think it's so much that the acknowledgement gets unacknowledged as it is that nagios sends another alert to PD when it runs it's check again and the issue is still there. [11:39] retoaded: yeah, but wouldn't scheduling downtime for the alert in nagios fix psivaa's problem? [11:39] I'd agree that PD is probably not the right place to say "this is going to take a while" [11:40] though I'd also agree that having to perform some tasks in PD and others in nagios isn't ideal :) [11:40] ev, as for policy in cases like this, hmmm ..... Most issues we see are able to be resolved quickly. Since there are some that can't be then we would need to/should a) add a comment to the incident in PD and b) schedule the downtime in nagios to prevent repeated alerts for an issue already being worked. [11:46] retoaded: can I ask that you hijack https://wiki.canonical.com/UbuntuEngineering/CI/Alerting for this, filling it out with what you've just said and also the instructions for scheudling downtime? [11:46] ev, sure [11:47] star, thanks! === alan_g is now known as alan_g|afk [12:21] retoaded: not sure how useful too many users logged in is [12:21] in nagios, that is [12:24] ev, from my perspective, more people logged in = more chance something could get broken. It's about the only thing I take the pessimistic view on [12:24] :) [12:24] fair enough [12:25] ev, although I will admit the default nagios check is bs. It gives total logins instead of unique logins. Might be the first candidate for a plugin to fix or replace [12:27] * ev nods [12:29] Who here has an Ubuntu tablet? [12:30] sil2100: which model? [12:30] popey: any I guess, just something that would be a tablet form-factor [12:31] so nexus 10 then. [12:32] you mean nexus7 doesnt qualify for tablet formfactor ? [12:32] (you should tell that to the deciders that will make us drop everything but N4 and N7 ;) ) [12:33] ;) [12:39] Well, I just need someone with a N7 or N10 to test a package for me [12:59] Who here has a N7 or N10? === cjohnston changed the topic of #ubuntu-ci-eng to: Ubuntu CI Engineering Team | Vanguard: cjohnston | Landing instructions: http://paste.ubuntu.com/6292280/ | Known issues: - === alan_g|afk is now known as alan_g [13:29] didrocks: hmm... would it be somehow possible that the intel machine's otto didn't use the latest desktop image? [13:30] Wait [13:31] didrocks: actually yes, I see that the intel machine uses trusty-i386-20140113-0008 while nvidia already trusty-i386-20140114-0008 <- who should I ping to get this resolved? [13:31] vila: ^ ? [13:32] sil2100: cihelp's vanguard is cjohnston right now ;) [13:33] vila: ok ;) Just remembered that you had experience with otto and q-jenkins [13:33] * cjohnston has no experience with that stuff [13:33] cjohnston: ^ could you maybe take a look why intel in otto still uses the previous image? [13:33] sil2100: yup, but we try to disseminate that knowledge through the vanguard rotation [13:34] cjohnston: most of the knowledge should be documented in https://wiki.canonical.com/UbuntuEngineering/CI/Playbook/Otto [13:35] vila: that's where I'm lookin [13:35] ty [13:35] cjohnston: yw [13:37] sil2100: I'll log this and attempt to chase it down [13:50] cjohnston: thanks! [14:07] ping ci-help: so, for running tests using the OSK we need to restart maliit with testability. [14:08] this can be similar to how we run unity8 tests, that assumes unity is not running, and it's started on each test. [14:08] but I don't know where is the code that kills unity8 for jenkins. Can I get some help copying that for the maliit case? [14:11] sil2100: yeah, the CI team should be your contact [14:13] elopio: cihelp not ci-help or nobody will notice ;) And you should should ping the vanguard indicated in the topic line. And hi and Happy New Year ! [14:14] thanks vila. Happy New Year for you too. [14:14] and ping cjohnston. [14:16] elopio: looking [14:16] morning [14:18] fginther: any suggestions on elopio's request? [14:18] elopio, have you tried asking in #ubuntu-unity to see what unity8 is doing? [14:18] fginther, cjohnston: there's a process_helper.py on unity that's what I'm going to copy to ubuntu-keyboard. [14:18] the part that I'm missing is how to make sure maliit is not running. [14:19] I can ask them. [14:19] elopio, cjohnston, I know that there is a unity8 restart in our test runner, but I recall this might no longer be the right way to do it [14:19] i need to head out for a bit, i might not be back in time for the meeting [14:19] * kenvandine waves [14:19] elopio, does OSK only need to be restarted for OSK tests or for all tests? [14:20] fginther: eventually, for all tests. For now, only for ubuntu-ui-toolkit tests. [14:20] elopio, hmmm [14:21] fginther: there are alternatives, but I thought that what unity was doing was the right way according to CI. [14:21] note that the maliit upstart job depends on unity8 running [14:21] might be a bit trickier than the unity case [14:23] ogra_: but we always have unity8 running, where's the tricky part? [14:23] elopio, it's not such a big deal how its done, it's just something we (unity8, OSK, and CI) need to get right and agree upon [14:26] fginther: do you think we can agree on something this week? Should I start pinging people to discuss about it? [14:32] popey: do you have an N7? ;) [14:32] (or any other UT enabled tablet?) [14:34] elopio, yes, I don't think agreeing upon a method should be too much work [14:38] sil2100: both my N7's are android atm [14:39] bfiller, Saviq: I think you are the ones that should be involved in that discussion ^^, re: restarting services with testability enabled. [14:39] please, point somebody else if I'm wrong :) [14:40] * popey afk [14:41] elopio, yeah, that's probably me [14:50] davmor2: I'd check the bug with ricmm_, as it seems to be app lifecycle related [14:50] davmor2: updated the bug as well [14:52] rsalveti: great thanks [14:53] cihelp: does anyone from the CI team have a tablet with UT installed? === alan_g is now known as alan_g|tea [14:53] sil2100: I think balloons has a N10 [14:59] ricmm_: https://bugs.launchpad.net/bugs/1268693 rsalveti has asked me to run this past you. On the maguro there is an issue possibly caused by constantly opening and closing an app that at some point in a test run the app locks up with just the grey app holder visible. [14:59] Ubuntu bug 1268693 in Unity 8 "Possible bug in mir/memory on maguro" [Undecided,New] === alan_g|tea is now known as alan_g [15:04] cjohnston: thanks, will poke him then [15:04] balloons: hi! Are you around already? [15:12] didrocks, sil2100 can we add http://paste.ubuntu.com/6748287/ to the release plan? I forward ported to trunk as well (https://code.launchpad.net/~sergiusens/autopilot/app_uris/+merge/201525 veebers said the code was fine) [15:12] not sure when trunk is happening; but we need that for gallery and media player [15:13] sergiusens: trunk release should come within the week, can we just wait for it? [15:13] I tested btw, and bfiller might do that as well [15:13] didrocks, ask bfiller :-) [15:14] bfiller: ? ^ [15:14] didrocks, I don't trust ETA's from anyone any more ;-) [15:14] sergiusens: well, just look at the still failing AP tests for instance, I agree with you :) [15:15] balloons: hey btw, any news on rss reader app? it's what is blocking image promotion FYI [15:15] didrocks, fwiw, I don't even trust my own ETAs ;-) [15:16] ahah ;) [15:16] ;) [15:17] davmor2: that sounds like a race with upstart app launcher [15:17] where an app hasnt finished being stopped by the time you ask it to start the new one [15:18] in which case the app manager gets out of sync, because it assumes that upstart has done its job [15:18] however maguro is slow [15:19] ricmm_: could well be [15:20] sergiusens, lol [15:21] didrocks, no good news to pass along, sorry mate [15:21] balloons: it's the priority one? do we know where this regression come from? [15:22] no changes have been released with rss reader [15:22] balloons: but you are working on digging it, right? [15:22] yes, I'm attempting to tweak things anyway ;-) [15:23] balloons: so, it started on image 122, let me get you the diff [15:24] I thought it was the python-gobject issue, but even with the revert, it didn't change [15:24] balloons: quite a huge diff: http://people.canonical.com/~ogra/touch-image-stats/20140110.1.changes [15:24] balloons: I'm seeing some openssl change, I would suggest that you try to revert it on your device and rerun the tests [15:25] hmm.. I just saw the ssl change as well [15:25] that's my best guess from the list [15:26] cjohnston: hi! Any luck with otto and the image? [15:27] fginther: ^ [15:28] sil2100, sorry, too many fires this morning [15:29] sergiusens, didrocks : sorry was on standup, what is the question? [15:35] sil2100, cjohnston the update job (http://q-jenkins.ubuntu-ci:8080/job/autopilot-trusty-setup_otto/83/) failed on the intel node. Looks like jenkins couldn't connect to the node. [15:35] sil2100, I've manually updated the node, it should be on a trusty-i386-20140114-1534 container now [15:35] fginther: oh, was that a singular failure? Thanks! [15:36] sil2100, yes, it appears to be an isolated failure, but one I've never seen before [15:39] bfiller: it seems the gallery and media player needs an autopilot backport. As autopilot is getting released this week normally, I wonder if you can wait on that one rather than backporting the AP changes (which involves quite a lot of overhead) [15:39] didrocks: yes we can wait === gatox is now known as gatox_lunch [15:44] thanks ;) [15:49] didrocks, so if I go to devel proposed the rss reader app should be broken, right? [15:51] yes [15:52] sergiusens: yeah, it is, balloons is trying to fix it [15:52] well, the tests should be ... not sure the app exposes any breakage :) [15:57] ogra_, didrocks who do I talk to about stuff stuck in proposed due to dependencies? [15:58] depends [15:59] :) [15:59] whats the issue with the dependencies ? [15:59] if they are stuck, #ubuntu-release, if they are wrong in the package the package maintainer [16:03] #ubuntu-release is generally happy to help you diagnose such things [16:03] ogra_, I'm the mintainer; there's just no android emulator for arm* :-) [16:03] just create one then :P [16:04] so we can run it on the chromebooks :) [16:04] I can't obviously see anything to do with android that's stuck in -proposed === cjohnston changed the topic of #ubuntu-ci-eng to: Ubuntu CI Engineering Team | Vanguard: cihelp | Landing instructions: http://paste.ubuntu.com/6292280/ | Known issues: - === doanac changed the topic of #ubuntu-ci-eng to: Ubuntu CI Engineering Team | Vanguard: doanac | Landing instructions: http://paste.ubuntu.com/6292280/ | Known issues: - [16:26] fginther, doanac: it seems the jenkins intel otto node is down [16:26] Could anyone reanimate it? [16:26] sil2100, looking [16:27] sil2100, oops, left it offline when I was doing the manual lxc update [16:27] sil2100, doanac it's online now [16:29] Thanks :) [16:32] didrocks: are your free for some packaging ACKs? [16:35] kenvandine: hey! Maybe you have some free moments right now? === gatox_lunch is now known as gatox [16:38] ogra_: could you ACK some packaging changes for me before releasing? [16:38] http://q-jenkins.ubuntu-ci:8080/view/cu2d/view/Head/view/Unity8/job/cu2d-unity8-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_unity-mir_0.2+14.04.20140114.1-0ubuntu1.diff <- cmake switch [16:38] sure [16:39] hmpf, i have no vpn set up here [16:39] http://q-jenkins.ubuntu-ci:8080/view/cu2d/view/Head/view/Platform/job/cu2d-platform-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_platform-api_0.20+14.04.20140114.1-0ubuntu1.diff <- test package addition, but pitti seemed to work on that so I say safe ;p [16:39] http://q-jenkins.ubuntu-ci:8080/view/cu2d/view/Head/view/Platform/job/cu2d-platform-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_qtubuntu_0.53+14.04.20140114.1-0ubuntu1.diff <- double build changes [16:39] i cant get to them [16:39] hmmm, let me see if they're on the public jenkins [16:40] Ah, here they are, one moment [16:40] https://jenkins.qa.ubuntu.com/view/cu2d/view/Head/view/Platform/job/cu2d-platform-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_qtubuntu_0.53+14.04.20140114.1-0ubuntu1.diff [16:40] https://jenkins.qa.ubuntu.com/view/cu2d/view/Head/view/Platform/job/cu2d-platform-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_platform-api_0.20+14.04.20140114.1-0ubuntu1.diff [16:40] jenkins.qa.ubuntu.com/view/cu2d/view/Head/view/Unity8/job/cu2d-unity8-head-3.0publish/lastSuccessfulBuild/artifact/packaging_changes_unity-mir_0.2+14.04.20140114.1-0ubuntu1.diff [16:41] Ah, the last one is not there... [16:41] Let me pastebinit [16:42] heh "GNU-based desktops" [16:42] sil2100: in meetings [16:42] ogra_: here's the unity-mir one: http://paste.ubuntu.com/6751346/ [16:43] sil2100, hmm, afaik pitti had issues with the platform-api fix and needed a qemu patch first [16:43] do you know if he fixed that already ? [16:44] sil2100, apart from that packaging wise it looks fine [16:44] ACK [16:44] I don't know, I just know that platform-api works fine on the devices right now [16:45] ogra_: thanks! [16:45] yeah, but it fails the tests in cross envs iirc [16:45] (you cant build it in sbuild cross or pbuilder cross with that) [16:46] ogra_: gnu-based desktops, is that were you cause a stampede to speed up the processing. [16:46] davmor2, heh, likely [16:46] if you get them fast enough you win a stallman for home [16:47] ogra_: no you don't want it to stallman you'll never get it to go again man [16:47] heh, *I* surely dont want a stallman for home [16:47] * ogra_ herad stories [16:47] why is platform-api running tests in cross envs at all? [16:48] cjwatson, ask pitti/tvoss [16:48] usually cross-builders disable tests [16:48] they were the ones complaining about missing qemu syscalls [16:48] ogra_: I don't care enough to chase it down :) [16:48] (which they hit and thus make their tests fail) [16:48] missing qemu syscalls sounds more like PPAs ... [16:49] that too [16:49] our normal cross-building infra these days doesn't involve qemu [16:49] well, pitti was using sbuild i think [16:50] not sure though, we only discussed the qemu patch i gave them [16:50] sbuild disables tests when cross-building [16:50] ah [16:50] assuming the package honours DEB_BUILD_OPTIONS=nocheck [16:56] well, platform-api is blocked for cross-building anyway due to the usual problem with non-trivial toolchain dependencies plus some other random bits of multiarch metadata that I haven't chased down [16:57] then it is fine [16:57] as long as PPAs dont fail [16:59] that's an entirely different question, haven't checked [16:59] of course devirt PPAs won't care about qemu anyway [16:59] didrocks, robru can you check https://code.launchpad.net/~sergiusens/goget-ubuntu-touch/package_arch/+merge/201628 ? [17:01] will be there in 2 minutes [17:02] didrocks, sent along a mail with the updates.. I'm going to keep working on this stuff.. lots to do atm [17:07] sergiusens, in a meeting, will check it in ~30 [17:10] sergiusens, approved [17:11] (trivial enough, especially after seeing the discussion in #ubuntu-release) [17:11] balloons, I ran the clock app in the amulator yesterday, I had no issues [17:11] well, aside from thrashing :-) [17:11] sergiusens, ty. I was going to try again at some point.. I haven't done so with the updates [17:12] sergiusens, actually I was hoping you could try and land the calendar [17:12] you have a maguro right? [17:12] balloons, I have a mako now ;-) [17:13] balloons, maguro is dead, long live mako [17:13] sergiusens, well, whatever: https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/fix-test-timing-issues/+merge/201120 [17:14] balloons, is that you requesting me to check that? :-D [17:15] sergiusens, if you would. If it works for you too, and blast those maguro's anyhow, let's just merge it. [17:15] I need to move on to other things [17:15] balloons, I can test on the emulator as well, it's slow enough :-) [17:16] ty sergiusens [17:16] * balloons crosses fingers [17:17] balloons: excellent! thanks a bunch :) [17:17] sergiusens: feel free to land whatever balloons is giving you if this fix the AP tests flakyness btw [17:29] dobey: any reason why ubuntu-purchase-service is priority extra and not optional? [17:30] no COPYING/LICENSE file in tarball [17:31] robru: I'm going to reject the NEW package, can you get those fixed? (mostly for the missing license file) ^ [17:34] robru: please get those changes in and rebuild a new package + get some ack for the change (only ubuntu-purchase-service) [17:44] didrocks, well dobey did revert all my packaging work. [17:45] robru: which was none of the things didrocks just mentioned [17:45] can you guy get those done and move on, please? ;) [17:45] guys* [17:45] k, i'm submitting a branch. [17:45] thanks! [17:45] didrocks: i copied the debian/ dir from another project that's already in ubuntu and editied, so extra would have come from that [17:46] didrocks: not sure what you mean about the license file and tarball though. [17:46] dobey: no COPYING/LICENSE GPL3 file, better to include it in tarball [17:46] oh, there isn't one in trunk. huh [17:46] ah, it's not in the package I reviewed [17:47] so not sure which version is was based on [17:47] didrocks: right. it's a native package though. so "tarball" confused me :) [17:47] dobey: hum, bzr branch lp:ubuntu-purchase-service [17:47] no COPYING or LICENSE here [17:48] didrocks, https://code.launchpad.net/~robru/ubuntu-purchase-service/didrocks-new/+merge/201635 [17:48] didrocks: right, i just looked [17:48] robru: approved [17:48] robru: once merged, can you kick another one and just publish it? (it's a +1 on the packaging change ;)) [17:48] slow down :) [17:52] dobey, ... no [17:53] yes [17:53] dobey, i think you approved the wrong one... [17:53] no [17:54] the tree contains LGPL-3 code as well, so it needs COPYING and COPYING.LIB [17:54] dobey, in that case, debian/copyright also needs to be updated, to identify where the lgpl code is [17:54] ok [17:55] didrocks: sorry i totally overlooked this. too much going on :) [17:56] dobey, indeed I see a bunch of files by grepping for 'Lesser'. want me to just add it to my merge or are you doing it? [17:56] robru: you can add it to your merge [17:57] dobey, ok [17:57] no point making 2 branches to fix the same thing [17:57] thanks guys, and please fix debian/copyright :) [17:58] (I didn't run license-check -r * --copyright when I saw the missing copyright file) [18:03] dobey, is any of this actually GPL? why don't we just make the whole package LGPL? [18:05] Hi, I made some changes to a branch 5 hours ago and Jenkins hasn't kicked in any ideas wht is going on? https://code.launchpad.net/~andrew-hayzen/ubuntu-ui-toolkit/fix-swipe-delete-001/+merge/199906 [18:05] robru: the qml/UbuntuPurchase.qml is GPL3 [18:05] dobey, ok then. https://code.launchpad.net/~robru/ubuntu-purchase-service/didrocks-new/+merge/201635 [18:05] didrocks, ^ [18:06] now to wait for jenkins to approve it === bfiller is now known as bfiller_afk [18:07] great === alan_g is now known as alan_g|EOD [19:44] cjohnston: any chance you could build flake8 for trusty here? https://launchpad.net/~cjohnston/+archive/flake8 [19:44] cjohnston: oh wait, I see it's in the archive now, nvm. I wonder when that happened [19:44] :-) [19:45] I was lookin, you had me stumped [19:45] I can stop installing it into virtualenvs now :) === bfiller_afk is now known as bfiller [21:59] robru, had you had a chance to happrove my MR? [22:13] sergiusens, before I get any farther along, can you have a peek at https://code.launchpad.net/~nskaggs/phablet-tools/add-lp-branch-support/+merge/201685 and give me your opinion [22:15] balloons, heh, just did ;-) [22:15] added a comment [22:15] balloons, we should migrate all the apps to cmake imo; even if we don't compile anything [22:15] that way we can keep building the deb and the click with one ruleset [22:16] hmm.. [22:17] balloons, give me a couple of slack and I'll propose something you will love [22:17] ;-) [22:17] so, if we migrate to cmake it should build the click apps.. So, the only missing piece is pushing them to the device? [22:18] balloons, yup; and that should be easy enough if we standarize a bit [22:18] sergiusens, as long as I can get the desired workflow I'll be happy [22:18] right.. I thought you might have some ideas.. So show me up :-) [22:18] balloons, one thing that you might be able to help with is; is the way we do testing the way we want to do it; and do we have a migration plan? [22:19] what do you mean "is the way we do testing the way we want to do it?" [22:19] I mean, is everyone sufficiently happy with this mechanism to provision the tests? [22:19] balloons, another thing is, we need to figure out how to use autopilot without installing it [22:19] ahh.. at the moment I don't think provisioning is easy as a normal app dev or test writer [22:20] that's part of the goal here [22:21] balloons, yeah, but do we want to add is as part of the click package? [22:21] balloons, or keep it that way [22:22] balloons, I'll make it easy to provision [22:22] sergiusens, honestly the route I'm proposing still isn't ideal [22:23] Ideally we'd have a simple test runner that supports testing against a device or the emulator with a single switch, and requiring nothing from me except my branch (local or lp ;-) ) [22:24] balloons, that can all be doable; imagine running 'make device-test' [22:24] right.. ideally the app devs would rather have it more integrated into qtcreator [22:25] I assume making it part of the build would make that easier [22:25] balloons, we can externalize it; I can add that to phablet-click-test-setup easily (test provision) [22:27] sergiusens, well, how much hacking time is required? :-) [22:28] balloons, not much; we just need to standarize [22:28] balloons, how about we set some time to chat tomorrow? [22:29] sergiusens, sounds like a plan. I'd like to get this up and running asap. We need an easier way to provision for app devs [22:29] the migration work is just that, but I'm happy to do it if it gets us where we need to be [22:29] balloons, we chat tomorrow; implement that tomorrow night :-) [22:30] balloons, can you set something up and probably invite any other people you think are relevant? [22:30] sergiusens, I'll do so now [22:30] sergiusens, 1500 utc ok for you? [22:30] balloons, yup [22:33] balloons, I'll try and get some notes down to review before then and share on the appointment [22:34] sergiusens, sent, feel free to invite whomever you wish.. [22:43] balloons, ack; I see some heavy weight names there ;-)