=== rogpeppe2 is now known as rogpeppe | ||
gary_poster | hi all! | 13:23 |
---|---|---|
gary_poster | My desktop doesn't appear to be booting | 13:24 |
gary_poster | So I'm trying to figure that out before facing the email wall | 13:24 |
rick_h_ | gary_poster: it's mad you left it alone. Good luck | 13:31 |
gary_poster | :-) thx | 13:33 |
hatch | morning | 13:36 |
gary_poster | morning! | 13:38 |
gary_poster | ok, it seems that the desktop just wanted a good hug | 13:38 |
gary_poster | I picked it up, looked around, out it back down, connected a few wires back, and started it up: | 13:39 |
gary_poster | hello boot screen! | 13:39 |
gary_poster | I'll try hooking it up more fully now... | 13:39 |
rick_h_ | hah | 13:39 |
rick_h_ | hatch: when you get a sec I wanted to see what originally broke things you branch is fixing? | 13:42 |
frankban | morning all, welcome back gary_poster | 13:42 |
gary_poster | thanks frankban :-) | 13:48 |
hatch | rick_h_ https://github.com/hatched/juju-gui/commit/0b5917d9acaaab5f389cd9804423d1caefffdd5e | 13:52 |
gary_poster | ok logging out here to switch to bip on the desktop... | 13:58 |
=== gary_poster|away is now known as gary_poster | ||
rick_h_ | hatch: so is this just that the isLoggedin skipped the old path that would allow it to route? | 14:00 |
gary_poster | so did anyone else get attacked by a killer William Grant Spam monster? | 14:00 |
rick_h_ | gary_poster: I don't think so here | 14:01 |
gary_poster | jujugui who has read dimiter's rewrite proposal and has opinions? there's a meeting going on right now that I'd like you to attend | 14:01 |
hatch | rick_h_ line 903 and 904 is the problem, it's basically formalizing the 'hey you're not logged in' branch | 14:01 |
rick_h_ | hatch: ok, that's what I figured | 14:02 |
gary_poster | hazmat, computer issues, will join mtg asap, and trying to find delegate | 14:02 |
gary_poster | frankban or benji or rick_h_: you willing to be delegate to dimiter rewrite proposal mtg? ^^^ | 14:03 |
hatch | gary_poster I have, as far as opinions.... | 14:03 |
hatch | I have some, but also questions | 14:03 |
gary_poster | hatch, ok, https://plus.google.com/hangouts/_/canonical.com/juju-api pls? | 14:04 |
gary_poster | and thank you. | 14:04 |
rick_h_ | gary_poster: benji is out, I can, but honestly didn't look closely at it as I'm not much of an expert on the old api. | 14:04 |
rick_h_ | and go hatch go | 14:04 |
gary_poster | will be there as soon as chrome is not hanging :-( | 14:04 |
hatch | i'm there | 14:05 |
gary_poster | ty | 14:06 |
frankban | guihelp: I need two reviews + QA for https://codereview.appspot.com/51350044 (quickstart 1.0 rc2 ;-) Anyone available? | 14:09 |
bac | frankban: yes, yes i am. on it. | 14:09 |
frankban | bac: thank you | 14:09 |
gary_poster | hatch, been fascinating so far? :-) | 14:11 |
hatch | hah, nothing new, just chatting about how to deprecate the old one | 14:11 |
gary_poster | :-) k | 14:12 |
bac | frankban: i finished the code review and it looks good. i'm not sure what steps to do for QA. how do i provoke the errors from which you wish to recover? | 15:20 |
bac | gary_poster: sorry for the late notice but i need to be away during our meeting time today. | 15:21 |
gary_poster | ok bac. everything ok? | 15:21 |
bac | gary_poster: yes. | 15:21 |
gary_poster | cool | 15:22 |
frankban | bac: never seen that error myself, rick_h_ already tested it and quickstart no longer hangs. I'd suggest the usual QA just to check everything works (interactive session, bootstrapping an environment, re-opening a bootstrapped environment) | 15:22 |
bac | gary_poster: yeah, i just want to attend a lecture on a 40's era Farm Security Administration photographer. you know, important stuff. :) | 15:23 |
gary_poster | lol | 15:23 |
gary_poster | cool | 15:23 |
bac | frankban: okey doke | 15:24 |
* rick_h_ has super natural breaking powers! | 15:25 | |
frankban | :-) | 15:27 |
bac | frankban: given this bundle on launchpad, what is the correct spelling of the "bundle:" url? https://code.launchpad.net/~bac/charms/bundles/minimal/bundle | 15:30 |
frankban | bac: you can use a "bundle:..." URL or the http(s) location to the YAML file, if your bundle is in jc.com, the bundle page should include the command to deploy it with quickstart | 15:31 |
rick_h_ | frankban: can it load the https of any bundle file? | 15:32 |
hatch | rick_h_ what stupid thing? I don't know how to respond to your last comment lol | 15:33 |
frankban | bac: https://jujucharms.com/fullscreen/search/bundle/~bac/minimal/1/openstack-services/?text=minimal#bws-deploy | 15:33 |
rick_h_ | hatch: chai or whatever is being stupid | 15:34 |
hatch | oh...yeah | 15:34 |
rick_h_ | hatch: it's generaly test tool agner | 15:34 |
rick_h_ | anger | 15:34 |
rick_h_ | ignore me | 15:34 |
frankban | rick_h_: the URL location con point to an arbitrary bundle file if that's the question | 15:34 |
bac | thanks frankban. i forgot about the juju charms deploy instructions. they are great | 15:34 |
rick_h_ | frankban: right, jcastro ^^ should get you close to you git bundle file wishlist | 15:35 |
rick_h_ | jcastro: just have to be the url to the file out of github vs the repo itself | 15:35 |
frankban | rick_h_: the bundle itself for now can only point to charms in the store IIRC | 15:35 |
rick_h_ | frankban: right, but jcastro wants to have bundles themselves in github. To fork/etc I guess | 15:35 |
rick_h_ | and wants to quickstart ...github... | 15:36 |
frankban | rick_h_: that just works I suppose | 15:36 |
rick_h_ | I assume the dream is github:bunlename or something, but just fyi'ing him | 15:36 |
rick_h_ | for some of the stuff that's come up github gists would be cool forkable points for doing a bundle | 15:37 |
rick_h_ | is another 'feature' of that way | 15:37 |
frankban | rick_h_, jcastro: from the quickstart help -> http://pastebin.ubuntu.com/6768505/ | 15:37 |
hatch | hey rick_h_ speed up the CI :P mmmmmmkay | 15:44 |
rick_h_ | hatch: shush, your tests passed yesterday. What do you need now? | 15:44 |
hatch | http://karenjlloyd.com/blog/wp-content/uploads/2008/11/mkay-song-300x174.jpg | 15:44 |
hatch | it to turn green before I shipit | 15:45 |
rick_h_ | it is green | 15:45 |
rick_h_ | All is well — Merged build finished. (Details) | 15:45 |
rick_h_ | "16 hours ago" | 15:45 |
hatch | yeah but maybe it changed! | 15:45 |
rick_h_ | oh, you added comments | 15:45 |
rick_h_ | well in that case wait your 23min | 15:46 |
rick_h_ | 20min | 15:46 |
gary_poster | jujugui, stepping away for a few, so 14 minites till weekly call | 15:47 |
gary_poster | minutes even | 15:47 |
hatch | jujugui call in 4 | 15:56 |
jcastro | frankban, that is quite excellent | 16:03 |
jcastro | I promise I won't tell anyone we can deploy a bundle directly from github | 16:03 |
jcastro | hah just kidding I will tell the world. | 16:03 |
=== rogpeppe1 is now known as rogpeppe | ||
frankban | :-) | 16:34 |
bac | hey frankban, i've done 'sudo juju destroy-environment -e local'. but when i then try to spin up a local env with quickstart i get | 17:11 |
bac | juju-quickstart: error: machine 1 is in an error state: error: container "bac-local-machine-1" is already created | 17:11 |
bac | either a) i don't care or b) use it. right? | 17:11 |
frankban | bac: are you in trusty? | 17:11 |
bac | i am saucy. | 17:12 |
bac | as is my VM | 17:12 |
gary_poster | heh | 17:12 |
frankban | bac: this seems a juju error in handling lxc containers | 17:13 |
frankban | bac: on the other hand it's cool that you actually QAed the problem this branch tries to fix. a machine error does not hangs the application | 17:15 |
frankban | bac: you can try re-destroying the environment, deleting the jenv file in ~/.juju/environments/ and manually killing containers if they are still alive | 17:15 |
bac | frankban: sure | 17:15 |
bac | frankban: yeah, i thought that was funny since i'd asked how to do it. :) | 17:16 |
frankban | heh | 17:16 |
bac | frankban: i have no jenv file | 17:17 |
bac | i tried using lxc-destroy and it said the container was not confined | 17:18 |
frankban | :-/ | 17:20 |
hatch | *sigh* finish expenses....and the site crashes | 17:27 |
bac | frankban: i know you're at EOD/EOW but one quick question. quickstart pretends to have worked, printing | 17:28 |
bac | deploying the bundle openstack-services with the following services: ntp, mysql | 17:28 |
bac | done! | 17:28 |
bac | but those services were not deployed. | 17:28 |
bac | juju status doesn't list them. | 17:28 |
gary_poster | "deploying..."/"Requesting a deployment of..." ? | 17:29 |
bac | gary_poster: good change. but it doesn't look like anything happened | 17:29 |
frankban | gary_poster: yeah that's a good idea, bac: how much time passed? | 17:29 |
bac | frankban: minutes. so it may still be processing them? | 17:30 |
bac | i figured they would show up in 'status' | 17:30 |
frankban | bac: what do you see in https://[GUI URL]/gui-server-info ? | 17:31 |
bac | cool | 17:32 |
bac | {"uptime": 449, "deployer": [{"Status": "completed", "DeploymentId": 0, "Error": "invalid literal for int() with base 10: '1G'", "Time": 1389979445}], "apiversion": "go", "sandbox": false, "version": "0.2.2", "debug": false, "apiurl": "wss://10.0.3.1:17070"} | 17:32 |
frankban | bac: so your deployment completed with an error, you should see an error notification in the GUI | 17:32 |
frankban | bac: a very human friendly error indeed ;-) | 17:33 |
bac | frankban: i'd checked that earlier. no errors | 17:33 |
bac | mem=1G is not ok? | 17:33 |
frankban | bac: right, the deployment was started from quickstart, not from the GUI | 17:33 |
frankban | bac: it seems the deployer requires an int | 17:34 |
bac | that is a bug with the deployer then. | 17:34 |
bac | ok, frankban, so neither the gui nor quickstart noted the error. | 17:35 |
bac | that seems like an issue | 17:35 |
* gary_poster has emails down to < 500. Time for lunch. | 17:36 | |
frankban | bac: is it is, but it's not a quickstart issue. we should improve bundle validation in the guiserver, or in the deployer validation step | 17:37 |
bac | frankban: ok. qa-ok then | 17:38 |
bac | sorry it took so long | 17:39 |
frankban | bac: thank you. did the bundle work without 1G? | 17:39 |
bac | frankban: i haven't tried it yet. | 17:44 |
hatch | lunching | 17:47 |
rick_h_ | gary_poster: so sorry...will take my time on those better in the future | 18:30 |
gary_poster | rick_h_: np! | 18:30 |
gary_poster | rick_h_: thanks for the research! | 18:31 |
* rick_h_ shoe horned what he was reading into past issues and made it all fit. doh | 18:31 | |
rick_h_ | np, happy to add to any confusion wheee | 18:31 |
bac | hi gary_poster, so you'll know i intend to work monday and swap the holiday, maybe for next friday. | 18:32 |
gary_poster | bac, ok cool, thanks for heads up | 18:33 |
bac | you working? | 18:33 |
gary_poster | bac, no, taking Monday off. Kids are off, so it will be better for all concerned (including me) for me to do so also. :-) | 18:33 |
bac | yep | 18:33 |
gary_poster | OK, down to 17 emails, but I actually have to do something about them :-) | 18:43 |
hatch | jujugui the latest chrome devtools reset my config values so if you're having issues with caching, it's possible that it's back on again :/ | 19:32 |
gary_poster | :-/ ack | 19:33 |
hatch | ooo boy this bug is a complicated one | 19:54 |
hatch | aww why are all these things written in Python :P | 19:59 |
hazmat | hatch, :-) http://blog.koehntopp.de/uploads/mapreduce.png | 20:00 |
hatch | hazmat HAHAHA | 20:00 |
rick_h_ | hatch: which things are we referring to? | 20:01 |
hatch | see emails | 20:01 |
rick_h_ | hatch: oh all the charm tools stuff? | 20:02 |
hatch | yeah | 20:02 |
hatch | maybe it's a good way to make me learn more | 20:02 |
rick_h_ | hatch: because it's on the system by default and doesn't need a ppa and most people would rather write python than JS and pypi stays up while npm is going comercial and ... | 20:02 |
rick_h_ | :) | 20:02 |
hatch | oh shit, now you're on the npm going commercial bandwagon too? lol | 20:02 |
hatch | oops I swore | 20:02 |
hatch | haha | 20:03 |
rick_h_ | well, I'm on the wait and see on that. I'm curious how that works out | 20:03 |
bac | wait, we're not supposed to swear? | 20:03 |
rick_h_ | I know the python software foundation has some some of the backing of pypi and such | 20:03 |
hatch | rick_h_ yeah tbh I would have much preferred a foundation to own npm as well | 20:04 |
* gary_poster watches curse police head towards Saskatoon | 20:04 | |
hatch | haha | 20:04 |
hatch | I just wish I could force the node_app charm to go through jshint | 20:05 |
rick_h_ | patch it | 20:05 |
rick_h_ | why not? | 20:05 |
* rick_h_ has done a couple of "pep8 M*@#$#F#@$A#@" pull requests | 20:05 | |
hatch | the latest pull request is a 1200 line diff | 20:06 |
hatch | and there are if() statements written using 3 different syntax's | 20:06 |
hatch | maybe more | 20:06 |
hatch | and one MASSSSSSIVE pyramid of doom | 20:06 |
rick_h_ | lol | 20:07 |
rick_h_ | take it one file at a time? | 20:07 |
rick_h_ | jshint hooks/* and submit that | 20:07 |
rick_h_ | then move on to another folder | 20:07 |
hatch | I'd rather the author fix it before it lands :) | 20:08 |
hatch | marcoceppi am I allowed to add some input on that latest node_app PR? | 20:11 |
rick_h_ | if you've already got 1200 line diff then submit it! :) | 20:11 |
marcoceppi | hatch: yes of course | 20:11 |
hatch | rick_h_ lol I don't have a diff, that's what the current one is | 20:12 |
hatch | marcoceppi ok cool, is the guy who's submitting that PR within the company? or an external contributor? | 20:12 |
marcoceppi | hatch: he works for joyent | 20:13 |
hatch | hmm, he should know about jshint then :P | 20:13 |
rick_h_ | teach don't b#$##@ | 20:13 |
rick_h_ | :) | 20:13 |
marcoceppi | hatch: it is an initial submission still a WIP | 20:14 |
hatch | rick_h_ teach don't beach? | 20:14 |
hatch | :P | 20:14 |
rick_h_ | yea, get off that beach and stop lallygagging around | 20:14 |
hatch | I lost my mouse, kinda irritated about that | 20:14 |
* rick_h_ has never thought about spelling that before | 20:14 | |
rick_h_ | hatch: what kind of mouse? | 20:14 |
hatch | rick_h_ logitech something or other....Iunno the battery lasts for a year and it's sorta ergo | 20:15 |
rick_h_ | lamo | 20:16 |
rick_h_ | lmao that is | 20:16 |
rick_h_ | so it's one of 100 diff mice | 20:16 |
hatch | haha truth! | 20:16 |
rick_h_ | AMZ says "logitech wireless mouse" Showing 1 - 16 of 5,910 Results | 20:16 |
hatch | M510 | 20:17 |
hatch | I think | 20:17 |
hatch | it's still lost somewhere | 20:17 |
hatch | my dog was playing with it, maybe he took it | 20:17 |
rick_h_ | hah | 20:23 |
rick_h_ | thinks he's a cat? | 20:23 |
hatch | haha, well he was pushing it around the couch and now it's gone...suspicious, I think not! | 20:23 |
gary_poster | rick_h_: I don't get any cred for the MI theme? awww.... :-) thanks for voluntering | 20:23 |
gary_poster | will send to Antonio as well | 20:23 |
rick_h_ | gary_poster: I can't keep up. It's friday :) | 20:23 |
gary_poster | :-) | 20:24 |
rick_h_ | and I found my bug...with a one line fix | 20:24 |
gary_poster | heh cool | 20:24 |
rick_h_ | and MORE to test | 20:24 |
rick_h_ | so meh, I give up | 20:24 |
hatch | gary_poster any possibility we can move the 'destroy-service' and 'expose' buttons into the inspector footer so that it's visible on every tab? | 20:24 |
gary_poster | hatch, <shrug> talk to the luca-man. I think it will be a bit awkward myself. for instance, change a value on the config tab, look at the appearing buttons, and then imagine that along with the destroy/expose combo | 20:26 |
hatch | ahh yeah....hmm | 20:26 |
gary_poster | doesn't look to good in my eye, but maybe there's a nice way around it | 20:26 |
gary_poster | too | 20:26 |
hatch | fixed | 20:38 |
hatch | jujugui looking for a review/qa on a trivial fix https://github.com/juju/juju-gui/pull/76 | 20:43 |
* bac heads out to be festive again. | 20:47 | |
rick_h_ | hatch: trade you? https://github.com/juju/juju-gui/pull/77 | 20:47 |
hatch | rick_h_ you left a .only in your tests | 20:48 |
rick_h_ | bah | 20:48 |
hatch | and ok | 20:48 |
hatch | :) | 20:48 |
* rick_h_ runs make lint | 20:48 | |
hatch | rick_h_ now that we don't have lbox I run make lint && make test-debug && make test-prod before PR :) | 20:48 |
rick_h_ | hatch: yea, I was trying to rush to get it up for you to look at so I could do yours and EOD on a nice clean slate | 20:49 |
hatch | heh EOD on time? since when | 20:51 |
hatch | lol | 20:51 |
rick_h_ | been a rough week for that | 20:51 |
rick_h_ | friday! | 20:51 |
rick_h_ | whoa, that's a tall inspector at 2160px browser height | 20:53 |
hatch | lol | 20:54 |
hatch | it will be 100% height in the next design | 20:54 |
hatch | :) | 20:54 |
rick_h_ | hatch: qa fail | 20:54 |
hatch | :( | 20:54 |
hatch | what happened | 20:54 |
rick_h_ | the expose it part of the scroll, but not destroy | 20:55 |
rick_h_ | it hard stops at the end of expose, can't see destory at all until I make the window large enough to not need to scroll | 20:55 |
hatch | hmm | 20:55 |
hatch | can you make sure you're running the new code and not a cache? | 20:56 |
rick_h_ | yea, just clearing now | 20:56 |
hatch | AND if you are - try removing the TB_SPACING that was added and see if you now cannot see the expose button either | 20:56 |
rick_h_ | oh hmm, old code. wtf. Did my qa-pr fail me? | 20:57 |
hatch | *phew* | 20:59 |
rick_h_ | k, qa ok, just no test sad face | 21:00 |
hatch | I was out of ideas beyond a huge refactor branch so I'm glad it was a cache issue haha | 21:00 |
hatch | can you think of a way to test this? | 21:01 |
hatch | I'm open to ideas but anything I can come up with is so dependant on the browser/resolution it's being viewed in | 21:01 |
rick_h_ | can you just setup a div and check the calculated height. Fill it with known content. a 1x1 gif you set a size to | 21:02 |
hatch | hmm | 21:02 |
rick_h_ | well that container doesn't have to be full browser height right? It's not getting window sizes | 21:02 |
rick_h_ | you control container which all the heights are set from | 21:02 |
rick_h_ | not a 5 liner, but seems like it's testable | 21:02 |
hatch | the height calculation is based on the height of the window so that it's full height minus the padding | 21:02 |
rick_h_ | off the cuff | 21:02 |
hatch | could maybe have a container to render it into and calculate off that | 21:03 |
rick_h_ | I don't see window.* in that function | 21:03 |
rick_h_ | right | 21:03 |
rick_h_ | that's what I'm saying | 21:03 |
hatch | var winHeight = container.get('winHeight'), | 21:03 |
rick_h_ | the function is good in that you pass in the known entity | 21:03 |
rick_h_ | right, but container is what you send in | 21:03 |
rick_h_ | you can determine/set that | 21:03 |
hatch | yeah | 21:03 |
hatch | hmm ok | 21:04 |
rick_h_ | sorry, I know it'll be a little pita | 21:04 |
rick_h_ | and maybe not worth it I guess, but seems a chunk of code w/o any tests then if we don't test that at all | 21:04 |
hatch | aybe I can treat it as a functional test and just mock out the stuff and test that the setstyle sends the proper value | 21:04 |
rick_h_ | right, I mean you just made a change where you forced a known 20 * 3 px change | 21:04 |
hatch | ok update the PR that the qa passed and I'll stew on a test for a bit | 21:04 |
rick_h_ | some test should be failing with off by 60 right now | 21:05 |
rick_h_ | PR updated | 21:05 |
hatch | cool thanks, yeah I'll add a test here | 21:09 |
rick_h_ | hatch: going to get the boy from day care. I've got about 8min left on my test run. | 21:12 |
rick_h_ | hatch: if your review is cool and the tests pass can you :shipit: for me please? | 21:12 |
hatch | yup can do | 21:12 |
rick_h_ | ty kind sir | 21:13 |
jcastro | anyone still working? | 22:19 |
jcastro | mhall has some charm deployment questions to for deploying the Ubuntu API website and he needs someone who can walk him through some steps | 22:20 |
=== gary_poster is now known as gary_poster|away | ||
hatch | jcastro I am here | 22:55 |
hatch | jcastro I pinged him | 22:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!