/srv/irclogs.ubuntu.com/2014/01/17/#maas.txt

=== freeflying is now known as freeflying_away
=== freeflying_away is now known as freeflying
=== CyberJacob|Away is now known as CyberJacob
=== CyberJacob is now known as CyberJacob|Away
rvbagmb: care to review: https://bugs.launchpad.net/maas/+bug/1270052 ?08:47
ubot5Ubuntu bug 1270052 in MAAS "Adding an SSH key fails due to a UnicodeDecodeError" [Critical,In progress]08:47
=== mwhudson is now known as zz_mwhudson
gmbrvba, allenap: Free to review a short one? https://code.launchpad.net/~gmb/maas-test/report-machine-info/+merge/20139510:15
allenapgmb: Sure.10:16
gmbTa10:17
gmballenap: Just noticed that lines 9 and 10 of the diff are redundant now.10:28
allenapgmb: I just posted my review, which mentions that, but it’s still a +1.10:30
gmbWinner.10:30
gmballenap: Your 3rd point is a good one, and applies to a couple of bits of maas-test. cases.py is not tested much, and neither is main.py. Sadly, we're doing ZFDD now.10:32
allenapgmb: Oh, you cynic :)10:32
gmballenap: Nah, I got this one from the horse's (well, bigjools's) mouth.10:33
gmbA mighty voice spoke from the clouds.10:33
gmbIt said:10:33
gmb"Where the fuck are you, shortarse? I can't see you 'cos I'm taller than any human being has a right to be."10:33
gmbThus was the message delivered unto his people.10:34
* gmb may be about to have a psychotic break. Apologies.10:34
allenapgmb: I can’t think of anything to reply. I think I’m due a psychotic break now; you’ve induced one.10:39
gmbWhat the hell, it's nearly the weekend.10:39
allenaprvba: I think I might have found a bug in WithMACAddressesMixin.is_valid(). If there’s an error, it does not update the value of `valid` before returning it.13:46
rvbaallenap: definitely looks like a bug14:07
allenaprvba: Okay, I’ll file it.14:07
rvbaallenap: you might as well fix it, it's going to be quick14:07
allenapOr fix it. rvba: Does is_valid() just return a bool?14:07
rvbaYes14:07
=== jam1 is now known as jam
=== CyberJacob|Away is now known as CyberJacob
=== CyberJacob is now known as CyberJacob|Away
allenapgmb: Got time for a short review? https://code.launchpad.net/~allenap/postgresfixture/trusty-compatibility/+merge/20215118:03
allenapgmb: No worries; I’ll selfie it for now.18:04
stokachuanyone around and could help me debug what is going wrong with http://paste.ubuntu.com/6770456/21:31

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!