=== freeflying is now known as freeflying_away | ||
=== freeflying_away is now known as freeflying | ||
=== CyberJacob|Away is now known as CyberJacob | ||
=== CyberJacob is now known as CyberJacob|Away | ||
rvba | gmb: care to review: https://bugs.launchpad.net/maas/+bug/1270052 ? | 08:47 |
---|---|---|
ubot5 | Ubuntu bug 1270052 in MAAS "Adding an SSH key fails due to a UnicodeDecodeError" [Critical,In progress] | 08:47 |
=== mwhudson is now known as zz_mwhudson | ||
gmb | rvba, allenap: Free to review a short one? https://code.launchpad.net/~gmb/maas-test/report-machine-info/+merge/201395 | 10:15 |
allenap | gmb: Sure. | 10:16 |
gmb | Ta | 10:17 |
gmb | allenap: Just noticed that lines 9 and 10 of the diff are redundant now. | 10:28 |
allenap | gmb: I just posted my review, which mentions that, but it’s still a +1. | 10:30 |
gmb | Winner. | 10:30 |
gmb | allenap: Your 3rd point is a good one, and applies to a couple of bits of maas-test. cases.py is not tested much, and neither is main.py. Sadly, we're doing ZFDD now. | 10:32 |
allenap | gmb: Oh, you cynic :) | 10:32 |
gmb | allenap: Nah, I got this one from the horse's (well, bigjools's) mouth. | 10:33 |
gmb | A mighty voice spoke from the clouds. | 10:33 |
gmb | It said: | 10:33 |
gmb | "Where the fuck are you, shortarse? I can't see you 'cos I'm taller than any human being has a right to be." | 10:33 |
gmb | Thus was the message delivered unto his people. | 10:34 |
* gmb may be about to have a psychotic break. Apologies. | 10:34 | |
allenap | gmb: I can’t think of anything to reply. I think I’m due a psychotic break now; you’ve induced one. | 10:39 |
gmb | What the hell, it's nearly the weekend. | 10:39 |
allenap | rvba: I think I might have found a bug in WithMACAddressesMixin.is_valid(). If there’s an error, it does not update the value of `valid` before returning it. | 13:46 |
rvba | allenap: definitely looks like a bug | 14:07 |
allenap | rvba: Okay, I’ll file it. | 14:07 |
rvba | allenap: you might as well fix it, it's going to be quick | 14:07 |
allenap | Or fix it. rvba: Does is_valid() just return a bool? | 14:07 |
rvba | Yes | 14:07 |
=== jam1 is now known as jam | ||
=== CyberJacob|Away is now known as CyberJacob | ||
=== CyberJacob is now known as CyberJacob|Away | ||
allenap | gmb: Got time for a short review? https://code.launchpad.net/~allenap/postgresfixture/trusty-compatibility/+merge/202151 | 18:03 |
allenap | gmb: No worries; I’ll selfie it for now. | 18:04 |
stokachu | anyone around and could help me debug what is going wrong with http://paste.ubuntu.com/6770456/ | 21:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!