[08:47] <rvba> gmb: care to review: https://bugs.launchpad.net/maas/+bug/1270052 ?
[10:15] <gmb> rvba, allenap: Free to review a short one? https://code.launchpad.net/~gmb/maas-test/report-machine-info/+merge/201395
[10:16] <allenap> gmb: Sure.
[10:17] <gmb> Ta
[10:28] <gmb> allenap: Just noticed that lines 9 and 10 of the diff are redundant now.
[10:30] <allenap> gmb: I just posted my review, which mentions that, but it’s still a +1.
[10:30] <gmb> Winner.
[10:32] <gmb> allenap: Your 3rd point is a good one, and applies to a couple of bits of maas-test. cases.py is not tested much, and neither is main.py. Sadly, we're doing ZFDD now.
[10:32] <allenap> gmb: Oh, you cynic :)
[10:33] <gmb> allenap: Nah, I got this one from the horse's (well, bigjools's) mouth.
[10:33] <gmb> A mighty voice spoke from the clouds.
[10:33] <gmb> It said:
[10:33] <gmb> "Where the fuck are you, shortarse? I can't see you 'cos I'm taller than any human being has a right to be."
[10:34] <gmb> Thus was the message delivered unto his people.
[10:34]  * gmb may be about to have a psychotic break. Apologies.
[10:39] <allenap> gmb: I can’t think of anything to reply. I think I’m due a psychotic break now; you’ve induced one.
[10:39] <gmb> What the hell, it's nearly the weekend.
[13:46] <allenap> rvba: I think I might have found a bug in WithMACAddressesMixin.is_valid(). If there’s an error, it does not update the value of `valid` before returning it.
[14:07] <rvba> allenap: definitely looks like a bug
[14:07] <allenap> rvba: Okay, I’ll file it.
[14:07] <rvba> allenap: you might as well fix it, it's going to be quick
[14:07] <allenap> Or fix it. rvba: Does is_valid() just return a bool?
[14:07] <rvba> Yes
[18:03] <allenap> gmb: Got time for a short review? https://code.launchpad.net/~allenap/postgresfixture/trusty-compatibility/+merge/202151
[18:04] <allenap> gmb: No worries; I’ll selfie it for now.
[21:31] <stokachu> anyone around and could help me debug what is going wrong with http://paste.ubuntu.com/6770456/