=== freeflying is now known as freeflying_away === freeflying_away is now known as freeflying === CyberJacob|Away is now known as CyberJacob === CyberJacob is now known as CyberJacob|Away [08:47] gmb: care to review: https://bugs.launchpad.net/maas/+bug/1270052 ? [08:47] Ubuntu bug 1270052 in MAAS "Adding an SSH key fails due to a UnicodeDecodeError" [Critical,In progress] === mwhudson is now known as zz_mwhudson [10:15] rvba, allenap: Free to review a short one? https://code.launchpad.net/~gmb/maas-test/report-machine-info/+merge/201395 [10:16] gmb: Sure. [10:17] Ta [10:28] allenap: Just noticed that lines 9 and 10 of the diff are redundant now. [10:30] gmb: I just posted my review, which mentions that, but it’s still a +1. [10:30] Winner. [10:32] allenap: Your 3rd point is a good one, and applies to a couple of bits of maas-test. cases.py is not tested much, and neither is main.py. Sadly, we're doing ZFDD now. [10:32] gmb: Oh, you cynic :) [10:33] allenap: Nah, I got this one from the horse's (well, bigjools's) mouth. [10:33] A mighty voice spoke from the clouds. [10:33] It said: [10:33] "Where the fuck are you, shortarse? I can't see you 'cos I'm taller than any human being has a right to be." [10:34] Thus was the message delivered unto his people. [10:34] * gmb may be about to have a psychotic break. Apologies. [10:39] gmb: I can’t think of anything to reply. I think I’m due a psychotic break now; you’ve induced one. [10:39] What the hell, it's nearly the weekend. [13:46] rvba: I think I might have found a bug in WithMACAddressesMixin.is_valid(). If there’s an error, it does not update the value of `valid` before returning it. [14:07] allenap: definitely looks like a bug [14:07] rvba: Okay, I’ll file it. [14:07] allenap: you might as well fix it, it's going to be quick [14:07] Or fix it. rvba: Does is_valid() just return a bool? [14:07] Yes === jam1 is now known as jam === CyberJacob|Away is now known as CyberJacob === CyberJacob is now known as CyberJacob|Away [18:03] gmb: Got time for a short review? https://code.launchpad.net/~allenap/postgresfixture/trusty-compatibility/+merge/202151 [18:04] gmb: No worries; I’ll selfie it for now. [21:31] anyone around and could help me debug what is going wrong with http://paste.ubuntu.com/6770456/