| === duflu_ is now known as duflu | ||
| === daek_ is now known as Daekdroom | ||
| karni | https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-grid/+merge/202593 | 03:53 |
|---|---|---|
| karni | https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-filtergrid/+merge/202594 | 03:53 |
| * karni eod | 03:59 | |
| mzanetti | didrocks: hey, just writing the test plan for unity8 | 09:15 |
| mzanetti | didrocks: "Ensure that all AP tests are passing." | 09:15 |
| mzanetti | can't we have that automated? | 09:15 |
| didrocks | mzanetti: there is andy's job I mentionned yesterday (ping doanac once he's around on the CI), it's a self-service testing | 09:16 |
| didrocks | mzanetti: but for the rest, we need the CI team to provide an automated service for it | 09:16 |
| didrocks | so, please write your queries down ;) | 09:16 |
| mhr3 | Cimi, ping? | 09:16 |
| mzanetti | where? | 09:16 |
| didrocks | mzanetti: I guess email ev, asac and I | 09:17 |
| mzanetti | ok | 09:17 |
| didrocks | (well, just CC me, I'm not in the CI team or in that chain of operations ;)) | 09:17 |
| Trendal | . | 09:38 |
| Trendal | yo | 09:40 |
| Cimi | mhr3, pong | 09:40 |
| mhr3 | Cimi, just wondering, you do know about the design spec for the preview components, right? | 09:41 |
| Cimi | there is a doc | 09:41 |
| Trendal | wondering if anyone can point me in the way of getting 3 monitors going. I tried and failed again. | 09:42 |
| mhr3 | paulliu, you saw the doc as well, right? | 09:42 |
| === rachelliu_ is now known as rachelliu | ||
| tsdgeos | and otto is broken again | 10:18 |
| * tsdgeos goes to the crying corner | 10:19 | |
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| mhr3 | sil2100, hey, any idea what this is about? https://launchpadlibrarian.net/163037120/buildlog.txt.gz | 11:08 |
| sil2100 | mhr3: hi! Is it reproducible? | 11:12 |
| mhr3 | sil2100, yes, retried it now, just got a mail that it failed | 11:12 |
| tsdgeos | mhr3: do you know what i need to run the unity-scope-tool ? demo-stuff ppa and some registry stuff i remember? | 11:14 |
| mhr3 | didrocks, you're bzrlib guru, seen something like that before ^^^? | 11:14 |
| didrocks | mhr3: hum, this is bzr-builder itself. I got some in the paste and never got that worked done. That's one of the reason I enforce split mode and so, don't use recipes | 11:15 |
| === _salem is now known as salem_ | ||
| === alan_g is now known as alan_g|afk | ||
| dandrader | tsdgeos, are those common failures that happen on many MPs? https://code.launchpad.net/~dandrader/unity8/draghandle_lp1269022/+merge/202484/comments/472332 | 11:57 |
| paulliu | mhr3: yes. | 12:00 |
| === alan_g|afk is now known as alan_g | ||
| tsdgeos | dandrader: otto is silly | 12:05 |
| tsdgeos | fails, then works, then fails again | 12:05 |
| tsdgeos | noone knows why | 12:05 |
| tsdgeos | dandrader: at the moment we are in the fail stage | 12:05 |
| mzanetti | Cimi: hi. You have been testing the side stage stuff lately, right? | 12:08 |
| mzanetti | Cimi: if you launch a sidestage app on the tablet, does that work properly? | 12:09 |
| dandrader | tsdgeos, btw, would you have time to review it? https://code.launchpad.net/~dandrader/unity8/draghandle_lp1269022/+merge/202484 | 12:11 |
| tsdgeos | sure | 12:17 |
| Cimi | mzanetti, yes | 12:44 |
| Cimi | mzanetti, it works | 12:44 |
| Cimi | mzanetti, not 100% fine but runs | 12:44 |
| karni | tsdgeos: Added comment - https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-grid/+merge/202593 | 12:44 |
| mzanetti | Cimi: here, if I have only one side stage app running, the main stage is black, and swiping it to the right keeps the app where it is | 12:45 |
| karni | tsdgeos: Any hints how would you unit test that? | 12:45 |
| tsdgeos | karni: but compile unity8 trunk | 12:46 |
| tsdgeos | and you'll see the bug is not there | 12:46 |
| Cimi | mzanetti, yes, mine stage is black | 12:46 |
| tsdgeos | karni: someone changed that made stuff be not centered | 12:46 |
| karni | tsdgeos: The code was wrong, mathematically. I don't understand how that would be centered in unity8 without that chage :O :S | 12:47 |
| karni | *change | 12:47 |
| tsdgeos | karni: well, just look at the phone, it is centered | 12:47 |
| karni | tsdgeos: Do you mean latest trusty-proposed? | 12:48 |
| tsdgeos | yes | 12:48 |
| tsdgeos | without demo-stuff | 12:48 |
| karni | tsdgeos: It's not. That's where the screenshots came from. I flashed it before applying demo-stuff and applying them. | 12:48 |
| karni | oh | 12:48 |
| karni | now were getting somewhere | 12:48 |
| tsdgeos | that's not what the comment says | 12:49 |
| karni | tsdgeos: What did you mean by that last sentence? | 12:51 |
| tsdgeos | your comment says | 12:51 |
| tsdgeos | "The problem exists in both. | 12:51 |
| tsdgeos | Screenshots above show latest trusty-proposed with demo-stuff ppa applied. | 12:51 |
| tsdgeos | Screenshots below show same problem in unity-scope-tool:" | 12:51 |
| tsdgeos | that is both have demo-stuff applied, no? | 12:52 |
| karni | tsdgeos: Correct | 12:52 |
| karni | well, if you consider unity-scope-tool having demo-stuff applied (you know what I mean), then yes | 12:52 |
| tsdgeos | well, unity-scope-tool is only in new-scopes which is what demo-stuff gives you | 12:53 |
| tsdgeos | so yes, i consired it the same | 12:53 |
| karni | right | 12:53 |
| karni | FTR just confirmed with Katie left alignment wasn't intentional. | 12:53 |
| karni | tsdgeos: So you're saying I should flash clean image of trunk, and check it out? | 12:53 |
| tsdgeos | yes and no | 12:54 |
| tsdgeos | you can't run unity-scope-tool in "plain" unity8 | 12:54 |
| tsdgeos | but what "yes", if you run unity8 and check the default dash scopes | 12:54 |
| tsdgeos | that have 3 columns in the grid | 12:54 |
| tsdgeos | they are perfectly aligned | 12:54 |
| tsdgeos | karni: no need to flash the phone, just run it on your desktop | 12:55 |
| * karni investigates | 12:56 | |
| tsdgeos | lunch, back later | 12:56 |
| === alan_g is now known as alan_g|lunch | ||
| === dandrader is now known as dandrader|afk | ||
| Wellark | Cimi: you pinged me yesterday | 13:37 |
| Cimi | Wellark, yup | 13:37 |
| Cimi | Wellark, I am fine at the moment :) | 13:37 |
| Wellark | I assume you are trying to write an AP test for connecting to a wifi network | 13:37 |
| Wellark | I would advice against it ATM, it's way too complicated to do properly | 13:38 |
| Wellark | connecting to a wifi network requires actual HW to be available | 13:39 |
| Wellark | or you have to mock all the relevant network-manager classes | 13:39 |
| Wellark | I will get there eventually, but blocking mir merges just for that AP test is IMO unreasonable | 13:39 |
| === dandrader|afk is now known as dandrader | ||
| Wellark | Cimi: ^ | 13:40 |
| Cimi | Wellark, there is a mock | 13:40 |
| Cimi | Wellark, python-dbusmock | 13:40 |
| Wellark | Cimi: which handles secret agents, etc correctly? | 13:41 |
| Cimi | Wellark, don't know | 13:43 |
| Cimi | Wellark, let's move to ubuntu-touch | 13:43 |
| Cimi | Wellark, ask pitta there | 13:43 |
| Cimi | Wellark, pitti | 13:43 |
| === alan_g|lunch is now known as alan_g | ||
| tsdgeos | karni: did you run trunk unity8 on your desktop? | 13:56 |
| karni | tsdgeos: yes. and I think it's related to delegate size, but I haven't confirmed that yet. I'm adding tests for collapsedRowCount in FilterGrid. | 13:57 |
| tsdgeos | cool | 13:57 |
| tsdgeos | karni: do you think you could try to do this work directly over trunk instead of over the new-scopes branch? | 13:57 |
| karni | tsdgeos: I asked Scott if he has his scope working with the old API. If he doesn't, I'd have to dedicate (significant?) time reproducing the problem on trunk. | 13:59 |
| karni | But I understand where your question comes from. | 13:59 |
| tsdgeos | karni: but why would this be scope dependant? | 13:59 |
| tsdgeos | scopes just give data | 13:59 |
| tsdgeos | the grid view layout should be the same for all, no? | 13:59 |
| karni | tsdgeos: It should. Let me rephrase that. I think it's actually the delegate size that influences the spacing/marings. Because they're small in trunk, one can't reproduce the issue. | 14:00 |
| karni | They're significantly larger in new unity8, thus easily reproducible. | 14:00 |
| karni | Yes, grid view should be same in both. | 14:01 |
| tsdgeos | karni: but you could still reproduce it in a test | 14:01 |
| karni | tsdgeos: I'll try that | 14:01 |
| tsdgeos | since there you can set any size for the delegates you want | 14:01 |
| karni | perfect | 14:01 |
| karni | tsdgeos: Is it legal for me to change API of qml/Component/FilterGrid? i.e. I believe 'collapsedRowCount' (which is settable) should not reflect real collapsedRowCount, when the model.count would simply not fill up the visible rows when collapsed. In other words - either I would introduce "maxCollapsedRowCount" and use collapsedRowCount to indicate *real* value of rows, OR use 'collapsedRowCount' as is (no API change) and internally keep a ... | 14:15 |
| karni | ... smaller or equal value to collapsedRowCount elsewhere. | 14:15 |
| karni | I hope it was clear what I said. | 14:15 |
| tsdgeos | karni: i am not sure :D | 14:17 |
| karni | I see. | 14:17 |
| tsdgeos | karni: i guess it should be 1 instead of 2 when there's not enough items | 14:17 |
| karni | That's right | 14:17 |
| tsdgeos | but probably ask katie about it? | 14:17 |
| karni | or 2 instead of 3 if there's not enough items | 14:17 |
| karni | tsdgeos: Don't get me wrong. It's not a design decision - if we have "collapsedRowCount: 3" (say, 2 columns) and we have 2 items, it's clear we just display 2 items instead of 2 items and 4 blank spaces (2 empty rows) | 14:18 |
| karni | What I mean is, the problem appears when there's only 2 elements in a filter grid that specifies collapsedRowCount: 2 | 14:18 |
| karni | which is more than the model contains, and UI goes nuts | 14:19 |
| tsdgeos | i got lost :D | 14:19 |
| karni | though - I still need to reproduce that. | 14:19 |
| karni | tsdgeos: quick mumble? | 14:19 |
| tsdgeos | sure, give me a sec | 14:19 |
| karni | thanks. 1 min, be right there | 14:19 |
| * karni is there, not sure which room to choose haha | 14:20 | |
| karni | tsdgeos: small success. FilterGrid goes nuts also in testFilterGrid, when I set maximumNumberOfColumns to 2 instead of 3, the layout goes from 3 columsn to 1 (!). So I guess I'm getting somewhere. | 14:31 |
| tsdgeos | cool \o/ | 14:32 |
| tsdgeos | Cimi: standup? | 14:32 |
| karni | tsdgeos: That's regarding the rendering bug (latter MP), not the grid spacing, just yet. | 14:32 |
| tsdgeos | one at a time! | 14:32 |
| karni | inded | 14:32 |
| karni | *indeed :D | 14:32 |
| karni | Cimi: can you stay after standup for a moment? | 14:42 |
| elopio | can I get a quick review for a one-line change? | 14:45 |
| elopio | https://code.launchpad.net/~elopio/unity8/wait_for_category/+merge/202523 | 14:45 |
| tsdgeos | elopio: want me to add you to the google calendar standup invite? | 14:46 |
| elopio | tsdgeos: kevin already added me. | 14:46 |
| tsdgeos | ah | 14:46 |
| tsdgeos | okidkoi | 14:46 |
| elopio | mzanetti: can't we have autolanding for trunk, and then manual promotion from trunk to the current version? | 14:48 |
| mzanetti | elopio: no | 14:48 |
| elopio | it sounds terrible that for a branch like mine, your machine will be stuck running for 3 hours. | 14:49 |
| mzanetti | elopio: I know | 14:49 |
| tsdgeos | mzanetti: so you get to dry-run the manual-landing with https://code.launchpad.net/~elopio/unity8/wait_for_category/+merge/202523 :D | 14:49 |
| * tsdgeos hides | 14:49 | |
| * mzanetti hides too | 14:49 | |
| elopio | where should I complaint? didrocks? | 14:49 |
| mzanetti | elopio: I think asac | 14:49 |
| mzanetti | tsdgeos: that commit is for autopilot. we don't need it any more :P | 14:50 |
| elopio | I'll find some more townsmen in rage and go to him with torches. | 14:52 |
| mzanetti | didrocks: what are the MP guidelines in order to set the "Ready" field to yes? | 14:57 |
| mzanetti | ah found it. nvm | 14:58 |
| mzanetti | elopio, tsdgeos: does the branch comply with this checklist? https://wiki.ubuntu.com/Process/Merges/Checklists/Common | 14:59 |
| tsdgeos | it's too long | 14:59 |
| tsdgeos | i'm going to say no | 14:59 |
| tsdgeos | :D | 14:59 |
| mzanetti | when it is, set the ready field in here to yes and come back to me: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AuDk72Lpx8U5dFlCc1VzeVZzWmdBZS11WERjdVc3dmc&usp=drive_web#gid=0 | 14:59 |
| elopio | yeah, no. It's not in sync with trunk because it cleanly merges into it. | 14:59 |
| elopio | mzanetti: I'm updating... | 14:59 |
| tsdgeos | so we need to have an arhmf chroot now? | 14:59 |
| tsdgeos | awesome | 14:59 |
| tsdgeos | why have automatic testing | 15:00 |
| tsdgeos | when you can force everyone to waste his time | 15:00 |
| tsdgeos | this is nuts | 15:00 |
| karni | mhr3: available for quick hangout? | 15:03 |
| elopio | Cimi: I've been reading the autopilot code for indicators. Let me know if you need a hand with that. | 15:06 |
| Cimi | elopio, thanks in case | 15:08 |
| tsdgeos | pete-woods: ping | 15:24 |
| pete-woods | tsdgeos: hi | 15:27 |
| tsdgeos | pete-woods: just wanted to make sure i added a comment in https://bugs.launchpad.net/libhud-qt/+bug/1271036 in case you were working in a fix | 15:27 |
| ubot5 | Ubuntu bug 1271036 in libhud Qt "libhud-qt segfault when building on amd64 against Qt 5.2" [Critical,New] | 15:28 |
| === om26er is now known as om26e | ||
| === om26e is now known as om26er | ||
| === dandrader is now known as dandrader|lunch | ||
| pete-woods | tsdgeos: I hadn't actually noticed that one, thanks for sorting it! | 15:31 |
| pete-woods | tsdgeos: I presumably would realistically have to wait for some new release of Qt there, though! | 15:32 |
| pete-woods | ? | 15:32 |
| tsdgeos | pete-woods: you just get Mirv to distro-patch the patch | 15:33 |
| pete-woods | tsdgeos: ah, cool, will do that then! | 15:33 |
| pete-woods | thanks again! | 15:33 |
| tsdgeos | yw | 15:33 |
| pete-woods | tsdgeos: just worked out that Mirv = Timo :$ | 15:38 |
| tsdgeos | he he | 15:38 |
| tsdgeos | nicks and names | 15:39 |
| tsdgeos | that big first world problem :D | 15:39 |
| pete-woods | :) | 15:39 |
| tsdgeos | add faces into the mix | 15:39 |
| tsdgeos | and i'm lost | 15:39 |
| pete-woods | yes, I know what you mean | 15:39 |
| pete-woods | even when you've spoken on a hangout | 15:39 |
| pete-woods | tsdgeos: also, thought I'd let you know that progress has been made on the quit action | 15:41 |
| tsdgeos | pete-woods: okidoki | 15:41 |
| pete-woods | with any luck, the unity8 side should need no changes | 15:43 |
| === alan_g is now known as alan_g|tea | ||
| pete-woods | just need to do some patching up inside the uitk to listen to a "quit" signal | 15:43 |
| tsdgeos | pete-woods: it will need for sure, the buttons in the hud bar are hardcoded :D | 15:45 |
| tsdgeos | and i guess they want the button back | 15:46 |
| tsdgeos | not just when you search for quit | 15:46 |
| pete-woods | tsdgeos: there should still be a "quit" labelled button in the toolbar | 15:48 |
| tsdgeos | no i killed that long time ago | 15:49 |
| pete-woods | okay, fair enough | 15:49 |
| tsdgeos | so i need to readd it | 15:49 |
| tsdgeos | and make sure it calls whatever you need on it | 15:49 |
| pete-woods | the API should be exactly the same at any rate | 15:49 |
| tsdgeos | cool | 15:49 |
| pete-woods | in the new HUD release, I've also included the Qt API, in-case you're interested | 15:50 |
| pete-woods | so if you wanted, you could just hook that straight into the QML, instead of using the one in unity8 | 15:51 |
| pete-woods | I've trimmed off anywhere it exposed dee, and that sorta thing | 15:52 |
| === alan_g|tea is now known as alan_g | ||
| mhr3 | karni, i am now | 15:53 |
| tsdgeos | pete-woods: cool, i'll have a look | 16:01 |
| pete-woods | tsdgeos: the plan is really to make the client library simpler / more reliable - I'll probably just made it a pure Qt lib once it's in use | 16:02 |
| karni | mhr3: join me? :) https://plus.google.com/hangouts/_/72cpi855g63gciccj1rugpifuc | 16:09 |
| kgunn | elopio: curious...do you have a bug ref for the new AP test for " install a click app with no u1 account associated" | 16:35 |
| === dandrader|lunch is now known as dandrader | ||
| mhall119 | Saviq: are you going to give an update on Unity8 progress in the UE Live call in an hour? | 16:40 |
| mhr3 | he's on holiday | 16:41 |
| mhall119 | :( | 16:48 |
| mhall119 | I'll get him next week then | 16:48 |
| === alan_g is now known as alan_g|EOD | ||
| === dandrader is now known as dandrader|bbl | ||
| kgunn | mterry: ping | 19:21 |
| mterry | kgunn, hello | 19:21 |
| === dandrader|bbl is now known as dandrader | ||
| elopio | kgunn: no, that's just on my whiteboard. Do you need a bug for it? | 20:58 |
| kgunn | elopio: no, its ok...was just cross referencing | 20:59 |
| kgunn | on some stuff, saying it is dependent that we provide those tests first | 20:59 |
| elopio | kgunn: also, you know you can't install an app without u1 account, right? | 21:00 |
| elopio | kgunn: let me file the bug... | 21:00 |
| kgunn | elopio: ok, " you know you can't install an app without u1 account".... so are you supposed to be ? | 21:00 |
| elopio | kgunn: no, you shouldn't. | 21:01 |
| elopio | I'm just saying, nevermind. | 21:01 |
| elopio | kgunn: https://bugs.launchpad.net/ubuntu/+source/unity-scope-click/+bug/1271722 | 21:04 |
| ubot5 | Ubuntu bug 1271722 in unity-scope-click (Ubuntu) "missing autopilot test: try to install an app without u1 account" [High,In progress] | 21:04 |
| kgunn | elopio: hey thanks man | 21:04 |
| === seb128_ is now known as seb128 | ||
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!