=== chriadam is now known as chriadam|away [07:45] Good morning all; happy Friday and happy Belly Laugh Day! :-D [08:03] good morning === luke is now known as Guest43582 [08:56] mzanetti, morning! For the hack days starting today, I'm trying to make sure the po/reminders-app.pot file is up to date, but I'm not very familiar with cmake, tbh. Is there a way I can run cmake to update that file only, instead of having to build the whole source tree? [09:20] dpm: no, there isn't atm [09:23] mzanetti, ok, thanks. It seems that the current rule to build the .pot file has no effect as it's missing the list of files to extract translations from. Would something along these lines help? -> http://pastebin.ubuntu.com/6807439/ (I need to check if the glob is recursive and if there is a better way to specify the path to the QML files) [09:28] ok, seems GLOB_RECURSE is my friend === mpt_ is now known as mpt [09:44] Hi, I am new to core-app. Any place to start work on? [09:46] Guest___: hi there! [09:46] Guest___: what's your area of interest? [09:47] app or language? [09:48] either/both [09:49] I can do both qml and c++. I want to work on music app today. [09:49] ok, do you have a development environment setup? [09:50] Do we do it on phone or desktop [09:50] You can develop on the desktop and test both on desktop and device [09:51] I have the environment setup already. [09:52] Hi everybody! Just a few question: I need to sign the Contributor Agreement, who's the Canonical Project Manager that I nedd to add in the form? Is there any roadmap for the Music App today? [09:52] stefano92100: me, Alan Pope. [09:53] Thanks, so do I just need to add your name? [09:53] yeah [09:53] they know who i am ☻ [09:54] stefano92100 / Guest___: dpm and I are having a meeting in a moment to make sure we have things for you. will ping you shortly. [09:54] in the meantime, there's always the bugs already filed.. https://bugs.launchpad.net/music-app/+bugs?orderby=-id&start=0 [09:56] I'm sure they know :D Anyway, yesterday I was testing the music app, I found some problems that aren't filed [09:58] morning stefano92100! Please make sure you file them at https://bugs.launchpad.net/music-app/+filebug [09:58] oh, awesome, get them filed and ping me and I can confirm them [10:00] Guest___, a good place to start is by picking a small bug and trying to fix it. Do you want to choose one from this list https://bugs.launchpad.net/music-app/+bugs?field.tag=bitesize and start working on it? [10:00] dpm: Sure [10:02] awesome :) [10:02] How to import songs on desktop? [10:03] Guest___, it should work automatically for you if you are in Ubuntu 13.10 or Ubuntu 14.04 - if it doesn't work, let me know [10:03] Guest___, there is a service called mediascanner that imports your music in the background [10:04] Good Hack Days to all :) [10:04] dpm: Operation failed Cannot open media index params at ""/home/luke/.cache/mediascanner"": g-file-error-quark(4): No such file or directory [10:16] popey: did it. I've just send one for now, because others were just related to the design that seems not to fit well on a tablet. [10:17] stefano92100: thanks! [10:23] stefano92100, awesome, thanks! Feel free to file the other design bugs too [10:23] hey WebbyIT, happy Hack Days to you too! :-) [10:28] ok [10:48] mzanetti, when you've got a minute, could you review https://code.launchpad.net/~dpm/reminders-app/update-translations/+merge/203030 - it's a trivial one to update translations [11:29] dpm: left 2 comments here: https://code.launchpad.net/~dpm/reminders-app/update-translations/+merge/203030 [11:37] mzanetti, thanks, looking at it now === _salem is now known as salem_ [11:44] dpm: ah one more note: The "attach" button does only pictures right now, but the code (and evernote) would allow to attach any file [11:44] dpm: so I'm not sure it should be named "Attach picture" [11:46] mzanetti, yeah, I agree with you, although perhaps we should leave it as picture until we have support for other types of files? Btw, what would be needed to attach other files? Content Hub support for File Manager? [11:47] dpm: I'd say just content hub in general [11:47] dpm: we could also attach music files from the music app for example [11:48] mzanetti, yeah, so we'd have to make each app a provider, right? (not sure about the terminology there) [11:49] so music app for media files, doc viewer for PDFs, File Manager for everything else... [11:49] dpm: don't know exactly what it takes... but yeah. I assume once an app registers something to export, it'll show up in there. [11:49] dpm: from the reminders app we'd just need to change ContentType from Pictures to Any or the like [11:49] apart from a few more fixes needed in the plugin (e.g. mime type detection) [11:50] so far I only check for jpeg and png [11:50] ok [11:51] mzanetti, the "too long strings" for actions should rather be an SDK bug, but I'll work around it by calling them "Attach" and "Shot" [11:52] thanks for the review! === MacSlow is now known as MacSlow|lunch [12:25] mzanetti, updated the MP with the fixes. When you've got a minute, could you re-review? https://code.launchpad.net/~dpm/reminders-app/update-translations/+merge/203030 [12:26] dpm: bzr push ;) [12:27] mzanetti, hm, I did, it should be up to date on r33, let me check... [12:28] dpm: still on r31 here and bzr pull does nothing [12:29] mzanetti, argh, bzr push :parent pushed to trunk! [12:29] bollocks [12:30] mzanetti, the MP should now be up to date at least [12:30] dpm: :D [12:31] dpm: I was going to approve anyways... [12:31] dpm: so consider it approved and merged [12:31] mzanetti, thanks :) [12:33] ok, we're all set for translations now: https://translations.launchpad.net/reminders-app [12:35] nik90: hi, so, I have ~20 mins before my meeting starts, do you have the Qs for the AlarmAPI? [12:35] zsombi: yes [12:36] nik90: shoot then [12:36] zsombi: me and popey noticed that when we save an alarm, it doesn't appear in the alarm list until 10-15 mins later or only after we restart the phone. Is this an issue with the EDS - Alarms API communication? [12:37] nik90: I see it as a problem of EDS: the Alarm API sends it straight, so if it would be the problem of the API, then a consecutive restart of the app (not the phone) should bring it in. [12:38] zsombi: okay, in that case I will report a bug against EDS and ask renato to take a look at it. [12:39] nik90: yep [12:39] zsombi: I heard that you are working on the snooze feature for Alarms API v2.0. Considering that the indicator-datetime patch is planned to land next week, would it be possible to focus the efforts first on clearing up any issues with alarms API so that the basic functioning of Alarms is perfect. [12:41] nik90: my network is just crap... [12:41] nik90: anything else? [12:42] zsombi: 1 last question [12:42] I heard that you are working on the snooze feature for Alarms API v2.0. Considering that the indicator-datetime patch is planned to land next week, would it be possible to focus the efforts first on clearing up any issues with alarms API so that the basic functioning of Alarms is perfect. [12:42] some issues were like I mentioned before, 1. Switching an alarm on/off results in it being immediately reverted. This only happens sometimes but requires testing and needs a fix. [12:42] 2. Deleting an alarm does not update the alarm manager count [12:43] nik90: Alarm API 2.0 is on hold till we get all Qt5.2 issues cleared [12:43] zsombi: ok. that's fine by me [12:43] nik90: these seme to be issues with the EDS, so we need to get together with renato to solve these [12:43] nik90: as it works smoothly with Memory backend [12:44] zsombi: I already reported a bug about the delete alarm issue. But I am unable to reproduce the switch issue reliably [12:44] nik90: and renato suggested that I should concentrate on that as it should be completely the same with EDS... but it is apparently not [12:44] nik90: can you repro it unreliably on desktop? [12:44] zsombi: ok, in that case, I will try to contact renato and see where it leads [12:45] zsombi: the delete issue I can reliably reproduce on the phone and the desktop [12:45] zsombi: the switch issue happens sometimes on the phone and desktop. I do not have a 100% sure way of reproducing it [12:45] nik90: if yes, try to use Memory and not the EDS, and if still behaves badly, it's in Alarm [12:45] zsombi: Memory? [12:46] nik90: you can force Memory backend either by removing EDS support from your desktop, or by altering Alarm backend [12:47] zsombi: is there any special package I need to install or would removing EDS plugin alone suffice? [12:48] nik90: removing EDS plugin would be enough [12:48] zsombi: alrite, I will give that a try [12:48] nik90: ok.. and if you see it happening, file a bug to Alarm API, otherwise it should be synced with EDS [12:48] zsombi: ok [12:48] need to move now to a place where I have more reliable connection [12:49] zsombi: that was it. thnx for your time. [12:49] nik90: you're most welcome :) [12:49] nik90: any time :) [12:59] I am fixing Bug #1272113 of music-app and got confused with the description. Does that mean every time we enter the songsList, it should show the top instead of the currently played file. [12:59] Launchpad bug 1272113 in Ubuntu Music App "Genre and Playlist sheets skip currently playing/paused song if it's in the list" [Low,Triaged] https://launchpad.net/bugs/1272113 === MacSlow|lunch is now known as MacSlow [13:11] Guest___, let me have a look... [13:16] Guest___, yes, that's it. When you click on a genre, the list shown should start at the top [13:19] dpm, removing three lines of coode will fix the problem. Is this a new design decision [13:20] Guest___, I think we're fine to go ahead: one of the developers proposed and I agree with that too, so we've got consensus :) [13:21] renato: how do I report bugs on EDS? I noticed that https://launchpad.net/qtorganizer5-eds doesn't allow reporting bugs. [13:22] renato: Is there any other launchpad project for it? [13:22] nik90, perhaps https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds ? [13:22] (i.e. reporting against the source package) [13:23] dpm: ah that works [13:23] nik90, ok cool, but renato should probably confirm where he looks at the bugs [13:24] dpm: I will just report them for now and ping him the bug links [13:24] sounds good! [13:25] hackday \o/ [13:26] ahayzen: :) [13:29] hey ahayzen o/ [13:29] dpm, o/ [13:31] Guest___, ahayzen and danielholm are music app developers, so if you've got any further questions about the bug you're fixing, they can probably help you [13:32] vthompson, danielholm, o/ [13:32] ahayzen: hey! [13:32] danielholm, hows things? [13:32] ahayzen: absolutely lovely. how about you? [13:33] danielholm, yeah good thanks, just trying to figure out binding loops :/ [13:33] ahayzen: sounds interesting ;) I'm in class :) [13:33] danielholm, hehe [13:36] ahayzen: so what are you trying to achieve? [13:36] danielholm, i'm trying to get the U1DB code to be in a state to be pushed up, obviously not fully working due to issues upstream but at least visible to others [13:37] ahayzen: okey. what is the issue upstream? [13:38] danielholm, me and nik90 found some bugs/missing features tht we'll need [13:38] ahayzen: btw, I noticed that stuart reported some more bugs upstream [13:38] Hi all :) [13:38] PaoloRotolo: hey paolo [13:38] Hi nik90 :) [13:38] nik90, u got any links? i saw his blog post [13:38] ahayzen: aha ok. nice to see those changes land then, I can imagine? [13:38] ahayzen: hopefully we can expect fixes soon [13:38] ahayzen: 1 sec [13:38] nik90, awesome [13:39] danielholm, yh it should help people solving the issues if i can get the code posted as well [13:39] ahayzen: https://bugs.launchpad.net/u1db-qt/+bug/1271973 [13:39] ahayzen: https://bugs.launchpad.net/u1db-qt/+bug/1271972 [13:39] Launchpad bug 1271973 in U1DB Qt/ QML "Results from U1db.Query contain only indexed fields, not the whole document" [Medium,Confirmed] [13:39] Launchpad bug 1271972 in U1DB Qt/ QML "Top-level fields in document cannot be indexed" [High,Confirmed] [13:39] dpm: https://code.launchpad.net/~mzanetti/reminders-app/enable-attaching-images/+merge/202817/comments/473595 [13:39] nik90, thanks [13:40] * dpm looks [13:40] ahayzen, danielholm, good day! [13:40] vthompson: hey mate! how are you? [13:40] nik90, looks like some of them may be related to our issues or assist us in resolving [13:40] vthompson, morning :) [13:40] danielholm, Good, yourself? [13:40] ahayzen: yup :) [13:41] mzanetti, hm... will try again, updating the image on the phone now (I'm using dual-boot, so it takes a while) [13:41] nik90, u any good with resolving binding loops? [13:41] vthompson: I am great, thank you. Long time since we spoke now [13:41] ahayzen: with the height? [13:41] ahayzen: let me give a shot at it :) [13:41] nik90, no i've been building the U1DB stuff for the music-app and getting a binding loop :/ [13:41] ahayzen, danielholm, nik90 The music app has had a height binding loop error/warning for a while now [13:42] nik90, oh does tht one with the height still exist? [13:42] dpm: that said, I believe you that there might still be an issue somewhere... just not sure where as your steps to make it fail don't work here [13:42] ahayzen: what vthompson said ^^ [13:42] ahayzen, what does the U1DB stuff say is binding too what? [13:43] vthompson, well erm its probably easier to post the code then post links hang on i'll dump it in +junk... [13:43] nik90, ahayzen maybe the music app got rid of the binding loop issue. I think a lot of it had to do with anchoring listviews in a pagestack [13:43] mzanetti, ack. Will try to reproduce again, this time with the latest image [13:43] ahayzen: it seems that there are branches in https://code.launchpad.net/~uonedb-qt/u1db-qt/trunk/+activereviews that need reviewing...hopefully if they get quickly reviewed we can expect good fixes [13:44] nik90, ahayzen, you might want to ping kalikiana for the status of reviews in U1DB [13:44] dpm, thanks [13:44] dpm: actually they are his branches [13:44] dpm: so he needs someone else to review them :) [13:44] dpm, who can i talk to about getting UITK merges landed? [13:45] dpm, eg this one https://code.launchpad.net/~andrew-hayzen/ubuntu-ui-toolkit/fix-swipe-delete-002/+merge/202171 [13:45] ahayzen, you can try the SDK guys that are around - zsombi, timp, kalikiana, Kaleo... ^^ [13:45] vthompson, nik90, right this binding loops http://bazaar.launchpad.net/~andrew-hayzen/+junk/music-app-u1db-conversion/view/head:/MusicPlaylists.qml#L164 [13:46] dpm, cool [13:46] ahayzen: wanted to ask how you test your fixes in UITK? As in are you able to build and test uitk? [13:46] nik90, i just overwrite the files with my modifications... [13:46] ahayzen: ah [13:47] nik90, vthompson, then this is the output in the console MusicPlaylists.qml:155:17: QML CoverRow: Binding loop detected for property "covers" [13:49] ahayzen, off the top of your head do you know what pkg I need to use U1DB-qml [13:50] vthompson, errr hang on [13:50] vthompson: qtdeclarative5-u1db1.0 [13:50] vthompson, try qtdeclarative5-u1db1.0 [13:50] vthompson, note tht bits of it don't work due to the bugs [13:50] nik90, ahayzen thx [13:50] vthompson, so u won't be able to see the tracks of a playlist [13:51] vthompson, the recent list isn't sorted by time [13:51] vthompson, and probably other bugs lol but u get the idea [13:51] nik90: those branches need reviewers in fact, as in people stepping up to do those reviews ^_~ [13:52] kalikiana: I know..unfortunately I can help test the patches but not really the code itself since I am not good with c++ :/ [13:53] ahayzen: perhaps there is something wrong with the playlistStorage.getPlaylistCovers(name) function? Since CoverRow component is used in the exact same way in other files [13:53] nik90: how about https://code.launchpad.net/~kalikiana/u1db-qt/newstylelog/+merge/183887 there's no c++ there [13:53] nik90, yeah thts wht i suspect but don't know wht yet lol [13:54] may be try doing, component.onCompleted: console.log(playlistStorage.getPlaylistCovers(name)) [13:54] nik90, gd idea :) [13:55] * kalikiana waits for aquarius to come online to talk him into reviewing the other branches [13:55] nik90, it comes back with a cover.. [file:///home/andy/.cache/media-art/album-ddbaf6bd108836d4afe269d86532a844-3847274bce1afa48001cb1e0d877a17c.jpg] [13:57] ahayzen: hmm [13:57] nik90, its not something stupid like having two queries running on the same index at the same time? [13:57] Could the binding loop be because of accessing playlistStorage? [13:57] vthompson, tht was my other thought [13:58] Maybe comment out "playlist"'s count string [13:58] vthompson: but ahayzen seems to have accessed playlistStorage in other places as well though [13:58] nik90, yh just wondering if that's what's causing the loop [13:59] ahayzen, I can't run the branch so I won't be of much help :) [13:59] vthompson, nik90, playlistStorage is where everything for it is stored http://bazaar.launchpad.net/~andrew-hayzen/+junk/music-app-u1db-conversion/view/head:/storage/PlaylistStorage.qml [13:59] vthompson, no worries we're still waiting for stuff upstream so probably shouldn't spend too long on it [14:00] ahayzen: just a thought, the coverRow component assigns covers to Image source. So shouldn't the file path be "/home/andy/.cache/media-art/album-ddbaf6bd108836d4afe269d86532a844-3847274bce1afa48001cb1e0d877a17c.jpg" instead of it starting with file:/// ? [14:01] ahayzen: or is this used in other places as well where that works [14:01] nik90, possibly....don't we just put Qt.ResolvedUrl() around it or something? [14:01] ahayzen: nope we dont use Qt.resolvedurl() there [14:01] oh no we don't [14:01] http://bazaar.launchpad.net/~andrew-hayzen/+junk/music-app-u1db-conversion/view/head:/common/CoverRow.qml [14:02] * ahayzen checks wht is happening in trunk [14:02] popey, just saw your blog post. Good taste in music! :) [14:03] :D [14:03] nik90, i get this back in trunk [file:///home/andy/.cache/media-art/album-57bab982bcba3e65c33206f442a015db-ec0c33dc9346a3e53339f4bdcb13ee35.jpg] [14:03] I was careful with the one I picked for that screenshot ㋛ [14:04] popey: lol...btw nice new blog theme [14:04] seems like everyone is changing their blog theme recently [14:04] popey, hehe...wait until the scrobbling works ;) then u'll have to be real careful wht u choose [14:04] webupd8, iloveubuntu.net, popey etc etc [14:05] ahayzen: ah ok... [14:05] vthompson, did u get a chance to look at https://code.launchpad.net/~andrew-hayzen/music-app/convergence-prototype-a [14:05] nik90, i'll come back to it another time i've been staring at it for too long lol [14:05] +1 [14:05] haha ahayzen [14:06] nik90: i saw someone else use it, it's just the default 2014 wordpress one :D [14:06] ahayzen, yep. Good start. The real hard part will be introducing panels. Filemanger might have a good example for us to use however [14:07] vthompson, yeah tht'll be me next branch hopefully :) [14:07] vthompson, do u think i need to do anything else to https://code.launchpad.net/~andrew-hayzen/music-app/convergence-prototype-a before merging? [14:07] vthompson, i'm trying to do the transition in small steps to make it easier [14:08] ahayzen, not sure. Maybe propose a merge but leave it as a WIP so we can get a quick read of the diffs [14:08] vthompson, cool [14:09] ahayzen, might also be good to get Jenkins to see it too [14:09] vthompson, hehe [14:09] vthompson, hmmm more to the fact how would we test convergence in jenkins? [14:09] vthompson, can we have a test resize the window? then check the wideAspect bool? [14:10] popey, on calc blueprint you wrote "Ensure keypad does not get disappear when labels being entered". What does it mean? [14:10] ahayzen, yea, that's a fair point. I think jenkins starts the app in the size you specify, ie how we'd start in the desktop. I don't know what Filemanager tests--it starts in tablet/desktop mode [14:10] dpm: sorry. I have to revert you commits [14:10] WebbyIT: lemme see [14:10] dpm: seeing that sergio's commit broke lots of stuff [14:11] mzanetti, no worries, committing directly was a mistake anyway [14:11] vthompson, will i need to wait for Jenkins to run before marking as WIP? https://code.launchpad.net/~andrew-hayzen/music-app/convergence-prototype-a/+merge/203070 [14:12] ahayzen, not sure. you can leave it proposed for now [14:12] vthompson, cool, its actually quite a small diff :) [14:12] WebbyIT: http://imgur.com/q209FFc - when you click a label, the OSK/keypad disappears, which looks odd. [14:12] (on desktop) [14:13] ahayzen, it might be interesting to let it pass, then to specify a wide width to see what would fail at the moment [14:13] popey, so, on desktop has to not disappear, but on phone yes? [14:14] WebbyIT: well, on phone it switches to OSK, on desktop we don't have OSX, so need to keep keypad on [14:14] vthompson, it would fail with trying to get to anything on the smaller toolbar at a guess [14:14] there is a simple way to know if app runs on desktop on or phone? [14:14] heh OSX [14:14] ahayzen, would assume the same [14:15] ahayzen, I think this should go in as well [14:15] https://code.launchpad.net/~vthompson/music-app/sheet-size-on-desktop [14:15] vthompson, yep :) [14:15] vthompson, u want me to top-approve? [14:15] ahayzen, sure thing [14:18] WebbyIT: not really that I'm aware yet [14:19] popey, mhh, I'll try to find something [14:19] popey, dpm, mhall119, etc. I think one nice thing would be to assure that all fixes currently in launchpad for core apps are available in the click store and/or the Trusty builds. Music app already has one dup bug that's been fixed--I expect we'll get a few [14:20] I was about to say the same thing [14:20] +1 [14:20] Just let us know when you want us to crank a build out [14:21] ahayzen, what do you think? Push to the store now? we don't really have any merges waiting for phone UI. [14:21] vthompson, when was the last click build? [14:21] Just in case ppl want to hack on our app next week as well [14:21] LONG time ago [14:21] vthompson, do it :) [14:22] Last was r273 from launchpad... so not that long ago Dec 11.. but long enough ago [14:24] 245 is the one on my phone [14:24] vthompson, popey, I agree, but I'd just wait for a few minutes for Jenkins to merge this one: https://code.launchpad.net/~vthompson/music-app/sheet-size-on-desktop/+merge/202001 [14:25] dpm, sounds good. That mp should be transparent to the N4, but I agree. [14:25] phablet@ubuntu-phablet:~$ click list music | grep com.ubuntu.music [14:25] com.ubuntu.music 1.1.245 [14:26] vthompson, yeah, if it were to fail the tests, then we go for the click store update straight away and fix that branch later [14:26] popey, odd. root@ubuntu-phablet:/usr/share/click/preinstalled/com.ubuntu.music# click list music | grep com.ubuntu.music [14:26] com.ubuntu.music 1.1.273 [14:26] vthompson, my uni internet just crashed so if u said anything i would have missed it :P [14:26] haha [14:26] look at all the updates on my phone pending [14:26] my bad [14:27] ahayzen, saw you drop. I didn't say anything. Your campus internet is worse that ours was in the states.. that's saying something :) [14:27] :) [14:27] http://popey.com/~alan/phablet/device-2014-01-24-142705.png [14:27] popey, for shame! [14:27] check that out! [14:27] what a bad person you are... [14:27] vthompson, hehe it is 10 up/down when it works in halls :) and 100 up/down on campus [14:27] its because I flashed clean then pushed a load of clicks from my laptop then did "pkcon install-local *.click" [14:27] clearly had old clicks on my laptop [14:28] good way to test updates though *ahem* [14:29] vthompson, we have a pass from Jenkins https://code.launchpad.net/~andrew-hayzen/music-app/convergence-prototype-a/+merge/203070 [14:32] ahayzen, now the question is do we want to use your branch to default to a wide mode on the desktop? I use the app on my desktop all the time, so it might be nice... BUT it'd probably also require you to make AP exceptions for the "wideAspect" property? [14:32] vthompson, hmm yeah how would we do tht? [14:33] ahayzen, specifying a width in MainView IIRC [14:33] vthompson, do we have the API to figure out if ur on a touch/pointer device [14:33] vthompson, oh cause on the mobile it'll just fill the screen [14:34] ahayzen, yep, and on the tablet... I assume [14:34] popey, when you ping sergiusens for a store update for music, can you check with him if there is a way to upload the reminders app without having to wait for a conclusion on the frameworks discussion? I've got a hunch it's going to take a while otherwise [14:34] dpm: its already uploaded [14:34] dpm: its blocked on me, i can let it through any time [14:34] if you want [14:35] vthompson, but this is definitely gonna cause issues with autopilot...how has the file manager done it? [14:35] popey, ah, yeah, let's upload it. Or were you waiting on anything else? [14:35] how about we get music updated and push both together, nice end to the day today ☻ [14:35] no, just testing [14:35] popey, sounds like a plan [14:35] kk [14:35] will do [14:35] thanks \o/ [14:35] once we get the nod from vthompson about when to push music [14:35] ahayzen, not sure. I would assume they check a property [14:36] vthompson, i've just pushed changes to the size so we'll see wht fails [14:36] popey, I think pushing would be good [14:37] ok [14:37] ahayzen, just tested. I like this ratio: width: units.gu(125) [14:37] height: units.gu(80) [14:38] vthompson, i just did w100/h80 [14:38] ahayzen, that's probably good too [14:39] vthompson, wht resolution is ur screen? [14:39] 1680/1200ish [14:40] vthompson, mine is 1366x768 so tht nicely fills the centre :) [14:40] ahayzen, I lied 1680x1050 [14:54] ahayzen, not bad! only 1 AP test to do some patchwork to! [14:55] vthompson, \o/ it is the one tht tests the play/pause on the small toolbar [14:56] vthompson, but surely we want to test both cases? desktop and mobile mode? [14:58] ahayzen, Probably. But I'm not sure how we'd do so. [14:59] ahayzen, I've seen AP accidentally resize the window... so maybe we could intentionally do so [15:00] vthompson, hmmm i think we need to talk to some autopilot people about wht we should do about this [15:02] mzanetti, what's the status of the reminders-app branch right now? Are you working on cmake changes? Reverting the .pot file made the translations in LP disappear, and if it's going to take a while for the rest of the fixes to land I'd send a simple MP that only touches the .pot file to have translations back [15:02] dpm, popey, what do you think? I'd rather we start in wide mode on the desktop--because I'm self-serving and use the app frequently--and then work on getting an AP test to get Jenkins to test phone mode. The builds will still test phone mode stuff... [15:02] dpm: on it [15:03] mzanetti, ok, thanks! [15:05] dpm, popey, addendum to above. I mean wait to get an AP that Jenkins can use to test both modes [15:05] vthompson, what do you exactly mean with "we start", though? (sorry if I'm asking something obvious, I want to make sure I understand) [15:05] i agree [15:05] when the app is opened on desktop it should be wider than tall, or full screen by default [15:05] dpm, I mean launch the app in wide mode on the desktop. This means that Jenkins will also be testing the app in this mode [15:05] full screen is probably the easy/dirty way to do it [15:06] popey, ahayzen has found a nice ratio. [15:06] popey, but how do we test the different buttons/labels that are present in the different modes? [15:06] ahayzen: ---> balloons is that way [15:06] popey, we can only test the default size unless we can resize the window somehow [15:06] right [15:06] ahayzen, that's a really good question this might be a good one for fginther and balloons [15:06] popey, ahayzen, balloons, I think the proper way would be to check one or more properties that specify which mode is currently being used [15:06] ahayzen, we can open the different sizes [15:06] happy for it to be a fixed size of some kind. [15:07] yes, we do that for filemanager for instance [15:07] hello, it appears that there's no field in the manifest of a click package for the application name. Should that be taken from a desktop file instead? [15:07] the test changes depending on if we're in wide mode or not [15:07] balloons, so Jenkins tests both modes somehow? [15:08] vthompson, atm jenkins merge will test wide mode, the lab tests phone mode [15:08] balloons, ok, ahayzen let's do the same [15:08] balloons, vthompson how would we implement this? [15:08] balloons, This scares me a bit because we can break the phone and jenkins wont know and we won't know until an image is built [15:08] once running in the lab it should run fine on both.. We simply check the flag in filemanager to see what UI it is running [15:09] vthompson, yes, that is possible. But if it happens we'll revert [15:09] ahayzen, in the test you'd do an if wideMode else [15:09] we do test on the phone before pushing manually [15:09] balloons, ah so does Jenkins force the window size? [15:09] james_w: not "title"? [15:10] ahayzen, jenkins tests in desktop mode.. We could ask fginther if we could also have it run a second set of tests (maybe only during autolanding) on a small window size [15:10] james_w: and "name" [15:10] popey: name is package name right? Not user-friendly display name? [15:10] balloons, tht would be useful [15:10] james_w: my manifest.json has both name and title., yes, name is com.popey.appname, title is Appname [15:10] balloons, can't the test itself launch the application in a specific mode? [15:10] popey: hmm [15:10] james_w: also, description [15:10] popey: then my question becomes where I should get the "tagline" from :) [15:11] james_w: http://paste.ubuntu.com/6808794/ for example [15:11] fginther, how would we do tht? because tht would be the best way [15:11] fginther, balloons the other idea would be to have jenkins resize [15:11] ooh [15:11] "title: short (one-line) synopsis of the application" [15:11] fginther, balloons, or rather AP resize [15:11] which to me is the "tagline" not the "app name" [15:11] I have these holes to fill for submission: package name, app name, tagline, description [15:11] fginther, in theory it could.. but if we could limit the xserver screen size that would force all the apps to behave in the smaller size. Which is probably better [15:12] the first and last are easy [15:12] I only have one element to put in the middle two, and I'm not sure which it is [15:12] i dont think I have seen tagline anywhere other than the website [15:12] so app name. [15:13] balloons, is the application forced to fit within the xserver window? Do we know if this will work? :-) [15:14] fginther, I don't know for sure, I'm curious :-) [15:14] popey: ok, thanks [15:14] np [15:15] balloons, it's an interesting idea. If it works, we should just need to duplicate the existing jenkins job and start the xserver with the limited size. Then run both jobs for the apps that want to do the small window testing [15:17] dpm: ok. ready to approve your translation branch after you push the last fixes [15:17] fginther, right.. I would suggest we do it for all apps. But consider only running the tests twice as part of autolanding, or maybe that would be confusing. I wouldn't want to slow down the jobs needlessly [15:18] dpm: DO NOT use :parent :P [15:18] balloons, I would not worry about slowing down the jobs, that problem is solved by scaling out [15:18] true :-) [15:18] then yea, let's do it [15:19] mzanetti, I'll stay well away from it :) [15:21] vthompson, lunch brb [15:44] renato: I have some EDS bugs for you :) [15:44] I saw it [15:44] thanks for report it [15:44] popey: hey I got a design question (usability) for you. [15:44] Guys, how to import music in the music-app? [15:44] renato: let me know if you need any logs for the bug reports [15:45] vthompson: ^^ [15:45] nik90: go [15:45] popey: In the add alarms page, we have options to set an alarm daily, weekly and one time. But isn't daily a special case of weeky? [15:45] PaoloRotolo: you have a phone connected via USB? if so, just drag it over via mtp in nautilus [15:46] popey: since when you choose weekly and then select all days of the week, it is actually a daily alarm [15:46] perhaps that can be removed [15:47] popey: stefano made a small gif mockup https://launchpadlibrarian.net/162723769/proposal2.gif [15:47] nik90: ios has just one repeat option [15:47] you pick the days and thats it [15:47] Hi popey! No, unfortunately I've only a Nexus 7 (2013), still not supported by Ubuntu Touch... [15:47] http://imgur.com/PkUXIxs [15:48] nik90: ^ [15:48] popey: how do you know if it is repeating for 1 week or for the entire year? [15:48] you dont get that option [15:48] its on or off on the previous screen === gatox is now known as gatox_lunch [15:49] nik90: http://imgur.com/PqOHQcu,WDuWWtW [15:50] popey: ok..so technically that mockup by stefano is good [15:50] yeah. [15:50] popey: In the repeat alarm page, you can choose several values? [15:54] yes [15:55] nik90: same as yours, individually flip them on and off [15:55] * popey cancells before he sets himself some ludicrous alarms [15:56] ok [15:57] popey, can I do that on desktop too? [15:58] PaoloRotolo: if you put music in ~/Music and have mediascanner installed, yes, it should [15:58] vthompson: thats right isn't it? [16:00] popey, I've just installed mediascanner but it doesn't work... [16:01] is it running? [16:04] Hey PabloRubianes [16:04] vthompson: hello [16:04] PabloRubianes, do a "ps -ef|grep mediascanner-service" [16:04] vthompson: I am in my work in windows :S [16:04] popey, oh, right, I've to run mediascanner-service. Thanks :D [16:05] If you reboot it should run [16:05] and yes I know I need to change of work vthompson [16:05] Otherwise you can do "mediascanner-service ~/Music" [16:05] PabloRubianes, ha. My work's workstation is a Windows PC as well [16:08] nik90, I added some comments on your bug [16:10] nik90, would be nice if you can isolate the bug [16:10] nik90, btw I have added the SDK project into the affected projects since this affect the SDK alarm components [16:11] and the problem could be on the component too [16:30] What's next if my merge request is approved? [16:33] Guest___: it gets tested by jenkins, and lands in trunk if all is well. [16:33] then we break out the champagne and celebrate [16:44] renato: I will try to reproduce this from a sample app. I remember creating one sometime back. [16:51] popey: what do you think? http://i.imgur.com/mk2YEqN.png === gatox_lunch is now known as gatox [16:54] morning everyone [17:00] mzanetti: wow, thats quite green! [17:00] :D [17:00] is it their green? [17:00] yeah [17:00] Well it's delightful then ☻ [17:00] you think I should file a merge request for it? [17:00] * mzanetti likes [17:01] and it makes the right edge animation cooler if there is some color in there :D [17:02] I am not sure I can speak authoritatively on matters of design. [17:03] but propose a merge and I will wave it at design on monday [17:17] fginther, would you happen to know why this branch hasn't landed despite being approved? -> https://code.launchpad.net/~dpm/reminders-app/update-translations/+merge/203030 [17:19] dpm, the merge is failing with: Server sent an unexpected error: ('error', 'GhostRevisionsHaveNoRevno', 'Could not determine revno for {david.planella@ubuntu.com-20140124121210-n7rr1k4ezcznmdgw} because its ancestry shows a ghost at {david.planella@ubuntu.com-20140124121210-n7rr1k4ezcznmdgw}') [17:19] Build step 'Execute shell' marked build as failure [17:19] "an ancestry shows a ghost" [17:19] that's scary stuff [17:20] http://wiki.bazaar.canonical.com/GhostRevision [17:20] There is no castle for this ghost? Poor ghost! [17:20] mzanetti, how did you revert the changes in trunk? Did you delete revisions or did you overwrite revisions? ^^ [17:21] "revision ghosts are just like real ghosts (such as they are) in that their discorporeal existence typically causes little, if any, harm. " I'm relieved now [17:21] lol [17:22] right... yeah, I did uncommit and push overwrite [17:22] dpm, there still exists the problem that this branch won't merge automatically. You might need to create a new branch and resubmit [17:22] yeah, will do that, thanks fginther [17:22] thanks fginther [17:23] dpm, mzanetti, no problem, may I change https://code.launchpad.net/~dpm/reminders-app/update-translations/+merge/203030 to something other than approved? [17:23] dpm, jenkins is stuck in a loop trying to merge this in [17:23] fginther, sure [17:23] fginther: sure. disapprove it, we'll resubmit [17:23] sorry dpm [17:23] I marked as rejected [17:24] mzanetti, no worries, it's fixable [17:24] good morning all [17:26] mzanetti...david mentioned a emulator to run the reminders app...where can I find this emulator [17:26] rottinrob: there's a guide here http://davidplanella.org/ubuntu-emulator-quickstart-guide/ [17:26] it depends on which version of ubuntu you have [17:27] thank you samertm [17:27] and speaking of that, if we want to work on the Core apps, is it sufficient to have the emulator or should we be running Trusty Tahr? === Ursinha is now known as Ursinha-afk [17:31] samertm: personally i run on trusty [17:31] popey: hey! I saw you on the ubuntu engineering webcast last wednesday! [17:31] that was a lot of fun [17:32] is there a way I can install trusty tahr beside 13.10 without dual-booting? [17:32] well, you can run 13.10 [17:32] rottinrob, I did mention it, sorry I didn't follow up, it's been a bit hectic this last couple of days [17:32] that should work fine [17:32] rottinrob, the guide above should get you started, it's what I wanted to send you [17:33] samertm, I'm on 13.10 and have no problems, but remembert to add the right PPA ;) [17:34] samertm: thanks for the nice comments ☻ [17:36] no worries...I was just wanting to set this up and try to get back up to speed [17:38] popey: I was following your policy of staying on the stable release before upgrading :) ... you upgrade too early [17:38] hah [17:38] I upgraded through peer pressure [17:38] I'd have been happy staying on 12.04! :D [17:38] popey: oh great let's blame mhall119 and dpm :) [17:39] no no no, always blame popey [17:39] I'm innocent: I'm using both 13.10 and trusty! :) [17:39] How do active developers set up 14.04 for testing? Do they use a chroot? [17:40] what is the most convenient way for me to run the latest 14.04 build :P [17:40] samertm: most just upgrade from 13.10 to 14.04 tbh [17:40] yeah [17:40] 14.04 is pretty stable [17:40] ah kk [17:40] samertm, I run a VM [17:40] he says with a 4GB xorg process [17:40] I was going to say that too, a VM is another option [17:40] I'll try a VM first [17:40] ty [17:41] samertm, np [17:41] mhall119, dpm: :) [17:44] which is the best way to upgrade from 13.10 to Trusty? [17:44] update-manager -d [17:44] kk...ty [17:44] mzanetti, would you mind having a look to https://code.launchpad.net/~dpm/reminders-app/add-pot/+merge/203136 - I've kept the changes to the minimum and will wait until the cmake cleanup is done before doing more i18n-related changes [17:45] dpm: approved [17:45] awesome, thanks [17:50] dpm: https://code.launchpad.net/~mzanetti/reminders-app/change-edit-page/+merge/203139 [17:51] mzanetti, on it [17:52] btw guys, if someone is looking for an app to help with, reviewing reminders-app is an area where we need help with: https://code.launchpad.net/reminders-app/+activereviews [17:55] * dpm likes cmake's indication of percentage built [17:55] hi all [17:56] hi [18:13] dpm: hey, I think its not possible yet to open the camera in order to take a picture. I will implement a minimalistic camera view myself, ok? [18:14] mzanetti, ack, makes sense then [18:15] ahayzen, did the autopilot bug you found for your merge from a bit ago get solved yet? [18:29] hey all [18:29] samertm: hi [18:29] how long does it take for the ubuntu-emulator to work? It's been on a black screen for a while. [18:30] and it's launched the ubuntu-phablet terminal [18:30] ooh I havent tried the emulator yet to be helpful.sry [18:30] haha that's k [18:33] samertm, it's in the order of minutes. Just check that you don't have other apps consuming a lot of memory or CPU, which tends either to kill or slow down the emulator [18:33] if after 10 mins the emulator still shows the black screens it's a good signal it's better to restart it :) [18:34] dpm: haha it's been about 15, but my cpu is still at 100% [18:34] so I assume something is happening [18:35] yeah, the PC is probably good as heating :) [18:35] the bright side :P [18:36] vthompson, why hasn't Jenkins run on https://code.launchpad.net/~bobo-324/music-app/fix1272151and1272113/+merge/203074 [18:37] ahayzen, I think it only does so when top approved if you are not on the team [18:37] balloons, it was solved but i don't think the merge has been approved [18:37] vthompson, ah ok [18:37] vthompson, shall i top approve? [18:37] ahayzen, what vthompson said is correct [18:37] ahayzen, I just did [18:37] vthompson, cool [18:38] balloons, i'll find the autopilot MP... [18:38] balloons, this one https://code.launchpad.net/~thomir/autopilot-qt/export-qobject/+merge/201865 [18:38] vthompson, wht was the result of the discussions about screen size? [18:39] ahayzen, from a testing perspective? [18:39] vthompson, yeah [18:39] ahayzen, I assume we just want to make the test detect wideMode and handle both [18:39] vthompson, ok i'll add tht in [18:39] ahayzen, Jenkins and desktop (by default) will run in wide mode and the image builds will test phone mode [18:40] ahayzen, anything more than that can be worked out soon here [18:40] vthompson, cool and we can do manual autopilot on device [18:40] vthompson, u have the script to do tht? [18:40] yep [18:40] ah [18:41] ahayzen, do a "debuild -uc -us" from the music-app root directory [18:41] vthompson, no there is one which runs autopilot on the device from a bzr branch for u [18:41] vthompson, http://paste.ubuntu.com/6721815/ [18:42] vthompson, then just run for example ... script.sh lp:music-app music_app [18:42] vthompson, it doesn't even need a writeable image which is cool [18:42] ahayzen, I see and then you can also do something like " music_app.tests.test_music.TestMainWindow.test_create_playlist_from_songs_tab" as the second param to run just one test [18:43] ahayzen, I've never done it that way [18:43] vthompson, yep [18:43] dpm: I waited way too long the first time [18:43] ahayzen, I know you've shown me the script before... just havent used it/saved it away [18:43] I restarted the emulator and it took ~5 minutes to launch [18:44] vthompson, :) [18:44] vthompson, also we found if u comment out the lines that run the tests.... if u then restart the device the music-app is then replaced with tht one ...so it can be used to deploy apps [18:45] vthompson, i usually do script.sh lp:music-app && adb reboot to test the app now [18:46] ahayzen, neat. I might still do it the old way as I don't want to deploy if I'm testing. But this is a neat way to deploy [18:46] vthompson, yep [18:47] vthompson, it just means u don't have to make the image writeable [18:47] samertm, ah, cool (as "cool" as 5 minutes can be :) [18:48] ahayzen, speaking of deploying: http://i.imgur.com/0kRBfFu.png [18:48] I need to call it a day, nice work everyone, good hack day, and it's still not over! :-) [18:48] ahayzen, woot [18:48] dpm: it was nice to meet you! [18:48] cya [18:49] vthompson, 321! [18:49] dpm: enjoy your evening [18:49] see you, have fun :) [18:49] thanks nik90, samertm [18:50] are there any hack day tasks I can help out on? [18:52] vthompson, we need a commit msg https://code.launchpad.net/~bobo-324/music-app/fix1272151and1272113/+merge/203074 [18:54] ahayzen, just added one [18:57] doflah, there are a few links on these blog posts http://popey.com/blog/2014/01/24/january-2014-core-apps-hack-day-one-reminders-and-music/ http://davidplanella.org/ubuntu-core-apps-hack-days-back/ [18:57] doflah, also searching for bugs which have the tag hackday or bitesize within the coreapps [19:04] vthompson, passes on the Nexus 4 now for Jenkins ... https://code.launchpad.net/~andrew-hayzen/music-app/convergence-prototype-a/+merge/203070 :) [19:22] vthompson, passed on Jenkins as well https://code.launchpad.net/~andrew-hayzen/music-app/convergence-prototype-a/+merge/203070 [19:22] vthompson, brb [19:26] ahayzen, I get one failure, but it might be the same playlists test fluke seen earlier in the #ubuntu-touch room [19:27] ahayzen, I need to step out. I'll be back in an hour or so [19:52] this might be a dumb question [19:53] but how do I run the music-app on the ubuntu phone emulator after I grab the code from launchpad? [19:56] samertm, you want to run code you've written?> [19:56] samertm, in general it's easier to run it locally on the desktop if you are trying to test things. Otherwise you can simply ssh in and run it as normal [19:56] bzr branch, qmlscene music-app.qml [19:58] ah, so I should run it from the ubuntu-phone terminal? [19:59] samertm, yep that should work out fine [19:59] thanks! [20:00] ahayzen, re: https://code.launchpad.net/~thomir/autopilot-qt/export-qobject/+merge/201865.. Cool, looks like it might be ready to go. I wonder if I can get someone to review outside of thomi [20:12] balloons: do you have reminders-app on your device? [20:12] or indeed mhall119 [20:14] popey, my device is down for the count atm [20:14] well, I do have the n10, I could try it on that [20:14] why do you ask? [20:17] its in the store [20:17] wanted someone to test install [20:17] because i already have it [20:32] balloons, cool would be good to get tht landed [20:32] vthompson, back.... yh looks like we have a flaky test...which one is it in particular i may look to see if i can improve it === Ursinha-afk is now known as Ursinha [20:39] where does music-app look for music? [20:49] samertm, it uses the mediascanner are u on desktop/device? [20:49] ahayzen, desktop [20:50] samertm, if u say ran the following it would add ~/Music to the index... mediascanner-service ~/Music [20:51] samertm, assuming the package 'mediascanner' has been installed (we did have issues with this not being installed before) [20:51] ahayzen, it worked! [20:51] samertm, \o/ [20:51] and mediascanner wasn't installed [20:51] thanks! [20:51] samertm, np [20:55] should mediascanner be added to the touch-coreapps package? [20:55] samertm, there is/was a bug for it [20:55] * ahayzen tries to find [20:56] samertm, https://bugs.launchpad.net/music-app/+bug/1241403 [20:56] Launchpad bug 1241403 in mediascanner "Music app's grilo plugin package needs to depend on mediascanner" [Undecided,New] [20:57] samertm, also we will be moving away from Grilo soon (hopefully) so this won't be an issue [20:57] ahayzen, what's replacing it? [20:57] doflah, there will be a media scanner service that we will talk directly to [20:58] doflah, and a media-hub for playing tracks [20:58] danielholm, o/ [20:58] ah, kk [21:12] about this bug: https://bugs.launchpad.net/music-app/+bug/1272155 [21:12] Launchpad bug 1272155 in Ubuntu Music App "Clicking a track from a sheet when it is currently playing pauses the track instead of taking the user to the Now Playing page" [Low,Triaged] [21:12] what is the correct behavior for clicking a track that is already playing [21:13] samertm, either for it to restart the track and refill the queue or to do nothing...but in both cases show the now playing [21:13] alright [21:13] thanks [21:13] samertm, could be a one liner ... [21:14] samertm, however i guess if it clicked in the now playing page it would need to pause [21:15] samertm, i suspect changing this else if statement to only be true if on the now playing page might work ... http://bazaar.launchpad.net/~music-app-dev/music-app/trunk/view/head:/music-app.qml#L447 [21:15] samertm, thts where i would start [21:16] thanks a bunch! [21:16] this is a brand new code base to me :P === snwh_ is now known as snwh [21:16] samertm, hehe np just ping me, vthompson or danielholm if u need help [21:26] samertm, anyway i gtg, good luck i'll be around tomorrow if u need any help === salem_ is now known as _salem [21:53] anyone else having issues with logging in to Evernote from Online Accounts on Touch device? [22:00] danielholm, I had tried a bit ago and recall that it was difficult. I'll try to give it ago again. [22:01] vthompson, I'm a new contributor and I think I've fixed a bug [22:01] how do I run the testing suite? [22:01] and do you want to look at my patch [22:01] danielholm: you have a sandbox.evernote.com account? [22:01] thats what it ties to [22:01] samertm, push your code to launchpad when you want. do you have a device? [22:02] (i.e. not a standard evernote.com account) [22:02] vthompson, I have the emulator [22:02] samertm, I'm not sure how to test against the emulator, actually. If you push your code I'll run it through my device [22:02] popey: I don't see the reminders app for download [22:03] alright! [22:03] mhall119, popey I thought you still had to push it from the project branch [22:03] 15:17 < popey> its in the store [22:04] as I've looked for it in the click store recently as well [22:04] I assumed he was talking about reminders [22:10] hmm, well, it should be [22:11] * popey pokes sergio [22:12] ok, should be live soon [22:22] samertm, if you run this on the desktop or emulator one thing you'll notice is that the user can no longer pause a track by clicking on it in the Now Playing page. [22:23] popey: responded, i can't make it :'( [22:25] vthompson, so it needs to be paused when you click on it on the now playing page? [22:26] daker: ☹ [22:27] samertm, that's my opinion. There probably isn't a spec saying we need to do so. Let's take a poll [22:28] I know on some media players, like the iphone, clicking the album art doesn't change whether or not the track is being played [22:28] it brings up the tool bar [22:28] which is the behavior it has right now [22:29] mhall119, popey: samertm is fixing a bug I reported. When a user navigates an album, genre, playlist, etc, if he/she clicks on a track that happens to be the one playing in the list it pauses--even though they are not in the now playing page. I think this should bring up the Now Playing page. Now the question is we don't really have a spec for this, but we assumed that clicking on the large now playing cover art wo [22:29] uld play/pause when clicked. What do you think? [22:32] hmm, i can see clicking the currently playing track is an interesting use case. how often would you do that? once you do, and it pauses, would you be pleasantly surprised at discovering that feature [22:32] samertm, IMO the main thing is the behavior for the sheet should be as you have it. However, the user should still be able to click and toggle play/pause in the now playing page [22:32] I'm always a fan of having a quick way to get a phone to STFU [22:33] vthompson, alright, I can work on that [22:33] thanks for the input [22:33] if I happen to have a list of tracks on screen and one of them is playing and i want to shut the phone up because some other thing needs my attention, it could be useful, yes. [22:33] Well, let's talk about this... it was just our assumption [22:34] are there any other music apps which do this? [22:34] hmm! [22:34] its a novel behaviour [22:34] wait, how about this [22:34] So, the google music app restarts the song if clicked from the queue [22:35] the google play music app does nothing it seems [22:35] if you're using the music-app from the Now Playing screen and you click a song to start it, the song starts and the toolbar comes up [22:35] but if you drag the screen to look at the other songs, the tool bar goes down [22:36] so if the user wanted to get back the toolbar without pausing the song, they'll need to swipe up from the bottom [22:36] (if pressing the song being played pauses the track) [22:36] Actually let me check on something. I think one reason I did it this way is due to someone's original desire to have an easy way to pause, etc, when driving [22:36] otherwise, clicking the currently playing song will bring up the toolbar [22:38] samertm, yea, the swipe up to get to the currently playing track is a design decision (and a good one). It is a neat feature that clicking on the now playing item pops the toolbar [22:41] samertm, I think it's a bit of an unprecedented feature we currently have, but I've come to depend upon it. [22:41] danielholm, have you been reading along? [22:42] vthompson: reading what? [22:42] ah, [22:42] danielholm: I can read up [22:42] danielholm, do you click on the currently playing large cover art to play/pause at all? [22:42] vthompson: nope. Not usually. [22:42] tbh I didnt know that happened before you just mentioned it [22:43] vthompson: maybe when I am in a hurry to stop the music. but usually I use the buttons for it [22:44] Well, I might be outvoted. I use it all the time. (possibly because I introduced the feature :X) [22:45] heh [22:45] vthompson: ok. WOuld there be another use of clicking the large cover instead? [22:45] zoom [22:45] ? [22:45] danielholm, maybe restarting the song from the beginning. That's what my Google Music app does [22:45] danielholm: right now it just brings up the tool bar. [22:46] I think simply bringing up the toolbar is less useful [22:47] clicking on the album art on the default android music app does nothing [22:47] vthompson, samertm hmm.. ok. Someone was asking for this? It might be an idea. But then again, I always drag the duration back to 0, or press back [22:47] But given that no one else knew you could pause the song this way... only very slightly less useful :) [22:48] vthompson: I am ok with it pausing. I dont think it should restart the track. back button should do that (right?) [22:48] danielholm, yep after the time limit (5 or 10 secs IIRC) [22:49] vthompson: exactly. so either keep the play/pause or make it do nothing? [22:49] It'd just be extra work for samertm to retain this feature just in the Now Playing queue. [22:49] aha [22:49] do whats less work then, I suppose [22:49] I think the consensus is that it could be useful, but isn't obvious to use. [22:51] samertm, You could check what mode the app's in. There's a mode for the now playing page [22:54] vthompson, what do you mean? [22:54] samertm, Easiest way to check for the now playing page being active might be to check if "currentPage == nowPlaying" [22:55] vthompson, samertm: that the large cover can do different things based in page? [22:55] If so then you'd allow the play/pause toggle [22:55] danielholm, no, the mode is more for the state of the toolbar [22:56] aha ok [22:56] Okay, so I'll add the play/pause toggle [22:56] thanks for the help! [22:57] No worries, thanks for *your* help! [23:00] vthompson, do you know what player.playbackState represents? [23:00] samertm, should be the play/paused state of the MediaPlayer component. [23:00] this is the main object that plays the tunes [23:00] okay === _salem is now known as salem_ [23:36] vthompson, I just pushed a branch which has the behavior you wanted [23:36] :D === salem_ is now known as _salem [23:45] samertm, good work! [23:46] vthompson, thanks! [23:46] samertm, we have no current tests for this area. So there's no benefit to directly testing with the autopilot infrastructure. [23:48] samertm, Assigned the bug to you and formally reviewing now [23:48] vthompson, awesome! [23:48] this is my first free software patch haha [23:51] samertm, Ok. So what I'll let you do next is click on your branch and "Propose for merging" you'll then add a short description (which can be the same as the commit message) click on "Extra options" and then fill in the "Commit message" with something like "* Prevent pausing from elements that do not directly control playback" and click the "Propose Merge" button. [23:53] vthompson, should I include the bug number in the description or the commit? [23:54] No need, it will be assigned when merged. We have a nice sophisticated bot that does that for us [23:54] alright, I just proposed the merge [23:55] as you can see the bug is still related to the merge since it was related to the branch itself. [23:55] yup [23:59] samertm, approved for merge! Feel free to take the time to look at the other apps as well in the oncoming days as they also could use some love! Thanks again!