Noskcaj | jarkko, yep | 00:00 |
---|---|---|
valorie | yes, or apt-get | 00:01 |
valorie | easy-peasy | 00:01 |
jarkko | have you tried it? | 00:03 |
jarkko | that it works and dont break x | 00:03 |
ahoneybun | jarkko: I installed Ubuntu then Kubuntu-desktop package and I;m fine | 00:04 |
jarkko | well i am happy with kde, but i would like to it to start a bit faster | 00:05 |
=== gla is now known as zoranoth | ||
ahoneybun | yofel: what did lintain tell us? | 01:51 |
yofel | oh sorry, got distracted :/ | 01:51 |
yofel | ok, lets see where we left off | 01:51 |
ahoneybun | thats ok | 01:51 |
yofel | now that we have the built package, lintian can not only check for common errors in the source, but also in the finished package | 01:53 |
yofel | you can find the explenation of the tags on lintian.debian.org, e.g. http://lintian.debian.org/tags/copyright-refers-to-deprecated-bsd-license-file.html | 01:53 |
yofel | for now we'll leave lintian, and check for the next script output | 01:54 |
yofel | list-missing | 01:54 |
ahoneybun | there is nothing there | 01:55 |
yofel | that tells whether there are any files that are not in any deb | 01:55 |
yofel | in this case, it's empty, so all files are installed and we're good | 01:55 |
ahoneybun | cool | 01:56 |
yofel | for library packages this would be the point where you would check for symbol diffs in the log, but here we don't have any so we're done looking at the log for now | 01:57 |
yofel | so we see all debs are built | 01:57 |
yofel | the result folder also has the build log in it should you want to take another look at it later | 01:58 |
ahoneybun | no 32 bit build? | 01:59 |
yofel | we only did one pbuilder build, and that defaults to the host architecture. You could build for 32bit too, but that would require another build and a 32bit pbuilder chroot | 01:59 |
yofel | easy to do, but normally checking just one arch is fine | 02:00 |
ahoneybun | as it would build for both for sure | 02:00 |
yofel | pbuilder doesn't make a difference between the packages it builds on specific archs like launchpad does | 02:00 |
yofel | it always builds everything | 02:00 |
yofel | as the package built fine, the package is done from a technical standpoint | 02:02 |
yofel | what we still have to do is update the copyright information in debian/copyright and fix the lintian warnings that are fixable | 02:03 |
yofel | updating the copyright information is possibly the most boring and tricky thing to do for a package | 02:04 |
yofel | lets take a look at the current file | 02:04 |
yofel | in the file you see a small header, then every file is listed with it's respective license and the copyright holders | 02:05 |
yofel | at the bottom of the file you find the short descriptions of the licenses with references to the full ones, or if a license doesn't have a short form then you see the whole license there | 02:06 |
ahoneybun | I see | 02:07 |
yofel | there is sadly no fully automated way of updating the information | 02:07 |
ahoneybun | so what magic script tells us what has changed lol | 02:07 |
yofel | so what I usually do is take the file, and check whether the information is still correct by combinding licensecheck, grep, cut and some shell magic | 02:08 |
yofel | I think there's a bit easier way to do it, but that's how I do it | 02:08 |
ahoneybun | oh ok then | 02:09 |
yofel | at this point: a small lesson in byobu: You can create shell tabs with F2 and switch with F3/F4 | 02:09 |
yofel | it would be nice if it was that easy :S | 02:10 |
yofel | I'll show you how licensecheck works | 02:10 |
yofel | so, licensecheck nicely shows us under which license a file is | 02:11 |
yofel | it can also show what copyright it has, but at least to me that's of limited use as it's hard to filter | 02:13 |
yofel | nice for small packages, but for something as large as tomahawk.. not really | 02:13 |
yofel | so I usually go and filter by license (as that's how the copyright file is grouped) | 02:14 |
yofel | the full syntax of the debian/copyright file is documented on http://dep.debian.net/deps/dep5/ btw. | 02:14 |
ahoneybun | so we do that on for both packages? and then change as neeeded? | 02:14 |
yofel | both packages? You only need to update the new one | 02:15 |
ahoneybun | well you need to see what it was before | 02:15 |
yofel | that's already documented in the copyright file | 02:16 |
yofel | you *could* ofc. make a full source diff of 0.6 to 0.7 and parse the changed copyright information out of that | 02:16 |
yofel | I'll show you how I usually do it | 02:17 |
ahoneybun | where does it say that a license is different | 02:17 |
yofel | well, we have nothing that can compare that, so finding that out is up to you | 02:18 |
yofel | making a diff will show the license as changed | 02:18 |
yofel | or you could go and essentially re-create the copyright file which is kinda what I do | 02:18 |
yofel | you can ask the others too how they do it, maybe they have a better procedure ^^ | 02:19 |
ahoneybun | this is a bit over my head I have a headache lol | 02:19 |
yofel | licensing is always headache material. Sometimes you could really use a lawyer for this -.- | 02:20 |
ahoneybun | just this altogether I mean | 02:21 |
ahoneybun | not something I'm used too | 02:21 |
ahoneybun | *to | 02:21 |
yofel | you'll get used to it, it takes some practice though ^^ | 02:21 |
ahoneybun | heck I don't even understand what your writing | 02:21 |
yofel | in the shell you see what I usually do: get the licenses, filter files by license, then get just the filename from the list, grep for copyright in those files, then filter by user | 02:22 |
ahoneybun | what is happening | 02:22 |
ahoneybun | lol | 02:22 |
yofel | it's magic :P | 02:22 |
ahoneybun | a script doing this for you is magic | 02:23 |
ahoneybun | this is something that can't be said over irc | 02:23 |
yofel | well, there have been attempts, haven't really seen a good working one for dep5 though | 02:23 |
yofel | nor do I really remember where they are | 02:23 |
ahoneybun | oh | 02:25 |
ahoneybun | lol | 02:25 |
yofel | so at this point, I would check the output whether the copyright information for that user is still correct | 02:25 |
yofel | in this case, just make sure all copyright years are documented | 02:25 |
yofel | which is ok, so now I go and filter that user out | 02:26 |
yofel | and filter for the next user | 02:26 |
yofel | now repeat that for every user, and every license, and at some point you're done | 02:27 |
yofel | if one would like to do it the diff way, I guess it would go like this | 02:28 |
yofel | so make a diff, then look for added/removed/changed copyrights and update the file accordingly | 02:29 |
yofel | now you can try yourself at this a bit if you want to | 02:29 |
yofel | as I'll have to sign off for today | 02:30 |
yofel | it's 3:30AM and i'm slowly falling asleep :/ | 02:30 |
ahoneybun | oh ok then ll | 02:34 |
ahoneybun | you have to sleep | 02:34 |
=== jacky is now known as ThisNickIsHowFre | ||
=== ThisNickIsHowFre is now known as Jacky | ||
lordievader | Good morning. | 08:57 |
BluesKaj | Hiyas all | 13:45 |
tester56 | I think I have figured out my first patch for kdelibs (in kdelibs/kio/kfile/kpropertiesdialog.cpp) | 18:32 |
tester56 | but I have no experience with compiling such large stuff ... is it possible to compile kpropertiesdialog standalone? | 18:33 |
tester56 | or is it necessary to compile whole kdelibs? | 18:36 |
Peace- | tester56:you need to compile everything | 18:48 |
tester56 | Peace: okay, and how do I test? do I really have to replace the system files? | 18:48 |
Peace- | tester56: i have tried a patch for dolphin for example | 18:49 |
Peace- | tester56: and i have compiled it again with my modifications => http://nowardev.wordpress.com/2013/11/18/automatic-video-audio-preview-with-dolphin-kde-hovering-a-file/ | 18:49 |
Peace- | tester56: try to figure out reading how i have compiled it ... | 18:49 |
Peace- | tester56: read this step THIRD STEP : COMPILE DOLPHIN AND INSTALL IT | 18:50 |
Peace- | tester56: in that tutorial you get a debian pacakge | 18:50 |
Peace- | tester56: so if someting goes wrong just reinstall the default debian pacakge and you are done | 18:51 |
tester56 | i want to check out if the bug i have found is already fixed in frameworks, where can I find kio in neon? | 19:04 |
tester56 | Peace: thanks, I will try it | 19:04 |
tester56 | kio is not listed here: https://launchpad.net/~neon/+archive/kf5 | 19:06 |
tester56 | is it part of any of the listed packages? | 19:07 |
yofel | tester56: project-neon5-kio | 19:10 |
tester56 | yofel: yeah i am an idiot, i was not able to go to page 2 | 19:11 |
yofel | ^^ | 19:11 |
yofel | easy to miss on launchpad :P | 19:11 |
tester56 | yofel: could you say me how to get it with bzr? I seems to be too stupid for that too ... | 19:15 |
tester56 | because i need the code and not the package ... | 19:18 |
yofel | tester56: I don't think we have bzr imports for those, use: | 19:19 |
yofel | git clone git://anongit.kde.org/kio | 19:19 |
tester56 | yofel: thanks | 19:20 |
Riddell | valorie: how did it go? | 19:21 |
jussi | what state is 14.04 in right now? | 19:29 |
tester56 | when i simply run cmake when compiling kdelibs, the install directory is the default one, meaning it will replace system files, right? | 19:42 |
tester56 | (when running make install) | 19:42 |
yofel | no, it should default to /usr/local/ | 19:44 |
yofel | you could simply replace the lib you want to test if you know which one it is | 19:44 |
yofel | /usr/local/ should be hiding the system libs when installed though, just remember to make uninstall them later | 19:45 |
tester56 | so when i make install, the newly compiled ones will be used? | 19:46 |
yofel | jussi: usable, mostly. My issues on my notebook are nvidia driver crashes somehow related to opengl, kernel sometimes not waking from suspend and for some reason virtuoso does nothing but crash on this one system | 19:46 |
yofel | other than that it runs fine for me | 19:46 |
tester56 | yofel: and the path used by kubuntu is /usr ? | 19:50 |
yofel | yes | 19:51 |
tester56 | so setting path to /usr will override the right files? | 19:51 |
jussi | yofel: ok, nice. might go ahead and do the update then... especially as I have intel on this machine... | 19:55 |
yofel | tester56: yes, should be -DCMAKE_INSTALL_PREFIX=/usr I think. But I wouldn't really recommend that, if you can patching and rebuilding the package would be safer | 19:58 |
tester56 | yofel: btrfs snapshots should help in that case ;-) | 20:04 |
yofel | agreed ^^ | 20:04 |
tester56 | okay something went wrong ... | 20:15 |
tester56 | in CMakeLists.txt in kdelibs: | 20:16 |
tester56 | set (KDE_VERSION_MAJOR 4) | 20:16 |
tester56 | set (KDE_VERSION_MINOR 15) | 20:16 |
tester56 | set (KDE_VERSION_RELEASE 70) | 20:16 |
tester56 | so after installing, all kde applications should show 4.15.70 as version, right? | 20:17 |
tester56 | (in about KDE) | 20:17 |
tester56 | :-( | 20:24 |
yofel | they should show whatever kde4-config --version shows | 20:24 |
yofel | I don't know where that comes from though | 20:24 |
tester56 | when i ran make install there are many of those entries: Installing: /usr/include/kio/jobclasses.h | 20:25 |
tester56 | why are source files installed? | 20:25 |
yofel | those are library headers | 20:25 |
yofel | you need those to build anything that uses the libs | 20:26 |
tester56 | yofel: but the install seems to have gone right: http://pastebin.com/Lkk649Fz or? | 20:34 |
yofel | looks right.. I think | 20:34 |
tester56 | yofel: okay i think i understand what i did wrong ... | 20:40 |
tester56 | yofel: if dolphin uses kdelibs/kio/kfile/kpropertiesdialog.cpp i have to compile dolphin against it, right? | 20:40 |
yofel | not if the so version of the lib that the code is in is still the same | 20:41 |
yofel | /usr/lib/libkio.so.5 I guess? | 20:42 |
tester56 | yofel: not sure ... | 20:42 |
tester56 | yofel: I have changed something there but I do not see the changes applied ... | 20:43 |
tester56 | yofel: plasma is in kdelibs, right? | 20:46 |
yofel | plasma is in kde-workspace | 20:46 |
yofel | ah | 20:47 |
yofel | libplasma3 is part of kdelibs though | 20:47 |
tester56 | yofel: so you say it is not necessary to rebuild dolphin? | 20:49 |
yofel | it shouldn't be, but if you're unsure you can always try to do that. | 20:50 |
yofel | I'm not familiar enough with kdelibs and don't have enough time to take a close look at this to give a definite answer | 20:50 |
tester56 | yofel: okay thanks for your great help ! | 20:51 |
tester56 | yofel: okay there seems to be somethin wrong | 20:58 |
tester56 | kmailservice -v outputs KDE Development Platform: 4.12.1 | 20:58 |
tester56 | in the build folder in bin it outputs KDE Development Platform: 4.15.70 | 20:59 |
tester56 | as expected | 20:59 |
tester56 | yofel: that means the systemfiles did no replaced | 20:59 |
yofel | try to reload the session? Some libs might still be loaded | 21:00 |
tester56 | i have rebooted after installing | 21:00 |
yofel | if the install went ok then that's the only thing I can think of | 21:00 |
yofel | dunno then, maybe #kde-devel knows more | 21:00 |
tester56 | yofel: i do not understand the world atm ... it installed /usr/bin/kmailservice according to the output ... | 21:03 |
tester56 | then i test the two binaries and they do not match ... WTF? | 21:03 |
tester56 | trying again now | 21:04 |
yofel | it could be that an RPATH was set and it's loading libs from different locations | 21:05 |
yofel | wild guess | 21:05 |
tester56 | yeah but i ran the path it installed it too and it did not match ^^ | 21:06 |
tester56 | i did a btrfs snapshot before installing though ... | 21:06 |
tester56 | could that be related? | 21:06 |
yofel | unlikely... unless you're running the wrong snapshot or so | 21:07 |
tester56 | yofel: anyway building whole kdelibs now ... before I only build kio ... | 21:08 |
tester56 | yofel: there kde4-config is included now :-) | 21:11 |
ahoneybun_ | yofel: is that shared chroot running? | 21:16 |
yofel | ahoneybun_: should be | 21:16 |
ahoneybun_ | yep | 21:19 |
ahoneybun_ | what is the key to remove a shell yofel? | 21:21 |
yofel | ahoneybun_: just close it with ctrl+d | 21:24 |
ahoneybun_ | look in debian/copyright correct? | 21:25 |
ahoneybun_ | for the licenses and such | 21:25 |
yofel | right, that's where we left off | 21:26 |
ahoneybun_ | I have th 0.6 and 0.7 debian/copyright files open but see no difference | 21:32 |
yofel | right, as I said yesterday, the 0.7 file is a copy of the 0.6 file | 21:33 |
ahoneybun_ | oh | 21:33 |
yofel | it now has to be updated with the 0.7 license information | 21:33 |
yofel | that is documented in the tomahawk source | 21:33 |
ahoneybun_ | looking | 21:33 |
yofel | the debian/copyright file is essentially a documentation of all the copyright headers in the source | 21:33 |
yofel | no, that's something else | 21:34 |
yofel | do you remember licensecheck? | 21:35 |
ahoneybun_ | does it matter where I run it? | 21:36 |
yofel | yes, as you need to tell it which files to check | 21:36 |
yofel | -r * | 21:36 |
yofel | does the trick if you're in the package root | 21:36 |
yofel | uhm | 21:37 |
yofel | * ? | 21:37 |
ahoneybun_ | I don't remember the use of grep and such though | 21:39 |
ahoneybun_ | to filter | 21:39 |
yofel | ok, I guess we'll do it my way | 21:40 |
yofel | that'll take a while though | 21:40 |
ahoneybun_ | well I don't know anyway but kinda yours | 21:40 |
yofel | ok, lets go back to the copyright file | 21:40 |
ahoneybun_ | I mean I can look though that long list | 21:40 |
ahoneybun_ | and compate | 21:40 |
ahoneybun_ | compare | 21:40 |
yofel | right... but that would probably take ages for tomahawk - would still work ofc. ^^ | 21:41 |
yofel | Files: * | 21:41 |
ahoneybun_ | so you look though licensecheck and put each file in the right license in the copyright file? | 21:42 |
yofel | means that we assume that all files that aren't specified in another section are | 21:42 |
yofel | License: GPL-3+ | 21:42 |
yofel | kinda. You need to document what files have what copyright, and who holds the copyright on that | 21:43 |
yofel | so I usually update the file starting from the top | 21:44 |
ahoneybun_ | from the first license | 21:44 |
ahoneybun_ | I'm trying to see the command | 21:44 |
yofel | ok, so now I've filtered out all files that are GPL-3+ | 21:45 |
ahoneybun_ | so just the license so options or anything | 21:45 |
yofel | right, works better for me for filtering | 21:45 |
yofel | as I need only the file list | 21:45 |
yofel | now some shell magic | 21:45 |
yofel | that'll cut the output apart on the colon and give me only the first part | 21:46 |
yofel | now some more magic | 21:46 |
yofel | xargs will append the file list after the 'grep -i copyright' | 21:47 |
yofel | that way we can grep through all the listed files | 21:47 |
yofel | yay, and it's listing all the copyright holders for the GPL-3+ files | 21:48 |
yofel | now we have tons of duplicates ofc. so I filter only one person out | 21:48 |
ahoneybun_ | after this we can just copy and paste no? | 21:48 |
yofel | well, we only need every person *once* | 21:48 |
ahoneybun_ | yea | 21:49 |
yofel | so we need to merge all the copyright years | 21:49 |
ahoneybun_ | oh boy | 21:49 |
yofel | currently we have 2010-2012, so I'll filter for 2013 as that's the only thing that could've been added | 21:49 |
yofel | nothing, great | 21:50 |
yofel | so nothing to do for that person | 21:50 |
ahoneybun_ | hard part is to remember these command | 21:50 |
ahoneybun_ | and options | 21:50 |
yofel | now, as I'm done with him, I add -v to grep, which changes behaviour from 'filter for' to 'filter out' | 21:51 |
yofel | just to make sure we didn't have 2 christians ^^ | 21:51 |
yofel | ahoneybun_: you can just copy the ~/.bash_history file later | 21:52 |
yofel | that should have most of the commands inside | 21:52 |
yofel | now to the next person | 21:52 |
yofel | ok, no update for leo either | 21:53 |
yofel | ahoneybun_: so, do you kinda see what I do? | 21:54 |
ahoneybun_ | yea let me try for a sex | 21:54 |
ahoneybun_ | sec | 21:54 |
ahoneybun_ | sec | 21:54 |
ahoneybun_ | crap | 21:54 |
ahoneybun_ | nothing new from him | 21:55 |
yofel | Quintasan: you were asking what kinda weird shell magic I do to filter licenses, it looks like this :P | 21:56 |
yofel | licensecheck -r * | grep GPL | grep v3 | grep later | cut -f 1 -d : | xargs grep -i copyright | grep -i -v christian | grep -i -v franchi | grep -i mitchell | grep 2013 | 21:56 |
Quintasan | okay | 21:57 |
Quintasan | that's magic allright | 21:57 |
Quintasan | :D | 21:57 |
ahoneybun_ | new things | 21:57 |
yofel | right | 21:57 |
yofel | so now you can change the year range to 2010-2013 | 21:57 |
yofel | stop | 22:01 |
ahoneybun_ | ops | 22:02 |
yofel | that's why I like to only append grep 2013 in the second run | 22:02 |
ahoneybun_ | already updated | 22:02 |
yofel | so I'm sure I did filter right in the first try | 22:02 |
ahoneybun_ | i see | 22:05 |
yofel | that's the packager coyprights, you won't find those anywhere | 22:07 |
yofel | you may add yourself there btw ;) | 22:07 |
ahoneybun_ | I don't really feel that I have done enough to earn that right | 22:07 |
yofel | nobody cares about that ;P | 22:07 |
yofel | as the list above was done, you should now check for new people | 22:08 |
ahoneybun_ | do I keep all these names for the next list? | 22:08 |
ahoneybun_ | I see I can't save | 22:09 |
yofel | huh | 22:09 |
yofel | what's the shortcut for that? | 22:10 |
ahoneybun_ | crtl-s pops that message | 22:10 |
yofel | aha, never saw that before ^^ | 22:10 |
yofel | but then again, I don't use nano | 22:10 |
yofel | now give me a sec to check something | 22:10 |
ahoneybun_ | how did you check for new people? | 22:10 |
ahoneybun_ | see our changes did not save | 22:11 |
ahoneybun_ | seems it did | 22:12 |
yofel | oh well, it saves on exit | 22:12 |
yofel | hm, I wonder why nokia wasn't added | 22:14 |
yofel | anyway | 22:15 |
yofel | to check for anything new that's missing, just filter out everything we checked before, and look at the leftovers | 22:15 |
yofel | which in this case is some code, nokia, and a copyright entry for a different license (that part of FdoNotifyPlugin.cpp is GPL-2+) | 22:16 |
yofel | IMO, nokia does belong into the copyright file, so can you please add it? | 22:17 |
yofel | it's already open | 22:18 |
yofel | ahoneybun_: wait | 22:19 |
yofel | what license are we checking? | 22:19 |
ahoneybun_ | I thought to add the file | 22:20 |
yofel | well, which license are we checking? | 22:20 |
ahoneybun_ | we just check gpl 3+ | 22:21 |
yofel | ok, and what license is that section of the file for? | 22:21 |
yofel | (see 2 lines below) | 22:21 |
ahoneybun_ | gpl 2+ | 22:22 |
yofel | no | 22:22 |
yofel | LGPL-2 | 22:22 |
yofel | and that's not GPL-3+ | 22:22 |
yofel | our GPL-3+ section was at the top of the file | 22:22 |
yofel | again | 22:23 |
yofel | that's GPL-2+ | 22:23 |
ahoneybun_ | I'm trying to add that nokia file | 22:23 |
yofel | ok, I'll do it | 22:23 |
yofel | we were checking GPL-3+ | 22:23 |
yofel | oh come on | 22:24 |
Riddell | ahoneybun_: getting into packaging? | 22:25 |
yofel | he is, tomahawk simply wasn't the best thing to start with. I'm trying to teach him how to do the copyright file | 22:26 |
yofel | tomahawk is a licensing chaos :S | 22:26 |
ahoneybun_ | Riddell: mostly watching | 22:26 |
yofel | src/libtomahawk/utils/StyleHelper.h (C) nokia gpl-3+ | 22:27 |
yofel | src/libtomahawk/utils/StyleHelper.cpp (C) nokia gpl-3 | 22:27 |
yofel | no + | 22:27 |
ahoneybun_ | bbl crap | 22:28 |
yofel | k | 22:28 |
valorie | Riddell: went well | 23:08 |
valorie | I might blog about it today | 23:08 |
ahoneybun_ | back | 23:09 |
yofel | ahoneybun_: wb | 23:12 |
ahoneybun_ | thanks | 23:12 |
yofel | ok, so lets do things strictly by handbook and add nokia | 23:13 |
yofel | as our first section is for any file, we don't need to add any | 23:13 |
yofel | now, annoyingly one file is only gpl-3, so lets add that | 23:14 |
yofel | and add a new full section for the GPL-3, as that was missing | 23:17 |
yofel | ahoneybun_: so that concludes our work for GPL-3+ | 23:18 |
yofel | on to the next license.. | 23:18 |
ahoneybun_ | ok then | 23:18 |
yofel | licensecheck didn't find anything GPL-3-only, so that's fine too | 23:19 |
yofel | next one is GPL-2+ | 23:19 |
yofel | here we now have a different license than the package default, so we need to list the affected files | 23:20 |
ahoneybun_ | ? | 23:20 |
yofel | for GPL-3+, we just had "Files: *" | 23:20 |
yofel | now we have a list of files - that are GPL-2+, not GPL-3+ | 23:20 |
yofel | as in: all files in the package are GPL-3+, *except* ... | 23:21 |
ahoneybun_ | that works no? | 23:21 |
yofel | it does, if it weren't for those 2 id3v2tag.* files | 23:22 |
yofel | better :) | 23:22 |
yofel | now go by the pattern from before | 23:23 |
yofel | sorry | 23:29 |
ahoneybun_ | ? nothing new there | 23:30 |
yofel | nope | 23:30 |
yofel | wait | 23:30 |
yofel | always do a check whether any new people are there now | 23:31 |
ahoneybun_ | so that is how you do that | 23:31 |
ahoneybun_ | ok let me add them | 23:31 |
ahoneybun_ | cant copy and paste? | 23:33 |
yofel | hm, should work.. | 23:33 |
yofel | the files are already there though | 23:33 |
ahoneybun_ | I forgot shift | 23:33 |
yofel | first 2 at least | 23:33 |
yofel | wait, those are wildcards | 23:35 |
ahoneybun_ | ? | 23:35 |
yofel | no need for * if you put the full filename | 23:35 |
yofel | * means 'any character 0 or unlimited times' | 23:35 |
yofel | the colons shouldn't be there | 23:36 |
yofel | they're just part of the grep output | 23:36 |
ahoneybun_ | right? | 23:37 |
yofel | right | 23:37 |
ahoneybun_ | cool | 23:37 |
ahoneybun_ | good? | 23:38 |
yofel | right intention | 23:38 |
yofel | but shortened too much | 23:39 |
yofel | 2002 wasn't in the list | 23:39 |
ahoneybun_ | I see | 23:39 |
yofel | ok | 23:40 |
yofel | now let me check something | 23:40 |
ahoneybun_ | k | 23:40 |
yofel | ok fine, I like looking at the headers themselves just to make sure it's not some weird combined license that licensecheck misunderstood | 23:41 |
yofel | not the case here ) | 23:41 |
yofel | ok, we're done with the GPL section | 23:42 |
yofel | now to check if there's anything else GPL-like | 23:42 |
yofel | oh yay, LGPL with kde clause | 23:43 |
yofel | hm, now that's LGPL-2.1+, not LGPL-3+ as the copyright file says | 23:44 |
yofel | as there is no LGPL-2.1+ explained at the bottom, we need to add that | 23:46 |
yofel | and as there is no file with LGPL-3+ anymore we can remove that part | 23:47 |
yofel | now we're done with anything GPL (for now) | 23:48 |
yofel | so lets look for any other licenses | 23:48 |
yofel | or hm | 23:48 |
yofel | lets stay with the LGPL ones for now | 23:49 |
yofel | kdsingleapplicationguard is a problem because it shows a limitation of licensecheck that doesn't fit with the real world | 23:51 |
yofel | by default licensecheck only looks through source code files to find licenses | 23:51 |
yofel | kdsingleapplicationguard does it... differently :/ | 23:52 |
yofel | ahoneybun_: wait | 23:53 |
yofel | ahoneybun_: I was checking something for a sec, where are you now? | 23:54 |
ahoneybun_ | checking lgpl for kertz | 23:54 |
yofel | ok | 23:55 |
ahoneybun_ | that does not work | 23:55 |
yofel | see the output from before | 23:56 |
ahoneybun_ | just those | 23:56 |
yofel | licensecheck doesn't understand the kde clause in the file, so can't tell the version | 23:56 |
ahoneybun_ | so check each file? | 23:56 |
yofel | yes | 23:56 |
yofel | ahoneybun_: tip: first grep for copyright, so you see which files are worth checking | 23:58 |
yofel | most in there have nothing in them | 23:58 |
ahoneybun_ | let me see | 23:58 |
ahoneybun_ | show me that please | 23:58 |
yofel | so we see there's only one file with copyright information | 23:59 |
yofel | and that's the part we're interested in | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!