| === Trevinho_ is now known as Trevinho | ||
| Cimi | Saviq, I don't know why it's failing on CI | 00:34 |
|---|---|---|
| Cimi | I mean, those two tests.. | 00:35 |
| === Guest72010 is now known as balloons | ||
| === TheMuso` is now known as TheMuso | ||
| === duflu_ is now known as duflu | ||
| tsdgeos | MacSlow: any help with the notification thing? | 08:53 |
| tsdgeos | s/help/luck | 08:54 |
| MacSlow | tsdgeos, not yet... still stuck with all those ap-tests failing... | 09:00 |
| MacSlow | tsdgeos, I've no idea why they all fail with http://pastebin.ubuntu.com/6827212 | 09:01 |
| tsdgeos | MacSlow: are you running them with make autopilot? | 09:01 |
| MacSlow | tsdgeos, yes | 09:01 |
| tsdgeos | you're compiling in /tmp/bla/unity8/ ? | 09:03 |
| MacSlow | tsdgeos, yes | 09:03 |
| Saviq | MacSlow, that error says autopilot can't find the running unity8 process to introspect - maybe not running with testability? | 09:06 |
| Saviq | MacSlow, got a branch so we can test? | 09:06 |
| MacSlow | Saviq, for this I'm just using plain unity8 trunk | 09:07 |
| Saviq | MacSlow, and all tests fail for you like that? | 09:08 |
| MacSlow | Saviq, yeah | 09:10 |
| Saviq | MacSlow, feels like a dbus issue, when did you last reboot? | 09:10 |
| Saviq | MacSlow, like your dbus session got confused between your terminal and upstart, maybe | 09:10 |
| MacSlow | tsdgeos, Saviq: about an hour ago... so I compiled unity8, cd builddir, LC_ALL=C make install, LC_ALL=C PYTHONPATH=../tests/autopilot autopilot run ... | 09:11 |
| MacSlow | I can do a reboot and see if that solves anything... | 09:11 |
| Cimi | Saviq, hi | 09:16 |
| Saviq | Cimi, yo | 09:16 |
| Cimi | Saviq, can you give me feedback on https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 ? | 09:16 |
| Cimi | Saviq, I would like to know what you wanted with the preview widgets | 09:16 |
| Cimi | Saviq, apart from adding tests and cleaning code, is something like this correct? | 09:17 |
| Saviq | Cimi, don't actually integrate it with the old previews, they're going away | 09:18 |
| Cimi | Saviq, so I dimly separate them, but leave them unused in a folder? | 09:19 |
| Cimi | *simply | 09:19 |
| Saviq | Cimi, yes, and test them | 09:19 |
| Cimi | ok | 09:19 |
| Saviq | Cimi, they need to be self-contained, too | 09:19 |
| Saviq | Cimi, so the actual Audio { } component needs to be inside, too | 09:20 |
| Cimi | Saviq, but this will imply having one audio component per track | 09:20 |
| Saviq | Cimi, that's my next sentence | 09:20 |
| Saviq | Cimi, in this particular case, the widget needs to support a model, not just one item | 09:20 |
| Saviq | Cimi, so you need a Column+Repeater here | 09:21 |
| Cimi | ok | 09:21 |
| sil2100 | jamesh: hi! Sorry for the mediascanner2 LP problems - I actually thought that the team configuration I prepared was enough | 09:22 |
| MacSlow | tsdgeos, Saviq: same problem even after a reboot... but starting unity8 via the run script works as usual | 09:22 |
| sil2100 | jamesh: I made you an administrator of the mediascanner team now so you have ultimate power | 09:22 |
| jamesh | sil2100: yeah. It looked like mediascanner and mediascanner2 had the same ownership config, so I wonder what is different? | 09:22 |
| Saviq | MacSlow, if you have unity8 installed system-wide, remove ~/.config/upstart/unity8.conf | 09:22 |
| jamesh | I can certainly update things on the old project | 09:23 |
| Saviq | MacSlow, otherwise cp data/unity8.conf ~/.config/upstart/ | 09:23 |
| sil2100 | jamesh: that's indeed a valid question | 09:24 |
| MacSlow | Saviq, copying over data/unity8.conf to ~/.config/upstart did the trick... although I'm not seeing any of the assets (images) in the notifications | 09:26 |
| Saviq | Cimi, it won't be a real model, but an array of hashes instead, so access them like so: modelData['title'], modelData['subtitle'], modelData['source'] | 09:28 |
| Cimi | Saviq, so I'll just create a property var for this, and write a mock? | 09:29 |
| Saviq | Cimi, yup | 09:29 |
| MacSlow | tsdgeos, hm... with the fixed unity8.conf none of the notification ap-tests fail for me on the desktop (using trunk of both... unity-notifications and unity8) | 09:29 |
| tsdgeos | MacSlow: you sure you're using trunk unity-notifications? try usign http://10.98.3.7/archive//head.unity8/trusty/qtdeclarative5-unity-notifications-plugin_0.1.1+14.04.20131030.1bzr196pkg0trusty0-0ubuntu1_amd64.deb | 09:31 |
| * Saviq reboots | 09:31 | |
| MacSlow | tsdgeos, just pulled lp:unity-notifications about 30 minutes ago... | 09:31 |
| MacSlow | tsdgeos, I retry with that .deb | 09:32 |
| Saviq | MacSlow, I can confirm, with the .deb it fails | 09:38 |
| MacSlow | tsdgeos, Saviq: yes... that .deb also fails for me here. | 09:41 |
| tsdgeos | MacSlow: i have the same when using the deb that results from compiling unity-notifications trunk | 09:42 |
| tsdgeos | MacSlow: you sure you did install the deb after compiling it? | 09:42 |
| MacSlow | tsdgeos, Saviq: I'll work on the fix (for the test) now | 09:42 |
| MacSlow | tsdgeos, I saw that I used fixed trunk I did locally yesterday and copied over the wrong directory. | 09:43 |
| MacSlow | tsdgeos, sorry for the mixup | 09:43 |
| tsdgeos | mzanetti: ping | 09:47 |
| mzanetti | tsdgeos: pong | 09:48 |
| tsdgeos | mzanetti: i was having a look at https://bugs.launchpad.net/unity8/+bug/1271676 and found out it's because of the preview | 09:49 |
| ubot5 | Ubuntu bug 1271676 in Unity 8 "Launching an app from the app scope causes app scope to jump to the top" [High,Triaged] | 09:49 |
| mzanetti | hmm.. ok | 09:50 |
| tsdgeos | mzanetti: can it really happen in rendererLoader.item.onClicked that scopeView.scope.activate will trigger a preview? | 09:50 |
| mzanetti | yes.. that's how it normally works | 09:50 |
| mzanetti | for everything except installed apps | 09:50 |
| mzanetti | wait... need to read the code | 09:51 |
| tsdgeos | well, everything except installed apps goes through the else, no? | 09:51 |
| mzanetti | tsdgeos: true... should not happen in there | 09:52 |
| tsdgeos | so basically could move all the previewlist stuff inside the else? | 09:53 |
| mzanetti | I'd say yes... | 09:54 |
| mzanetti | when you guys are creating all the new Scopes API's, are you keeping the previews in mind? so we eventually will have a PreviewModel which is just filled with data instead of throwing all those pointer forth and back | 09:55 |
| Saviq | mhr3, see https://docs.google.com/a/canonical.com/document/d/1NmiM4UCnJgf6IEawmfyTOHRNAA5ZGrqpyrPqPOibwc8/edit#heading=h.6fng39a8onr for a reference on how data for widgets will be provided | 09:55 |
| Saviq | erm | 09:55 |
| Saviq | Cimi, ↑↑ | 09:55 |
| Saviq | mhr3, ignore | 09:55 |
| Cimi | Saviq, dziekuje | 09:56 |
| Saviq | Cimi, nie ma za co | 09:56 |
| Saviq | mzanetti, I'm not entirely sure what the lower-level plan is there, mhr3, pstolowski? | 09:57 |
| mhr3 | Saviq, meaning? | 09:57 |
| mhr3 | "lower-level plan"? | 09:57 |
| Saviq | mhr3, how will the plugin expose the preview as received from the scope? how will we match previews to result items? | 09:58 |
| mhr3 | Saviq, the plugin exposes previews as models of the widgets | 09:58 |
| mhr3 | you request a preview for specific result | 09:59 |
| Saviq | mhr3, current issue is the preview just comes in at a random time, and there's no way to associate it with a result item, and we're jumping all kinds of hoops because of that | 09:59 |
| Saviq | mhr3, yeah, but it comes back async, how do we match it back to the result? | 09:59 |
| mhr3 | Saviq, i changed the semantics the way i mentioned yesterday | 09:59 |
| mhr3 | Saviq, ie a preview request gives you back an empty model right away, once all data is there a signal is emitted | 10:00 |
| mhr3 | up to you to ignore it :) | 10:00 |
| mzanetti | ok.. the model right away is good | 10:00 |
| Saviq | yup, we can then associate it with the result | 10:00 |
| mzanetti | ideally it would be a model just the same size as the actual item model, just containing the prviewdata :) | 10:01 |
| tsdgeos | the day we get rid of | 10:01 |
| tsdgeos | terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >' | 10:01 |
| tsdgeos | what(): could not activate surface with eglMakeCurrent | 10:01 |
| tsdgeos | will be an awesome day | 10:01 |
| mzanetti | haha... indeed | 10:01 |
| mzanetti | but this one is not as bad as "address already in use" | 10:01 |
| mhr3 | mzanetti, hm, theoretically the result model could have previewdata role, a that thing would be filled in only if you asked for it | 10:03 |
| mhr3 | but that doesn't play overly nice with being able to do that lazily | 10:03 |
| mzanetti | mhr3: you can just fill the stuff on demand... | 10:04 |
| mzanetti | with an additionaly property, "loaded: bool" so we know if we should show the spinner instead | 10:04 |
| mzanetti | but we wouldn't need to catch a signal with a pointer later and try to find what it belongs to... | 10:05 |
| mhr3 | mzanetti, i can easily emit such a signal on the preview model itself if you want that | 10:06 |
| mzanetti | mhr3: for defining something I'm a bit far off the topic right now... would need to read through it again. | 10:06 |
| mzanetti | but I'm sure Saviq can handle this ;) | 10:07 |
| Saviq | mzanetti, mhr3, if a role in the model, it'd have to be a stack of previews (think payment confirmation page) | 10:07 |
| mzanetti | ah yeah... that's another issue | 10:07 |
| Saviq | which might not be an overly bad idea anyway | 10:07 |
| Saviq | mhr3, data() is only called on a role when that particular role is requested, so having that there might be a good enough idea | 10:09 |
| mhr3 | Saviq, but it's const :P | 10:09 |
| mhr3 | so isn't exactly lazy-init friendly | 10:09 |
| Saviq | mhr3, not like that can't be worked around ;) | 10:10 |
| mhr3 | but those workarounds are awful | 10:10 |
| Saviq | mhr3, we should write down all the usecases and see what's problematic where and why | 10:11 |
| Saviq | mzanetti, btw, remember how you spent countless hours to get the "highlight item under preview" work properly? | 10:11 |
| mzanetti | yeah | 10:12 |
| Saviq | mzanetti, you'll be pleased (?) to know it's going away completely - previews are going to cover full screen now | 10:12 |
| mzanetti | its totally broken all over already :/ | 10:12 |
| mzanetti | \o/ | 10:12 |
| Saviq | and there's going to be a back button, simply | 10:13 |
| mhr3 | Saviq, for me it doesn't feel right, previews can be dynamic and stuffing it into the model makes it feel like it's immutable | 10:14 |
| Saviq | mhr3, only the mapping between result and "preview stack" is immutable, what's in that preview stack is a different issue | 10:14 |
| mhr3 | still, you'll never need multiple previewstacks active | 10:17 |
| Saviq | mhr3, that is true | 10:17 |
| Saviq | mhr3, well, when switching between previews we will | 10:18 |
| Saviq | mhr3, can't destroy the old one before requesting / creating the new one | 10:18 |
| mhr3 | that's looking at it from a different angle | 10:18 |
| Saviq | mhr3, sure, the old one isn't "active" any more, and arguably we could just use a snapshot of it | 10:19 |
| Saviq | mhr3, OTOH it depends on how persistent their state is supposed to be | 10:19 |
| Saviq | mhr3, but I doubt it is meant to be persistent | 10:19 |
| mhr3 | and if you were deep in the stack and come back i would expect it to start over | 10:19 |
| Saviq | mhr3, you would probably be prevented from going away from an unconfirmed or cancelled page (again, preview confirmation) | 10:20 |
| Saviq | mhr3, and yeah, once you switch away you start over | 10:20 |
| mhr3 | Saviq, i'd say there isn't a strong need to put it in the result model | 10:21 |
| mhr3 | but we do have the option to change it if we do want it that way | 10:22 |
| Saviq | mhr3, sure, you're probably right, we can request a stack for a particular result on getting into a new preview, and the old one would get deleted when its preview page gets off screen | 10:22 |
| Saviq | mhr3, as long as you make sure that a preview for a particular result will always end up in the stack it's been requested for, it should be fine | 10:24 |
| dednick | mhr3: you going to be in office today? | 10:24 |
| mhr3 | dednick, yea, for 2nd half :) | 10:25 |
| mhr3 | Saviq, i think that navigating in the stack will be done by invoking methods of the preview itself | 10:26 |
| Saviq | mhr3, yeah, so they can be "confined" to that particular preview stack, sounds good to me | 10:26 |
| Saviq | mzanetti, ↑ ? | 10:27 |
| dednick | mhr3: hehe, now that you have to do your 8:30am start you're slacking off again?! | 10:27 |
| mhr3 | dednick, shush, you came in at 9:30, i can see it here, imagine you'd have to be there an hour earlier :P | 10:28 |
| dednick | um, yeah :) trip in was a bit of a mightmare | 10:29 |
| mzanetti | Saviq: not entirely following... but you know what the issues are with how it works right now... if you're happy with it I'm sure were fine | 10:29 |
| mhr3 | Saviq, anyway, we don't have api that would tell us about nested previews yet... cc pstolowski :) | 10:30 |
| Saviq | mzanetti, workflow would be like so: activating an item will get you an empty preview stack, that you can start displaying straight away, the preview data would come into that model and any subsequent preview interaction will be "confined" to that preview stack for that result | 10:30 |
| Saviq | mzanetti, when you switch to a different preview (left/right), you'd request another preview stack for that result, and drop the other one when it goes off screen | 10:31 |
| mzanetti | but that's mostly how it is right now, no? | 10:32 |
| Saviq | mzanetti, problem right now is that you don't get the model straight away | 10:32 |
| mzanetti | that's one, yes | 10:32 |
| Saviq | mzanetti, you request a preview and you never know when it'll come (hence the cancellation we did) | 10:32 |
| mzanetti | the other is that I need to build a model in qml which reflects the scope category but holds previews | 10:32 |
| mzanetti | have to run to a right-edge meeting now... | 10:33 |
| Saviq | mzanetti, yeah, but that model is only ever max 3 items, and the append/prepend operations are pretty simple I'd think | 10:33 |
| Saviq | mzanetti, sure | 10:33 |
| mhr3 | Saviq, what this means though is that we can't update the result models when preview is showing | 10:39 |
| mhr3 | (when we have async notifications about changes) | 10:39 |
| Saviq | mhr3, I think the fact that we're not showing the results any more precludes result updates anyway | 10:40 |
| Saviq | mhr3, as suddenly switching between items would get you somewhere you didn't expect | 10:40 |
| mhr3 | well that would be weird even if we were showing the results | 10:41 |
| mhr3 | plus weirdness like current result disappearing | 10:41 |
| karni | Saviq: I've probably spammed you a bit with merge proposals before I left yesterday"today" | 10:42 |
| Saviq | mhr3, indeed | 10:43 |
| Saviq | karni, it's fine, didn't respond to the emails, though, wanted to wait for you to show up | 10:43 |
| karni | Saviq: :) | 10:43 |
| karni | Saviq: fire at will when you have a moment, I'm all ears | 10:44 |
| Saviq | karni, re: carousel, yes I know the problem, didn't dig into it, though, Carousel has a huge number of properties I've no idea what they do ;P | 10:44 |
| karni | Saviq: so, it's something we're aware of? (i.e. there is a problem, and we already know)? | 10:45 |
| Saviq | karni, yes, we are aware, no one looked at a solution yet, though | 10:45 |
| karni | yeah, fixing that one will be challenging. | 10:45 |
| karni | Saviq: ack | 10:45 |
| Saviq | karni, as for the filtergrid, I suspect there's a binding loop somewhere there, and you're falling victim of that | 10:47 |
| karni | Saviq: It seemed like sometimes FilterGrid wouldn't "unwind", the opposite to the way it nicely collapses. The fix works fine, the problem only surfaces when you start *changing* collapsedRowCount in the mean time. | 10:49 |
| Saviq | karni, for https://code.launchpad.net/~saviq/unity8/fix-card-header-height/+merge/203411 - if you feel like it, approve away, otherwise we can ask mzanetti to put another set of eyes on it | 10:49 |
| karni | Saviq: can you explain me just one line from your MP? line 91, header.y + header.height | 10:50 |
| Saviq | karni, that's the lower edge of the header | 10:52 |
| Saviq | karni, so its top edge + its height | 10:52 |
| karni | Saviq: Right. I understand that, what I don't understand why would you test that against *height* | 10:52 |
| Saviq | karni, hmm let me look again | 10:53 |
| Saviq | karni, because that's the height I expect the card to be | 10:53 |
| Saviq | karni, we need the card's bottom edge to be the same with the header's bottom edge | 10:54 |
| karni | ha | 10:54 |
| karni | gotcha | 10:54 |
| karni | and we're only testing on 1 card, so bottom edge == height | 10:54 |
| karni | Saviq: I feel confident top approving this | 10:54 |
| Saviq | karni, go for it, then | 10:55 |
| karni | Saviq: how about https://code.launchpad.net/~unity-team/unity8/unity8-fix-carousel5/+merge/203444 ? | 10:59 |
| Saviq | karni, well, doesn't x <= 6 eq x < 5 for integers? ;) | 11:00 |
| Saviq | no it doesn't | 11:01 |
| karni | no :D | 11:01 |
| karni | hehehe | 11:01 |
| karni | ^ ^ | 11:01 |
| Saviq | karni, but anyway, I'd rather not touch that value in lp:unity8, as it's working fine here | 11:01 |
| Saviq | karni, make the test work with <= 6 for now | 11:01 |
| karni | Saviq: shall I rebase to new-scopes? | 11:01 |
| Saviq | karni, and we'll tweak it in new-scopes for the new rule, yes | 11:02 |
| karni | Saviq: ack! | 11:02 |
| Saviq | mzanetti, ok, shall we go through the release process then? | 11:09 |
| === _salem is now known as salem_ | ||
| Saviq | mzanetti, I'm thinking let's push trunk to lp:unity8/devel, uncommit trunk up to the latest release, propose a merge from devel to trunk, and go through the process with that? | 11:11 |
| Saviq | wonder how we can get the changelog message for this, though | 11:12 |
| karni | Saviq: okay, this effectively just adds a tests, that passes in unity8 trunk [1]. I'll get the tweak ready for new-scopes now, aye? [1] https://code.launchpad.net/~unity-team/unity8/unity8-fix-carousel5/+merge/203444 | 11:13 |
| Saviq | karni, yup | 11:13 |
| Saviq | karni, one thing: var renderer...var renderer - the second "var" is not needed, and will be frowned upon by qtcreator, for example | 11:15 |
| karni | Saviq: oh, that wasn't intentional. shall I fix? | 11:15 |
| Saviq | karni, yes please | 11:15 |
| karni | ok | 11:15 |
| Saviq | didrocks, do you have the daily release dch generator somewhere so that we could use it locally? | 11:16 |
| didrocks | Saviq: hum, it's a in library, but what are you trying to aciheve? | 11:16 |
| didrocks | achieve* | 11:16 |
| karni | Saviq: fixed | 11:16 |
| Saviq | didrocks, we're going the staging/devel branch route for lp:unity8 | 11:16 |
| didrocks | Saviq: hum, talk with asac, it's not what we want people to go with | 11:17 |
| Saviq | didrocks, as the overhead for Train CI is just to big for us for every MP | 11:17 |
| Saviq | *too | 11:17 |
| tsdgeos | didrocks: maybe you should not create guidelines that make it impossible to devel stuff if you don't want that | 11:17 |
| didrocks | Saviq: well, it seems you didn't even try it and already decided about the guidelines | 11:17 |
| didrocks | Saviq: would have been great that you try before talking about the overhead | 11:18 |
| didrocks | especially as you are bundling multiple MPs together | 11:18 |
| didrocks | so not sure what you mean by overhead | 11:18 |
| Saviq | didrocks, well, I wasn't even schooled yet, but we just know how long it takes to build/run the test suites locally | 11:18 |
| Saviq | didrocks, manual testing time | 11:18 |
| didrocks | Saviq: and you are not applying the same level of quality in your "devel trunk"? | 11:18 |
| tsdgeos | didrocks: we are not doing manual testing for a one liner, no | 11:19 |
| Saviq | didrocks, we do, but we let CI do the testing for us | 11:19 |
| tsdgeos | depending on the one liner of course :D | 11:19 |
| didrocks | tsdgeos: well, you can bundle multiple MPs all together | 11:19 |
| didrocks | and accept/reject all of them | 11:19 |
| tsdgeos | didrocks: that means that everyone has to wait for the very obvious oneliner fix because it has to be bundled | 11:19 |
| asac | Saviq: *shrug* ... i am with didrocks that you should really first try using the system and see how fast you can go before investing in workarounds | 11:19 |
| tsdgeos | bundling MPs is just a workaround for the thing being a pain | 11:20 |
| asac | Saviq: you realize that you can land 100 MPs in one shot if the quality your engineers submit is good | 11:20 |
| Saviq | didrocks, meaning that we can put several MPs into Approved, and land them all together? | 11:20 |
| didrocks | Saviq: right | 11:20 |
| Saviq | asac, no, I was not | 11:20 |
| asac | Saviq: thats the point :) | 11:20 |
| didrocks | as seb128 is doing with system-settings | 11:20 |
| Saviq | ok well that changes things | 11:21 |
| asac | Saviq: use the system for a bit... it ultimately is the same approach. you take a bunch of MPs, create a temp branch for everything you feel is safe to land | 11:21 |
| asac | and land it all in one shot ... | 11:21 |
| Saviq | asac, so if I need the temp branch, what's the difference between a staging branch that we merge periodically into trunk then? | 11:21 |
| didrocks | Saviq: look at https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AuDk72Lpx8U5dFlCc1VzeVZzWmdBZS11WERjdVc3dmc&usp=drive_web#gid=1 | 11:21 |
| didrocks | Saviq: see that there are 2 MPs listed here | 11:22 |
| didrocks | the merge is done for you | 11:22 |
| Saviq | so I don't need the temp branch | 11:22 |
| asac | Saviq: you disconnect the process | 11:22 |
| dednick | larsu: ping | 11:22 |
| asac | Saviq: the temp branch is created by the system for you (just used this to explain it) | 11:22 |
| asac | Saviq: how about you join and get trained? | 11:23 |
| Saviq | asac, I was planned to, but was off last week | 11:23 |
| asac | right. so lets move you in, then you will see | 11:23 |
| Saviq | asac, when's the next slot for training? | 11:24 |
| asac | Saviq: guess we can make a special session for you this week? | 11:24 |
| asac | didrocks: ? | 11:24 |
| asac | like in 1h :)? | 11:24 |
| asac | lol | 11:24 |
| larsu | dednick: hey, what's up? | 11:25 |
| dednick | larsu: howdy. q about the message indicator. It doesnt use telepathy does it? | 11:26 |
| Saviq | tsdgeos, +Component.onCompleted: console.log("SDFDFSD", scope.id) | 11:26 |
| tsdgeos | need that or won't work! | 11:27 |
| tsdgeos | j/k | 11:27 |
| larsu | dednick: no, but there's talk that it should | 11:27 |
| dednick | larsu: ok. | 11:27 |
| Saviq | asac, not necessary, we've got mzanetti and tsdgeos trained (although apparently there's been some miscommunication, then) | 11:27 |
| karni | Hrm... I pulled trunk and I have failing tests for testGenericScopeView, even though they were passing last evening. | 11:27 |
| tsdgeos | Saviq: i wasn't trained, just mzanetti | 11:28 |
| larsu | dednick: https://bugs.launchpad.net/indicator-messages/+bug/1267063/ | 11:28 |
| Saviq | tsdgeos, ah ok | 11:28 |
| ubot5 | Ubuntu bug 1267063 in indicator-messages (Ubuntu) "Retain user-selected presence state, optimize daemons usage" [Undecided,New] | 11:28 |
| mzanetti | Saviq: re (sorry. had to go to buy some food) | 11:28 |
| Saviq | mzanetti, don't be | 11:28 |
| Saviq | asac, didrocks, we'll get the first process through and I'll join the next planned slot | 11:28 |
| dednick | larsu: cool. thanks | 11:29 |
| didrocks | Saviq: we are going to do a landing with thostr_, I won't reash all the concepts, but I'm happy to prepare that with you in advance | 11:29 |
| Saviq | didrocks, I'm yours | 11:30 |
| didrocks | Saviq: do you have time like now for a quick hangout? | 11:30 |
| didrocks | so that I explain the basic workflow | 11:30 |
| didrocks | then, you will follow their first landing :) | 11:30 |
| Saviq | didrocks, sure | 11:31 |
| * didrocks is going to a free room | 11:32 | |
| didrocks | Saviq: https://plus.google.com/hangouts/_/76cpj79bppufnts1b6cjfcq8u8 | 11:36 |
| karni | mhr3: Cimi: in new-scopes, testGenericScopeView fails on test_hiddenPreviewOpen, test_previewCycle, test_previewOpenClose, test_showPreviewCarousel, test_show_spinner - are you guys aware of this? Is this because of undergoing preview work? | 11:43 |
| mhr3 | karni, the tests weren't much updated so far | 11:44 |
| karni | mhr3: okay, was just double checking you guys aware we have failing tests. | 11:44 |
| === MacSlow is now known as MacSlow|lunch | ||
| popey | tsdgeos: is https://bugs.launchpad.net/unity8/+bug/1271676 on your radar to be fixed soon? It's quite jarring and will be obvious when giving demos at MWC | 12:14 |
| ubot5 | Ubuntu bug 1271676 in Unity 8 "Launching an app from the app scope causes app scope to jump to the top" [High,Triaged] | 12:14 |
| tsdgeos | popey: it is fixed in a MR | 12:14 |
| tsdgeos | popey: needs a test, but then i found out an existing test was broken, so i'm fixing that test first | 12:14 |
| popey | ♥ | 12:14 |
| popey | thanks | 12:15 |
| tsdgeos | popey: so if you need it *now* ping saviq and we can fast track it without test | 12:15 |
| popey | not *now* but /soon/ | 12:15 |
| tsdgeos | otherwise wait till the end of the day and i hope i've fixed the mess | 12:15 |
| popey | great great! | 12:15 |
| popey | glad I asked | 12:15 |
| === dandrader is now known as dandrader|afk | ||
| tsdgeos | mzanetti: https://code.launchpad.net/~aacid/unity8/testCyclePreviewBroken/+merge/203529 | 12:41 |
| mzanetti | tsdgeos: hmm. fails to build | 12:44 |
| === dandrader|afk is now known as dandrader | ||
| tsdgeos | mzanetti: really? | 12:44 |
| mzanetti | crap... yeah. but my fault... it just printed mock preview warnings exactly before crapping out | 12:45 |
| tsdgeos | mzanetti: i changed 2 qml files, how can it fail to build? | 12:45 |
| mzanetti | ... what are the odds... | 12:45 |
| tsdgeos | mzanetti: it's not your fault really, it's my fault when i redid the previewlist to be global instead of per genericscope | 12:46 |
| mzanetti | tsdgeos: approved, thanks | 12:49 |
| * mzanetti goes back to the right edge animation | 12:50 | |
| karni | tsdgeos: hey, maybe you don't mind taking a look :)? https://code.launchpad.net/~unity-team/unity8/unity8-fix-carousel5/+merge/203444 | 12:51 |
| karni | tsdgeos: and tweak for new-scopes (that's what we decided with Saviq) https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-carousel5/+merge/203517 | 12:51 |
| karni | tsdgeos: If you prefer to leave it to Michał, that's fine | 12:52 |
| tsdgeos | he approved the first one already | 12:52 |
| tsdgeos | looks ok to me, i guess he'll aprrove the second one later | 12:53 |
| karni | tsdgeos: yeah, thanks :) | 12:53 |
| Saviq | tsdgeos, Cimi, dandrader, elopio, kgunn, greyback, mzanetti, karni, MacSlow|lunch, dednick: please have a look at https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8 and see if it sounds sane, bear in mind it's ultimately us who decide whether answers to those questions are good enough, so if e.g. there was no design review, because it's still too difficult to get it, it's fine | 13:01 |
| * dandrader reads on | 13:01 | |
| * karni looks | 13:01 | |
| Cimi | Saviq, how about setting an highlighted word to type that we all sync in our irc clients? so when we want to gather attention to the whole team we simply type that keyword | 13:02 |
| * mzanetti uses "all:" | 13:02 | |
| Saviq | Cimi, mzanetti, you decide ;) | 13:02 |
| Cimi | like unityuiteam: hello team | 13:02 |
| Cimi | I think it's nice | 13:03 |
| greyback | "expound" that not a word I see too often :) | 13:03 |
| mzanetti | causes a few false positives when someone pastes "dh_install:" error messages | 13:03 |
| Cimi | or cimirocks | 13:03 |
| mzanetti | lol | 13:03 |
| mzanetti | +1 ^^ | 13:03 |
| Cimi | cimirocks: standup | 13:03 |
| Cimi | :D | 13:03 |
| Cimi | cimirocks is actually my playstation network id :) | 13:03 |
| kgunn | i like uiteam | 13:04 |
| karni | Cimi: we used @all for hilight | 13:04 |
| Saviq | greyback, I had to look it up ;D | 13:04 |
| greyback | :) | 13:04 |
| kgunn | i actually use "expound" | 13:04 |
| karni | that worked for 2 of the teams I've been on | 13:04 |
| Cimi | karni, but a lot of people can say all | 13:04 |
| Saviq | kgunn, yeah, you wrote it, too | 13:04 |
| karni | Cimi: "@all" not "all" | 13:04 |
| Cimi | in normal chat | 13:04 |
| Cimi | karni, ok, other teams then :) | 13:04 |
| karni | Cimi: whatever works for you. this works for u1-client and phone delivery :) | 13:04 |
| Saviq | kgunn, I adapted the checklists a bit, hope the changes are fine with you: https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8?action=diff&rev2=18&rev1=16 | 13:05 |
| dandrader | Saviq, "Did you perform an exploratory manual test run of your code change? " would like to have "test run" properly defined. e.g.: run unity8 on the device and play around with it, performing a couple of fundamental usecases and something that your MP affects, if any" | 13:05 |
| karni | haha I like cimirocks | 13:05 |
| kgunn | Saviq: yep, looked good...i'm for paring them down to bare minimum | 13:05 |
| Cimi | karni, +1 ;) | 13:05 |
| Saviq | dandrader, we have the definition in https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8 | 13:05 |
| Saviq | dandrader, but it's more extensive than what we want per-MP | 13:06 |
| Saviq | dandrader, per-MP we just want to apply reason | 13:06 |
| === alan_g is now known as alan_g|lunch | ||
| mzanetti | Saviq: "First please copy & paste into the MP the checklist " <- into the description field? | 13:06 |
| greyback | Saviq: when you say "core-dev" you mean what exactly? (for the packaging change bullet point) | 13:06 |
| Saviq | greyback, right, I want it to be a team | 13:06 |
| kgunn | mzanetti: maybe into a comment ? | 13:06 |
| Saviq | greyback, but there isn't one yet | 13:06 |
| greyback | ok | 13:06 |
| Saviq | greyback, so ubuntu-unity, /me fixes | 13:07 |
| kgunn | if description is weird | 13:07 |
| mzanetti | Saviq: description can be altered, comments not | 13:07 |
| Saviq | kgunn, mzanetti I'm for description, yes | 13:07 |
| mzanetti | so you could change something from "no" to "yes" or add a better expound later :D | 13:07 |
| kgunn | right...i did think comment let's you reply to expound | 13:07 |
| kgunn | but i'm originally for description | 13:08 |
| kgunn | bbiab, a.m. house duties | 13:09 |
| dandrader | Saviq, not sure I got it. so "exploratory manual test" is more lax than https://wiki.ubuntu.com/Process/Merges/TestPlans/Unity8 ? | 13:11 |
| Saviq | dandrader, yes | 13:11 |
| Saviq | dandrader, it's more about testing your code change and any related functionality, rather than checking for regressions | 13:11 |
| mzanetti | Saviq: what's the plan on getting an image to test? | 13:12 |
| Saviq | mzanetti, add a ppa, dist-upgrade from it | 13:12 |
| dandrader | Saviq, ok. better have it written down there somewhere | 13:12 |
| Saviq | mzanetti, for now, will get improved later | 13:12 |
| mzanetti | Saviq: is that already working or tbd? | 13:12 |
| Saviq | mzanetti, works | 13:12 |
| mzanetti | which ppa? | 13:12 |
| Saviq | mzanetti, it's a per-landing silo | 13:13 |
| Saviq | mzanetti, https://launchpad.net/~ci-train-ppa-service/+archive/landing-004/ for example | 13:13 |
| Saviq | mzanetti, when you create a landing, you get assigned one of them | 13:14 |
| mzanetti | yep | 13:14 |
| mzanetti | didn't know it creates a ppa we can use | 13:14 |
| Saviq | mzanetti, the ppa is there, it just cleans it up and uploads new packages | 13:14 |
| Saviq | mzanetti, there's 10 "silos" at the moment | 13:15 |
| mzanetti | yeah, I know | 13:15 |
| Saviq | mzanetti, and each has a PPA | 13:15 |
| dandrader | Saviq, so the reviewer also changes the MP description? | 13:15 |
| Saviq | dandrader, yes | 13:15 |
| Saviq | dandrader, or well | 13:16 |
| Saviq | dandrader, actually maybe not | 13:16 |
| Saviq | dandrader, because there can be more reviewers | 13:16 |
| dandrader | Saviq, why not in a regular comment? | 13:16 |
| Saviq | dandrader, just changed | 13:17 |
| Saviq | dandrader, reviewers put their answers in review comments | 13:17 |
| dandrader | Saviq, so merging to trunk is going to be manually done by someone and that guy will perform the TestPlan? | 13:18 |
| Saviq | dandrader, no, not manually | 13:18 |
| Saviq | dandrader, the "Lander" lists the MPs to be landed in https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AuDk72Lpx8U5dFlCc1VzeVZzWmdBZS11WERjdVc3dmc&usp=drive_web#gid=0 | 13:18 |
| Saviq | dandrader, all the MPs are built into a corresponding PPA, the test plan is to be executed | 13:19 |
| Saviq | dandrader, packages are put into archive and code merged into trunks | 13:19 |
| karni | Saviq: You seem to be quite busy.. this one is almost the same as the one you approved, just for new-scopes: | 13:22 |
| karni | https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-carousel5/+merge/203517 | 13:23 |
| Saviq | karni, yeah, will wait for the one to trunk to merge | 13:23 |
| Saviq | karni, and merge trunk into new-scopes | 13:23 |
| karni | Saviq: ach, gotcha! | 13:23 |
| karni | :) | 13:23 |
| Saviq | karni, can you please fill the answers in https://code.launchpad.net/~unity-team/unity8/unity8-fix-carousel5/+merge/203444 | 13:23 |
| karni | sure | 13:23 |
| Saviq | dandrader, fill in answers in https://code.launchpad.net/~dandrader/unity8/draghandle_lp1269022/+merge/202484 please | 13:23 |
| Saviq | elopio, fill in answers in https://code.launchpad.net/~elopio/unity8/wait_for_category/+merge/202523 please | 13:24 |
| Saviq | karni, https://code.launchpad.net/~unity-team/unity8/unity8-fix-card-no-artimage/+merge/203520 here too | 13:25 |
| karni | ack | 13:25 |
| Saviq | tsdgeos, I already linked the OSK bug with the keyboard | 13:26 |
| kklimonda | hey, anyone got any idea how to disable alt+button1 window resize in 14.04? | 13:27 |
| Saviq | kklimonda, isn't that window move, not resize? | 13:28 |
| * karni uses it all the tim | 13:29 | |
| * Saviq too | 13:29 | |
| Saviq | kklimonda, regardless, dig into compizconfig-settings-manager | 13:29 |
| kklimonda | right, it's window move | 13:29 |
| === MacSlow|lunch is now known as MacSlow | ||
| kklimonda | I wouldn't try to disable it if it werent for the fact that it's messing the game I'm playing | 13:30 |
| kklimonda | I tried in ccsm, the setting is there indeed, but if I try changing, it gets reverted somehow | 13:31 |
| Saviq | kklimonda, I just disabled the "window move" plugin in ccsm and it worked fine? | 13:32 |
| kklimonda | Saviq: when I did that I couldn't move windows at all after restarting unity - a rather undesirect side-effect | 13:34 |
| Saviq | kklimonda, hmm indeed | 13:35 |
| Saviq | kklimonda, sounds like a bug, disabling the button1+Alt shortcut indeed does not seem to change anything here | 13:41 |
| seb128 | Saviq, do you know where is the default launcher config for unity8/touch? | 13:41 |
| Saviq | seb128, same as for desktop | 13:41 |
| seb128 | Saviq, is the config the same? | 13:41 |
| Saviq | seb128, no, we've an .override in place IIRC | 13:42 |
| Saviq | mzanetti ↑ correct? | 13:42 |
| seb128 | Saviq, right, what package is shipping the override is my question I guess | 13:42 |
| Saviq | seb128, gimme a minute please | 13:42 |
| mzanetti | yeah, correct | 13:42 |
| seb128 | Saviq, sure, thanks ;-) | 13:42 |
| mzanetti | seb128: its in ubuntu-touch-settings or however the package is called | 13:43 |
| Saviq | seb128, ↑ yup | 13:43 |
| karni | hrm. flashed trusty-proposed, applied demo-stuff, and scope-onlinemusic wouldn't show up | 13:43 |
| karni | aaah fuuu.. used -b when flashing, blew away my home | 13:44 |
| seb128 | Saviq, mzanetti: ok, got it, thanks | 13:44 |
| mzanetti | :D | 13:44 |
| Saviq | ouch | 13:44 |
| Saviq | karni, do you see any issues in ~/.cache/upstart/unity8.log? | 13:44 |
| * karni looks | 13:44 | |
| karni | Saviq: nothing immediately obvious, no. rebooting the device. | 13:46 |
| karni | still nothing. strange. will install anothe scope. | 13:48 |
| seb128 | Saviq, mzanetti: is there a design document or something describing what the launcher should include by default? that key seems out of sync with reality (seeing the number of elements listed compared to what is listed on the device) | 13:49 |
| Saviq | seb128, not that I know of | 13:49 |
| mzanetti | seb128: nope. I think ssweeny created this override | 13:49 |
| seb128 | ok | 13:49 |
| mzanetti | or cwayne | 13:49 |
| tsdgeos | Saviq: oki | 13:50 |
| seb128 | Saviq, mzanetti: do you any idea who I could ping in design to ask about what should be there? | 13:50 |
| mzanetti | hmm... vesar or JohnLea probably | 13:51 |
| Saviq | karni, https://code.launchpad.net/~unity-team/unity8/unity8-fix-card-no-artimage/+merge/203520/comments/474981 | 13:51 |
| seb128 | Saviq, mzanetti: in fact my initial goal was to add ubuntu-system-settings (mpt stated on the settings design that it should be in the launcher by default), but I'm happy to try to get the set sorted while I'm at it | 13:51 |
| seb128 | mzanetti, thanks | 13:51 |
| karni | Saviq: How about these? https://docs.google.com/a/canonical.com/document/d/1n880Fih5KyGPcoP5chidnHDG_8TxXUgSuij7f4rHpuk/edit?pli=1# | 13:51 |
| seb128 | Saviq, mzanetti: other question, do you if/how I can make ubuntu-system-settings be listed in the top items of the app lens (so it doesn't need to expand the section to see it)? | 13:52 |
| seb128 | mhr3, ^ | 13:52 |
| mhr3 | seb128, yes, change the qml :) | 13:52 |
| seb128 | mhr3, that's an hardcoded list? do you know what qml that is? | 13:53 |
| mhr3 | Apps/FrequentlyUsedAppsModel.qml: | 13:53 |
| karni | Saviq: so.. basically, it comes from the spec. and I believe it's something Scott tried to use, and had this empty art shape box | 13:54 |
| karni | so called "minimum configuration" (I'd call it minimal ;) configuration) | 13:54 |
| === alan_g|lunch is now known as alan_g | ||
| Saviq | /food | 14:02 |
| elopio | Saviq: reading the checklist, it looks a lot better than the default. Thanks. | 14:19 |
| elopio | Saviq: I'd add to make sure the code follows the code standards | 14:19 |
| elopio | Saviq: to check that all changes come with unit tests. | 14:20 |
| elopio | and to check that all changes to user stories have autopilot tests. | 14:20 |
| karni | Saviq: heh, dunno. installed another scope, rebooted the device, and music scope showed up. I think there was a known deadlock problem, it's not the first time I've seen this behavior (it was similar in trunk some time ago) | 14:25 |
| MacSlow | tsdgeos, Saviq: I've found the issue(s) in the ap-test causing the failure of unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call | 14:27 |
| tsdgeos | cool | 14:28 |
| MacSlow | tsdgeos, Saviq: lp:unity-notifications does not need to be touched at all | 14:28 |
| tsdgeos | nice | 14:28 |
| Saviq | elopio, right, will incorporate those somehow | 14:29 |
| MacSlow | tsdgeos, still it's odd... at least one of the found issues... the non-odd was changed paths for the graphics-assets | 14:29 |
| elopio | Saviq: I replied to the checklist on my two branches. | 14:31 |
| Saviq | elopio, cheers | 14:31 |
| mzanetti | cimirocks: standup! | 14:31 |
| Cimi | mzanetti, I'm in :P | 14:32 |
| mzanetti | Saviq: ^ | 14:32 |
| karni | Saviq: updated description, left comment: https://code.launchpad.net/~unity-team/unity8/unity8-fix-card-no-artimage/+merge/203520 | 14:32 |
| karni | ah, /me looks at + id: artImage possibly not used | 14:33 |
| kgunn | greyback: are you still in disagreement with this one ? | 14:34 |
| kgunn | https://bugs.launchpad.net/ubuntu/+source/unity-mir/+bug/1251330 | 14:34 |
| ubot5 | Ubuntu bug 1251330 in unity-mir (Ubuntu) "Keyboard orientation incorrect when brought up by side stage app" [Critical,New] | 14:34 |
| greyback | kgunn: my comment was poorly phrased - it is a bug, but I didn't think it was a qtubuntu bug | 14:35 |
| karni | Saviq: yeah, that was a left over. pushed update to that MP I liked above. | 14:35 |
| greyback | kgunn: since there's no OSK guy any more (and I know it a bit) I can take it on | 14:36 |
| kgunn | greyback: alternately...maybe dandrader could take a look | 14:36 |
| kgunn | ? | 14:36 |
| kgunn | greyback: worried you may be busy with rotation? | 14:37 |
| greyback | kgunn: sure | 14:37 |
| kgunn | dandrader: would you mind ? | 14:37 |
| kgunn | taking on the bug above ^^ | 14:37 |
| dandrader | kgunn, yeah, I could check this bug | 14:37 |
| dandrader | no problem | 14:38 |
| kgunn | dandrader: thanks | 14:39 |
| elopio | this is ready for review: https://code.launchpad.net/~elopio/unity8/generic_preview/+merge/202793 | 14:44 |
| elopio | can somebody please take a look? | 14:44 |
| tsdgeos | Saviq: commented in the two bugs i approved | 14:46 |
| Saviq | tsdgeos, thanks | 14:47 |
| MacSlow | tsdgeos, btw... do we have a bug-entry for the failing notification ap-test? | 14:47 |
| tsdgeos | MacSlow: not that i know | 14:48 |
| MacSlow | tsdgeos, just wondering if I can attach my fixing branch to a bug-# | 14:48 |
| MacSlow | tsdgeos, ok | 14:48 |
| vesar | seb128, Hi you were asking about the launcher default apps on the phone | 14:48 |
| seb128 | vesar, hey, yes | 14:48 |
| vesar | seb128, we have a design doc for launcher: https://docs.google.com/a/canonical.com/document/d/1OnCNVhXPDAE41zI_S8lou2xPQ4ILy5BysVy6tBfIw-g/edit# | 14:48 |
| vesar | seb128, but it a bit in working state and doesn't list any default apps at the moment | 14:49 |
| Saviq | greyback, you said you could help sil2100 with the OSK a bit? | 14:49 |
| vesar | seb128, the current set is from the bottom to top: Home, Telephony, Messeging, Contacts, Camera, Gallery, Browser | 14:50 |
| * sil2100 waves to greyback | 14:50 | |
| vesar | seb128, I think that's defined by mzanetti and to me it's a good set of apps. And I agree that system settings should be there as well. | 14:50 |
| sil2100 | greyback: you have a moment for some consulting? | 14:50 |
| greyback | sil2100: ok, gimme 10 mins | 14:51 |
| seb128 | vesar, mpt wrote in https://wiki.ubuntu.com/SystemSettings "“System Settings” should be in the Launcher by default"... | 14:51 |
| mzanetti | defined by mzanetti is wrong... | 14:51 |
| seb128 | vesar, ok, great, so I'm going to keep that list and add system-settings at the bottom | 14:51 |
| seb128 | vesar, works for you? | 14:51 |
| vesar | seb128, I would add it between Contacts and camera | 14:51 |
| vesar | seb128, Bottom most should always be the home icon | 14:52 |
| mzanetti | vesar: he means top-most | 14:52 |
| sil2100 | greyback: sure | 14:52 |
| mzanetti | seb128: vesar: bottom in the list == bottom-most on desktop - top-most on phone | 14:52 |
| mzanetti | given the phone-launcher is inverted | 14:52 |
| karni | Saviq: hey, I know you're swamped. I'll drop you my links on priv, and you'll get to them when you have a moment, okay? :) | 14:53 |
| vesar | mzanetti, seb128: I would give it a bit more priority and put it next to "phone essential" apps | 14:53 |
| seb128 | vesar, ok, that works for me, between contacts and camera it is | 14:53 |
| seb128 | vesar, mzanetti: thanks | 14:53 |
| Saviq | karni, I'm managing ;) | 14:53 |
| seb128 | mzanetti, reverse-order ack, I didn't think before writing ;-) | 14:53 |
| karni | Saviq: hehe | 14:54 |
| vesar | seb128, mzanetti: cool. works for me! I'll update the spec from that part | 14:54 |
| mzanetti | vesar: seb128: thanks. works for me too | 14:54 |
| greyback | sil2100: ok I'm free now | 14:54 |
| kgunn | mterry: so i'm gonna claim flu-fog :)...but can you explain how/why nested mir testing needs this | 14:57 |
| kgunn | https://code.launchpad.net/~unity-team/unity8/unity8.test_nested_mir/+merge/203088 | 14:57 |
| kgunn | alan_g: ^ | 14:57 |
| Saviq | karni, for https://code.launchpad.net/~unity-team/unity8/unity8-fix-card-no-artimage/+merge/203520 - I know it's not necessarily related | 14:58 |
| mterry | kgunn, that's an integration testing to make sure the unity8 session can talk to NetworkManager. This broke with nested mode because my 'switch-to-nested' branch accidentally misconfigured lightdm in a way that the user session was inactive, so it wasn't allowed to configure NetworkManager | 14:58 |
| karni | Saviq: Yes? | 14:58 |
| Saviq | karni, but it doesn't seem to react to card-size, nor center the title | 14:58 |
| karni | Saviq: Right, as far as centering the title - that's what I noted in the description. I wanted to get rid of an ugly rendering view (empty artShape) | 14:59 |
| Saviq | karni, the centering I don't think was implemented, but card-size should work (and I think it's not working because it relied on art size) | 14:59 |
| kgunn | mterry: ok...so more of a true integration test, not really directed at mir per se | 14:59 |
| === dandrader is now known as dandrader|bbl | ||
| karni | Saviq: Card size you say.. | 14:59 |
| mterry | kgunn, yeah. The bug wasn't really Mir at all | 14:59 |
| mterry | kgunn, just a misconfiguration of the new lightdm path I was using | 15:00 |
| kgunn | mterry: is that misconfig fixed ? | 15:00 |
| kgunn | e.g. if i go for another landing of mir 0.1.4 is it gonna work ? | 15:00 |
| mterry | kgunn, yeah, in my 'switch-to-nested' branch | 15:00 |
| mterry | kgunn, yes, because the bug & fix is in code that isn't a part of the image yet | 15:00 |
| * kgunn little confused as to how code not in the image got mir backed out 2 weeks ago.... | 15:01 | |
| kgunn | didrocks: ^ | 15:01 |
| mterry | kgunn, not Mir, I don't think. But my switch-to-nested branch got backed out | 15:01 |
| didrocks | kgunn: can you give me some context? | 15:01 |
| Saviq | tsdgeos, mzanetti https://code.launchpad.net/~aacid/unity8/testCyclePreviewBroken/+merge/203529 could we merge that, too? checlists, please | 15:03 |
| kgunn | didrocks: so mir 0.1.4 got backed out per the release mail, a couple of weeks back...and my understanding that backing out was tied to the nested feature...however, mterry is saying, the bug wasn't with mir, but his greeter branch | 15:04 |
| Saviq | dednick, tsdgeos, how about https://code.launchpad.net/~nick-dedekind/unity8/indicators.better-visible-items/+merge/201789 ? | 15:04 |
| karni | Saviq: ah ok. While it looked acceptably in horizontal, it looks pretty darn bad to just hide the art in vertical Cards. /me looks at Card sizing | 15:04 |
| kgunn | didrocks: meaning i've been holding off for a retry to promote mir...when in reality...it probably shouldn't have been back out | 15:04 |
| kgunn | ? | 15:04 |
| Saviq | karni, ah right, horizontal is always full-width, forgot about that | 15:04 |
| karni | Saviq: oh, it's okay, Card width is fixed, and height is == childrenRect.height. | 15:05 |
| mterry | kgunn, oh I didn't realize 0.1.4 was backed out | 15:05 |
| dednick | Saviq: it's ready to go... | 15:05 |
| karni | Saviq: so, it would just be better to make the view "gone" instead of "invisible" (in Android terms haha) | 15:05 |
| kgunn | didrocks: mterry ...its ok, i'm not mad...just want to get to where i can go re-try on mir promotion | 15:05 |
| dednick | unless that was a request to go through this new release process | 15:05 |
| karni | I can change it's width. | 15:05 |
| * karni investigates | 15:05 | |
| mterry | kgunn, the reason was because of the nested regressions? | 15:05 |
| kgunn | mterry: that's what the mails indicate.... | 15:05 |
| kgunn | again i was in flu fog...then travel | 15:06 |
| Saviq | dednick, can you fill the submitter checklist in there please | 15:06 |
| kgunn | poor excuses...but anyway | 15:06 |
| mterry | kgunn, huh. Yeah, all that needed to be backed out IIRC was my enable-nested branch | 15:06 |
| kgunn | mterry: thanks...just trying to confirm here with didrocks if he remembers some other reason mir was backed out | 15:06 |
| tsdgeos | Saviq: for the first yes, could merge it | 15:07 |
| tsdgeos | Saviq: for the second, still need to do more stuff i'd say | 15:07 |
| Saviq | tsdgeos, ok | 15:07 |
| Saviq | tsdgeos, mzanetti, can you please fill in checklists for https://code.launchpad.net/~aacid/unity8/testCyclePreviewBroken/+merge/203529 | 15:07 |
| elopio | Saviq: thinking about an extra point for the landing checklist: | 15:07 |
| elopio | if the UI change is big, ping davmor2 to make sure he will do an extra exploratory testing on that section when the image is ready. | 15:07 |
| tsdgeos | Saviq: https://code.launchpad.net/~aacid/unity8/delegateRangeBugfix is quite visually bad in the phone (once you know how to trigger it), but i understand noone has had time to review it yet | 15:08 |
| mzanetti | kk | 15:08 |
| karni | Saviq: setting artShape width to 0 is the proper way to hide it? (like you did with comment field height) | 15:08 |
| Saviq | elopio, that'd be for the landing checklists, though? | 15:08 |
| dednick | Saviq: done | 15:08 |
| karni | It bothers me, because the view is still in the hierarchy. Meh. | 15:08 |
| Saviq | karni, we could try and use a Flow there | 15:08 |
| * karni reads | 15:08 | |
| Saviq | karni, it will disregard invisible items and not position them | 15:09 |
| davmor2 | elopio: also let me know what is meant to of changed | 15:09 |
| Saviq | tsdgeos, it's fine, we don't have to release everything today | 15:09 |
| elopio | Saviq: yes, before it's considered to go into the new image. | 15:09 |
| karni | Saviq: sounds interesting. looking at docs. | 15:09 |
| Saviq | karni, that's something that anchors can't do | 15:09 |
| Saviq | or childrenRect, for that matter | 15:09 |
| tsdgeos | Saviq: ok, done my part | 15:10 |
| Saviq | tsdgeos, thanks | 15:10 |
| mzanetti | Saviq: "Did CI run pass? If not, please explain why. " Is this really to be answered by the reviewer? | 15:11 |
| Saviq | mzanetti, I think so, yes - in case it did not pass, the reviewer needs to have a good excuse to approve anyway | 15:11 |
| mzanetti | Saviq: but we're not going to merge to trunk if it doesn't pass | 15:12 |
| Saviq | mzanetti, in this case, yes we will | 15:12 |
| Saviq | mzanetti, 'cause we have an unrelated failure that's not fixed yet | 15:12 |
| mzanetti | meh... | 15:12 |
| Saviq | mzanetti, but we don't want it to block us | 15:12 |
| Saviq | mzanetti, it should be a rare occurence for sure | 15:13 |
| mzanetti | also in this case we shouldn't merge it imho | 15:13 |
| mzanetti | as long as ci isn't passing | 15:13 |
| mzanetti | a unrelated failure might hide a real one | 15:13 |
| karni | Saviq: sounds good. and sounds like a significant update to Card code (which I'd be happy to take on). I'd like that versus the fact that by Thursday/Friday we need to decide whether we're go or no-go with new scopes API for MWC :| Would it make sense to size down the artShape to (0,0) if the artImage source is not set for time being, or that's plain dirty? If it sounds bad, let's shelve that work for couple hours, and I'll ask Scott if we ... | 15:13 |
| karni | ... need that as opposed to other minor fixes. | 15:13 |
| Saviq | karni, it's fine | 15:14 |
| Saviq | karni, to size it to 0,0 I mean | 15:14 |
| karni | Saviq: ok, I'll try that | 15:14 |
| karni | it should look fine | 15:14 |
| MacSlow | tsdgeos, could you give lp:~macslow/unity8/unity8.fix-test_sd_incoming_call a try and verify it fixes the autopilot-test failure of unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call for you too. | 15:14 |
| MacSlow | tsdgeos, used lp:unity-notification trunk with this | 15:15 |
| Saviq | mzanetti, ↑ we might not need to merge with failure in the end | 15:15 |
| tsdgeos | MacSlow: just create a merge request and see if CI is happy | 15:15 |
| mzanetti | Saviq: yeah... that's what I thought | 15:15 |
| tsdgeos | MacSlow: i'll check asap, but want to finish something first | 15:15 |
| MacSlow | tsdgeos, ok... just wanted to point you to the fixing branch | 15:16 |
| Saviq | mzanetti, I know, it's a rare occasion, but when CI is failing on us for random reasons, we need to be able to override | 15:16 |
| Saviq | mzanetti, that question just gives us the ability to do so | 15:16 |
| mzanetti | ok... | 15:16 |
| elopio | Saviq, mzanetti: if it's not a common practice, for me, that flexibility is ok. Just please make sure there's a critical bug for the unstable test, and it's schedule to be fixed really soon. | 15:17 |
| Saviq | elopio, yup | 15:17 |
| mzanetti | I think we should use this only for *very* rare exception. i.e. release deadline and the test cannot be fixed by then | 15:18 |
| Saviq | MacSlow, I'm getting the same failure still with the downloaded package | 15:20 |
| MacSlow | Saviq, :/ | 15:21 |
| Saviq | didrocks, Ready → yes | 15:21 |
| MacSlow | Saviq, you're talking about the .deb tsdgeos mentioned yesterday? | 15:22 |
| Saviq | MacSlow, yes, from naartije | 15:22 |
| Saviq | MacSlow, http://10.98.3.7/archive//head.unity8/trusty/qtdeclarative5-unity-notifications-plugin_0.1.1+14.04.20131030.1bzr196pkg0trusty0-0ubuntu1_amd64.deb | 15:22 |
| MacSlow | Saviq, I used lp:unity-notifications and compiled the .deb locally and installed that... with that it worked | 15:23 |
| Saviq | MacSlow, will try | 15:23 |
| MacSlow | Saviq, I'll try that precompiled .deb again too | 15:24 |
| Saviq | dandrader|bbl, why "not yet" for the manual testing? didn't you check that your code fix the issue? | 15:24 |
| Saviq | sil2100, could we get a landing silo for unity8? | 15:29 |
| Mirv | Saviq: mumble? | 15:31 |
| Saviq | Mirv, yup, coming | 15:31 |
| Mirv | greyback: bzoltan is asking if you could join too | 15:31 |
| greyback | Mirv: uhh ok | 15:32 |
| Saviq | MacSlow, nope, built from trunk, same failure | 15:32 |
| sil2100 | Saviq: uno momento ;) | 15:33 |
| Saviq | sil2100, just uno? I can live with that :) | 15:33 |
| MacSlow | Saviq, misssed a change to commit... just verified again that it works... both with the prebuilt .deb and lp:unity-notifications trunk | 15:38 |
| MacSlow | tsdgeos, ^ | 15:38 |
| Saviq | MacSlow, +1 | 15:39 |
| sil2100 | Saviq: silo assigned, let's wait for it to be ready and you can build ;) | 15:39 |
| Saviq | sil2100, actually sorry, I just added one more MP, you need to reconfigure the silo don't you? | 15:42 |
| sil2100 | Saviq: oh noes! Give me a moment | 15:43 |
| Saviq | sil2100, sooorry | 15:44 |
| Saviq | MacSlow, FWIW, I still don't get the assets | 15:44 |
| MacSlow | Saviq, hm | 15:46 |
| Saviq | MacSlow, ah, os.getcwd() assumes you run the tests in tests/autopilot | 15:46 |
| Saviq | MacSlow, you should use os.path.dirname(__file__) | 15:46 |
| MacSlow | Saviq, trying... | 15:46 |
| Mirv | Saviq: did you mean this or something similar? http://iso.qa.ubuntu.com/qatracker/milestones/270/builds/50650/testcases | 15:47 |
| Saviq | MacSlow, actually you need os.path.abspath(__file__) first | 15:48 |
| Saviq | Mirv, no, http://ci.ubuntu.com/smokeng/trusty/touch/mako/150:20140128:20140115.1/6308/ | 15:48 |
| Mirv | Saviq: ah, yes, the usual, right | 15:48 |
| Saviq | Mirv, yup | 15:48 |
| karni | Saviq: Is there any obvious problem with this code? I also tried regular if else clause - test_art_layout(Horizontal) fails, and one dumps core haha. http://paste.ubuntu.com/6832660/ | 15:49 |
| karni | that, applied to lp:~unity-team/unity8/unity8-fix-card-no-artimage | 15:50 |
| Saviq | karni, I don't think ? : should be used within | 15:50 |
| Saviq | karni, I mean the interpreter might get confused | 15:51 |
| Saviq | karni, which : belongs to which ? | 15:51 |
| karni | that's okay, let me confirm the regular if-else didn't work :) | 15:51 |
| karni | sure, I'll change that | 15:51 |
| Saviq | MacSlow, os.path.dirname(__file__) + "/../../../../../qml/graphics/" + icon_name | 15:52 |
| Saviq | MacSlow, instead of os.path.abspath)_ | 15:52 |
| Saviq | erm | 15:52 |
| Saviq | instead of os.path.getcwd() | 15:52 |
| karni | Saviq: it looks great, it just freaks out on tests :| http://paste.ubuntu.com/6832681/ | 15:54 |
| sil2100 | Saviq: I reconfigured it a moment ago, should be ok now! | 15:54 |
| Saviq | sil2100, thanks, and sorry for that :) | 15:54 |
| dandrader|bbl | Saviq, I checked on my desktop. didn't run on the device | 15:54 |
| dandrader|bbl | Saviq, and used "make tryDragHandle" for that | 15:55 |
| Saviq | dandrader, I'd say that's enough for the "apply reason" part of the test | 15:55 |
| * dandrader|bbl "bbl" for good now. taking dog to the vet. | 15:56 | |
| Saviq | karni, the segfaults I've had happening sometimes - it's a race - try adding a wait(50) at the beginning of the test to see that it settles | 15:56 |
| Saviq | karni, the failure looks legit, though | 15:56 |
| karni | Saviq: I also tested this on new-scopes branch. Looks great, like I said :| | 15:56 |
| karni | ok, I'll have to track down which test segfaults. re: the failure, no idea - the art is visible, so the change should not apply :/ | 15:57 |
| Saviq | karni, can you visually confirm that everything's ok? | 16:00 |
| karni | Saviq: yes, let me run through the tests without change right after my teams SU | 16:00 |
| sao | hey all I am trying to create a new master scope but could't find any documentation - see question here http://askubuntu.com/questions/390683/what-to-do-when-my-scope-does-not-fit-into-any-master-scope anyone has a hint? | 16:03 |
| karni | Saviq: yes, I went visually through all cases, all look exactly the same, excluding my case - which shrinks the artShape to (0,0) | 16:03 |
| davidcalle | sao, hi, is it a master specific for your scope? | 16:04 |
| davidcalle | sao, or do you want to enter an existing master scope? | 16:05 |
| sao | davidcalle no it would for a clipboard related content | 16:05 |
| sao | davidcalle and the clipboard manager I am writing could be one of the scope providing information for that master scope | 16:06 |
| davidcalle | sao, one interesting thing to know is that you don't need a master scope. You can just add your .scope file to /usr/share/unity/scopes/ and kill unity-scope-home, this will add it to the Home scope. Then, if you want a Dash bar icon with a specific view for your scope, you just need to open dconf-tool and add your scope to the list at com.canonical.unity.dash.scopes | 16:10 |
| Saviq | karni, so at least when looking at the test run, the layout gets confused and you can see that the art is pushed away from the left | 16:11 |
| karni | brb SU | 16:12 |
| * karni looks | 16:13 | |
| sao | davidcalle That sounds fairly easy. I haven't tried this yet. This should then also support categories right? | 16:13 |
| davidcalle | sao, on the other hand, if you want a master to aggregate several scopes : look at /usr/share/unity/scopes/books.scope and replicate it for your needs. The thing you need to pay attention to are the categories declarations, they need to be the same as the ones used by your scope(s). | 16:14 |
| karni | does make support cherry picking test to run? | 16:15 |
| davidcalle | sao, sure, if you add a Dash bar icon. Categories will be mixed into one when in the Home scope. | 16:15 |
| davidcalle | will always* | 16:16 |
| sao | davidcalle OK I will try this then just having a lens with a cateogry icon. Just out of curiosity in the books.scope the group name is com.canonical.Unity.Scope.Home resp uniquename /com/canonical/unity/masterscope/books. How would I provide this in my own scope service? Is there a special class? | 16:19 |
| Saviq | karni, no | 16:19 |
| sao | davidcalle considering when I would write my own master scope of course with adjusted unique name and group name. | 16:20 |
| karni | Saviq: heh. adding wait(50) at the beginning of all tests makes them pass. | 16:20 |
| Saviq | karni, you'd need to get the qmltestrunner command from the make | 16:20 |
| karni | Saviq: Is that acceptable "fix" for the test suite? | 16:20 |
| karni | Saviq: ack | 16:20 |
| Saviq | karni, hmm pass? they don't segfault here, but still fail... | 16:20 |
| karni | ah wait.. | 16:20 |
| karni | Saviq: ignore me. I was rushing, had stuff shelved. yeah, 2 failing. | 16:21 |
| davidcalle | sao, look at the tuto http://developer.ubuntu.com/scopes/tutorial/, step 1 in Defining the scope | 16:22 |
| davidcalle | sao, oh wait, misunderstood your question | 16:22 |
| === greyback is now known as greyback|food | ||
| davidcalle | sao, you create a /usr/share/unity/scopes/<scope name> folder, where you put .scope files of your various scopes. That's it. | 16:23 |
| Saviq | sil2100, didrocks, does that build look right https://launchpad.net/~ci-train-ppa-service/+archive/landing-003/+build/5530676 ? | 16:24 |
| Saviq | it only says "Start" for a few minutes now | 16:24 |
| karni | Saviq: test_art_size(HorizontalWidth) was seg faulting here, added wait(50), now 2 tests failing. looking into it (like I have been for a while :)) | 16:24 |
| sil2100 | Saviq: uh wtf, never saw anything like that | 16:25 |
| sil2100 | didrocks: ^ ? | 16:25 |
| Saviq | karni, yeah, it's kinda weird, TBH, as you can see for the 5s when it's checking the value, that the art is shifted to the right somehow | 16:25 |
| Saviq | karni, couldn't come up with why, though | 16:25 |
| karni | Saviq: ack, thank you. I agree, something's wrong, even though the change shouldn't have caused that behavior. | 16:26 |
| tsdgeos | MacSlow: your MR doesn't follow the new processes | 16:26 |
| tsdgeos | MacSlow: need to answer all those questions | 16:26 |
| MacSlow | tsdgeos, yeah... :) | 16:26 |
| MacSlow | tsdgeos, fixing... | 16:26 |
| sao | davidcalle OK. I thought I tried this and had an error that a function was missing in the dbus unique name I had defined in the master scope file. Cannot rember the exact error message though. I will try again and will otherwise ask again if it doesn't work. Thanks a lot for your ideas. | 16:26 |
| tsdgeos | MacSlow: so did you kill the placeholder notification we had in unity-notifications? | 16:27 |
| Saviq | karni, can you paste your `bzr diff --old=lp:unity8` please? I want to try something | 16:27 |
| karni | sure | 16:27 |
| karni | Saviq: appreciated :) http://paste.ubuntu.com/6832847/ | 16:28 |
| davidcalle | sao, sure, no problem :) | 16:28 |
| Saviq | karni, I wanted the wait(50)s, too ;) | 16:28 |
| karni | Saviq: in all tests? | 16:29 |
| karni | I can add them | 16:29 |
| Saviq | karni, nvm, I'll manage | 16:29 |
| MacSlow | tsdgeos, not that I'm aware of... but I need to check something related anyway and look after that too | 16:29 |
| karni | that one fixes the segfault I had | 16:29 |
| tsdgeos | or it's still there? | 16:29 |
| tsdgeos | seems there | 16:29 |
| tsdgeos | MacSlow: works here fwiw | 16:30 |
| MacSlow | tsdgeos, the MR-branch?! | 16:30 |
| === mhr3__ is now known as mhr3 | ||
| tsdgeos | MacSlow: yes | 16:35 |
| karni | added this to UbuntuShape, all tests pass: anchors.left: template && template["card-layout"] === "horizontal" ? parent.left : undefined | 16:36 |
| karni | Saviq: ↑ What do you think.. ? I have mixed feelings heh. | 16:36 |
| Saviq | karni, all pass? didn't for me, but that's exactly what I did | 16:36 |
| Saviq | karni, and it's kind of correct, as when the anchor is lifted, the shape doesn't really know where to go | 16:37 |
| karni | Saviq: yes, visual inspection also fine. that's the only line I changed from the diff I sent | 16:37 |
| karni | Saviq: like.. if it's not horizontal, what does the anchor.left === undefined mean? Left aligned? It's unclear to me. | 16:38 |
| Saviq | karni, it doesn't mean anything, that's the thing | 16:38 |
| Saviq | karni, it's undefined, so if an item was applied an anchor, and then that only anchor got lifted | 16:39 |
| Saviq | karni, then it won't do anything | 16:39 |
| Saviq | karni, it will treat itself like it had x/y defined (that resulted from the anchor) | 16:39 |
| karni | ok. so basically we had missing anchor.left in horizontal layout. that makes sense. | 16:40 |
| karni | why it didn't work before - that I don't understand. | 16:40 |
| karni | why it *did* work, sorry. | 16:40 |
| karni | Saviq: want to mumble for a sec about this.. ? | 16:40 |
| Saviq | karni, am there | 16:40 |
| karni | Saviq: can you hear me? | 16:41 |
| karni | mumble dance | 16:41 |
| Saviq | tsdgeos, did you do something for your phablet user to not have /sbin in its path? | 16:47 |
| tsdgeos | Saviq: do you have it? | 16:49 |
| Saviq | tsdgeos, yeah, our AP tests wouldn't work if it wasn't there by default | 16:49 |
| tsdgeos | http://paste.ubuntu.com/6832966/ | 16:49 |
| tsdgeos | Saviq: ↑ | 16:50 |
| tsdgeos | that's an almost clean phablet-flash'ed thing | 16:50 |
| MacSlow | tsdgeos, the placeholder is still there being added to the model upon is contruction... just checked lp:unity-notifications | 16:50 |
| Saviq | tsdgeos, ah, I wonder if su - phablet is broken | 16:50 |
| tsdgeos | su phablet | 16:50 |
| tsdgeos | does indeed give me /sbin | 16:50 |
| Saviq | tsdgeos, sudo -u phablet -i | 16:51 |
| Saviq | tsdgeos, that's what I use, and is recommended | 16:51 |
| Saviq | tsdgeos, your change is good nevertheless, but was just wondering | 16:51 |
| === greyback|food is now known as greyback | ||
| MacSlow | tsdgeos, I'll update the ap-tests for the new visual snap-decisions queue feature anyway and will also add a placeholder-related test along the way | 16:51 |
| karni | Saviq: Is this a legal QML/JS operation? Because I refactored the isHorizontal function as well (line 5 of diff) and that works, but hasArt does not. http://paste.ubuntu.com/6832974/ | 16:52 |
| karni | I could have pushed without this, but it makes it so much more readable. | 16:52 |
| Saviq | karni, this breaks bindings | 16:53 |
| Saviq | karni, and you'd need () in there anyway | 16:53 |
| Saviq | karni, basically, you have to think of anything that's after : in a propert | 16:53 |
| karni | Thought so (about bindings). thanks :) | 16:53 |
| Saviq | karni, that's what the binding will be updated on | 16:53 |
| karni | Saviq: What if I used Qt.binding(hasArt) ? | 16:53 |
| karni | still no go? | 16:53 |
| Saviq | karni, still, the thing that changes must be explicitly called out | 16:54 |
| karni | Qt.binding(function() { return cardData && ... }) would work | 16:54 |
| Saviq | karni, otherwise Qt would have to introspec the function | 16:54 |
| karni | I see, thank you | 16:54 |
| Saviq | karni, yeah, but that's the default | 16:54 |
| Saviq | i.e. | 16:54 |
| Saviq | prop: foo === prop: Qt.binding(function() { return foo; }) | 16:54 |
| karni | too bad. QML is pretty smart already, tho :) | 16:54 |
| Saviq | the important difference is: | 16:54 |
| Saviq | prop = foo; !== prop = Qt.binding(function() { return foo; }); | 16:55 |
| Saviq | so when you assign a value in javascript | 16:55 |
| Saviq | that's when you need Qt.binding, otherwise it's a one-time assignment | 16:55 |
| Saviq | karni, FWIW "|| false" is not needed | 16:55 |
| karni | aha | 16:55 |
| Saviq | as undefined && undefined evaluate to undefined, whose boolean is false | 16:56 |
| karni | Saviq: right, that assignment thing causes me a tiny bit of troble, but I guess with time I'll wrap my head aroud it :) | 16:56 |
| karni | a, great | 16:56 |
| Saviq | so "undefined && undefined || false" === "undefined && undefined" | 16:56 |
| karni | :) | 16:56 |
| Saviq | karni, one tricky thing here, though: | 16:57 |
| Saviq | karni, "" || "foo" evaluates to "foo", not true | 16:57 |
| karni | :D | 16:58 |
| Saviq | karni, so "" || "foo" === "foo"; "" || "foo" == true; "" || "foo" !== true | 16:58 |
| Saviq | so if you go: | 16:58 |
| Saviq | o && o["prop"] | 16:58 |
| karni | got it! :) | 16:58 |
| Saviq | that evaluates to o (when it's boolean false) or o["prop"] (when o is boolean true) | 16:59 |
| Saviq | karni, it's a shortcut for: | 16:59 |
| karni | this is so much fun :D | 16:59 |
| Saviq | o && o["prop"] ? o["prop"] : undefined | 16:59 |
| Saviq | for example | 16:59 |
| Saviq | only problem is you don't have control of the "negative" value | 17:00 |
| karni | I'll re-read it all, thank you for the explanation, thanks so much :) | 17:00 |
| karni | Saviq: fixed and pushed. https://code.launchpad.net/~unity-team/unity8/unity8-fix-card-no-artimage/+merge/203520 | 17:14 |
| Saviq | karni, you don't need the wait() | 17:19 |
| Saviq | karni, it only really helps when there are failures | 17:19 |
| karni | Saviq: it still seg faulted here Michał :( | 17:19 |
| karni | that very test, on a single (last?) case | 17:20 |
| Saviq | karni, hmm, does not, here | 17:20 |
| karni | I could try running tests without | 17:20 |
| Saviq | karni, please do | 17:20 |
| Saviq | karni, also, compare() is generally dangerous, but in this case you've a tryCompare() before, so should be fine | 17:20 |
| karni | Saviq: pff.. now it doesn't segfault. pushed change | 17:21 |
| Saviq | karni, yeah, I found that it only segvs when it's failing | 17:21 |
| karni | :D | 17:21 |
| karni | Saviq: how about slapping a sweet +1 on this, too :) you've read the trunk counterpart. https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-carousel5/+merge/203517 | 17:25 |
| Saviq | karni, don't want this before we merge the trunk counterpart to see the actual diff | 17:25 |
| karni | \o/ thanks for reviewing and help on that no-artmage branch, Saviq, you rock | 17:25 |
| karni | Saviq: blarhg, right! you said it before | 17:25 |
| karni | :) | 17:25 |
| Saviq | karni, FWIW you should be able to set the other one as prerequisite | 17:26 |
| Saviq | karni, LP should then realize | 17:26 |
| Saviq | what the actual diff is | 17:26 |
| karni | Saviq: done, and resubmitted | 17:26 |
| Saviq | karni, will hopefully be done before you're up tomorrow | 17:27 |
| karni | w00t | 17:27 |
| Saviq | karni, I'm going for food now o/ | 17:27 |
| karni | Saviq: enjoy!! :) | 17:27 |
| karni | o/ | 17:27 |
| Saviq | sil2100, apparently was a buildds issue, back on track | 17:29 |
| karni | it's marked as superceded :/ ayay, I marked a prerequisite, but they have differen't parents | 17:29 |
| karni | approved one goes to trunk, that one awaits trunk, but goes to new-scopes | 17:29 |
| Saviq | karni, well, they have a common ancestor nevertheless, so thought it'd work :? | 17:29 |
| karni | I think only if they're proposed to be merged to same branch, which is not the case | 17:30 |
| karni | don't worry. I'll resubmit if I can. | 17:30 |
| karni | can't resubmit. I'll prepare a new one. | 17:31 |
| karni | d'oh, resubmit proposal => new URL | 17:37 |
| karni | here it is, safe and sound. https://code.launchpad.net/~unity-team/unity8/new-scopes-fix-carousel5/+merge/203597 | 17:37 |
| === alan_g is now known as alan_g|EOD | ||
| kgunn | bbiab | 18:06 |
| === dandrader|bbl is now known as dandrader | ||
| karni | -> eod | 18:22 |
| dandrader | greyback, when I hold the tablet in portrait mode, what should happen to the app in the side stage? | 19:01 |
| dandrader | or to the side stage itself | 19:02 |
| greyback | dandrader: rotation not supported by shell, so sidestage remains open and the app inside rotates if it wants | 19:02 |
| dandrader | greyback, does an application know somehow it's on the side stage? I mean, is there any global variable or anything telling it | 19:25 |
| Saviq | dandrader, why would it need to? | 19:26 |
| greyback | dandrader: not that I'm aware of. The qpa plugin does know, but if that info is available higher up, I don't know | 19:26 |
| dandrader | Saviq, I don't know, just asking | 19:26 |
| Saviq | dandrader, greyback, ultimately when you change orientation, side stage should follow | 19:27 |
| * dandrader is trying to get familiar with how all that side stage magic happens | 19:27 | |
| Saviq | to always be on the right edge, that is | 19:27 |
| dandrader | Saviq, would look horrible | 19:27 |
| Saviq | dandrader, what would? side stage in portrait? | 19:27 |
| dandrader | Saviq, yes | 19:28 |
| Saviq | dandrader, even worse when it becomes bottom-stage ;) | 19:28 |
| dandrader | Saviq, does it even makes sense in terms of usability | 19:28 |
| dandrader | Saviq, also horrible | 19:28 |
| dandrader | IMHO a side stage only makes sense when the device is in landscape | 19:29 |
| dandrader | Saviq, are there other OSes implementing this concept? what do they do? | 19:29 |
| Saviq | dandrader, on one hand I agree, on the other what happens with apps that can only support phone layout | 19:29 |
| Saviq | dandrader, Win8 on tablet does, not sure what it does in portrait | 19:29 |
| dandrader | Saviq, is there a design doc or something explaining all those side stage situations and corner cases? | 19:30 |
| Saviq | dandrader, the closest I know of is https://drive.google.com/a/canonical.com/folderview?id=0B2WkkoWiZT_TVVpRbWZHaUZYR0U | 19:31 |
| Saviq | dandrader, but I'm not sure it deals with those details, we've only gotten somewhere with the right edge last week | 19:32 |
| Saviq | dandrader, and I probably don't have all the details atm | 19:32 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === salem_ is now known as _salem | ||
| === seb128_ is now known as seb128 | ||
| kdub_ | building platform-api, i get not able to find #include <org/freedesktop/dbus/codec.h>, anyone know a workaround? | 22:22 |
| greyback | kdub_: file appears to be in dbus-cpp-dev | 22:42 |
| greyback | surely apt-get build-dep platform-api should install all you need | 22:42 |
| kdub_ | greyback, yeah, something must be messed up with my packages or something | 22:43 |
| kdub_ | trying to install that package gives Note, selecting 'libdbus-cpp-dev' instead of 'dbus-cpp-dev' | 22:43 |
| greyback | dpkg -S lies | 22:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!