| === chriadam|away is now known as chriadam | ||
| ahayzen | nik90, have i broken something? | 00:52 |
|---|---|---|
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| === bfiller is now known as bfiller_afk | ||
| Obrian1180 | Buenas noches... Saludos desde Venezuela | 04:53 |
| mardy | mzanetti: maybe the accounts page should be the one at the bottom of the stack? | 07:36 |
| dholbach | good morning | 07:57 |
| dpm | morning dholbach | 08:03 |
| dpm | mzanetti, more contributions! \o/ https://code.launchpad.net/~bobo-324/reminders-app/fix-1273111/+merge/204144 | 08:03 |
| dholbach | hey dpm | 08:08 |
| popey | dpm: mzanetti https://plus.google.com/u/0/+marshallk/posts/Dx48KbSZieE | 08:56 |
| dpm | popey, nice! I still like the Ubuntu feel better though, even if we don't have visual designs yet :) | 09:01 |
| popey | ☻ | 09:01 |
| WebbyIT | mzanetti, I'll pick this one, I have an idea: I'll fix both bug 1274743 and bug 1274742, cause both require to modify login page | 09:02 |
| ubot2` | Launchpad bug 1274743 in Ubuntu Reminders app "App has no logout option." [Undecided,New] https://launchpad.net/bugs/1274743 | 09:02 |
| ubot2` | Launchpad bug 1274742 in Ubuntu Reminders app "App has a back button on the select account screen, shouldn't" [Undecided,New] https://launchpad.net/bugs/1274742 | 09:02 |
| dpm | WebbyIT, mardy is doing some work on getting the authentication plugin merged into the reminders code. Perhaps it might be worth waiting for his branch to land before you start working on login-related bugs | 09:07 |
| popey | dpm: these are more for the app than the plugin | 09:08 |
| dpm | popey, that's right, but we're also going to change how we talk to the authentication from the app. I'm just mentioning to make sure WebbyIT doesn't start working on something that later needs to be reworked. Perhaps mardy can give us some advice | 09:10 |
| mardy | dpm: actually, the branch is ready (IMHO), it just needs someone other than me to test it | 09:10 |
| popey | ok | 09:11 |
| dpm | mardy, can you add some instructions on how to test the branch? IIRC it needs the package with the trusted helper code, which has not landed yet, to be installed first, right? | 09:12 |
| dpm | perhaps on the description of the MP? | 09:13 |
| mardy | dpm: no, no dependencies | 09:13 |
| mardy | dpm: just build it and run it :-) | 09:13 |
| mardy | dpm: I'll propose another branch for the trusted helper, probably later on today | 09:14 |
| dpm | mardy, ah, so that one just takes care of the merging of the two repos, right? I should have probably looked at it in more detail... | 09:14 |
| dpm | WebbyIT, so it's up to you what you want to work on. If you want to wait for these changes to land and you're looking for something else, this is a potentially bitesize bug: bug 1273110 | 09:16 |
| ubot2` | Launchpad bug 1273110 in Ubuntu Reminders app "Show activity indication when loading content" [High,Triaged] https://launchpad.net/bugs/1273110 | 09:16 |
| mardy | dpm: correct: merges the two repos and adds the username retrieval in the account plugin | 09:17 |
| dpm | ok, thanks | 09:17 |
| mzanetti | morning everyone | 09:17 |
| * mzanetti is still sleepy | 09:17 | |
| mzanetti | WebbyIT: cool, thanks. | 09:17 |
| dpm | hey mzanetti, morning o/ | 09:17 |
| mzanetti | mardy: valid point | 09:17 |
| mzanetti | dpm: will review soonish | 09:18 |
| === Ursinha-afk is now known as Ursinha | ||
| mardy | mzanetti: that's just an idea, probably using a dialog is better (and it would be nice if this page can be accessed from the toolbar) | 09:28 |
| JamesTait | Good morning all; happy Friday and happy Chinese New Year! :-D | 09:31 |
| nik90 | morning everyone | 09:44 |
| WebbyIT | How can I find list of all icons on Ubuntu 14.04? | 10:20 |
| WebbyIT | Icon for Ubuntu Touch... | 10:20 |
| nik90 | WebbyIT: there was this app which lists all icon theme and individual icon names | 10:31 |
| nik90 | WebbyIT: I cannot remember the app name :/ | 10:31 |
| WebbyIT | nik90, on phone? | 10:32 |
| nik90 | WebbyIT: no its a desktop app | 10:33 |
| nik90 | WebbyIT: the app does nothing else except show icons in an icon theme. A very simple app | 10:33 |
| * nik90 hates it when you cannot remember stuff just when u need it | 10:33 | |
| WebbyIT | nik90, mhh, I didn't find anythig on bigG | 10:34 |
| nik90 | bigG? | 10:34 |
| WebbyIT | nik90, Google :P | 10:36 |
| nik90 | :) | 10:36 |
| nik90 | WebbyIT: found it! | 10:38 |
| nik90 | WebbyIT: http://iloveubuntu.net/icon-library-10-released-support-ubuntu-1304-and-ubuntu-1310 | 10:38 |
| WebbyIT | nik90, awesome! Thansk very much :) | 10:39 |
| WebbyIT | popey, could you top-approve this please? | 10:48 |
| WebbyIT | https://code.launchpad.net/~rpadovani/reminders-app/fix-1267800/+merge/204115 | 10:48 |
| === _salem is now known as salem_ | ||
| WebbyIT | mzanetti, if it's ok, could you top approve this, please? | 11:22 |
| WebbyIT | https://code.launchpad.net/~rpadovani/reminders-app/fix-1267800/+merge/204115 | 11:22 |
| WebbyIT | I need it for the new branch | 11:22 |
| dpm | nik90, WebbyIT, enjoy ;) https://plus.google.com/u/0/+DavidPlanella/posts/144iojDbjv5 | 11:24 |
| WebbyIT | dpm thanks :-) I think it's the same that nik90 linked | 11:25 |
| mzanetti | WebbyIT: added some comments, needs fixing, sorry ;) | 11:25 |
| dpm | ah, yeah, I missed the "Found it!" message | 11:25 |
| nik90 | Hehe | 11:26 |
| dpm | also, I've just filed bug 1274895 | 11:29 |
| ubot2` | Launchpad bug 1274895 in Ubuntu UI Toolkit "Add mobile icons to the Gallery Showcase" [Undecided,New] https://launchpad.net/bugs/1274895 | 11:29 |
| WebbyIT | mzanetti, mhh, I put it in the delegate because it's the only way to access to accountService easily | 11:31 |
| mzanetti | WebbyIT: hmm... looking at it I'm actually not sure why the AccountService element is inside the delegate | 11:33 |
| * mzanetti gets the impression that the AccountService API is a bit weird... | 11:34 | |
| mzanetti | mardy: hey, can you explain me something? | 11:35 |
| mzanetti | how does the AccountService element know which account it actually is? | 11:35 |
| WebbyIT | mzanetti, if I put AccountService out of delegate I have an error with accountServiceHandle. I suppose there is a strange link between the delegate and the account | 11:37 |
| mzanetti | yeah... trying to figure what's happening | 11:38 |
| mzanetti | the weird thing is that if AccountService is inside a delegate it has a method "authenticate()" if its outside the delegate, it doesn't | 11:39 |
| WebbyIT | also in API documentation AccountService is inside the delegate: | 11:42 |
| WebbyIT | http://developer.ubuntu.com/api/qml/sdk-1.0/Ubuntu.OnlineAccounts.AccountServiceModel/ | 11:42 |
| WebbyIT | (see third and fourth example) | 11:42 |
| timp | which package do I need to install to get cmake for gallery-app detect gstreamer-0.1? | 11:46 |
| mzanetti | timp: tried with apt-get build-dep gallery-app? | 11:46 |
| mzanetti | if that doesn't work its a bug in the packaging I'd say | 11:47 |
| timp | mzanetti: thank you! that works. | 11:48 |
| mzanetti | WebbyIT: in any case, as your branch is now I won't approve it cause this might break in certain circumstances | 11:52 |
| mzanetti | will talk to mardy how to fix it | 11:53 |
| WebbyIT | mzanetti, in which circumstances? If I put the Component.onCompleted out of delegate is sufficent to fix it? | 11:54 |
| mzanetti | WebbyIT: for example if the first item's onCompleted is executed before the model delivers the second item. not entirely sure how to deal with it yet | 11:55 |
| WebbyIT | mzanetti, so, I'll push another branch for fix other two bugs related to login and I'll update this one when we'll find a solution | 12:00 |
| mzanetti | WebbyIT: ok, cool | 12:01 |
| mzanetti | WebbyIT: what I'd like to have is something like this: the app starts up, the first thing it does is to check how many accounts there are, if there is only one, select that, if not, open the list and let the user pick | 12:03 |
| mzanetti | mardy: ^ I can't figure how to do this | 12:03 |
| mzanetti | 'cause AccountsService need to be visible before they work (as a result of only working inside listview delegates for some reason) which imo is quite broken | 12:03 |
| WebbyIT | mzanetti, for switch account icon is ok to use contacts-app-symbolic? It's the only icon in ubuntu-mobile theme with account | 12:04 |
| mzanetti | WebbyIT: sure... just put some icon you think fits. as long as we don't have any visual design that's not really an issue | 12:04 |
| mardy | mzanetti: sorry, was on lunch break | 12:07 |
| * mardy reads the backlog | 12:08 | |
| === MacSlow is now known as MacSlow|lunch | ||
| mardy | mzanetti: so to check how many accounts you have, you don't need the AccountService, just the AccountserviceModel | 12:10 |
| mardy | mzanetti: it has a "count" property | 12:10 |
| mzanetti | mardy: yeah, ok. that works, but how would I call authenticate() on one of them? | 12:10 |
| mardy | mzanetti: OK, then you need to instantiate an AccountService for the account you want to authenticate | 12:11 |
| mzanetti | mardy: yep, that's where I'm struggling right now | 12:11 |
| mardy | mzanetti: you set the accountServiceHandle to the one of the account you need | 12:11 |
| mzanetti | mardy: for some reason I can't set objectHandle | 12:11 |
| mardy | mzanetti: I don't understand, the current trunk seems to be fine; what are you changing? | 12:11 |
| WebbyIT | https://bazaar.launchpad.net/~rpadovani/reminders-app/fix-1267800/view/head:/src/app/qml/ui/AccountSelectorPage.qml | 12:12 |
| mzanetti | mardy: I don't want to build up the page with the listView if there is only one account anyways | 12:12 |
| mzanetti | mardy: we don't want the user to have to manually select the account | 12:12 |
| mardy | mzanetti: IIRC the AccountServiceModel has a get() method, let me check... | 12:13 |
| mardy | mzanetti: yes, it's there. So, something like accounts.get(0, "accountServiceHandle") will give you the handle you have to put in the AccountService | 12:15 |
| * mzanetti tries | 12:15 | |
| dpm | does anyone know whether I can put an SVG app icon in the sources rather than a fixed-size PNG? "Can" being defined as "will it be used in the Launcher and the Apps scope"? | 12:21 |
| mzanetti | dpm: yes | 12:21 |
| mzanetti | dpm: all my apps use exclusively svg icons | 12:22 |
| dpm | mzanetti, ok, so we can fix bug 1273704 quite easily, let me get an SVG | 12:22 |
| ubot2` | Launchpad bug 1273704 in Ubuntu Reminders app "Icon isn't the right size" [Undecided,New] https://launchpad.net/bugs/1273704 | 12:22 |
| mzanetti | dpm: well, this bug is not really related to png vs svg I think | 12:22 |
| mzanetti | dpm: its more that the png has a transparent border | 12:23 |
| mzanetti | but still, +1 on replacing it with an svg | 12:23 |
| dpm | mzanetti, the bug is there because the icon is square, and it should be rectangular (ratio width/height should be 8/7.5, I'm told). But yeah, in any case the SVG has those proportions and will fix it | 12:24 |
| FuLgOrE | hi guys. My UT is fully up to date. Is there any way to make ENTER and BACKSPACE working in the terminal app? | 12:30 |
| mzanetti | mardy: Object Accounts::AccountService(0x291ea40) has no method 'authenticate' | 12:30 |
| mardy | mzanetti: impossible :-) | 12:32 |
| mardy | mzanetti: I'll push a branch in a second | 12:32 |
| mzanetti | mardy: ok :) | 12:32 |
| mzanetti | WebbyIT: you've got a talent to reveal the tricky parts of the app :D | 12:33 |
| mzanetti | mardy: do you mean a branch for accountservice of a branch for the reminders-app that does this? | 12:34 |
| mardy | https://code.launchpad.net/~mardy/reminders-app/single-account/+merge/204219 | 12:34 |
| mardy | mzanetti: I tested it quickly, it might use some improvement | 12:34 |
| mzanetti | mardy: this is what I was missing: singleAccountComponent.createObject(this, { "objectHandle": accounts.get(0, "accountServiceHandle") }) | 12:36 |
| === chriadam is now known as chriadam|away | ||
| mardy | mzanetti: looking at my code, I think we can do better, wait a second... | 12:36 |
| mzanetti | mardy: as accounts.get() return a AccountSerivce already | 12:36 |
| mzanetti | I thought that's it... but it seems to be a dummy QObject instead | 12:37 |
| * mzanetti votes for AccountsModel::account(index) which returns the real thing, not having to do the createObject in qml | 12:38 | |
| mzanetti | imo those handles shouldn't be exported to qml at all... | 12:38 |
| mardy | mzanetti: true, it was not easy to design that QML API | 12:40 |
| mardy | mzanetti: I chose to make it as declarative as possible | 12:40 |
| mardy | mzanetti: the other option would have been to return "the real thing" as you say, but then one would have to play with "Connections" elements or the "connect()" method on the signals | 12:41 |
| mardy | mzanetti: I updated my last merge request, the code is much simpler now | 12:42 |
| mzanetti | mardy: ok, cool. I won't merge your's as is as I'd like to have some of this in reminders.qml and don't even load the AccountSelectorPage if not required. but your branch helps me a lot to get that done. thanks! | 12:43 |
| mardy | mzanetti: yw | 12:43 |
| mardy | mzanetti: yes, that makes sense | 12:44 |
| dpm | A very trivial review if someone can have a look at it! https://code.launchpad.net/~dpm/reminders-app/bug-1273704/+merge/204218 | 13:00 |
| mzanetti | WebbyIT: mardy: https://code.launchpad.net/~mzanetti/reminders-app/init-account-rework/+merge/204228 | 13:07 |
| mzanetti | WebbyIT: this just handles the communication with the AccountService, still a lot to do for you on top of that... | 13:08 |
| mzanetti | for example even if there are multiple accounts, we should store the selected one and reuse that. | 13:08 |
| mzanetti | in case there are 0 accounts we need to launch the settings | 13:09 |
| mzanetti | and there is no error handling yet | 13:09 |
| nik90 | dpm: can you top approve that MP. I reviewed and approved it | 13:11 |
| WebbyIT | mzanetti, I start to working on it :) | 13:15 |
| WebbyIT | thanks mardy ! | 13:15 |
| mzanetti | +1 ^ | 13:15 |
| mardy | WebbyIT: di niente :-) | 13:17 |
| WebbyIT | mardy, ci sono italiani dappertutto :D | 13:18 |
| mzanetti | :D | 13:18 |
| dpm | thanks nik90, mzanetti for the review | 13:25 |
| ahayzen | timp, ping | 13:31 |
| tefla | Hi! I'm looking for what I know on Debian as /dev/eth0 (or similar, em0) as the interface file, but can't find it on Ubuntu 13.10. Where am I going wrong? I am using the NetworkManager. Does this have anything to do with it? | 13:41 |
| popey | tefla: this isn't a support channel for ubuntu, however it sounds like you're looking for /etc/network/interfaces? | 13:44 |
| popey | tefla: when you use network manager, the interfaces file isn't used. indeed if you put interfaces in that file it will prevent network manager from managing that device. so by default we don't ship by configuring interfaces in that file | 13:44 |
| tefla | Thanks for the clarification. However I am trying to create an app that uses the network dev file directly | 13:47 |
| popey | tefla: an ubuntu touch app? | 13:48 |
| tefla | so that i can create a socket using it. | 13:48 |
| tefla | no :) | 13:48 |
| tefla | #ubuntu? | 13:48 |
| popey | well, the network device will be the same as debian, in /dev/eth0 or /dev/wlan0 depending on your device | 13:48 |
| popey | cat /proc/net/dev | 13:49 |
| popey | and you'll see the devices | 13:49 |
| tefla | ok, so having my default connection using NetworkManager is getting me! | 13:49 |
| tefla | Ah! got you | 13:49 |
| tefla | thanks for the help, and sorry for spamming the wrong room | 13:50 |
| popey | np | 13:51 |
| === matiasb1 is now known as matiasb | ||
| === MacSlow|lunch is now known as MacSlow | ||
| timp | ahayzen: hello | 14:07 |
| ahayzen | timp, regarding the MP https://code.launchpad.net/~andrew-hayzen/ubuntu-ui-toolkit/fix-swipe-delete-002/+merge/202171 | 14:08 |
| ahayzen | timp, the failure is that when a swipe delete has been confirmed the height isn't set to 0? | 14:08 |
| timp | let me have a look. I only had a quick look to see which tests failed | 14:08 |
| ahayzen | timp, https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2447/testReport/junit/ubuntuuitoolkit.tests.test_emulators/SwipeToDeleteTestCase/test_delete_item_moving_left/ | 14:08 |
| timp | it fails on AssertionError: After 10.0 seconds test on Standard.implicitHeight failed: 0 != dbus.Double(50.0, variant_level=1) | 14:09 |
| WebbyIT | mzanetti, couple of questions: what's the best way to save favourite account? GSetting, Sqlite with QML or U1DB? | 14:09 |
| ahayzen | timp, hmm i wonder wht bit broke tht lol | 14:09 |
| mzanetti | WebbyIT: I personally would go for QSettings | 14:09 |
| WebbyIT | mzanetti, ok, thanks. Second: how can I call friends to add an account? | 14:10 |
| mzanetti | WebbyIT: don't know, maybe mardy does ^ | 14:10 |
| ahayzen | timp, and why did ur tests pass? | 14:10 |
| timp | that's.... ehm. weird. | 14:11 |
| timp | ahayzen: I just checked again, they still pass on my laptop. | 14:13 |
| timp | ahayzen: I'll try on my galaxy nexus now | 14:13 |
| timp | ahayzen: strange. it works fine on my galaxy nexus as well | 14:18 |
| ahayzen | timp, weird | 14:18 |
| timp | elopio: ^ do you have an idea why AP fails on jenkins but not locally for me in this MR? https://code.launchpad.net/~andrew-hayzen/ubuntu-ui-toolkit/fix-swipe-delete-002/+merge/202171 | 14:18 |
| * timp lunchtime, bbl | 14:18 | |
| elopio | timp: no idea. | 14:27 |
| elopio | that's failing on the desktop, let me give it a try. | 14:27 |
| mardy | WebbyIT: not sure what you mean... to add accounts you don't call friends | 14:28 |
| mardy | WebbyIT: if you want to create accounts from Reminders, I've a branch for it: https://code.launchpad.net/~mardy/reminders-app/app-access/+merge/204191 | 14:29 |
| === bfiller_afk is now known as bfiller | ||
| mardy | WebbyIT: BTW, testing is *very* welcome :-) | 14:29 |
| WebbyIT | mardy, I don't want to add an account from app: if user press on "Add other account" I think the best way is to open Friend to add another account | 14:29 |
| mardy | WebbyIT: not sure why Friends would be involved | 14:31 |
| mardy | WebbyIT: Friends cannot create accounts, AFAIK | 14:31 |
| WebbyIT | mardy, what's the name of account manager? | 14:32 |
| WebbyIT | where you can add online account... | 14:32 |
| mardy | WebbyIT: "Online Accounts" :-) But that is what the branch I linked above does | 14:33 |
| WebbyIT | mardy, uops :-) Ok, I'll try it, thanks :) | 14:33 |
| elopio | ahayzen: I got to reproduce the error. I think we are not hitting the delete button properly, and then the item is still there. | 14:34 |
| elopio | I'm in a meeting, but will be back with you shortly. | 14:35 |
| mardy | mzanetti: had any time to look at https://code.launchpad.net/~mardy/reminders-app/account-plugin/+merge/203952 ? | 14:37 |
| mzanetti | mardy: no, not yet, sorry | 14:37 |
| mzanetti | the right edge animation to switch apps is driving me mad :D | 14:37 |
| mzanetti | mardy: I'll try to get to it today | 14:37 |
| mardy | mzanetti: thanks | 14:38 |
| WebbyIT | mardy, could your branch work on desktop? There are some dipendences to install? | 14:39 |
| mardy | WebbyIT: yes, it works on the desktop, there's one dependency which is mentioned in the description of the merge request | 14:43 |
| WebbyIT | right, thanks | 14:44 |
| ahayzen | elopio, ok so is tht my issue or the test? | 14:46 |
| elopio | ahayzen: it's the emulator, it seems. We need to wait for the row to stop moving. | 14:48 |
| elopio | let me try something. | 14:48 |
| ahayzen | elopio, could it be because i have now fixed some of the animations tht weren't working before? | 14:49 |
| elopio | timp: you don't get the error probably because your machine is slow :) | 14:49 |
| elopio | ahayzen: likely. We need to wait for the animation to finish before we click. Otherwise, we will get the center of the button while it's moving. | 14:49 |
| ahayzen | elopio, ok | 14:49 |
| * ahayzen lunch bbl | 14:51 | |
| ahayzen | elopio, whts the best way of waiting for the animation to complete? | 15:13 |
| elopio | ahayzen: I'm trying to find a way, but my autopilot vis is stuck. | 15:16 |
| elopio | ahayzen: have you done autopilot tests before? | 15:16 |
| ahayzen | elopio, heh i've done some for the music-app but my knowledge isnt tht gd | 15:17 |
| ahayzen | elopio, i guess in the confirm_removal() in the emulators.py we need to wait until the animation is complete? | 15:18 |
| elopio | sorry, things are crashing everywhere. | 15:25 |
| ahayzen | haha no worries | 15:25 |
| === gatox is now known as gatox_lunch | ||
| elopio | ahayzen: I don't know enought QML to understand what's going on. It seems to me that waitingConfirmationForRemoval = True is happening after all the animations are finished. | 16:19 |
| ahayzen | elopio, so maybe waiting for tht to be true would work? | 16:20 |
| elopio | ahayzen: we are waiting for it to be true: | 16:21 |
| elopio | self.waitingConfirmationForRemoval.wait_for(True) | 16:21 |
| ahayzen | elopio, hmm yh i just saw tht | 16:21 |
| elopio | it seems that after it's True, we still have another animation that I don't know where it comes from. | 16:21 |
| ahayzen | elopio, ok i may have changed something then | 16:21 |
| ahayzen | elopio, i'll investigate tonight see if i can figure it out, thanks for ur help, i've gtg now :/ | 16:22 |
| elopio | ahayzen: thanks to you. If I find something, I'll comment the MP. | 16:22 |
| ahayzen | elopio, thanks | 16:22 |
| elopio | I get it. | 16:26 |
| === greyback_ is now known as greyback|food | ||
| === greyback|food is now known as greyback | ||
| mzanetti | mardy: I'm wondering why jenkins doesn't pick this up https://code.launchpad.net/~mardy/reminders-app/account-plugin/+merge/203952 | 17:15 |
| === gatox_lunch is now known as gatox | ||
| dpm | mzanetti, because he's not a member of the team. We need to ping fginther to manually trigger the job ^ | 17:42 |
| mzanetti | dpm: ah, I see... | 17:42 |
| mzanetti | dpm: I autolanding seems to be working tho | 17:42 |
| dpm | mzanetti, top-approving triggers the job too afaik, so perhaps that was it? | 17:43 |
| fginther | dpm, mzanetti top approving by a team member will trigger autolanding automatically | 17:43 |
| mzanetti | ack, thanks | 17:44 |
| mzanetti | dpm: https://code.launchpad.net/~mardy/reminders-app/app-access/+merge/204191/comments/477181 | 17:44 |
| * dpm looks | 17:44 | |
| * dpm looks if Dani is still around... | 17:47 | |
| dpm | ah, you pinged him already :) | 17:47 |
| WebbyIT | mzanetti, sorry, too many branch today. I'll work on this for improve login after mardy merge? | 17:51 |
| WebbyIT | https://code.launchpad.net/~mzanetti/reminders-app/init-account-rework | 17:52 |
| mzanetti | WebbyIT: I'd say you test this and review it, if it works, approve it. | 17:53 |
| mzanetti | WebbyIT: then mardy's branch deals with the case if there is no account at all | 17:53 |
| mzanetti | WebbyIT: an you can handle the case if there are multiple accounts (with the switch account button etc) | 17:54 |
| mzanetti | WebbyIT: does this work you? | 17:54 |
| WebbyIT | mzanetti, yap :) | 17:54 |
| * popey hugs WebbyIT | 17:54 | |
| mzanetti | WebbyIT: cool, I won't be online tonight. if you finish this and want to do more, check out the "shoot" branch and get it merged. then rework the camera workflow to reflect the design mockups | 17:55 |
| mzanetti | WebbyIT: there needs to be a confirmation page that asks "Do you want to use this picture" etc | 17:55 |
| WebbyIT | mzanetti, wow, ok :) | 17:55 |
| mzanetti | WebbyIT: do you have the link to the design mockups? | 17:56 |
| popey | they are in the blueprint | 17:56 |
| popey | https://blueprints.launchpad.net/ubuntu-phone-commons/+spec/reminders-app-development | 17:56 |
| mzanetti | popey: yeah, but for some reason the blueprint is not linked to the lp:reminders-app repo | 17:56 |
| popey | yeah | 17:57 |
| popey | added blueprint link to https://launchpad.net/reminders-app ☻ | 17:57 |
| WebbyIT | mzanetti, if it's the gdocs yes | 17:57 |
| mzanetti | WebbyIT: yeah, that one... there are 3 pictures for the camera workflow. that's missing in the app so far | 17:58 |
| mzanetti | well, one of the 3 is missing completely, and one looks bad and needs to become prettier | 17:59 |
| WebbyIT | ok, I'll see what I can do | 18:00 |
| mzanetti | popey: what I mean is, if you go to here https://launchpad.net/reminders-app and click on the Blueprints link on top, you won't end up in the blueprint | 18:00 |
| popey | yeah, i know | 18:00 |
| mzanetti | WebbyIT: no worries if you don't manage or don't have time... | 18:00 |
| mzanetti | WebbyIT: just in case you want to do something while I'm away | 18:00 |
| WebbyIT | :-) | 18:01 |
| WebbyIT | mzanetti, https://code.launchpad.net/~mzanetti/reminders-app/init-account-rework/+merge/204228/comments/477207 | 18:10 |
| om26er | boiko, how do i get new messaging-app released ? | 18:19 |
| boiko | om26er: you need to fill the MR submission checkist on the MR | 18:21 |
| boiko | om26er: https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps | 18:21 |
| boiko | om26er: then the reviewer fills the review checkist, and then we request to bfiller a new release | 18:21 |
| om26er | boiko, hmm, thats a bigger task | 18:23 |
| boiko | om26er: that's the new procedure for all packages it seems | 18:23 |
| om26er | boiko, will fill the request once jenkins behaves and my branch lands | 18:24 |
| boiko | om26er: well, that needs to be filled before it gets approved/merged | 18:24 |
| om26er | boiko, even for https://code.launchpad.net/~om26er/messaging-app/fix_introspection/+merge/203392 ? | 18:25 |
| WebbyIT | Someone could review this please? | 18:25 |
| WebbyIT | https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/1274229/+merge/204311 | 18:25 |
| boiko | om26er: yep | 18:25 |
| om26er | - if (arguments.contains("-testability")) { | 18:25 |
| om26er | + if (arguments.contains("-testability") || qgetenv("QT_LOAD_TESTABILITY") == "1") { | 18:25 |
| om26er | :p | 18:25 |
| boiko | om26er: yep, I have done that for an MR that was changing even less code than yours did :P | 18:26 |
| om26er | boiko, should I revert the status from 'approved' to needs review then ? | 18:26 |
| boiko | om26er: doesn't really matter, cause bfiller will only pick the MR if it has both the submitter and the reviewer checklists filled | 18:26 |
| boiko | om26er: no more autolanding on branches | 18:27 |
| om26er | fun! | 18:29 |
| bfiller | om26er: for any MR, you need to perform the steps in the reviewer section checklist here: https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps | 18:30 |
| bfiller | om26er: part of that is making sure you manually run these tests: https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app | 18:30 |
| om26er | bfiller, ok, will do. | 18:31 |
| bfiller | om26er: once you've done that then we can get it released | 18:33 |
| bfiller | om26er: just a heads up as well, the design of the dialer app is going to be changing alot, so I wouldn't write too many new autopilot tests until we know exactly what is going t change | 18:34 |
| bfiller | om26er: hopefully you knew about that :) | 18:35 |
| om26er | bfiller, heh, I have already written a few ;) seems they will need to be altered later | 18:35 |
| om26er | the good part is most of the work in those tests is logical so that will stay the same | 18:36 |
| bfiller | that's good | 18:37 |
| nik90 | WebbyIT: I reviewed and approved your MP. Care to top approve it pls. | 18:46 |
| WebbyIT | nik90, thanks :) | 18:46 |
| nik90 | WebbyIT: btw, your qbzr recommendation is so freaking awesome...helps out nicely instead of using the terminal | 18:49 |
| WebbyIT | nik90, yeah, Trevino suggested it to me a week ago, it's very cool :) | 18:52 |
| dpm | I use it all the time too! | 18:52 |
| dpm | qdiff and qlog all the time :) | 18:53 |
| WebbyIT | wow, I didn't know qlog, very interesting :) | 18:53 |
| nik90 | qlog? | 18:54 |
| nik90 | I basically used bzr q(commit, log, diff) | 18:55 |
| nik90 | they all work | 18:55 |
| nik90 | try out bzr qcommit | 18:55 |
| WebbyIT | qdiff is the best, but also qcommit is useful | 18:55 |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| balloons | ahayzen_, you about? | 20:13 |
| ahayzen_ | balloons, sortof...on a dodgy WiFi and gonna go out in a bit | 20:13 |
| ahayzen_ | balloons, whts up? | 20:13 |
| balloons | ahayzen_, nvm actually I figured it out.. but, fyi, migrating music to cmake | 20:14 |
| balloons | you'll see a mp soon | 20:14 |
| ahayzen_ | balloons, ooo cool :) | 20:14 |
| ahayzen_ | balloons, so we can cross compile? | 20:14 |
| balloons | the world is our oyster, lol.. my motivation is to allow for usage of the click-buddy tool | 20:14 |
| ahayzen_ | balloons, awesome :) | 20:15 |
| wardane | How do you simulate a pinch to zoom in Qt creator? | 20:41 |
| WebbyIT | dpm, if you have time, could you please review this again? https://code.launchpad.net/~mzanetti/reminders-app/shoot/+merge/203418 | 21:16 |
| WebbyIT | Mhh, dpm isn't online :/ | 21:16 |
| === bfiller is now known as bfiller_afk | ||
| WebbyIT | popey, this is for you :-) https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/1273637/+merge/204354 | 21:55 |
| popey | :D | 21:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!