| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| Mirv | Saviq: I'm not using quilt, but maybe it works only when sources are in the same repo as packaging? | 04:56 |
|---|---|---|
| === duflu_ is now known as duflu | ||
| Saviq | Mirv, of course <facepalm> | 08:00 |
| Saviq | Mirv, both branches linked to https://bugs.launchpad.net/unity-lens-applications/+bug/1271158 - if you need me to do anything else with them, pray tell :) | 08:45 |
| ubot5 | Ubuntu bug 1271158 in qtbase-opensource-src (Ubuntu) "Application Lens Icons are blurry, compared with home screen" [Undecided,In progress] | 08:45 |
| Mirv | Saviq: thanks | 09:00 |
| Mirv | I'll look at those | 09:00 |
| Saviq | Mirv, you're in London, right? | 09:01 |
| Saviq | Mirv, were you *still* or *already* up at 5am? ;) | 09:10 |
| Saviq | dednick, hey, could I ask you to do https://code.launchpad.net/~saviq/unity8/add-doxygen/+merge/204123 | 09:15 |
| dednick | Saviq: sure | 09:16 |
| Saviq | dednick, probably no need to read through the whole Doxyfile.in | 09:16 |
| Saviq | dednick, but you might want to grep for @ and see if the substitutions make sense | 09:16 |
| Saviq | dednick, hmm actually now that I think of it... | 09:17 |
| Saviq | dednick, we probably shouldn't build the docs all the time | 09:17 |
| Saviq | since it takes a few seconds | 09:18 |
| dednick | Saviq: yeah, i just saw that | 09:18 |
| Saviq | let me tweak it a bit | 09:18 |
| dednick | graphvis can probably take a bit of time | 09:18 |
| dednick | or dot rather... | 09:19 |
| Saviq | dednick, doxygen itself is enough | 09:20 |
| Saviq | dednick, especially since it needs to pipe the qml through doxyqml, which is python | 09:20 |
| dednick | Saviq: but it needs to be built for packaging though... | 09:21 |
| Saviq | dednick, yup, tweaking debian/rules to do that | 09:21 |
| dednick | ok | 09:21 |
| Saviq | let's see if I did good | 09:21 |
| Saviq | dednick, pushed | 09:27 |
| dednick | Saviq: ta | 09:27 |
| Saviq | dednick, I just saw an issue - "/build/unity8-KAx5z5/unity8-7.84+14.04.20140129" got included in the paths, /me fixes | 09:28 |
| mhr3 | sil2100, automerger still ignoring that one branch... what's up with that? (https://code.launchpad.net/~marcustomlinson/unity-scopes-api/smartscopes_proxy/+merge/203943) | 09:32 |
| Saviq | dednick, fixed | 09:32 |
| Mirv | Saviq: haha. no, I'm in London only next week, not this week | 09:32 |
| Saviq | Mirv, oh ok :) | 09:32 |
| Mirv | Saviq: I expect to wake up at weird hours anyhow also next week, even if I wouldn't want to ;) | 09:32 |
| Saviq | Mirv, 3h difference? | 09:33 |
| Mirv | Saviq: I think only 2h. the thing is I also wake up locally at 6am normally because of the daily schedule | 09:33 |
| Saviq | Mirv, right ;) | 09:33 |
| Mirv | so it furthers the observed delta | 09:33 |
| Saviq | Mirv, just go for drinks on Sunday, it'll help you accommodate :D | 09:34 |
| Mirv | but in London the work begins at 9am (ie. 11am here) so it's 4h difference in practice | 09:34 |
| ricmm | morning | 09:37 |
| Saviq | hey ricmm | 09:37 |
| ricmm | Saviq: so yea reading back I think daniel got the point | 09:37 |
| Saviq | dednick, https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 another small one | 09:38 |
| ricmm | some logic needs to happen in unity8 to setup the new ipc | 09:38 |
| ricmm | and then plug that in p-api | 09:38 |
| Saviq | seb128, could you do a quick checkup on packaging changes for: | 09:38 |
| Saviq | https://code.launchpad.net/~saviq/unity8/add-doxygen/+merge/204123 | 09:38 |
| Saviq | https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 | 09:38 |
| dednick | Saviq: ok | 09:39 |
| Saviq | ricmm, what changed between then and now? why can't we use android's copypaste service? | 09:39 |
| ricmm | android has no copy paste service | 09:39 |
| ricmm | ClipboardService is an implementation in the android ubuntuappmanager | 09:40 |
| Saviq | ricmm, ah! | 09:40 |
| ricmm | as in, code we wrote | 09:40 |
| Saviq | ricmm, that was the detail I was missing | 09:40 |
| ricmm | that uses binder for ipc and manages all through the app manager | 09:40 |
| ricmm | it would be the same thing to be fair | 09:40 |
| ricmm | just that living in unity-mir somewhere | 09:41 |
| Saviq | Cimi, forgot to put prerequisite on textSummary | 09:41 |
| Cimi | Saviq, yeah!! | 09:41 |
| Cimi | Saviq, done | 09:42 |
| Saviq | Cimi, also, while you're at it... you could implement the See more | See less buttons there, and a "title" for it | 09:43 |
| Saviq | Cimi, https://docs.google.com/a/canonical.com/file/d/0B-a_7E3tDxOgY2daVlFzaVB3ZFk/edit | 09:43 |
| Cimi | Saviq, cool | 09:43 |
| Cimi | Saviq, was bored of simply adding a label :) | 09:43 |
| Saviq | Cimi, make the see more / see less a component | 09:43 |
| Saviq | Cimi, we'll be using it in the dash as well | 09:43 |
| Cimi | Saviq, ok | 09:44 |
| Saviq | Cimi, I'm adding "title" to the text widget JSON | 09:44 |
| Saviq | Cimi, I'd say optional | 09:44 |
| Saviq | Cimi, so hide if empty | 09:44 |
| Cimi | Saviq, so textSummary needs what? | 09:44 |
| Cimi | column of two labels | 09:44 |
| Cimi | plus see more/less | 09:45 |
| Cimi | ? | 09:45 |
| Saviq | Cimi, yes, and it needs to accept a modelData object for its data, not text directly | 09:45 |
| Cimi | Saviq, but no array | 09:46 |
| Saviq | Cimi, no, a single value, yes | 09:46 |
| Cimi | Saviq, var modelData then? | 09:46 |
| Saviq | Cimi, yeah, or so | 09:46 |
| Saviq | Cimi, make it an interface, btw | 09:46 |
| Saviq | Cimi, so PreviewWidget { property var data } | 09:46 |
| Saviq | Cimi, or so | 09:47 |
| Saviq | Cimi, and base all of the preview widgets off of that | 09:47 |
| Cimi | adding an interface to all widgets you mean | 09:47 |
| Cimi | ok | 09:47 |
| Saviq | Cimi, yup, the only common prop between widgets will be data, I'd say | 09:47 |
| Saviq | Cimi, also, use Text.Wrap | 09:47 |
| mhr3 | Saviq, any chance to try to hookup the new previews today? | 09:47 |
| mhr3 | although we landed columns api, should change the models to support it | 09:48 |
| Saviq | mhr3, I'd rather have at least one widget first ;) | 09:48 |
| mhr3 | yea, that would help i guess :) | 09:48 |
| Saviq | Cimi, otherwise long words will overflow / get clipped | 09:48 |
| Saviq | mhr3, so Monday? I reworked a few things with the Card (+CardTool), so carousel will work now | 09:49 |
| Saviq | meaning when I complete the tests and merge it ;) | 09:50 |
| Saviq | and will make sure today grid is centered | 09:50 |
| mhr3 | Saviq, k, re columns, i'll make scope.preview() return a master preview model that will have columns role which will have per-column widget models | 09:50 |
| mhr3 | widget model* | 09:51 |
| Saviq | mhr3, yup, sounds good | 09:51 |
| Saviq | mhr3, so we'll wrap it in a stack of previews later? | 09:51 |
| mhr3 | Saviq, activations and stuff will go to the master object though | 09:51 |
| Saviq | mhr3, fine | 09:51 |
| mhr3 | Saviq, still not sure where to put the stack | 09:51 |
| Saviq | mhr3, mhm | 09:52 |
| mhr3 | Saviq, i guess the master will emit a signal when it gets a nested child | 09:52 |
| mhr3 | s/nested/stacked/ | 09:52 |
| Saviq | mhr3, mhm | 09:52 |
| mhr3 | so don't think we really need to expose the entire stack to the shell | 09:53 |
| mhr3 | always just the active one | 09:53 |
| mhr3 | but maybe you don't think so? :) | 09:54 |
| Saviq | mhr3, well, I don't want to destroy the inactive one | 09:55 |
| Saviq | mhr3, since there can be data the user entered | 09:55 |
| mhr3 | true | 09:55 |
| Saviq | mhr3, and they expect it there when, went "back" from the stacked one | 09:55 |
| mhr3 | i just find the model hierarchy pretty complex already, but well | 09:57 |
| Saviq | mhr3, well, it's modeling a complex thing, so... | 09:57 |
| mhr3 | Saviq, ok, so scope.preview() returns PreviewStack, that contains PreviewModel, which has columns and those have PreviewWidgetModel which finally has the individual widgets | 10:00 |
| sil2100 | mhr3: give me a moment and I'll check | 10:00 |
| dednick | Saviq: is unity8.shell.tests.test_system_integration.SystemIntegrationTests.test_networkmanager_integration a known failure at the mo? | 10:05 |
| dednick | Saviq: http://pastebin.ubuntu.com/6848599/ | 10:08 |
| Saviq | dednick, https://code.launchpad.net/~mterry/unity8/disable-nm-test/+merge/203980 | 10:08 |
| dednick | Saviq: that was just using dpkg-buildpackage | 10:09 |
| Saviq | dednick, uh, what that... | 10:09 |
| dednick | :/ it was second time was building. maybe not cleaned? | 10:10 |
| karni | Saviq: if there's been any chages to card-tool brach, push 'em up please, reading now :) | 10:10 |
| Saviq | karni, no, not yet | 10:11 |
| Saviq | dednick, semop is "systemv semaphore operations"... | 10:11 |
| dednick | Saviq: hm. i had to ctrl-C out. build got stuck. | 10:11 |
| Saviq | dednick, try a clean one, or better yet - https://wiki.ubuntu.com/SimpleSbuild | 10:11 |
| Saviq | dednick, it builds everywhere else, so... | 10:12 |
| karni | ack | 10:13 |
| dednick | yay. an updated [possibly] not impossible to understand sbuild wiki! | 10:13 |
| Saviq | dednick, oh, didn't you see it before? | 10:14 |
| mhr3 | Saviq, btw ok to push http://paste.ubuntu.com/6848630/ ? it doesn't exactly work, but makes it easier to fix :) | 10:14 |
| dednick | Saviq: only this on. https://wiki.ubuntu.com/SecurityTeam/BuildEnvironment | 10:14 |
| Saviq | mhr3, fine | 10:14 |
| Saviq | dednick, yeah, I extracted the info useful for the normal person in the SimpleSbuild one | 10:15 |
| karni | :D | 10:16 |
| Saviq | dednick, https://wiki.ubuntu.com/CrossBuilding some info about cross-building here, too | 10:17 |
| Saviq | dednick, unity8 is cross-buildable through that | 10:18 |
| Saviq | didrocks, maybe you could you do a quick checkup on packaging changes for: | 10:18 |
| Saviq | https://code.launchpad.net/~saviq/unity8/add-doxygen/+merge/204123 | 10:18 |
| Saviq | https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 | 10:18 |
| dednick | Saviq: ta | 10:18 |
| seb128 | Saviq, just gave a +1 to the first one | 10:19 |
| seb128 | Saviq, I'm unsure about the second one, maybe ping Mirv? (did that package got renamed in 5.2?) | 10:20 |
| seb128 | Saviq, well unsure in the sense of "I don't know why you have the alternative name, I didn't follow the qt packaging enough to say if that's correct" | 10:20 |
| Saviq | seb128, see http://packages.ubuntu.com/saucy/qtdeclarative5-private-dev vs. http://packages.ubuntu.com/trusty/qtdeclarative5-private-dev | 10:21 |
| Saviq | seb128, qtdeclarative5-private-dev in trusty depends on libqt5v8-5-private-dev | 10:21 |
| Saviq | seb128, and libqt5v8-5-private-dev doesn't exist for qt >= 5.2, it's "built into" qtdeclarative5-private-dev | 10:22 |
| seb128 | Saviq, ok, thanks for the pointer, makes sense now | 10:22 |
| seb128 | Saviq, +1 that one as well | 10:22 |
| Saviq | seb128, thanks | 10:22 |
| dednick | Saviq: dpkg not generating unity8-doc package | 10:23 |
| Saviq | dednick, :/ | 10:24 |
| dednick | need dh_install rule as well for doc? | 10:24 |
| Saviq | dednick, https://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2792/artifact/work/output/ | 10:24 |
| Saviq | dednick, jenkins disagrees | 10:24 |
| seb128 | dednick, building from the vcs linked previously? | 10:24 |
| seb128 | dednick, you have the new .install? | 10:24 |
| dednick | Saviq: it's building, but not generating the package | 10:24 |
| dednick | Saviq: no, just using dpkg still. Working on sbuilder env now | 10:25 |
| Mirv | seb128: yes Qt's V8 is no more, it's replaced by V4 insside qtdeclarative. | 10:26 |
| dednick | Saviq: hm, actually, it's not giving me autopilot either.... | 10:26 |
| Mirv | Saviq: but, qtdeclarative5-private-dev 5.0.2 depends on libqt5v8-5-private-dev | 10:26 |
| Mirv | nowadays, to avoid that need | 10:26 |
| Saviq | Mirv, not in saucy | 10:26 |
| Saviq | Mirv, that change is for saucy | 10:26 |
| Saviq | Mirv, https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 | 10:26 |
| seb128 | dednick, seems like you don't build arch all packages? | 10:26 |
| Mirv | Saviq: aha.. a stable release backport, no PPA usage? the SDK Release PPA has qtdeclarative for saucy too that has that. | 10:27 |
| dednick | seb128: er. dpkg-buildpackage -us -uc -B ? | 10:27 |
| Saviq | dednick, drop -B | 10:27 |
| Mirv | (and precise/quantal/raring) | 10:27 |
| dednick | -B not | 10:27 |
| dednick | hm | 10:27 |
| seb128 | dednick, -B is the issue indeed | 10:27 |
| Mirv | Saviq: https://launchpadlibrarian.net/159906274/qtdeclarative-opensource-src_5.0.2-6ubuntu4_5.0.2-6ubuntu5~saucy1~test1.diff.gz | 10:28 |
| dednick | ah, no arch-independant | 10:28 |
| Saviq | Mirv, hmm we require the sdk ppa anyway, maybe that change isn't needed then | 10:28 |
| dednick | doh | 10:28 |
| dednick | 3rd times a charm! | 10:28 |
| Mirv | Saviq: yes we require SDK PPA if it's about developers | 10:28 |
| Saviq | Mirv, ok, /me undo's | 10:29 |
| Mirv | thanks | 10:29 |
| seb128 | Mirv, thanks for reviewing it ;-) | 10:29 |
| Saviq | seb128, Mirv, done | 10:30 |
| didrocks | Saviq: sorry, too many fuzz here | 10:32 |
| didrocks | thanks seb128 for the review :) | 10:32 |
| seb128 | didrocks, yw! | 10:32 |
| Saviq | didrocks, no worries, got many eyes on it already :) | 10:32 |
| Mirv | approved | 10:33 |
| Saviq | Mirv, seb128, thanks! | 10:33 |
| Saviq | dednick, pushed OPTIONAL for the install of doc, so that cmake doesn't complain if you didn't build it | 10:33 |
| Cimi | Saviq, interface https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 | 10:40 |
| Saviq | Cimi, 55+ model: data | 10:41 |
| Saviq | Cimi, that's wrong | 10:41 |
| Saviq | Cimi, you will get the whole object as described in the docs | 10:41 |
| Saviq | Cimi, so you need data["tracks"] | 10:41 |
| Cimi | damm | 10:41 |
| Saviq | Cimi, also, be explicit - name the top level item | 10:42 |
| Saviq | Cimi, and reference data by that name | 10:42 |
| Cimi | root.data | 10:42 |
| Cimi | ok | 10:42 |
| Saviq | Cimi, yup, something like that | 10:42 |
| Cimi | Saviq, data["tracks"] will contain the model then? | 10:42 |
| Cimi | so I'll have to redo the mocks? | 10:43 |
| Saviq | Cimi, yes | 10:43 |
| Saviq | Cimi, well, not "redo", just wrap them in { "tracks": [] } | 10:43 |
| Cimi | Saviq, got a link handy | 10:43 |
| Cimi | of the json? | 10:43 |
| Saviq | Cimi, https://docs.google.com/a/canonical.com/document/d/1NmiM4UCnJgf6IEawmfyTOHRNAA5ZGrqpyrPqPOibwc8/edit#heading=h.6fng39a8onr | 10:44 |
| dednick | Saviq: does doxygen not generate for the qml files? | 10:44 |
| Saviq | dednick, it does, when they're documented | 10:44 |
| Saviq | dednick, Carousel should be there | 10:44 |
| dednick | Saviq: ahh | 10:44 |
| Saviq | dednick, I've hidden non-documented files, thought it didn't make sense otherwise | 10:44 |
| Saviq | Cimi, 405+ audioPlayer.stop() I don't think that's needed - and if it would be, then it needs to be part of the interface | 10:45 |
| Saviq | Cimi, or maybe not.. | 10:45 |
| Cimi | Saviq, currently | 10:45 |
| Cimi | Saviq, on current previews | 10:45 |
| Cimi | Saviq, there's a stop when the preview isCurrent turns falser | 10:45 |
| dednick | Saviq: they're not listed under 'Files', only 'Classes' | 10:46 |
| Cimi | Saviq, since this is no longer top level preview but a widget, thought of adding a function | 10:46 |
| Saviq | dednick, yeah, that seems a limitation of doxyqml | 10:47 |
| Saviq | dednick, or well, it doesn't add .cpp files either | 10:48 |
| Saviq | dednick, I'll have a chat with agateau (maintainer of doxyqml) | 10:48 |
| Saviq | Cimi, I'm just thinking what would be calling it | 10:48 |
| Cimi | Saviq, the preview page | 10:49 |
| dednick | Saviq: approved. | 10:49 |
| Saviq | Cimi, yeah, but that would basically mean that the preview should go away, so the player would get destroyed anyway | 10:49 |
| Cimi | Saviq, do they go away? | 10:49 |
| Cimi | Saviq, or they are listviews? | 10:49 |
| Saviq | Cimi, there's only 3 in a ListVIew | 10:50 |
| Saviq | Cimi, so if you move away by more than one | 10:50 |
| Saviq | Cimi, it gets destroyed | 10:50 |
| Saviq | Cimi, only use case I can think of is when you get a preview on top of your current one - but whether it should pause I'm not sure | 10:50 |
| Cimi | Saviq, but you want to move one, not two | 10:50 |
| Cimi | Saviq, you switch album | 10:50 |
| Cimi | and it should stop | 10:50 |
| Saviq | Cimi, yes, I know | 10:50 |
| Saviq | Cimi, just wondering whether it should really get destroyed or not | 10:51 |
| Saviq | Cimi, anyway, so let's say PreviewWidget gets a new property | 10:51 |
| Saviq | Cimi, "focused" | 10:51 |
| Cimi | ok | 10:51 |
| Saviq | Cimi, and preview widgets react to that | 10:51 |
| mhr3 | sil2100, so what's the news on the branch? | 10:54 |
| mhr3 | sil2100, you gave us a silo and that mp would like to be landed | 10:54 |
| sil2100 | mhr3: ok, so I poked fginther about it, since it seems it's something stranger | 10:57 |
| sil2100 | mhr3: oh, and we just recently published some silo, right? | 10:57 |
| Cimi | Saviq, data seems to cause troubles as a name | 10:58 |
| Cimi | var name | 10:58 |
| Cimi | can I change it to something else? | 10:58 |
| Cimi | previewData ? | 10:58 |
| fginther | sil2100, mhall119, the MP is failing to merge because jenkins is complaining that it has an unapproved pre-requisite, but that's not the case (it's actually merged). Will need to dig more. | 11:02 |
| sil2100 | mhr3: ^ | 11:02 |
| sil2100 | ;) | 11:02 |
| sil2100 | fginther: thanks! | 11:02 |
| mhr3 | fginther, so i'll just remove the pre-req since it's merged | 11:03 |
| * mhr3 really wants it in | 11:04 | |
| Saviq | Cimi, right, of course | 11:05 |
| Saviq | Cimi, widgetData | 11:05 |
| Saviq | Cimi, "data" is an internal QML name | 11:05 |
| Saviq | Cimi, sorry about that | 11:06 |
| fginther | mhr3, can I re-approve that MP? the last push to merge to trunk does not match the approved version. | 11:07 |
| mhr3 | fginther, i resubmitted it a minute ago | 11:08 |
| mhr3 | and approved | 11:08 |
| mhr3 | so should be good afaict | 11:09 |
| fginther | mhr3, ack. I'll watch it in case it doesn't start | 11:10 |
| Saviq | Cimi, you could add some docs - we'll be generating them soon enough | 11:15 |
| Saviq | Cimi, see http://bazaar.launchpad.net/~saviq/unity8/card-tool/revision/677 for an example | 11:15 |
| === _salem is now known as salem_ | ||
| === alan_g is now known as alan_g|dentist | ||
| Saviq | /food | 11:27 |
| anpok | i think you client does not suppor that | 11:29 |
| anpok | *your | 11:29 |
| dandrader | greyback, hey. it unity8 already using the mir socket and protocol as a general purpose mechanism to exchange information with apps (and vice versa)? | 11:34 |
| dandrader | s/it/is | 11:34 |
| karni | Saviq: FYI I'm on app/sdk sprint next week in Orlando, my presence may vary | 11:41 |
| Saviq | karni, ok | 11:57 |
| Saviq | karni, will you get us an updated look at your guys' priorities? | 11:57 |
| karni | Saviq: just noticed something interesting on my phone. flashed trusty-proposed, added demo-stuff ppa, rebooted, still see old scopes | 11:58 |
| karni | Saviq: yes, will do | 11:58 |
| Saviq | karni, apt-cache policy unity8? | 11:58 |
| Saviq | anpok, ;) | 11:59 |
| karni | Saviq: looks correct http://paste.ubuntu.com/6849035/ | 11:59 |
| Saviq | karni, no it doesn't, there's a newer unity8 from distro than there is from ppa | 12:00 |
| karni | oh, indeed | 12:00 |
| mhr3 | didrocks, deps between landed packages not really handled? https://launchpad.net/~ci-train-ppa-service/+archive/landing-009/+packages | 12:01 |
| karni | hrm | 12:01 |
| Saviq | karni, probably because I didn't merge trunk into new-scopes | 12:01 |
| Saviq | karni, pushed, kicking build now | 12:01 |
| karni | Saviq: thank you, sir! | 12:02 |
| mhr3 | didrocks, what will i have to do once the dep pkg publishes? | 12:02 |
| Saviq | mhr3, click "merge & clean" | 12:04 |
| Saviq | mhr3, and for the deps, just click "retry this build" | 12:05 |
| Saviq | mhr3, oh no you can't | 12:05 |
| Saviq | didrocks, ↑ valid issue | 12:05 |
| mhr3 | yea, i can't | 12:05 |
| mhr3 | the good news is that the build today was about 20x faster than last time | 12:06 |
| didrocks | mhr3: it's in dep wait | 12:07 |
| mhr3 | didrocks, yes, and the dep built now | 12:07 |
| didrocks | mhr3: ah, you have to wait for a cronjob IIRC in launchpad | 12:07 |
| didrocks | it's not triggered by signals) | 12:07 |
| didrocks | but launchpad is handling that | 12:07 |
| mhr3 | didrocks, does that really work in ppas? | 12:07 |
| didrocks | AFAIK, it does | 12:08 |
| Saviq | didrocks, yeah, I've never seen "dependency wait" to switch to "needs build" by itself | 12:08 |
| Saviq | let's see, then... | 12:09 |
| dednick | Saviq: just trying to understand unity-mir at the mo. how does mir know where to draw the surface? ie how does it know its position given a stage? Can't find unity telling it anywhere... | 12:09 |
| Saviq | dednick, currently unity-mir has it hardcoded | 12:09 |
| didrocks | Saviq: mhr3: you can ping wgrant about it (I'm ddosing on pings right now) | 12:09 |
| dednick | Saviq: ahh. i c. | 12:09 |
| Saviq | ;D | 12:09 |
| === MacSlow is now known as MacSlow|lunch | ||
| dednick | thought i was going a bit mad | 12:10 |
| mhr3 | didrocks, k | 12:10 |
| Saviq | @unity: any branches you guys would like landed? There's five in queue currently | 12:10 |
| Saviq | elopio, can you please fill checklist on https://code.launchpad.net/~elopio/unity8/generic_preview/+merge/202793 | 12:11 |
| dednick | mzanetti: did you take a look at https://code.launchpad.net/~nick-dedekind/unity8/plugin-qml/+merge/203810 ? | 12:11 |
| Saviq | dednick, mzanetti's refusing to approve branches before CI goes green again ; | 12:12 |
| Saviq | ;) | 12:12 |
| dednick | ahha. dang | 12:12 |
| dednick | then no, i guess | 12:12 |
| Saviq | dednick, which it will with this lannding | 12:12 |
| karni | Saviq: which row of landing spreadsheet where you referring to? | 12:12 |
| dandrader | Saviq, no | 12:12 |
| * karni doesn't see unity8-fix-mascot in the sheet | 12:13 | |
| Saviq | karni, none, yet, just https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews | 12:13 |
| karni | ah | 12:13 |
| mzanetti | dednick: I looked at it, but CI seems still red | 12:13 |
| karni | cool | 12:13 |
| dednick | mzanetti: no worries, no rush on that one | 12:13 |
| Saviq | sil2100, I can has silo for unity8? | 12:16 |
| sil2100 | Saviq: let me look at that | 12:17 |
| Saviq | sil2100, thanks | 12:17 |
| Saviq | karni, I'll have patched (blurriness) qtbase packages for you in a few minutes | 12:18 |
| karni | Saviq: w00t! | 12:18 |
| Saviq | karni, new unity8-newscopes built in demo-stuff for amd64/i386, soon there for armhf | 12:23 |
| sil2100 | Saviq: so, we have a limited number of silos right now, so it might take a while at most - we're trying to bump the number of silos anyway, but it's something not for today | 12:23 |
| karni | Saviq: very neat, very neat :) | 12:23 |
| Saviq | sil2100, so no spot for us yet? ;( | 12:23 |
| Saviq | sil2100, 002, 007 and 010 look empty? are they queued for someone or waiting for cleanup? | 12:24 |
| Saviq | sil2100, not complaining, just trying to get more data | 12:24 |
| Saviq | thostr_, "When you allocate a silo just go ahead and hit build at the same time. Thanks!" delegating already, nice one! | 12:27 |
| thostr_ | Saviq: ? | 12:28 |
| thostr_ | Saviq: the comment. yes, I think that is a pattern we should apply | 12:29 |
| Saviq | thostr_, indeed, no point in assigning a silo without building, agreed | 12:29 |
| thostr_ | Saviq: at least I started this and e.g. initiated bfillers requests, so when he starts his day he should have all his packages built | 12:29 |
| Saviq | thostr_, yup | 12:30 |
| sil2100 | Saviq: so, I had a talk with Didier, and I would be grateful if you could wait with silo assignment for unity8 for now | 12:47 |
| sil2100 | Saviq: just a little bit ;) | 12:48 |
| Saviq | sil2100, ok, can you let me know before you'd assign them in case we'd like another branch to get in? | 12:49 |
| sil2100 | Saviq: sure! | 12:49 |
| Saviq | dednick, you have some time - merge the test fix and resubmit your branch with prerequisite if you want it in! ;D | 12:49 |
| === dandrader is now known as dandrader|afk | ||
| Saviq | aargh stupid optipng ;/ | 12:56 |
| Saviq | Mirv, you really need to disable OPTIPNG for qt packages... it's a half hour already here that it's built and just mangling already-optimized pngs... | 12:57 |
| Saviq | Mirv, or something... | 12:57 |
| * Saviq finds a way to disable optipng system-wide | 12:58 | |
| karni | Saviq: card-tool -- looking good :) let me know when you want further feedback/when it goes out of WIP | 12:59 |
| Saviq | karni, yeah, I just need to add some tests, will happen soon (I hope) | 12:59 |
| karni | very cool | 13:00 |
| === alan_g|dentist is now known as alan_g|lunch | ||
| Mirv | Saviq: it could be similarly temporarily disable to how I'm temporarily enabling debug options | 13:01 |
| Mirv | Saviq: I know I've bookmarked your disabling trick _somewhere_ :) | 13:02 |
| Saviq | Mirv, I just feel like it's wasting so much builders' time | 13:02 |
| Saviq | Mirv, export NO_PKG_PNG_MANGLE=1 | 13:02 |
| Saviq | export NO_PNG_PKG_MANGLE=1 | 13:02 |
| Saviq | PKG_PNG vs. PNG_PKG :/ | 13:02 |
| mhr3 | sil2100, more train questions | 13:05 |
| elopio | Saviq: I already did: https://code.launchpad.net/~elopio/unity8/generic_preview/+merge/202793/comments/475007 | 13:05 |
| Saviq | elopio, yeah, saw that | 13:05 |
| Saviq | elopio, please put submitter checklists in description | 13:05 |
| Saviq | elopio, reviewer in comments, as there may be more | 13:05 |
| Saviq | elopio, I copied it already | 13:05 |
| elopio | Saviq: ok. Thanks. | 13:05 |
| mhr3 | sil2100, the build failed, do i need to check any of the options now when i try to rebuild? | 13:06 |
| === dandrader|afk is now known as dandrader | ||
| Cimi | Saviq, it's fine now https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 | 13:10 |
| Saviq | Cimi, \brief not needed if only one line | 13:11 |
| Cimi | ok | 13:11 |
| sil2100 | mhr3: no, you can specify what specific packages you want to rebuild but you don't have to | 13:11 |
| Cimi | done | 13:12 |
| Saviq | Cimi, no tests for subtitle, but otherwise looks good, I'll leave to Albert to review properly on Monday | 13:12 |
| Cimi | Saviq, how can I test subtitle? | 13:12 |
| Cimi | oh sorry | 13:12 |
| mhr3 | sil2100, well, i need to rebuild the one that succeeded cause that broke the one that failed :) | 13:12 |
| Cimi | subtitle I think I tested it | 13:12 |
| Saviq | Cimi, not there in mocks? | 13:13 |
| Saviq | Cimi, wrong, it's there | 13:13 |
| Saviq | Cimi, sorry, it's good | 13:13 |
| Cimi | Saviq, time is not tested | 13:13 |
| Cimi | Saviq, not sure how I can test it | 13:13 |
| Cimi | Saviq, because it's processed | 13:13 |
| Cimi | from seconds I have a string | 13:13 |
| Saviq | Cimi, well, yeah, you should supply one value and check that the string is what you expect? | 13:13 |
| mhr3 | sil2100, so i just click the rebuild without checking any of the options? | 13:13 |
| Saviq | Cimi, that's the easiest thing to test :) - input, output | 13:14 |
| Saviq | Cimi, have a separate test function for it | 13:14 |
| Cimi | Saviq, yes but that will mean adding an extra field to the mock | 13:14 |
| sil2100 | mhr3: yep :) | 13:14 |
| Cimi | I wanted to keep the mock like the one it will receive | 13:15 |
| Cimi | but I can do it | 13:15 |
| sil2100 | mhr3: it will then take all the components, fetch latest revisions of the branches and build | 13:15 |
| Saviq | Cimi, wait | 13:15 |
| Saviq | Cimi, no, no more fields in mocks, why would you need it there? | 13:15 |
| Cimi | Saviq, I don't know wehre | 13:15 |
| Cimi | if not there | 13:15 |
| Cimi | it's the easiest... | 13:15 |
| karni | Saviq: unity-scope-tool requires 14.04, right? | 13:15 |
| Saviq | karni, should be fine in 13.10 | 13:15 |
| karni | ack | 13:16 |
| Saviq | Cimi, so well, I wouldn't have gone your route of just putting the model in _data | 13:16 |
| Saviq | Cimi, but instead I'd go with three separate test functions for the three different models | 13:16 |
| Saviq | Cimi, and then in _data() you put the expected values | 13:16 |
| Saviq | Cimi, one of which would be the expected processed time | 13:16 |
| Saviq | Cimi, but even now you can just add an array to {tag: "0 tracks", tracksModel: tracksModel0}, | 13:17 |
| Cimi | I can add an array to _data for expected length in case | 13:17 |
| Saviq | Cimi, yeah, it's a bit convoluted, but yeah | 13:17 |
| mhr3 | sil2100, can i make it build just one source pkg and the other later? | 13:17 |
| Saviq | Cimi, and to really test the **it out of that function | 13:17 |
| mhr3 | sil2100, cause i know right now that the second one will fail until the first one doesn't build | 13:18 |
| Saviq | Cimi, ah, take out the lengthToString() function from under the Repeatre | 13:18 |
| Saviq | Cimi, have a separate _data() and test_ pair, put it in Audio for example - we only need one copy of that function | 13:18 |
| Saviq | Cimi, then, have a separate _data() and test_ pair, findChild() the Audio component | 13:19 |
| Saviq | Cimi, and just test what you get out when supplying undefined, 0, -1, 1, 60, 120, 3600, 7201 etc. | 13:19 |
| Cimi | ok | 13:20 |
| Saviq | so your _data() would look more or less: | 13:20 |
| Saviq | [ { tag: "0", value: 0, result: "0:00" }, { tag: "-1", value: -1, result: undefined } ] or so | 13:21 |
| Cimi | sure | 13:21 |
| Saviq | https://code.launchpad.net/~saviq/unity8/card-tool/+merge/204093 ready for review | 13:27 |
| Saviq | karni, actually let me do one more thing | 13:28 |
| Saviq | karni, or well, a few more things... | 13:29 |
| === alan_g|lunch is now known as alan_g | ||
| didrocks | mhr3: Saviq: see, it retried automatically | 13:30 |
| Saviq | didrocks, yeah, an hour - too long ;) | 13:31 |
| Saviq | didrocks, we might need a button "retry builds" | 13:31 |
| karni | Saviq: ack, ping me when ready :) | 13:31 |
| didrocks | Saviq: or fix launchpad to get a quicker retry? | 13:31 |
| Saviq | didrocks, or that ;) | 13:31 |
| didrocks | in the archive, it's even based | 13:32 |
| didrocks | not sure why the ppas can't | 13:32 |
| mhr3 | Saviq, removing rating-input::submit-icon per katie's comment | 13:37 |
| Saviq | mhr3, ok | 13:37 |
| Saviq | karni, ready | 13:43 |
| karni | ack | 13:43 |
| karni | Saviq: do you want to still own it, or pass to unity-team? | 13:44 |
| karni | Doesn't matter for me, just a check. | 13:45 |
| Saviq | karni, we only push as ~unity-team if we foresee someone else needing to commit to it | 13:45 |
| * karni nod | 13:45 | |
| karni | Saviq: neat way to OWN stuff ;) | 13:45 |
| Saviq | karni, crap, it's 300MB of .debs for qtbase... | 13:47 |
| karni | hahahhaha | 13:47 |
| * Saviq tests his pipe's upload capabilities | 13:48 | |
| * karni chuckles | 13:48 | |
| Saviq | 1.2MB/s, it's fine ;P | 13:48 |
| karni | :D | 13:48 |
| Saviq | 3 minutes | 13:48 |
| karni | Saviq: Just a thought, not for this MP - I think that referencing test cases by index (from the drop down component) is error prone. One has to keep in mind which case are you referencing. Adding a test case within (instead of at the end) would screw test suite beautifully. Maybe something we can get better one day? | 13:51 |
| karni | Less things you keep in mind when coding = better code (well.. you get the point) | 13:51 |
| Saviq | karni, we can probably id them by name instead of index somehow | 13:51 |
| Saviq | karni, can definitely be improved | 13:51 |
| karni | Saviq: yes, that's what I mean | 13:51 |
| * karni nods | 13:51 | |
| karni | Saviq: waiting for CI run | 13:53 |
| Saviq | karni, yup | 13:53 |
| Saviq | karni, http://people.canonical.com/~msawicz/qtbase_amd64.tar.xz | 13:54 |
| karni | \o/ | 13:54 |
| * Saviq likes his pipe | 13:54 | |
| Saviq | karni, armhf is still in the works, optipng will probably take a while still :? | 13:54 |
| karni | :) | 13:54 |
| Saviq | we have more qml tests in unity8 now that employees in Canonical ;D | 13:56 |
| * Saviq likes :D | 13:56 | |
| Saviq | even if we did cross the magical 600 employees boundary | 13:56 |
| Saviq | 611 today | 13:57 |
| karni | Saviq: downloaded | 13:57 |
| karni | Saviq: hahah | 13:57 |
| karni | Saviq: wow, number of packages. do you remember which one contained the fix, or should I just install em all x)? | 13:58 |
| === MacSlow|lunch is now known as MacSlow | ||
| Saviq | karni, for i in $( dpkg -l `for i in *.deb; do echo $i | cut -d_ -f1; done` 2>/dev/null | grep 5.0.2 | cut -d' ' -f3 | cut -d':' -f1 ); do echo -n "$i*.deb "; done; echo | 14:00 |
| karni | Saviq: I also like bash, but you just slaped the 'awesome' sticker on your 'already-awesome' perception from my POV haha | 14:02 |
| Saviq | ;) | 14:02 |
| Saviq | karni, thought you'd enjoy that | 14:02 |
| karni | Saviq: btw that last echo was intentional or got trimmed? | 14:02 |
| karni | oh yeah :) | 14:03 |
| Saviq | karni, just so you don't end up with prompt at the end of the lsit | 14:03 |
| Saviq | list | 14:03 |
| karni | :D | 14:03 |
| * karni joined scope sync with Scott and Joe | 14:05 | |
| mhr3 | sil2100, so, the prereq package re-built, how do i make retry building the second one? | 14:06 |
| mhr3 | sil2100, i don't have powers that be to see a "retry this build" for the ppa | 14:06 |
| sil2100 | mhr3: I'll try that, but it also happens automatically - just it probably takes some time ;/ | 14:10 |
| sil2100 | mhr3: we're thinking on how to deal with this | 14:10 |
| mhr3 | sil2100, not the same thing, the build failed, it isn't in dep wait | 14:10 |
| sil2100 | mhr3: ah, you mean, it failed and you just want to rebuild it? You can always do it from the Build job - just list the source package name you want to rebuild | 14:11 |
| mhr3 | sil2100, into the prepare-only? | 14:12 |
| sil2100 | mhr3: yes, it will then fetch all the merges related to that source and push them to the PPA again | 14:13 |
| mhr3 | sil2100, since the mps didn't change do i need "force-rebuild"? | 14:13 |
| sil2100 | mhr3: no, it's fine | 14:14 |
| mhr3 | ok, let's see what happens | 14:14 |
| sil2100 | At least in theory | 14:14 |
| sil2100 | ;) | 14:14 |
| karni | Saviq: thostr_: Who would we need to talk to about porting news and weather scopes to the new server scope api? | 14:27 |
| karni | Cc ssweeny | 14:28 |
| thostr_ | karni: lucio | 14:28 |
| karni | ack, thank you thostr_ | 14:28 |
| thostr_ | karni: but hurry up he's only here today, then he goes on vacation | 14:28 |
| karni | ouch | 14:28 |
| karni | omw | 14:28 |
| mzanetti | @unity standup | 14:32 |
| dandrader | mzanetti, already there | 14:32 |
| mzanetti | it should be possible to exclude people :) like @unity -dandrader :D | 14:32 |
| karni | mzanetti: lol | 14:33 |
| Saviq | like that'd work ;D | 14:33 |
| mzanetti | :D | 14:33 |
| Saviq | greyback, standup | 14:33 |
| karni | @greybackrocks | 14:33 |
| greyback | darn | 14:33 |
| Cimi | Saviq, added tests | 14:40 |
| Saviq | Cimi, o/ | 14:40 |
| dednick | elopio: what did you need help with? sorry, i missed your request. | 14:40 |
| elopio | dednick: qt5.2 errors. | 14:41 |
| dednick | elopio: in qmltests? | 14:41 |
| elopio | dednick: I'm just starting to look at them. https://bugs.launchpad.net/unity8/+bug/1274484 | 14:42 |
| elopio | Mirv reported 5 autopilot errors. I'll run the unit tests, and the autopilot tests and report some more detailed bugs. | 14:42 |
| ubot5 | Ubuntu bug 1274484 in Unity 8 "5 unity8 AP tests failing with Qt 5.2" [Critical,New] | 14:43 |
| karni | Saviq: Card size was applied only to first card of the carousel. While I believe I do understand your branch well, I would not understand why card size would not apply to all carousel Cards before. | 14:43 |
| Saviq | karni, because it was set wrong | 14:43 |
| Saviq | karni, it needs to be "synced" between the delegates and the carousel itself | 14:44 |
| Saviq | karni, so it got confused (chicken'n'egg issue) | 14:44 |
| karni | Saviq: Well, I can't be happier than, can I! :) | 14:44 |
| Saviq | karni, so yeah, I wanted to wait until this lands in trunk and merge into new-scopes and integrate CardTool into CardFilterGrid, CardCarousel and friends | 14:45 |
| karni | Saviq: that's a blast! | 14:45 |
| Saviq | karni, but might need to change the plans if we don't get a silo for a while still | 14:45 |
| * karni nods | 14:45 | |
| * mzanetti goes away for an hour and a half | 14:46 | |
| Saviq | karni, top-ack? | 14:53 |
| karni | sry | 14:53 |
| karni | Saviq: done | 14:53 |
| Saviq | thanks | 14:53 |
| karni | yw! | 14:53 |
| Saviq | dednick, can you please verify docs still work for you, and include qml sources now? | 14:55 |
| Saviq | dednick, and re-approve to pick up the new rev | 14:55 |
| dednick | Saviq: sure. give me a few minutes | 14:57 |
| Saviq | dednick, thanks | 14:58 |
| karni | Saviq: CardFilterGrid works fine rendering wise, maybe we could prioritize integration of CardTool into CardCarousel (DashCarousel, or whichever would be appropriate)? | 15:02 |
| karni | anyway, I'll try to work out the list of our needs asap, trying to multithread | 15:03 |
| Saviq | karni, it's at the top of my prio | 15:03 |
| karni | Saviq: <3 | 15:03 |
| Saviq | karni, the next thing is to fix CardFilterGrid not being centered | 15:03 |
| * karni nods | 15:03 | |
| karni | :) | 15:03 |
| Saviq | karni, I'll probably prepare a branch while we don't have cardtool in trunk | 15:03 |
| dednick | Saviq: cool, still works + qml is there. approved | 15:04 |
| karni | Saviq: great :) | 15:04 |
| Saviq | dednick, thanks | 15:07 |
| === dandrader is now known as dandrader|lunch | ||
| Saviq | karni, apparently forgot about carousel ;) | 15:11 |
| karni | Saviq: excuse me? | 15:12 |
| Saviq | karni, in CardTool | 15:12 |
| Saviq | karni, no carousel ;) | 15:12 |
| karni | d'uhhhhhh | 15:12 |
| karni | xDD | 15:12 |
| karni | I'm a terrible reviewer | 15:12 |
| karni | Saviq: since it's write protected with ~saviq :D can you still push up a fix? | 15:13 |
| Saviq | karni, sure, just cooking it up | 15:13 |
| karni | phew | 15:13 |
| * karni reboot | 15:14 | |
| karni | Saviq: with all the work that you've put in, I'd really like to make it work here. I installed the packages your bash line returned, rebooted, mascot still blured. But don't let this take your focus away from CardTool related improvements! | 15:32 |
| Saviq | karni, must be it's actually a different issue | 15:33 |
| === dandrader|lunch is now known as dandrader | ||
| Saviq | sil2100, FYI unity-mir waiting for a silo now, too | 16:08 |
| sil2100 | Saviq: ok, I guess soon we might figure out the regression and then we can resume normal landings | 16:09 |
| Saviq | sil2100, yup, thanks | 16:09 |
| Saviq | dednick, you around? | 16:12 |
| Saviq | dednick, ah, here you are :) | 16:12 |
| Saviq | karni, sorry for the delay, pushed card-tool | 16:23 |
| karni | Saviq: np, compiling notes from a meeting I just had | 16:23 |
| thostr_ | sil2100: where I can see if you guys clicked the publish button? | 16:25 |
| thostr_ | sil2100: (except trying to see if the package is available via launchpad) | 16:25 |
| sil2100 | thostr_: it's usually saying then that it's migrating the package to the archive | 16:25 |
| thostr_ | sil2100: can you do that for some of the silos? | 16:26 |
| thostr_ | sil2100: seems like 5 silos are waiting for the publish button to be clicked? | 16:27 |
| sil2100 | thostr_: yes yes, we didn't publish them yet since we're trying to resolve a regression first | 16:27 |
| thostr_ | sil2100: ah, ok | 16:28 |
| karni | Saviq: sorry, handling other stuff along ETOOLITTLEHANDS will get to your review asap | 16:38 |
| Saviq | karni, no worries | 16:39 |
| Saviq | mhr3, hmm I'm not getting results in new scopes, that expected? | 16:40 |
| === greyback_ is now known as greyback|food | ||
| Saviq | mhr3, and btw "restart scope-registry" just killed my session a second ago ;) | 16:40 |
| mhr3 | Saviq, how what why? | 16:45 |
| Saviq | mhr3, not sure, but it happened | 16:46 |
| Saviq | ⟫ restart scope-registry | 16:46 |
| Saviq | restart: Connection was disconnected before a reply was received | 16:46 |
| Saviq | mhr3, and my whole session went away | 16:46 |
| Saviq | mhr3, but anyway, unimportant ;P | 16:46 |
| Saviq | mhr3, no results in new scopes? | 16:46 |
| mhr3 | are you running a unity8 session? | 16:46 |
| mhr3 | Saviq, apt-cache policy libunity-scopes0 | 16:47 |
| Saviq | mhr3, no, not unity8 session, 0.2.6+14.04.20140128-0ubuntu1 | 16:47 |
| mhr3 | ps aux | grep scoper | 16:48 |
| mhr3 | Saviq, upstart crash i guess? | 16:48 |
| Saviq | mhr3, probably, yeah | 16:48 |
| Saviq | mhr3, I do get the scope, but no results | 16:48 |
| Saviq | mhr3, i.e. I get the header and the category | 16:48 |
| mhr3 | then you broke the renderer :) | 16:49 |
| mhr3 | cause no results = no category | 16:49 |
| Saviq | mhr3, if someone broke it, it's you ;) | 16:49 |
| Saviq | mhr3, I didn't push to new-scopes for a while | 16:49 |
| * Saviq tries again | 16:49 | |
| Saviq | karni, something along those lines lp:~saviq/unity8/newscopes-card-tool should improve grid and carousel | 16:49 |
| mhr3 | Saviq, i wanted to, but they don't want to publish the new versions :P | 16:49 |
| Saviq | karni, but I've no results yet :/ | 16:49 |
| Saviq | karni, caution recommended | 16:50 |
| karni | Saviq: ack! will look asap, gotcha | 16:50 |
| Saviq | mhr3, ok, results are back | 16:50 |
| mhr3 | Saviq, see, you just need to ping me, then it fixes itself :P | 16:51 |
| Saviq | mhr3, and I did break the renderer indeed | 16:52 |
| Saviq | ok /me goes for food now | 16:52 |
| mhr3 | lol | 16:52 |
| mhr3 | at least once i'm right :P | 16:52 |
| Cimi | Saviq, http://paste.ubuntu.com/6850317/ | 16:56 |
| Cimi | Saviq, component name is ugly :D | 16:56 |
| Cimi | I called it SeeMore.qml | 16:57 |
| === greyback|food is now known as greyback | ||
| Saviq | karni, ok, fixed grid, it looks great now | 17:02 |
| karni | Saviq: WOHOOO | 17:02 |
| Saviq | karni, carousel needs tweaking, but it's ok, too | 17:02 |
| karni | And I have some friggin broke news for you guys ;D You'll get a laugh. | 17:03 |
| * karni preps a paste | 17:03 | |
| Saviq | /food | 17:03 |
| karni | mhr3: (Cc ssweeny) http://paste.ubuntu.com/6850362/ | 17:05 |
| karni | Saviq: for your entertainment ↑ | 17:05 |
| karni | Saviq: mhr3: ignore the mascot: art line, it was unrelated when I tested this | 17:06 |
| mhr3 | NO | 17:06 |
| mhr3 | WAY | 17:06 |
| karni | I pushed the renderer.json to the phonee twice | 17:06 |
| karni | mhr3: want a screenshot? hahaha. I'm serious, tho :| | 17:06 |
| * karni tries this trick with scope-onlinemusic hehe | 17:07 | |
| mhr3 | i won't believe until i run that on my device before my very own eyes | 17:07 |
| mhr3 | eh, *in front of | 17:07 |
| karni | mhr3: I'll ping you in a sec with a supposedly broken json file | 17:08 |
| Saviq | karni, whoa | 17:12 |
| karni | Trying to reproduce this on scope-onlinemusic | 17:12 |
| Saviq | karni, I can has the whole renderer.json in both versions? | 17:13 |
| karni | yes, in a sec | 17:13 |
| * karni takes time to reproduce this, I already said on another channel that's most ridiculous thing I ever said in programming | 17:21 | |
| Saviq | karni, fixed carousel | 17:22 |
| karni | Saviq: you're amazing :) | 17:23 |
| Cimi | Saviq, quick opinion on that component? ^ | 17:23 |
| Saviq | Cimi, use AbstractButton instead of the custom MouseArea | 17:24 |
| Saviq | Cimi, so AbstractButton { Label { } } | 17:24 |
| Cimi | Saviq, but I'll have to use style | 17:24 |
| Saviq | Cimi, AbstractButton is not visual | 17:25 |
| Cimi | Saviq, abstract button already has text property | 17:25 |
| Saviq | orly | 17:25 |
| Cimi | and ion | 17:25 |
| Cimi | icon | 17:25 |
| Cimi | but doesn't draw anything for me | 17:25 |
| Saviq | Cimi, yes, which is fine | 17:25 |
| Saviq | Cimi, it implements the behavior of a button | 17:26 |
| Saviq | Cimi, either way | 17:26 |
| Saviq | Cimi, no need for enabled: ! | 17:27 |
| Cimi | Saviq, it's to reduce mouse areas | 17:27 |
| karni | Saviq: card-tool bzr pull -- branches diverged. you overwrote/uncommited something? | 17:27 |
| Saviq | karni, newscopes-card-tool is on top of new-scopes | 17:27 |
| Saviq | Cimi, yeah, but I'd rather eat that event and not react to it than to let it through | 17:28 |
| Saviq | Cimi, and it doesn't "reduce" them in any meaningful way | 17:28 |
| Cimi | Saviq, shall I really use abstract buttons? | 17:28 |
| Saviq | Cimi, I'd go s/seeMoreEnabled/seeMore/ or even s/seeMoreEnabled/more/ | 17:28 |
| Saviq | Cimi, your call | 17:28 |
| Cimi | nope then | 17:29 |
| Saviq | Cimi, other than that property name it looks fine | 17:29 |
| Saviq | Cimi, and SeeMore.qml is fine with me | 17:29 |
| sil2100 | mhr3: hi! | 17:29 |
| Cimi | Saviq, will add tests and push | 17:30 |
| Saviq | Cimi, how about some behaviour on opacity? | 17:30 |
| sil2100 | mhr3: so, I published your changes and it seems I made a mess because of that | 17:30 |
| karni | Saviq: I wanted to +1 last two commits at https://code.launchpad.net/~saviq/unity8/card-tool/+merge/204093 | 17:30 |
| mhr3 | sil2100, how so? | 17:30 |
| karni | Saviq: should I be reviewing newscopes-card-tool instead.. ? | 17:30 |
| karni | nvm, I'll just clean branch it | 17:31 |
| Saviq | karni, no | 17:31 |
| Saviq | karni, review on card-tool is good | 17:31 |
| Saviq | karni, newscopes-card-tool is just prep for when card-tool gets into trunk | 17:31 |
| karni | ack | 17:31 |
| Saviq | karni, to actually use card-tool | 17:31 |
| sil2100 | mhr3: tell me, why are you directly depending on libunity-scopes0 in debian/control on one of the packages in unity-scopes-shell ? | 17:31 |
| Saviq | karni, there's little on top of card-tool there | 17:31 |
| mhr3 | sil2100, cause the pkg isn't maintaining proper abi compability yet | 17:32 |
| sil2100 | mhr3: hm, what do you have in mind? | 17:32 |
| karni | Saviq: +1 card-tool | 17:33 |
| Saviq | karni, cool thanks | 17:33 |
| mhr3 | sil2100, it deps on libunity-scopes0, but that keeps changing its abi, so we need to specify exact version to not get into a state where the are installed, but incompatible | 17:33 |
| karni | Saviq: thank you | 17:33 |
| Saviq | Cimi, I'd go for Behavior on just one of those labels | 17:34 |
| Saviq | Cimi, and then the other's opacity based on the first one | 17:34 |
| mhr3 | sil2100, like it just upgraded just unity-plugin-scopes without upgrading libunity-scopes | 17:34 |
| Saviq | Cimi, so that they're always opposite, without the need for two Behaviors | 17:34 |
| mhr3 | sil2100, if you just upgraded...* | 17:35 |
| sil2100 | slangasek: ^ | 17:35 |
| sil2100 | slangasek: not sure if that's a proper reason, but I'm not sure how to resolve it in any other way then | 17:35 |
| slangasek | sil2100: "keeps changing its ABI" - ok, for the record I will not sign off on any library being uploaded to the Ubuntu archive that changes ABI without *at minimum* changing its binary package name | 17:36 |
| slangasek | I was aware that there were libraries currently being managed this way; this needs to stop | 17:37 |
| mhr3 | slangasek, and it will once we declare the library stable | 17:37 |
| slangasek | I'm not going to block someone else signing off on it, but the currently-employed method also doesn't guarantee consistency | 17:37 |
| slangasek | mhr3: I don't consider "once we declare the library stable" to be sufficient. These are baseline requirements for anything in the Ubuntu archive | 17:39 |
| mhr3 | the library is under heavy development and we're forced to keep pushing it in the archive | 17:42 |
| mhr3 | all its users are currently internal and they're well aware the api and abi unstable | 17:43 |
| slangasek | yes, but your current declarations fail to actually enforce consistency | 17:43 |
| slangasek | they only prevent the inconsistency in *one* direction but not the other | 17:44 |
| mhr3 | we could have just dropped it and noone would ever know | 17:44 |
| mhr3 | we chose to do at least one-way enforcing instead | 17:45 |
| Saviq | Cimi, on that note, are you sure you should be using raised/black everywhere? | 17:45 |
| Saviq | Cimi, I don't see that in the designs | 17:45 |
| Cimi | Saviq, no | 17:45 |
| Cimi | Saviq, will fix designs when we'll have something working | 17:45 |
| Cimi | s/designs/implementations | 17:45 |
| Saviq | Cimi, ok, drop the style at least, it's not there in the designs | 17:46 |
| Cimi | ok | 17:46 |
| Saviq | Cimi, and there's a separator you could add | 17:46 |
| Cimi | Saviq, how? | 17:46 |
| Cimi | Saviq, I thought about it | 17:46 |
| Cimi | rectangle? | 17:46 |
| slangasek | mhr3: it's absolutely not true that people wouldn't know. Playing fast and loose with ABI declarations significantly impedes the CI infrastructure being able to automatically land the right thing | 17:47 |
| Saviq | Cimi, no, isn't it just a rotated ThinDivider? | 17:47 |
| Cimi | dunno | 17:47 |
| karni | Saviq: mhr3: For your entertainment, I can't get summary to show up on our custom scope at all (as opposed to sample "summary": "artist" mapping working just fine in scope-onlinemusic). I'll get back to you guys when I have less ridiculous news, I hope you enjoyed the read anyway ;) | 17:48 |
| karni | Saviq: Would you like me to review anything else (carousel fix)? | 17:49 |
| mhr3 | slangasek, isn't this actually poor man's solution so that it actually does land the correct thing? | 17:50 |
| Cimi | Saviq, tried with hebaviour | 17:50 |
| Cimi | Saviq, doesn't look nice | 17:50 |
| Saviq | Cimi, ok | 17:51 |
| Saviq | karni, let me see if I can make this diff sane | 17:51 |
| karni | :) | 17:51 |
| mhr3 | slangasek, eventually anyway :) | 17:52 |
| Saviq | karni, https://code.launchpad.net/~saviq/unity8/newscopes-card-tool/+merge/204301 looks ok | 17:54 |
| Saviq | karni, if you want a local diff, merge card-tool into new-scopes first | 17:54 |
| Saviq | karni, you need to re-top-approve card-tool, 'cause it holds the old revision as approved | 17:56 |
| karni | Saviq: done | 17:56 |
| Saviq | karni, tx | 17:57 |
| karni | ssweeny: This is comedy. I got the summary to appear, and now I can't get it to break. =_= | 17:59 |
| slangasek | mhr3: why are we resorting to poor-man's solutions, which have failure scenarios that we can actually handle? | 18:02 |
| Cimi | Saviq, any clever idea to animate maximumLineCount? | 18:04 |
| Saviq | Cimi, clip + behaviour on height | 18:04 |
| Cimi | Saviq, so I don't use it? | 18:05 |
| Saviq | Cimi, you do | 18:05 |
| Saviq | just when you change maximumLineCount | 18:05 |
| Saviq | Cimi, height is behaviourized | 18:05 |
| === dandrader is now known as dandrader|afk | ||
| mhr3 | slangasek, cause as you said, we're playing fast | 18:05 |
| Cimi | Saviq, adding behaviour on height doesn't change anything | 18:06 |
| === alan_g is now known as alan_g|EOW | ||
| * Saviq wants to get rid of DashRenderer so bad... | 18:09 | |
| sil2100 | Saviq: I'll assign a silo for unity8 for you after I eat something and get to the hotel, ok? :) | 18:10 |
| Saviq | sil2100, sure, no worries | 18:10 |
| Cimi | Saviq, thank you | 18:15 |
| Cimi | why is it so bad? :D | 18:15 |
| Saviq | Cimi, so does it work or not? | 18:15 |
| Cimi | Saviq, I was joking about dashrenderer | 18:15 |
| Cimi | Saviq, no, the behaviour doesn't work | 18:16 |
| Saviq | Cimi, because all the properties are going three ways | 18:16 |
| Saviq | Cimi, you might need height: implicitHeight, although that'd be weird | 18:16 |
| Cimi | Saviq, height changes | 18:16 |
| Cimi | Saviq, but it doesn't animate | 18:16 |
| Cimi | mmm | 18:19 |
| Cimi | this component requires a bit more work | 18:19 |
| Cimi | cannot finish it today | 18:19 |
| Cimi | it has to show SeeMore depending on the number or lines of text displayed | 18:20 |
| Cimi | I guess I'll do this monday | 18:20 |
| Cimi | :P | 18:20 |
| Cimi | Saviq, I can use height+clip instead of maximumLineHeight | 18:22 |
| karni | Saviq: mhr3: ssweeny: Sent you good and bad json renderer files, with more details, and debs to try. | 18:22 |
| karni | ssweeny: With that said, you should be able to make screenshots today. | 18:23 |
| Saviq | Cimi, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-text.html#lineCount-prop | 18:23 |
| Cimi | Saviq, I know this | 18:23 |
| Cimi | Saviq, but height is fine | 18:23 |
| Cimi | Saviq, if description is taller than X height | 18:24 |
| Cimi | Saviq, I add seeMore that clips to X | 18:24 |
| Cimi | otherwise I don't set height | 18:24 |
| Saviq | Cimi, yeah, but that won't clip at line boundary | 18:24 |
| Cimi | or just set it to lineHeight*lineCOunt | 18:24 |
| Cimi | Saviq, I'll clip it smart | 18:25 |
| Saviq | Cimi, whenever you think about calculating something based on lineHeight, stop ;) | 18:25 |
| Cimi | Saviq, we could potentially fade with a gradient on last line | 18:25 |
| Saviq | Cimi, http://paste.ubuntu.com/6850737/ *almost* works | 18:25 |
| Saviq | Cimi, I forgot what I did to delay the clipping of text | 18:26 |
| Saviq | Cimi, but I did it somewhere already | 18:26 |
| Saviq | Cimi, if all else fails - ShaderEffect { live: false }... | 18:27 |
| === dandrader|afk is now known as dandrader | ||
| Saviq | karni, I knew it | 18:29 |
| Saviq | "summary": "summmary" | 18:29 |
| karni | Saviq: + huge 1 on newscopes-card-tool | 18:30 |
| Saviq | TOOMANYMs | 18:30 |
| karni | you're fking with me.. | 18:30 |
| Saviq | karni, 'fraid I'm not | 18:30 |
| Saviq | mhr3, ↑↑ | 18:30 |
| karni | ssweeny: ... ↑ | 18:30 |
| karni | ssweeny: you owe me a beer, and I owe myself a bitchslap for not noticing that. | 18:30 |
| karni | That's clear sign to EOW | 18:31 |
| Saviq | indeed | 18:31 |
| karni | Saviq: I won't comment on ETOOMANYMs :P | 18:31 |
| karni | Saviq: You've been great this week, thank you :) | 18:31 |
| Cimi | Saviq, I'm sure it works if we change height and not maximumLineCount | 18:31 |
| Saviq | Cimi, yes, but you can't know the correct height | 18:32 |
| Saviq | Cimi, well, there is one thing that can help | 18:32 |
| karni | I guess that's why I couldn't reproduce this problem, ssweeny. Because I CAN type "summary" :D hahahah And I'm blind. | 18:32 |
| Cimi | Saviq, lineCount * lineHeight? | 18:32 |
| Saviq | Cimi, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-text.html#onLineLaidOut-signal | 18:32 |
| mhr3 | karni, see, when i say NO WAY i mean no way :) | 18:32 |
| Cimi | sorry | 18:33 |
| Saviq | Cimi, you can do onLineLaidOut: and find out when the third line is laid out | 18:33 |
| Saviq | Cimi, and store that value in collapsedHeight | 18:33 |
| karni | mhr3: I couldn't believe myself. And I'm the one that can type "summary" correctly hahah | 18:33 |
| Cimi | Saviq, contentHeight? | 18:33 |
| karni | mhr3: Please, let's not get back to that ;D | 18:33 |
| Cimi | contentHeight is maximum | 18:33 |
| mhr3 | karni, it's eow i'll cut you some slack :P | 18:34 |
| Cimi | each line is contentHeight / lineCount | 18:34 |
| Saviq | Cimi, property real collapsedHeight; onLineLaidOut { if (line.number <=3) collapsedHeight = line.y + line.height } | 18:34 |
| Cimi | Saviq, I want to try with contentHeight | 18:34 |
| Saviq | Cimi, that would probably work, too, yah | 18:35 |
| Saviq | or close enough | 18:35 |
| Cimi | Saviq, tested, works well | 18:36 |
| Cimi | Saviq, will do the automatic appear/disappear of seeMore controls on monday | 18:36 |
| Saviq | karni, one last treat for this evening https://code.launchpad.net/~saviq/unity8/newscopes-new-dash-look/+merge/204322 | 18:48 |
| Saviq | karni, not really review-ready, but it's getting closer and closer | 18:48 |
| Saviq | karni, in scope-tool only, btw, actual shell/dash needs work | 18:51 |
| Saviq | aand EOW | 18:58 |
| Saviq | o/ | 18:58 |
| * greyback hitting EOW too, have a good weekend all | 18:58 | |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!