=== _salem is now known as salem_ === salem_ is now known as _salem [04:56] Saviq: I'm not using quilt, but maybe it works only when sources are in the same repo as packaging? === duflu_ is now known as duflu [08:00] Mirv, of course [08:45] Mirv, both branches linked to https://bugs.launchpad.net/unity-lens-applications/+bug/1271158 - if you need me to do anything else with them, pray tell :) [08:45] Ubuntu bug 1271158 in qtbase-opensource-src (Ubuntu) "Application Lens Icons are blurry, compared with home screen" [Undecided,In progress] [09:00] Saviq: thanks [09:00] I'll look at those [09:01] Mirv, you're in London, right? [09:10] Mirv, were you *still* or *already* up at 5am? ;) [09:15] dednick, hey, could I ask you to do https://code.launchpad.net/~saviq/unity8/add-doxygen/+merge/204123 [09:16] Saviq: sure [09:16] dednick, probably no need to read through the whole Doxyfile.in [09:16] dednick, but you might want to grep for @ and see if the substitutions make sense [09:17] dednick, hmm actually now that I think of it... [09:17] dednick, we probably shouldn't build the docs all the time [09:18] since it takes a few seconds [09:18] Saviq: yeah, i just saw that [09:18] let me tweak it a bit [09:18] graphvis can probably take a bit of time [09:19] or dot rather... [09:20] dednick, doxygen itself is enough [09:20] dednick, especially since it needs to pipe the qml through doxyqml, which is python [09:21] Saviq: but it needs to be built for packaging though... [09:21] dednick, yup, tweaking debian/rules to do that [09:21] ok [09:21] let's see if I did good [09:27] dednick, pushed [09:27] Saviq: ta [09:28] dednick, I just saw an issue - "/build/unity8-KAx5z5/unity8-7.84+14.04.20140129" got included in the paths, /me fixes [09:32] sil2100, automerger still ignoring that one branch... what's up with that? (https://code.launchpad.net/~marcustomlinson/unity-scopes-api/smartscopes_proxy/+merge/203943) [09:32] dednick, fixed [09:32] Saviq: haha. no, I'm in London only next week, not this week [09:32] Mirv, oh ok :) [09:32] Saviq: I expect to wake up at weird hours anyhow also next week, even if I wouldn't want to ;) [09:33] Mirv, 3h difference? [09:33] Saviq: I think only 2h. the thing is I also wake up locally at 6am normally because of the daily schedule [09:33] Mirv, right ;) [09:33] so it furthers the observed delta [09:34] Mirv, just go for drinks on Sunday, it'll help you accommodate :D [09:34] but in London the work begins at 9am (ie. 11am here) so it's 4h difference in practice [09:37] morning [09:37] hey ricmm [09:37] Saviq: so yea reading back I think daniel got the point [09:38] dednick, https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 another small one [09:38] some logic needs to happen in unity8 to setup the new ipc [09:38] and then plug that in p-api [09:38] seb128, could you do a quick checkup on packaging changes for: [09:38] https://code.launchpad.net/~saviq/unity8/add-doxygen/+merge/204123 [09:38] https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 [09:39] Saviq: ok [09:39] ricmm, what changed between then and now? why can't we use android's copypaste service? [09:39] android has no copy paste service [09:40] ClipboardService is an implementation in the android ubuntuappmanager [09:40] ricmm, ah! [09:40] as in, code we wrote [09:40] ricmm, that was the detail I was missing [09:40] that uses binder for ipc and manages all through the app manager [09:40] it would be the same thing to be fair [09:41] just that living in unity-mir somewhere [09:41] Cimi, forgot to put prerequisite on textSummary [09:41] Saviq, yeah!! [09:42] Saviq, done [09:43] Cimi, also, while you're at it... you could implement the See more | See less buttons there, and a "title" for it [09:43] Cimi, https://docs.google.com/a/canonical.com/file/d/0B-a_7E3tDxOgY2daVlFzaVB3ZFk/edit [09:43] Saviq, cool [09:43] Saviq, was bored of simply adding a label :) [09:43] Cimi, make the see more / see less a component [09:43] Cimi, we'll be using it in the dash as well [09:44] Saviq, ok [09:44] Cimi, I'm adding "title" to the text widget JSON [09:44] Cimi, I'd say optional [09:44] Cimi, so hide if empty [09:44] Saviq, so textSummary needs what? [09:44] column of two labels [09:45] plus see more/less [09:45] ? [09:45] Cimi, yes, and it needs to accept a modelData object for its data, not text directly [09:46] Saviq, but no array [09:46] Cimi, no, a single value, yes [09:46] Saviq, var modelData then? [09:46] Cimi, yeah, or so [09:46] Cimi, make it an interface, btw [09:46] Cimi, so PreviewWidget { property var data } [09:47] Cimi, or so [09:47] Cimi, and base all of the preview widgets off of that [09:47] adding an interface to all widgets you mean [09:47] ok [09:47] Cimi, yup, the only common prop between widgets will be data, I'd say [09:47] Cimi, also, use Text.Wrap [09:47] Saviq, any chance to try to hookup the new previews today? [09:48] although we landed columns api, should change the models to support it [09:48] mhr3, I'd rather have at least one widget first ;) [09:48] yea, that would help i guess :) [09:48] Cimi, otherwise long words will overflow / get clipped [09:49] mhr3, so Monday? I reworked a few things with the Card (+CardTool), so carousel will work now [09:50] meaning when I complete the tests and merge it ;) [09:50] and will make sure today grid is centered [09:50] Saviq, k, re columns, i'll make scope.preview() return a master preview model that will have columns role which will have per-column widget models [09:51] widget model* [09:51] mhr3, yup, sounds good [09:51] mhr3, so we'll wrap it in a stack of previews later? [09:51] Saviq, activations and stuff will go to the master object though [09:51] mhr3, fine [09:51] Saviq, still not sure where to put the stack [09:52] mhr3, mhm [09:52] Saviq, i guess the master will emit a signal when it gets a nested child [09:52] s/nested/stacked/ [09:52] mhr3, mhm [09:53] so don't think we really need to expose the entire stack to the shell [09:53] always just the active one [09:54] but maybe you don't think so? :) [09:55] mhr3, well, I don't want to destroy the inactive one [09:55] mhr3, since there can be data the user entered [09:55] true [09:55] mhr3, and they expect it there when, went "back" from the stacked one [09:57] i just find the model hierarchy pretty complex already, but well [09:57] mhr3, well, it's modeling a complex thing, so... [10:00] Saviq, ok, so scope.preview() returns PreviewStack, that contains PreviewModel, which has columns and those have PreviewWidgetModel which finally has the individual widgets [10:00] mhr3: give me a moment and I'll check [10:05] Saviq: is unity8.shell.tests.test_system_integration.SystemIntegrationTests.test_networkmanager_integration a known failure at the mo? [10:08] Saviq: http://pastebin.ubuntu.com/6848599/ [10:08] dednick, https://code.launchpad.net/~mterry/unity8/disable-nm-test/+merge/203980 [10:09] Saviq: that was just using dpkg-buildpackage [10:09] dednick, uh, what that... [10:10] :/ it was second time was building. maybe not cleaned? [10:10] Saviq: if there's been any chages to card-tool brach, push 'em up please, reading now :) [10:11] karni, no, not yet [10:11] dednick, semop is "systemv semaphore operations"... [10:11] Saviq: hm. i had to ctrl-C out. build got stuck. [10:11] dednick, try a clean one, or better yet - https://wiki.ubuntu.com/SimpleSbuild [10:12] dednick, it builds everywhere else, so... [10:13] ack [10:13] yay. an updated [possibly] not impossible to understand sbuild wiki! [10:14] dednick, oh, didn't you see it before? [10:14] Saviq, btw ok to push http://paste.ubuntu.com/6848630/ ? it doesn't exactly work, but makes it easier to fix :) [10:14] Saviq: only this on. https://wiki.ubuntu.com/SecurityTeam/BuildEnvironment [10:14] mhr3, fine [10:15] dednick, yeah, I extracted the info useful for the normal person in the SimpleSbuild one [10:16] :D [10:17] dednick, https://wiki.ubuntu.com/CrossBuilding some info about cross-building here, too [10:18] dednick, unity8 is cross-buildable through that [10:18] didrocks, maybe you could you do a quick checkup on packaging changes for: [10:18] https://code.launchpad.net/~saviq/unity8/add-doxygen/+merge/204123 [10:18] https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 [10:18] Saviq: ta [10:19] Saviq, just gave a +1 to the first one [10:20] Saviq, I'm unsure about the second one, maybe ping Mirv? (did that package got renamed in 5.2?) [10:20] Saviq, well unsure in the sense of "I don't know why you have the alternative name, I didn't follow the qt packaging enough to say if that's correct" [10:21] seb128, see http://packages.ubuntu.com/saucy/qtdeclarative5-private-dev vs. http://packages.ubuntu.com/trusty/qtdeclarative5-private-dev [10:21] seb128, qtdeclarative5-private-dev in trusty depends on libqt5v8-5-private-dev [10:22] seb128, and libqt5v8-5-private-dev doesn't exist for qt >= 5.2, it's "built into" qtdeclarative5-private-dev [10:22] Saviq, ok, thanks for the pointer, makes sense now [10:22] Saviq, +1 that one as well [10:22] seb128, thanks [10:23] Saviq: dpkg not generating unity8-doc package [10:24] dednick, :/ [10:24] need dh_install rule as well for doc? [10:24] dednick, https://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2792/artifact/work/output/ [10:24] dednick, jenkins disagrees [10:24] dednick, building from the vcs linked previously? [10:24] dednick, you have the new .install? [10:24] Saviq: it's building, but not generating the package [10:25] Saviq: no, just using dpkg still. Working on sbuilder env now [10:26] seb128: yes Qt's V8 is no more, it's replaced by V4 insside qtdeclarative. [10:26] Saviq: hm, actually, it's not giving me autopilot either.... [10:26] Saviq: but, qtdeclarative5-private-dev 5.0.2 depends on libqt5v8-5-private-dev [10:26] nowadays, to avoid that need [10:26] Mirv, not in saucy [10:26] Mirv, that change is for saucy [10:26] Mirv, https://code.launchpad.net/~saviq/unity8/packaging-and-cleanup/+merge/203829 [10:26] dednick, seems like you don't build arch all packages? [10:27] Saviq: aha.. a stable release backport, no PPA usage? the SDK Release PPA has qtdeclarative for saucy too that has that. [10:27] seb128: er. dpkg-buildpackage -us -uc -B ? [10:27] dednick, drop -B [10:27] (and precise/quantal/raring) [10:27] -B not [10:27] hm [10:27] dednick, -B is the issue indeed [10:28] Saviq: https://launchpadlibrarian.net/159906274/qtdeclarative-opensource-src_5.0.2-6ubuntu4_5.0.2-6ubuntu5~saucy1~test1.diff.gz [10:28] ah, no arch-independant [10:28] Mirv, hmm we require the sdk ppa anyway, maybe that change isn't needed then [10:28] doh [10:28] 3rd times a charm! [10:28] Saviq: yes we require SDK PPA if it's about developers [10:29] Mirv, ok, /me undo's [10:29] thanks [10:29] Mirv, thanks for reviewing it ;-) [10:30] seb128, Mirv, done [10:32] Saviq: sorry, too many fuzz here [10:32] thanks seb128 for the review :) [10:32] didrocks, yw! [10:32] didrocks, no worries, got many eyes on it already :) [10:33] approved [10:33] Mirv, seb128, thanks! [10:33] dednick, pushed OPTIONAL for the install of doc, so that cmake doesn't complain if you didn't build it [10:40] Saviq, interface https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 [10:41] Cimi, 55 + model: data [10:41] Cimi, that's wrong [10:41] Cimi, you will get the whole object as described in the docs [10:41] Cimi, so you need data["tracks"] [10:41] damm [10:42] Cimi, also, be explicit - name the top level item [10:42] Cimi, and reference data by that name [10:42] root.data [10:42] ok [10:42] Cimi, yup, something like that [10:42] Saviq, data["tracks"] will contain the model then? [10:43] so I'll have to redo the mocks? [10:43] Cimi, yes [10:43] Cimi, well, not "redo", just wrap them in { "tracks": [] } [10:43] Saviq, got a link handy [10:43] of the json? [10:44] Cimi, https://docs.google.com/a/canonical.com/document/d/1NmiM4UCnJgf6IEawmfyTOHRNAA5ZGrqpyrPqPOibwc8/edit#heading=h.6fng39a8onr [10:44] Saviq: does doxygen not generate for the qml files? [10:44] dednick, it does, when they're documented [10:44] dednick, Carousel should be there [10:44] Saviq: ahh [10:44] dednick, I've hidden non-documented files, thought it didn't make sense otherwise [10:45] Cimi, 405 + audioPlayer.stop() I don't think that's needed - and if it would be, then it needs to be part of the interface [10:45] Cimi, or maybe not.. [10:45] Saviq, currently [10:45] Saviq, on current previews [10:45] Saviq, there's a stop when the preview isCurrent turns falser [10:46] Saviq: they're not listed under 'Files', only 'Classes' [10:46] Saviq, since this is no longer top level preview but a widget, thought of adding a function [10:47] dednick, yeah, that seems a limitation of doxyqml [10:48] dednick, or well, it doesn't add .cpp files either [10:48] dednick, I'll have a chat with agateau (maintainer of doxyqml) [10:48] Cimi, I'm just thinking what would be calling it [10:49] Saviq, the preview page [10:49] Saviq: approved. [10:49] Cimi, yeah, but that would basically mean that the preview should go away, so the player would get destroyed anyway [10:49] Saviq, do they go away? [10:49] Saviq, or they are listviews? [10:50] Cimi, there's only 3 in a ListVIew [10:50] Cimi, so if you move away by more than one [10:50] Cimi, it gets destroyed [10:50] Cimi, only use case I can think of is when you get a preview on top of your current one - but whether it should pause I'm not sure [10:50] Saviq, but you want to move one, not two [10:50] Saviq, you switch album [10:50] and it should stop [10:50] Cimi, yes, I know [10:51] Cimi, just wondering whether it should really get destroyed or not [10:51] Cimi, anyway, so let's say PreviewWidget gets a new property [10:51] Cimi, "focused" [10:51] ok [10:51] Cimi, and preview widgets react to that [10:54] sil2100, so what's the news on the branch? [10:54] sil2100, you gave us a silo and that mp would like to be landed [10:57] mhr3: ok, so I poked fginther about it, since it seems it's something stranger [10:57] mhr3: oh, and we just recently published some silo, right? [10:58] Saviq, data seems to cause troubles as a name [10:58] var name [10:58] can I change it to something else? [10:58] previewData ? [11:02] sil2100, mhall119, the MP is failing to merge because jenkins is complaining that it has an unapproved pre-requisite, but that's not the case (it's actually merged). Will need to dig more. [11:02] mhr3: ^ [11:02] ;) [11:02] fginther: thanks! [11:03] fginther, so i'll just remove the pre-req since it's merged [11:04] * mhr3 really wants it in [11:05] Cimi, right, of course [11:05] Cimi, widgetData [11:05] Cimi, "data" is an internal QML name [11:06] Cimi, sorry about that [11:07] mhr3, can I re-approve that MP? the last push to merge to trunk does not match the approved version. [11:08] fginther, i resubmitted it a minute ago [11:08] and approved [11:09] so should be good afaict [11:10] mhr3, ack. I'll watch it in case it doesn't start [11:15] Cimi, you could add some docs - we'll be generating them soon enough [11:15] Cimi, see http://bazaar.launchpad.net/~saviq/unity8/card-tool/revision/677 for an example === _salem is now known as salem_ === alan_g is now known as alan_g|dentist [11:27] /food [11:29] i think you client does not suppor that [11:29] *your [11:34] greyback, hey. it unity8 already using the mir socket and protocol as a general purpose mechanism to exchange information with apps (and vice versa)? [11:34] s/it/is [11:41] Saviq: FYI I'm on app/sdk sprint next week in Orlando, my presence may vary [11:57] karni, ok [11:57] karni, will you get us an updated look at your guys' priorities? [11:58] Saviq: just noticed something interesting on my phone. flashed trusty-proposed, added demo-stuff ppa, rebooted, still see old scopes [11:58] Saviq: yes, will do [11:58] karni, apt-cache policy unity8? [11:59] anpok, ;) [11:59] Saviq: looks correct http://paste.ubuntu.com/6849035/ [12:00] karni, no it doesn't, there's a newer unity8 from distro than there is from ppa [12:00] oh, indeed [12:01] didrocks, deps between landed packages not really handled? https://launchpad.net/~ci-train-ppa-service/+archive/landing-009/+packages [12:01] hrm [12:01] karni, probably because I didn't merge trunk into new-scopes [12:01] karni, pushed, kicking build now [12:02] Saviq: thank you, sir! [12:02] didrocks, what will i have to do once the dep pkg publishes? [12:04] mhr3, click "merge & clean" [12:05] mhr3, and for the deps, just click "retry this build" [12:05] mhr3, oh no you can't [12:05] didrocks, ↑ valid issue [12:05] yea, i can't [12:06] the good news is that the build today was about 20x faster than last time [12:07] mhr3: it's in dep wait [12:07] didrocks, yes, and the dep built now [12:07] mhr3: ah, you have to wait for a cronjob IIRC in launchpad [12:07] it's not triggered by signals) [12:07] but launchpad is handling that [12:07] didrocks, does that really work in ppas? [12:08] AFAIK, it does [12:08] didrocks, yeah, I've never seen "dependency wait" to switch to "needs build" by itself [12:09] let's see, then... [12:09] Saviq: just trying to understand unity-mir at the mo. how does mir know where to draw the surface? ie how does it know its position given a stage? Can't find unity telling it anywhere... [12:09] dednick, currently unity-mir has it hardcoded [12:09] Saviq: mhr3: you can ping wgrant about it (I'm ddosing on pings right now) [12:09] Saviq: ahh. i c. [12:09] ;D === MacSlow is now known as MacSlow|lunch [12:10] thought i was going a bit mad [12:10] didrocks, k [12:10] @unity: any branches you guys would like landed? There's five in queue currently [12:11] elopio, can you please fill checklist on https://code.launchpad.net/~elopio/unity8/generic_preview/+merge/202793 [12:11] mzanetti: did you take a look at https://code.launchpad.net/~nick-dedekind/unity8/plugin-qml/+merge/203810 ? [12:12] dednick, mzanetti's refusing to approve branches before CI goes green again ; [12:12] ;) [12:12] ahha. dang [12:12] then no, i guess [12:12] dednick, which it will with this lannding [12:12] Saviq: which row of landing spreadsheet where you referring to? [12:12] Saviq, no [12:13] * karni doesn't see unity8-fix-mascot in the sheet [12:13] karni, none, yet, just https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews [12:13] ah [12:13] dednick: I looked at it, but CI seems still red [12:13] cool [12:13] mzanetti: no worries, no rush on that one [12:16] sil2100, I can has silo for unity8? [12:17] Saviq: let me look at that [12:17] sil2100, thanks [12:18] karni, I'll have patched (blurriness) qtbase packages for you in a few minutes [12:18] Saviq: w00t! [12:23] karni, new unity8-newscopes built in demo-stuff for amd64/i386, soon there for armhf [12:23] Saviq: so, we have a limited number of silos right now, so it might take a while at most - we're trying to bump the number of silos anyway, but it's something not for today [12:23] Saviq: very neat, very neat :) [12:23] sil2100, so no spot for us yet? ;( [12:24] sil2100, 002, 007 and 010 look empty? are they queued for someone or waiting for cleanup? [12:24] sil2100, not complaining, just trying to get more data [12:27] thostr_, "When you allocate a silo just go ahead and hit build at the same time. Thanks!" delegating already, nice one! [12:28] Saviq: ? [12:29] Saviq: the comment. yes, I think that is a pattern we should apply [12:29] thostr_, indeed, no point in assigning a silo without building, agreed [12:29] Saviq: at least I started this and e.g. initiated bfillers requests, so when he starts his day he should have all his packages built [12:30] thostr_, yup [12:47] Saviq: so, I had a talk with Didier, and I would be grateful if you could wait with silo assignment for unity8 for now [12:48] Saviq: just a little bit ;) [12:49] sil2100, ok, can you let me know before you'd assign them in case we'd like another branch to get in? [12:49] Saviq: sure! [12:49] dednick, you have some time - merge the test fix and resubmit your branch with prerequisite if you want it in! ;D === dandrader is now known as dandrader|afk [12:56] aargh stupid optipng ;/ [12:57] Mirv, you really need to disable OPTIPNG for qt packages... it's a half hour already here that it's built and just mangling already-optimized pngs... [12:57] Mirv, or something... [12:58] * Saviq finds a way to disable optipng system-wide [12:59] Saviq: card-tool -- looking good :) let me know when you want further feedback/when it goes out of WIP [12:59] karni, yeah, I just need to add some tests, will happen soon (I hope) [13:00] very cool === alan_g|dentist is now known as alan_g|lunch [13:01] Saviq: it could be similarly temporarily disable to how I'm temporarily enabling debug options [13:02] Saviq: I know I've bookmarked your disabling trick _somewhere_ :) [13:02] Mirv, I just feel like it's wasting so much builders' time [13:02] Mirv, export NO_PKG_PNG_MANGLE=1 [13:02] export NO_PNG_PKG_MANGLE=1 [13:02] PKG_PNG vs. PNG_PKG :/ [13:05] sil2100, more train questions [13:05] Saviq: I already did: https://code.launchpad.net/~elopio/unity8/generic_preview/+merge/202793/comments/475007 [13:05] elopio, yeah, saw that [13:05] elopio, please put submitter checklists in description [13:05] elopio, reviewer in comments, as there may be more [13:05] elopio, I copied it already [13:05] Saviq: ok. Thanks. [13:06] sil2100, the build failed, do i need to check any of the options now when i try to rebuild? === dandrader|afk is now known as dandrader [13:10] Saviq, it's fine now https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 [13:11] Cimi, \brief not needed if only one line [13:11] ok [13:11] mhr3: no, you can specify what specific packages you want to rebuild but you don't have to [13:12] done [13:12] Cimi, no tests for subtitle, but otherwise looks good, I'll leave to Albert to review properly on Monday [13:12] Saviq, how can I test subtitle? [13:12] oh sorry [13:12] sil2100, well, i need to rebuild the one that succeeded cause that broke the one that failed :) [13:12] subtitle I think I tested it [13:13] Cimi, not there in mocks? [13:13] Cimi, wrong, it's there [13:13] Cimi, sorry, it's good [13:13] Saviq, time is not tested [13:13] Saviq, not sure how I can test it [13:13] Saviq, because it's processed [13:13] from seconds I have a string [13:13] Cimi, well, yeah, you should supply one value and check that the string is what you expect? [13:13] sil2100, so i just click the rebuild without checking any of the options? [13:14] Cimi, that's the easiest thing to test :) - input, output [13:14] Cimi, have a separate test function for it [13:14] Saviq, yes but that will mean adding an extra field to the mock [13:14] mhr3: yep :) [13:15] I wanted to keep the mock like the one it will receive [13:15] but I can do it [13:15] mhr3: it will then take all the components, fetch latest revisions of the branches and build [13:15] Cimi, wait [13:15] Cimi, no, no more fields in mocks, why would you need it there? [13:15] Saviq, I don't know wehre [13:15] if not there [13:15] it's the easiest... [13:15] Saviq: unity-scope-tool requires 14.04, right? [13:15] karni, should be fine in 13.10 [13:16] ack [13:16] Cimi, so well, I wouldn't have gone your route of just putting the model in _data [13:16] Cimi, but instead I'd go with three separate test functions for the three different models [13:16] Cimi, and then in _data() you put the expected values [13:16] Cimi, one of which would be the expected processed time [13:17] Cimi, but even now you can just add an array to {tag: "0 tracks", tracksModel: tracksModel0}, [13:17] I can add an array to _data for expected length in case [13:17] Cimi, yeah, it's a bit convoluted, but yeah [13:17] sil2100, can i make it build just one source pkg and the other later? [13:17] Cimi, and to really test the **it out of that function [13:18] sil2100, cause i know right now that the second one will fail until the first one doesn't build [13:18] Cimi, ah, take out the lengthToString() function from under the Repeatre [13:18] Cimi, have a separate _data() and test_ pair, put it in Audio for example - we only need one copy of that function [13:19] Cimi, then, have a separate _data() and test_ pair, findChild() the Audio component [13:19] Cimi, and just test what you get out when supplying undefined, 0, -1, 1, 60, 120, 3600, 7201 etc. [13:20] ok [13:20] so your _data() would look more or less: [13:21] [ { tag: "0", value: 0, result: "0:00" }, { tag: "-1", value: -1, result: undefined } ] or so [13:21] sure [13:27] https://code.launchpad.net/~saviq/unity8/card-tool/+merge/204093 ready for review [13:28] karni, actually let me do one more thing [13:29] karni, or well, a few more things... === alan_g|lunch is now known as alan_g [13:30] mhr3: Saviq: see, it retried automatically [13:31] didrocks, yeah, an hour - too long ;) [13:31] didrocks, we might need a button "retry builds" [13:31] Saviq: ack, ping me when ready :) [13:31] Saviq: or fix launchpad to get a quicker retry? [13:31] didrocks, or that ;) [13:32] in the archive, it's even based [13:32] not sure why the ppas can't [13:37] Saviq, removing rating-input::submit-icon per katie's comment [13:37] mhr3, ok [13:43] karni, ready [13:43] ack [13:44] Saviq: do you want to still own it, or pass to unity-team? [13:45] Doesn't matter for me, just a check. [13:45] karni, we only push as ~unity-team if we foresee someone else needing to commit to it [13:45] * karni nod [13:45] Saviq: neat way to OWN stuff ;) [13:47] karni, crap, it's 300MB of .debs for qtbase... [13:47] hahahhaha [13:48] * Saviq tests his pipe's upload capabilities [13:48] * karni chuckles [13:48] 1.2MB/s, it's fine ;P [13:48] :D [13:48] 3 minutes [13:51] Saviq: Just a thought, not for this MP - I think that referencing test cases by index (from the drop down component) is error prone. One has to keep in mind which case are you referencing. Adding a test case within (instead of at the end) would screw test suite beautifully. Maybe something we can get better one day? [13:51] Less things you keep in mind when coding = better code (well.. you get the point) [13:51] karni, we can probably id them by name instead of index somehow [13:51] karni, can definitely be improved [13:51] Saviq: yes, that's what I mean [13:51] * karni nods [13:53] Saviq: waiting for CI run [13:53] karni, yup [13:54] karni, http://people.canonical.com/~msawicz/qtbase_amd64.tar.xz [13:54] \o/ [13:54] * Saviq likes his pipe [13:54] karni, armhf is still in the works, optipng will probably take a while still :? [13:54] :) [13:56] we have more qml tests in unity8 now that employees in Canonical ;D [13:56] * Saviq likes :D [13:56] even if we did cross the magical 600 employees boundary [13:57] 611 today [13:57] Saviq: downloaded [13:57] Saviq: hahah [13:58] Saviq: wow, number of packages. do you remember which one contained the fix, or should I just install em all x)? === MacSlow|lunch is now known as MacSlow [14:00] karni, for i in $( dpkg -l `for i in *.deb; do echo $i | cut -d_ -f1; done` 2>/dev/null | grep 5.0.2 | cut -d' ' -f3 | cut -d':' -f1 ); do echo -n "$i*.deb "; done; echo [14:02] Saviq: I also like bash, but you just slaped the 'awesome' sticker on your 'already-awesome' perception from my POV haha [14:02] ;) [14:02] karni, thought you'd enjoy that [14:02] Saviq: btw that last echo was intentional or got trimmed? [14:03] oh yeah :) [14:03] karni, just so you don't end up with prompt at the end of the lsit [14:03] list [14:03] :D [14:05] * karni joined scope sync with Scott and Joe [14:06] sil2100, so, the prereq package re-built, how do i make retry building the second one? [14:06] sil2100, i don't have powers that be to see a "retry this build" for the ppa [14:10] mhr3: I'll try that, but it also happens automatically - just it probably takes some time ;/ [14:10] mhr3: we're thinking on how to deal with this [14:10] sil2100, not the same thing, the build failed, it isn't in dep wait [14:11] mhr3: ah, you mean, it failed and you just want to rebuild it? You can always do it from the Build job - just list the source package name you want to rebuild [14:12] sil2100, into the prepare-only? [14:13] mhr3: yes, it will then fetch all the merges related to that source and push them to the PPA again [14:13] sil2100, since the mps didn't change do i need "force-rebuild"? [14:14] mhr3: no, it's fine [14:14] ok, let's see what happens [14:14] At least in theory [14:14] ;) [14:27] Saviq: thostr_: Who would we need to talk to about porting news and weather scopes to the new server scope api? [14:28] Cc ssweeny [14:28] karni: lucio [14:28] ack, thank you thostr_ [14:28] karni: but hurry up he's only here today, then he goes on vacation [14:28] ouch [14:28] omw [14:32] @unity standup [14:32] mzanetti, already there [14:32] it should be possible to exclude people :) like @unity -dandrader :D [14:33] mzanetti: lol [14:33] like that'd work ;D [14:33] :D [14:33] greyback, standup [14:33] @greybackrocks [14:33] darn [14:40] Saviq, added tests [14:40] Cimi, o/ [14:40] elopio: what did you need help with? sorry, i missed your request. [14:41] dednick: qt5.2 errors. [14:41] elopio: in qmltests? [14:42] dednick: I'm just starting to look at them. https://bugs.launchpad.net/unity8/+bug/1274484 [14:42] Mirv reported 5 autopilot errors. I'll run the unit tests, and the autopilot tests and report some more detailed bugs. [14:43] Ubuntu bug 1274484 in Unity 8 "5 unity8 AP tests failing with Qt 5.2" [Critical,New] [14:43] Saviq: Card size was applied only to first card of the carousel. While I believe I do understand your branch well, I would not understand why card size would not apply to all carousel Cards before. [14:43] karni, because it was set wrong [14:44] karni, it needs to be "synced" between the delegates and the carousel itself [14:44] karni, so it got confused (chicken'n'egg issue) [14:44] Saviq: Well, I can't be happier than, can I! :) [14:45] karni, so yeah, I wanted to wait until this lands in trunk and merge into new-scopes and integrate CardTool into CardFilterGrid, CardCarousel and friends [14:45] Saviq: that's a blast! [14:45] karni, but might need to change the plans if we don't get a silo for a while still [14:45] * karni nods [14:46] * mzanetti goes away for an hour and a half [14:53] karni, top-ack? [14:53] sry [14:53] Saviq: done [14:53] thanks [14:53] yw! [14:55] dednick, can you please verify docs still work for you, and include qml sources now? [14:55] dednick, and re-approve to pick up the new rev [14:57] Saviq: sure. give me a few minutes [14:58] dednick, thanks [15:02] Saviq: CardFilterGrid works fine rendering wise, maybe we could prioritize integration of CardTool into CardCarousel (DashCarousel, or whichever would be appropriate)? [15:03] anyway, I'll try to work out the list of our needs asap, trying to multithread [15:03] karni, it's at the top of my prio [15:03] Saviq: <3 [15:03] karni, the next thing is to fix CardFilterGrid not being centered [15:03] * karni nods [15:03] :) [15:03] karni, I'll probably prepare a branch while we don't have cardtool in trunk [15:04] Saviq: cool, still works + qml is there. approved [15:04] Saviq: great :) [15:07] dednick, thanks === dandrader is now known as dandrader|lunch [15:11] karni, apparently forgot about carousel ;) [15:12] Saviq: excuse me? [15:12] karni, in CardTool [15:12] karni, no carousel ;) [15:12] d'uhhhhhh [15:12] xDD [15:12] I'm a terrible reviewer [15:13] Saviq: since it's write protected with ~saviq :D can you still push up a fix? [15:13] karni, sure, just cooking it up [15:13] phew [15:14] * karni reboot [15:32] Saviq: with all the work that you've put in, I'd really like to make it work here. I installed the packages your bash line returned, rebooted, mascot still blured. But don't let this take your focus away from CardTool related improvements! [15:33] karni, must be it's actually a different issue === dandrader|lunch is now known as dandrader [16:08] sil2100, FYI unity-mir waiting for a silo now, too [16:09] Saviq: ok, I guess soon we might figure out the regression and then we can resume normal landings [16:09] sil2100, yup, thanks [16:12] dednick, you around? [16:12] dednick, ah, here you are :) [16:23] karni, sorry for the delay, pushed card-tool [16:23] Saviq: np, compiling notes from a meeting I just had [16:25] sil2100: where I can see if you guys clicked the publish button? [16:25] sil2100: (except trying to see if the package is available via launchpad) [16:25] thostr_: it's usually saying then that it's migrating the package to the archive [16:26] sil2100: can you do that for some of the silos? [16:27] sil2100: seems like 5 silos are waiting for the publish button to be clicked? [16:27] thostr_: yes yes, we didn't publish them yet since we're trying to resolve a regression first [16:28] sil2100: ah, ok [16:38] Saviq: sorry, handling other stuff along ETOOLITTLEHANDS will get to your review asap [16:39] karni, no worries [16:40] mhr3, hmm I'm not getting results in new scopes, that expected? === greyback_ is now known as greyback|food [16:40] mhr3, and btw "restart scope-registry" just killed my session a second ago ;) [16:45] Saviq, how what why? [16:46] mhr3, not sure, but it happened [16:46] ⟫ restart scope-registry [16:46] restart: Connection was disconnected before a reply was received [16:46] mhr3, and my whole session went away [16:46] mhr3, but anyway, unimportant ;P [16:46] mhr3, no results in new scopes? [16:46] are you running a unity8 session? [16:47] Saviq, apt-cache policy libunity-scopes0 [16:47] mhr3, no, not unity8 session, 0.2.6+14.04.20140128-0ubuntu1 [16:48] ps aux | grep scoper [16:48] Saviq, upstart crash i guess? [16:48] mhr3, probably, yeah [16:48] mhr3, I do get the scope, but no results [16:48] mhr3, i.e. I get the header and the category [16:49] then you broke the renderer :) [16:49] cause no results = no category [16:49] mhr3, if someone broke it, it's you ;) [16:49] mhr3, I didn't push to new-scopes for a while [16:49] * Saviq tries again [16:49] karni, something along those lines lp:~saviq/unity8/newscopes-card-tool should improve grid and carousel [16:49] Saviq, i wanted to, but they don't want to publish the new versions :P [16:49] karni, but I've no results yet :/ [16:50] karni, caution recommended [16:50] Saviq: ack! will look asap, gotcha [16:50] mhr3, ok, results are back [16:51] Saviq, see, you just need to ping me, then it fixes itself :P [16:52] mhr3, and I did break the renderer indeed [16:52] ok /me goes for food now [16:52] lol [16:52] at least once i'm right :P [16:56] Saviq, http://paste.ubuntu.com/6850317/ [16:56] Saviq, component name is ugly :D [16:57] I called it SeeMore.qml === greyback|food is now known as greyback [17:02] karni, ok, fixed grid, it looks great now [17:02] Saviq: WOHOOO [17:02] karni, carousel needs tweaking, but it's ok, too [17:03] And I have some friggin broke news for you guys ;D You'll get a laugh. [17:03] * karni preps a paste [17:03] /food [17:05] mhr3: (Cc ssweeny) http://paste.ubuntu.com/6850362/ [17:05] Saviq: for your entertainment ↑ [17:06] Saviq: mhr3: ignore the mascot: art line, it was unrelated when I tested this [17:06] NO [17:06] WAY [17:06] I pushed the renderer.json to the phonee twice [17:06] mhr3: want a screenshot? hahaha. I'm serious, tho :| [17:07] * karni tries this trick with scope-onlinemusic hehe [17:07] i won't believe until i run that on my device before my very own eyes [17:07] eh, *in front of [17:08] mhr3: I'll ping you in a sec with a supposedly broken json file [17:12] karni, whoa [17:12] Trying to reproduce this on scope-onlinemusic [17:13] karni, I can has the whole renderer.json in both versions? [17:13] yes, in a sec [17:21] * karni takes time to reproduce this, I already said on another channel that's most ridiculous thing I ever said in programming [17:22] karni, fixed carousel [17:23] Saviq: you're amazing :) [17:23] Saviq, quick opinion on that component? ^ [17:24] Cimi, use AbstractButton instead of the custom MouseArea [17:24] Cimi, so AbstractButton { Label { } } [17:24] Saviq, but I'll have to use style [17:25] Cimi, AbstractButton is not visual [17:25] Saviq, abstract button already has text property [17:25] orly [17:25] and ion [17:25] icon [17:25] but doesn't draw anything for me [17:25] Cimi, yes, which is fine [17:26] Cimi, it implements the behavior of a button [17:26] Cimi, either way [17:27] Cimi, no need for enabled: ! [17:27] Saviq, it's to reduce mouse areas [17:27] Saviq: card-tool bzr pull -- branches diverged. you overwrote/uncommited something? [17:27] karni, newscopes-card-tool is on top of new-scopes [17:28] Cimi, yeah, but I'd rather eat that event and not react to it than to let it through [17:28] Cimi, and it doesn't "reduce" them in any meaningful way [17:28] Saviq, shall I really use abstract buttons? [17:28] Cimi, I'd go s/seeMoreEnabled/seeMore/ or even s/seeMoreEnabled/more/ [17:28] Cimi, your call [17:29] nope then [17:29] Cimi, other than that property name it looks fine [17:29] Cimi, and SeeMore.qml is fine with me [17:29] mhr3: hi! [17:30] Saviq, will add tests and push [17:30] Cimi, how about some behaviour on opacity? [17:30] mhr3: so, I published your changes and it seems I made a mess because of that [17:30] Saviq: I wanted to +1 last two commits at https://code.launchpad.net/~saviq/unity8/card-tool/+merge/204093 [17:30] sil2100, how so? [17:30] Saviq: should I be reviewing newscopes-card-tool instead.. ? [17:31] nvm, I'll just clean branch it [17:31] karni, no [17:31] karni, review on card-tool is good [17:31] karni, newscopes-card-tool is just prep for when card-tool gets into trunk [17:31] ack [17:31] karni, to actually use card-tool [17:31] mhr3: tell me, why are you directly depending on libunity-scopes0 in debian/control on one of the packages in unity-scopes-shell ? [17:31] karni, there's little on top of card-tool there [17:32] sil2100, cause the pkg isn't maintaining proper abi compability yet [17:32] mhr3: hm, what do you have in mind? [17:33] Saviq: +1 card-tool [17:33] karni, cool thanks [17:33] sil2100, it deps on libunity-scopes0, but that keeps changing its abi, so we need to specify exact version to not get into a state where the are installed, but incompatible [17:33] Saviq: thank you [17:34] Cimi, I'd go for Behavior on just one of those labels [17:34] Cimi, and then the other's opacity based on the first one [17:34] sil2100, like it just upgraded just unity-plugin-scopes without upgrading libunity-scopes [17:34] Cimi, so that they're always opposite, without the need for two Behaviors [17:35] sil2100, if you just upgraded...* [17:35] slangasek: ^ [17:35] slangasek: not sure if that's a proper reason, but I'm not sure how to resolve it in any other way then [17:36] sil2100: "keeps changing its ABI" - ok, for the record I will not sign off on any library being uploaded to the Ubuntu archive that changes ABI without *at minimum* changing its binary package name [17:37] I was aware that there were libraries currently being managed this way; this needs to stop [17:37] slangasek, and it will once we declare the library stable [17:37] I'm not going to block someone else signing off on it, but the currently-employed method also doesn't guarantee consistency [17:39] mhr3: I don't consider "once we declare the library stable" to be sufficient. These are baseline requirements for anything in the Ubuntu archive [17:42] the library is under heavy development and we're forced to keep pushing it in the archive [17:43] all its users are currently internal and they're well aware the api and abi unstable [17:43] yes, but your current declarations fail to actually enforce consistency [17:44] they only prevent the inconsistency in *one* direction but not the other [17:44] we could have just dropped it and noone would ever know [17:45] we chose to do at least one-way enforcing instead [17:45] Cimi, on that note, are you sure you should be using raised/black everywhere? [17:45] Cimi, I don't see that in the designs [17:45] Saviq, no [17:45] Saviq, will fix designs when we'll have something working [17:45] s/designs/implementations [17:46] Cimi, ok, drop the style at least, it's not there in the designs [17:46] ok [17:46] Cimi, and there's a separator you could add [17:46] Saviq, how? [17:46] Saviq, I thought about it [17:46] rectangle? [17:47] mhr3: it's absolutely not true that people wouldn't know. Playing fast and loose with ABI declarations significantly impedes the CI infrastructure being able to automatically land the right thing [17:47] Cimi, no, isn't it just a rotated ThinDivider? [17:47] dunno [17:48] Saviq: mhr3: For your entertainment, I can't get summary to show up on our custom scope at all (as opposed to sample "summary": "artist" mapping working just fine in scope-onlinemusic). I'll get back to you guys when I have less ridiculous news, I hope you enjoyed the read anyway ;) [17:49] Saviq: Would you like me to review anything else (carousel fix)? [17:50] slangasek, isn't this actually poor man's solution so that it actually does land the correct thing? [17:50] Saviq, tried with hebaviour [17:50] Saviq, doesn't look nice [17:51] Cimi, ok [17:51] karni, let me see if I can make this diff sane [17:51] :) [17:52] slangasek, eventually anyway :) [17:54] karni, https://code.launchpad.net/~saviq/unity8/newscopes-card-tool/+merge/204301 looks ok [17:54] karni, if you want a local diff, merge card-tool into new-scopes first [17:56] karni, you need to re-top-approve card-tool, 'cause it holds the old revision as approved [17:56] Saviq: done [17:57] karni, tx [17:59] ssweeny: This is comedy. I got the summary to appear, and now I can't get it to break. =_= [18:02] mhr3: why are we resorting to poor-man's solutions, which have failure scenarios that we can actually handle? [18:04] Saviq, any clever idea to animate maximumLineCount? [18:04] Cimi, clip + behaviour on height [18:05] Saviq, so I don't use it? [18:05] Cimi, you do [18:05] just when you change maximumLineCount [18:05] Cimi, height is behaviourized === dandrader is now known as dandrader|afk [18:05] slangasek, cause as you said, we're playing fast [18:06] Saviq, adding behaviour on height doesn't change anything === alan_g is now known as alan_g|EOW [18:09] * Saviq wants to get rid of DashRenderer so bad... [18:10] Saviq: I'll assign a silo for unity8 for you after I eat something and get to the hotel, ok? :) [18:10] sil2100, sure, no worries [18:15] Saviq, thank you [18:15] why is it so bad? :D [18:15] Cimi, so does it work or not? [18:15] Saviq, I was joking about dashrenderer [18:16] Saviq, no, the behaviour doesn't work [18:16] Cimi, because all the properties are going three ways [18:16] Cimi, you might need height: implicitHeight, although that'd be weird [18:16] Saviq, height changes [18:16] Saviq, but it doesn't animate [18:19] mmm [18:19] this component requires a bit more work [18:19] cannot finish it today [18:20] it has to show SeeMore depending on the number or lines of text displayed [18:20] I guess I'll do this monday [18:20] :P [18:22] Saviq, I can use height+clip instead of maximumLineHeight [18:22] Saviq: mhr3: ssweeny: Sent you good and bad json renderer files, with more details, and debs to try. [18:23] ssweeny: With that said, you should be able to make screenshots today. [18:23] Cimi, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-text.html#lineCount-prop [18:23] Saviq, I know this [18:23] Saviq, but height is fine [18:24] Saviq, if description is taller than X height [18:24] Saviq, I add seeMore that clips to X [18:24] otherwise I don't set height [18:24] Cimi, yeah, but that won't clip at line boundary [18:24] or just set it to lineHeight*lineCOunt [18:25] Saviq, I'll clip it smart [18:25] Cimi, whenever you think about calculating something based on lineHeight, stop ;) [18:25] Saviq, we could potentially fade with a gradient on last line [18:25] Cimi, http://paste.ubuntu.com/6850737/ *almost* works [18:26] Cimi, I forgot what I did to delay the clipping of text [18:26] Cimi, but I did it somewhere already [18:27] Cimi, if all else fails - ShaderEffect { live: false }... === dandrader|afk is now known as dandrader [18:29] karni, I knew it [18:29] "summary": "summmary" [18:30] Saviq: + huge 1 on newscopes-card-tool [18:30] TOOMANYMs [18:30] you're fking with me.. [18:30] karni, 'fraid I'm not [18:30] mhr3, ↑↑ [18:30] ssweeny: ... ↑ [18:30] ssweeny: you owe me a beer, and I owe myself a bitchslap for not noticing that. [18:31] That's clear sign to EOW [18:31] indeed [18:31] Saviq: I won't comment on ETOOMANYMs :P [18:31] Saviq: You've been great this week, thank you :) [18:31] Saviq, I'm sure it works if we change height and not maximumLineCount [18:32] Cimi, yes, but you can't know the correct height [18:32] Cimi, well, there is one thing that can help [18:32] I guess that's why I couldn't reproduce this problem, ssweeny. Because I CAN type "summary" :D hahahah And I'm blind. [18:32] Saviq, lineCount * lineHeight? [18:32] Cimi, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-text.html#onLineLaidOut-signal [18:32] karni, see, when i say NO WAY i mean no way :) [18:33] sorry [18:33] Cimi, you can do onLineLaidOut: and find out when the third line is laid out [18:33] Cimi, and store that value in collapsedHeight [18:33] mhr3: I couldn't believe myself. And I'm the one that can type "summary" correctly hahah [18:33] Saviq, contentHeight? [18:33] mhr3: Please, let's not get back to that ;D [18:33] contentHeight is maximum [18:34] karni, it's eow i'll cut you some slack :P [18:34] each line is contentHeight / lineCount [18:34] Cimi, property real collapsedHeight; onLineLaidOut { if (line.number <=3) collapsedHeight = line.y + line.height } [18:34] Saviq, I want to try with contentHeight [18:35] Cimi, that would probably work, too, yah [18:35] or close enough [18:36] Saviq, tested, works well [18:36] Saviq, will do the automatic appear/disappear of seeMore controls on monday [18:48] karni, one last treat for this evening https://code.launchpad.net/~saviq/unity8/newscopes-new-dash-look/+merge/204322 [18:48] karni, not really review-ready, but it's getting closer and closer [18:51] karni, in scope-tool only, btw, actual shell/dash needs work [18:58] aand EOW [18:58] o/ [18:58] * greyback hitting EOW too, have a good weekend all === salem_ is now known as _salem === _salem is now known as salem_ === salem_ is now known as _salem