| === RAOF_ is now known as RAOF | ||
| tsdgeos | Saviq: so it was me that broke the previews right? | 08:06 |
|---|---|---|
| Saviq | tsdgeos, not really, it only ever worked by sheer luck | 08:06 |
| tsdgeos | i see | 08:07 |
| Saviq | tsdgeos, when app installed → scope would signal result invalidation, as well as send a new preview for the, now installed, app | 08:07 |
| tsdgeos | but probably my refactoring broke it? | 08:07 |
| tsdgeos | i mean there's not much more that would touch previews and such | 08:07 |
| Saviq | tsdgeos, yeah it surfaced it | 08:07 |
| Saviq | tsdgeos, so before, somehow, the results did not get reset for the previewListView, and it would not reset | 08:08 |
| Saviq | tsdgeos, or they did reset later | 08:08 |
| Saviq | tsdgeos, so when bringing in the new preview, currentIndex was already -1 | 08:08 |
| Saviq | tsdgeos, as opposed to the real, currently selected one, 'cause the model for it was reset in the mean time | 08:09 |
| Saviq | tsdgeos, anyway: https://code.launchpad.net/~saviq/unity8/fix-preview-updates/+merge/204559 | 08:14 |
| Saviq | tsdgeos, if you could get it to Approved (mterry waited for -ci run that was late) | 08:14 |
| tsdgeos | will do | 08:14 |
| Saviq | tsdgeos, thanks | 08:15 |
| === Wellark__ is now known as Wellark | ||
| tsdgeos | Saviq: can you explain what the "onPreviewDataChanged: showProcessingAction = false" does? | 08:39 |
| Saviq | tsdgeos, DashPreview.qml, at the bottom | 08:40 |
| Saviq | tsdgeos, there's a MouseArea that eats input after you have triggered an action | 08:40 |
| Saviq | tsdgeos, but it needs to be disabled when new previewData comes, as that action was executed, then | 08:41 |
| tsdgeos | ok, makes sense | 08:41 |
| Saviq | tsdgeos, again, TBH not sure how this could have worked before... | 08:41 |
| Saviq | tsdgeos, most probably the PreviewListView did get reset, but somehow managed to maintain the currentIndex | 08:41 |
| === asac` is now known as asac | ||
| mhr3 | Saviq, why did we loose 7.85 from new-scopes? | 09:00 |
| Saviq | mhr3, not sure what you mean? the version number? | 09:01 |
| Saviq | mhr3, probably because I cleaned up the recipes | 09:01 |
| tsdgeos | Saviq: is there any chance we get the netowkrmanager tests fix in? bug1271676 seems to be something MWC people want to see fixed asap and without the tests fixed mzanetti is abstaniing from reviewing it, so it's all a bit of urgent | 09:01 |
| mhr3 | Saviq, yep, the version in the ppa is now lower than distro | 09:01 |
| Saviq | bug #1271676 | 09:01 |
| ubot5 | bug 1271676 in Unity 8 "Launching an app from the app scope causes app scope to jump to the top" [High,In progress] https://launchpad.net/bugs/1271676 | 09:01 |
| mhr3 | which sucks | 09:01 |
| Saviq | mhr3, not because we lost 7.85 | 09:01 |
| Saviq | mhr3, but because there was a revert of unity8 yesterday | 09:02 |
| Saviq | mhr3, should be sorted today | 09:02 |
| Saviq | tsdgeos, it's waiting in the queue, will be released today with the fix for the previes | 09:02 |
| Saviq | previews | 09:02 |
| Saviq | tsdgeos, they won't get a fix for it if we don't release at all, either, so it just needs to run its course | 09:03 |
| tsdgeos | ok | 09:04 |
| Saviq | tsdgeos, what I mean is even if we got it in trunk any other way, if we don't release, it won't be there for the image | 09:04 |
| tsdgeos | sure | 09:04 |
| Saviq | tsdgeos, so we just need to be able to release again | 09:05 |
| Saviq | sil2100, didrocks, FWIW unity8 fix is in CITrain, waiting for a silo | 09:17 |
| didrocks | Saviq: excellent, thanks! can I ask you a favor? | 09:17 |
| Saviq | didrocks, one more!? ;P | 09:17 |
| didrocks | hehe, indeed | 09:17 |
| didrocks | we try to see if we can promote the current image | 09:17 |
| didrocks | (well 161, it's the one we have whole test results) | 09:18 |
| didrocks | there is on unity8 failure | 09:18 |
| didrocks | one* | 09:18 |
| didrocks | on both mako and maguro | 09:18 |
| * sil2100 is flashing 161 just now | 09:18 | |
| didrocks | + 162 fails the same on mako | 09:18 |
| sil2100 | *162 | 09:18 |
| sil2100 | ;) | 09:18 |
| Saviq | didrocks, upgrade unity-notifications | 09:18 |
| didrocks | Saviq: so, if we promote the current image | 09:18 |
| Saviq | didrocks, it's because of the unity8 rollback | 09:18 |
| didrocks | that will be broken? | 09:18 |
| Saviq | didrocks, just the test | 09:19 |
| didrocks | what will be broken exactly | 09:19 |
| didrocks | hum | 09:19 |
| didrocks | are you 101% sure? :) | 09:19 |
| didrocks | if so, I'm happy to promote :p | 09:19 |
| sil2100 | :D | 09:19 |
| didrocks | (well, considering for promotion) | 09:19 |
| Saviq | didrocks, yes, I am | 09:19 |
| didrocks | Saviq: trusting you then! thanks a lot | 09:19 |
| * didrocks hugs Saviq | 09:19 | |
| * didrocks is a lot happier :p | 09:19 | |
| sil2100 | Phew! | 09:19 |
| sil2100 | \o/ | 09:19 |
| Saviq | didrocks, https://code.launchpad.net/~macslow/unity8/unity8.fix-test_sd_incoming_call/+merge/203567 | 09:20 |
| Saviq | didrocks, that commit fixed the test, but was backed out yesterday | 09:20 |
| Saviq | /bbiab | 09:22 |
| didrocks | Saviq: perfect! I wasn't even asking you for the commit to prove it's only a test change without any effect on runtime, I trust you enough to take your words :) | 09:22 |
| didrocks | Saviq: ok, sounding good for the image, we are doing dogfooding | 10:09 |
| didrocks | as no QA around | 10:09 |
| didrocks | and sounds we can promote | 10:09 |
| didrocks | then, we'll just add your unity8 fix as a priority reland | 10:09 |
| didrocks | (we prioritize the reverted components first) | 10:09 |
| dednick | stupid irc... | 10:15 |
| Saviq | dednick, freenode is bitchy today | 10:18 |
| dednick | Saviq: just had to change from irc.freenode.net to chat.freenode.net and seems to work now. | 10:19 |
| Saviq | didrocks, sure, will we land all that's in queue or would you want to land just the fix? | 10:19 |
| didrocks | Saviq: as you prefer, if you land everything, you are taking more risk I would say | 10:26 |
| tsdgeos | greyback: ping | 10:29 |
| greyback | tsdgeos: pong | 10:30 |
| tsdgeos | greyback: i'm trying your "do not draw branch" | 10:30 |
| tsdgeos | and i can't see the difference | 10:30 |
| tsdgeos | am i supposed to see less " Breakdown of frame time;" calls | 10:31 |
| tsdgeos | or shorter ones? | 10:31 |
| greyback | tsdgeos: much less calls | 10:31 |
| tsdgeos | also on desktop? | 10:31 |
| greyback | tsdgeos: probably not as noticeable, since the lenses are already loaded on desktop when you start unity8.. But on device, it's very noticeable | 10:32 |
| tsdgeos | i'm actually getting more calls on the desktop :D | 10:33 |
| tsdgeos | 126 vs 117 | 10:33 |
| tsdgeos | let me see the phone | 10:33 |
| Saviq | didrocks, not with the set of changes we have there, most are not even in use currently (prep for new scopes) | 10:34 |
| tsdgeos | greyback: how did you test it on the phone? i.e. which modification you did to run_on_device? | 10:40 |
| tsdgeos | it seems i'm not passing the envvar correctly | 10:40 |
| tsdgeos | did you run manually without using run_on_device? | 10:40 |
| * tsdgeos tries that | 10:40 | |
| greyback | tsdgeos: manual run | 10:41 |
| tsdgeos | greyback: manual run gives me 345 vs 316 | 10:44 |
| tsdgeos | is that something like you were getting? | 10:44 |
| Saviq | mzanetti, yay | 10:45 |
| mzanetti | Saviq: no... no yay | 10:46 |
| Saviq | mzanetti, ? | 10:46 |
| mzanetti | Saviq: znc still won't connect | 10:46 |
| Saviq | mzanetti, well, at least you connected | 10:46 |
| mzanetti | (connectes fine to canonical's server tho) | 10:46 |
| Saviq | mzanetti, got a znc account ready for you here if you'd want one | 10:46 |
| mzanetti | well... that's not really the solution | 10:46 |
| mzanetti | but thanks for the offer | 10:46 |
| Saviq | mzanetti, I know, that's why I said "if you'd want one" | 10:46 |
| mzanetti | interestingly I get Connection refused now instead of timeouts | 10:47 |
| greyback | tsdgeos: I wasn't counting, but the difference was noticeable | 10:50 |
| tsdgeos | i see | 10:50 |
| greyback | tsdgeos: I'm not unlocking, I just start unity8 and watch | 10:50 |
| tsdgeos | ok | 10:55 |
| tsdgeos | greyback: nexus4? | 11:03 |
| greyback | tsdgeos: nexus10 I tested on | 11:03 |
| tsdgeos | this is weeeeird | 11:05 |
| tsdgeos | i added | 11:05 |
| tsdgeos | onFullyCoveredChanged: console.log("MOOOOOOOOOOOOO", fullyCovered) | 11:05 |
| tsdgeos | and it never shows anything ?¿ | 11:06 |
| tsdgeos | greyback: my greeter does not have a fullyshown property ?¿ :S | 11:09 |
| greyback | tsdgeos: "fullyShown" ? | 11:10 |
| tsdgeos | i added this | 11:10 |
| tsdgeos | Component.onCompleted: console.log("BAAAAAAAAAAAAAA", fullyCovered, gree | 11:10 |
| tsdgeos | ter, greeter.fullyShown) | 11:10 |
| tsdgeos | and i get | 11:10 |
| tsdgeos | BAAAAAAAAAAAAAA false Greeter_QMLTYPE_97_QML_209(0x47becd38, "greeter") undefined | 11:10 |
| tsdgeos | and grepping i don't see how it can be defined for you | 11:11 |
| tsdgeos | seems fullyShown is only there for stages | 11:11 |
| tsdgeos | which the greeter is not one | 11:11 |
| greyback | tsdgeos: damn, I swore that fullyShown was part of Showable. I must be wrong | 11:15 |
| tsdgeos | i can be wrong too, has happened before you know ;-) | 11:17 |
| greyback | tsdgeos: well reading the code, I think you're correct. I'm more confused about what I was finding last night... | 11:18 |
| tsdgeos | mhr3_: pstolowski: Saviq: what am i supposed to do with the "id" field of a type: "actions"? | 12:13 |
| mhr3_ | tsdgeos, it's just an id picked by the scope | 12:14 |
| mhr3_ | tsdgeos, perhaps set objectName to it? | 12:15 |
| pstolowski | tsdgeos, activation api expected id of a button back; it will also expect that actions id (not yet in the api) | 12:16 |
| tsdgeos | so i'll have to call something back | 12:17 |
| tsdgeos | ok | 12:17 |
| tsdgeos | but that doesn't exist yet | 12:17 |
| Saviq | tsdgeos, yeah | 12:17 |
| pstolowski | tsdgeos, it exists, but takes just one id (button); it will be enhanced with one more id | 12:17 |
| pstolowski | (actions) | 12:18 |
| Saviq | pstolowski, why? do we want to support non-unique action IDs for some reason? | 12:18 |
| tsdgeos | mhr3_: pstolowski: Saviq: also can you confirm that one type: "actions" with two elements in the "actions" array is a combo with two entries and not two buttons? | 12:18 |
| tsdgeos | i.e. if you want two buttons you need two type "actions" elements? | 12:19 |
| Saviq | tsdgeos, confirmed | 12:19 |
| mhr3_ | Saviq, widget_id + action_id | 12:20 |
| Saviq | mhr3_, yeah, why? shouldn't action_id be unique already? | 12:20 |
| mhr3_ | there's nothing forcing it to be unique | 12:20 |
| pstolowski | Saviq, to be on safe side? otherwise yes, they would need to be globally unique | 12:20 |
| Saviq | mhr3_, there's nothing forcing widget_id + action_id to be unique, either | 12:21 |
| Saviq | mhr3_, pstolowski, I'd go for requiring unique action_id, TBH... | 12:21 |
| mhr3_ | Saviq, we won't allow pushing widgets with the same id twice | 12:21 |
| Saviq | mhr3_, will you check action_id for uniqueness? | 12:22 |
| mhr3_ | we could within a widget | 12:23 |
| === Trevinho_ is now known as Trevinho | ||
| pstolowski | Saviq, mhr3_ no strong opinion, just a feeling that perhaps widget_id + action_id is more future-proof... | 12:28 |
| Saviq | mhr3_, pstolowski, I don't really care, feels overkill to me, though | 12:29 |
| === alan_g is now known as alan_g|lunch | ||
| tsdgeos | Cimi: where's the comment you mention in https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 ? | 12:29 |
| Cimi | tsdgeos, it should be there, no? | 12:31 |
| tsdgeos | don't see it | 12:31 |
| tsdgeos | ah | 12:32 |
| tsdgeos | see it now | 12:32 |
| tsdgeos | Cimi: it still has the urls that seem real | 12:33 |
| tsdgeos | Cimi: and the stop for the audioplayer | 12:33 |
| mhr3_ | Saviq, i agree with pstolowski, more future-proof | 12:39 |
| tsdgeos | Saviq: so on the actions thing, how do you think we should expose the "signal" of it being pressed or the combobox changing, add a signal to the base PreviewWidget? | 12:43 |
| === cimi4 is now known as CImi3 | ||
| Saviq | tsdgeos, I think so, yes, more widgets will actually trigger actions | 12:44 |
| Saviq | tsdgeos, (like the progress widget, the review-input one) | 12:44 |
| Saviq | mhr3_, pstolowski, do we have ideas on how will we pass data back with the action? think a single QVariantHash arg would be ok? | 12:45 |
| === MacSlow is now known as MacSlow|lunch | ||
| mhr3_ | Saviq, yep | 12:46 |
| mhr3_ | i mean... widget_id + action_id + variantmap | 12:46 |
| Saviq | tsdgeos, so the signal signature would be: (string widgetId, string actionId, var data) | 12:46 |
| tsdgeos | Saviq: "activate"? "activated"? | 12:47 |
| pstolowski | Saviq yeah, as mhr3_ said | 12:47 |
| Saviq | tsdgeos, the Qt way - activated, or triggered, maybe? | 12:48 |
| Cimi | tsdgeos, please decide the name of the property :) | 12:48 |
| Cimi | tsdgeos, for focused | 12:48 |
| tsdgeos | triggered sounds ok | 12:48 |
| tsdgeos | Cimi: as the comment says, i am not sure we even need a name | 12:49 |
| tsdgeos | Cimi: why can't you use visible? | 12:49 |
| Saviq | tsdgeos, because the preview might still be visible, but no longer focused | 12:49 |
| Saviq | tsdgeos, when you're switching previews, for example | 12:50 |
| tsdgeos | Saviq: but you said we're killing the switching of previews | 12:50 |
| Saviq | tsdgeos, no no no | 12:50 |
| Saviq | tsdgeos, we're killing the bottom "see-through" | 12:50 |
| tsdgeos | ah | 12:50 |
| tsdgeos | ok | 12:50 |
| Saviq | tsdgeos, you will still be able to swipe between them | 12:50 |
| Saviq | /food | 12:51 |
| tsdgeos | Cimi: isCurrent then, focused is too close to focus to me | 12:51 |
| Cimi | mzanetti, why we have on the music preview | 12:51 |
| tsdgeos | or maybe Saviq has a better suggestion for it | 12:51 |
| Cimi | mzanetti, to stop audio on destruction? | 12:51 |
| mzanetti | Cimi: why not? | 12:51 |
| Cimi | mzanetti, isn't automatic? | 12:52 |
| mzanetti | hmm... probably not, otherwise it wouldn't be there I'd say | 12:52 |
| mzanetti | need to check the code. one minute | 12:53 |
| Saviq | tsdgeos, fine by me, it should actually be previewFocused / isCurrentPreview or something | 12:53 |
| Saviq | tsdgeos, as it's not about the widget being current / focused, but the whole preview | 12:53 |
| tsdgeos | Saviq: right, which also shows we're having too many properties in every widget instead of a "global" one per preview, but that's the price you pay for decoupling :D | 12:57 |
| tsdgeos | food! | 12:57 |
| Saviq | tsdgeos, well, sure, if we put it all in one .qml, we wouldn't need it indeed | 12:57 |
| mzanetti | Cimi: right... might actually be a bug in the qtmultimedia backend | 12:57 |
| mzanetti | Cimi: 'cause the playback is handled by the media service | 12:58 |
| mzanetti | Cimi: so destructing it should implicitly send a stop to the media service, probably it doesn't | 12:58 |
| mzanetti | Cimi: I remember having talked to jhodapp about this when implementing it | 12:58 |
| karni | Hi guys | 13:10 |
| karni | Saviq: would you like me to add tests for title alignment, or is this "look and feel" like you considered something a while back? | 13:11 |
| karni | I rebased it on the branch you mentioned | 13:12 |
| karni | lp:~unity-team/unity8/new-scopes-title-alignment | 13:12 |
| Cimi | tsdgeos, ^ | 13:14 |
| karni | dang, I should have added a prerequisite branch | 13:15 |
| Saviq | karni, test for CardTool, yeah | 13:15 |
| Saviq | karni, should be a simple one, too | 13:15 |
| karni | Saviq: ignore that MP for now | 13:15 |
| karni | I think my bzr config went haywire, changed username | 13:16 |
| Saviq | karni, no need to reject all the MPs, just make them WIP and resubmit then if needed | 13:16 |
| === dandrader is now known as dandrader|afk | ||
| karni | Saviq: ack | 13:16 |
| * karni moves to different building | 13:16 | |
| Saviq | tsdgeos, if we could do attached props in QML, that'd help some | 13:19 |
| Saviq | mhr3_, pstolowski, how do we communicate the number of columns for a preview? | 13:20 |
| mhr3_ | Saviq, working on that, but it'll be a prop on the PreviewStack object you get from scope.preview() | 13:21 |
| mhr3_ | Q_PROPERTY(int widgetColumnCount READ widgetColumnCount WRITE setWidgetColumnCount NOTIFY widgetColumnCountChanged) | 13:23 |
| mhr3_ | good enough? | 13:23 |
| Saviq | mhr3_, how do we do the splitting in case the scope didn't define it? | 13:23 |
| mhr3_ | Saviq, that is a good question | 13:23 |
| mhr3_ | ideas? | 13:24 |
| mzanetti | anpok: hey, saw your comment on the bug. what exactly does it mean? i.e. where does the 16ms value come from? | 13:24 |
| mhr3_ | Saviq, doesn't help that the scope can keep pushing more widgets any time it wants | 13:25 |
| Saviq | mhr3_, indeed | 13:25 |
| sil2100 | Saviq: hm, you mentioned there's a landing plan for the Unity8 regression fix? | 13:25 |
| mhr3_ | Saviq, i'm leaning to doing something stupid... 1 widget per column, everything else into last col | 13:25 |
| Saviq | sil2100, yup, waiting for silo | 13:25 |
| Saviq | sil2100, row 20 I think | 13:25 |
| Saviq | mhr3_, I have two ideas: a) you expose all configured models at the same time as an array, and when there isn't one that matches the current setup, shell takes over and does its thing | 13:26 |
| sil2100 | Saviq: oh, hm, I think we cannot re-use already Landed silos | 13:26 |
| Saviq | sil2100, meant row 40, sorry | 13:26 |
| sil2100 | Saviq: can you just slap the MR to a new row? Since I don't even know whic MR it is | 13:26 |
| Saviq | sil2100, I'd rather land it all together, don't want to waste time on separate regression fix and actual code that's waiting for almost a week now :/ | 13:27 |
| Saviq | mhr3_, b) you call into the shell when receiving a preview (and/or subsequent preview widgets) and the shell comes back with lists split into columns | 13:28 |
| Saviq | mhr3_, b) is ~same idea as plugin calling into shell to potentially apply any rules / changes on template / components | 13:29 |
| sil2100 | Saviq: ok, just remember that if we find a regression again by accident (;p) we'll revert everything again ;p | 13:29 |
| Saviq | sil2100, I'm fine with that | 13:29 |
| sil2100 | Saviq: but if you're ok with that risk then I prepare stuff for it | 13:29 |
| Saviq | sil2100, I'm completely ok with you guys reverting us if there's a regression identified | 13:29 |
| === popey_ is now known as popey | ||
| mhr3_ | Saviq, i don't like either :) | 13:29 |
| Saviq | mhr3_, other (better) ideas? | 13:30 |
| === dandrader|afk is now known as dandrader | ||
| mhr3_ | Saviq, i'm leaning to forcing scope devs to provide the layouts, so if a scope wouldn't specify a layout, shell would display everything in one col | 13:35 |
| === alan_g|lunch is now known as alan_g | ||
| sil2100 | Saviq: silo assigned! It's getting prepared this instance | 13:36 |
| Saviq | mhr3_, future-proof you said? | 13:40 |
| Saviq | sil2100, thanks | 13:40 |
| mhr3_ | Saviq, touche | 13:40 |
| mhr3_ | Saviq, my primary worry is how would things look like if a scope pushed one widget, then another one 500ms later and then 10more another 500ms later... why just can't make informed decision if we want to display things as fast as possible | 13:41 |
| mhr3_ | s/why/we/ | 13:41 |
| Saviq | mhr3_, of course, I think there's two cases: preview creation and widget addition (removal not possible, right?) | 13:42 |
| mhr3_ | right | 13:42 |
| Saviq | mhr3_, so when preview is "lazy" with adding widgets, and does not provide a layout | 13:42 |
| Saviq | mhr3_, we'd only append widgets at the end of columns | 13:43 |
| mhr3_ | columnS? | 13:43 |
| mhr3_ | like randomly...? | 13:43 |
| Saviq | mhr3_, not randomly, but based on some rules | 13:44 |
| Saviq | mhr3_, say, if there's art in the first column, we wouldn't add anything more there | 13:44 |
| Saviq | mhr3_, otherwise we might try some more fancy determination | 13:45 |
| mhr3_ | so you'd try to do something like the horizontal journal is doing? | 13:45 |
| Saviq | mhr3_, something of the sort, yeah | 13:45 |
| Saviq | mhr3_, but not based on actual rendered widgets, just their type and props | 13:46 |
| Saviq | mhr3_, but I'd rather the plugin not be part of that | 13:46 |
| mhr3_ | which means we'd need to notify the shell with about-to-be-added widget | 13:46 |
| Saviq | mhr3_, yes | 13:46 |
| mhr3_ | did i mention the data for those widget might not be present immediately? | 13:47 |
| Saviq | mhr3_, that's fine, I think | 13:47 |
| Saviq | mhr3_, again, I don't want to base the decision on actual data | 13:47 |
| mhr3_ | Saviq, that means the props will be pretty much empty | 13:47 |
| Saviq | mhr3_, if something's not there, it's not like we can do anything about it | 13:47 |
| Saviq | mhr3_, what I'm saying is I'd like to make a semi-informed decision as soon as a widget becomes "known" to the system | 13:48 |
| Saviq | mhr3_, it will be a corner case I think, that we'd get a widget with no data | 13:48 |
| mhr3_ | oh well... you can surely make better decision than the plugin | 13:48 |
| Saviq | mhr3_, but anyway its type would be enough information | 13:48 |
| Saviq | mhr3_, exactly | 13:48 |
| mhr3_ | but not thrilled about having to call into js | 13:49 |
| mhr3_ | how does that even work | 13:49 |
| mhr3_ | ? | 13:49 |
| Saviq | mhr3_, good question ;), but it can be as simple as a property that the shell sets | 13:49 |
| Saviq | mhr3_, after you trigger a signal | 13:50 |
| Saviq | mhr3_, problem with that would be that it'd be required to do it | 13:50 |
| mhr3_ | aren't signals going to js asynchronously? | 13:50 |
| Saviq | mhr3_, they are | 13:50 |
| mhr3_ | well.. that's a problem | 13:50 |
| Saviq | mhr3_, so yeah, I think we'd rather do sync, wouldn't we | 13:50 |
| mhr3_ | i basically need return value from js | 13:51 |
| mhr3_ | as in "int giveMeColumnNumForWidget(widget)" | 13:51 |
| Saviq | mhr3_, QMetaObject::invokeMethod | 13:52 |
| Saviq | mhr3_, i.e. you'd have a property (default null) on Scopes | 13:53 |
| Saviq | mhr3_, say, previewProcessor | 13:53 |
| Saviq | mhr3_, if it's non-null, you'd call a method on it with some data | 13:53 |
| mhr3_ | i can already see the lost frames :P | 13:53 |
| Saviq | mhr3_, and use the output | 13:53 |
| Saviq | mhr3_, it will be maybe 20 lines of JS at the mos | 13:53 |
| === _salem is now known as salem_ | ||
| Saviq | mhr3_, we're running much more js on every frame than that ;) | 13:54 |
| mhr3_ | it's just awful :P | 13:54 |
| mhr3_ | anyway... /me lunch | 13:54 |
| Saviq | mhr3_, we can always do vala, if you'd rather ;P | 13:54 |
| Saviq | mhr3_, anyway, we can implement the processor in C++ | 13:55 |
| Saviq | mhr3_, and use the same mechanisms | 13:55 |
| mhr3_ | slightly better | 13:55 |
| mhr3_ | now get rid of the QMetaObject and i'm happy | 13:55 |
| mhr3_ | :) | 13:55 |
| === MacSlow|lunch is now known as MacSlow | ||
| Saviq | mhr3_, wanna rewrite unity8 in C/vala/C++? be my guest | 13:55 |
| Saviq | let's see how that goes :P | 13:56 |
| mhr3_ | Saviq, i'll think about it :P | 13:56 |
| Saviq | mhr3_, enjoy lunch | 13:56 |
| Saviq | mhr3_, http://qt-project.org/doc/qt-5.0/qtqml/qtqml-cppintegration-interactqmlfromcpp.html#invoking-qml-methods BTW | 13:59 |
| Saviq | sil2100, "In silo landing-005. Can't build: Some projects are missing revisions from distribution." | 14:05 |
| Saviq | didrocks, ↑ | 14:05 |
| Saviq | what do I do now? | 14:05 |
| sil2100 | Saviq: ah! Yes, so you need to check a checkbox, let me see the naming | 14:06 |
| Saviq | sil2100, will do | 14:06 |
| Saviq | sil2100, FORCE_REBUILD it seems | 14:06 |
| sil2100 | Saviq: yes, since we don't want to have the changelog entry for the revert | 14:07 |
| Saviq | karni, drop the TODO, it's a general thing we'll need to tackle together | 14:07 |
| karni | ok | 14:07 |
| Saviq | karni, I think letting JS "booleanize" undefined / null / "" would be good enough | 14:08 |
| Saviq | karni, in isOnlyItem | 14:08 |
| Saviq | karni, what is components["art"]["image"]? | 14:09 |
| dandrader | sil2100, hi, would you mind reviewing that? https://code.launchpad.net/~dandrader/ubuntu-keyboard/outOfSourceBuilds/+merge/204292 | 14:09 |
| karni | Saviq: I wasn't sure how to implement that correctly, I'm still not confident in those constructs | 14:09 |
| didrocks | Saviq: seems the naming was clear enough? \o/ | 14:09 |
| Saviq | didrocks, the message said "force rebuild", so yeah ;) | 14:10 |
| karni | Saviq: the image of the art. I assume it's sufficient to test ["art"] only? | 14:10 |
| Saviq | karni, there is no "image of the art" | 14:10 |
| Saviq | karni, and remember you're looking at the configuration, not at any particular result | 14:10 |
| Saviq | karni, and why would we always left-align when art is there? | 14:10 |
| dandrader | sil2100, I've picked you as you name pops up in "bzr log" and tmoenicke is no longer around... | 14:11 |
| karni | Saviq: I'm sorry if I didn't make this clear - I'll make it work in progress | 14:11 |
| sil2100 | dandrader: sure, let me take a look | 14:11 |
| Saviq | karni, I don't think art has any bearing on center vs. left alignment... | 14:11 |
| Saviq | karni, also, because components might be: | 14:11 |
| Saviq | "art": "foo" | 14:11 |
| Saviq | as well as: | 14:11 |
| Saviq | "art": { "field": "foo" } | 14:12 |
| karni | Saviq: It does. if there's art and it's horizontal, it should be left aligned, if there's no art, it should be center aligned | 14:12 |
| karni | let me find the spec | 14:12 |
| Saviq | karni, right, you need to differentiate between horizontal and vertical, then | 14:12 |
| tsdgeos | Cimi: there's still one "../../tests/qmltests/Dash/Music/data/testsound1.ogg" left | 14:12 |
| Saviq | karni, the condition should be: | 14:13 |
| Saviq | subtitle && (typeof subtitle === "string" || subtitle["field"]) | 14:13 |
| karni | ack, thank you :) | 14:13 |
| Saviq | karni, so, you check that subtitle is defined at all in the first place (and non-empty) | 14:13 |
| * karni nods | 14:13 | |
| === mterry_ is now known as mterry | ||
| Saviq | karni, and then it needs to be a string, or subtitle["field"] needs to be non-empty | 14:14 |
| tsdgeos | Saviq: Cimi: besides that one ogg path still looking like it should exist, it looks ok to me so i've approved https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 want me to top approve or want to have a second approve? | 14:14 |
| Cimi | tsdgeos, I updated the path | 14:14 |
| Saviq | tsdgeos, top-approve away | 14:14 |
| Cimi | tsdgeos, maybe I can do | 14:14 |
| Cimi | /path/not/existing | 14:15 |
| Saviq | Cimi, "../../tests/qmltests/Dash/Music/data/testsound1.ogg" | 14:15 |
| Cimi | let me do that | 14:15 |
| Cimi | Saviq, I pushed :| | 14:15 |
| tsdgeos | Cimi: you updated 3 of them, forgot 1 | 14:15 |
| Saviq | Cimi, tracksModel1 | 14:15 |
| tsdgeos | or launchpad is behind | 14:15 |
| Saviq | Cimi, or that ↑ | 14:15 |
| Saviq | Cimi, just drop the extensions, it really doesn't matter what you put there | 14:15 |
| Cimi | Saviq, ok | 14:16 |
| Cimi | sorry guys, was killed by headache till 10 mins ago | 14:16 |
| Saviq | Cimi, tsdgeos, I wonder, should we update the duration once the stream is loaded? in case the scope lied? | 14:16 |
| Cimi | since 7am | 14:16 |
| Cimi | :( | 14:16 |
| Saviq | Cimi, you need to fix your head! ETOOMANYHEADACHES | 14:16 |
| tsdgeos | Saviq: i was thinking that the other day too | 14:17 |
| tsdgeos | don't know tbh, i'd trust the scope | 14:17 |
| tsdgeos | but i'm open to both | 14:17 |
| Saviq | tsdgeos, we don't display the current time anyway, do we | 14:17 |
| tsdgeos | there's also the question if we should autoload or not | 14:17 |
| tsdgeos | Saviq: no, just progress | 14:17 |
| Saviq | tsdgeos, ok so unless people use stopwatches or somethin' we'r | 14:18 |
| Saviq | e good | 14:18 |
| tsdgeos | yep | 14:18 |
| Saviq | let's leave it be | 14:18 |
| Cimi | Saviq, don't ask me why | 14:18 |
| Saviq | Cimi, please put */ on separate line | 14:18 |
| Cimi | Saviq, I did work this morning, but I wish I was without headache | 14:18 |
| Cimi | Saviq, ok | 14:18 |
| Saviq | Cimi, London doesn't agree with you ;) | 14:19 |
| Saviq | Cimi, you Italians need more sun ;) | 14:19 |
| Cimi | Saviq, yes, glad I'm going to mwc | 14:20 |
| Cimi | Saviq, I'll be working there also the week after | 14:20 |
| Cimi | Saviq, rented flat with alex chiang | 14:21 |
| Saviq | Cimi, cool | 14:21 |
| Saviq | Cimi, docs are wrong | 14:22 |
| Saviq | widgetData["source"] widgetData["title"] widgetData["subtitle"] widgetData["length"]. | 14:22 |
| Saviq | those don't exist | 14:22 |
| Cimi | dammit | 14:22 |
| Cimi | you're right | 14:22 |
| Saviq | Cimi, it's enough to say: it expects each element in the array to be: { "source": "url://", "title": "Title", "subtitle": "Subtitle" // optional, "length": 120 // in seconds } | 14:23 |
| Cimi | Saviq, or you prefer http://paste.ubuntu.com/6873262/ | 14:25 |
| Cimi | ? | 14:25 |
| Saviq | Cimi, that's still wrong ;) | 14:25 |
| Saviq | Cimi, it's missing the index in there | 14:25 |
| Saviq | Cimi, let me check one thing | 14:25 |
| === rachelliu_ is now known as rachelliu | ||
| Cimi | Saviq, standup | 14:30 |
| Saviq | Cimi, btw, s/TextSummaryWidget/TextWidget/ or SummaryWidget please | 14:35 |
| Cimi | Saviq, you want AudioPlayerWidget as well? | 14:36 |
| tintou | mhr3_: I applied the changes you requested, It's better, it has triggered a very smaller diff :) | 14:36 |
| mhr3_ | tintou, great, why the "bool?" | 14:38 |
| mhr3_ | tintou, simple bool would suffice | 14:38 |
| tintou | mhr3_: yes, for sure, it's because I tried with void | 14:38 |
| mhr3_ | tintou, there's actually a trick possible | 14:39 |
| Saviq | Cimi, something like: http://pastebin.ubuntu.com/6873320/ | 14:41 |
| Saviq | Cimi, (sorry for pinging on irc.c.c) | 14:41 |
| Saviq | Cimi, not sure what you mean by "you want APW as well"? | 14:46 |
| Cimi | Saviq, audioPlayerWidget? | 14:46 |
| Cimi | as well? | 14:46 |
| Saviq | Cimi, what? rename? AudioWidget would probably be enough, tbh | 14:47 |
| Cimi | ok | 14:47 |
| greyback | dandrader: did you mean https://code.launchpad.net/~thomas-voss/platform-api/expose_accuracy_and_service_status_to_platform/+merge/203298 with the corresponding location service branch? | 14:47 |
| dandrader | greyback, no | 14:47 |
| * dandrader looks for the branches | 14:48 | |
| dandrader | greyback, lp:~thomas-voss/location-service/adjust-to-dbus-cpp and lp:~thomas-voss/platform-api/adjust-to-location-service-changes | 14:48 |
| greyback | dandrader: thanks | 14:48 |
| Saviq | Cimi, tsdgeos, ah you didn't name them *Widget, maybe that's fine (Audio, Summary, Gallery etc.)? | 14:54 |
| Saviq | since they're all in /Previews/ anyway | 14:55 |
| tsdgeos | Saviq: no we didn't | 14:55 |
| tsdgeos | since they are in Previews | 14:55 |
| tsdgeos | *but* | 14:55 |
| tsdgeos | it pollutes a bit the make testXYZ naming though | 14:55 |
| Saviq | tsdgeos, right, can the tests be named differently than the .qml itself? | 14:55 |
| tsdgeos | since you do make testAudioPlayer | 14:56 |
| tsdgeos | and make testAudioPlayerPreview | 14:56 |
| Saviq | tsdgeos, testPreview_Audio or something? | 14:56 |
| tsdgeos | or something may make more sense | 14:56 |
| tsdgeos | let me see | 14:56 |
| Cimi | Saviq, tsdgeos I renamed already both to AudioWidget and TextWidget | 14:57 |
| Cimi | tsdgeos, it creates a conflict in tests/qmluitests/CMakeLists.txt | 14:57 |
| Saviq | Cimi, sorry, I brainfarted, thought they were named *Widget | 14:57 |
| Cimi | tsdgeos, easy to fix in your branch | 14:57 |
| * tsdgeos is lost now | 14:58 | |
| Cimi | me too | 14:58 |
| Cimi | shall I revert? | 14:58 |
| Cimi | I think is fine to keep some sort of custom name | 14:58 |
| Saviq | tsdgeos, Cimi, let's go for simple names - Audio, Gallery, Text etc. | 14:58 |
| Cimi | we can have PreviewAudio | 14:58 |
| Cimi | PreviewGallery | 14:59 |
| tsdgeos | i've been trying to use the names in the UX doc | 14:59 |
| Cimi | or AudioPreview | 14:59 |
| Saviq | mzanetti, would rather do ↑ I know | 14:59 |
| Saviq | I have no strong opinion, (simple is better IMO) | 14:59 |
| Saviq | brb | 14:59 |
| mzanetti | ? | 14:59 |
| * mzanetti is not following | 15:01 | |
| tsdgeos | Saviq: Cimi: ok, let's go with PreviewName | 15:01 |
| tsdgeos | mzanetti: don't worry :D | 15:01 |
| Cimi | tsdgeos, PreviewAudioPlayback then | 15:04 |
| Cimi | tsdgeos, PreviewTextSummary | 15:04 |
| Cimi | ok? | 15:04 |
| tsdgeos | +1 | 15:04 |
| karni | Saviq: what's this? 20/20 Test #20: timeformattertest ....................***Failed 0.02 sec | 15:04 |
| karni | Saviq: WIP -> Needs Review https://code.launchpad.net/~unity-team/unity8/new-scopes-title-alignment/+merge/204677 | 15:06 |
| Saviq | karni, LANG=C | 15:07 |
| Saviq | karni, or LC_ALL=C | 15:07 |
| Saviq | karni, == read CODING | 15:07 |
| karni | huh! | 15:09 |
| Cimi | tsdgeos, done | 15:11 |
| tsdgeos | Cimi: do you really need import Ubuntu.Components.ListItems 0.1 in the PreviewAudioPlayback? | 15:14 |
| Cimi | tsdgeos, nope, I needed when I had thindivider | 15:14 |
| Cimi | tsdgeos, removed | 15:14 |
| Cimi | tsdgeos, well spot, let me do | 15:14 |
| Cimi | tsdgeos, done for both | 15:17 |
| Saviq | karni, re: carousel, I wouldn't touch Carousel.qml itself | 15:25 |
| Saviq | karni, and it's weird, it doesn't look that big here | 15:25 |
| karni | I'll send you a screenshot | 15:25 |
| Saviq | karni, ah I know what you mean | 15:26 |
| Saviq | karni, non-overlayed title isn't meant to be supported I'm afraid :| | 15:26 |
| tsdgeos | Cimi: since my image gallery and your text summary don't merge together well, i'll chain imageGallery after textSummary | 15:26 |
| karni | Saviq: the label, when focused in carousl, gets cut | 15:26 |
| tsdgeos | Cimi: if you are working on something chain it after my imagegallery | 15:26 |
| karni | Saviq: ok. so, either I should work on the overlay part, or we have to fix this like ^ before MWC. It looks real bad :( | 15:26 |
| karni | Saviq: and I agree. non overlayed title looks ridiculous in carousel xD | 15:27 |
| Saviq | karni, doesn't look that great on the screenshot, either... | 15:27 |
| karni | yes, lesser evil | 15:27 |
| Saviq | karni, depends ;) | 15:27 |
| Saviq | ok, will try and get overlay to work this week, then | 15:27 |
| === salem_ is now known as _salem | ||
| karni | Saviq: sent the screenshot | 15:28 |
| karni | Saviq: woho, that'd be amazing | 15:28 |
| tsdgeos | Cimi: you are missing the "commit boilerplate" in https://code.launchpad.net/~unity-team/unity8/unity8.previews_audioPlayer/+merge/203387 and https://code.launchpad.net/~unity-team/unity8/unity8.previews_textSummary/+merge/204177 | 15:29 |
| tsdgeos | please add | 15:29 |
| anpok | mzanetti: re | 15:30 |
| mzanetti | anpok: hi :) | 15:30 |
| anpok | mzanetti: because all buffers are stacked onto each other and all use a pixel format with alpha they all get blended onto each other | 15:30 |
| === alan_g is now known as alan_g|tea | ||
| mzanetti | anpok: any idea already how to make it faster? | 15:32 |
| Cimi | tsdgeos, commit boilerplate? | 15:32 |
| Cimi | ah | 15:32 |
| Cimi | tsdgeos, sorry what? | 15:32 |
| anpok | mzanetti: yes, greyback suggested to make application windows oppaque - since they are - then mir can filter the occupied ones out.. | 15:33 |
| tsdgeos | Cimi: https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8 | 15:33 |
| anpok | additionally we could also play with hidden status - but neither sure where and how - so I will try with opaque first | 15:33 |
| mzanetti | anpok: I guess in the long run we should support transparent app surfaces though. | 15:34 |
| greyback | anpok: let me know when you want to try the hidden status thing, I've a good idea how to tackle that | 15:34 |
| greyback | mzanetti: yep. App should be able to decide if it wants transparency or not | 15:34 |
| anpok | oh started the qtubuntu build earlier | 15:35 |
| anpok | and it failed o_O | 15:35 |
| === dandrader is now known as dandrader|lunch | ||
| Cimi | tsdgeos, :'( | 15:36 |
| Cimi | tsdgeos, that sounds boring | 15:36 |
| anpok | http://paste.ubuntu.com/6873609/\ | 15:36 |
| anpok | http://paste.ubuntu.com/6873609/ | 15:36 |
| mzanetti | anpok: install qt5-default | 15:37 |
| mzanetti | anpok: or export QT_SELECT=qt5 | 15:37 |
| === alan_g|tea is now known as alan_g | ||
| tsdgeos | Cimi: where have you been ? | 15:38 |
| Cimi | tsdgeos, added checklist | 15:39 |
| kgunn | is ./run_on_device not rebuilding changes in ? on latest trunk ?...or am i doing something wrong | 15:39 |
| kgunn | note, was previously working...just updated my local branch to latest trunk | 15:40 |
| mzanetti | kgunn: its not rebuilding always. there are rare cases where it fails to detect if something has changed | 15:40 |
| mzanetti | kgunn: to be sure, log into the device and delete ~/shell | 15:40 |
| tsdgeos | Cimi: can you update the pot file in the textsummary | 15:40 |
| Cimi | tsdgeos, ok | 15:40 |
| Cimi | tsdgeos, where do I need it? | 15:41 |
| kgunn | mzanetti: thanks...and yeah...weird, code change in same exact spot, all of the sudden it detected | 15:42 |
| Cimi | ah see more | 15:42 |
| * kgunn suspects an order of operation somewhere | 15:42 | |
| anpok | mzanetti: thats with sbuild | 15:44 |
| Cimi | tsdgeos, it carries other changes http://paste.ubuntu.com/6873649/ | 15:44 |
| tsdgeos | the only real change is "Please enter SIM PIN" | 15:45 |
| tsdgeos | the other is just moving around | 15:45 |
| tsdgeos | the sim pin thing is complicated | 15:45 |
| tsdgeos | but just let it there too | 15:45 |
| mzanetti | anpok: you can still add qt5-default as a build dependency or export QT_SELECT in debian/rules. but the question is why does it build in the repositories if this is missing... | 15:46 |
| sil2100 | mhr3_: hi! We assigned a slot for the mediascanner scope now | 15:48 |
| mhr3_ | and it took only 4 days! :P | 15:49 |
| Cimi | tsdgeos, OK done | 15:49 |
| Saviq | tsdgeos, 'fraid pushed a small change to card-tool: http://bazaar.launchpad.net/~saviq/unity8/card-tool/revision/687 | 15:50 |
| * tsdgeos re-reviews | 15:53 | |
| karni | Saviq: Could you update me on where we are with preview work please? | 15:54 |
| Trevinho | pete-woods: I'm getting hud-service to use 100% of my CPU quite often... I don't have debg symbols here yet, but this seems to happen http://pastebin.ubuntu.com/6873661/ (if it helps) | 15:54 |
| pete-woods | Trevinho: thanks, I'll have a look | 15:54 |
| karni | Saviq: Feel free to delegate to Cimi or mhr3, I'm happy for whoever provides progress update :) | 15:54 |
| Cimi | karni, branches are merging soon | 15:54 |
| Cimi | karni, at least for text summary, audio playback | 15:55 |
| karni | Cimi: how soon is soon :)? some time this week perhaps? | 15:55 |
| Cimi | karni, currently approved, today/tomorrow | 15:55 |
| karni | Cimi: I'm just asking because we need to know where we are relative to MWC | 15:55 |
| karni | Cimi: sound great | 15:56 |
| Saviq | karni, I plan to have initial preview support hooked up tomorrow | 15:56 |
| karni | Saviq: whoaa, that is great news | 15:56 |
| Saviq | karni, it's fortunately not a huge amount of work | 15:56 |
| karni | Saviq: That's great. Please keep me posted, I'm happy to testdrive whatever will be in WIP on lp | 15:56 |
| pete-woods | Trevinho: can you tell me which apps you have running? and also pastebin the hud log (~/.cache/upstart/hud.log) | 15:57 |
| Trevinho | pete-woods: this is my log http://paste.ubuntu.com/6873710/ | 15:58 |
| tsdgeos | Saviq: looks good, want me to re-topapprove? | 15:59 |
| Trevinho | pete-woods: as for the apps I've firefox (3 windows), gnome-terminal (2 windows), chromium-browser (webapp mode), subilme text (6 windows), evolution, gnome-tweak-tool | 15:59 |
| Saviq | tsdgeos, please | 15:59 |
| Saviq | karni, if you're in need of tasks, you could have a stab at the overlay, or maybe trying to find out why tapping doesn't work in carousel | 15:59 |
| tsdgeos | dine | 15:59 |
| pete-woods | Trevinho: if you notice any correlation with it occurring with the startup of any of those particular applications it would be very helpful to know :) | 16:00 |
| kgunn | hey so, using ./run_on_device....shouldn't i be able to navigate to home/phablet/shell on the device and ./runtests ? | 16:00 |
| Saviq | tsdgeos, already? you're in Barcelona, shouldn't you dine at 10pm or something? | 16:00 |
| pete-woods | but thanks for that list | 16:00 |
| karni | Saviq: trying to find a balance between sprint and MWC work. noted. I'll look into carousel first. | 16:00 |
| Trevinho | pete-woods: full list http://paste.ubuntu.com/6873719/ | 16:00 |
| tsdgeos | Saviq: i meant done | 16:00 |
| Saviq | tsdgeos, ;) | 16:00 |
| kgunn | heh | 16:00 |
| tsdgeos | Saviq: 9pm if at home, 10pm if at a restaurant is typical yes | 16:00 |
| Trevinho | pete-woods: ok, but I've noticed that at boot time... or just few seconds after | 16:00 |
| pete-woods | Trevinho: hmm, that is very interesting | 16:01 |
| Saviq | karni, it's your call - if you have time and want to stab it, just let me know you are, otherwise one of us will do it | 16:01 |
| pete-woods | presumably with only something like gnome-terminal runnung? | 16:01 |
| karni | Saviq: ack! happy to take on work, I'll keep you posted. | 16:02 |
| Saviq | karni, cheers | 16:02 |
| karni | Saviq: You asked for a list of priorities for out team. We took an old e-mail, and noted where we are. Here it is: https://pastebin.canonical.com/104220/ | 16:04 |
| Saviq | karni, thanks | 16:04 |
| karni | Saviq: basically, previews, so we're on good path, then, if possible, some theming | 16:04 |
| karni | Saviq: thank you, sir | 16:04 |
| === _salem is now known as salem_ | ||
| pete-woods | Trevinho: well, the culprit is definitely sublime text | 16:11 |
| pete-woods | Trevinho: ran it, and the CPU usage immediately spiked | 16:11 |
| pete-woods | Trevinho: thanks for all the information :) | 16:11 |
| Trevinho | pete-woods: np | 16:12 |
| Trevinho | pete-woods: any idea what it might be? | 16:12 |
| pete-woods | Trevinho: it could possibly be that there's a cycle in the menus that sublimetext exports, and we're not handling it? | 16:12 |
| pete-woods | at the minute I'd just be guessing, though | 16:13 |
| Trevinho | ah... damned closed sources things | 16:13 |
| Trevinho | but it's soo good to code :/ | 16:13 |
| pete-woods | we should still be able to debug it fairly easily, though | 16:13 |
| pete-woods | at it's all happening over DBus, so is fairly transparent | 16:13 |
| kgunn | hey so, using ./run_on_device....shouldn't i be able to navigate to home/phablet/shell on the device and ./runtests ? | 16:16 |
| pete-woods | Trevinho: here's a bug report for you to watch (https://bugs.launchpad.net/hud/+bug/1276225) | 16:17 |
| ubot5 | Launchpad bug 1276225 in Unity HUD "Infinite loop in gmenu handling when running sublimetext" [Undecided,New] | 16:17 |
| anpok | mzanetti: hmm i guess I use the wrong branch - i should be using trunk not mir? | 16:17 |
| mzanetti | anpok: what do you want to do? | 16:18 |
| tsdgeos | kgunn: i'd say runtests needs some love | 16:18 |
| kgunn | tsdgeos: heh | 16:19 |
| mzanetti | tsdgeos: that might be true, yea | 16:19 |
| tsdgeos | quick look at it doesn't seem as it would work | 16:19 |
| tsdgeos | kgunn: see CODING for how to run tests | 16:19 |
| Trevinho | pete-woods: thanks | 16:19 |
| mzanetti | tsdgeos: well, it works, that's how our tests in jenkins are run | 16:19 |
| mzanetti | kgunn: ^ | 16:19 |
| tsdgeos | mzanetti: well just runs qmltests and it expects you to be in the builddir | 16:19 |
| anpok | mzanetti: hack on qtubuntu | 16:19 |
| mzanetti | but probably only works if you do the exact same thing as jenkins does | 16:19 |
| mzanetti | anpok: trunk | 16:19 |
| kgunn | well...it attempted of course, but nothing ran... | 16:19 |
| tsdgeos | kgunn: if you do | 16:20 |
| tsdgeos | cd builddir | 16:20 |
| tsdgeos | ../runtests | 16:20 |
| tsdgeos | maybe it works better | 16:20 |
| kgunn | ah, would make sense | 16:20 |
| Saviq | sil2100, didrocks, unity8 good to go | 16:21 |
| didrocks | Saviq: good good, or good, like "GOOOOD"? ;) | 16:22 |
| kgunn | no really....good | 16:22 |
| didrocks | ;) | 16:23 |
| didrocks | hum | 16:23 |
| didrocks | jenkins is weird… | 16:23 |
| didrocks | ah no, it's not | 16:23 |
| didrocks | I'm broken | 16:23 |
| * didrocks fixes didrocks | 16:23 | |
| Saviq | didrocks, tested, everything works as expected, filed a few bugs I found: bug #1276218, bug #1276223, bug #1276231 | 16:25 |
| ubot5 | bug 1276218 in indicator-network (Ubuntu) "Cancelling a WiFi password dialog turns WiFi off and leaves the network checked in the list" [Undecided,New] https://launchpad.net/bugs/1276218 | 16:25 |
| ubot5 | bug 1276223 in unity-scope-click (Ubuntu) "Preview for already installed apps in "More suggestions" has "Install" button" [Undecided,New] https://launchpad.net/bugs/1276223 | 16:25 |
| ubot5 | bug 1276231 in ubuntu-keyboard (Ubuntu) "With auto-correction enabled, leaving an app when a word is "being predicted" leaves the keyboard in weird state" [Undecided,New] https://launchpad.net/bugs/1276231 | 16:25 |
| didrocks | Saviq: packaging changes looks good, publishing | 16:26 |
| sil2100 | ls | 16:27 |
| sil2100 | ... | 16:27 |
| Saviq | didrocks, \o\ /o/ \o/ \o\ /o/ | 16:27 |
| Saviq | /we need to regress more, we get priority silos *cough* *cough* | 16:28 |
| didrocks | Saviq: rohhhh :p | 16:28 |
| Saviq | didrocks, sorry ;D | 16:29 |
| * didrocks looks Saviq with brown eyes | 16:29 | |
| didrocks | at* | 16:29 |
| Saviq | tsdgeos, "8-import Ubuntu.Components.ListItems 0.1" in gallery? | 16:38 |
| tsdgeos | Saviq: i think that's a result of 3--way merge | 16:38 |
| Saviq | tsdgeos, ok, let me see | 16:38 |
| tsdgeos | Saviq: first merged to audioplayer, later merged to textsummary | 16:39 |
| tsdgeos | textsummary as been merged to audioplayer too | 16:39 |
| tsdgeos | but the merge is less recent | 16:39 |
| tsdgeos | so it seems i'm removing that line | 16:39 |
| tsdgeos | when indeed the line is not there | 16:39 |
| tsdgeos | not sure if i'm making sense in there | 16:39 |
| Saviq | tsdgeos, you are, but when merging the three in sequence I get a conflict in CMakeLists.txt | 16:45 |
| tsdgeos | really? | 16:46 |
| tsdgeos | damn | 16:46 |
| Saviq | <<<<<<< TREE | 16:46 |
| Saviq | ======= | 16:46 |
| Saviq | add_qml_test(Dash/Previews PreviewImageGallery IMPORT_PATHS ${qmltest_DEFAULT_IMPORT_PATHS} ${CMAKE_BINARY_DIR}/tests/mocks) | 16:46 |
| Saviq | >>>>>>> MERGE-SOURCE | 16:46 |
| Saviq | wonder how is that a conflict... | 16:46 |
| Saviq | stupid bzr | 16:46 |
| tsdgeos | Saviq: i guess textsummary would need to get updated | 16:46 |
| Saviq | tsdgeos, yeah, *something* isn't merge *somewhere* ;) | 16:47 |
| tsdgeos | let me see if i can make it work | 16:47 |
| tsdgeos | it's actually text summary that needs fixing | 16:48 |
| tsdgeos | it already fails at merging there | 16:48 |
| tsdgeos | Cimi: can you do it? | 16:48 |
| tsdgeos | or i'm old | 16:48 |
| * tsdgeos checks | 16:48 | |
| tsdgeos | wait i was outdated | 16:48 |
| tsdgeos | Saviq: i can't make any sense of why it doesn't merge | 16:51 |
| tsdgeos | Saviq: you can merge those 2 only and then merge mine next | 16:52 |
| tsdgeos | or i can just resubmit a "cleaner" branch | 16:52 |
| Saviq | tsdgeos, maybe yeah, let's clean it up | 16:53 |
| tsdgeos | Saviq: ok, i'll do the implicitHeight thing, but who's going to set the height? | 16:53 |
| tsdgeos | the previewfactory? | 16:53 |
| Cimi | Saviq, irssi? :) | 16:53 |
| Saviq | tsdgeos, it's internal | 16:53 |
| Saviq | tsdgeos, if there's no explicit height, implicitHeight is used | 16:53 |
| * tsdgeos facepalms :D | 16:53 | |
| Saviq | Cimi, no, xchat-gnome | 16:53 |
| Saviq | tsdgeos, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-item.html#implicitWidth-prop | 16:54 |
| Saviq | tsdgeos, RTFM! | 16:54 |
| Saviq | ;) | 16:54 |
| Saviq | Cimi, re: priv | 16:54 |
| Saviq | Cimi, we're not "marking" them at all, we just hide them so they're not available on the root object | 16:54 |
| Saviq | Cimi, when there's a lot, we'd put them in a QtObject { id: priv } indeed | 16:55 |
| Saviq | Cimi, when there's only one, just put it in one of the lower level components | 16:55 |
| Saviq | Cimi, I know it feels like a hardcoded value, but where it should be un-hardcoded is the style/theme, not in the component itself | 16:56 |
| tsdgeos | Saviq: yes, all the projects i've used always did /** and not /*! | 16:58 |
| Saviq | tsdgeos, https://qt.gitorious.org/qt/qtdeclarative/source/7c1e3dea8ba66f9eedee4f3d66dba55d7f7556b8:src/quick/items/qquickloader.cpp#L159 | 16:59 |
| tsdgeos | well that's qdoc | 16:59 |
| tsdgeos | isn't it? | 16:59 |
| Saviq | tsdgeos, same difference :) | 16:59 |
| Saviq | tsdgeos, kde uses /** ? | 17:00 |
| tsdgeos | i'd say it does | 17:00 |
| tsdgeos | let me see | 17:00 |
| === dandrader|lunch is now known as dandrader | ||
| Saviq | tsdgeos, I don't really care, just looked at Qt for "inspiration" | 17:00 |
| tsdgeos | i don't care either | 17:00 |
| tsdgeos | yeah /** | 17:01 |
| tsdgeos | http://paste.ubuntu.com/6873967/ | 17:01 |
| tsdgeos | anyhow http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html says /*! is Qt style | 17:01 |
| tsdgeos | so that works fine for me | 17:01 |
| Saviq | tsdgeos, let's do that | 17:01 |
| tsdgeos | do what? | 17:01 |
| Saviq | tsdgeos, Qt style | 17:01 |
| tsdgeos | sure | 17:01 |
| Saviq | tsdgeos, /me should add * everywhere then | 17:02 |
| Saviq | tsdgeos, will clean it up later | 17:02 |
| tsdgeos | Saviq: no no, Qt style is /*! | 17:02 |
| tsdgeos | no need to add any *, no? | 17:02 |
| Saviq | tsdgeos, I mean next line | 17:02 |
| tsdgeos | ah | 17:02 |
| tsdgeos | well that's optional | 17:02 |
| Saviq | tsdgeos, between /*! and */ | 17:02 |
| Saviq | sure it is | 17:03 |
| Saviq | ETOOMANYPOSSIBILITES | 17:03 |
| tsdgeos | i actually like it though :D | 17:03 |
| Saviq | like it couldn't be imposed, dammit! | 17:03 |
| Saviq | tsdgeos, yeah, kde uses @, too, instead of \ | 17:03 |
| Saviq | java lovers! | 17:03 |
| tsdgeos | i'd mostly vote for "old people" | 17:04 |
| Saviq | ;D | 17:04 |
| tsdgeos | i.e. i don't think doxygen supported Qt-style when kde started adding documentation | 17:04 |
| Saviq | tsdgeos, Cimi, .pot change on purpose? | 17:05 |
| tsdgeos | Saviq: well there's new strings | 17:05 |
| Saviq | tsdgeos, ah of course | 17:05 |
| Saviq | tsdgeos, and the other are just movearounds | 17:05 |
| Saviq | ok | 17:05 |
| * tsdgeos args | 17:07 | |
| tsdgeos | force pushed the wrong stuff :D | 17:07 |
| Saviq | tsdgeos, yay ;) | 17:09 |
| tsdgeos | ahhhhhhhh | 17:10 |
| tsdgeos | i hate bzr | 17:10 |
| tsdgeos | so i get a branch | 17:10 |
| tsdgeos | merge everything in order | 17:10 |
| tsdgeos | resolve the conflicts | 17:10 |
| tsdgeos | push it | 17:10 |
| tsdgeos | and then try to do the merge again | 17:10 |
| tsdgeos | and it conflcits :D | 17:10 |
| tsdgeos | Saviq: is there a change you do bzr merge lp:~aacid/unity8/image_gallery_preview_widget --weave when merging the 3rd branch? | 17:11 |
| tsdgeos | or you don't have control over it and i should really push a clean clean branch? | 17:11 |
| Saviq | tsdgeos, not sure what you mean | 17:12 |
| tsdgeos | so if you add | 17:12 |
| Saviq | tsdgeos, but just leave it for now, don't get frustrated | 17:12 |
| tsdgeos | --weave | 17:12 |
| tsdgeos | it merges fine | 17:12 |
| tsdgeos | but if there's some tool that does the merging | 17:12 |
| tsdgeos | instead of you | 17:12 |
| tsdgeos | i need to redo the branch for it to not have a criss-cross | 17:12 |
| tsdgeos | bah, will fix it tomorrow | 17:14 |
| * tsdgeos waves | 17:14 | |
| Cimi | Saviq, pushed comments and moved variable | 17:19 |
| Saviq | Cimi, I've more comments to that branch I'm afraid, incoming | 17:19 |
| Cimi | ok | 17:19 |
| Cimi | Saviq, tell me | 17:20 |
| Cimi | Saviq, I didn't use thin divider because rotation doesn't seem to work inside row | 17:21 |
| Cimi | sorry | 17:21 |
| Cimi | it just doesn't work in row | 17:21 |
| Saviq | Cimi, oh interesting, using a transform, or direct via Item.rotation? | 17:22 |
| Cimi | Saviq, just put it inside | 17:22 |
| Cimi | Saviq, I think they have some calculation of dimensions | 17:22 |
| Cimi | but let me try again so I paste the error | 17:22 |
| Cimi | Saviq, QML Row: Cannot specify left, right, horizontalCenter, fill or centerIn anchors for items inside Row. Row will not function | 17:23 |
| Cimi | Saviq, pretty sure it contains some weird theming | 17:24 |
| Cimi | or some calculations somewhere in listitems | 17:24 |
| Cimi | Saviq, that is the error happening adding a ThinDivider {} in row | 17:25 |
| Saviq | Cimi, https://code.launchpad.net/~unity-team/unity8/unity8.previews_textSummary/+merge/204177/comments/478501 | 17:27 |
| Saviq | Cimi, yeah, ThinDivider has anchors | 17:28 |
| Saviq | Cimi, you should be able to undefine them | 17:28 |
| Saviq | Cimi, i.e. anchors: undefined | 17:28 |
| Saviq | Cimi, it's not about rotation | 17:28 |
| Cimi | Saviq, I don't agree with all your comments | 17:29 |
| Saviq | Cimi, you don't have to | 17:29 |
| Saviq | Cimi, if you disagree somewhere, reply why | 17:30 |
| Saviq | Cimi, convince me ;) | 17:30 |
| Cimi | I can tell you here | 17:30 |
| Saviq | Cimi, comment please | 17:30 |
| Saviq | Cimi, I'm past my EOD already | 17:30 |
| Cimi | ok | 17:30 |
| Cimi | Saviq, anchors is read only | 17:32 |
| Saviq | Cimi, then you need to unset the actual anchors that ThinDivider defines | 17:33 |
| Cimi | Saviq, but this is crap because if thin divider changes we break | 17:33 |
| Saviq | Cimi, thin divider is our component, that's a) | 17:33 |
| Cimi | hah | 17:33 |
| Cimi | Saviq, no, it's in SDK | 17:34 |
| Saviq | Cimi, and it's like 10 lines ;) | 17:34 |
| Saviq | Cimi, no, it's not | 17:34 |
| Saviq | Cimi, just copy it into VerticalDivider and be done with it ;) | 17:34 |
| Cimi | Saviq, I was using thin divider from sdk | 17:34 |
| Saviq | Cimi, we have our own in ListItems (which, granted, we should not) | 17:35 |
| Saviq | Cimi, but anyway, I'm not hung up on using ThinDivider | 17:35 |
| Saviq | Cimi, I *am* hung up on not using two Rectangles there ;) | 17:35 |
| Saviq | mhr3_, u8 landed, just pushed merge to new-scopes, version should be resolved in some minutes | 17:45 |
| mhr3_ | Saviq, i was wondering if it'd happen today :) | 17:46 |
| Saviq | mhr3_, you know, all the snow on the tracks... | 17:46 |
| Saviq | karni, we could use a review of https://code.launchpad.net/~saviq/unity8/newscopes-card-tool/+merge/204301 | 17:48 |
| mhr3_ | :) | 17:48 |
| karni | Saviq: ack, on it after lunch break | 17:51 |
| Saviq | karni, cheers | 17:52 |
| mhr3_ | karni, your lunch hours suggest you moved to us :) | 17:54 |
| karni | mhr3_: Orlando, 12:55 here :) | 17:55 |
| mhr3_ | aaaaah, so i'm actually right, and i though you're just being... you? :P | 17:56 |
| Cimi | Saviq, I've done, chat tomorrow then! | 17:57 |
| karni | hahahah | 17:57 |
| karni | almost done with lunch | 17:57 |
| Saviq | Cimi, o/ | 17:57 |
| === alan_g is now known as alan_g|EOD | ||
| Saviq | karni, you wrote in the notes that VJournal is DONE, which it isn't, is it still a req? should we be looking at it? | 18:01 |
| karni | aight, you summoned me :) | 18:03 |
| karni | Saviq: No, I think we don't need vjournal. I'll confirm with ssweeny, but if we do, I'll complete it. | 18:04 |
| Saviq | karni, ok cool | 18:04 |
| karni | Saviq: for now, consider it non-req | 18:04 |
| * karni does review | 18:04 | |
| Saviq | karni, so basically previews are top of the list now | 18:04 |
| karni | Saviq: yes, great | 18:04 |
| Saviq | karni, then overlay and the visual themes | 18:04 |
| karni | perfect! | 18:04 |
| karni | Saviq: so, I left a comment that carousel would not spin when clicked (after I approved that branch). how would you like to proceed? I started looking into why it doesn't work. shall we fix it in another branch? we don't want to break trunk carousel | 18:05 |
| karni | Saviq: the "weird" card height was probably because CardTool calculates 3 (?) lines of text for summary, if summary is mapped. even if all summaries are very short. | 18:06 |
| karni | and so, there's visual spacing below. but, that's a detail, we don't care about that much ATM | 18:06 |
| Saviq | karni, trunk carousel is not touched at all | 18:06 |
| karni | we just used subtitle field instead. | 18:06 |
| karni | Saviq: so it's a card thing, eh? | 18:06 |
| Saviq | karni, 5 lines | 18:06 |
| * karni nods | 18:06 | |
| Saviq | karni, it's something between CardCarousel and Carousel, yeah | 18:07 |
| Saviq | karni, and re: mapping summary yes, and that's the desired behavior | 18:07 |
| karni | ok. want me to +1 your branch and fix in a different one? | 18:07 |
| karni | Saviq: bleh :D | 18:07 |
| Saviq | karni, since _a_ card can have a summary 5 lines long | 18:07 |
| Saviq | karni, we need all of them to cater for that | 18:07 |
| Saviq | karni, but that's only the case in grid | 18:08 |
| karni | Saviq: I was thinking of "check longest summary in the model", and set size based on that hehe | 18:08 |
| karni | right | 18:08 |
| Saviq | karni, no no no | 18:08 |
| karni | heheheheh | 18:08 |
| karni | Saviq: take that as a joke | 18:08 |
| Saviq | karni, oof | 18:08 |
| karni | Saviq: aight, let's go back to your branch | 18:08 |
| karni | +1 and I fix the carousel? | 18:08 |
| Saviq | karni, if you're anywhere close to fixing the carousel, we can include it | 18:08 |
| Saviq | karni, it's your call, really | 18:09 |
| Saviq | karni, I can push to ~unity-team and you'll just continue on that branch, /me fine with that | 18:09 |
| karni | Saviq: ok, let's +1 and I fix it, if that's okay with you. | 18:09 |
| Saviq | karni, fine by me | 18:09 |
| karni | I had to share my attention with the meetings, and just came back from lunch, so let's get this rolling. | 18:09 |
| Saviq | karni, yup, no worries | 18:10 |
| karni | Saviq: want to fill out checklist? | 18:10 |
| Saviq | karni, not here, no | 18:10 |
| karni | ok | 18:10 |
| Saviq | karni, that will happen when merging new-scopes into trunk | 18:10 |
| Saviq | we need to start fixing tests, though... | 18:10 |
| karni | Saviq: +1 and top-approved | 18:10 |
| karni | Saviq: which ones? | 18:10 |
| Saviq | karni, all the failing ones ;) | 18:11 |
| karni | Saviq: what's the fulll suite run command? | 18:11 |
| Saviq | karni, in new-scopes I mean | 18:11 |
| karni | I only did selective test* and make test | 18:11 |
| Saviq | karni, I'll kick a -ci run on new-scopes, let's see | 18:11 |
| karni | ok | 18:11 |
| === dandrader is now known as dandrader|afk | ||
| karni | Saviq: Card is an abstract button. the click() event has no arguments. do you know what are attached properties of Carousel delegates? basically, onClicked: cardCarousel.clicked(index, itemY) was outside of the delegate (that was the problem), but itemY is not defined. | 19:04 |
| Saviq | karni, ah of course | 19:04 |
| Saviq | karni, Carousel is different, it needs all input | 19:05 |
| Saviq | karni, I think it's going to be enough to go enable: false on the Card in Carousel | 19:06 |
| * karni looks | 19:06 | |
| Saviq | karni, yup | 19:07 |
| karni | Saviq: right, but doesn't that kill the click-to-preview part? | 19:07 |
| karni | long press should be preview? | 19:08 |
| Saviq | karni, no, because Carousel itself needs to calculate which item was clicked | 19:08 |
| Saviq | karni, so in case of Carousel it's the Carousel that sends that signal, not Card itself | 19:08 |
| karni | ack | 19:08 |
| karni | Saviq: you're right. want to push that one-liner or should I? | 19:09 |
| Saviq | karni, | 19:09 |
| Saviq | === modified file 'qml/Dash/CardCarousel.qml' | 19:09 |
| Saviq | --- qml/Dash/CardCarousel.qml 2014-01-31 17:22:40 +0000 | 19:09 |
| Saviq | +++ qml/Dash/CardCarousel.qml 2014-02-04 19:09:09 +0000 | 19:09 |
| Saviq | @@ -64,6 +64,8 @@ | 19:09 |
| Saviq | 19:09 | |
| Saviq | property bool explicitlyScaled | 19:09 |
| Saviq | property var model | 19:09 |
| Saviq | + | 19:09 |
| Saviq | + enabled: false | 19:09 |
| Saviq | } | 19:09 |
| Saviq | } | 19:09 |
| Saviq | } | 19:09 |
| karni | yes, that's what I did :) | 19:09 |
| Saviq | karni, I'll just push it directly to new-scopes | 19:09 |
| karni | Saviq: ack, thank you | 19:09 |
| karni | good job | 19:09 |
| Saviq | karni, good job you! | 19:09 |
| Saviq | another one bites the dust! | 19:10 |
| karni | haha | 19:10 |
| karni | Saviq: would you mind giving me 2 sentence intro into overlay mode? you mentioned UbuntuShape2 | 19:11 |
| Saviq | karni, yeah, we don't have that yet | 19:11 |
| karni | Saviq: Do you have the link to the design drive? Could you PM it to me please? | 19:12 |
| karni | Saviq: I'm happy to take on overlay if I find time (and I'll try to find time) | 19:12 |
| karni | Thanks | 19:13 |
| Saviq | karni, we had the overlay somewhere, although it wasn't great | 19:13 |
| Saviq | karni, but would be good enough | 19:13 |
| karni | oh | 19:13 |
| * Saviq looks | 19:13 | |
| karni | you never stop surprizing me | 19:13 |
| Saviq | karni, https://code.launchpad.net/~cimi/unity8/carousel-music-video/+merge/192118 | 19:13 |
| karni | :D | 19:14 |
| Saviq | karni, you'd have to look it through and yank out the overlay support | 19:16 |
| * karni nod | 19:16 | |
| karni | thank you :) | 19:16 |
| Saviq | karni, shouldn't be crazy difficult, hopefully | 19:16 |
| karni | ^ ^ | 19:16 |
| * karni joins one sprint session | 19:17 | |
| Saviq | karni, but it won't look *great*, I'm afraid | 19:17 |
| Saviq | karni, actually maybe I have a better idea for a poor-man's overlay | 19:17 |
| Saviq | karni, give me a few mins, let's see what I can come up with | 19:18 |
| karni | Saviq: it's 20:00 in Poland (you work in Poland?), take it easy buddy! | 19:18 |
| karni | *from Poland | 19:18 |
| karni | My English sucks recently. | 19:19 |
| cwayne_ | lol karni telling people to not work late | 19:19 |
| karni | xD | 19:19 |
| cwayne_ | Saviq, hey, do sidestage bugs belong in unity8? or is there somewhere else more approrpriate | 19:23 |
| Saviq | cwayne_, yes, between unity8 and unity-mir | 19:23 |
| Saviq | cwayne_, ping greyback please, he's got a few on his radar, so as not to duplicate | 19:24 |
| cwayne_ | Saviq, awesome, thanks | 19:24 |
| greyback | cwayne: please log to unity8, and give them a "sidestage" tag so I can track them easily please | 19:24 |
| * greyback too polite sometimes | 19:24 | |
| cwayne_ | perfect, that's exactly what i was gonna do :) | 19:25 |
| greyback | cwayne: appreciated, thanks | 19:25 |
| karni | Saviq: with that pace, I'll get pulled back to phone delivery real soon haha | 19:26 |
| Saviq | karni, shall we slow down, eh? | 19:27 |
| cwayne_ | god no | 19:27 |
| cwayne_ | speed up so we can get karni back :P | 19:28 |
| karni | lol | 19:28 |
| Saviq | karni, you should be able to take it further: http://paste.ubuntu.com/6874946/ | 20:08 |
| Saviq | karni, just add «, "overlay": true» in the template (override in scope-tool works fine) | 20:10 |
| karni | xD | 20:11 |
| karni | Saviq: you pure awesomeness | 20:11 |
| karni | Have a good evening man :) Take it easy, thank you! | 20:12 |
| Saviq | karni, it looks like CardTool gets confused (implicitHeight binding loop in Card) for some reason | 20:15 |
| Saviq | karni, that might be why you're getting weird card heights | 20:15 |
| karni | Saviq: ACK. now go enjoy your evening :D | 20:16 |
| Saviq | karni, I'm thinking of going http://paste.ubuntu.com/6875018/ | 20:21 |
| Saviq | karni, it fixes the issue, all tests still pass | 20:22 |
| Saviq | karni, so yeah, it doesn't look great in Carousel, mostly because our carousel works "the other way around", meaning it scales items up instead of down | 20:24 |
| Saviq | karni, it also needs to only show the overlay on the current item in carousel, so we'll need a prop on Card | 20:25 |
| Saviq | karni, but yeah, I'll go now | 20:25 |
| * karni reads | 20:25 | |
| karni | Saviq: ^ ^ will check out the paste in a sec | 20:25 |
| karni | Enjoy your evening :) | 20:26 |
| tedg | bregma, Hey, so I have a branch where I was playing with implementing XDG Autostart as Upstart jobs. Would that be useful for your Unity8 session? | 21:27 |
| bregma | tedg, to do what? Autostart programs wit hthe session? | 21:28 |
| tedg | bregma, Yup, basically. | 21:29 |
| tedg | bregma, Basically do gnome-session's job without gnome-session. | 21:29 |
| bregma | tedg, yes, that sounds like one of the missing parts of the puzzle | 21:30 |
| tedg | bregma, So it's here, I hadn't really pushed to merge it because I didn't know if it was actually useful. But if it is, we can figure out that whole packaging thing: https://code.launchpad.net/~ted/upstart-app-launch/xdg-autostart/+merge/200545 | 21:32 |
| tedg | bregma, It is disabled by default so that you can make the adjustment per-session so that you don't screw up your whole machine :-) | 21:32 |
| bregma | I live for screwing up my machine | 21:33 |
| tedg | Then just make the suggested changes in /usr ;-) | 21:34 |
| tedg | bregma, Merged trunk and updated. Realized I hadn't in a while. | 21:40 |
| mhr3_ | tedg, so much upstart stuff, you're trying to make systemd migration hard, aren't you? :) | 21:48 |
| tedg | mhr3_, Heh, you've seen right through me. | 21:49 |
| tedg | Sure most of this stuff could work with systemd as well. Haven't tried though. | 21:50 |
| tedg | Is GNOME using Systemd in the user session yet? I know they'd talked about it, but not sure if it's happened. | 21:51 |
| mhr3_ | no idea | 21:53 |
| Saviq | karni, got time to look at the diffs? what do you think? | 21:57 |
| karni | Saviq: yes! they're fantastic | 21:58 |
| karni | I was about to send out an MP with your code lol. Or do you want to do the honors? I'm not taking credit! :D | 21:59 |
| Saviq | karni, just put it up | 21:59 |
| karni | ok | 21:59 |
| karni | Saviq: saw that shader implementation. slick, dude, slick! | 21:59 |
| karni | Saviq: I did it against new-scopes branch, that right? | 22:00 |
| Saviq | karni, nah, into trunk I think | 22:00 |
| karni | ack | 22:01 |
| karni | That'll be fun. I should actually approve that upcoming MP, it's your code haha. | 22:03 |
| karni | branching unity8, really slow | 22:04 |
| Saviq | karni, I'll ask Albert to review tomorrow | 22:08 |
| karni | Saviq: https://code.launchpad.net/~unity-team/unity8/unity8-card-overlay/+merge/204790 | 22:09 |
| Saviq | karni, thanks | 22:09 |
| karni | Saviq: I'll +1 it as comment, not top-approve then :) | 22:09 |
| karni | Saviq: thank YOU!! | 22:09 |
| Saviq | karni, there's definitely a few thing we need to fix there, though - it should only show up on the current item in Carousel, not all of them | 22:11 |
| Saviq | karni, and the height should probably be dynamic, based on maximum header size | 22:12 |
| Saviq | karni, and some margins, too | 22:12 |
| karni | only current item? I see.. I should find the doc with the spec | 22:13 |
| karni | laggy network | 22:13 |
| Saviq | karni, https://docs.google.com/a/canonical.com/file/d/0B-a_7E3tDxOgOHAwNEt1S2Zfa2s/edit | 22:13 |
| Saviq | karni, I'll look at it myself tomorrow again and leave things to fix as comments, will work on the preview first, though, so if you find time somewhen you can have a go, otherwise I'll tackle it later | 22:14 |
| karni | Saviq: sounds like a great plan! thanks so much, Saviq | 22:14 |
| karni | We really appreciate your work! | 22:15 |
| Saviq | karni, it's not that bad testing-wise, too, btw https://code.launchpad.net/~unity-team/unity8/new-scopes/+merge/198359/comments/478617 | 22:15 |
| * karni looks | 22:15 | |
| * karni nods. GenericScopeView would make sense to take on first, probably, once basic previews land | 22:17 | |
| Saviq | karni, yup | 22:19 |
| karni | Saviq: since you're here, I'll just ask one last question - that overlay should show when the item is centered in carousel, or fade-in as it shifts to foreground | 22:21 |
| Saviq | karni, fade in | 22:21 |
| karni | shit x) | 22:21 |
| Saviq | karni, easy - Behavior on opacity { NumberAnimation { duration: UbuntuAnimation.SnapDuration } } | 22:22 |
| Saviq | something like that | 22:22 |
| karni | oh, I thought fade in as it shifts to foreground | 22:22 |
| karni | tied to carousel position. | 22:22 |
| Saviq | karni, it will be | 22:23 |
| karni | that's easier :D | 22:23 |
| karni | oh hahaha | 22:23 |
| Saviq | and then property bool showHeader: true; opacity: showHeader ? 1 : 0 | 22:23 |
| * karni nods | 22:23 | |
| Saviq | karni, Carousel would override showHeader to be based on whether it's the current item | 22:23 |
| karni | that's still easier than I thought :) | 22:24 |
| karni | I thought it'd be bound to x position of the item being selected and it'd fade it as it shifts to center | 22:24 |
| Saviq | karni, http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-listview.html#isCurrentItem-prop should be enough here | 22:24 |
| karni | Saviq: you're making my life too easy ^o^ | 22:24 |
| Saviq | ;) | 22:24 |
| karni | Enjoy your evening :) | 22:25 |
| Saviq | karni, pushed a small commit ther | 22:35 |
| Saviq | e | 22:35 |
| karni | ack | 22:36 |
| Saviq | karni, pushed https://code.launchpad.net/~unity-team/unity8/newscopes-card-overlay/+merge/204797 too to ease work on the newscopes branch | 22:41 |
| tedg | So I upgraded and ended up in a bad place. | 22:41 |
| tedg | It seems compiz isn't drawing all the Unity stuff. | 22:41 |
| tedg | No panel, no launcher, etc. | 22:41 |
| karni | Saviq: +1 | 22:42 |
| tedg | But it is running and saying it's loaded the unity plugin. | 22:42 |
| karni | top approved | 22:43 |
| tedg | Looks like I have a daily build of Unity: 7.1.2+14.04.20140204.2-0ubuntu1 | 22:43 |
| Saviq | tedg, ppa:ubuntu-unity/daily-build ? | 22:45 |
| tedg | Saviq, Yeah | 22:45 |
| bschaefer | tedg, have you checked ccsm to make sure the plugin hasn't decided to unload it self? | 22:48 |
| karni | I'm exhausted, Michal, took notes. I'll try to addres some of those overlay comments this evening/tomorrow morning. | 22:49 |
| karni | We'll keep in touch. | 22:49 |
| tedg | bschaefer, Uhm, it had. | 22:49 |
| tedg | How is that possible? | 22:49 |
| bschaefer | tedg, there some sort of magic that goes on (some error handling im not familiar with, that causes it to unload it self) | 22:49 |
| bschaefer | tedg, i've never actually dug into the loading plugin part of compiz | 22:50 |
| tedg | Huh, okay. So then once it's gone, it's gone forever? | 22:50 |
| bschaefer | you should be able to re-enable it | 22:50 |
| tedg | Yeah, I did. I was more meaning it wouldn't reenable itself. | 22:51 |
| bschaefer | or its just not there at all? | 22:51 |
| bschaefer | nope | 22:51 |
| tedg | Joy. | 22:51 |
| bschaefer | once it unchecks it self, its never checked again | 22:51 |
| bschaefer | yeah | 22:51 |
| bschaefer | one of the fun joys of ccsm | 22:51 |
| tedg | Saviq, Don't implement that feature ^ | 22:51 |
| bschaefer | usually only happens after an update... | 22:51 |
| bschaefer | haha | 22:51 |
| Saviq | karni, no worries | 22:51 |
| * bschaefer suspects schema changes that cause issues | 22:52 | |
| tedg | Anyway, thanks bschaefer, wouldn't have thought that could happen. | 22:52 |
| bschaefer | tedg, yeah, and np! Thats become my number place to check when unity goes aways :) | 22:53 |
| bschaefer | number one* | 22:53 |
| mhr3_ | bschaefer, what did you do?! | 23:47 |
| bschaefer | mhr3_, what did I do! | 23:48 |
| mhr3_ | bschaefer, you can't see half of the map in dota... that's horrible! | 23:48 |
| bschaefer | i know :( | 23:48 |
| bschaefer | mhr3_, it makes the game a bit harder! | 23:48 |
| mhr3_ | ah, you like challenge | 23:48 |
| bschaefer | the real issue though, i have no clue some problem in opengl not wanting to fully render some textures | 23:48 |
| bschaefer | mhr3_, hows all your fun API work going? | 23:49 |
| mhr3_ | maybe some offset issue somewhere | 23:49 |
| mhr3_ | thinks it's clipped while it isn't | 23:49 |
| bschaefer | yeah, strangly it renders most of it fine... | 23:50 |
| Saviq | bschaefer, hard at work, eh? http://ubuntuone.com/5i6T94DYbrR62yez71DTeR | 23:50 |
| bschaefer | clipped sounds reasonable as well, the problem is like 90% of the other textures work | 23:50 |
| bschaefer | Saviq, haha, it was hard watching people play! | 23:50 |
| bschaefer | (its just spectator mode, i am not that good) | 23:51 |
| mhr3_ | bschaefer, that's intel btw? | 23:51 |
| bschaefer | mhr3_, no it was AMD | 23:51 |
| bschaefer | err | 23:51 |
| bschaefer | ATI | 23:51 |
| bschaefer | mhr3_, X11 works fine though | 23:52 |
| mhr3_ | i know it does :) | 23:52 |
| bschaefer | so it could either be in SDL rendering (something wrong with the opengl context given), mesa, or DOTA2 it self... | 23:53 |
| bschaefer | but | 23:53 |
| bschaefer | it seems to lean more on mir | 23:53 |
| bschaefer | mhr3_, on the plus side the FPS is the same on X11/mir | 23:53 |
| bschaefer | as i have an old old pc | 23:53 |
| mhr3_ | hmm, i thought games running mir natively would be faster than x | 23:54 |
| bschaefer | well i've not tested it intensively, it was just the game FPS meter... | 23:55 |
| bschaefer | soo its hard to tell when it fluctuates from 15 -> 25 FPS | 23:55 |
| mhr3_ | right | 23:55 |
| bschaefer | its at lease no worse | 23:55 |
| bschaefer | is all i could really conclude from that | 23:55 |
| mhr3_ | i'm sure a particular news site will soon publish benchmarks :) | 23:56 |
| bschaefer | mhr3_, its actually really annoying getting dota2 running atm (due to some issues in loading the game and libtogl) | 23:56 |
| bschaefer | it took me like 2 weeks to try to get it to work, theres also a bug in the mesa video driver | 23:57 |
| kklimonda | playing dota2 under unity is actually even more annoying | 23:57 |
| bschaefer | where it fails to have to correct API index for the context | 23:57 |
| kklimonda | ;) | 23:57 |
| bschaefer | i've not tried, but hopefully its not to bad! | 23:57 |
| kklimonda | the hud button (alt) minimizes the game | 23:57 |
| mhr3_ | oh yea, annoying as hell | 23:58 |
| kklimonda | I think the same with super key, I just rebound both to some other keys | 23:58 |
| bschaefer | kklimonda, you can use ccsm to disable those (i didn't say that out loud!) | 23:58 |
| mhr3_ | bschaefer, but anyway, great job, some thing still missing, but we'll get there :) | 23:58 |
| kklimonda | bschaefer: in 14.04 I have to restart unity for those changes to kick in :( | 23:58 |
| kklimonda | otherwise I'd just write some script to do that before I launch the game, and revert back later | 23:59 |
| bschaefer | kklimonda, hmm it should by dynamic...but if isn't you can always restart the interface | 23:59 |
| bschaefer | with out rebooting | 23:59 |
| kklimonda | yeah, I'm just restarting it | 23:59 |
| bschaefer | through setsid unity (in a terminal), or setsid compiz --replace ccp | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!