mterryelopio, well, I'm feeling like it's past EOD for me, let's look at this tomorrow00:06
elopiomterry: have a good night.00:26
elopioI'm trying to make the data mocks optional, but I think I broke something else because it is not working now. I'll better get some rest too.00:26
Saviqtsdgeos, hey, when you have some minutes for a review, https://code.launchpad.net/~saviq/unity8/new-preview/+merge/205086 - could use an opinion whether I should add more tests08:07
Saviqtsdgeos, I'll be away for about two hours, gotta run an errand08:07
Saviqalthough I'll try and look here08:07
tsdgeosbut first08:07
tsdgeosOMG we are green!08:07
Saviqtsdgeos, hold your horses! ;)08:08
Saviqtsdgeos, we're still not landing stuff ;D08:08
tsdgeossure but there's a green in the prairy08:08
tsdgeosspring is coming!08:08
tsdgeosSaviq: the tests look reasonable09:26
tsdgeosSaviq: i didn't do a more in depth review, just a few nitpicks and looking at the tests09:26
tsdgeostell me if you want me to do a bit of a deeper look09:26
tsdgeosdednick: https://code.launchpad.net/~nick-dedekind/unity8/indicator-client-profile-switch/+merge/203985 ?09:37
dednicktsdgeos: ah. cheers09:38
dednicktsdgeos: it's an optional arg.09:39
dednicknot really sure why it worked when i tested though..09:39
dednicktsdgeos: ah, right. because indexOf probably returned -1...09:40
tsdgeosthe if never returned true, no?09:40
dednicktsdgeos: it did. because the first is just contains, and args.size() > (-1 + 1)09:41
tsdgeosah right09:43
tsdgeosso can you fix it and add a test?09:44
tsdgeosi.e check that -profile foo gives you foo profile09:44
dednicktsdgeos: um, i think a test for this is a bit of overkill.09:52
dednicktsdgeos: testing a test ui...09:53
tsdgeoswell testing ui is all we do here :D09:54
dednicktsdgeos: IndicatorsClient is the "test app" we use to test indicators with autopilot.09:55
tsdgeosi mean can't you just fake passing stuff to IndicatorsClient and then check it got set?09:55
tsdgeosah, so you mean testing the test09:55
tsdgeosok, i can take that09:55
tsdgeosdandrader: can you do https://code.launchpad.net/~nick-dedekind/unity8/indicators.hint-interval/+merge/202104 ?10:21
tsdgeosdednick: there?10:41
dednicktsdgeos: i am10:41
dednickpysically. maybe not all mentally...10:41
tsdgeosdednick: i don't totally understand that profile switch, i see the profile propagates down from the client, but when not in the client where does the profile come from?10:42
tsdgeosdoes it come from ./qml/Panel/Indicators.qml and is just hardcoded to "phone" for the moment?10:43
dednicktsdgeos: it's hardcoded at the moment to use "phone" in qml/Panel/Indicators.qml10:43
tsdgeosdednick: maybe a TODO there saying "this should not be hardcoded"?10:43
dednicktsdgeos: aiight10:44
dednicktsdgeos: done10:47
tsdgeostwo greens, there are two greens https://jenkins.qa.ubuntu.com/job/unity8-ci/ \o/10:55
tsdgeosdednick: what's the name of the battery indicator?11:02
tsdgeosseems so11:04
Cimitsdgeos, which component shall I pick up next?11:16
tsdgeosgood question11:16
* tsdgeos opens the document11:16
tsdgeosCimi: rating?11:18
dednicktsdgeos: yeah, indicator-power11:18
Cimitsdgeos, ok11:19
tsdgeosSaviq: cimi does ratingS?11:23
Saviqtsdgeos, you tell me :)11:35
Saviqtsdgeos, looking at the app preview we're missing the header11:36
tsdgeoswhich header?11:36
Saviqtsdgeos, like in the card11:37
tsdgeosah i thought we had the card header already11:37
Saviqtsdgeos, there "top" header won't be a widget11:37
Saviqtsdgeos, we do11:37
tsdgeosbut doesn't understand json?11:37
Saviqtsdgeos, more or less, yes11:37
tsdgeosCimi: have you started already, if not maybe look at the header as Saviq says?11:39
tsdgeosif not, i'm almost done-ish with actions11:39
tsdgeosso i could take that one11:39
Cimitsdgeos, let me take both :)11:45
Cimitsdgeos, I have to go to the office though today, so bring something bigger11:45
Cimitsdgeos, zoomable image? :)11:45
Cimitsdgeos, I ant to do media player11:45
tsdgeosCimi: header is more important, since we *need* it now11:46
tsdgeosmedia player is more of a wish list i gather11:46
tsdgeosCimi: so let's focus on reusing the card header first, you can do it or i can do it, your call11:46
tsdgeosbut media player i'd say is something we don't need now (at least for the mockups i've seen)11:47
tsdgeosSaviq: ↑↑↑11:47
Saviqtsdgeos, Cimi, video player → later, we won't do video playback before we can do it out-of-process anyway11:47
Saviqlater == when we can play video out-of-process11:47
SaviqCimi, and zoomable image is not designed well yet11:48
SaviqCimi, since we don't know what to do when zooming (see my comments in the "future dash" spec)11:48
Cimitsdgeos, do header11:48
Cimitsdgeos, since it's more important11:48
Cimitsdgeos, I have a chat today with desktop team11:49
CimiI think about legacy etc11:49
Cimithey're in london11:49
Cimimight spend more time with them11:49
tsdgeosok, i'll do it11:49
CimiI'll do ratings11:49
SaviqCimi, tsdgeos, we do, though, need an image widget anyway, just not support the zoomable prop11:50
Saviqbut that should be rather simple11:50
tsdgeosSaviq: outside the image gallery?11:50
Saviqtsdgeos, hmm I think so, yes, just a single image11:51
* Saviq wonders if we should add more props for the Image - like aspect ratio, fill mode...11:51
CimiSaviq, aspect ration no11:52
CimiSaviq, fill mode definitely11:52
SaviqCimi, one without the other doesn't make much sense11:52
CimiSaviq, unless we state11:52
Cimi"we're going to support just this"11:52
Cimiso you plan things ahead and you're consistent11:53
Saviqok actually it looks like images are same height as gallery, so no need for any of those11:53
Saviqat least not now11:54
=== MacSlow is now known as MacSlow|lunch
dandradergreyback, would you like or have time to review this? https://code.launchpad.net/~dandrader/unity-mir/clipboard/+merge/20513512:16
greybackdandrader: that isn't as much code as I was expecting :) I can take it.12:19
dandradergreyback, great! thanks!12:19
greybackdandrader: for future we need to put the proto into a separate package/project12:20
dandradergreyback, not sure if the extra complexity is worth it, but it's indeed more correct12:21
dandradergreyback, just added the specific mir branch is depends on to the description as well12:22
=== dandrader is now known as dandrader|afk
greybackdandrader: ah good to know12:23
tsdgeosSaviq: you doing https://code.launchpad.net/~aacid/unity8/action_preview_widget/+merge/204998 ?12:23
Saviqtsdgeos, will do, yes12:23
Saviqtsdgeos, I'm adding a test for the onFocusChanged in new-preview12:23
Saviqtsdgeos, would like a real review when that's done12:23
Saviqtsdgeos, will  let you knw12:24
=== alan_g is now known as alan_g|lunch
CimiSaviq, this one is ready too now https://code.launchpad.net/~unity-team/unity8/unity8.previews_textSummary/+merge/20417712:40
SaviqCimi, k12:45
=== dandrader|afk is now known as dandrader
Saviqgreyback, FINALLY! congratz!12:52
Saviqrsalveti, congratz to you too, well deserved :)12:52
Saviqdidrocks, and you :)12:53
greybackSaviq: ta :)12:53
rsalvetiSaviq: thanks12:54
Saviqtsdgeos, shouldn't a Behavior on contentY make a ListView animate when positionViewAtIndex() is triggered?12:58
didrocksSaviq: thanks you, congrats greyback and rsalveti as well!13:07
rsalvetiyeah, congrats as well :-)13:08
=== MacSlow|lunch is now known as MacSlow
Saviqtsdgeos, https://code.launchpad.net/~saviq/unity8/new-preview/+merge/205086 ready13:19
karnigreyback: rsalveti: Congrats you guys!! Great job!13:28
greybackkarni: thanks :)13:31
greybackdidrocks: rsalveti: congrats to you both also13:31
=== alan_g|lunch is now known as alan_g
mhr3_Saviq, what do i need so have new previews? your new-previews branch i guess? :)14:04
tsdgeosSaviq: so this typo you had shows you probably need another test for PreviewWidgetFactory in which you don't overwrite the source?14:07
Saviqtsdgeos, probably14:08
Saviqtsdgeos, I didn't want to write one for the mapping... but yeah, will do14:08
tsdgeosit's a bit weird14:08
Cimigreyback, congrats, good time to come living in London14:08
tsdgeosas you're effectevily testing the switch14:08
=== rachelliu_ is now known as rachelliu
Saviqtsdgeos, exactly14:09
mhr3_Saviq, also, which widget types are supposed to be supported atm?14:09
tsdgeosSaviq: ok, ignore it then14:09
Saviqtsdgeos, no, but we need it14:09
Saviqtsdgeos, will add, it's a simple test14:09
Saviqmhr3_, audio, gallery, text and actions, header is in the works14:10
greybackCimi: thanks! Just need a few more of them and I'd be able to afford to live in London :)14:10
Saviqtsdgeos, Cimi, we'll need the progress widget, too14:15
tsdgeosSaviq: do we want to use it as the docu says or?14:15
tsdgeosi mean the docu says an action button that automagically turns into a progress bar14:15
* Cimi loves his IRC notifications on the watch when I have laptop closed14:15
Cimithis is just awesome!14:16
SaviqCimi, open your laptop this instance14:16
SaviqCimi, you're at work, remember?14:16
CimiSaviq, just back from lunch14:16
Saviqtsdgeos, no, separate widget14:16
CimiSaviq, it's 14 here14:16
SaviqCimi, you close your laptop over lunch?!14:16
CimiSaviq, standby14:16
tsdgeosSaviq: ok14:16
CimiI close the lid14:17
dandradergreyback, didn't get your "rpc for copy" comment14:17
dandradergreyback, you're suggesting "service UnityService { message copy .... }" (don't even know if that construct exists)?14:18
paulliuSaviq: I don't mind to take the progress widget .14:18
CimiSaviq, ZNC -> pushover -> android -> pebble14:19
Saviqpaulliu, ah, I wasn't exactly sure what're you doing these days, thought you were helping folks closer to the backends?14:19
SaviqCimi, yes, I know you're into your watches ;)14:19
paulliuSaviq: yes. And now I should help to get the previews componentized done.14:20
Saviqpaulliu, ok cool, start with Image, then14:20
paulliuSaviq: got it.14:21
Saviqpaulliu, look at one of the approved widgets in https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews14:21
greybackdandrader: well first off if a client calls copy(), could it fail? Does client care if copy() fails?14:21
paulliuSaviq: seems your branch (previews_audioPlayer) is not yet merged.14:21
Saviqpaulliu, you want to base your new widget off of lp:~unity-team/unity8/unity8.previews_audioPlayer branch14:21
paulliuSaviq: ok14:21
Saviqpaulliu, that's Cimi's14:21
Cimiinternet at home: 152Mbps/12, office, 12/1014:21
dandradergreyback, well, theoretically any rpc call can fail14:21
Saviqpaulliu, and no branches are merged as CI Train is stopped14:21
paulliuSaviq: ok.. got it.14:21
CimiSaviq, when will it get merged?14:22
dandradergreyback, but we surely don't care if the copy() fails at this point14:22
Saviqtsdgeos, https://code.launchpad.net/~aacid/unity8/action_preview_widget/+merge/204998/comments/47976514:22
dandradergreyback, as for the Void thing, I was just following the idiom used in mir14:22
SaviqCimi, I hope to get a slot today14:22
SaviqCimi, it's not entirely my call :/14:22
greybackdandrader: aha ok.14:22
dandradergreyback, but the error field is optional, you know14:23
CimiSaviq, I'm in the office, shall I push someone in the desktop team or CI? :)14:23
dandradergreyback, if you don't set it, it won't bet sent14:23
CimiI can be annoying :D14:23
tsdgeosSaviq: ok14:23
greybackdandrader: it was confusing me, using these rpc calls for something that look like a single message14:23
dandradergreyback, well, that's how it's done in protobuf as far as I known: you have a service and inside it a number of rpc functions14:24
dandradergreyback, and each rpc function necessarily takes a message in and sends back another message14:25
Saviqdidrocks, any chance for a landing slot for unity8 today?14:25
dandradergreyback, and you can use the return message to at least know that the rpc was successful (server received and acked it)14:25
greybackdandrader: rpc is a message + a reply, no?14:25
dandradergreyback, yes14:26
greybackdandrader: for copy, do we need the reply?14:26
dandradergreyback, a request message and a result message14:26
greybackis always having a reply good practice?14:26
tsdgeosSaviq: i thought i had to pass back my own data on a button click, so no data for buttons?14:26
Saviqtsdgeos, no14:26
Saviqtsdgeos, data is only for additional data14:27
dandradergreyback, we need so that we know that it has been received. i.e., that the rpc is complete14:27
dandraderalan_g, ^^^^14:27
tsdgeosSaviq: i am not sure i understand what you mean with "Can we override the clicked() signal to send just the action id?"14:27
Saviqtsdgeos, instead of a new signal14:27
Saviqtsdgeos, can we do signal clicked(string id)?14:27
dandradergreyback, alan_g is our protobug expert14:27
tsdgeosSaviq: but didn't we say we wanted to call it triggered?14:28
Saviqtsdgeos, Button already has a signal clicked()14:28
Saviqtsdgeos, higher up, yes14:28
tsdgeoslet me see14:28
Saviqtsdgeos, but button is clicked, action is triggered14:28
tsdgeosnot sre how happy is qml with overrriden signal names tbh14:28
greybackdandrader: yes, best to ask him14:28
Saviqtsdgeos, hence the ? :)14:28
Saviqtsdgeos, the result itself is sent with actions, on top of that we only need widget and action id, and any data (rating, review, progress status etc.)14:29
alan_gWe've used protobuf to implement rpc from the client and messaging from the server. Stepping outside that needs additional work14:30
Saviqdednick, standup14:32
Saviqkgunn, kudos ;)14:34
didrockssil2100: can you assign for Saviq? ^14:39
sil2100Saviq: is the landing ready?14:39
Saviqdidrocks, sil2100, no, not yet - was just asking whether we're landing again?14:39
mterryOh, I meant to ask in the meeting.  elopio and I are seeing that when the mock Unity plugin is used during AP tests, url-dispatcher doesn't work right.  Presumably due to applicationmanager?  Does anyone know off the top of their heads why that would be?14:39
mterrySaviq, mzanetti ^14:39
sil2100Saviq: we're landing now ;) We had a green image in the morning so we're ok14:39
Saviqsil2100, didrocks yay :)14:40
Saviqsil2100, didrocks can we have a silo for unity-mir then?14:40
greybackalan_g: my query was more of a "best practice" inquiry with protobuf. He implemented copy/paste with protobuf. I was questioning if "copy" needs to be an rpc call, or if simply a "message" would do - i.e. would a client ever care if the copy call failed?14:40
Saviqsil2100, line 4214:40
mzanettimterry: hmm... no, not really14:40
karniSaviq: re: overlay height - katie's comment isn't conclusive to me. "header height would be the same as a non-overlaid header". Would you say she's aware that title only 2-line header is shorter than title only 1-line header?14:40
didrocksSaviq: yeah, we are landing14:41
mzanettimterry: but... is it using the mock applicationmanager plugin?14:41
greybacktbh, I suppose silent fails are bad14:41
Saviqkarni, probably best ping here in #design on i.c.c14:41
karniI'll do that14:41
mterrymzanetti, among others yeah14:42
mzanettimterry: yeah, the fake appmanager doesn't connect to upstart or anything14:42
mzanettimterry: it has a hardcoded list of apps it knows14:42
mterrymzanetti, url-dispatcher doesn't seem to go through upstart?14:42
alan_ggreyback: "copy" needs to be an RPC call because it happens client side and the existing support in Mir is for RPC on the client and messaging on the server.14:42
mzanettimterry: I suppose you want to start an app, right?14:43
mterrymzanetti, yeah14:43
mzanettiyeah, that goes from url-dispatcher to upstart, and from there to unity-mir.14:43
mzanettithe fake appmanager in unity8 doesn't listen to that14:43
mzanettiand hence doesn't actually start the app14:44
greybackalan_g: just what I needed to know, thank you14:44
* mterry isn't convinced that it actually goes through upstart14:45
Saviqmterry, it does14:45
Saviqmterry, upstart-app-launch14:45
mterryif that were true, we wouldn't be seeing the bug from nested mode we did see14:45
Saviqmterry, that was dbus-dispatched, right?14:45
mterrywhere we had to add MIR_SOCKET to dbus's environment (it was already in upstart's environment)14:45
sil2100Saviq: ok, let me assign that14:45
mterrySaviq, via url-dispatcher14:46
Saviqmterry, well, they're definitely upstart-managed, that's for sure14:46
Saviqmterry, (see all the logs in .cache/upstart/)14:46
* mterry wonders how this needs dbus's environment then14:46
Saviqtedg, can you shed some light on this ↑14:46
* mzanetti goes for a run as long as the sun is shining. bbiab14:47
tedgI'm a little confused14:47
elopioI'm sorry I missed the stand up.14:48
mterrytedg, so we had a bug where url-dispatched apps didn't work in nested mode14:48
tedgSo url-dispatcher definitely uses upstart.14:48
elopiobut I just worked with mterry yesterday, so that's already on the log.14:48
* elopio listens carefully.14:48
mterrytedg, adding the correct MIR_SOCKET to dbus's environment fixed that14:48
mterrytedg, now I'm wondering why if url-dispatcher just uses upstart14:48
tedgmterry, Was the proper MIR_SOCKET set in the global upstart env?14:49
mterrytedg, yes14:49
mterrytedg, other upstart launches worked14:49
mterrytedg, only url-dispatcher was busted14:49
sil2100Saviq: ok, silo assigned - just make sure you check that all the MR's written down are MR's not branches ;) THere was one there14:49
tedgmterry, That's definitely weird.  Just because URL dispatcher is kinda simplistic.14:50
tedgmterry, It doesn't set any environment other than the URI.14:50
mterrytedg, let me double confirm it's not specific to click scope then14:52
tedgmterry, You can throw the glib debug messages flag into URL dispatcher and it'll print out every URL it gets.14:52
mterrytedg, (click scope was launching the url-dispatcher)14:52
tedgI'm hoping Upstart launches it, and click scope calls it :-)14:53
mterrytedg, so click scope is calling settings:///system/online-accounts14:54
mterrytedg, which when I call manually on command line is also busted in nested mode14:55
mterrytedg, but what happens is settings comes up14:55
mterrytedg, then a second accounts window comes up busted14:55
mterrytedg, only the second window is busted14:55
* mterry wonders what the heck system-settings is doing14:55
mterryseb128, ^14:56
seb128mterry, howdy14:56
seb128mterry, do I need to read backlog or can you summarize the question?14:56
mterryseb128, how does system-settings handle url-dispatches?  It seems to open a second accounts window via dbus instead of upstart?14:56
mterryseb128, like14:56
mterryurl-dispatcher settings:///system/online-accounts14:57
seb128mterry, online accounts is special, they are a different app than system settings14:57
mterryseb128, that line gives me two windows14:57
tedgmterry, Can you try with clock or something else just to see if it's a settings thing or not?14:57
mterryseb128, curious14:57
seb128mterry, right14:57
mterrytedg, it's just settings14:57
mterrytedg, you can go now, thanks  ;)14:57
seb128mterry, the experience relies on Mir work that is not there yet, same as content picker14:57
tedgHeh, okay14:57
mterryseb128, it's launched via dbus?14:58
tedgGood luck seb128, remember no hits below the belt.14:58
mterryelopio, sounds like the test needs system-settings then.   It's the only one that does this dbus-launching thing14:59
seb128mterry, https://code.launchpad.net/~mardy/ubuntu-system-settings/plugin-invocation/+merge/17692914:59
mhr3_Saviq, what's still missing to hook things up with the new preview? atm it's still trying to use the old renderers14:59
mterryelopio, and specifically the online acccounts plugin14:59
elopiomterry: that's easy, but will add a new dependency.15:00
mterryelopio, yeah  :-/  Plus, we'd still be fighting the mocks15:00
* elopio tries to see if this time it gets the focus.15:00
mterryelopio, we need just a package of system-level AP test15:00
tsdgeosSaviq: "Duplicate signal name: invalid override of property change signal or superclass signal"15:01
elopiomterry: that, and a way to reproduce this dbus launching without the real system settings.15:03
seb128mterry, you better ask kenvandine or mardy about the online account15:03
elopiobut we have now added like 6 new tests to the backlog. Lets finish this one first.15:03
mterryelopio, good news15:04
=== dandrader is now known as dandrader|lunch
seb128mterry, is your issue similar to https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings-online-accounts/+bug/1273781 ?15:04
mterryelopio, using settings:// does not mind the mocks15:04
ubot5Launchpad bug 1273781 in ubuntu-system-settings-online-accounts (Ubuntu) "If you open the accounts page in the settings app and close it you can't reopen it" [Undecided,Confirmed]15:04
mterryseb128, the issue I see with nested mode is that the accounts window tries to connect to the system compositor instead of unity8, so it can't be swiped away or such15:05
mterryelopio, so we could certainly add a dependency for this test...  But it seems heavy handed15:05
elopiomterry: the project that will hold ubuntu-level tests is not ready. Would it be ok to have it in unity for now, and move it later?15:08
mterryelopio, I'm personally OK with it15:09
mterrymzanetti, how bad is it to add a dep on system-settings for a unity8 AP test?15:09
elopiomterry, mzanetti: system settings, and online accounts.15:09
elopiotedg: I have some questions. Still around?15:10
tedgelopio, Sure, what's up?15:11
elopiotedg: I would like to launch with URL dispatcher an application I create during a test setup.15:11
elopioso it won't be installed. Can I launch qmlscene with my own QML file?15:12
tedgelopio, Will it have a desktop file?15:13
tedgI guess, let me say it another way. You need a desktop file :-)15:13
elopiotedg: it can have one, but not on /usr/15:13
tedgSure, but in ~/.local/share/applications15:13
elopiotedg: sure, I can put it there without problems.15:14
elopioso, should I give url dispatcher the name of that desktop file?15:14
tedgelopio, Yes, so you can give it: application:///foo.desktop15:14
elopiothat's pretty good, thanks :)15:14
tsdgeosSaviq: does signalspy have a cleanup function?15:14
elopiotedg: the other thing I want to do is to mock url-dispatcher, so on the click scope test, I only check that we send the right URL. Is there a documentation of the dbus API so I can write the dbusmock?15:15
tedgelopio, Don't tell your boss how easy it is ;-)  http://bazaar.launchpad.net/~indicator-applet-developers/url-dispatcher/trunk.14.04/view/head:/data/com.canonical.URLDispatcher.xml15:16
tedgelopio, Are you using dbus-test-runner's dbus-mock support?15:17
elopiotedg: no, autopilot + python-dbusmock.15:18
mterryelopio, so I'm going to test your unity8 test with the online account swapped in for camera-app, will let you know how it goes15:18
tedgelopio, Ah, so a full system test.15:18
elopiomterry: thanks. I'm also trying it on my phone before updating the branch.15:18
elopiotedg: yes. Well, not full for now because we are isolating the external dependencies.15:19
mhr3_tsdgeos, are you aware of a branch that hooks up the new previews?15:20
tedgelopio, Interesting, we use dbusmock in our unit tests for URL Dispatcher.15:20
mhr3_tsdgeos, don't see anything in active mps15:20
tedgelopio, You could steal that code :-)15:20
tsdgeosmhr3_: not really, https://code.launchpad.net/~saviq/unity8/new-preview/+merge/205086 is the closest thing i'd say15:20
mterryelopio, huh, now I get same result with mocks not letting the app show15:20
tedgelopio, http://bazaar.launchpad.net/~indicator-applet-developers/url-dispatcher/trunk.14.04/view/head:/tests/lib-test.cc15:21
mhr3_tsdgeos, yea, that's the one i'm running15:21
tsdgeosbut yeah, doesn't hook it up yet15:21
elopiotedg: right, I will :) Then I can tell my boss I had to do nothing because you had it all covered.15:21
=== alan_g is now known as alan_g|tea
elopiomterry: for one run, I could see the camera on top.15:23
elopiobut even then, it wasn't updating the current focused app property.15:24
elopioback to the start...15:24
=== greyback is now known as greyback|away
=== alan_g|tea is now known as alan_g
elopiomterry: with the mocks, I get a white screen being opened. Without the mocks, I get system settings, not online accounts.15:32
elopiocuriouser and curiouser.15:32
elopiomzanetti: where's the code for the real app-manager?15:40
tsdgeosunity-mir i think15:44
Saviq_sil2100, man, sorry about that15:54
Saviqmhr3_, https://code.launchpad.net/~unity-team/unity8/new-scopes/+activereviews15:55
Saviqmhr3_, https://code.launchpad.net/~unity-team/unity8/newscopes-preview/+merge/20502915:56
Saviqmhr3_, I hope to land the prereqs today, so that tomorrow we get it all into new-scopes15:56
didrocksSaviq: btw, you will get candies once unity-mir lands :)15:59
mhr3_Saviq, we're getting somewhere :) http://imgur.com/uMZwsfB15:59
tsdgeospete-woods: so i still need https://code.launchpad.net/~pete-woods/ubuntu-ui-toolkit/handle-quit-action so that the hud quit works, right=15:59
Saviqmhr3_, w00t!15:59
Saviqthostr_, ↑↑15:59
mhr3_Saviq, it's missing text field though15:59
Saviqmhr3_, "text field"?16:00
mhr3_i pushed gallery, actions, text, audio16:00
pete-woodstsdgeos: yes, but that just adds it to the toolbar16:00
=== dandrader|lunch is now known as dandrader
Saviqmhr3_, will have a look16:00
pete-woodstsdgeos: there's also the ubuntu-ui-toolkit component to land16:00
tsdgeospete-woods: what do you mean it adds it to the toolbar?16:00
pete-woodstsdgeos: doesn't your unity8 change add the quit action to the toolbar?16:01
pete-woodsbefore that it will just live in the actions list16:01
Saviqdidrocks, oh candies? why's that?16:01
tsdgeospete-woods: yes, i am saying that i need https://code.launchpad.net/~pete-woods/ubuntu-ui-toolkit/handle-quit-action/+merge/203964 for it to actually quit, no?16:01
pete-woodstsdgeos: sorry, yes, you're correct, I misunderstoof16:01
pete-woods*misunderstood, even16:01
tsdgeospete-woods: ah, no worries, bool then16:01
tsdgeosbool -> cool16:02
Saviqdidrocks, btw, any idea why SSO with the jenkins instance is so weird? Like I can press "build" and only then will it go through SSO, and then ask about the details every time16:02
didrocksSaviq: there is ricmm's fix for enabling registering an application which failed at startup :)16:02
Saviqdidrocks, ah yeas16:02
didrocksSaviq: yeah, I don't know, I tried to poke IS about it16:02
didrocksSaviq: just so that you feel better, I can tell you "you're not alone" :p16:02
Saviqdidrocks, not sure I feel better ;)16:02
Saviquh, conflict :/16:03
didrocksI tried so hard though!16:03
Saviqand tvoss not around16:03
didrocksSaviq: want to remove one MP?16:03
didrockswe can reconfigure16:03
Saviqdidrocks, no, want to fix it ;)16:03
didrocksif the branch name is ~tvoss, that would be hard ;)16:03
mhr3_Saviq, no, my bad... pushed it as "txt" instead of "text"... all good (minus the spinner)16:04
Saviqmhr3_, yeah, spinner should go away, not sure why it doesn't, but then again it was pretty late yesterday when I wrote it and could not test :)16:05
Saviqmhr3_, can you switch between previews fine?16:05
mhr3_Saviq, hmm.. would need more than one result to tell :)16:05
Saviq↑cool glasses16:06
seb128kenvandine, mardy: can we get a gnome-control-center-signon upload?16:10
seb128unity-control-center is needing the update16:11
mhr3_Saviq, ok added another result, i can swipe to it, but there is some weirdness, the previews opens correctly only for the first result, if i try to open it from the second it displays just blank preview16:11
pete-woodstsdgeos: I've just updated that ubuntu-ui-toolkit branch now I can actually test it properly16:11
Saviqmhr3_, ok, we're getting there16:12
tsdgeospete-woods: oki, you know where my branch is, right?16:12
pete-woodstsdgeos: yes, I've linked it to the overall bug, I already tested that part, and I'm certain it works16:12
Saviqmhr3_, if I can get the scope, I'll start fixing those16:13
Saviqmhr3_, btw, just remembered - how do we handle previews that should come as responses to activation? where do I get the model?16:13
mhr3_Saviq, we'll handle that somehow via the stack16:14
mhr3_Saviq, it will either update the current preview or add a new one16:14
mhr3_Saviq, and i'm actually using the mock test scope from unity-scopes-shell16:14
Saviqmhr3_, I meant result activation, sorry16:17
Saviqmhr3_, not actions16:17
karniSaviq: sorry to bug you, tring to pull multiple parties into a meeting :) got couple minutes?16:17
mhr3_Saviq, oh yea, still possible, but more explicit, the activation will come back with "do preview instead"16:25
mhr3_Saviq, and i guess i'll just emit that as a signal16:26
mhr3_Saviq, will be better for you that way i think?16:26
Saviqmhr3_, otp, gimme a minute please16:26
mhall119Saviq: does Unity8 use the same theme/theming funcitonality as the SDK components?17:00
Saviqmhall119, yes17:00
Saviqmhall119, but not extensively17:01
Saviqmhall119, so for every thing someone would want themable, we need to make it happen17:01
mhall119ok, but if the defaul SDK theme itself were to gain some ability to just change things like colors, would Unity8 automatically pick them up?17:02
=== shiznix_ is now known as shiznix
mhr3_mhall119, could you update the scopes docs again pls?17:03
mhr3_mhall119, link coming up17:03
mhall119mhr3_: was just about to ask for that :)17:04
mhall119mhr3_: we're about to break for lunch, I'll upload them after17:04
mhr3_mhall119, http://people.canonical.com/~mhr3/scopes.tgz17:04
mhr3_mhall119, btw the dir name changed17:04
mhr3_mhall119, if you can upload it to the old it'd be great, cause people bookmarked that already17:05
mhall119I'll take a look17:05
=== dandrader is now known as dandrader|afk
Saviqsil2100, ok, can we have a silo for unity8, too?17:20
Saviqsil2100, or actually... maybe we should merge the two landings?17:20
Saviqsil2100, one includes the TestPlan for the other anyway17:20
=== greyback|away is now known as greyback
Saviqdidrocks,  ↑17:21
didrocksSaviq: sounds good to me to merge them17:22
* Saviq does17:22
didrocksSaviq: tell us when you are ready :)17:22
didrocksI guess that will be first Mirv's assignement17:22
didrocksSaviq: btw: http://ci.ubuntu.com/smokeng/trusty/touch/maguro/167:20140206.1:20140115.1/6480/unity8-autopilot/741839/17:22
didrocksnot sure if it's due to new AP17:22
didrocksor a flaky test/behavior17:22
Saviqdidrocks, not sure either, will have to investigate - didn't see that before17:23
didrocksSaviq: ok, I asked plars to rerun it to get more infos17:23
Saviqdidrocks, ok, line 42 can be reconfigured17:24
Saviqdidrocks, and line 52 can be removed17:24
MirvSaviq: ok, thanks for merging17:27
MirvSaviq: there's a 'comment' link in the proposal list...17:31
MirvSaviq: fixing17:31
MirvSaviq: ok done, silo reconfigured17:35
mhr3_Cimi, ping17:48
mhr3_Cimi, ping217:48
=== alan_g is now known as alan_g|EOD
SaviqMirv, man, sorry, that thing needs to be validated somehow...18:01
Saviq didrocks, 2014-02-06 17:48:37,988 INFO === Trying to prepare unity8 ===18:01
Saviq 2014-02-06 17:48:38,155 INFO Branching https://code.launchpad.net/~mir-team/unity-mir/trunk to unity-mir18:02
Saviqdidrocks, looks like some label got mixed up - unity8 vs. unity-mir18:02
SaviqMirv, can you please reconfigure row 42? I had to resubmit a conflicting merge18:02
Saviqand kick build after it's reconfigured...18:03
karniSaviq: I need a quick tip :( I was hoping I'd pull CardHeader height from CardTool, so it's fixed (and not affected whether title is wrapped or not). Is that the right way to do it? Doesn't weem to work.18:04
karniDoes that make sense? http://paste.ubuntu.com/6886636/18:06
=== dandrader|afk is now known as dandrader
karniSaviq: nvm, works great :)18:22
=== vila_ is now known as vila
karniSaviq: WIP -> needs review19:14
mhall119Saviq: http://ubuntuone.com/1cCsRpYVBbAMWn5ZogzTH719:36
ubot5Launchpad bug 1277232 in Indicator Date and Time "indicator icon and event icons within the indicator use wrong icon" [Undecided,New]19:39
Saviqmhall119, oh yay20:42
SaviqMirv, are you still there?20:51
karniready: https://code.launchpad.net/~unity-team/unity8/new-scopes-title-alignment/+merge/20467720:52
Saviqkarni, conflict20:55
Saviqkarni, and not "titleAlignment" but "headerAlignment"20:55
karniI should really take it easy *sighs*21:11
elopiomterry: I got it working once, with online accounts on top and everything.21:12
elopionext time I run it, it breaks. If I wait a lot, I get a white screen.21:12
mterryelopio, :(21:13
elopioI'm seing this bug:21:13
ubot5Launchpad bug 1252294 in unity-mir "Application window appears in the background" [High,Confirmed]21:13
mterryelopio, you mentioned we might get a general component to put system-integration AP tests in soon?21:13
mterryI'm assuming that would help us (no running mock stuff)21:14
elopiomterry: omer is working on it. https://code.launchpad.net/~om26er/ubuntu-autopilot-tests/ubuntu-integration-tests21:15
Saviqkarni, you need to scale down the header in CardCarousel (by selectedScaleFactor)21:16
elopiomterry: yes, I'll start moving this tests with online accounts there. But I think we should have one inside unity that opens a fake application using url dispatcher. Don't you think so?21:16
Saviqkarni, again, 'cause we're scaling up instead of down21:16
mterryelopio, didrocks gave go-ahead on landing nested support as long as we have a short-term plan for landing AP tests21:16
mterryelopio, so maybe we wait for that for the full online-accounts bit21:16
mterryelopio, for launching a fake application using url dispatcher, sure.  That'd be nice to have in unity821:17
mterryelopio, but that isn't a must-have for me like the online-accounts is/was21:17
elopiomterry: yeah, you can tell didrocks that we have identified all the boundaries, I will be adding some tests for those boundaries and reporting bugs for the ones I can't make, and put the unity+mir+url dispatcher+online accounts tests on ubuntu-integration-tests21:19
Saviqkarni, small optimization: http://paste.ubuntu.com/6887632/21:19
elopiosounds like a good short-term plan, right?21:19
mterryelopio, yeah, thanks!  I appreciate your help in all this21:19
karniSaviq: thank you21:21
elopiomterry: no problem. I appreciate your help too, now I understand many more things.21:21
elopiomterry: what we still need to define is how often those ubuntu-integration-tests are going to be run, and how to share the load of checking their failures.21:21
mterryelopio, that last bit is an interesting one  :)21:21
elopioI'm scared that if we just add many tests, we will spend half of our day figuring out what went wrong.21:21
elopioand excercising a real ubuntu image, we have too many failure points21:22
karnipushed your patch, Michal21:30
karni(tring not to cause you highlight anymore :P)21:31
karnione-liner for anyone https://code.launchpad.net/~unity-team/unity8/unity8-silence-typeerror/+merge/20526621:36
* karni marked title alignment WIP, fixing a test21:36
elopiomterry: is there a way to wait until the application is fully loaded?22:02
elopioif I try to swipe it away while it's loading, funny things happen.22:02
mterryelopio, uh, other tests just seem to wait if it's the focused app22:03
elopiomterry: that's not enough.22:04
mterrygreyback ^22:05
elopiomterry: nevermind. Actually, the problem was that we are not swiping until the middle.22:09
Saviqkarni, implicitHeight is changed in https://code.launchpad.net/~unity-team/unity8/unity8-card-overlay/+merge/20479022:56
Saviqkarni, indeed it doesn't shrink - IIUC there's a binding loop that's interrupted and that's why implicitHeight is not updated22:56
Saviqkarni, so when that gets merged, stuff should be better again22:58
Saviqkarni, as for the tests, which ones fail for you?22:58
karnisorry, didn't notice your msg23:03
karniNoSummary and HorizontalNoSummary23:04
karnibut I think any that exercise card height would fail23:04
karniSaviq: ^23:04
karniwhich would be true, because these are the only two exercising height haha23:04
karniSaviq: gotta run. thanks for having a look at that. I need to learn more about binding loops, that can sometimes suck. funny enough, I came up myself with the fix that already was (written by you) in the overlay branch.23:09
karniHave a good evening!23:09
Saviqkarni, o/23:10

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!