| mterry | elopio, well, I'm feeling like it's past EOD for me, let's look at this tomorrow | 00:06 |
|---|---|---|
| elopio | mterry: have a good night. | 00:26 |
| elopio | I'm trying to make the data mocks optional, but I think I broke something else because it is not working now. I'll better get some rest too. | 00:26 |
| Saviq | tsdgeos, hey, when you have some minutes for a review, https://code.launchpad.net/~saviq/unity8/new-preview/+merge/205086 - could use an opinion whether I should add more tests | 08:07 |
| Saviq | tsdgeos, I'll be away for about two hours, gotta run an errand | 08:07 |
| tsdgeos | oki | 08:07 |
| Saviq | although I'll try and look here | 08:07 |
| tsdgeos | but first | 08:07 |
| tsdgeos | OMG we are green! | 08:07 |
| Saviq | tsdgeos, hold your horses! ;) | 08:08 |
| Saviq | tsdgeos, we're still not landing stuff ;D | 08:08 |
| tsdgeos | sure but there's a green in the prairy | 08:08 |
| tsdgeos | spring is coming! | 08:08 |
| tsdgeos | :D | 08:08 |
| tsdgeos | Saviq: the tests look reasonable | 09:26 |
| tsdgeos | Saviq: i didn't do a more in depth review, just a few nitpicks and looking at the tests | 09:26 |
| tsdgeos | tell me if you want me to do a bit of a deeper look | 09:26 |
| tsdgeos | dednick: https://code.launchpad.net/~nick-dedekind/unity8/indicator-client-profile-switch/+merge/203985 ? | 09:37 |
| dednick | tsdgeos: ah. cheers | 09:38 |
| dednick | tsdgeos: it's an optional arg. | 09:39 |
| dednick | not really sure why it worked when i tested though.. | 09:39 |
| dednick | tsdgeos: ah, right. because indexOf probably returned -1... | 09:40 |
| tsdgeos | yes | 09:40 |
| tsdgeos | the if never returned true, no? | 09:40 |
| dednick | tsdgeos: it did. because the first is just contains, and args.size() > (-1 + 1) | 09:41 |
| tsdgeos | ah right | 09:43 |
| tsdgeos | so can you fix it and add a test? | 09:44 |
| tsdgeos | i.e check that -profile foo gives you foo profile | 09:44 |
| dednick | tsdgeos: um, i think a test for this is a bit of overkill. | 09:52 |
| dednick | tsdgeos: testing a test ui... | 09:53 |
| tsdgeos | well testing ui is all we do here :D | 09:54 |
| dednick | tsdgeos: IndicatorsClient is the "test app" we use to test indicators with autopilot. | 09:55 |
| tsdgeos | i mean can't you just fake passing stuff to IndicatorsClient and then check it got set? | 09:55 |
| tsdgeos | ah, so you mean testing the test | 09:55 |
| tsdgeos | ok, i can take that | 09:55 |
| tsdgeos | dandrader: can you do https://code.launchpad.net/~nick-dedekind/unity8/indicators.hint-interval/+merge/202104 ? | 10:21 |
| tsdgeos | dednick: there? | 10:41 |
| dednick | tsdgeos: i am | 10:41 |
| dednick | pysically. maybe not all mentally... | 10:41 |
| tsdgeos | dednick: i don't totally understand that profile switch, i see the profile propagates down from the client, but when not in the client where does the profile come from? | 10:42 |
| tsdgeos | does it come from ./qml/Panel/Indicators.qml and is just hardcoded to "phone" for the moment? | 10:43 |
| dednick | tsdgeos: it's hardcoded at the moment to use "phone" in qml/Panel/Indicators.qml | 10:43 |
| tsdgeos | ok | 10:43 |
| tsdgeos | dednick: maybe a TODO there saying "this should not be hardcoded"? | 10:43 |
| dednick | tsdgeos: aiight | 10:44 |
| dednick | tsdgeos: done | 10:47 |
| tsdgeos | tx | 10:49 |
| tsdgeos | two greens, there are two greens https://jenkins.qa.ubuntu.com/job/unity8-ci/ \o/ | 10:55 |
| tsdgeos | dednick: what's the name of the battery indicator? | 11:02 |
| tsdgeos | indicator-power? | 11:04 |
| tsdgeos | seems so | 11:04 |
| Cimi | tsdgeos, which component shall I pick up next? | 11:16 |
| tsdgeos | good question | 11:16 |
| * tsdgeos opens the document | 11:16 | |
| tsdgeos | Cimi: rating? | 11:18 |
| dednick | tsdgeos: yeah, indicator-power | 11:18 |
| Cimi | tsdgeos, ok | 11:19 |
| tsdgeos | Saviq: cimi does ratingS? | 11:23 |
| Saviq | tsdgeos, you tell me :) | 11:35 |
| Saviq | tsdgeos, looking at the app preview we're missing the header | 11:36 |
| tsdgeos | which header? | 11:36 |
| tsdgeos | E_TOO_MANY_HEADERS | 11:37 |
| Saviq | tsdgeos, like in the card | 11:37 |
| tsdgeos | ah i thought we had the card header already | 11:37 |
| Saviq | tsdgeos, there "top" header won't be a widget | 11:37 |
| Saviq | tsdgeos, we do | 11:37 |
| tsdgeos | but doesn't understand json? | 11:37 |
| Saviq | tsdgeos, more or less, yes | 11:37 |
| tsdgeos | ok | 11:38 |
| tsdgeos | Cimi: have you started already, if not maybe look at the header as Saviq says? | 11:39 |
| tsdgeos | if not, i'm almost done-ish with actions | 11:39 |
| tsdgeos | so i could take that one | 11:39 |
| Cimi | tsdgeos, let me take both :) | 11:45 |
| Cimi | tsdgeos, I have to go to the office though today, so bring something bigger | 11:45 |
| Cimi | tsdgeos, zoomable image? :) | 11:45 |
| Cimi | tsdgeos, I ant to do media player | 11:45 |
| tsdgeos | Cimi: header is more important, since we *need* it now | 11:46 |
| tsdgeos | media player is more of a wish list i gather | 11:46 |
| tsdgeos | Cimi: so let's focus on reusing the card header first, you can do it or i can do it, your call | 11:46 |
| tsdgeos | but media player i'd say is something we don't need now (at least for the mockups i've seen) | 11:47 |
| tsdgeos | Saviq: ↑↑↑ | 11:47 |
| Saviq | tsdgeos, Cimi, video player → later, we won't do video playback before we can do it out-of-process anyway | 11:47 |
| Saviq | later == when we can play video out-of-process | 11:47 |
| tsdgeos | +1 | 11:48 |
| Saviq | Cimi, and zoomable image is not designed well yet | 11:48 |
| Saviq | Cimi, since we don't know what to do when zooming (see my comments in the "future dash" spec) | 11:48 |
| Cimi | tsdgeos, do header | 11:48 |
| Cimi | tsdgeos, since it's more important | 11:48 |
| Cimi | tsdgeos, I have a chat today with desktop team | 11:49 |
| Cimi | I think about legacy etc | 11:49 |
| Cimi | they're in london | 11:49 |
| Cimi | might spend more time with them | 11:49 |
| tsdgeos | ok, i'll do it | 11:49 |
| Cimi | I'll do ratings | 11:49 |
| Saviq | Cimi, tsdgeos, we do, though, need an image widget anyway, just not support the zoomable prop | 11:50 |
| Saviq | but that should be rather simple | 11:50 |
| tsdgeos | Saviq: outside the image gallery? | 11:50 |
| Saviq | tsdgeos, hmm I think so, yes, just a single image | 11:51 |
| tsdgeos | ok | 11:51 |
| * Saviq wonders if we should add more props for the Image - like aspect ratio, fill mode... | 11:51 | |
| Cimi | Saviq, aspect ration no | 11:52 |
| Cimi | Saviq, fill mode definitely | 11:52 |
| Saviq | Cimi, one without the other doesn't make much sense | 11:52 |
| Cimi | Saviq, unless we state | 11:52 |
| Cimi | "we're going to support just this" | 11:52 |
| Cimi | so you plan things ahead and you're consistent | 11:53 |
| Saviq | ok actually it looks like images are same height as gallery, so no need for any of those | 11:53 |
| Saviq | at least not now | 11:54 |
| === MacSlow is now known as MacSlow|lunch | ||
| dandrader | greyback, would you like or have time to review this? https://code.launchpad.net/~dandrader/unity-mir/clipboard/+merge/205135 | 12:16 |
| greyback | dandrader: that isn't as much code as I was expecting :) I can take it. | 12:19 |
| dandrader | greyback, great! thanks! | 12:19 |
| greyback | dandrader: for future we need to put the proto into a separate package/project | 12:20 |
| dandrader | greyback, not sure if the extra complexity is worth it, but it's indeed more correct | 12:21 |
| dandrader | greyback, just added the specific mir branch is depends on to the description as well | 12:22 |
| === dandrader is now known as dandrader|afk | ||
| greyback | dandrader: ah good to know | 12:23 |
| tsdgeos | Saviq: you doing https://code.launchpad.net/~aacid/unity8/action_preview_widget/+merge/204998 ? | 12:23 |
| Saviq | tsdgeos, will do, yes | 12:23 |
| Saviq | tsdgeos, I'm adding a test for the onFocusChanged in new-preview | 12:23 |
| Saviq | tsdgeos, would like a real review when that's done | 12:23 |
| tsdgeos | ok | 12:23 |
| Saviq | tsdgeos, will let you knw | 12:24 |
| === alan_g is now known as alan_g|lunch | ||
| Cimi | Saviq, this one is ready too now https://code.launchpad.net/~unity-team/unity8/unity8.previews_textSummary/+merge/204177 | 12:40 |
| Saviq | Cimi, k | 12:45 |
| === dandrader|afk is now known as dandrader | ||
| Saviq | greyback, FINALLY! congratz! | 12:52 |
| Saviq | rsalveti, congratz to you too, well deserved :) | 12:52 |
| Saviq | didrocks, and you :) | 12:53 |
| greyback | Saviq: ta :) | 12:53 |
| rsalveti | Saviq: thanks | 12:54 |
| Saviq | tsdgeos, shouldn't a Behavior on contentY make a ListView animate when positionViewAtIndex() is triggered? | 12:58 |
| didrocks | Saviq: thanks you, congrats greyback and rsalveti as well! | 13:07 |
| rsalveti | yeah, congrats as well :-) | 13:08 |
| === MacSlow|lunch is now known as MacSlow | ||
| Saviq | tsdgeos, https://code.launchpad.net/~saviq/unity8/new-preview/+merge/205086 ready | 13:19 |
| karni | o/ | 13:27 |
| karni | greyback: rsalveti: Congrats you guys!! Great job! | 13:28 |
| greyback | karni: thanks :) | 13:31 |
| karni | :) | 13:31 |
| greyback | didrocks: rsalveti: congrats to you both also | 13:31 |
| === alan_g|lunch is now known as alan_g | ||
| mhr3_ | Saviq, what do i need so have new previews? your new-previews branch i guess? :) | 14:04 |
| mhr3_ | s/so/to/ | 14:04 |
| tsdgeos | Saviq: so this typo you had shows you probably need another test for PreviewWidgetFactory in which you don't overwrite the source? | 14:07 |
| Saviq | tsdgeos, probably | 14:08 |
| Saviq | tsdgeos, I didn't want to write one for the mapping... but yeah, will do | 14:08 |
| tsdgeos | it's a bit weird | 14:08 |
| Cimi | greyback, congrats, good time to come living in London | 14:08 |
| tsdgeos | as you're effectevily testing the switch | 14:08 |
| === rachelliu_ is now known as rachelliu | ||
| Saviq | tsdgeos, exactly | 14:09 |
| mhr3_ | Saviq, also, which widget types are supposed to be supported atm? | 14:09 |
| tsdgeos | Saviq: ok, ignore it then | 14:09 |
| Saviq | tsdgeos, no, but we need it | 14:09 |
| Saviq | tsdgeos, will add, it's a simple test | 14:09 |
| Saviq | mhr3_, audio, gallery, text and actions, header is in the works | 14:10 |
| greyback | Cimi: thanks! Just need a few more of them and I'd be able to afford to live in London :) | 14:10 |
| Saviq | ;D | 14:11 |
| Saviq | tsdgeos, Cimi, we'll need the progress widget, too | 14:15 |
| tsdgeos | Saviq: do we want to use it as the docu says or? | 14:15 |
| tsdgeos | i mean the docu says an action button that automagically turns into a progress bar | 14:15 |
| * Cimi loves his IRC notifications on the watch when I have laptop closed | 14:15 | |
| Cimi | this is just awesome! | 14:16 |
| Saviq | Cimi, open your laptop this instance | 14:16 |
| Saviq | Cimi, you're at work, remember? | 14:16 |
| Cimi | Saviq, just back from lunch | 14:16 |
| Saviq | tsdgeos, no, separate widget | 14:16 |
| Cimi | Saviq, it's 14 here | 14:16 |
| Saviq | Cimi, you close your laptop over lunch?! | 14:16 |
| Cimi | Saviq, standby | 14:16 |
| tsdgeos | Saviq: ok | 14:16 |
| Cimi | I close the lid | 14:17 |
| dandrader | greyback, didn't get your "rpc for copy" comment | 14:17 |
| dandrader | greyback, you're suggesting "service UnityService { message copy .... }" (don't even know if that construct exists)? | 14:18 |
| paulliu | Saviq: I don't mind to take the progress widget . | 14:18 |
| Cimi | Saviq, ZNC -> pushover -> android -> pebble | 14:19 |
| Saviq | paulliu, ah, I wasn't exactly sure what're you doing these days, thought you were helping folks closer to the backends? | 14:19 |
| Saviq | Cimi, yes, I know you're into your watches ;) | 14:19 |
| paulliu | Saviq: yes. And now I should help to get the previews componentized done. | 14:20 |
| Saviq | paulliu, ok cool, start with Image, then | 14:20 |
| paulliu | Saviq: got it. | 14:21 |
| Saviq | paulliu, look at one of the approved widgets in https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews | 14:21 |
| greyback | dandrader: well first off if a client calls copy(), could it fail? Does client care if copy() fails? | 14:21 |
| paulliu | Saviq: seems your branch (previews_audioPlayer) is not yet merged. | 14:21 |
| Saviq | paulliu, you want to base your new widget off of lp:~unity-team/unity8/unity8.previews_audioPlayer branch | 14:21 |
| paulliu | Saviq: ok | 14:21 |
| Saviq | paulliu, that's Cimi's | 14:21 |
| Cimi | internet at home: 152Mbps/12, office, 12/10 | 14:21 |
| dandrader | greyback, well, theoretically any rpc call can fail | 14:21 |
| Saviq | paulliu, and no branches are merged as CI Train is stopped | 14:21 |
| paulliu | Saviq: ok.. got it. | 14:21 |
| Cimi | Saviq, when will it get merged? | 14:22 |
| dandrader | greyback, but we surely don't care if the copy() fails at this point | 14:22 |
| Saviq | tsdgeos, https://code.launchpad.net/~aacid/unity8/action_preview_widget/+merge/204998/comments/479765 | 14:22 |
| dandrader | greyback, as for the Void thing, I was just following the idiom used in mir | 14:22 |
| Saviq | Cimi, I hope to get a slot today | 14:22 |
| Saviq | Cimi, it's not entirely my call :/ | 14:22 |
| greyback | dandrader: aha ok. | 14:22 |
| dandrader | greyback, but the error field is optional, you know | 14:23 |
| Cimi | Saviq, I'm in the office, shall I push someone in the desktop team or CI? :) | 14:23 |
| dandrader | greyback, if you don't set it, it won't bet sent | 14:23 |
| Cimi | I can be annoying :D | 14:23 |
| tsdgeos | Saviq: ok | 14:23 |
| greyback | dandrader: it was confusing me, using these rpc calls for something that look like a single message | 14:23 |
| dandrader | greyback, well, that's how it's done in protobuf as far as I known: you have a service and inside it a number of rpc functions | 14:24 |
| dandrader | greyback, and each rpc function necessarily takes a message in and sends back another message | 14:25 |
| Saviq | didrocks, any chance for a landing slot for unity8 today? | 14:25 |
| dandrader | greyback, and you can use the return message to at least know that the rpc was successful (server received and acked it) | 14:25 |
| greyback | dandrader: rpc is a message + a reply, no? | 14:25 |
| dandrader | greyback, yes | 14:26 |
| greyback | dandrader: for copy, do we need the reply? | 14:26 |
| dandrader | greyback, a request message and a result message | 14:26 |
| greyback | is always having a reply good practice? | 14:26 |
| tsdgeos | Saviq: i thought i had to pass back my own data on a button click, so no data for buttons? | 14:26 |
| Saviq | tsdgeos, no | 14:26 |
| tsdgeos | ok | 14:27 |
| Saviq | tsdgeos, data is only for additional data | 14:27 |
| dandrader | greyback, we need so that we know that it has been received. i.e., that the rpc is complete | 14:27 |
| dandrader | alan_g, ^^^^ | 14:27 |
| tsdgeos | Saviq: i am not sure i understand what you mean with "Can we override the clicked() signal to send just the action id?" | 14:27 |
| Saviq | tsdgeos, instead of a new signal | 14:27 |
| Saviq | tsdgeos, can we do signal clicked(string id)? | 14:27 |
| dandrader | greyback, alan_g is our protobug expert | 14:27 |
| tsdgeos | Saviq: but didn't we say we wanted to call it triggered? | 14:28 |
| dandrader | protobuf | 14:28 |
| Saviq | tsdgeos, Button already has a signal clicked() | 14:28 |
| Saviq | tsdgeos, higher up, yes | 14:28 |
| tsdgeos | ah | 14:28 |
| tsdgeos | let me see | 14:28 |
| Saviq | tsdgeos, but button is clicked, action is triggered | 14:28 |
| tsdgeos | not sre how happy is qml with overrriden signal names tbh | 14:28 |
| greyback | dandrader: yes, best to ask him | 14:28 |
| Saviq | tsdgeos, hence the ? :) | 14:28 |
| Saviq | tsdgeos, the result itself is sent with actions, on top of that we only need widget and action id, and any data (rating, review, progress status etc.) | 14:29 |
| alan_g | We've used protobuf to implement rpc from the client and messaging from the server. Stepping outside that needs additional work | 14:30 |
| Saviq | dednick, standup | 14:32 |
| Saviq | kgunn, kudos ;) | 14:34 |
| didrocks | sil2100: can you assign for Saviq? ^ | 14:39 |
| sil2100 | Saviq: is the landing ready? | 14:39 |
| Saviq | didrocks, sil2100, no, not yet - was just asking whether we're landing again? | 14:39 |
| mterry | Oh, I meant to ask in the meeting. elopio and I are seeing that when the mock Unity plugin is used during AP tests, url-dispatcher doesn't work right. Presumably due to applicationmanager? Does anyone know off the top of their heads why that would be? | 14:39 |
| mterry | Saviq, mzanetti ^ | 14:39 |
| sil2100 | Saviq: we're landing now ;) We had a green image in the morning so we're ok | 14:39 |
| Saviq | sil2100, didrocks yay :) | 14:40 |
| Saviq | sil2100, didrocks can we have a silo for unity-mir then? | 14:40 |
| greyback | alan_g: my query was more of a "best practice" inquiry with protobuf. He implemented copy/paste with protobuf. I was questioning if "copy" needs to be an rpc call, or if simply a "message" would do - i.e. would a client ever care if the copy call failed? | 14:40 |
| Saviq | sil2100, line 42 | 14:40 |
| mzanetti | mterry: hmm... no, not really | 14:40 |
| karni | Saviq: re: overlay height - katie's comment isn't conclusive to me. "header height would be the same as a non-overlaid header". Would you say she's aware that title only 2-line header is shorter than title only 1-line header? | 14:40 |
| didrocks | Saviq: yeah, we are landing | 14:41 |
| mzanetti | mterry: but... is it using the mock applicationmanager plugin? | 14:41 |
| greyback | tbh, I suppose silent fails are bad | 14:41 |
| Saviq | karni, probably best ping here in #design on i.c.c | 14:41 |
| karni | I'll do that | 14:41 |
| mterry | mzanetti, among others yeah | 14:42 |
| mzanetti | mterry: yeah, the fake appmanager doesn't connect to upstart or anything | 14:42 |
| mzanetti | mterry: it has a hardcoded list of apps it knows | 14:42 |
| mterry | mzanetti, url-dispatcher doesn't seem to go through upstart? | 14:42 |
| alan_g | greyback: "copy" needs to be an RPC call because it happens client side and the existing support in Mir is for RPC on the client and messaging on the server. | 14:42 |
| mzanetti | mterry: I suppose you want to start an app, right? | 14:43 |
| mterry | mzanetti, yeah | 14:43 |
| mzanetti | yeah, that goes from url-dispatcher to upstart, and from there to unity-mir. | 14:43 |
| mzanetti | the fake appmanager in unity8 doesn't listen to that | 14:43 |
| mzanetti | and hence doesn't actually start the app | 14:44 |
| greyback | alan_g: just what I needed to know, thank you | 14:44 |
| alan_g | yw | 14:44 |
| * mterry isn't convinced that it actually goes through upstart | 14:45 | |
| Saviq | mterry, it does | 14:45 |
| Saviq | mterry, upstart-app-launch | 14:45 |
| Saviq | +lib | 14:45 |
| mterry | if that were true, we wouldn't be seeing the bug from nested mode we did see | 14:45 |
| Saviq | mterry, that was dbus-dispatched, right? | 14:45 |
| mterry | where we had to add MIR_SOCKET to dbus's environment (it was already in upstart's environment) | 14:45 |
| sil2100 | Saviq: ok, let me assign that | 14:45 |
| mterry | Saviq, via url-dispatcher | 14:46 |
| Saviq | mterry, well, they're definitely upstart-managed, that's for sure | 14:46 |
| Saviq | mterry, (see all the logs in .cache/upstart/) | 14:46 |
| * mterry wonders how this needs dbus's environment then | 14:46 | |
| Saviq | tedg, can you shed some light on this ↑ | 14:46 |
| * mzanetti goes for a run as long as the sun is shining. bbiab | 14:47 | |
| tedg | I'm a little confused | 14:47 |
| elopio | I'm sorry I missed the stand up. | 14:48 |
| mterry | tedg, so we had a bug where url-dispatched apps didn't work in nested mode | 14:48 |
| tedg | So url-dispatcher definitely uses upstart. | 14:48 |
| elopio | but I just worked with mterry yesterday, so that's already on the log. | 14:48 |
| * elopio listens carefully. | 14:48 | |
| mterry | tedg, adding the correct MIR_SOCKET to dbus's environment fixed that | 14:48 |
| mterry | tedg, now I'm wondering why if url-dispatcher just uses upstart | 14:48 |
| tedg | mterry, Was the proper MIR_SOCKET set in the global upstart env? | 14:49 |
| mterry | tedg, yes | 14:49 |
| mterry | tedg, other upstart launches worked | 14:49 |
| mterry | tedg, only url-dispatcher was busted | 14:49 |
| sil2100 | Saviq: ok, silo assigned - just make sure you check that all the MR's written down are MR's not branches ;) THere was one there | 14:49 |
| tedg | mterry, That's definitely weird. Just because URL dispatcher is kinda simplistic. | 14:50 |
| tedg | mterry, It doesn't set any environment other than the URI. | 14:50 |
| mterry | tedg, let me double confirm it's not specific to click scope then | 14:52 |
| tedg | mterry, You can throw the glib debug messages flag into URL dispatcher and it'll print out every URL it gets. | 14:52 |
| mterry | tedg, (click scope was launching the url-dispatcher) | 14:52 |
| tedg | I'm hoping Upstart launches it, and click scope calls it :-) | 14:53 |
| mterry | tedg, so click scope is calling settings:///system/online-accounts | 14:54 |
| mterry | tedg, which when I call manually on command line is also busted in nested mode | 14:55 |
| mterry | tedg, but what happens is settings comes up | 14:55 |
| mterry | tedg, then a second accounts window comes up busted | 14:55 |
| mterry | tedg, only the second window is busted | 14:55 |
| * mterry wonders what the heck system-settings is doing | 14:55 | |
| mterry | seb128, ^ | 14:56 |
| seb128 | mterry, howdy | 14:56 |
| seb128 | mterry, do I need to read backlog or can you summarize the question? | 14:56 |
| mterry | seb128, how does system-settings handle url-dispatches? It seems to open a second accounts window via dbus instead of upstart? | 14:56 |
| mterry | seb128, like | 14:56 |
| mterry | url-dispatcher settings:///system/online-accounts | 14:57 |
| seb128 | mterry, online accounts is special, they are a different app than system settings | 14:57 |
| mterry | seb128, that line gives me two windows | 14:57 |
| tedg | mterry, Can you try with clock or something else just to see if it's a settings thing or not? | 14:57 |
| mterry | seb128, curious | 14:57 |
| seb128 | mterry, right | 14:57 |
| mterry | tedg, it's just settings | 14:57 |
| mterry | tedg, you can go now, thanks ;) | 14:57 |
| seb128 | mterry, the experience relies on Mir work that is not there yet, same as content picker | 14:57 |
| tedg | Heh, okay | 14:57 |
| mterry | seb128, it's launched via dbus? | 14:58 |
| tedg | Good luck seb128, remember no hits below the belt. | 14:58 |
| mterry | elopio, sounds like the test needs system-settings then. It's the only one that does this dbus-launching thing | 14:59 |
| seb128 | mterry, https://code.launchpad.net/~mardy/ubuntu-system-settings/plugin-invocation/+merge/176929 | 14:59 |
| mhr3_ | Saviq, what's still missing to hook things up with the new preview? atm it's still trying to use the old renderers | 14:59 |
| mterry | elopio, and specifically the online acccounts plugin | 14:59 |
| elopio | mterry: that's easy, but will add a new dependency. | 15:00 |
| mterry | elopio, yeah :-/ Plus, we'd still be fighting the mocks | 15:00 |
| * elopio tries to see if this time it gets the focus. | 15:00 | |
| mterry | elopio, we need just a package of system-level AP test | 15:00 |
| tsdgeos | Saviq: "Duplicate signal name: invalid override of property change signal or superclass signal" | 15:01 |
| elopio | mterry: that, and a way to reproduce this dbus launching without the real system settings. | 15:03 |
| seb128 | mterry, you better ask kenvandine or mardy about the online account | 15:03 |
| elopio | but we have now added like 6 new tests to the backlog. Lets finish this one first. | 15:03 |
| mterry | elopio, good news | 15:04 |
| === dandrader is now known as dandrader|lunch | ||
| seb128 | mterry, is your issue similar to https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings-online-accounts/+bug/1273781 ? | 15:04 |
| mterry | elopio, using settings:// does not mind the mocks | 15:04 |
| ubot5 | Launchpad bug 1273781 in ubuntu-system-settings-online-accounts (Ubuntu) "If you open the accounts page in the settings app and close it you can't reopen it" [Undecided,Confirmed] | 15:04 |
| mterry | seb128, the issue I see with nested mode is that the accounts window tries to connect to the system compositor instead of unity8, so it can't be swiped away or such | 15:05 |
| mterry | elopio, so we could certainly add a dependency for this test... But it seems heavy handed | 15:05 |
| elopio | mterry: the project that will hold ubuntu-level tests is not ready. Would it be ok to have it in unity for now, and move it later? | 15:08 |
| mterry | elopio, I'm personally OK with it | 15:09 |
| mterry | mzanetti, how bad is it to add a dep on system-settings for a unity8 AP test? | 15:09 |
| elopio | mterry, mzanetti: system settings, and online accounts. | 15:09 |
| mterry | true | 15:10 |
| elopio | tedg: I have some questions. Still around? | 15:10 |
| tedg | elopio, Sure, what's up? | 15:11 |
| elopio | tedg: I would like to launch with URL dispatcher an application I create during a test setup. | 15:11 |
| elopio | so it won't be installed. Can I launch qmlscene with my own QML file? | 15:12 |
| tedg | elopio, Will it have a desktop file? | 15:13 |
| tedg | I guess, let me say it another way. You need a desktop file :-) | 15:13 |
| elopio | tedg: it can have one, but not on /usr/ | 15:13 |
| tedg | Sure, but in ~/.local/share/applications | 15:13 |
| elopio | tedg: sure, I can put it there without problems. | 15:14 |
| elopio | so, should I give url dispatcher the name of that desktop file? | 15:14 |
| tedg | elopio, Yes, so you can give it: application:///foo.desktop | 15:14 |
| elopio | that's pretty good, thanks :) | 15:14 |
| tsdgeos | Saviq: does signalspy have a cleanup function? | 15:14 |
| elopio | tedg: the other thing I want to do is to mock url-dispatcher, so on the click scope test, I only check that we send the right URL. Is there a documentation of the dbus API so I can write the dbusmock? | 15:15 |
| tedg | elopio, Don't tell your boss how easy it is ;-) http://bazaar.launchpad.net/~indicator-applet-developers/url-dispatcher/trunk.14.04/view/head:/data/com.canonical.URLDispatcher.xml | 15:16 |
| tedg | elopio, Are you using dbus-test-runner's dbus-mock support? | 15:17 |
| elopio | tedg: no, autopilot + python-dbusmock. | 15:18 |
| mterry | elopio, so I'm going to test your unity8 test with the online account swapped in for camera-app, will let you know how it goes | 15:18 |
| tedg | elopio, Ah, so a full system test. | 15:18 |
| elopio | mterry: thanks. I'm also trying it on my phone before updating the branch. | 15:18 |
| elopio | tedg: yes. Well, not full for now because we are isolating the external dependencies. | 15:19 |
| mhr3_ | tsdgeos, are you aware of a branch that hooks up the new previews? | 15:20 |
| tedg | elopio, Interesting, we use dbusmock in our unit tests for URL Dispatcher. | 15:20 |
| mhr3_ | tsdgeos, don't see anything in active mps | 15:20 |
| tedg | elopio, You could steal that code :-) | 15:20 |
| tsdgeos | mhr3_: not really, https://code.launchpad.net/~saviq/unity8/new-preview/+merge/205086 is the closest thing i'd say | 15:20 |
| mterry | elopio, huh, now I get same result with mocks not letting the app show | 15:20 |
| tedg | elopio, http://bazaar.launchpad.net/~indicator-applet-developers/url-dispatcher/trunk.14.04/view/head:/tests/lib-test.cc | 15:21 |
| mhr3_ | tsdgeos, yea, that's the one i'm running | 15:21 |
| tsdgeos | but yeah, doesn't hook it up yet | 15:21 |
| elopio | tedg: right, I will :) Then I can tell my boss I had to do nothing because you had it all covered. | 15:21 |
| === alan_g is now known as alan_g|tea | ||
| elopio | mterry: for one run, I could see the camera on top. | 15:23 |
| elopio | but even then, it wasn't updating the current focused app property. | 15:24 |
| elopio | back to the start... | 15:24 |
| === greyback is now known as greyback|away | ||
| === alan_g|tea is now known as alan_g | ||
| elopio | mterry: with the mocks, I get a white screen being opened. Without the mocks, I get system settings, not online accounts. | 15:32 |
| elopio | curiouser and curiouser. | 15:32 |
| elopio | mzanetti: where's the code for the real app-manager? | 15:40 |
| tsdgeos | unity-mir i think | 15:44 |
| mzanetti | yep | 15:45 |
| Saviq_ | sil2100, man, sorry about that | 15:54 |
| Saviq | mhr3_, https://code.launchpad.net/~unity-team/unity8/new-scopes/+activereviews | 15:55 |
| Saviq | mhr3_, https://code.launchpad.net/~unity-team/unity8/newscopes-preview/+merge/205029 | 15:56 |
| Saviq | mhr3_, I hope to land the prereqs today, so that tomorrow we get it all into new-scopes | 15:56 |
| didrocks | Saviq: btw, you will get candies once unity-mir lands :) | 15:59 |
| mhr3_ | Saviq, we're getting somewhere :) http://imgur.com/uMZwsfB | 15:59 |
| tsdgeos | pete-woods: so i still need https://code.launchpad.net/~pete-woods/ubuntu-ui-toolkit/handle-quit-action so that the hud quit works, right= | 15:59 |
| Saviq | mhr3_, w00t! | 15:59 |
| Saviq | thostr_, ↑↑ | 15:59 |
| mhr3_ | Saviq, it's missing text field though | 15:59 |
| Saviq | mhr3_, "text field"? | 16:00 |
| mhr3_ | i pushed gallery, actions, text, audio | 16:00 |
| pete-woods | tsdgeos: yes, but that just adds it to the toolbar | 16:00 |
| === dandrader|lunch is now known as dandrader | ||
| Saviq | mhr3_, will have a look | 16:00 |
| pete-woods | tsdgeos: there's also the ubuntu-ui-toolkit component to land | 16:00 |
| tsdgeos | pete-woods: what do you mean it adds it to the toolbar? | 16:00 |
| pete-woods | tsdgeos: doesn't your unity8 change add the quit action to the toolbar? | 16:01 |
| pete-woods | before that it will just live in the actions list | 16:01 |
| Saviq | didrocks, oh candies? why's that? | 16:01 |
| tsdgeos | pete-woods: yes, i am saying that i need https://code.launchpad.net/~pete-woods/ubuntu-ui-toolkit/handle-quit-action/+merge/203964 for it to actually quit, no? | 16:01 |
| pete-woods | tsdgeos: sorry, yes, you're correct, I misunderstoof | 16:01 |
| pete-woods | *misunderstood, even | 16:01 |
| tsdgeos | pete-woods: ah, no worries, bool then | 16:01 |
| tsdgeos | bool -> cool | 16:02 |
| Saviq | didrocks, btw, any idea why SSO with the jenkins instance is so weird? Like I can press "build" and only then will it go through SSO, and then ask about the details every time | 16:02 |
| didrocks | Saviq: there is ricmm's fix for enabling registering an application which failed at startup :) | 16:02 |
| Saviq | didrocks, ah yeas | 16:02 |
| didrocks | Saviq: yeah, I don't know, I tried to poke IS about it | 16:02 |
| didrocks | Saviq: just so that you feel better, I can tell you "you're not alone" :p | 16:02 |
| Saviq | didrocks, not sure I feel better ;) | 16:02 |
| Saviq | uh, conflict :/ | 16:03 |
| didrocks | I tried so hard though! | 16:03 |
| Saviq | and tvoss not around | 16:03 |
| didrocks | Saviq: want to remove one MP? | 16:03 |
| didrocks | we can reconfigure | 16:03 |
| Saviq | didrocks, no, want to fix it ;) | 16:03 |
| didrocks | if the branch name is ~tvoss, that would be hard ;) | 16:03 |
| mhr3_ | Saviq, no, my bad... pushed it as "txt" instead of "text"... all good (minus the spinner) | 16:04 |
| Saviq | mhr3_, yeah, spinner should go away, not sure why it doesn't, but then again it was pretty late yesterday when I wrote it and could not test :) | 16:05 |
| Saviq | mhr3_, can you switch between previews fine? | 16:05 |
| mhr3_ | Saviq, hmm.. would need more than one result to tell :) | 16:05 |
| Saviq | LD | 16:06 |
| Saviq | ↑cool glasses | 16:06 |
| seb128 | kenvandine, mardy: can we get a gnome-control-center-signon upload? | 16:10 |
| seb128 | unity-control-center is needing the update | 16:11 |
| mhr3_ | Saviq, ok added another result, i can swipe to it, but there is some weirdness, the previews opens correctly only for the first result, if i try to open it from the second it displays just blank preview | 16:11 |
| pete-woods | tsdgeos: I've just updated that ubuntu-ui-toolkit branch now I can actually test it properly | 16:11 |
| Saviq | mhr3_, ok, we're getting there | 16:12 |
| tsdgeos | pete-woods: oki, you know where my branch is, right? | 16:12 |
| pete-woods | tsdgeos: yes, I've linked it to the overall bug, I already tested that part, and I'm certain it works | 16:12 |
| tsdgeos | oki | 16:12 |
| Saviq | mhr3_, if I can get the scope, I'll start fixing those | 16:13 |
| Saviq | mhr3_, btw, just remembered - how do we handle previews that should come as responses to activation? where do I get the model? | 16:13 |
| mhr3_ | Saviq, we'll handle that somehow via the stack | 16:14 |
| mhr3_ | Saviq, it will either update the current preview or add a new one | 16:14 |
| mhr3_ | Saviq, and i'm actually using the mock test scope from unity-scopes-shell | 16:14 |
| Saviq | mhr3_, I meant result activation, sorry | 16:17 |
| Saviq | mhr3_, not actions | 16:17 |
| karni | Saviq: sorry to bug you, tring to pull multiple parties into a meeting :) got couple minutes? | 16:17 |
| mhr3_ | Saviq, oh yea, still possible, but more explicit, the activation will come back with "do preview instead" | 16:25 |
| mhr3_ | Saviq, and i guess i'll just emit that as a signal | 16:26 |
| mhr3_ | Saviq, will be better for you that way i think? | 16:26 |
| Saviq | mhr3_, otp, gimme a minute please | 16:26 |
| mhall119 | Saviq: does Unity8 use the same theme/theming funcitonality as the SDK components? | 17:00 |
| Saviq | mhall119, yes | 17:00 |
| Saviq | mhall119, but not extensively | 17:01 |
| Saviq | mhall119, so for every thing someone would want themable, we need to make it happen | 17:01 |
| mhall119 | ok, but if the defaul SDK theme itself were to gain some ability to just change things like colors, would Unity8 automatically pick them up? | 17:02 |
| === shiznix_ is now known as shiznix | ||
| mhr3_ | mhall119, could you update the scopes docs again pls? | 17:03 |
| mhr3_ | mhall119, link coming up | 17:03 |
| mhall119 | mhr3_: was just about to ask for that :) | 17:04 |
| mhall119 | mhr3_: we're about to break for lunch, I'll upload them after | 17:04 |
| mhr3_ | mhall119, http://people.canonical.com/~mhr3/scopes.tgz | 17:04 |
| mhr3_ | mhall119, btw the dir name changed | 17:04 |
| mhr3_ | mhall119, if you can upload it to the old it'd be great, cause people bookmarked that already | 17:05 |
| mhall119 | I'll take a look | 17:05 |
| mhr3_ | thx | 17:06 |
| === dandrader is now known as dandrader|afk | ||
| Saviq | sil2100, ok, can we have a silo for unity8, too? | 17:20 |
| Saviq | sil2100, or actually... maybe we should merge the two landings? | 17:20 |
| Saviq | sil2100, one includes the TestPlan for the other anyway | 17:20 |
| === greyback|away is now known as greyback | ||
| Saviq | didrocks, ↑ | 17:21 |
| didrocks | Saviq: sounds good to me to merge them | 17:22 |
| * Saviq does | 17:22 | |
| didrocks | Saviq: tell us when you are ready :) | 17:22 |
| didrocks | I guess that will be first Mirv's assignement | 17:22 |
| didrocks | Saviq: btw: http://ci.ubuntu.com/smokeng/trusty/touch/maguro/167:20140206.1:20140115.1/6480/unity8-autopilot/741839/ | 17:22 |
| didrocks | not sure if it's due to new AP | 17:22 |
| didrocks | or a flaky test/behavior | 17:22 |
| Saviq | didrocks, not sure either, will have to investigate - didn't see that before | 17:23 |
| Mirv | o/ | 17:23 |
| didrocks | Saviq: ok, I asked plars to rerun it to get more infos | 17:23 |
| Saviq | didrocks, ok, line 42 can be reconfigured | 17:24 |
| Saviq | didrocks, and line 52 can be removed | 17:24 |
| Mirv | Saviq: ok, thanks for merging | 17:27 |
| Mirv | Saviq: there's a 'comment' link in the proposal list... | 17:31 |
| Mirv | Saviq: fixing | 17:31 |
| Mirv | Saviq: ok done, silo reconfigured | 17:35 |
| mhr3_ | Cimi, ping | 17:48 |
| mhr3_ | Cimi, ping2 | 17:48 |
| === alan_g is now known as alan_g|EOD | ||
| Saviq | Mirv, man, sorry, that thing needs to be validated somehow... | 18:01 |
| Saviq | didrocks, 2014-02-06 17:48:37,988 INFO === Trying to prepare unity8 === | 18:01 |
| Saviq | 2014-02-06 17:48:38,155 INFO Branching https://code.launchpad.net/~mir-team/unity-mir/trunk to unity-mir | 18:02 |
| Saviq | didrocks, looks like some label got mixed up - unity8 vs. unity-mir | 18:02 |
| Saviq | Mirv, can you please reconfigure row 42? I had to resubmit a conflicting merge | 18:02 |
| Saviq | and kick build after it's reconfigured... | 18:03 |
| karni | Saviq: I need a quick tip :( I was hoping I'd pull CardHeader height from CardTool, so it's fixed (and not affected whether title is wrapped or not). Is that the right way to do it? Doesn't weem to work. | 18:04 |
| karni | Does that make sense? http://paste.ubuntu.com/6886636/ | 18:06 |
| === dandrader|afk is now known as dandrader | ||
| karni | Saviq: nvm, works great :) | 18:22 |
| === vila_ is now known as vila | ||
| karni | Saviq: WIP -> needs review | 19:14 |
| karni | https://code.launchpad.net/~unity-team/unity8/unity8-card-overlay/+merge/204790 | 19:14 |
| karni | https://code.launchpad.net/~unity-team/unity8/newscopes-card-overlay/+merge/204797 | 19:14 |
| mhall119 | Saviq: http://ubuntuone.com/1cCsRpYVBbAMWn5ZogzTH7 | 19:36 |
| mhall119 | https://bugs.launchpad.net/indicator-datetime/+bug/1277232 | 19:39 |
| ubot5 | Launchpad bug 1277232 in Indicator Date and Time "indicator icon and event icons within the indicator use wrong icon" [Undecided,New] | 19:39 |
| Saviq | mhall119, oh yay | 20:42 |
| Saviq | Mirv, are you still there? | 20:51 |
| karni | ready: https://code.launchpad.net/~unity-team/unity8/new-scopes-title-alignment/+merge/204677 | 20:52 |
| Saviq | karni, conflict | 20:55 |
| Saviq | karni, and not "titleAlignment" but "headerAlignment" | 20:55 |
| karni | ^-^ | 21:08 |
| karni | I should really take it easy *sighs* | 21:11 |
| elopio | mterry: I got it working once, with online accounts on top and everything. | 21:12 |
| elopio | next time I run it, it breaks. If I wait a lot, I get a white screen. | 21:12 |
| mterry | elopio, :( | 21:13 |
| elopio | I'm seing this bug: | 21:13 |
| elopio | https://bugs.launchpad.net/unity-mir/+bug/1252294 | 21:13 |
| ubot5 | Launchpad bug 1252294 in unity-mir "Application window appears in the background" [High,Confirmed] | 21:13 |
| mterry | elopio, you mentioned we might get a general component to put system-integration AP tests in soon? | 21:13 |
| mterry | I'm assuming that would help us (no running mock stuff) | 21:14 |
| elopio | mterry: omer is working on it. https://code.launchpad.net/~om26er/ubuntu-autopilot-tests/ubuntu-integration-tests | 21:15 |
| Saviq | karni, you need to scale down the header in CardCarousel (by selectedScaleFactor) | 21:16 |
| elopio | mterry: yes, I'll start moving this tests with online accounts there. But I think we should have one inside unity that opens a fake application using url dispatcher. Don't you think so? | 21:16 |
| Saviq | karni, again, 'cause we're scaling up instead of down | 21:16 |
| mterry | elopio, didrocks gave go-ahead on landing nested support as long as we have a short-term plan for landing AP tests | 21:16 |
| mterry | elopio, so maybe we wait for that for the full online-accounts bit | 21:16 |
| mterry | elopio, for launching a fake application using url dispatcher, sure. That'd be nice to have in unity8 | 21:17 |
| mterry | elopio, but that isn't a must-have for me like the online-accounts is/was | 21:17 |
| elopio | mterry: yeah, you can tell didrocks that we have identified all the boundaries, I will be adding some tests for those boundaries and reporting bugs for the ones I can't make, and put the unity+mir+url dispatcher+online accounts tests on ubuntu-integration-tests | 21:19 |
| Saviq | karni, small optimization: http://paste.ubuntu.com/6887632/ | 21:19 |
| elopio | sounds like a good short-term plan, right? | 21:19 |
| mterry | elopio, yeah, thanks! I appreciate your help in all this | 21:19 |
| karni | Saviq: thank you | 21:21 |
| elopio | mterry: no problem. I appreciate your help too, now I understand many more things. | 21:21 |
| elopio | mterry: what we still need to define is how often those ubuntu-integration-tests are going to be run, and how to share the load of checking their failures. | 21:21 |
| mterry | elopio, that last bit is an interesting one :) | 21:21 |
| elopio | I'm scared that if we just add many tests, we will spend half of our day figuring out what went wrong. | 21:21 |
| elopio | and excercising a real ubuntu image, we have too many failure points | 21:22 |
| karni | pushed your patch, Michal | 21:30 |
| karni | (tring not to cause you highlight anymore :P) | 21:31 |
| karni | one-liner for anyone https://code.launchpad.net/~unity-team/unity8/unity8-silence-typeerror/+merge/205266 | 21:36 |
| * karni marked title alignment WIP, fixing a test | 21:36 | |
| elopio | mterry: is there a way to wait until the application is fully loaded? | 22:02 |
| elopio | if I try to swipe it away while it's loading, funny things happen. | 22:02 |
| mterry | elopio, uh, other tests just seem to wait if it's the focused app | 22:03 |
| elopio | mterry: that's not enough. | 22:04 |
| mterry | greyback ^ | 22:05 |
| elopio | mterry: nevermind. Actually, the problem was that we are not swiping until the middle. | 22:09 |
| Saviq | karni, implicitHeight is changed in https://code.launchpad.net/~unity-team/unity8/unity8-card-overlay/+merge/204790 | 22:56 |
| Saviq | karni, indeed it doesn't shrink - IIUC there's a binding loop that's interrupted and that's why implicitHeight is not updated | 22:56 |
| Saviq | karni, so when that gets merged, stuff should be better again | 22:58 |
| Saviq | karni, as for the tests, which ones fail for you? | 22:58 |
| karni | sorry, didn't notice your msg | 23:03 |
| karni | NoSummary and HorizontalNoSummary | 23:04 |
| karni | but I think any that exercise card height would fail | 23:04 |
| karni | Saviq: ^ | 23:04 |
| karni | which would be true, because these are the only two exercising height haha | 23:04 |
| karni | Saviq: gotta run. thanks for having a look at that. I need to learn more about binding loops, that can sometimes suck. funny enough, I came up myself with the fix that already was (written by you) in the overlay branch. | 23:09 |
| karni | Have a good evening! | 23:09 |
| Saviq | karni, o/ | 23:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!