| rick_h_ | hatch: :/ | 00:10 |
|---|---|---|
| hatch | rick_h_ yeah but the good news is that they have accepted the bug report | 00:11 |
| hatch | so it should at some point get fixed haha | 00:12 |
| Makyo | jujugui review/qa for the AM - https://github.com/juju/juju-gui/pull/118 Dealing with dead/dying fridge, so out for the night. | 03:12 |
| hatch | Makyo looks like you forgot to lint :) | 03:49 |
| Makyo | hatch, It's running now, sorry. | 03:50 |
| hatch | :) np | 03:51 |
| Makyo | And pushed | 03:51 |
| hatch | just playing hearthstone | 03:51 |
| Makyo | I'm thawing a freezer. Your night sounds better. | 03:52 |
| hatch | agreed haha | 03:55 |
| hatch | although im not very good at this game | 03:56 |
| hatch | i'll review your branch | 04:00 |
| hatch | Makyo I found a QA issue so I'm going to hold off on reviewing the code until resolved | 04:06 |
| Makyo | Later | 04:07 |
| hatch | yeah no problem :) | 04:07 |
| Makyo | See the issue, but this isn't data-bound and outside of scope. Will discuss tomorrow. | 04:14 |
| hatch | sure thing | 04:21 |
| hatch | I'm out have a good night | 04:21 |
| bac | trusty update-ageddon | 12:50 |
| rick_h_ | bac: yea, I get nervous | 12:55 |
| rick_h_ | jcastro had bad timing and blew up during a trusty upgrade at cape town | 12:56 |
| rick_h_ | jujugui I'm taking today as swap to catch up around here. I'll be in/out if anyone needs anything through the day | 12:56 |
| bac | i've been having issues with X on the vm so i get jittery when i see a bunch of x updates. but, perhaps, they are the fixes i've been waiting for. yay, irrational exhuberance. | 12:56 |
| bac | hey rick_h_ could you spare 5 minutes for a chat ? | 12:57 |
| rick_h_ | bac: sure thing | 12:58 |
| bac | rick_h_: https://plus.google.com/hangouts/_/calendar/Z2FyeS5wb3N0ZXJAY2Fub25pY2FsLmNvbQ.t3m5giuddiv9epub48d9skdaso | 12:59 |
| === rogpeppe1 is now known as rogpeppe | ||
| bac | hi abentley, i have some questions about charmworld migrations and exoduses. | 14:32 |
| abentley | bac: OTP. | 14:32 |
| bac | currently in migrations/versions we have 019 - 023 | 14:32 |
| bac | abentley: ok, no rush | 14:32 |
| hatch | rick_h_ hey I found something for you http://hackaday.com/2014/02/10/python-with-braces/ lol | 14:41 |
| rick_h_ | hatch: :P | 14:50 |
| rick_h_ | Makyo: hatch I'm swapping today but added a card with links to the twitter account info and azure stuff for ci. | 14:50 |
| rick_h_ | Makyo: hatch so if you guys can note that in the call appreciate it | 14:50 |
| hatch | got it! | 14:50 |
| rick_h_ | thanks | 14:50 |
| hatch | swap away | 14:50 |
| abentley | bac: Okay, I can talk now. | 14:54 |
| bac | abentley: ok, currently we have 019-023 in migrations/versions. 019 is an exodus. i need to add a new exodus as 024. so, if i'm reading everything correctly, adding a new exodus requires that i delete the existing exodus (019) and the migrations (020-023). is that correct? | 15:02 |
| abentley | bac: That is correct. | 15:03 |
| bac | ty | 15:04 |
| abentley | bac: If you really want to keep the previous migrations/exoduses, you can rewrite the migrations a new migration 025 to happen after the exodus. | 15:04 |
| abentley | err, "can rewrite the old migrations into a new migration 025" | 15:05 |
| benji | the debug server and app server running on the same port is irritating | 15:06 |
| hatch | jujugui I need someone to test a bug for me who's running stable chrome on Ubuntu | 15:33 |
| hatch | https://code.google.com/p/chromium/issues/detail?id=342554 click the fiddle and let me know the outcome please | 15:33 |
| bac | hatch: the zip file was right but i saw application/x-yaml for the yaml file | 15:36 |
| hatch | ok so it looks like it works properly on Ubuntu but not OSX or windows | 15:36 |
| hatch | thanks for confirming | 15:36 |
| bac | hatch: here's my chromium from trusty | 15:37 |
| bac | ii chromium-browser 31.0.1650.63-0ubuntu1~20131204.1 | 15:37 |
| hatch | yeah thats an older version than is on OSX too | 15:37 |
| hatch | jujugui call in 10 | 15:50 |
| bac | jcsackett: thanks for your review last night. i've made fixes you can look at if you want otherwise i'll land with your previous review. | 15:50 |
| Makyo | jujugui call in 1 | 15:59 |
| bac | let's shoot for five tomorrow | 16:07 |
| hatch | haha | 16:08 |
| arosales | rick_h_, hello | 16:43 |
| arosales | rick_h_, I know you got some more work on your plate so I wasn't sure if you would have time for writing a jenkins test for the charm audit | 16:43 |
| arosales | rick_h_, but I also didn't want to steal that one from you if you were going to work on so I thought I would ping here :-) | 16:43 |
| Makyo | arosales, I think rick_h_ is taking a swap day today, but I can make a card for that. | 16:43 |
| marcoceppi | hey rick, I've got a few merges that need review for amulet, got a few seconds? | 16:54 |
| marcoceppi | rick_h_: * | 16:54 |
| marcoceppi | https://github.com/marcoceppi/amulet/pull/19 and https://github.com/marcoceppi/amulet/pull/22 | 16:55 |
| arosales | Makyo, ok thanks, that would be good. Just didn't want to steal that from rick_h_ if he was working on it | 16:59 |
| Makyo | arosales, alright, card on the board in Maint. - High for the time being. | 17:03 |
| Makyo | marcoceppi, ^^^ re rick_h_ | 17:03 |
| arosales | Makyo, thanks | 17:04 |
| marcoceppi | Makyo: ah, thanks | 17:04 |
| Makyo | jujugui added @jujuui to http://jujugui.wordpress.com/ so that posts are autotweeted, and the user is @mentioned when anyone shares one of our posts through the widget. | 17:04 |
| hatch | OOooOOoo | 17:11 |
| hatch | Makyo +1 | 17:11 |
| Makyo | <helpful /> | 17:12 |
| hatch | done your good deed for the month? Time to relax! | 17:12 |
| Makyo | I'm out. I'll be over here petting these dogs. | 17:22 |
| hatch | haha | 17:26 |
| hatch | Makyo review done | 17:26 |
| Makyo | hatch, cheers, thanks. | 17:27 |
| hatch | no prolbemo | 17:28 |
| rick_h_ | marcoceppi: I'll take a look in a bit. Thanks for the links | 17:31 |
| rick_h_ | arosales: honestly, probably not room on the plate with picking up all the knowledge in gary's head and getting things here ready for machine view asap. sorry | 17:32 |
| rick_h_ | arosales: I'll see if we can get a slack card in case someone has some blocked time or something if it'll help | 17:32 |
| arosales | rick_h_, ack and thats what I figured just wanted to confirm, now get back to your swap day | 17:32 |
| arosales | any help is appreciated | 17:33 |
| rick_h_ | benji: sorry on the port issue. I hit that the other day and thought the same thing. I liked it in theory when I updated it all. | 17:33 |
| rick_h_ | benji: can you add a slack card split that into two ports again? I'll see if I can update it and get CI updated to use the right one. | 17:33 |
| rick_h_ | Makyo: woot on auto tweeting robots | 17:34 |
| rick_h_ | Makyo: hatch have you guys seen the email thread about allowing a null/none type? I want to chat/check how that effects us as we don't way to use 'unset' from the Gui and I worry we'll be stuck with an impossible workflow | 17:37 |
| rick_h_ | marcoceppi: maybe we can setup a quick time tomorrow mid-day to chat on it? ^ | 17:38 |
| hatch | rick_h_ I was under the impression that was only for proof and testing | 17:38 |
| hatch | but I'd participate in a call to learn more | 17:39 |
| rick_h_ | hatch: well if it passes proof then it means the default value going into the charm config will be None. That effects us for 'use default values' and allowing a user to get back to a default once changed right? | 17:39 |
| rick_h_ | right now proof marks it as an error if it's the wrong type and won't ingest/process I believe. | 17:40 |
| rick_h_ | so I think this effects us on both charmworld and gui config UX | 17:40 |
| hatch | well we have 'real' defaults though | 17:40 |
| hatch | I think they are saying when people have defaults as 'empty' | 17:41 |
| rick_h_ | hatch: right "" vs None. "" is a string, None is not. In JS it's the equiv of undefined. | 17:42 |
| rick_h_ | How do we allow a user to get back to undefined from an input field | 17:42 |
| hatch | ohh now I see what you're getting at | 17:42 |
| rick_h_ | and how to we get that sent via the api, or is there a magic "use default" we use instead or something? | 17:42 |
| hatch | we can solve this with a checkbox 'reset to default' on each field.... bleh | 17:43 |
| rick_h_ | hatch: right, I think this effects us. I'd like to talk about it romorrow | 17:43 |
| rick_h_ | tomorrow | 17:43 |
| rick_h_ | if you can Makyo and maybe bac can peek at it and think on the repercussions so we can talk to marcoceppi about it from our end. | 17:43 |
| hatch | yup, I'm available, just invite me to whenever it is | 17:43 |
| * hatch swears at the damn power key | 17:44 | |
| rick_h_ | hatch: ok cool. Maybe we'll chat and talk it through on our end first. Anyway, ponder it please. | 17:44 |
| hatch | we need to determine if "" can always be undefined | 17:45 |
| hatch | I'm thinking no | 17:45 |
| rick_h_ | hatch: right | 17:46 |
| hatch | I'd like a concrete case where that's true though | 17:46 |
| hatch | where "" !== undefined | 17:46 |
| rick_h_ | there is a distinction between a blog title with an empty name and a undefined name. | 17:46 |
| rick_h_ | maybe undefined is invalid, but "" is ok? | 17:46 |
| rick_h_ | yea blah | 17:46 |
| hatch | exactly :) | 17:46 |
| hatch | I can't think of a real case where it's not the same | 17:46 |
| hatch | but in reality it is | 17:46 |
| marcoceppi | rick_h_: let me know, I haven't changed proof yet, but several charm authors cried when proof was updated to be strict about formatting | 17:53 |
| rick_h_ | marcoceppi: yes, I think it brings a few issues for us we need to work through for that change to take place. I understand your desire for at least the undefined case, but we need to verify that core will accept it and figure out how to represent that in the GUI | 17:54 |
| marcoceppi | rick_h_: whatever unset does is what gui needs to do, I don't care either way, I'm just tired of fighting a few of the authors who are opposed to the current way it works. Before it was "well, you can't set a None type via juju set AND the GUI can't handle it" now that unset exists (which is revert to default, FYI) GUI is the only reason not to have the switch back | 17:56 |
| rick_h_ | marcoceppi: right, we'll have to explore some way of exposing 'unset' in the gui which we don't currently have is what I think we're heading towards | 17:57 |
| rick_h_ | marcoceppi: and room is tight to add an "unset" button to every field in config | 17:57 |
| marcoceppi | rick_h_: yeah, I understand that, cheers ;) | 17:58 |
| rick_h_ | marcoceppi: I agree it's something that needs to happen, just going to take a little bit to figure out the right way to do it. | 17:58 |
| marcoceppi | rick_h_: how does the reset to default work at the bottom? Or is that only reset the changes since last commit? | 17:58 |
| rick_h_ | so I believe that just walks and sets to the default value. It's not using unset | 17:59 |
| rick_h_ | and that's across all fields, not just one in particular you might want to 'unset' | 17:59 |
| marcoceppi | right, jw | 17:59 |
| hatch | jujugui could I get a review on https://github.com/juju/juju-gui/pull/119 no qa needed | 18:51 |
| hatch | thanks | 18:51 |
| hatch | rick_h_ how the heck do you have so many commits on the GUI? https://github.com/juju/juju-gui/graphs/contributors | 18:57 |
| hatch | do you just move code around to increase your ranking? lol! | 18:58 |
| * hatch taking lunch | 18:58 | |
| rick_h_ | hatch: :P guess it'll start to slow down a bit now | 19:00 |
| hatch | haha good I need to catch up! | 19:00 |
| bac | benji: would you have a moment to look at the exodus change? https://code.launchpad.net/~bac/charmworld/1278222-2/+merge/205835 | 19:05 |
| jcastro | hazmat, rick_h_: I cannot find the deployer bug that's "ignore broken units" and keep going | 20:24 |
| hazmat | jcastro, its framed by gui notion of bundle after bundle | 20:35 |
| jcastro | yeah I am just looking for the bug report. | 20:36 |
| hatch | jujugui anyone available for a pre-imp discussion on https://bugs.launchpad.net/juju-gui/+bug/1278559 I think I need to move the inspector creation code | 20:37 |
| _mup_ | Bug #1278559: dropping charm zip while inspector is open opens series select inspector over current inspector <juju-gui:Triaged by hatch> <https://launchpad.net/bugs/1278559> | 20:37 |
| hazmat | jcastro, 1252301 | 20:39 |
| hatch | bug 1252301 | 20:39 |
| _mup_ | Bug #1252301: guiserver reports second bundle as failing after the first fails <juju-deployer:New> <juju-gui (Juju Charms Collection):Triaged> <https://launchpad.net/bugs/1252301> | 20:39 |
| hatch | ^ easy link :) | 20:40 |
| jcastro | that's a new bug, I filed one when I originally found the race condition in the mongo charm | 20:40 |
| jcastro | hey so hazmat | 20:48 |
| jcastro | you kind of mention this is two bugs | 20:49 |
| jcastro | basically I want to communicate that this is the bug eco wants fixed | 20:49 |
| jcastro | I don't care too much where it lives as long as it's on someone's radar | 20:49 |
| hazmat | jcastro, could you file a separate bug for the unit failure mode.. hopefully its easier to track that way | 20:51 |
| jcastro | I had filed it | 20:51 |
| jcastro | but now I can't find it for the life of me | 20:51 |
| hazmat | jcastro, perhaps against distro? | 20:52 |
| hazmat | or gui charm? | 20:52 |
| jcastro | it was against the gui initially | 20:52 |
| jcastro | but was "also affects" deployer | 20:52 |
| jcastro | ok I will file a new one | 20:53 |
| hatch | heh yeah the bug search is kind of poor | 20:57 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1276107 this one? | 20:57 |
| _mup_ | Bug #1276107: gui fails to deploy a bundle due to "Invalid charm id: undefined" <juju-gui:Incomplete> <https://launchpad.net/bugs/1276107> | 20:57 |
| rick_h_ | hatch: still need a pre-imp? | 21:03 |
| hatch | I do, are you not swapping today? | 21:03 |
| rick_h_ | hatch: meh, semi swapping? e.g. destroyer of things blocking folks :) | 21:03 |
| hatch | haha ok creating hangout | 21:03 |
| hatch | https://plus.google.com/hangouts/_/76cpjlpbspqf8fkeidl096n1jg?authuser=1&hl=en | 21:04 |
| * bac dog walk. bye. | 21:15 | |
| hatch | rick_h_ lol wow this is embarrassing... https://gist.github.com/hatched/8944860 | 21:48 |
| huwshimi | Morning | 22:01 |
| hatch | hey huwshimi | 22:01 |
| hatch | huwshimi you're blocking the high priority lane with two cards btw | 22:04 |
| huwshimi | Well, I think the only course of action is for everyone to stop working until I've moved those cards! :) | 22:06 |
| huwshimi | I'm personally not a massive fan of my laptop hard locking every day. | 22:15 |
| hatch | haha | 22:17 |
| hatch | hard locking? Are you running different types of vm's? | 22:17 |
| hatch | when I run parallels and virtual box it hard locks instantly | 22:18 |
| huwshimi | hatch: Nothing like that... no idea what's causing it | 22:18 |
| huwshimi | hatch: Do you know how I can get a branch I created under OSX in Ubuntu? | 22:19 |
| hatch | jujugui looking for a review and qa for https://github.com/juju/juju-gui/pull/121 | 22:21 |
| hatch | are you using vagrant? | 22:21 |
| hatch | or are you running both on metal? | 22:22 |
| huwshimi | hatch: Maybe I should rephrase the question. I have a branch on GitHub that I want to play with locally, how do I do that? | 22:24 |
| hatch | git clone your fork | 22:24 |
| hatch | git checkout your branch | 22:24 |
| hatch | git clone <git repo url> | 22:25 |
| hatch | git checkout <branch name> | 22:25 |
| hatch | thaz it | 22:25 |
| hatch | heh what was the last message you got? | 22:26 |
| huwshimi_ | hatch: Crashed again :( | 22:26 |
| huwshimi_ | hatch: when I checkout I get "error: pathspec 'safari-bugfixes' did not match any file(s) known to git." | 22:26 |
| hatch | looking at your repo one sec | 22:27 |
| huwshimi_ | This is on an existing clone | 22:27 |
| hatch | run `git branch -a` is the branch there? | 22:27 |
| hatch | if not .... then `git fetch` | 22:28 |
| huwshimi_ | nope | 22:28 |
| hatch | after the git fetch? | 22:29 |
| huwshimi_ | ah, yes! | 22:29 |
| huwshimi_ | hatch: Thanks! | 22:29 |
| hatch | :) np | 22:29 |
| hatch | huwshimi_ looks like you have some conflicts in your PR | 22:30 |
| huwshimi_ | hatch: Yeah, that's what I'm trying to fix :( | 22:30 |
| hatch | alright well let me know if you need any help | 22:30 |
| huwshimi_ | hatch: Thanks, I think I just need to merge develop | 22:32 |
| hatch | hmph, somehow I hit a keyboard shortcut to quit the channel | 22:33 |
| Makyo | You are just having all sorts of problems. | 22:47 |
| hatch | haha nah | 22:52 |
| huwshimi_ | hatch: Fixed the build issues | 23:04 |
| hatch | cool | 23:04 |
| rick_h_ | hatch: lol, coolio | 23:06 |
| hatch | huwshimi_ think you could rebase it down to a single commit? | 23:06 |
| huwshimi_ | sure | 23:07 |
| hatch | you can keep the commit message with all the fix details | 23:07 |
| hatch | but just to keep the develop branch clean | 23:07 |
| huwshimi_ | hatch: So what process should I follow to rebase it? | 23:09 |
| hatch | rick_h_ is probably the best guy to ask because you have a merge in there | 23:09 |
| rick_h_ | huwshimi_: which branch is this? | 23:12 |
| huwshimi_ | rick_h_: Mine: https://github.com/juju/juju-gui/pull/120 | 23:12 |
| rick_h_ | looking | 23:13 |
| rick_h_ | huwshimi_: yea, don't merge develop if you don't need to before pushing up | 23:13 |
| huwshimi_ | rick_h_: There was a conflict with develop | 23:13 |
| rick_h_ | since that's your last commit I'd just rebase that away | 23:13 |
| rick_h_ | huwshimi_: ah, cool then | 23:14 |
| rick_h_ | then I'd have changed that commit message be 'resolve conflicts' | 23:14 |
| rick_h_ | so the goal is to rebase away the lint commit, change the message on the last one to "Resolve conflicts with develop" | 23:14 |
| rick_h_ | git rebase -i HEAD~~~~ | 23:14 |
| rick_h_ | and change the lint to a `s` to squash sit | 23:14 |
| rick_h_ | then `git ammend` should let you change the commit message of the last point | 23:15 |
| huwshimi_ | rick_h_: Oh, don't we want this as one commit? | 23:16 |
| rick_h_ | huwshimi_: naw, I think it's safe | 23:18 |
| rick_h_ | huwshimi_: I mean you're fixing a series of bugs | 23:18 |
| hatch | ok cool | 23:18 |
| rick_h_ | as long as it's sane it doesn't have to be one commit | 23:18 |
| rick_h_ | just don't need noise like 'lint' | 23:18 |
| rick_h_ | or 'prototype step 1' and such | 23:18 |
| huwshimi_ | rick_h_: http://dpaste.com/1606090/ | 23:23 |
| rick_h_ | huwshimi_: so should be a conflict to resolve | 23:25 |
| rick_h_ | git status | 23:25 |
| rick_h_ | look for the files that are modified and noted | 23:25 |
| huwshimi_ | ah, completed | 23:27 |
| rick_h_ | huwshimi_: cool | 23:27 |
| huwshimi_ | rick_h_: "git: 'ammend' is not a git command." | 23:27 |
| rick_h_ | bah, old version of git. | 23:27 |
| rick_h_ | git commit --ammend? | 23:27 |
| huwshimi_ | nope | 23:28 |
| huwshimi_ | this is just whatever version comes with Ubuntu I think | 23:29 |
| huwshimi_ | 13.10 | 23:29 |
| rick_h_ | huwshimi_: git commit --amend -m "New commit message" ? | 23:29 |
| huwshimi_ | git version 1.8.3.2 | 23:29 |
| * rick_h_ is looking | 23:29 | |
| huwshimi_ | What do I want that new commit message to be? | 23:29 |
| * huwshimi_ doesn't know what we're trying to achieve here | 23:30 | |
| rick_h_ | "Resolve conflicts with trunk" or the like vs "merge" | 23:30 |
| huwshimi_ | OK, that worked. Pushing up changes. | 23:32 |
| huwshimi_ | rick_h_: Pushing now fails: http://dpaste.com/1606119/ | 23:34 |
| rick_h_ | git push origin safari-bugfixes -f | 23:34 |
| huwshimi_ | rick_h_: Is this correct? https://github.com/juju/juju-gui/pull/120 | 23:38 |
| rick_h_ | huwshimi_: looking, looks crazy | 23:38 |
| rick_h_ | huwshimi_: give me a minute | 23:39 |
| hatch | holy schmoly | 23:42 |
| rick_h_ | hmm, git clone takes a while at 74k/s | 23:43 |
| rick_h_ | ugh, 77% | 23:44 |
| rick_h_ | go go go | 23:44 |
| huwshimi_ | rick_h_: Are you on your phone? | 23:49 |
| rick_h_ | huwshimi_: on my hotspot | 23:49 |
| rick_h_ | huwshimi_: going really slow atm :/ | 23:49 |
| rick_h_ | I'm at a LUG meetup atm | 23:49 |
| rick_h_ | at 81% | 23:50 |
| rick_h_ | sorry, trying to pull down your branch and to see/verify that the extra commits don't dupe/etc | 23:50 |
| rick_h_ | but need to clone first and guess 50MB is heavy for my current signal strength | 23:50 |
| rick_h_ | yay, downloaded...working on the branches now | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!