=== duflu_ is now known as duflu | ||
kdub | thanks for the review duflu | 01:48 |
---|---|---|
duflu | kdub: I don't claim to have tested it, but I support the idea :) | 01:49 |
=== jono is now known as Guest13828 | ||
RAOF | Oh, wow. | 07:14 |
RAOF | bzr merge -i --uncommitted works exactly like how I want it to work. | 07:14 |
=== alf is now known as alf_ | ||
mlankhorst | morning | 08:40 |
anpok_ | alan_g: duflu alf_: which direction should i go now.. | 10:29 |
anpok_ | keep report::, but drop lttng:: and report::logging? | 10:29 |
duflu | anpok_: Ever forward... ?! | 10:30 |
duflu | Oh | 10:30 |
duflu | anpok_: I prefer the namespaces how they are today. And would prefer even more if we had fewer than that. So abstain | 10:31 |
* duflu -> dinner | 10:31 | |
duflu | Good night | 10:31 |
alf_ | duflu: bye! | 10:31 |
alan_g | Bye | 10:31 |
=== alex__ is now known as alex-abreu | ||
=== greyback is now known as greyback|lunch | ||
=== om26er_ is now known as om26er | ||
=== dandrader is now known as dandrader|afk | ||
=== greyback|lunch is now known as greyback | ||
=== dandrader|afk is now known as dandrader | ||
=== alan_g is now known as alan_g|tea | ||
greyback | AlbertA: hey, quick comment on https://code.launchpad.net/~albaguirre/unity-mir/cross-compile-link-fix/+merge/205690 | 15:46 |
=== alan_g|tea is now known as alan_g | ||
anpok | alan_g: alf_: ... 200 lines less | 15:48 |
AlbertA | greyback: at least the mirserver library | 15:49 |
AlbertA | should be there | 15:49 |
AlbertA | as it's a direct dependency - it makes sure the api signatures haven't changed | 15:49 |
alan_g | anpok: It isn't the number of lines in the diff that matters. It is how easy it is to follow. | 15:50 |
AlbertA | greyback: Or not sure if you mean to use only the _LDFLAGS? | 15:54 |
greyback | AlbertA: yeah that was what I was asking. I was pouring over cmake manual to understand the difference | 15:54 |
greyback | AlbertA: _LIBRARIES seems to not set the -L path, which -LDFLAGS definitely does | 15:55 |
AlbertA | greyback: the LDFLAGS for those 3 packages at least just return -L path | 15:55 |
AlbertA | and the libraries flag sets -l<libname> | 15:55 |
greyback | AlbertA: http://www.cmake.org/cmake/help/v2.8.12/cmake.html <- searching for "_LDFLAGS" was what I was reading. I'm surprised now | 15:56 |
greyback | as it implies LDFLAGS contains all required linker flags (which I'd expect), whereas LIBRARIES contains list of lib names that need their pkgconfig scanned for linker flags | 15:59 |
greyback | do I mis-understand? | 15:59 |
anpok | greyback: the cmake pkg-config module creates a load of variables for each found library | 16:02 |
AlbertA | greyback: that's what I read too | 16:02 |
anpok | there is for example also PKG_NAME_LIBRARY_DIRS | 16:02 |
AlbertA | greyback: but it's essentially the output of pkg-config | 16:02 |
anpok | and that one could be used in link_directories() which is just symetric to include_directories() | 16:02 |
greyback | AlbertA: right | 16:02 |
greyback | So I guess I'm confused :) | 16:03 |
* greyback needs to dig a little more | 16:03 | |
anpok | i.e. look inside CMakeCache.txt of your build dir.. | 16:03 |
greyback | anpok: yeah I've been doing that, to check AlbertA's patch did what I expected, but now I'm unclear what's really happening | 16:05 |
greyback | mterry: comment on https://code.launchpad.net/~mterry/unity-mir/alpha-greeter/+merge/204069 | 16:18 |
mterry | greyback, noted. I tested on android and it worked! So apply_to must be doing something currently... | 16:21 |
greyback | mterry: nested in android? Or standalone? | 16:22 |
mterry | greyback, testing yourself is a little tricky. You'd need to install several branches to see the difference, but will add to MP | 16:22 |
mterry | greyback, nested | 16:22 |
mterry | greyback, oh, you say that | 16:22 |
greyback | mterry: yeah, that I expect to be ok. Just standalone I found apply_to wasn't being called | 16:22 |
mterry | greyback, fair. Though I don't happen to care about standalone case | 16:23 |
greyback | mterry: yep | 16:23 |
greyback | mterry: but I did for a while :) | 16:23 |
mterry | greyback, :) hey, how is the scenegraph stuff going, btw? | 16:24 |
greyback | mterry: oh I've not been able to touch it for weeks now. Hope to resume it after MWC. racarr is doing some Mir adjustments to help integrate it however | 16:25 |
mterry | greyback, cool. Poke me when it is more play-with-able. I eventually plan to use it in the USC for interstitial animations between sessions | 16:26 |
* mterry heads out to buy a ladder | 16:27 | |
greyback | mterry: really? Ok. /me thinks we'd better profile it carefully before nesting it like that | 16:27 |
AlbertA | greyback: you were right | 16:45 |
AlbertA | greyback: we only need LDFLAGS | 16:45 |
AlbertA | greyback: it does include everything like the docs say :) | 16:45 |
AlbertA | greyback: i.e. -L<path>;-l<libname> | 16:45 |
greyback | AlbertA: but I just tried compiling without LIBRARIES and it failed to link to mir! | 16:49 |
AlbertA | greyback: really? I tried here just using LDFLAGS it worked ok on both | 16:52 |
AlbertA | native and cross compiling | 16:52 |
greyback | let me try again, maybe I screwed something up | 16:53 |
greyback | AlbertA: you're correct, it works with just LDFLAGS | 16:57 |
AlbertA | I pushed a new revision | 16:58 |
AlbertA | to the branch | 16:58 |
greyback | AlbertA: and approved as it's exactly what I now have. Thank you! | 16:59 |
AlbertA | greyback: thanks! | 16:59 |
=== dandrader is now known as dandrader|lunch | ||
=== dandrader|lunch is now known as dandrader | ||
RAOF | anpok: It's not clear to me why logging:: should be under report::, as they're kinda two separate things. Not doing that move also reduces the namespace nesting somewhat. | 21:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!