[00:34] * karni notes to do the reviews [00:49] ff [08:42] tsdgeos, ping [08:42] Cimi: hi [08:42] tsdgeos, mhr3_ told me to use the video thumbailer in few cases [08:42] is source: widgetData["screenshot"] || widgetData["source"].startsWith("file://") ? "image://thumbnailer/..." : "" correct? [08:44] Cimi: think so [08:44] see uriToThumbnailerProviderString [08:44] basically does [08:44] if (uri.startsWith(QLatin1String("file:///"))) { [08:44] thumbnailerUri = BASE_THUMBNAILER_URI; [08:44] thumbnailerUri.append(uri.midRef(7)); [08:44] [08:45] Cimi, the "..." is supposed to be path to the video [08:45] mhr3_, ahah ok [08:45] mhr3_: the previews should be fine now [08:46] Cimi, don't forget to update the factory for the video widget [08:46] mhr3_, source: widgetData["screenshot"] || widgetData["source"].startsWith("file://") ? "image://thumbnailer/" + widgetData["source"] : "" ? [08:46] mhr3_: fixed it and karni reviewed [08:46] Cimi, you need to strip file:// [08:46] tsdgeos, awesome, thank you [08:46] does js support widgetData["source"][7:] ? [08:47] Cimi: and we have a release [08:47] Cimi: so remerge your stuff [08:47] Cimi: no [08:47] Cimi: cut the file:///, see the code i pasted [08:48] mhr3_, dunno [08:48] * Cimi prints [08:53] mhr3_, widgetData["source"].substr(7) might work [08:54] * tsdgeos shows http://www.w3schools.com/jsref/jsref_obj_string.asp to Cimi [08:54] mhr3_: are you doing https://code.launchpad.net/~unity-team/unity8/unity8.preview_image/+merge/205757 ? looks good enough to me now [08:56] tsdgeos, slice or substr ? [08:58] Cimi: substr i'd say [08:58] tsdgeos, what's diference-? [08:58] ah [08:58] position of end of char [08:59] or slice [08:59] yeah [08:59] see http://stackoverflow.com/questions/2243824/what-is-the-difference-between-string-slice-and-string-substring-in-javascript [08:59] it's "all do the same" kind of :D [09:01] mhr3_: ping [09:06] tsdgeos, pong [09:06] mhr3_: just to confirm, you wanted the data passed to the actions back right? [09:06] yep [09:07] ok, will have a MP for you to review in a few mins [09:13] mhr3_: https://code.launchpad.net/~aacid/unity8/actions_data_back/+merge/205915 [09:14] tsdgeos, help http://paste.ubuntu.com/6919000/ [09:15] lol [09:15] tsdgeos, home/cimi/Development/video/qml/Dash/Previews/PreviewVideoPlayback.qml:40: TypeError: Object file:///path/to/local/file has no method 'startsWith' [09:16] yeah no startswith in http://www.w3schools.com/jsref/jsref_obj_string.asp [09:16] me stupid [09:16] indexOf == 0 ? [09:17] Cimi: i'd do a function there [09:17] that'd be easier to read with proper if/else [09:17] and being able to assign stuff to a var [09:20] tsdgeos, i don't think the id is present in the attribute map [09:20] mhr3_: the test shows it is D: [09:21] and the json too [09:21] { [09:21] "type": "actions", [09:21] "actions": [{"label": null, "icon": null, "id": null}] [09:21] } [09:21] oh that's the action id [09:21] nvm [09:21] yea, ok [09:21] ep [09:21] yep [09:44] bregma: hi! Just to mention: I disabled and removed window-mocker from cu2d [10:05] sil2100: can we get a silo for unity8? [10:06] we have a good bunch of stuff to land again :-) [10:06] tsdgeos: ;) Sure, but we apparently have some spreadsheet problems right now, so once those are done we will assign ;) [10:08] tsdgeos, how's support for header looking? [10:08] sil2100: ok [10:08] mhr3_: should be landing soon [10:08] mhr3_: we can merge it to new-scopes already if you want [10:08] eh, if i knew 10minutes ago i would [10:08] mhr3_: lp:~aacid/unity8/preview_header [10:09] mhr3_: of course soon might mean tomorrow, since our CI train is not a high speed train :D [10:10] tsdgeos, tell me about it :) [10:33] http://bazaar.launchpad.net/~phablet-team/qtubuntu/trunk/view/head:/src/platforms/ubuntu/ubuntucommon/window.cc this code querries the opaque property from the window class [10:33] writes it to flags and ignores it then.. [10:33] is the opaque property in some way configureable for applications? [10:34] i.e. through a qml property? [10:38] anpok: reading the code i'd say no, but loicm should be the one that knows more [10:38] mzanetti: you did the DownloadTracker thing? [10:39] Saviq did [10:39] it seems [10:39] downloadtracker? [10:39] never heard of that [10:39] :D [10:39] wonder if we have tests for it [10:40] well we have a mock so may as well [10:41] cool [10:41] we do [10:43] Cimi: you need to hook up https://code.launchpad.net/~unity-team/unity8/unity8.preview_video/+merge/205802 to the factory too [10:44] tsdgeos, I did locally [10:44] cool [10:44] tsdgeos, I' writing tests for the image thumnnailer [10:45] oki [10:45] or [10:45] hmmm [10:45] Cimi: maybe no need [10:45] Cimi: i was promised ages ago, the thumbnailer would move from our codebase [10:45] so not sure it makes sense to invest time in that now [10:46] thumbnailer is in uitk [10:49] right, ok [10:49] Cimi: so what are you testing? [10:49] tsdgeos, yey, running apps in demo ppa :) [10:50] mhr3_: awesome, didn't think it'd work :D [10:50] * tsdgeos hides [10:50] lol [10:50] it does :P [10:50] tsdgeos, pushed [10:51] merging to new-scopes [10:56] tsdgeos, the headers look bad with the white bkgr [10:57] mhr3_: ok, will have to have a look at visuals [10:57] mhr3_: and maybe hardcode a few things for now [10:57] it's on the list [10:57] * make sure visuals are correct [10:57] k [10:57] tsdgeos, do you see anything else majorly missing for new-scopes? [10:57] besides progress widget [10:58] and me providing you with all the preview stuff [10:58] mhr3_: this is my todo http://paste.ubuntu.com/6919377/ [10:58] progress is almost done [10:58] need the tests [10:58] there's reviews preview widget and rating-input preview widget that Cimi will do next? [10:59] and there's a few stuff that probably needs to be tweaked [10:59] but it isn't looking that bad [10:59] tsdgeos, doing them now [10:59] mhr3_: Cimi: anything you find missing in that todo list? [10:59] tsdgeos, looks like you're missing some [DONE] ;) [10:59] well i need to remove them :D [10:59] well we first need to approve the cimi ones [11:00] i'm doing the last test [11:00] and will approve [11:00] tsdgeos, our next major thing is the progress widget, the click guys will need it to do end-to-end test [11:00] will be there in 30 mins or less hopefully [11:00] that's too fast, pls slow down :P [11:02] tsdgeos, link to MR check list? [11:02] https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8 [11:03] can we just add it when answer is negative? [11:03] what's the point? [11:03] tsdgeos, once we have all this we should talk about temp dash pages [11:03] Cimi: what is negative? [11:03] mhr3_: that's not so easy [11:04] but sure :D [11:04] tsdgeos, lucky you then, i was already pushing back on that [11:04] mhr3_: "so easy" -> hard [11:04] but talking is "free" [11:04] but yeah, i don't think we'll have time to do it tbh [11:05] so.. next week ;) [11:05] let's try to talk about it on fri [11:05] tsdgeos, when I don' test, I say I did not test [11:05] tsdgeos, it's obvious we do the checklist [11:05] tsdgeos, I always did it [11:05] Cimi: well, what do you need to test in those things that aren't hooked up anywhere? [11:05] in the last 4 years here [11:06] Cimi: i know, it's silly [11:06] it's not me that came up with rules that make us look as we are children that need to reminded to do our jobs [11:06] who did? [11:06] no clue [11:07] Cimi: so about your image and video stuff [11:07] they conflict with lp:~aacid/unity8/preview_header [11:07] where? [11:07] can you merge lp:~aacid/unity8/preview_header into them and make lp:~aacid/unity8/preview_header be the prerequisite for lp:~unity-team/unity8/unity8.preview_image ? [11:07] the factory [11:07] ok [11:08] tx [11:13] tsdgeos, done for both [11:14] tx [11:16] Cimi: can you resubmit https://code.launchpad.net/~unity-team/unity8/unity8.preview_image/+merge/205757 with the correct prerequisite? [11:17] where would I enter the PIN [11:17] used n4 without a sim card up to now [11:20] one of the indicators has "unlock sim" [11:20] tsdgeos, all done [11:28] mzanetti: can you add https://code.launchpad.net/~unity-team/unity8/unity8.preview_image/+merge/205937 and https://code.launchpad.net/~unity-team/unity8/unity8.preview_video/+merge/205802 to the list of MPs? [11:28] mzanetti: ideally at the end and in that order [11:29] since they depend on eachother and in others that are already in the list [11:29] tsdgeos: done [11:30] tsdgeos, here [11:30] gatox: no idea about unity-scope-tool to be honest [11:30] i've just used unity8 itself [11:30] with the scopes of scopes that mhr3_ pointed me to [11:30] tsdgeos, how were you testing that the preview is being displayed? [11:30] and it works [11:31] mhr3_: what are you using unity8 or unity-scope-tool? [11:31] tsdgeos, can you tell me how to reproduce it [11:31] ? [11:31] gatox: how to reproduce what? the unity8 binary? [11:31] tsdgeos, i ask because the same scope that was showing results of the search yesterday..... now it doesn't show even that [11:32] hmmm [11:32] we didn't change anything search related [11:32] tsdgeos, how can i execute anything unity8/unity-scope-tool or something that will allow me to see the preview working [11:32] gatox: build unity8 [11:32] or just install it from the demo-stuff ppa [11:32] it's just easier [11:32] tsdgeos, i'm testing on the desktop [11:33] gatox: yes you can do both things i mentioned (build and use the demo-stuff ppa) [11:33] https://launchpad.net/~unity-team/+archive/demo-stuff [11:33] on the desktop [11:33] tsdgeos, ok, i already build the new-scopes branch in the desktop [11:33] gatox: and is your scope showing? [11:33] tsdgeos, both [11:34] tsdgeos, i'm running it like this: UNITY_FORCE_NEW_SCOPES=1 ./builddir/tools/unity-scope-tool --scope-dir /media/gatox/leeloo/canonical/clickhack/demo [11:34] tsdgeos, how are you doing it? [11:34] gatox: as i said, i am not running /unity-scope-tool, i just ran unity8 and that's it [11:34] i haven't used unity-scope-tool much tbh [11:34] tsdgeos, and you are using just ./run? [11:34] gatox: yes [11:34] gatox, there's latest version of libunity-scopes in distro now, you need to recompile the scope [11:35] mhr3_, checking that [11:35] gatox, scope-tool should print an error from scoperunner about some ABI mismatch [11:37] gatox, sorry, looks like you weren't on the mail about the break [11:40] tsdgeos: assigning this to you, ok? https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1279298 [11:40] Launchpad bug 1279298 in unity8 (Ubuntu) "Header title sometimes disappears" [Undecided,Confirmed] [11:41] mzanetti: sure [11:41] mzanetti: it's the SDK people that don't stop messing with the tabs [11:41] :D [11:41] and they're rewriting/killing them again ^_^ [11:41] mhr3_, does the api changed or something? i'm getting a weird issue when trying to build the scope about the create_query and preview function not being override.... which was working yesterday [11:42] gatox, yes, http://bazaar.launchpad.net/~unity-team/unity-scopes-api/devel/view/head:/RELEASE_NOTES.txt [11:42] checking [11:42] gatox, there's a branch that fixes all that already [11:42] just merge it [11:46] gatox, btw the envvar isn't necessary [11:47] if you're using the new-scopes branch [11:47] ack [11:47] actually it might even be breaking things === _salem is now known as salem_ [11:51] mzanetti, would you have time to review that? https://code.launchpad.net/~dandrader/unity8/rotatedDDA/+merge/205845 [11:52] dandrader: mind adding the checklist [11:53] greyback, ^^^ that fixes the rotation issue with edge drags [11:53] mzanetti, ah, let me find it [11:53] dandrader: nice [11:54] greyback, I've merged it already in the unity8/rotate-n7 branch [11:54] dandrader: I know, am using it :) [11:56] Cimi: mhr3_: https://code.launchpad.net/~aacid/unity8/preview_progress/+merge/205939 [11:57] tsdgeos, kill empty double new lines :) [11:58] :D [11:58] tsdgeos, mhr3_ everything working using unity-scope-tool with the scope migrated to the new api.... thx both! [11:58] Cimi: there's more than one? [11:58] tsdgeos, there are few ones [11:59] really? [11:59] * tsdgeos looks again [11:59] tsdgeos, 25 + [11:59] 68 + [11:59] 147 + [11:59] so there are two [11:59] 68 is not a dobule line! [11:59] but i'll kill it too [12:00] done [12:00] gatox, cool [12:01] tsdgeos, looks good [12:01] tsdgeos, i am wondering though - all those widgetData["foo"], are those properly bound? [12:02] tsdgeos, i mean, the widgetData thing is a role in model and that thing can be updated [12:03] tsdgeos, how about choosing Moto G instead nexus 4 as our new device? [12:03] someone wants to play with new hardware :) [12:03] tsdgeos, nexus 4 are no longer available [12:03] mhr3_, ^ [12:04] mhr3_, and mogo G is less than half price [12:04] *moto G [12:04] and here i thought the n4 is the cheapest smartphone ever [12:04] dandrader: "// NB:..." always triggers "Nicht beachten" in my head which means "disregard this:" :D [12:05] mhr3_, you can find it for £250 N4 [12:05] mhr3_, spent 119 for Moto G [12:05] mzanetti, :) [12:05] comparable specs [12:06] Cimi: i'm not in position to decide that :D [12:06] tsdgeos, I know you're not [12:06] Cimi: not sure what is your concern about widgetData stuff [12:06] tsdgeos, neither I am [12:06] tsdgeos, but was asking your opinion [12:06] Cimi: but with motorola sold to lenovo, i'm wondering how much live motog has :D [12:06] hah [12:06] Cimi, well n4 is like $200 in us, which is about 120gbp, so it's actually pretty similar [12:06] wonder why the uk price is so crazy [12:07] mhr3_, isn't it out of production? [12:07] well yea, now it is [12:07] mhr3_, 200 is a lot [12:07] mhr3_, moto G is 99$ in us [12:07] ok, nvm then :) [12:07] greyback: you already tested dandraders branch on a rotated N7? [12:08] mzanetti: not in isolation yet. But if you give me 5 mins, I can [12:08] greyback: cool. I'll test it with standard rotation [12:08] code looks ok to me [12:09] mhr3_, 200$? http://www.amazon.com/s/ref=nb_sb_noss_1?url=search-alias%3Daps&field-keywords=nexus%204 [12:09] it's 360 [12:10] Cimi, understandable since google doesn't sell anymore [12:10] but it was 200 when they did [12:10] mhr3_, I know [12:11] mhr3_, but now, we're spending lots for getting out of production phones [12:11] mhr3_, wondering if it'll happen like galaxy nexus [12:12] Cimi, problem with any hardware, no? either n4 or moto g will be obsolete in a few months [12:13] well, moto g nope [12:13] it's on the market since a month [12:13] nexus 4 over a year [12:13] android 4.4 (kitkat) supports Nexus4, but the GNexus doesn't. So N4 should be good for a long while yet [12:14] greyback, issue is that we can't buy them easily anymore [12:14] greyback, I'd be happy to try porting ubuntu touch on my moto g (my private phone) [12:14] it's a jewel for its price [12:14] battery lasts 3 days with the pebble :) [12:14] tsdgeos, we lost the search activity indicator btw [12:15] mhr3_: in new-scopes? [12:15] tsdgeos, also in trunk [12:15] Cimi: sure, it's not the newest phone, but our software stack will support it for at least another year probably. [12:15] mhr3_: waaaa [12:15] but we didn't merge anything that touched that :S [12:16] tsdgeos, well, better double check with vanilla image, my isn't exactly vanilla :) [12:16] mhr3_: seems it got lost yes :S [12:16] mhr3_: can you open a bug and assign it to me plz [12:16] mhr3_: did you guys change anything in the backend? [12:16] nope [12:17] at least i'm not aware.. maybe we did break it [12:17] but it's not like we touched the old scope code [12:19] tsdgeos, https://bugs.launchpad.net/unity8/+bug/1279316 [12:19] Launchpad bug 1279316 in Unity 8 "Search activity indicator not present" [Undecided,New] [12:20] mhr3_: tx [12:24] tsdgeos, something's broketh http://imgur.com/8jKw2zf [12:24] booo [12:25] video + header + actions [12:25] i'd say video is broken [12:25] header + action looks good [12:25] assuming that 16xxxx is the header [12:25] yea [12:27] mhr3_: so it seems the search has been broken for a while [12:27] just nooen noticed [12:27] i know what's wrong [12:27] tsdgeos, also, the carousel doesn't show anything if there are only a few items [12:28] mhr3_: new-scopes? [12:28] (just category header) [12:28] yea [12:28] should show a grid [12:28] it doesn't [12:28] but it may happen that the magic is not working [12:28] * tsdgeos writes to the TODO list === MacSlow is now known as MacSlow|lunch [12:30] tsdgeos, maybe you want to check the demo ppa, there may be other issues i'm ignoring :) [12:30] mhr3_: sure i know [12:30] mhr3_: i'm just fixing the ones we know about first ;) [12:31] k [12:31] tsdgeos: huh? https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1165/? [12:31] mzanetti: yes? [12:31] tsdgeos: did we get this test released in a broken state? [12:31] yes [12:31] and your branch from today morning fixes this, ok [12:31] don't tell anyone [12:31] no prob [12:31] was just wondering how daniel's branch could fail on this now [12:32] everything is failing until we merge the fix [12:32] ack [12:35] greyback: please top approve when you're happy with the DDA on Nexus 7: https://code.launchpad.net/~dandrader/unity8/rotatedDDA/+merge/205845 [12:35] * mzanetti is happy with it [12:35] mzanetti: ack [12:37] mhr3_: if you feel like reviewing https://code.launchpad.net/~aacid/unity8/bug1279316/+merge/205952 that'd be great otherwise i can try to get Cimi or mzanetti to do it [12:40] tsdgeos, acked [12:40] Cimi: can you quick fix https://code.launchpad.net/~unity-team/unity8/unity8.preview_video/+merge/205802 ? [12:40] mhr3_: tx [12:41] tsdgeos, mmm [12:41] tsdgeos, I have implicitWidth [12:41] height? [12:42] tsdgeos, width [12:42] yes [12:42] i know [12:42] yes [12:42] tsdgeos, I got inspired by MoviePreview [12:42] but what about height? [12:42] tsdgeos, it is calculated from width [12:42] the inner one [12:42] not the outer one [12:42] your outer widget ahs no height [12:43] tsdgeos, but if I set height [12:43] tsdgeos, then how does the inner widget work? [12:43] if it is supposed to calculate from width? [12:43] you're missing a height: childrenRect.implicitHeight [12:43] or something along these lines [12:43] I am not sure [12:43] are yo? [12:43] i am [12:43] your widget has 0 height [12:44] how is that valid? [12:44] tsdgeos, other widget might have 0 width then [12:44] tsdgeos, we never specify width [12:44] we do [12:44] I cannot see implicitWidth here [12:44] on other widgets [12:45] i know [12:45] so why height and not width? [12:45] because width is set by the widget creator [12:45] i.e. [12:45] http://paste.ubuntu.com/6919775/ [12:45] this is what the Preview does [12:46] creates one widget after the other [12:46] and gives them widget [12:46] s/widget/width [12:46] but can't give them height because it doesn't know [12:46] Cimi: basically see http://imgur.com/8jKw2zf [12:47] the video doesn't define height [12:47] so stuff can't know where to add itself [12:47] tsdgeos, I see [12:47] tsdgeos, so it's basically to fit our use case [12:47] and to do the right thing :-) [12:48] every widget should either define width/height/implicitWidth/implicitHeight correctly [12:48] if there are that do not [12:48] well we have to fix them, but if the missing thing is width/implicitWidth it's less pressing since our current use case doesn't need them [12:48] tsdgeos, but we don't for width [12:48] yeah [12:48] Cimi: in which one we don't? [12:50] tsdgeos, look at others, we don't add implicitWidth iirc [12:50]