| === zoktar_ is now known as zoktar | ||
| === xnox_ is now known as xnox | ||
| === Pici is now known as Guest56659 | ||
| === jamesh__ is now known as jamesh | ||
| === jhodapp is now known as jhodapp|afk | ||
| === duflu__ is now known as duflu | ||
| karni | Can someone perhaps kick off a build please? https://code.launchpad.net/~unity-team/+recipe/unity8-daily-newscopes | 06:11 |
|---|---|---|
| karni | times out for me (known lp bug) | 06:11 |
| tsdgeos | lol my unity7 launcher doesn't open totally | 08:39 |
| tsdgeos | only something like 80% or something | 08:39 |
| didrocks | tsdgeos: probably because it's not fully awake yet :) | 08:40 |
| tsdgeos | yeah | 08:41 |
| tsdgeos | no | 08:41 |
| tsdgeos | i got some hickup while it was expanding | 08:41 |
| tsdgeos | and got upset | 08:41 |
| tsdgeos | had to restart unity | 08:41 |
| didrocks | interesting… I remember we had that issue in the far far past | 08:41 |
| didrocks | when there was a race due to xorg barriers and unity | 08:41 |
| didrocks | the fix was in xorg to send the right offset | 08:42 |
| didrocks | but as we moved to a new one and the barrier has changed, I bet that additional code has been dropped | 08:42 |
| tsdgeos | mhr3: https://bugs.launchpad.net/unity-scopes-shell/+bug/1279439 ? | 09:00 |
| ubot5 | Launchpad bug 1279439 in Unity 8 "Icons for non-click apps are shown empty" [Undecided,New] | 09:00 |
| mhr3 | tsdgeos, good question, how do we want to handle that? | 09:05 |
| mhr3 | tsdgeos, should we make the scopes use the image://theme/ uris? | 09:05 |
| mhr3 | that would fix it | 09:06 |
| tsdgeos | depends on what you say that result is | 09:06 |
| mhr3 | but then we're committing to those uris | 09:06 |
| tsdgeos | if you return image://theme then making a PHP based shell is harder | 09:06 |
| tsdgeos | because they have to replace all that | 09:07 |
| tsdgeos | but if it is "standard" it's ok | 09:07 |
| tsdgeos | mhr3: i'd do it at the unity-scopes-shell level | 09:07 |
| tsdgeos | which is a "translate scopes to shell" layer | 09:07 |
| tsdgeos | so then we can do a unity-scopes-php-shell project that does the appropiate translation | 09:07 |
| mhr3 | tsdgeos, but the scope is already tying itself to the system by using theme icons | 09:08 |
| tsdgeos | sure | 09:08 |
| tsdgeos | it just boils down if you want to commit to "image://theme" officially or not | 09:08 |
| mhr3 | indeed | 09:08 |
| mhr3 | but i'd prefer art to always be a uri | 09:08 |
| mhr3 | so we don't need crazy if (this_looks_like_a_uri) ... else ... | 09:09 |
| tsdgeos | mhr3: your team's call, i don't care :D | 09:16 |
| anpok | what is the difference between launching applications with upstart-app-launch <appname> and /usr/bin/dialer-app --desktop_file=path-to-/dialer-app.desktop? | 09:27 |
| mhr3 | tsdgeos, does http://paste.ubuntu.com/6924594/ look ok? | 09:32 |
| mhr3 | (the plugin will finally expose the per-column models) | 09:32 |
| tsdgeos | mhr3: hmmm, don't know | 09:33 |
| tsdgeos | mhr3: what does get(0) do? | 09:33 |
| mhr3 | tsdgeos, gets the first item from the model | 09:34 |
| tsdgeos | what is a "per-column" model? | 09:34 |
| mhr3 | just writing this into mp | 09:35 |
| mhr3 | Split PreviewModel into 3 separate models - PreviewStack which holds a bunch of PreviewModels (for nested previews, currently always holds just one), and PreviewModels contain per-column PreviewWidgetModels, which in turn contain the actual widgets. | 09:35 |
| mhr3 | tsdgeos, if shell tells the PreviewStack to use two columns (as it would on the tablet), each PreviewModel will expose two PreviewWidgetModels | 09:36 |
| tsdgeos | i am still confused | 09:37 |
| tsdgeos | you wrote 3 separate models | 09:37 |
| tsdgeos | but i don't understand what that means | 09:38 |
| mhr3 | tsdgeos, quick hangout? | 09:38 |
| tsdgeos | sure | 09:38 |
| mhr3 | tsdgeos, looks like i'm calling you, but it didn't give me a link | 09:40 |
| tsdgeos | :D | 09:40 |
| mhr3 | you should see it if you log onto plus | 09:40 |
| tsdgeos | you calling my canonical or the gmail account? | 09:42 |
| tsdgeos | an the gmail one | 09:42 |
| tsdgeos | back in a sec | 09:48 |
| tsdgeos | my unity has died | 09:48 |
| === MacSlow_ is now known as MacSlow | ||
| ESphynx | hey guys, would someone please explain to me how to get an app to go full screen over the dock and the menu bar with _NET_WM_STATE_FULLSCREEN ? | 09:57 |
| ESphynx | The only I manage to get my window on top of those is with override_redirect = True, but that has lots of other problems... | 09:57 |
| mhr3 | tsdgeos, https://code.launchpad.net/~mhr3/unity-scopes-shell/preview-split/+merge/206130 | 09:57 |
| mhr3 | pstolowski, could you take a look too? has the layout bits and other stuff | 09:58 |
| tsdgeos | woot | 09:59 |
| tsdgeos | that's big | 09:59 |
| ESphynx | anyone got a clue why Unity always shows the dock on top of my 'fullscreen' app ? | 10:01 |
| pstolowski | mhr3, sure | 10:04 |
| mhr3 | pstolowski, will need some api additions, to be able to do the nested previews :) | 10:05 |
| mhr3 | but not today | 10:05 |
| mhr3 | nor this week | 10:05 |
| pstolowski | mhr3, yeah, I was about to say this | 10:06 |
| === mirco is now known as MacSlow | ||
| tsdgeos | mzanetti: can you do https://code.launchpad.net/~aacid/unity8/lvwph_resize_item_bug/+merge/206140 ? | 10:34 |
| mzanetti | tsdgeos: ok. in a bit | 10:35 |
| tsdgeos | mhr3: so waht do we do with the icon theme thing? | 10:39 |
| mhr3 | tsdgeos, commented on the bug, i want uris | 10:39 |
| tsdgeos | ah, didn't see the comment | 10:39 |
| tsdgeos | mhr3: so close as invalid? | 10:39 |
| mhr3 | please | 10:39 |
| tsdgeos | mhr3: i tried turning the onlinemusic to a carousel, but then i can't make it return few results, so can't test the carousel -> grid transformation :/ | 10:52 |
| mhr3 | tsdgeos, "nonordinary" | 10:52 |
| tsdgeos | ok | 10:53 |
| tsdgeos | that works, tx | 10:53 |
| seb128 | macSlow, macSlow_: hey, how are you? | 10:54 |
| seb128 | macSlow, macSlow_: do you want to review https://code.launchpad.net/~larsu/notify-osd/always-use-workarea/+merge/206145 ? | 10:54 |
| MacSlow | hey seb128... busy debugging some branch-failure on jenkins | 10:55 |
| seb128 | macSlow, macSlow_: I've tested it in quite some configs, seems to work fine, let me know if you want to review/test it as well or if I should just approve it | 10:55 |
| MacSlow | seb128, I can look into that branch today too np | 10:55 |
| seb128 | MacSlow: thanks | 10:55 |
| tsdgeos | mhr3: https://code.launchpad.net/~aacid/unity8/new-scopes-carousel-as-grid/+merge/206148 | 11:08 |
| tsdgeos | mhr3: btw i did add the progress stuff | 11:08 |
| tsdgeos | to new-scopes | 11:08 |
| mhr3 | tsdgeos, hmm, won't that break the way from grid to carousel? | 11:21 |
| tsdgeos | mhr3: no | 11:21 |
| tsdgeos | mhr3: it is inside CardFilterGrid.qml | 11:21 |
| tsdgeos | it's always a Grid if you're there | 11:21 |
| mhr3 | tsdgeos, consider that the model has 3items after first bunch of results get back from the back, 2seconds later another 15arrive | 11:22 |
| mhr3 | backend* | 11:22 |
| tsdgeos | yes | 11:22 |
| tsdgeos | that will not be a CardFilterGrid | 11:22 |
| tsdgeos | can't be | 11:22 |
| tsdgeos | wheter that works or not | 11:22 |
| tsdgeos | i don't know | 11:22 |
| tsdgeos | but it can't be breaking it | 11:22 |
| mhr3 | after the 3items it would be FilterGrid | 11:23 |
| mhr3 | and then you modify the layout, so it won't even try to be carousel | 11:23 |
| mhr3 | that's how i see it | 11:23 |
| tsdgeos | you see it wrong :) | 11:23 |
| Cimi | I forgot | 11:23 |
| Cimi | what does the ternary var || "something else" we use imply? | 11:23 |
| Cimi | tsdgeos, ^ | 11:23 |
| Cimi | which conditions on var? | 11:24 |
| tsdgeos | mhr3: getRenderer in GenericScopeView will say "oh wait the number of results has changed so let's use a CardCarousel instead of a CardFilterGrid" | 11:24 |
| Cimi | undefined/null what? | 11:24 |
| tsdgeos | Cimi: example? | 11:24 |
| mhr3 | tsdgeos, so you're saying the var t = ...; makes a deep copy/ | 11:24 |
| mhr3 | ? | 11:24 |
| Cimi | widgetData["review-label"] || "Review" | 11:25 |
| tsdgeos | mhr3: yes | 11:25 |
| Cimi | tsdgeos, in which cases it chooses "Review" | 11:25 |
| tsdgeos | mhr3: or maybe not | 11:26 |
| * tsdgeos scratches head | 11:26 | |
| mhr3 | Cimi, same as it's use widgetData[review-label] if ( widgetData["review-label"] != undefined && ditto != null ) else use the default you specify | 11:27 |
| Cimi | mhr3, sure? | 11:27 |
| Cimi | mhr3, good then | 11:27 |
| mhr3 | yes | 11:27 |
| Cimi | mhr3, I just wanted to be sure of which checks | 11:27 |
| Cimi | mhr3, cause I had issues with assigning null | 11:28 |
| mhr3 | although i'm not completely sure how it works with nulls and empty string and the like | 11:28 |
| mhr3 | js secrets | 11:29 |
| mhr3 | tsdgeos, so, did you make up your mind? :) | 11:33 |
| tsdgeos | mhr3: so it does modify the original | 11:33 |
| tsdgeos | but i'm not so sure it's a problem | 11:33 |
| tsdgeos | but i'll have a different solution anyway just in case | 11:33 |
| mhr3 | well... on one hand it forbids the grid -> carousel transition | 11:34 |
| mhr3 | on the other maybe we don't want it | 11:34 |
| mhr3 | would be disruptive | 11:34 |
| tsdgeos | f5 | 11:35 |
| tsdgeos | ahhhhhhhh | 11:35 |
| tsdgeos | damn | 11:35 |
| tsdgeos | pushed to wrong place | 11:35 |
| tsdgeos | mhr3: now https://code.launchpad.net/~aacid/unity8/new-scopes-carousel-as-grid/+merge/206155 | 11:38 |
| tsdgeos | this is safer | 11:38 |
| dandrader | tsdgeos, have you had bad experiences with qFuzzyCompare? Is it that broken or am I doing something wrong? http://paste.ubuntu.com/6921245/ | 11:40 |
| tsdgeos | he he | 11:40 |
| tsdgeos | dandrader: i know it is some level of broken when comparing against 0 | 11:40 |
| tsdgeos | but to be honest never encountered such a case myself | 11:40 |
| dandrader | tsdgeos, now I'm just doing QVERIFY(qAbs(actual - expected) > 0.001) | 11:41 |
| mhr3 | tsdgeos, property string categoryLayout: template["category-layout"] || "" | 11:41 |
| mhr3 | ? :) | 11:41 |
| tsdgeos | mhr3: that will fail if template is null | 11:42 |
| mhr3 | dandrader, you might want < instead :) | 11:42 |
| tsdgeos | mhr3: well not fail but spit out a warning | 11:42 |
| Cimi | mhr3, the "id" for rating-input | 11:43 |
| Cimi | mhr3, what is it used for? | 11:43 |
| tsdgeos | have enough warnings already, don't want to add more :D | 11:43 |
| Cimi | how shall I use it? | 11:43 |
| mhr3 | tsdgeos, ok | 11:43 |
| mhr3 | Cimi, which id exactly? | 11:43 |
| Cimi | mhr3, there's an id in the json spec | 11:44 |
| Cimi | maybe tsdgeos knows | 11:44 |
| Cimi | looks like similar to progress? | 11:44 |
| mhr3 | Cimi, it's the regular widgetId, every widget has that | 11:44 |
| tsdgeos | Cimi: mhr3: this one "id": null, // mandatory here! | 11:45 |
| tsdgeos | ? | 11:45 |
| Cimi | tsdgeos, yup | 11:45 |
| tsdgeos | i have no idea why it says "mandatory to null" | 11:45 |
| tsdgeos | but yes it's the thing we store in widgetId | 11:45 |
| tsdgeos | just pass it up in the triggered signal | 11:45 |
| tsdgeos | up/down/somedirection | 11:45 |
| tsdgeos | if we are using triggered | 11:46 |
| tsdgeos | if not, ignore i'd say | 11:46 |
| mhr3 | we are | 11:46 |
| Cimi | mhr3, what if you set visible to rating but required review? | 11:51 |
| Cimi | it won't work :D | 11:51 |
| Cimi | what shall we do in those cases? | 11:52 |
| mhr3 | Cimi, indeed, and the scope author needs to fix it | 11:52 |
| Cimi | ok | 11:52 |
| mhr3 | tsdgeos, so what about the background-color thing? | 11:53 |
| tsdgeos | mhr3: we need a new json for that? | 11:53 |
| mhr3 | tsdgeos, i'd treat it the same way we do title and all the other components | 11:53 |
| tsdgeos | sure | 11:54 |
| tsdgeos | i meant a new property | 11:54 |
| tsdgeos | sorry | 11:54 |
| mhr3 | you mean role in the model? | 11:54 |
| dandrader | mzanetti, greyback: I've added more fixes to https://code.launchpad.net/~dandrader/unity8/rotatedDDA/+merge/205845 | 12:03 |
| mzanetti | dandrader: ok... will take a bit before I come this again tho | 12:03 |
| dandrader | mzanetti, greyback so you might like to ta a look at those new commits before top approving once again | 12:03 |
| dandrader | mzanetti, np | 12:03 |
| greyback | dandrader: this I confirm works correctly | 12:04 |
| === zequence_ is now known as zequence | ||
| bregma | hey sil2100, didrocks we're down to 9 failures in Unity CI, time for a distro landing I think | 12:22 |
| sil2100 | \o/ | 12:22 |
| sil2100 | Ouuu yeaaa | 12:22 |
| sil2100 | didrocks: ^ should we use CITrain for that as well, or can we simply release through cu2d? | 12:22 |
| didrocks | waow :) | 12:22 |
| didrocks | sil2100: I guess we should use CI Train (if you are happy handling it) | 12:22 |
| didrocks | that would be the right time to switch it | 12:22 |
| sil2100 | didrocks: ok ;) | 12:23 |
| didrocks | sil2100: I think nothing else is on your plate, right now, isn't it? you have time for that? | 12:23 |
| didrocks | (apart from the remaining AP messaging-app) | 12:24 |
| sil2100 | didrocks: I'm switching it off in cu2d in a moment | 12:24 |
| didrocks | excellent! | 12:24 |
| didrocks | sil2100: I guess it's not only unity, but nux, compiz… and the whole world | 12:24 |
| didrocks | check with bregma I guess :) | 12:24 |
| tsdgeos | mhr3: arg | 12:24 |
| didrocks | bregma: excellent work, 9 failures, we never had that :p | 12:24 |
| tsdgeos | mhr3: yes i mean role in the model | 12:25 |
| sil2100 | bregma: what do you want us to release? unity + nux + compiz? libunity has been already released if anything ;) | 12:25 |
| bregma | didrocks, sil2100, yes the whole stack | 12:25 |
| tsdgeos | mhr3: can you reproduce the first tab title not showing until you swipe back and forth? | 12:25 |
| * bregma is squirming in excitement | 12:25 | |
| didrocks | ahah :) | 12:26 |
| mhr3 | tsdgeos, happens with scope tool pretty much all the time | 12:26 |
| didrocks | sil2100: maybe confirm with bregma the whole source package list? | 12:26 |
| tsdgeos | mhr3: ok, i'll give you a patch for it and tell me if it fixes it | 12:26 |
| mhr3 | k | 12:26 |
| bregma | sil2100, far as I know it's just compiz, nux, and unity everythiong else has been landing | 12:27 |
| tsdgeos | mhr3: https://code.launchpad.net/~aacid/unity8/fix-new-scopes-tab-name-missing/+merge/206162 | 12:27 |
| sil2100 | bregma: I'll set you as a lander for those ;) | 12:27 |
| sil2100 | Feel invited to the CITrain bootcamp on Monday! | 12:28 |
| tsdgeos | mhr3: give it minute, still not pushed | 12:28 |
| Cimi | tsdgeos, tests are taking time.... | 12:29 |
| Cimi | tsdgeos, I'm testing all conditions | 12:29 |
| Cimi | with rating/reviews | 12:29 |
| tsdgeos | Cimi: good! | 12:29 |
| Cimi | tsdgeos, not much code but trying it simply | 12:29 |
| tsdgeos | mhr3: now, https://code.launchpad.net/~aacid/unity8/fix-new-scopes-tab-name-missing/+merge/206162 :D | 12:29 |
| mhr3 | tsdgeos, fixes it | 12:30 |
| tsdgeos | mhr3: ok, so i'd say let's merge it, since somebody said people want tabs to die there anyway, no need to investigate much more | 12:30 |
| mhr3 | tsdgeos, ack, +1ed, pls merge | 12:31 |
| tsdgeos | mhr3: done | 12:31 |
| mhr3 | tsdgeos, pushing also the previewmodel splitup fix | 12:32 |
| === MacSlow is now known as MacSlow|lunch | ||
| tsdgeos | mhr3: do we have the new unity-scopes-shell too? | 12:33 |
| tsdgeos | otherwise it'll break too, no? | 12:33 |
| mhr3 | not yet, going to build it in the ppa | 12:33 |
| mhr3 | yea | 12:33 |
| tsdgeos | ok | 12:33 |
| sil2100 | bregma: I should use lp:compiz/0.9.11 for compiz, right? | 12:35 |
| tsdgeos | mhr3: let's spec the background color thing if you want, that's the last feature i think as missing (besides billions of fixes here and there) | 12:35 |
| mhr3 | tsdgeos, and the other billion for next week :) | 12:35 |
| tsdgeos | sure | 12:35 |
| bregma | sil2100, yes, compiz 0.9.11 | 12:37 |
| seb128 | bregma, landing coming?! | 12:41 |
| seb128 | bregma, good morning ;-) | 12:42 |
| sil2100 | I'm preparing a landing slot ;) | 12:42 |
| seb128 | \o/ | 12:42 |
| sil2100 | didrocks, bregma: slot is being prepared, I'll kick the build for it and deal with it after lunch ;) | 12:45 |
| didrocks | great! | 12:45 |
| seb128 | bregma, sil2100, didrocks: I'm going to test from the ppa once it's built | 12:46 |
| * seb128 wants the new version | 12:46 | |
| didrocks | seb128: bregma: sil2100: I guess we still want all AP tests being run once on the final .debs as well | 12:47 |
| tsdgeos | Cimi: mhr3: any chance you guys can quick review https://code.launchpad.net/~aacid/unity8/new-scopes-header-fix/+merge/205987 ? It's just a quick fix for something that was commited and not throughly reviewed (my fault) | 12:48 |
| sil2100 | Yep ;) | 12:49 |
| mhr3 | looks good to me | 12:49 |
| === _salem is now known as salem_ | ||
| tsdgeos | mhr3: actaully give me a sec, i think it's not totally correct | 12:50 |
| tsdgeos | mhr3: or it is... | 12:50 |
| tsdgeos | mhr3: can a preview header ever be overlayed? i guess no, right? | 12:50 |
| mhr3 | tsdgeos, don't think so | 12:51 |
| tsdgeos | mhr3: ok, then it's fine | 12:51 |
| tsdgeos | mhr3: if you can approve we'll save a few warnings when showing previews | 12:51 |
| tsdgeos | lunch! | 12:51 |
| mhr3 | that is a good idea | 12:51 |
| Cimi | mhr3, tsdgeos what should happen on typos? | 12:54 |
| mhr3 | Cimi, what do you mean? | 12:54 |
| Cimi | widgetData["visibility"] = "reviewefe" | 12:54 |
| Cimi | instead "review" | 12:54 |
| mhr3 | fallback to default | 12:54 |
| Cimi | ok | 12:54 |
| mhr3 | it's clearly specified that it supports 3 values | 12:55 |
| Cimi | tsdgeos, if I change visibility of a parent, does children get different visibility | 13:00 |
| Cimi | propagates | 13:00 |
| Cimi | ? | 13:00 |
| Cimi | yes | 13:01 |
| Cimi | qt doc | 13:01 |
| === jhodapp|afk is now known as jhodapp | ||
| === dandrader is now known as dandrader|afk | ||
| === MacSlow|lunch is now known as MacSlow | ||
| === dandrader|afk is now known as dandrader | ||
| Cimi | tsdgeos, when widget data changes | 13:55 |
| Cimi | tsdgeos, what should happen to the review input? | 13:56 |
| Cimi | keep the same values? | 13:56 |
| tsdgeos | Cimi: "rating-input" ? | 13:58 |
| Cimi | mmm | 13:59 |
| Cimi | no when one changes the json | 13:59 |
| Cimi | tsdgeos, and the user did a review before or so | 13:59 |
| Cimi | tsdgeos, just like when you press submit, what should happen? | 14:00 |
| Cimi | it's tricky | 14:00 |
| Cimi | in the meanwhile, I'll try to finish this so you can review for now | 14:00 |
| tsdgeos | Cimi: i don't think the json would change tbh | 14:00 |
| Cimi | again with signalSpy drunk | 14:08 |
| Cimi | seeing 2 instead 1 | 14:08 |
| Cimi | mzanetti, help :( | 14:08 |
| mzanetti | Cimi: :D | 14:08 |
| mzanetti | Cimi: I didn't have any issues with the SignalSpy lately | 14:09 |
| Cimi | I have it | 14:09 |
| Cimi | I cannot see any bugs here | 14:09 |
| Cimi | I have a clear onTriggered: console.log("triggered"); | 14:09 |
| Cimi | ONE console line | 14:09 |
| Cimi | signalSpy says 2 | 14:10 |
| mzanetti | not following. need to see code | 14:10 |
| elopio | tsdgeos: ping. I need your help to land a branch that's needed by autopilot. | 14:10 |
| mzanetti | Cimi: can you paste the snipped and perhaps the output too? | 14:10 |
| tsdgeos | elopio: what's up? | 14:10 |
| Cimi | mzanetti, it's not easy, I'll paste | 14:11 |
| Cimi | mzanetti, http://paste.ubuntu.com/6925651/ | 14:12 |
| Cimi | hah, I told you | 14:12 |
| kgunn | elopio: i can help you...that way tsdgeos can do real work | 14:15 |
| dandrader | kgunn, any new on getting mir 0.1.5 in ubuntu? | 14:20 |
| kgunn | dandrader: you can't make this stuff up.... | 14:20 |
| kgunn | so its blocked on xorg rebuild | 14:20 |
| kgunn | b/c xorg is curently failing to build for | 14:20 |
| kgunn | (wait for it) | 14:20 |
| kgunn | ppc64el | 14:21 |
| elopio | sorry, they distracted me. | 14:21 |
| elopio | kgunn: https://code.launchpad.net/~elopio/unity8/no_uinput_side-effects/+merge/203876 | 14:21 |
| Cimi | who knows why SignalSpy goes to the Oktoberfest in mid February?? | 14:21 |
| kgunn | ...builds for everything else...so we're help up on powerpc | 14:21 |
| kgunn | :-/ | 14:21 |
| elopio | kgunn: this branch will let us refactor code in autopilot to start removing the ugly things we are doing in unity8. | 14:21 |
| Cimi | mzanetti, the output is | 14:21 |
| kgunn | elopio: ack | 14:21 |
| kgunn | tsdgeos: you want the preview_progress branch as well ? | 14:22 |
| tsdgeos | kgunn: sure | 14:23 |
| tsdgeos | kgunn: and if you give mzanetti 10 min, i'm sure he'll have another one done | 14:23 |
| tsdgeos | mzanetti: how is the lvwph review going? | 14:23 |
| kgunn | tsdgeos: sure..makes sense..will wait | 14:23 |
| kgunn | oh my...lvwph | 14:23 |
| kgunn | do we ever stop fiddling with lvwph :) | 14:23 |
| mzanetti | tsdgeos: looks good to me. still figuring what's wrong with that branch on jenkins | 14:23 |
| tsdgeos | mzanetti: ah yeah, somehow jenkins exploded on it | 14:24 |
| Cimi | oh god | 14:24 |
| Cimi | mzanetti, I understood why | 14:24 |
| mzanetti | kgunn: when desing redesigns the dash next time maybe :D | 14:24 |
| Cimi | mzanetti, we can talk it later on mumble | 14:24 |
| mzanetti | Cimi: ok | 14:24 |
| kgunn | elopio: you're gonna get someone to review tho right? | 14:29 |
| elopio | kgunn: to review this branch? That's why I pinged tsdgeos. | 14:30 |
| kgunn | ah...sorry, i thot it was already reviewed/approved.... | 14:30 |
| tsdgeos | elopio: so that branch says you need a new autopilot, does that autopilot exist already or i need a new one | 14:31 |
| tsdgeos | aaaah standup | 14:31 |
| elopio | tsdgeos: ahh, I didn't update the description. | 14:31 |
| elopio | I'll do it. Now it's compatible with current autopilot, and with my new branch that will refactor uinput,. | 14:32 |
| mzanetti | MacSlow: :D did you buy a new Mic? | 14:41 |
| MacSlow | mzanetti, no... is the sound quality better? | 14:41 |
| mzanetti | MacSlow: better than ever before | 14:42 |
| MacSlow | mzanetti, I mainly messed with mumble-settings | 14:42 |
| mzanetti | MacSlow: as in, you sound like a human now, not any more like a terminator robot | 14:42 |
| MacSlow | mzanetti, damn ;) | 14:42 |
| elopio | tsdgeos: I updated the description, and added the checklist. I keep forgetting about that, sorry. | 14:42 |
| mzanetti | Cimi: https://qt.gitorious.org/qt/qtdeclarative/source/586ebf6c55ed095c2627185d90153ccfdc51c3d2:src/imports/testlib/SignalSpy.qml | 14:44 |
| mzanetti | Cimi: you really made me curious how this can happen | 14:46 |
| kgunn | mzanetti: so sorting out ppa for rightedge this mornin' and merging your right-edge-2 | 14:48 |
| kgunn | branch with ~unity-team/unity8/new-scopes | 14:48 |
| kgunn | conflicts, just wondering if you need to | 14:49 |
| kgunn | rebase on trunk | 14:49 |
| tsdgeos | ok | 14:49 |
| mzanetti | kgunn: might be, yeah | 14:49 |
| mzanetti | kgunn: will do now | 14:49 |
| kgunn | ta | 14:49 |
| tsdgeos | elopio: so with that branch it will work now and in the future autopilot? | 14:50 |
| elopio | tsdgeos: yes. In a really ugly way using try catch for future compatibility, but as soon as autopilot lands I'll get back and clean that, and the nasty calls to private _fingers. | 14:51 |
| tsdgeos | elopio: looks reasonable | 14:52 |
| mzanetti | kgunn: merged & pushed | 14:52 |
| === redj_ is now known as redj | ||
| tsdgeos | elopio: i'll re-run the CI, ok? | 14:53 |
| kgunn | mzanetti: thanks! | 14:55 |
| tsdgeos | anyone knows if karni will be around today? | 14:55 |
| kgunn | tsdgeos:oh i think he's in california right ? | 14:56 |
| tsdgeos | yeah but he has helping $SOMEONE that was having medical problems | 14:56 |
| tsdgeos | not sure how that ended up | 14:56 |
| elopio | tsdgeos: ok. The error is weird, on os.killpg(self._notify_proc.pid, signal.SIGTERM) it seems. | 14:57 |
| elopio | completely unrelated. | 14:57 |
| tsdgeos | garg | 14:57 |
| tsdgeos | now autopilot fails in my branch too | 14:57 |
| tsdgeos | MacSlow: did you guys break notifications again? | 14:58 |
| tsdgeos | MacSlow: see https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2817/artifact/results/autopilot/artifacts/unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call%20%28Desktop%20Nexus%204%29.ogv and https://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2817/testReport/junit/unity8.shell.tests.test_notifications/InteractiveNotificationBase/test_sd_incoming_call_Desktop_Nexus_4_/ | 14:58 |
| MacSlow | tsdgeos, certainly not as I've not managed to get my branch in yet | 14:59 |
| tsdgeos | MacSlow: no change in unity-notifications that may cause that? | 14:59 |
| tsdgeos | no | 15:00 |
| tsdgeos | no release since january | 15:00 |
| MacSlow | tsdgeos, that has also not chagned | 15:00 |
| * tsdgeos tries to reproduce locally | 15:00 | |
| tsdgeos | obviously works locally | 15:04 |
| tsdgeos | how not | 15:04 |
| tsdgeos | i'm reading this | 15:05 |
| tsdgeos | def _tidy_up_script_process(self): | 15:05 |
| tsdgeos | if self._notify_proc is not None and self._notify_proc.poll() is None: | 15:05 |
| tsdgeos | logger.error("Notification process wasn't killed, killing now.") | 15:05 |
| tsdgeos | os.killpg(self._notify_proc.pid, signal.SIGTERM) | 15:05 |
| tsdgeos | MacSlow: can it happen that the thing disappears in bettwen we check if it's there and we try to kill it ↑↑↑ ? | 15:06 |
| tsdgeos | ah this is not yours | 15:06 |
| tsdgeos | mzanetti: can you try running unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call there and see if it works for you? | 15:08 |
| mzanetti | tsdgeos: on desktop? | 15:09 |
| MacSlow | tsdgeos, I just wish I could remove all AP-tests and somehow do everything with qml | 15:09 |
| tsdgeos | mzanetti: yeah | 15:09 |
| mzanetti | on it | 15:09 |
| mzanetti | tsdgeos: is this what you get? StateNotFoundError: State not found for class '<class 'unity8.shell.emulators.dash.Dash'>'. | 15:11 |
| tsdgeos | mzanetti: nope | 15:11 |
| tsdgeos | mzanetti: it works for me, and the error is different | 15:12 |
| tsdgeos | mzanetti: you need to make isntall and then from the builddir | 15:12 |
| mzanetti | I did that | 15:12 |
| tsdgeos | PYTHONPATH=../tests/autopilot autopilot unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call | 15:12 |
| mzanetti | tsdgeos: same error | 15:13 |
| tsdgeos | that is weird | 15:13 |
| tsdgeos | pyhton is so helpless reporting errors sometimes | 15:13 |
| tsdgeos | mzanetti: can you paste the whole error? | 15:13 |
| mzanetti | tsdgeos: http://paste.ubuntu.com/6925924 | 15:13 |
| tsdgeos | weird | 15:14 |
| mzanetti | tsdgeos: seems unity8 is not starting | 15:14 |
| tsdgeos | yeah | 15:14 |
| mzanetti | which is most likely an issue with my setup | 15:14 |
| tsdgeos | mzanetti: i guess | 15:14 |
| mzanetti | but well.. everytime I try to use autopilot something is wrong in "the setup" | 15:14 |
| tsdgeos | start unity8 doesn't start unity for you | 15:14 |
| mzanetti | nope, doesn't work | 15:15 |
| mzanetti | but wait... I don't have it installed system wide. is that a new requirement? | 15:15 |
| tsdgeos | shouldn't be | 15:16 |
| tsdgeos | but it may | 15:16 |
| tsdgeos | since autopilot tests do use start unity8 to start it | 15:16 |
| tsdgeos | i thought that the fact that you run it installed and from your dir | 15:16 |
| tsdgeos | overrides that | 15:16 |
| tsdgeos | but maybe not | 15:16 |
| mzanetti | so just "start unity8" wouldn't work in any case I guess... but in the autopilot tests some path is exported iirc | 15:16 |
| mzanetti | yeah... that's what I thought too | 15:17 |
| tsdgeos | autopilot is just not very friendly reporting what it does tbh | 15:17 |
| mhr3_ | tsdgeos, hm, the preview are not closing fully with the latest image | 15:20 |
| tsdgeos | mhr3_: what do you mean not fully closing? | 15:21 |
| MacSlow | mzanetti, tsdgeos: doesn't copying lp:unity8/data/unity8.conf to ~/.config/upstart fix this? | 15:21 |
| tsdgeos | mhr3_: new-scopes or regular image? | 15:21 |
| mhr3_ | tsdgeos, let me grab a screenshot | 15:21 |
| mhr3_ | new-scopes | 15:21 |
| mzanetti | MacSlow: I have that file already | 15:22 |
| mhr3_ | tsdgeos, http://imgur.com/umfBwSl <- that's after exitting a preview | 15:22 |
| mhr3_ | stays like that until i do something | 15:22 |
| tsdgeos | interesting | 15:22 |
| tsdgeos | mhr3_: can you get that on the destkop? | 15:23 |
| mhr3_ | let me update everything | 15:23 |
| mhr3_ | tsdgeos, yea, on desktop as well | 15:28 |
| mhr3_ | tsdgeos, i guess it's the no-art cards | 15:28 |
| tsdgeos | hmmm | 15:28 |
| tsdgeos | weird not here | 15:28 |
| tsdgeos | in which scope do you get that? | 15:28 |
| tsdgeos | or do you have some local change? | 15:28 |
| mhr3_ | tsdgeos, if you force online music to use medium mascot-only, it has the same issue | 15:29 |
| tsdgeos | mzanetti: so we need to decide what to do with that failing test, i can't reproduce it here and you can't even run the test :D | 15:29 |
| mhr3_ | well, s/art/mascot/ | 15:29 |
| tsdgeos | mzanetti: do we block landings or...? | 15:29 |
| mzanetti | is this failing for all branches on jenkins? | 15:30 |
| mzanetti | tsdgeos: ^? | 15:31 |
| tsdgeos | mzanetti: seems to have started failing lately yes | 15:31 |
| tsdgeos | elopio branch and mine | 15:31 |
| tsdgeos | both unrelated | 15:31 |
| tsdgeos | and both not related to that test at all | 15:31 |
| mzanetti | meh | 15:31 |
| mzanetti | let me check the failure on jenkins again | 15:31 |
| === alan_g is now known as alan_g|tea | ||
| mzanetti | tsdgeos: hmm... but this looks like something else again: http://s-jenkins.ubuntu-ci:8080/job/unity8-trusty-armhf-ci/840/console | 15:34 |
| tsdgeos | mzanetti: yes that is different, where's that from? | 15:36 |
| mzanetti | tsdgeos: from your branch too | 15:36 |
| mzanetti | although I don't think it's actually your change that causes it | 15:37 |
| tsdgeos | it is totally not | 15:37 |
| tsdgeos | i can tell you that :D | 15:37 |
| tsdgeos | see https://code.launchpad.net/~aacid/unity8/lvwph_resize_item_bug/+merge/206140 | 15:37 |
| tsdgeos | the autopilot one got fixed | 15:37 |
| tsdgeos | and that weird one appeared | 15:37 |
| tsdgeos | mhr3_: are you aware the scopes get angry if i ask for more than one preview quickly in a row? | 15:40 |
| === gatox is now known as gatox_lunch | ||
| mhr3_ | tsdgeos, how much angry? | 15:41 |
| mhr3_ | but yea, quite possible | 15:41 |
| tsdgeos | mhr3_: so if i as for preview for item 0 and 1 | 15:41 |
| tsdgeos | the item 0 model never gets populated | 15:41 |
| tsdgeos | at least in the scopes scope | 15:41 |
| mhr3_ | sounds about right, preview request cancels any unfinished ones | 15:42 |
| mhr3_ | but it shouldn't, i'll fix that | 15:42 |
| mzanetti | tsdgeos: seems the last post from jenkins on your MP has 3 different failures :D (or rahter :( ) | 15:47 |
| === alan_g|tea is now known as alan_g | ||
| mzanetti | tsdgeos: kgunn: well, I'm not feeling comfy releasing stuff in this state... chances are too big we'll release a real test failure and block ourselves for another week | 15:48 |
| mzanetti | however, I need to leave for today (got tickets for a musical) and if you really need to land something, don't ask me | 15:48 |
| kgunn | mzanetti: enjoy the musical.... | 15:48 |
| mzanetti | thanks | 15:48 |
| tsdgeos | mzanetti: stuff is in the same state as of yesterday | 15:51 |
| tsdgeos | but ok, no release | 15:51 |
| mzanetti | tsdgeos: really? yesterday stuff passed on jenkins still, no? | 15:51 |
| tsdgeos | mzanetti: i can trigger jenkins to pass eventually :D | 15:51 |
| tsdgeos | mzanetti: since the 3 different failures come and go ;) | 15:51 |
| mzanetti | hmm... ok... seemed a bit like it started and some point and fails predictably now | 15:52 |
| tsdgeos | sure | 15:52 |
| tsdgeos | that's ok | 15:52 |
| tsdgeos | i'll keep merging stuff into new-scopes | 15:53 |
| === dandrader is now known as dandrader|afk | ||
| === jono is now known as Guest53088 | ||
| tsdgeos | mhr3_: can you review https://code.launchpad.net/~aacid/unity8/new-scopes-preview-sometimes-disappears/+merge/206215 ? | 16:00 |
| karni | o/ | 16:01 |
| karni | tsdgeos: Here I am :) (at standup ATM) | 16:01 |
| tsdgeos | karni: do you have a way for me to see that need for the big icons patch you posted? | 16:02 |
| karni | tsdgeos: We got her a ticket yesterday back home. She arrived minutes ago, and will get immediate doctor attention. | 16:02 |
| karni | tsdgeos: there are two screenshots in the description | 16:03 |
| karni | tsdgeos: mascot on one are much more crisp | 16:03 |
| tsdgeos | karni: sure | 16:03 |
| karni | tsdgeos: this is not for "large" icons, this is for the in-memory resolution | 16:03 |
| tsdgeos | karni: i'm evil and want to see it by myself | 16:03 |
| karni | tsdgeos: oh | 16:03 |
| karni | I can give you the scope, sure | 16:03 |
| tsdgeos | karni: the patch doesn't make any sense to me tbh | 16:03 |
| tsdgeos | karni: the bug i fixed in Qt should fix it, and if not should be fixed again | 16:04 |
| tsdgeos | but multiplying by 4 the sizes is not cool | 16:04 |
| karni | tsdgeos: I know, but Saviq built qt for me, I installed it locally, and they still were blurry | 16:04 |
| karni | anywya, lemme give you the link | 16:04 |
| mhr3_ | tsdgeos, hm, is that a workaround because we're cancelling the unfinished preview? | 16:06 |
| tsdgeos | mhr3_: hard question :D | 16:07 |
| tsdgeos | mhr3_: the current code, only asks for one preview | 16:07 |
| tsdgeos | mhr3_: my patch thus still only asks for one preview too, but fixes the patch | 16:07 |
| tsdgeos | mhr3_: i'd like to remove the isCurrent from the if | 16:08 |
| tsdgeos | mhr3_: but then it asks for more previews and you don't see the fadeIn effect anymore | 16:08 |
| seb128 | bregma, is that a known issue with the ppa for the new unity? | 16:08 |
| seb128 | $ LC_ALL=C sudo apt-get install unity unity-lens-applications libunity-core-6.0-9 unity-plugin-scopes | 16:08 |
| tsdgeos | and not sure if design wants that | 16:08 |
| seb128 | unity-plugin-scopes : Depends: libunity-core-6.0-8 (>= 7.0.0) but it is not going to be installed | 16:08 |
| tsdgeos | mhr3_: so yes and no at the same time :D | 16:08 |
| karni | tsdgeos: sent you e-mail how to install and enable the scopes, so you can see for yourself (once you apply the patch on your phone and reboot, I think there's no easier way) | 16:08 |
| seb128 | bregma, seems like you need a unity-plugin-scopes rebuild in the ppa? | 16:08 |
| karni | tsdgeos: actually, let me send you a deb so you can test with unity8 locally | 16:08 |
| karni | that'll be faster | 16:08 |
| tsdgeos | karni: deb for what? | 16:08 |
| karni | that scope. you wanted to see for yourself | 16:09 |
| mhr3_ | tsdgeos, ok, i see | 16:09 |
| tsdgeos | karni: ah cool | 16:09 |
| mhr3_ | tsdgeos, can you add a fixme there? | 16:09 |
| tsdgeos | mhr3_: i'm not sure it needs one | 16:09 |
| mhr3_ | of course it does :) | 16:09 |
| tsdgeos | why? | 16:09 |
| mhr3_ | cause it's not obvious | 16:10 |
| tsdgeos | we've never requested more than one preview before | 16:10 |
| tsdgeos | what is not obvious? | 16:10 |
| tsdgeos | is the same code than we had before | 16:10 |
| mhr3_ | that the plugin doesn't support it, and ideally it should | 16:10 |
| tsdgeos | just before it was less declarative | 16:10 |
| karni | tsdgeos: e-mail sent | 16:10 |
| tsdgeos | mhr3_: the thing is, as said with the fadein animation, i'm not sure we want to remove the if | 16:10 |
| tsdgeos | but i can add a comment if you want | 16:10 |
| mhr3_ | if the content would be there right away, there's no need for fadein | 16:11 |
| tsdgeos | mhr3_: but design likes fadeins :D | 16:12 |
| tsdgeos | sure | 16:12 |
| tsdgeos | i was actually removing the fadein | 16:12 |
| tsdgeos | when i stumbled on the previws bug | 16:12 |
| tsdgeos | so i'll add the comment | 16:12 |
| tsdgeos | and someone will decide later if we want or not to get it | 16:12 |
| tsdgeos | mhr3_: comment added | 16:15 |
| mhr3_ | tsdgeos, thx, acked | 16:16 |
| karni | greyback: Hey man, any chance you could look into this before MWC? https://bugs.launchpad.net/savilerow/+bug/1279453 | 16:23 |
| ubot5 | Launchpad bug 1279453 in unity8 (Ubuntu) "Carousel renderer flies off the screen when scrolling on N10" [Undecided,Confirmed] | 16:23 |
| karni | greyback: I believe you were (at least one of) the authors of carousel, tell me if I got that wrong | 16:24 |
| greyback | karni: I've had little to do with carousel tbh. Cimi would be the man | 16:24 |
| karni | tsdgeos: regarding your comment on this bug ↑ Carousel requires minimum of 5 items, so this does comply. Also, the carousel works just fine on the phone. | 16:25 |
| karni | Cimi: You think you could have a look at the linked bug ↑ anytime soon? It's sort of a blocker for tablet demoing for MWC. | 16:26 |
| Cimi | carousel should not work with 5 items | 16:26 |
| Cimi | we should have grid IIRC | 16:26 |
| tsdgeos | karni: which bug? | 16:26 |
| Cimi | 5 items on the phone maybe | 16:26 |
| karni | https://bugs.launchpad.net/savilerow/+bug/1279453 | 16:27 |
| ubot5 | Launchpad bug 1279453 in unity8 (Ubuntu) "Carousel renderer flies off the screen when scrolling on N10" [Undecided,Confirmed] | 16:27 |
| Cimi | there was code on the old scopes | 16:27 |
| Cimi | karni, tomorrow maybe | 16:27 |
| karni | Cimi: no, I fixed that code, this is correct | 16:27 |
| karni | old limit was 7+, now it's 5+ | 16:27 |
| Cimi | karni, put it 7 | 16:27 |
| karni | actually, trunk contains <= 6 condition, new scopes contains <= 4 condition | 16:27 |
| karni | Cimi: Well.. I'm sorry, but that was design decision, it's not our call. | 16:27 |
| Cimi | karni, carousel math don't work with less than 7 | 16:28 |
| karni | I also suspect it's the number of items on this screen width that causes trouble, though | 16:28 |
| Cimi | period. | 16:28 |
| karni | o_O | 16:28 |
| Cimi | unless you increase the humbr of items on screen | 16:28 |
| Cimi | and make carousel smaller | 16:28 |
| karni | I guess that's good to know. Thank you Cimi. | 16:28 |
| Cimi | *number | 16:28 |
| Cimi | the sly effect is also due to the overflow / rebound | 16:29 |
| Cimi | *fly | 16:29 |
| karni | number of items on screen? | 16:29 |
| Cimi | of carousel tiles | 16:29 |
| karni | hrm | 16:29 |
| Cimi | it's a translation of content | 16:29 |
| Cimi | there's a complex math behind | 16:29 |
| karni | I'm sure there is, I've seen it. | 16:29 |
| Cimi | we decided we just wanted to have carousel when we had like more than 6-7 items | 16:30 |
| Cimi | me and Oren | 16:30 |
| tsdgeos | tbh i'd just trust cimi here | 16:30 |
| tsdgeos | and bring that 4 back to 6/7 | 16:30 |
| tsdgeos | wathever it was | 16:30 |
| tsdgeos | and if design wants it to be 4 | 16:30 |
| karni | So either I set number of items to 7 minimum, or add items to the carousel (whic is basically equivalent) | 16:30 |
| Cimi | it's stupid carousel with 4 | 16:30 |
| tsdgeos | well, we need to fix the code | 16:30 |
| karni | 4 would be grid, 5 would be carousel | 16:30 |
| tsdgeos | but not *now* D: | 16:30 |
| Cimi | it does not give any benefit in terms of usability | 16:30 |
| karni | I fixed that code to be so, and that was because of design decision. I didn't know carousel won't work for <7 items | 16:31 |
| Cimi | you actually need to tap an extra time | 16:31 |
| karni | it just gives the damn good looks, that's all | 16:31 |
| karni | ssweeny: ↑ | 16:31 |
| tsdgeos | of course it needs to be seen if with 7 | 16:31 |
| tsdgeos | it still acts this crazy or not | 16:31 |
| Cimi | looks cool but it's not efficient | 16:31 |
| Cimi | a grid works better with few elements | 16:31 |
| Cimi | I suppose it might still have issues | 16:32 |
| Cimi | I believe we need to limit the flickble drag over bounds | 16:32 |
| karni | it's not about being efficient, we're talking about looking good for MWC, Cimi :) | 16:32 |
| Cimi | karni, a grid looks good | 16:32 |
| Cimi | a carousel looks better, ya | 16:32 |
| karni | Cimi: Again, it's not our decision. | 16:32 |
| karni | Yes. | 16:32 |
| Cimi | but a broken UX is worse than something looking better | 16:33 |
| tsdgeos | it is our decision | 16:33 |
| karni | Cimi: I would appreciate if you could have a look at it tomorrow then. At least we know how to fix it. | 16:33 |
| tsdgeos | Cimi says the Carousel doesn't work with < 7 | 16:33 |
| Cimi | karni, let me know who wants to change this and I'll convince him back | 16:33 |
| karni | tsdgeos: THAT I understand, yes. | 16:33 |
| tsdgeos | and we don't have time to make it work with it | 16:33 |
| karni | Cimi: sure, ask katie on IRC | 16:33 |
| tsdgeos | so unless you can magically create time there's not much we can do | 16:33 |
| karni | tsdgeos: ok. | 16:33 |
| karni | I'll just let them know to add more stuff to carousel. | 16:33 |
| tsdgeos | please | 16:34 |
| tsdgeos | and let's see if it works then | 16:34 |
| karni | sure | 16:34 |
| === gatox_lunch is now known as gatox | ||
| elopio | greyback: do you know about the status of this bug? https://bugs.launchpad.net/ubuntu/+source/qtubuntu/+bug/1204595 | 16:37 |
| ubot5 | Launchpad bug 1204595 in unity-mir "Unity 8 does not properly parse legitimate desktop files" [Medium,In progress] | 16:37 |
| karni | If we end up not changing code, we should seriosly add a comment in carousel code it doesn't work with less than 7 items. | 16:37 |
| greyback | elopio: ultimately, we'll drop the custom desktop file parsing code and use QSettings to do the parsing. There is a branch attached that fixes up the old code a bit, but I wasn't aware of any demand for it to be solved | 16:38 |
| karni | ssweeny: fallback to grid under 7 items doesn't satisfy us. that'd break visuals Joe has worked on for weeks, and we've been iterating daily. unless we can ask jouni for more upgrade options (that sucks if you ask me, but that's exactly what we just did, when bumping to 5 items) | 16:39 |
| karni | ssweeny: please let me know if there's a way for us to bump number of items in carousels to 7. if not (and I assume that'd be blocked on Jounis deliverables), we may have to ask Cimi for help. | 16:40 |
| elopio | greyback: well, it's not urgent, but we are constantly making fake desktop files. When we miss something, it will just fail silently. | 16:40 |
| elopio | if it will be replaced with a better solution soon, then I'm ok with leaving the old code as it is. | 16:40 |
| ssweeny | karni, i don't know if it's feasible to add more items with our deadline | 16:41 |
| Cimi | karni, carousel under 7 items won't work | 16:41 |
| greyback | elopio: noted. I'll keep you in the loop when we fix it up | 16:41 |
| karni | Cimi: I know you said that. You also said you could limit the flickable drag over bounds. | 16:41 |
| Cimi | karni, this will fix the fly issue | 16:41 |
| karni | Cimi: Too bad we didn't know that a day before deadline :( There was no comment in code, and my fix passed Saviq's review. | 16:41 |
| Cimi | karni, but still the clicks won't work well | 16:41 |
| karni | Cimi: That would be fantast.. aha | 16:41 |
| karni | I think clicks do work well atm, right ssweeny ? | 16:42 |
| elopio | greyback: thanks. And a question, are some of the fields in the desktop file required? I mean, an app will fail to launch if we skip one of them? | 16:42 |
| karni | Cimi: you mean that if we fix the fly effect, bounding items may not be clickable | 16:42 |
| karni | ? | 16:42 |
| Cimi | karni, you can try | 16:42 |
| Cimi | karni, I doubt | 16:42 |
| karni | its there a single variable we could tweak? I'm sorry, the carousel code is huge, and you're probably our last hope. | 16:43 |
| Cimi | karni, carousel requires more items than the area | 16:43 |
| Cimi | karni, basically, it needs elements on both sides to work | 16:43 |
| greyback | elopio: required entries are Name, Comment, Icon, Exec, Path, StageHint, others are optional | 16:43 |
| karni | Cimi: that makes sense. the carousel does span the screen width on tablet, though. but I see what you mean. | 16:43 |
| Cimi | karni, carousel must be disabled for less than 7 | 16:44 |
| karni | ... | 16:44 |
| Cimi | for this reason | 16:44 |
| Cimi | it's like 4-5 on phone | 16:44 |
| karni | Cimi: I would be happy with that solution if we know 2 weeks ago. | 16:44 |
| Cimi | but 7 on tablet | 16:44 |
| karni | ooh | 16:44 |
| karni | oooh! | 16:44 |
| karni | could we change that separately on the tablet? | 16:44 |
| tsdgeos | karni: you sent me a bunch of amd64 debs?¿ | 16:44 |
| Cimi | it's a geometry thing | 16:44 |
| karni | tsdgeos: you don't like em :(? | 16:44 |
| tsdgeos | karni: how do i install them on the phone? | 16:44 |
| tsdgeos | karni: or you get the problem in the desktop too? | 16:45 |
| karni | Cimi: is there a way to tell from qml it's a tablet, besides comparing width/height ? | 16:45 |
| Cimi | because all the elements are outside the view, and the 3d effect brings them in the view | 16:45 |
| karni | tsdgeos: desktop too, install on the desktop | 16:45 |
| elopio | greyback: ack. Thanks. | 16:45 |
| karni | tsdgeos: I said that'd be a bit faster than trying on the phone and rebooting it :) | 16:45 |
| tsdgeos | karni: no, you don't want to test for tablet, you want to test for width | 16:45 |
| Cimi | karni, there is tablet variable in Shell.qml maybe? | 16:45 |
| tsdgeos | don't use that | 16:45 |
| tsdgeos | it's evil | 16:45 |
| tsdgeos | Cimi: and now cards are not all the same size | 16:45 |
| karni | tsdgeos: you can tweak qml/Dash/CardHeader.qml and relaunch unity-scope-tool to do visual inspection | 16:45 |
| tsdgeos | so what should be done is compare card width * count and width of the shell | 16:46 |
| tsdgeos | i'd say | 16:46 |
| karni | tsdgeos: we want to test for width - that might rescue us | 16:46 |
| Cimi | karni, in any case you have to re-tweak the value | 16:46 |
| Cimi | karni, because as soon as you do a search, you break | 16:46 |
| Cimi | karni, it must be 7 on a tablet | 16:46 |
| Cimi | no more questions for now | 16:46 |
| karni | how does search affect carousel ? | 16:46 |
| Cimi | karni, it limits the number of elements | 16:47 |
| Cimi | karni, we can spend more time to see if we can make it work with less items | 16:47 |
| karni | Thank you for your assistance. | 16:47 |
| Cimi | karni, but this later, after MWC | 16:47 |
| Cimi | karni, I cannot see how we can fix it, just have no idea | 16:47 |
| karni | That won't help us. I'll try to workaround that. All I care is MWC (as we all do) for now. | 16:47 |
| karni | ok | 16:47 |
| karni | Thank you, Cimi | 16:47 |
| Cimi | that's why I am saying let's keep 7, and switch to grid | 16:48 |
| Cimi | for 6 | 16:48 |
| karni | Will we have Shell rotation on the phone for MWC, or just the tablet? | 16:49 |
| tsdgeos | you know something that would be awesome? | 16:49 |
| karni | tsdgeos: ↑ do you know? /me tries not to highlight the whole team | 16:49 |
| tsdgeos | if doing a restart scope-registry | 16:50 |
| tsdgeos | would restart my desktop | 16:50 |
| karni | tsdgeos: hahah. but that does work once you install the scopes from me. at least restart scope-registry worked here. | 16:50 |
| tsdgeos | karni: i do not know, i'd say we don't have rotation at all | 16:50 |
| tsdgeos | phone -> portrait; tablet -> landscape | 16:50 |
| karni | that's even better, so we can just test width/height of shell | 16:50 |
| tsdgeos | but i know nothing | 16:50 |
| karni | then fallback to grid on tablet. or something. thanks guys. | 16:51 |
| tsdgeos | karni: do you remember anything about https://code.launchpad.net/~unity-team/unity8/header-alignment/+merge/205334 ? | 16:54 |
| * karni looks | 16:54 | |
| karni | tsdgeos: ha, description says "Center-align title when it's alone in the header." and this change is already in new-scopes or trunk. I'll follow up shortly, maybe I should just delete that. I'll double check, Albert. | 16:56 |
| mhr3_ | hmm, can we make the preview window suck less? | 16:58 |
| mhr3_ | the grey color is awful | 16:58 |
| tedg | bregma, At one point you were talking about using a screensaver that would go to the greeter in trusty, is that still on the table? | 17:01 |
| karni | mhr3_: I knew that'd be coming. | 17:02 |
| * karni scratches on the head | 17:02 | |
| Cimi | tsdgeos, one binding loop and the merge proposal is ready | 17:02 |
| mhr3_ | http://paste.ubuntu.com/6926453/ | 17:02 |
| mhr3_ | karni, ^ | 17:02 |
| bregma | tedg yes, after a fasion | 17:02 |
| mhr3_ | karni, maybe a better idea is to remove it completely :) | 17:03 |
| karni | hrhahah :D | 17:03 |
| mhr3_ | so what do i do with it? | 17:03 |
| tedg | bregma, fashion? Are we having a fashion show? Oh, what will I wear? | 17:03 |
| mhr3_ | i'm ready to bzr ci :) | 17:03 |
| mhr3_ | tsdgeos, ^? | 17:03 |
| karni | mhr3_: would you have a screenshot for that? would be happy to review that for you and get this pushed through. we may need to ask design for feedback :| | 17:03 |
| bregma | tegg, you look fabulous in anything | 17:04 |
| bregma | or nothing? | 17:04 |
| karni | mhr3_: Well, we need to change the grey color anyway, it just doesn't work for previews. | 17:04 |
| tedg | Both | 17:04 |
| mhr3_ | karni, well the designs don't have any grey | 17:04 |
| mhr3_ | they're white | 17:04 |
| mhr3_ | or at least very light grey | 17:04 |
| karni | :O okay, than that fix makes perfect sense then | 17:05 |
| mhr3_ | looks much nicer without it, but also it breaks the animation | 17:06 |
| tsdgeos | mhr3_: if it looks better, sure | 17:11 |
| tsdgeos | or don't if it breaks the animation :D | 17:12 |
| mhr3_ | tsdgeos, what is more important nice preview or nice animation? :P | 17:12 |
| tsdgeos | karni: i can reproduce the problem with your image, i will investigate if we can solve it any other way than with that random * 4 | 17:12 |
| tsdgeos | mhr3_: my artistic skills stopped evolving at 4 | 17:13 |
| mhr3_ | actually | 17:13 |
| karni | tsdgeos: That would be much appreciated. I didn't want to take your time. | 17:13 |
| tsdgeos | so don't ask me those kind of things :D | 17:13 |
| mhr3_ | the animation is broken eitherway | 17:13 |
| tsdgeos | mhr3_: which animation? | 17:13 |
| karni | mhr3_: I'd say preview is more important, but what do I know ;P | 17:13 |
| mhr3_ | tsdgeos, if there are no-art results, it's all weird | 17:13 |
| tsdgeos | wow | 17:14 |
| tsdgeos | yeah after installing the scope karni sent me | 17:14 |
| tsdgeos | i can repro the weirdness | 17:14 |
| tsdgeos | i'll have a look tomorrow | 17:14 |
| tsdgeos | karni: btw FGC is a train/metro not a bus, you guys may want to update the icon shown in that scope :D | 17:15 |
| mhr3_ | ok, so i'm removing the blending rect | 17:15 |
| karni | tsdgeos: fixed as we speak, got art form Jouni | 17:16 |
| karni | tsdgeos: but thanks :D | 17:16 |
| * tsdgeos gets some rest | 17:16 | |
| tsdgeos | tomorrow more! (or maybe later) | 17:17 |
| mhr3_ | rest.. what is that? | 17:17 |
| mhr3_ | :P | 17:17 |
| karni | ;) | 17:17 |
| mhr3_ | robru, pretty pls to land #18? | 17:18 |
| robru | mhr3_, hang on, in meeting. | 17:18 |
| mhr3_ | robru, and even prettier please to get silo for #27 | 17:18 |
| Cimi | oh damn it | 17:19 |
| robru | mhr3_, ok, assigned silo 16 | 17:19 |
| robru | mhr3_, we have to wait a bit to land mediascanner for you (other things are higher priority right now, can do it in a couple hours) | 17:23 |
| mhr3_ | robru, ok | 17:23 |
| Cimi | if someone has still some energy left... https://code.launchpad.net/~cimi/unity8/units8.previews_RatingStars/+merge/206239 | 17:31 |
| Cimi | I'm dead xD | 17:32 |
| Cimi | mzanetti, you can have a look at tests if you like, it's quite long | 17:32 |
| robru | mhr3_, ok, hitting publish on silo 9 for you. please merge & clean once you see it in distro | 17:46 |
| Cimi | karni, so did you manage to set back to 7? | 17:56 |
| karni | Cimi: no, juggling few things at a time. I will get to this very shortly. | 17:56 |
| Cimi | cool | 17:56 |
| karni | Cimi: setting back to 7 is easy. I know because I changed it to <=5 in new-scopes. I'll try to do bit better than that, and fallback to grid only on tablet (based on shell dimentions) | 17:57 |
| karni | Cimi: Thanks for asking | 17:57 |
| Cimi | karni, well, best would be depending on carousel dimensions | 17:58 |
| Cimi | karni, and remember on the phone still has to be disabled for around 4-5 | 17:58 |
| karni | Cimi: works just fine on phone with fallback to grid for <=7 | 17:58 |
| karni | only tablet has the bug | 17:58 |
| Cimi | karni, not with 1 or 2 | 17:59 |
| Cimi | or 3 | 17:59 |
| karni | Cimi: sory, I meant to say it works just fine for 5 and more items on the phone | 17:59 |
| Cimi | yes | 17:59 |
| karni | fallback to grid when <=4 items | 17:59 |
| Cimi | because of the dimensions | 17:59 |
| karni | yes, I understand that now :) | 17:59 |
| karni | phone's good. I'll fix the tablet with different fallback. | 18:00 |
| === alan_g is now known as alan_g|EOD | ||
| === dandrader is now known as dandrader|lunch | ||
| mhr3_ | karni, text widget is using wrong color, could you fix that? | 18:46 |
| karni | mhr3_: can I haz a look? where's that? | 18:46 |
| karni | btw that's like 3rd place the color pallete is wrong | 18:46 |
| mhr3_ | karni, http://imgur.com/ScFEfq7 | 18:47 |
| mhr3_ | if you try hard you'll see there's text :) | 18:47 |
| mhr3_ | below the button | 18:47 |
| karni | wow | 18:49 |
| karni | mhr3_: is this PreviewTextSummary.qml ? there should be titleLabel and textLabel, both have same color (both from Pallete, so no wonder if that's broken) | 18:51 |
| mhr3_ | karni, sounds right, yea | 18:52 |
| karni | ack | 18:52 |
| karni | mhr3_: Can you please test this (and possibly verify if "lightgrey" instead of "grey" isn't beter for summary?) http://paste.ubuntu.com/6927035/ | 18:54 |
| karni | I did that sort of blind. applying demo-stuff ppa to n4 now | 18:54 |
| mhr3_ | karni, yea, look good with grey | 18:58 |
| mhr3_ | seems to match designs | 18:58 |
| karni | mhr3_: ok, I'll whip a branch | 18:58 |
| karni | mhr3_: I suspect we'll run into more of these :/ | 18:59 |
| mhr3_ | definitely | 18:59 |
| mhr3_ | when can we start using some consts? | 18:59 |
| karni | Cimi: Do you know anything about possible updates to Ubuntu Palette? We're using it in new-scopes, but it just doesn't match new designs, and in couple of places we already have "grey"/"lightgrey" hardcoded. | 19:01 |
| karni | We expect we may run into more of these (see mhr's screenshot couple lines above) | 19:02 |
| karni | I imagine we'd update the palette and use some sort of version 2.0 of it for new-scopes | 19:02 |
| === dandrader|lunch is now known as dandrader | ||
| karni | but I have no idea who's responsible for that, nor I'm much familiar with debian packaging | 19:02 |
| karni | mhr3_: ^ | 19:02 |
| karni | also, how to do it without breaking trunk | 19:02 |
| mhr3_ | no idea how the pallette is handled | 19:03 |
| karni | cwayne: you know anything about Ubuntu Palette? You asked if I was doing any changes to it yesterday. | 19:04 |
| mhr3_ | robru, #27 waiting for button push :) | 19:04 |
| cwayne | karni, i know where it lives on the system, and i think its in ubuntu-ui-toolkit | 19:04 |
| cwayne | thats about it though :) | 19:04 |
| karni | yes, it is the toolkit. mhm. | 19:05 |
| karni | mhr3_: do you know if qml/Dash/Previews/PreviewTextSummary.qml is used by "old" unity8? Should I propose against trunk or new-scopes? | 19:07 |
| karni | Should I ask Cim'i ? | 19:08 |
| robru | mhr3_, published. merge & clean once it hits distro | 19:08 |
| mhr3_ | karni, separate preview widgets only by new-scopes | 19:11 |
| karni | ack, so this is safe to go into trunk | 19:12 |
| karni | mhr3_: here it is. can I please ask you to review and take it down the pipe? https://code.launchpad.net/~unity-team/unity8/unity8-preview-summary-color/+merge/206261 | 19:15 |
| mhr3_ | karni, ah, audio widget also wrong colors | 19:46 |
| karni | mhr3_: shall we fix in the same branch? | 19:47 |
| mhr3_ | why not | 19:48 |
| karni | mhr3_: I'm sorry, you need grey or lightgrey? | 19:51 |
| karni | there's track title and track subtitle | 19:51 |
| mhr3_ | looks grey to me | 19:51 |
| karni | hahaha gotta love deadlines | 19:51 |
| mhr3_ | title grey, sub light | 19:51 |
| karni | mhr3_: how bout time label? | 19:52 |
| mhr3_ | looks grey to me too | 19:53 |
| mhr3_ | anyway, heading home | 19:53 |
| mhr3_ | cu | 19:53 |
| karni | mhr3_: pushed | 19:54 |
| karni | mhr3_: would be awesome if you could land this tomorrow | 19:54 |
| karni | take care, mhr3_ | 19:54 |
| gatox | hi, does anyone here knows or can point me to the right direction about how to change one preview for another when perform_action is triggered in the scope? | 20:48 |
| karni | perhaps there's somone from Unity API team who would anser that question ↑ | 20:48 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!