=== TheMuso` is now known as TheMuso === _salem is now known as salem_ === salem_ is now known as _salem === duflu_ is now known as duflu [09:14] tsdgeos: hey, did you see the email on the unity8 maguro tests failing (they are multiple of them starting on image 181) [09:15] that can be due to latest Mir [09:15] didrocks: i did see it, and in my evilness i decided to unsee it :D [09:16] didrocks: can't we just deprecate maguro already and be happy? [09:17] tsdgeos, it seems we're not displaying the activity indicator when waiting for a video thumbnail [09:18] expected? [09:18] Cimi, ^? [09:18] that's for video widget [09:18] mhr3, I missed that [09:19] Cimi, isn't it part of lazy image itself? [09:19] Cimi, if not, pls add [09:19] yeah that's what i though [09:19] by using a LazyImage [09:19] dunno then [09:19] that we use [09:19] we should get it [09:19] Cimi: please investigate why we don't :D [09:19] mhr3, test the conditions pls [09:19] maybe [09:19] visible: state === "ready" [09:19] is breaking it [09:20] probably we need to move that to the image and mousearea, but not to the lazy image [09:20] so we get the spinning wheel [09:21] asac: happy if we discare the unity8 failures on maguro and promote 181 if dogfooding is good? [09:21] asac: seems people want to not take it into account even if I multiple times said it would be even worse with the emulator, so better to check for issues [09:22] tsdgeos, https://code.launchpad.net/~cimi/unity8/units8.previews_RatingStars/+merge/206239 [09:23] didrocks: asac: about maguro, yes, there is/was at least a test that i could reproduce all the time back on monday/tuesday and i know it could be worse on the emulator *but* what i was seeing may be caused by a lot of causes, one of them Qt having a bug on slower stuff (we know qt5.0 scene graph loop is bad) so before investing more time in getting it fixed i want to have Qt 5.2 first, and then if it still happens we can devote time to properly [09:23] investigate it. My problem is doing it *now*, not investigating it [09:23] that was a big long ^_^ [09:23] didrocks: asac: did i made sense in that sentence? [09:23] let me reread… it's… long :p [09:23] Cimi: saw it, will do in a bit [09:24] tsdgeos: if you just take a look at the output and can sense "this is a test only issue, no behavioral broken itself", I'm happy [09:26] didrocks: i can't say that [09:27] sad we even don't have results on 182 to know if some are reliably failing [09:27] as said, the test failure on maguro (at least the one i debugged a bit at beginning of the week) is stuff that should not be happening [09:27] but as trivial as "something that should be index 1 of a list is index 2" [09:27] so i don't want to debug that in an ancient Qt [09:28] tsdgeos: maguro isn't officially deprecated though, but beh… [09:29] didrocks: i know, i'm not saying that it should not be investigated, i just don't want to investigate it now [09:29] after we update to qt 5.2 [09:29] i'm happy to do [09:29] tsdgeos: that would mean we block promotion until we get 5.2? [09:30] didrocks: that's for you guys to decide :D [09:31] didrocks: i do not think that this bugs are new [09:31] s/bugs/test failures [09:31] but the data says otherwise [09:31] they didn't show as failures [09:31] but ok, let's see [09:31] so i can be just speaking crap [09:32] mhr3: this https://code.launchpad.net/~aacid/unity8/misc_previewlist_fixes/+merge/206365 should fix the previewlist opening/closing problems you were having yesterday, can you check [09:32] so the problem is that you guys decay our stuff [09:32] shoudl we try removing MIR again? [09:32] etc.? [09:32] should we ignore? [09:33] tsdgeos: you already said the same last week [09:33] e.g. its not new [09:33] but there is no indication of that being right [09:33] asac: i know i'm repeating myself [09:33] we made an exception last week to give you more time to investigate [09:34] now you say you cant make it now [09:34] there needs to be a STOP at some point [09:34] or REVERT [09:34] asac: sure [09:34] tsdgeos: please check these failures out... if you can proof them to be SoC/maguro specific [09:34] then we can ignore [09:34] asac: i can't do that and MWC at the same time [09:34] but htey are most likely genuine [09:34] races etc. [09:35] tsdgeos: i am not sure what you do for MWC [09:35] asac: let me repeat again "qt 5.0 qml is racy as hell and i don't want to debug it because it has been fixed already" [09:35] tsdgeos: we mght not get 5.2 [09:35] you dont know that yet [09:35] so i am not going to spend my time on that unless my manager tells me [09:35] (most likely we will get it) [09:36] speak to my manager [09:36] kgunn: ^ [09:36] :) [09:36] thanks [09:36] asac, not getting 5.2 seems like that would be a mistake [09:36] seb128: sure it would be [09:36] just sayin gthat whatever isnt reality might never happen (even if unlikely and brutal) [09:36] asac: or speak to saviq when he's back on monday, i'm just a regular guy that shouldn't and don't want to take this decisions [09:37] greyback: morning, seen the mail by kevin about the sdk failure on demo-stuff ppa? [09:37] tsdgeos: my understanding was that you are saviq's placeholder [09:37] while he is gone [09:37] asac: i am saviq's placeholder [09:37] tsdgeos: yeah just now [09:37] tsdgeos: so you can make the decisions as he could [09:38] asac: that's a bit of a overstatement :D I don't have all the knowledge about all the other components he has, i've just been raised temporarily because we needed someone [09:38] tsdgeos: so what do you propose? as a leader you must have a clear suggestion [09:39] asac: i do have a clear suggestion, ignore test failures that happen in maguro but not on mako until 5.2 lands [09:39] asac, imho it doesn't make sense spend time to workaround toolkit issues in our code, especially if getting a workaround is not trivial, when we know those issues are bugs fixed in the new version [09:39] asac: i think i've been pretty clear in that [09:39] noone has proven that [09:39] its qt [09:39] its a guess [09:39] and hope [09:39] asac: noone has proven that it is not [09:39] right,k hence investigation is needed [09:40] we had many many flaky things fixed [09:40] or moving on with qt 5.2 is needed [09:40] on maguro [09:40] asac: and we have proven that there are billions of problems in qt [09:40] never was the toolkit cited as the reason [09:40] it's creating an increasing number of resources wastes [09:40] try how the APs succeed with qt 5.2 then [09:40] do they? [09:40] that could easily make us rest [09:40] asac: i don't know, do they? [09:59] Cimi: you wokring on the video stuff? [10:03] Cimi: the RatingStars.qml we weren't using it yet? [10:03] tsdgeos, we were using it [10:03] tsdgeos, thus I added the compatibility layer [10:03] ah righ [10:03] tsdgeos, mainly old previews [10:04] just saw it now [10:05] Cimi: should then tst_RatingStars.qml still be there and not rename/Rework it to proof the old way still works? [10:05] and add a tst_Rating.qml with the new code [10:06] tsdgeos, the tst_Rating is tested [10:06] Cimi: yes [10:06] Cimi: but you deleted the tst_RatingStars.qml [10:07] can we leave it there while we don't delete the compatibility stuff with the old scopes? [10:08] tsdgeos, how do I revert the previous file and add the new one? [10:09] good question :D [10:09] tsdgeos, I'll simply add the file [10:09] ok [10:09] and who cares [10:10] tsdgeos, at this point I can remove the compatibility layer and have double widget [10:11] ? [10:11] tsdgeos, copy back RatingStars [10:11] ah [10:11] sure [10:11] that is even better :D [10:11] be sure not to break old-scopes [10:11] tsdgeos, actually [10:11] tsdgeos, my new rating stars provides new assets [10:11] boring [10:11] :-\ [10:15] tsdgeos, readied old stuff [10:15] *readded [10:17] Cimi: the test too? [10:17] nope [10:18] tsdgeos, forgot to run bzr add [10:18] tsdgeos, done [10:26] anyone familar with LP builds? Getting weirdest error with: https://launchpad.net/~unity-team/+archive/demo-stuff/+recipebuild/652566 [10:27] nope :/ [10:27] ah, seems to be a more general fail. #ubuntu-devel discussing it now [10:29] @unity: don't update your machine right now, there seems to be a broken libgcc1 package in the repo atm [10:29] \o/ [10:29] not [10:29] let's revert everything! === _salem is now known as salem_ [11:09] Cimi: the ratings widget has the same problem vidoe had with the height [11:10] tsdgeos, ah sorry dude [11:10] tsdgeos, will fix [11:11] Cimi: no worries, that's why we have people reviewing :) [11:11] tsdgeos, pushed [11:12] Cimi: it ain't working [11:13] Cimi: apply the patch i said and see the difference between clip enabled and not enabled [11:13] unless it's on purpose that the line edit and button are not part of the height [11:13] which i think is a bit weird :D [11:14] what? [11:14] why is not working with implicitHeight? [11:20] tsdgeos, [11:20] Cimi: it's not that implicitHeight is not working, i'd say that your childrenRect is unhappy [11:21] let me have a look [11:21] tsdgeos, how do I test it? [11:21] Cimi: see the comment on the review [11:21] Cimi: i'd say your reviewContainer is missing a implicitheight too [11:22] I'm looking [11:22] tsdgeos, works for you? [11:22] nope :D [11:29] Cimi: http://paste.ubuntu.com/6930678/ ? [11:30] tsdgeos, I ant it to stretch [11:30] *want [11:30] mmm [11:31] Cimi: but it is not stretching :D [11:31] Cimi: see your own tryPreviewRating without any change [11:31] you have it set to anchors.fill: parent [11:31] tsdgeos, I understand why its not stretching [11:32] and it's just not height enough [11:32] but I'd like it to stretch [11:32] besides this is the implicitheight [11:32] tsdgeos, in case you want two line of comment [11:32] doesn't mean it can't adapt to more height [11:32] it just gives a default one [11:32] so if it should not prevent you from stretching [11:34] do we need some unreleased uitk version for the new-scopes stuff? [11:34] getting this: nativeOrientationAngle: 0 // stop contents being re-rotated when shell in landscape [11:35] but qtdeclarative5-ubuntu-ui-toolkit-plugin seems to be up to date [11:35] err. this is the error: Cannot assign to non-existent property "nativeOrientationAngle" [11:36] greyback: you might know this? ^ [11:36] mzanetti: yeah, I'm trying to get it built into the PPA [11:38] greyback: and it seems to be rotated on the desktop now [11:38] mzanetti: oh, that's not supposed to happen [11:39] mzanetti: greyback: maybe because of the missing uitk stuff? [11:40] tsdgeos, but if I disable the anchors, yes [11:40] Cimi: diff? [11:40] tsdgeos, your [11:41] tsdgeos: mzanetti: possibly, checking now [11:43] tsdgeos, even mine doesn't stretch though [11:43] Cimi: that's what i was saying :D [11:43] hah [11:45] ok... going for lunch then and will try again. greyback, please let me know when the uitk package is ready [11:45] mzanetti: will do. LP giving me grief [11:45] *try again later [11:46] Cimi: http://paste.ubuntu.com/6930736/ [11:46] Cimi: this works here with both [11:46] anchors.fill: parent and no width defined [11:46] and with width: parent.width no anchors defined and no height defined [11:50] tsdgeos, nope [11:50] tsdgeos, maybe sdk bug [11:50] nope what? [11:51] tsdgeos, try typing in the entry when it's filled [11:51] stretched [11:51] lol [11:52] * greyback bbiab [11:52] Cimi: so maybe just have my first patch and consider stretching for later? [11:52] tsdgeos, I want to fix the stretching if possible [11:52] tsdgeos, let me see [11:52] ok, work on that [11:53] tsdgeos, review the tests [11:53] tsdgeos, not sure they are done in the correct way [11:53] tsdgeos, like, logically correct to put logic inside tests [11:53] ok [11:53] tsdgeos, for me is fine, but I'd like an opinion [11:53] will do [11:54] mhr3, btw, I received nexus 4 yesterday [11:54] mhr3, guess which was the first thing I did? [11:55] Cimi, i don't want to know! :P poor n4, it's naked now! [11:55] ehehe [11:56] mhr3, thinking of getting a prepaid [11:56] mhr3, and try ubuntu on it outside dev [11:56] mhr3, is there a way to disable 3d data? [11:56] *3g [11:56] Cimi, you think it would work out-of-the-box? :) [11:56] mhr3: when you have some time i'd appreciate a quick test to see if https://code.launchpad.net/~aacid/unity8/misc_previewlist_fixes/+merge/206365 fixes your preview opening/closing problems [11:57] Cimi, i mean it might... but well :) [11:57] mhr3, still buggered? [11:57] tsdgeos, am just about to try it [11:57] tsdgeos, i need https://code.launchpad.net/~mhr3/unity-scopes-shell/preview-replacing-preview/+merge/206354 :) [11:59] mhr3: you want me to review it or you want me to make unity8 work with it? [11:59] tsdgeos, review [11:59] tsdgeos, it doesn't change much of the shell-facing api [12:00] mhr3: but does it work? :D [12:00] tsdgeos, ie nothing breaks [12:00] yes :) [12:00] amazing [12:00] tsdgeos, your branch does breaks the header though [12:00] after closing preview it's not there [12:00] sure, it's because of the scrolling of the view [12:01] you can scroll it back [12:01] but you're right it doesn't make sense [12:01] since there's enough space [12:01] it should be visible [12:02] yep [12:03] tsdgeos, is there a way to make the animation super-slow? [12:03] mhr3: the opening one? [12:03] yea [12:03] when opening preview for a scope it's super weird [12:04] i want to see what's going on [12:04] i'd say openeffect [12:04] but let me check [12:04] i don't see anything weird though with this branch :S [12:04] tsdgeos, i meant specifically scopes scope is odd (probably because of no-art) [12:04] sure i've been using scopes scope [12:09] mhr3: yes qml/Dash/DashContentOpenEffect.qml [12:09] - duration: 200 [12:09] + duration: 2000 [12:10] yea, the first frame make everything jump [12:10] makes [12:10] yep [12:10] going to see why that happens [12:10] that'll fix the closing too most probably [12:10] it works fine for the first row of results [12:10] interesting [12:11] yeah because there's some calculation in there going wrong [12:11] positionListView in PreviewListView.qml is a bit of too much calculation :D === MacSlow is now known as MacSlow|lunch [12:20] mhr3: pushed [12:20] same branch? [12:22] mhr3, hi, do you know if it is possible to return a preview with the new scopes api when an action is triggered in a preview and the perform_action method is called?? (for example, in the click scope move from the Install preview to Progress preview) [12:23] gatox, it is, but scope-tool doesn't support it yet [12:23] mhr3, we have been trying to figure it out how to do that yesterday, but no luck [12:23] mhr3, ahhhhh ok [12:23] pstolowski, can you explain pls ^ trying to prepare all the mps now [12:24] gatox, you need to respond with ActivationResponse with status=ShowPreview [12:24] gatox, and then you get a call to preview() [12:24] pstolowski, but that is not working yet, right? [12:25] gatox, so it's an extra round-trip (unlike the old API, where you could pass serialized preview right away) [12:25] gatox, not supported by scope-tool, right [12:25] pstolowski, ack, thanks [12:25] mhr3: yes [12:27] tsdgeos, maybe because textfield is supposed to be a single line [12:28] Cimi: maybe, there's a text area? [12:28] tsdgeos, it's another option [12:28] tsdgeos, not sure how it is themed [12:30] mhr3: i don't think that i can honestly review https://code.launchpad.net/~mhr3/unity-scopes-shell/preview-replacing-preview/+merge/206354 [12:30] mhr3: i can say you're missing a const :D [12:30] in some functions [12:31] but i have almost no knowledge of how that thing works [12:31] i don't see any obvious coding mistake [12:31] tsdgeos, just run it :) [12:31] but given that tests pass, that was to be expected [12:32] mhr3: and do anything special? i don't know how to get an install/progress widget, none of the scopes i have seem to do it [12:32] mhr3: or just do a test run of stuff? [12:33] tsdgeos, yea, replacing previews working is guaranteed by the test [12:33] famous last words :) [12:34] tsdgeos, or do what saviq does, get coverage report and see if the change lines are covered :) [12:35] tsdgeos: mhr3 mzanetti ...i am so sorry to leave broken ppa's for your morning, did we recover ? [12:36] kgunn, no, lp is borked :/ [12:36] kgunn: greyback was working on it [12:36] but seems we have a broken gcc or soemthing that makes it hard to recover [12:36] kgunn: LP having problems, and a bad libgcc1 broke everything for a while, but things seem to be moving slowly again [12:36] thanks...felt bad going to bed leaving it that way [12:37] kgunn: sleep more important [12:40] gatox, we have a branch with which scope-tool can do it, but lp is borked, can't rebuild the demo ppa [12:41] mhr3, ack..... any estimate for that?? [12:41] gatox, scratch that, lp works, it's building [12:42] mhr3, great [12:42] soon in demo ppa near you [12:43] mhr3: approved, want me to top approve too? [12:43] tsdgeos, if it works for you, sure [12:43] mhr3: did you have time to look at the second fix for the previewlist preview open/close thing? [12:43] not yet [12:55] tsdgeos, yea, now it seems to actually work :) [12:55] mhr3 demo-stuff works ? [12:56] kgunn, no, tsdgeos's branch [12:56] kgunn, what's broken there anyway? [12:56] mhr3: :) thot i was crazy... [12:56] ubuntu-ui-toolkit [12:56] i just cleaned and rekicked...let's see [12:56] oh :/ === alan_g is now known as alan_g|lunch [13:05] gatox, built for desktop > https://code.launchpad.net/~unity-team/+archive/demo-stuff/+sourcepub/3913988/+listing-archive-extra [13:09] mhr3, thanks [13:21] alrigth ubutnu-ui-toolkit seems to have built!...soon in the demo-stuff [13:21] greyback_: ^ [13:21] \o/ [13:22] kgunn: nope, not recovered yet. the merge conflicts between new scopes and right edge are quite bad... still trying to fix them [13:47] mzanetti: thanks...(and actually ui-toolkit is only part of the demo-stuff...for n7 rotation) [13:47] starting to need a crib sheet :) [13:47] kgunn: well, the new scopes stuff depends on it [13:47] kgunn: which means I need to get it merged with my branches too [13:48] mzanetti: oh crap...so we have to pull it in [13:48] it==ui-toolkit [13:48] kgunn: right now I tied to run the new scopes stuff on my desktop and it doesn't even start without the unreleased uitk stuff [13:48] really!?! [13:48] kgunn: commenting away the bits that make it fail, makes the shell start again, but rotated on the desktop [13:49] which in turn tries to load the unfinished sidestage stuff from my branch [13:49] mzanetti: well...true we didn't test the effect [13:49] i blame greyback_ [13:49] :D [13:49] I do so too :P [13:49] he's an easy target [13:49] nah... we'll get it fixed [13:50] but yeah, need to the get the uitk stuff into the ppa I believe [13:50] greyback_: right? ^ [13:50] what did I do now? [13:51] greyback_: just kidding. you didn't do anyhting [13:51] mzanetti: http://pastebin.ubuntu.com/6931260/ will at least un-rotate on desktop === alan_g|lunch is now known as alan_g [13:56] kgunn: what's the plan actually? to have the new scopes + right edge on all phones? [13:56] kgunn: or will there be different phone images? [13:56] mzanetti: yes...that's the plan === MacSlow|lunch is now known as MacSlow [13:56] mzanetti: check my thinking but demo-stuff will be for n10/n7 [13:56] and phone-right-edge will be for n4 [13:57] ok... so the right edge branch needs still some fixing to work with the new scopes... [13:57] * mzanetti is on it [13:57] mzanetti: thanks sir [13:57] no pressure but mark will be reviewing early next week [13:58] :D [13:58] kgunn: what's the ETA on new scopes landing into trunk? [14:00] pete-woods: ping [14:00] tsdgeos: hi [14:00] pete-woods: hud-service is at 100% [14:00] pete-woods: what do i do? [14:00] kgunn: anyways, this branch rebases right-edge-2 on new-scopes: lp:~mzanetti/unity8/right-edge-based-on-new-scopes [14:01] kgunn: should make it start up again with that, still some broken animations tho [14:01] tsdgeos: can you attach gdb to it? [14:01] i guess [14:01] let me [14:02] is it gdb -p PID ? [14:02] mzanetti: ta... [14:02] mhr3, do i need any particular unity branch to use previes activation to show a new preview? or upgrading the system is enough (on desktop) [14:02] i was gonna test dandrader's copy/paste from the landing silo....then i'll turn my eyes to that [14:03] pete-woods: http://paste.ubuntu.com/6931318/ http://paste.ubuntu.com/6931320/ [14:03] pete-woods: let me see if i can get debug symbols for libdbusmenu-qt5.so.2 and for hud-service [14:03] gatox, new-scopes is enough [14:03] tsdgeos: thanks [14:06] pete-woods: http://paste.ubuntu.com/6931329/ http://paste.ubuntu.com/6931331/ http://paste.ubuntu.com/6931338/ [14:06] pete-woods: the DBusMenuImporter::slotMenuAboutToShow and waitForWatcher seem to be the offenders [14:06] sil2100: ↑↑↑ is that you? === dandrader is now known as dandrader|afk [14:08] oh [14:08] now that i see [14:08] i also have a few [14:09] QVariantMap DBusMenuExporterDBus::getProperties(int, const QStringList&) const: Condition failed: action [14:09] bool DBusMenuExporterDBus::AboutToShow(int): Condition failed: menu [14:09] in my console [14:09] no clue where they come from [14:09] but seem related [14:09] tsdgeos: thanks for this debugging info - very helpful! [14:10] pete-woods: can i kill it now? [14:10] sure [14:10] tsdgeos: if they are in your console, it makes me think it's an app that you started from there that is the culprit [14:10]