[00:19] mzanetti, and with this for tonight is all :-) [00:19] http://people.ubuntu.com/~rpadovani/touch/cameraImprovement.jpg [00:19] Good night folks o/ [00:54] ping nik90, how is the clock merges coming? [00:55] balloons: we are discussing this on #ubuntu-autopilot [00:56] balloons: I am just trying to fix 1 test which is failing locally === chriadam is now known as chriadam|away [07:30] good morning [08:49] dpm: https://code.launchpad.net/~mzanetti/reminders-app/tablet/+merge/207062 [08:53] mzanetti: can I help? [08:53] popey: sure. you can review that one too [08:54] mzanetti, I'm about to start a call, but perhaps popey can give you a hand in the meantime on an actual device [08:54] kk, will do now [09:06] mzanetti: fyi there is an add note button on the toolbar even if you have no reminders account on the device. [09:06] popey: yeah... the merge that should fix that is not complete yet [09:07] ok, its not a biggie for mwc [09:07] given the device _will_ have an account [09:09] mzanetti: this is great. [09:09] really nice work, thank you! [09:09] :) [09:09] * mzanetti is a bit tired today :D [09:09] i owe you beer [09:09] you and me both ☻ [09:10] * popey didnt see his bed last night [09:10] once it gets to 4am it's kinda not worth it [09:10] heh [09:10] indeed [09:33] Good morning all; happy Tug o' War Day! :-D [10:00] Can anybody review my performance MR please at https://code.launchpad.net/~nik90/ubuntu-clock-app/performance-patch-1/+merge/207119 [10:06] sure [10:10] yu/132 [10:10] bah [10:10] ? [10:11] zsombi: hey I see some of your MPs ready to land at https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/+activereviews [10:11] zsombi: When is it planned to have jenkins land them? [10:12] zsombi: My clock convergence patch is almost complete..hence I am wondering when I can land it. [10:13] nik90: it will be landed with the CI train... it will take some time [10:16] zsombi: ok, I will see what I can do.. [10:17] nik90: I _love_ the little animation on the stopwatch screen! [10:17] popey: hehe :) .. [10:17] nik90: and i can see almost no cpu usage when not on the clock page [10:18] popey: even if you are in the clock page and the seconds hand is not shown, the cpu usage should be 0% [10:18] popey: every minute or so when the minute hand moves, the cpu usage will spike and then drop [10:59] popey: can I go ahead and top-approve my MR or do you want me to get someone to code review it? [10:59] finding someone who isn't super busy leading up to mwc will be hard [10:59] So I leave that to you ☻ [11:01] rpadovani: If you have time could you do a quick code review of https://code.launchpad.net/~nik90/ubuntu-clock-app/performance-patch-1/+merge/207119 ? [11:01] rpadovani: it has been confirmed to work properly by me, popey and jenkins [11:10] mzanetti, wow. Nice work, just tested reminders on the desktop now [11:10] :) [11:10] I need to install content hub to test it properly [11:10] dpm: the edit page looks crap... but that's because of the design experiments [11:11] dpm: on the desktop, content hub always crashes for me [11:11] yeah, that's the one I cannot see yet, I'm on 13.10 on my laptop, and my desktop with trusty is busted [11:12] mzanetti, what's up exactly with the edit page, do you have any screenshots? [11:12] dpm: http://i.imgur.com/JoY8FhS.png [11:13] anyhow... good enough for a first step towards convergence I'd say [11:14] mzanetti, thanks. It doesn't look bad to me, perhaps the gray line above the notebook title could be removed? [11:15] dpm: hmm... yeah... but its somewhat required on the phone to keep consistency with other pages [11:16] dpm: and I can't just drop the header here (as I did with the other pages on the right) because it's used to rename the note and contains the save button [11:16] mzanetti, ack, let's go with that, then [11:19] dpm: not sure if you've seen this already: http://i.imgur.com/A1cmkvF.png [11:20] dpm: so I think all my todos for MWC are done [11:20] or is there anything left? [11:20] popey: is the clock app supposed to run in the sidestage in nexus 10? [11:20] nik90, good work :-) [11:20] up until there's convergent designs working, yes [11:21] popey: When my convergence branch lands, we will have a tablet design..so can it go to the main stage [11:21] popey: fair enough [11:21] popey: in that case, I will remove that desktop option in my convergence branch [11:21] rpadovani: thnx [11:22] mzanetti, NICE! I saw you marked it as In Progress, but I hadn't seen it live [11:22] right... /me updades the blueprint [11:29] mzanetti, I think that was pretty much it, we're looking pretty good! It'd also might be good to review https://code.launchpad.net/~bobo-324/reminders-app/fix-1273111/+merge/204404 which he now updated. It'd be nice to get these font sizes right for MWC, but if you think it will still require too much work, then let's leave it post-MWC [11:29] what do you think? [11:30] dpm: oh right. he updated it [11:30] missed that [11:30] yeah, he just did it a few hours ago [11:30] dpm: I'll review again and think its okish... however, I have a feeling that it doesn't really solve the problem [11:30] it improves it a bit tho [11:31] but do you think it's a step in the right direction, or does it need to be tackled completely differently? [11:32] its ok... the static variable needs to become dynamic, populated by the real screen (or maybe window?) size taking into account grid unit sizes etc [11:32] but yeah... it's not completely off [11:32] I think we should get this in as is and then I'll spend an evening to really understand and fix the issue at some point [11:32] dpm: ^ [11:33] mzanetti, sounds good, thanks [11:52] mzanetti, popey, so in order to get the click package ready for cwayne today, does this sound as a plan? -> http://pastebin.ubuntu.com/6959557/ [11:53] * mzanetti nods [11:54] +1 [11:55] thanks guys [12:10] mzanetti, just a small nitpick on the reminders labels: https://code.launchpad.net/~mzanetti/reminders-app/tablet/+merge/207062 [12:11] dpm: that's already in trunk and not part of this mr. [12:11] dpm: but I'll propose a new one to fix this [12:12] ok, thanks [12:20] dpm: https://code.launchpad.net/~mzanetti/reminders-app/better-reminder-expiry-labels/+merge/207154 [12:21] mzanetti, awesome, approved! [12:27] dpm: endless world of branching models.. ;) Thought it otherwise, but will work too this way [12:27] hey m-b-o :) [12:27] m-b-o, what's that you were thinking otherwise? [12:28] dpm: I thought raul merging not in trunk, but in conditonal-weather-branch ( or copy) before the whole will land in trunk. but it should work this way too (or even better) [12:29] m-b-o, yeah, I'd like to have a fallback in trunk in case Raul does not have the time to look at the resizing [12:29] dpm: ah, ok! [12:30] m-b-o, I've had a look at the resizing myself this morning, and I don't think it's that trivial to get the sizes right [12:30] dpm: I saw a screenhsot, which looks ready aon n10 size, but everthing under units.gu(100) has flaws, Iguess [12:31] since the size of the elements inside the Ubuntu shape are not relative to the shape [12:32] dpm: you should have a mail [12:33] ok, looking... :) [12:34] m-b-o, that looks good! [12:34] it is! :) [12:36] m-b-o, but I'm still concerned about the timing of this landing today. Let me reply to that e-mail to both of you. [12:36] dpm: okay, no problem [12:51] m-b-o, sent a reply to that e-mail. Let me know if it makes sense [12:56] dpm: makes sense! [12:57] m-b-o, ok, thanks for reviewing! [13:08] hey nik90, around? [13:15] dpm: hey [13:15] hey :) [13:16] dpm: were you going to ask me something? [13:16] nik90, I shared a google doc with a proposal for a landing plan for the 3 core apps with tablet layouts, including clock. I've not been following closely which branches need landing for clock. Could you help me filling in the blanks for clock in the document? [13:17] dpm: sure, which google doc? [13:17] just got it [13:17] ok, cool :) [13:19] dpm: I mentioned a prerequisite branch in the chat there [13:26] nik90, thanks. Can we land clock before the SDK branch lands? I.e. does the crash only happen on resizing and not on the tablet? [13:26] dpm: technically yes, but I haven't tested it yet to confirm that [13:27] dpm: let me finish my branch (should take at most another 30 mins) and then I will ask you guys to test it on the devices [13:28] nik90, sounds like a plan, thanks nik90! [13:31] popey, are you able to reproduce bug #1281745 on N7? Unfortunately is impossible to reproduce on desktop, and I have no idea on which is the cause [13:31] Launchpad bug 1281745 in Ubuntu Calculator App "white rectangle on calculator sidestage on N7 landscape" [Undecided,New] https://launchpad.net/bugs/1281745 [13:35] rpadovani: yes [13:35] popey, any idea on how fix it? [13:35] hmm [13:37] rpadovani: posted a picture to the bug report so you can see it [13:37] thanks [13:47] m-b-o, could you review https://code.launchpad.net/~dpm/ubuntu-weather-app/fixes-1282081/+merge/207190 ? (I'm not sure why the key.js file is added, it isn't on my local diff, so I'm guessing it's got to do with Jenkins) [13:48] rpadovani: i have no idea what that white box is [13:48] i cant move it [13:48] popey, not good at all [13:53] dpm: https://code.launchpad.net/~popey/ubuntu-calendar-app/fix-1281236/+merge/206787 can you review pls? [13:54] popey, approved! [13:55] popey, rpadovani : actually the clock app has the bug similar to the calculator -> https://launchpadlibrarian.net/166656767/clock.JPG [13:55] popey, rpadovani https://bugs.launchpad.net/ubuntu-clock-app/+bug/1281622 [13:55] Launchpad bug 1281622 in Ubuntu Clock App "clock resizing incorrect on N7 2013 landscape" [Undecided,New] [14:01] hi fginther, re: click package jobs in Jenkins, you mentioned they're run daily. Can we get them triggered on demand? E.g. we'd like to do 3 core apps releases today, and we'd like to get the click packages generated from Jenkins, i.e. the job triggered [14:08] dpm, that should be ok for today, just let me know when and where [14:09] dpm, which apps are they, I want to take a peek at the build jobs to make sure they are still working [14:09] fginther, reminders, clock, weather [14:10] (thanks!) [14:10] dpm, glad I asked, looks like reminders and clock need some work [14:11] fginther: :) how come? [14:12] nik90, for clock the build system was changed to use cmake, jenkins hasn't been updated yet [14:13] fginther: ah okay ... yeah the clock app in the store is behind by at least 45 commits :)...should be a nice upgrade [14:18] popey, dpm: Please test lp:~nik90/ubuntu-clock-app/converge-clock-tab on your devices both N4 and N7. Let me know if it crashes..On my phone it crashes. Lets see what happens [14:18] full convergence done [14:26] ok nik90 [14:29] dpm, FYI clock and reminders build jobs have been update and appear to be working again (at least they generate a .click :-) ) [14:29] fginther, awesome, we need to get the branches landed first, and when we've done that we'll ping you to generate the new .clicks via Jenkins if that works for you [14:30] nik90, fginther, popey mentioned that for clock there are some funky dependencies on the EDS plugin and the order it's built... I'm not sure I could follow. Is this something that we need to worry about? [14:31] dpm: the clock app uses the Alarms API which in turn depends on the EDS plugin to work. So it is not a direct dependency. The EDS plugin should be dependency of SDK afaik [14:32] nik90, ack. Is there anything we need to take into account when building the clock's .click? [14:33] dpm: sry, I am not sure..nothing has changed recently except for the cmake migration as far as click building goes [14:33] dpm, I don't really know what the core issue is. When jenkins test on the desktop, the clock-app is severly degraded by the presence of qtorganizer-eds. It's not an enforced dependency because the app can still be installed after removing qtorganizer-eds [14:34] dpm: we need renato's help here to figure the issue described by fginther [14:34] nik90: in that branch i have built a click and installed, and the icon is missing, doesn't appear to be being built into the click package [14:34] fginther: it is true that the app can be installed after removing qtorganizer-eds. However then you are not testing the true conditions [14:34] no clock-app@30.png exists anywhere under /opt/click.ubuntu.com/com.ubuntu.clock/current [14:35] fginther: since then the alarms would not be created in EDS itself but rather in the memory [14:35] popey: hmm weird [14:35] popey: can you test if your branch which submitted the icon correctly builds the icon? [14:35] X-Ubuntu-StageHint=SideStage [14:35] thats still there [14:35] so on nexus 10 your branch is in the side stage [14:36] popey: I just removed the sidestage hint just now [14:36] popey: can you update again [14:36] I'll ninja edit on the tablet [14:36] save rebuilding [14:36] okay [14:36] fginther, severely degraded you mean in terms of performance? [14:37] dpm, It actually hangs on start up [14:37] but it never crashes AFAICT [14:39] fginther: that's new..so it has to be the last few commits of EDS..since it worked perfectly fine before [14:39] fginther: the alarm backend code in clock app was not changed recently === boiko_ is now known as boiko [14:41] nik90, right, there was a new update to qtorganizer-eds that occurred when the problems started [14:41] nik90: taken some pics of it on the n10 and a video [14:41] uploading [14:42] popey: good or bad news? [14:42] mixed ☻ [14:43] nik90: http://imgur.com/jDvF5k1,DWtWOzz,kf1ihw4,sKbw1My,Sr45gNn,3T98SSW [14:45] popey: screenshots looks good [14:45] although the timer hint bars are rather close to the timer face [14:45] nik90: https://www.youtube.com/watch?v=f2CkurWjvZI [14:47] zsombi: can you help with https://www.youtube.com/watch?v=f2CkurWjvZI [14:48] zsombi: the animation seems a bit weird [14:48] specifically in case it's not clear, I'm talking about the clock face leaping around [14:48] popey: yup got that :) [14:48] :D [14:50] popey: it is basically transitioning from phone to tablet interface [14:50] nik90: what animation? you call the component appearing in the left-top corner then moving to the center as animation? :) [14:51] zsombi: hehe [14:51] zsombi: Is there a way to hide that or remove that? [14:51] nik90: it crashes on the phone. [14:51] nik90: I don't know what you are doing there... sorry [14:52] popey: yup .. we need the sdk patch for that then [14:52] ☹ [14:52] you see same? I don't need a video for this? [14:52] zsombi: I am basically switching from a Flickable layout to a Row [14:52] popey: yup I told you ,,,for me it crashes on the phone [14:53] popey: the reason is that by default the clock app shows the tablet interface [14:53] popey: that's why it worked on the tablet and not on phone [14:53] of course [14:53] sorry, sleep deprived ☻ [14:53] nik90: so you have the default layout in a Flickable, and the tablet layout is a row? [14:53] zsombi: yup [14:54] zsombi: but I still defined a tablet and phone interface where phone is the default layout that gets triggered [14:54] zsombi: so layouts: [ "tablet", "phone"] [14:55] nik90: you have ConditionalLayout for both? [14:55] zsombi: yes. is that wrong? [14:55] nik90: do you have default layout? [14:55] zsombi: no [14:56] zsombi: as in the UI elements inside the Layouts {} do not have any anchor definitions [14:56] zsombi: the anchor definitions are given only in the "phone" or "tablet" layout condition [14:56] nik90: wow... how comes? [14:56] nik90: you can say that the default layout is the phone, and then define ConditionalLayout for tablet... [14:57] zsombi: I don't know..I just thought you are supposed to define the rules on in the conditional layouts and not have a default layout persay [14:57] zsombi: ah :( [14:57] zsombi: Is it required for the UI elements to be declared inside the Layouts {} container? [14:58] nik90: the Layouts tutorial is also talking about that, that you define a default layout, then you name the components you will lay out differently, then you define the other layouts [14:59] zsombi: yeah I will read through it again [14:59] nik90: yes, you have to [14:59] zsombi: could this be the cause of my "animation" bug? [14:59] nik90: otherwise the layouting will not know wo will be laid out [15:00] nik90: it could [15:01] nik90: it seems that the layout engine tries to show, then hide, then show it again on its final position... [15:01] zsombi: yeah seems so [15:01] zsombi: thnx for your help..I will fix it and hope for the best [15:01] popey: can I get another hour to fix the animation issue? [15:02] nik90: I suggest you re-read the tutorial, it will give lots of hints :) [15:02] nik90, so could we go for a default phone layout and a conditional tablet layout to work around that bug? That's what the weather app does [15:02] I mean the crasher bug [15:02] dpm evernote call.. [15:02] ah, coming, thanks for the heads up! [15:03] dpm: no that won't fix the crash issue..with your suggestion the clock app will open fine on the phone but then crash on the desktop [15:03] dpm: we need the layout transition patch from the SDK on the phone [15:03] will talk after you evernote meeting [15:06] nik90: dpm: eventually you could take that patch and create dedicated MWC image with... bad idea... [15:12] zsombi: is it a bad idea to just push one single patch to the phone in the normal way? [15:16] nik90, that might be one option, but given the amount of moving parts, I'd suggest not to do it [15:17] dpm: I understand but the thing is this patch affects only the clock app. The patch does not affect other areas of the SDK. [15:31] nik90, yes, but I don't think it would be accepted for landing outside the regular process, so I'm trying to find alternatives to get your work to land for MWC. Does this summary make sense if we take the SDK out of the equation? http://pastebin.ubuntu.com/6960400/ [15:32] dpm: The first situation is good. Second situation I dont follow [15:32] dpm: do you want two default layout options where you choose which one based on the device? [15:34] nik90, that was from the conversation earlier on, where you mentioned that there wasn't a default layout, all were conditional, so I'm suggesting to do the same as the weather app, where there is a default layout that corresponds with the phone and a conditional layout (the condition being if width > phoneWidth) that is active on tablet and on desktop (when resizing) [15:36] nik90, popey https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds/+bug/1282129 [15:36] Launchpad bug 1282129 in qtorganizer5-eds (Ubuntu) "Clock and calendar tests fail with static void QOrganizerEDSEngine::itemsAsyncListed(ECalComponent*, time_t, time_t, FetchRequestData*) " [Undecided,New] [15:36] dpm: that won't work :(... As of now, I created the default layout (phone) and made a conditional layout for the tablet, however when I switch from phone to tablet it fails [15:36] dpm: that said, let me complete the fix and we can test again [15:37] dpm: I am half way there [15:37] dpm: already fixed clock and alarm [15:37] balloons: oh joy [15:37] nik90, let's try to test it on a device. Thanks for the extra effort! [15:37] Yeah, going above and beyond the call of duty here nik90, you should take a week off next week ☻ [15:38] popey: well I want the clock app tablet interface to be shown in MWC :) ... I will try my best to do what it takes to get that done [15:38] That's the spirit! [15:39] * popey adds "Clone nik90 to ToDo list" [15:39] * nik90 lol [15:39] popey: let me give you a click for clock and calendar; see if they even run on the device [15:39] balloons: roger roger [15:58] popey, dpm: I fixed the animation issue. Can you test pls [15:58] N4 and N7 [15:59] sure thing nik90 [16:18] nik90: icon still missing [16:18] nik90: not crashing on n4 [16:18] \o/ [16:18] popey: I am not sure about the icon, since I did not change anything there [16:19] popey: regarding the icon, we will get balloons or sergio's help on this [16:19] file:///usr/share/unity8/Launcher/LauncherDelegate.qml:62:20: QML QQuickImage: Failed to get image from provider: image://theme/clock-app@30.png [16:19] yeah. [16:21] popey: does it work on the n7? [16:21] popey: btw it didnt crash on my N4 as well :) [16:21] working on it [16:23] "not crashing on n4", that's what we like to hear :) [16:24] nik90: the cities show under the clock, not tablet style [16:24] I think this is because the gu setting is wrong [16:24] popey: I set the tablet condition as 80 [16:24] popey: but I did not change it since the last time you tested it [16:25] lemme test on n10 [16:25] popey: also the 80 gu unit condition was recommended by Kaleo [16:28] dpm: :) [16:28] nik90: still jumps a little on n10, not as much, and only vertically [16:28] want a video? [16:29] popey: yes pls [16:29] kk [16:32] popey: wait so the jumpy thing is only vertically [16:32] I think I might know the cause [16:32] yes [16:33] popey: also do you think the sidebar animation is annoying everytime you switch tabs? [16:33] I can remove that [16:34] dpm,popey: So from popey's testing, it seems that the clock app now runs on N4 and N10 without crashing. That's good news :) [16:34] which animation? [16:34] yes [16:34] just need to fix the icon ☻ [16:34] and vertical jump === gatox is now known as gatox_lunch [16:35] nik90: https://www.youtube.com/watch?v=NiqelgB-MqA [16:35] popey: when you switched from stopwatch -> clock tab there was a sidebar animation from the right [16:35] I was referring to that [16:36] popey: I can fix the vertical jump..should be easy [16:36] nah, i like the animation [16:36] dpm, popey: What is the deadline for the click package animation? Do we need it by today? [16:36] s/animation/creation [16:37] dpm, popey: I need to fix AP tests and some minor cleanup. I need today. would that be a problem? [16:37] yeah. [16:37] i think so. [16:38] popey: I will try to get it done then [16:38] dpm: what do you think? [16:40] * dpm reads scrollback [16:41] * dpm watches video [16:44] popey, nik90, what about 1) landing the fix for the crasher and the one for the vertical jump 2) Create a click package 3) Do a best effort to fix the animation and create a new click package. If not possible, go for the click package from 2) [16:46] dpm: what about the AP tests? [16:47] dpm: I already may have a fix the vertical jump (should remove most of the vertical jump, might have a small jitter) [16:54] nik90, ah, yes, we need the AP tests fixed, I'd missed that part [17:10] nik90, to answer the question earlier, the deadline for the click package is today, yes. Do you think the AP tests can still be fixed? [17:11] dpm: yeah I think they can be fixed..I need about 2 hrs to fix all that [17:12] nik90, ok, thanks. I'll check with cwayne if that still works for him [17:14] nik90, cwayne says that should work, hopefully that takes a bit of pressure off you [17:14] dpm: it does..thnx :) [17:14] popey: quick question...does the system application like gallery etc lock their toolbars on N10? [17:14] popey: I beleive that is the cause of the vertical jump [17:15] no [17:15] they all have a toolbar on start, then the toolbar drops away [17:15] popey: alrite..I will remove that from the clock app as well [17:15] popey: we can explore this post MWC [17:15] ok === gatox_lunch is now known as gatox [18:02] renato: boiko: tsdgeos: artmello: does anyone of you know if it's possible to flush the QML image cache ? maybe even for just one image ? [18:03] nerochiaro, I know that you can set cache property to false :D [18:04] this is the only information that I can give you, I do not know how the cache itself works [18:04] renato: yeah, but i don't want to do it because i want the cache to be normally on, then when i really want one image to reload from disk I will clear the cache to force [18:07] dpm, popey: I think I fixed the vertical jump and AP tests. I am waiting to see if jenkins can confirm the AP tests pass. [18:07] can one of you confirm the vertical jump fix? [18:08] nik90, unfortunately I don't have a tablet, but I can do testing on a Nexus 4 [18:08] dpm: ok [18:08] dpm: I will also test now [18:10] dpm: things look really good on N4 [18:18] fginther, can we get the reminders click build triggered? [18:19] fginther, the branch has landed and it's good to go as the first of the 3 core app tablet updates for today [18:25] nerochiaro: I remember there was a bug opened for that, but what I did when I needed something like this was to add a serial number to the image provider URL (like image://something/?serial=1 or something like that) [18:26] nerochiaro: not optimal, but it did the job back then [18:28] boiko: right, that's the trick i remember too. i was hoping for something cleaner, but I guess I will have to go with that [18:31] dpm: alrite balloons the AP tests pass :) [18:31] dpm: which leaves only vertical jump test [18:31] dpm: then we are set for life [18:32] \m/ [18:32] \m/ fist back :) [18:35] dpm, reminders app is building now [18:36] awesome [18:36] fginther, I talked to balloons and we're discussing that it might be necessary to roll back the latest e-d-s plugin upload for clock to land. What's your opinion? [18:37] dpm: we went through this last night.. the builder has a proper version that lets clock build. Calendar will not build [18:38] dpm, clock can build now, but if calendar needs to land also, then I'll need on older version of the eds packages, I don't have any [18:40] balloons, fginther, do I understand it correctly that we can leave this post-MWC if we don't need a new version of calendar to land today? [18:40] just trying to figure out the best thing to do [18:40] today it's only clock, calendar and reminders [18:40] shit [18:41] clock, *weather and reminders [18:41] sorry for the confusion [18:42] dpm, no worries [18:42] dpm, reminders has been updated https://jenkins.qa.ubuntu.com/job/reminders-app-click/ [18:43] awesome [19:00] nik90, I cannot test on tablet, but on desktop the clock looks gorgeous! [19:01] nik90, on the desktop, should I be able to test the vertical jump fix, or was it not noticeable there? [19:04] dpm: I think it happened fast that you don't notice it much on the desktop [19:04] dpm: need someone to review the MP and then approve it [19:05] nik90, I can do that, but I'd like to see if someone with a N10 can give it a quick test-drive too [19:05] dpm: that would be best [19:07] let me see if I can create a local click package to hand over to someone to make it easier to test... [19:07] nik90, did you bump the release number too? [19:08] dpm: I don't do it anymore this cycle since the click packages uses the revision number for the release number [19:08] dpm: so the clock version on the phone is 1.300 or something like that [19:08] no worries, that should work [19:26] nik90, I'm getting the same issue as popey - the click package I create locally doesn't contain the app icon, trying to figure out what's going on... [19:27] dpm: okay..can you try creating a click package of rev 345 [19:27] dpm: that's where the icon change was made [19:29] nik90, are you sure it was that revision? I cannot see any icon changes between r345 and r346 [19:30] dpm: I am referring to MP https://code.launchpad.net/~popey/ubuntu-clock-app/new-icon/+merge/207037 [19:30] dpm: which got merged into trunk at rev 345....so you will notice the change between 344 and 345 [19:32] nik90, hm, looking at the convergence branch now, I can't see that merge in r345, but in any case the CMakeLists.txt file contains the right icon, i.e. the change introduced in that MP ^ [19:32] fginther, I think you mentioned you had some issues building the weather click package and getting the icon to be included in there. Can you remember what fixed it? [19:33] dpm: ah you don't see that commit message in my MP because I merge trunk with the commit message "merged trunk" [19:51] dpm, I didn't do anything to fix it. I attempted a change to the CMakeList.txt file to explicitly copy over the ICON, but it was the wrong fix and I don't now if it actually worked [19:58] fginther, thanks, no idea why it's not including it locally. Do you have the command line how the click packages are built in Jenkins? [19:59] fginther, and also, do you know why this MP is Needs Fixing even though it passes the tests? -> https://code.launchpad.net/~dpm/ubuntu-weather-app/fixes-1282081/+merge/207190 [20:00] dpm, http://paste.ubuntu.com/6961764/ [20:01] ok, thanks will try to build locally like that [20:02] dpm, the steps are from click-buddy in lp:phablet-tools [20:02] fginther: I just did click-buddy --dir . --provision [20:02] I still don't see the icon for clock app [20:03] balloons, can you shed any light on the missing icon ? ^ [20:06] no, did the same steps as click buddy manually and the package doesn't include the icon [20:14] could it be that cmake chokes at the @ in clock-app@30.png? [20:14] * dpm tries [20:16] nope, red herring [20:17] dpm: weather has it as well +set(ICON weather-app@30.png) [20:17] dpm: I don't get it, when you compare the weather app and clock app commits for the new icon they are exactly the same :) [20:18] yeah, it's not that commit that changed anything, it's something in the cmake file [20:19] dpm: true since we haven't upload clock app click with the cmake migration [20:24] it seems that a local .click build does not include the icon, either [20:24] of the weather app, I mean [20:25] man, after all the effort to get the code finished, I can't believe we're blocking on this [20:25] * dpm shakes fist at cmake [20:29] is there a device emulator to test phone interfaces on if you don't have an ubuntu device? [20:42] mrgoodcat, https://wiki.ubuntu.com/Touch/Emulator [20:43] ty rpadovani [20:43]