| === chriadam|away is now known as chriadam | ||
| dholbach | good morning | 06:47 |
|---|---|---|
| === chriadam is now known as chriadam|away | ||
| === JamesTait is now known as Guest57947 | ||
| dpm | morning popey, when you're around, could you try to install this click package and show me a screenshot? http://people.canonical.com/~dpm/click/com.ubuntu.weather_1.0.201_all.click | 09:21 |
| === Guest57947 is now known as JamesTait | ||
| JamesTait | Good morning all; happy Love Your Pet Day! :-D | 09:23 |
| dpm | m-b-o, morning, thanks for approving the branch! Do you have any ideas about the known issues listed there? -> https://code.launchpad.net/~dpm/ubuntu-weather-app/fix-nexus7/+merge/207325 The footer position and the crasher are the ones that I consider blockers | 09:24 |
| m-b-o | dpm: this footer stuff with twc only happens on n7, not on desktop, right? | 09:25 |
| dpm | m-b-o, exactly, I cannot see it happening on desktop, not sure what's going on on the n7. I'm tempted to make the footer full width to work around it rather than play with GUs | 09:26 |
| m-b-o | dmp: regadring the missing H temperature: when it's late in the day, TWC has no real H temperture left to show. this happens oly in the second half of the day | 09:27 |
| dpm | m-b-o, ah, good to know, thanks | 09:28 |
| popey | dpm: morning, what device? | 09:29 |
| m-b-o | dpm: "ScrollingArea.qml:61: Error: Cannot assign [undefined] to int" is unrelated to the device | 09:29 |
| popey | I only have n4 and n7 now | 09:29 |
| dpm | popey, sorry, I meant a n7 | 09:30 |
| m-b-o | dpm: that occurrs when something's wrong with line 58 in th efile | 09:30 |
| dpm | m-b-o, yeah, | 09:31 |
| dpm | it seems that there wasn't any pressure data either? | 09:32 |
| dpm | but it shouldn't cause a crash I thought | 09:32 |
| m-b-o | yes, perahos it's related to switching the data rpovider in a specific way | 09:32 |
| m-b-o | perhaps it's related to switching the data provider in a specific way | 09:33 |
| popey | dpm: I need to re-flash my n7, so will take a little while as it's dead | 09:33 |
| dpm | popey, no worries, thanks | 09:33 |
| dpm | m-b-o, yes, I thought that as well, but they said they'd wiped out the database before testing. Let's see if popey's testing can shed some more light on this. Would you agree to make the footer full width rather than digging up why it's shorter on the N7? I've just made the change on a local branch and full width looks ok | 09:35 |
| m-b-o | dpm: of course! I pesonally like the wide twc footer! Is the footer okay when switched back to owm ? | 09:40 |
| dpm | m-b-o, after switching to full width, the OWM footer looks ok on the desktop, not sure what it'll look like on the device. Here are a couple of screenshots: | 09:46 |
| dpm | - TWC, full width: http://ubuntuone.com/5OLTa6rRQ1MpaSMfNxzYIM | 09:46 |
| dpm | - OWM, full width: http://ubuntuone.com/0ulO5fkQb5466kWvbDt8M3 | 09:46 |
| dpm | The OWM one looks a bit strange with the empty space under the forecast view on the right, but I think it's ok | 09:47 |
| m-b-o | dpm: yes! But that corner is difiicult to make nice... | 09:48 |
| dpm | m-b-o, I think for now it's absolutely fine. But just for the record, what makes it difficult to make nice? | 09:49 |
| m-b-o | dpm:the different footers of TWC and OWM (one with white bar, the other only with icon) we need to have two ways handling the footer. which makes positioning the navigation harder | 09:50 |
| m-b-o | dpm: would be easier if both footers would be aligned in their design | 09:51 |
| dpm | m-b-o, ok, gotcha. We can deal with it with a more in-depth tablet redesign after MWC. I think for now I'll submit a MP with the full width TWC footer | 09:51 |
| m-b-o | dpm: waiting to review! :) | 09:53 |
| dpm | m-b-o, there you go :) -> https://code.launchpad.net/~dpm/ubuntu-weather-app/full-width-footer/+merge/207383 | 09:59 |
| nik90 | Good morning folks | 10:00 |
| dpm | hey nik90 | 10:00 |
| nik90 | hi dpm | 10:00 |
| dpm | popey, what's the status of removing the sidestage hint for Music and Shorts (and perhaps Terminal and File Manager, although I'm not sure we'll be demoing them)? | 10:05 |
| dpm | m-b-o, thanks for the review! Can you top-approve if you're happy with it? | 10:06 |
| popey | bug 1281236 dpm | 10:06 |
| ubot2` | Launchpad bug 1281236 in Ubuntu Calendar App "App appears in sidestage in landscape mode on Nexus 10" [Undecided,New] https://launchpad.net/bugs/1281236 | 10:06 |
| m-b-o | dpm: :) | 10:06 |
| dpm | ah, yeah, and Calendar | 10:06 |
| nik90 | dpm: I just got an update to image #194 with the new clock app :) | 10:14 |
| dpm | nik90, what!!? Nice, I didn't know myself that when landing it in the store it'd make it directly in the image. So did you get it without explicitly updating the app in the store? | 10:15 |
| nik90 | dpm: yeah..on running update, it started updating to image 194...after installing and restarting I saw the new clock app icon and the new stuff | 10:16 |
| nik90 | dpm: but yes it wasn't explicity updating the clock app | 10:17 |
| dpm | cool, I'll update in a bit, it takes a bit longer for me with dual boot | 10:18 |
| nik90 | ok | 10:18 |
| * popey finally re-flashes n7 | 10:20 | |
| popey | dpm: i had to give mine away to someone in te office, so I just got another n7 which is still on android.. flashing now | 10:20 |
| dpm | popey, that's not the way to go, you should be _stealing_ instead of giving away :) | 10:20 |
| popey | hah | 10:21 |
| nik90 | +1 | 10:23 |
| dpm | popey, or someone else, could you review the 3 branches in this bug? They're pretty trivial, it's the same fix we applied yesterday to clock and weather to install the icon in the click package | 10:42 |
| dpm | https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1282500 | 10:42 |
| ubot2` | Launchpad bug 1282500 in Ubuntu RSS Feed Reader App "Cmake file does not add the icon in the click package" [High,In progress] | 10:42 |
| nik90 | dpm: how do you install the click package you mentioned yin your MP? | 11:01 |
| nik90 | s/yin/in | 11:01 |
| dpm | nik90, http://pastebin.ubuntu.com/6964813/ | 11:05 |
| nerochiaro | just joinned | 11:10 |
| nik90 | dpm: reviewed all 3 | 11:13 |
| dpm | \o/ | 11:13 |
| aquarius_phone | popey, ping | 11:13 |
| popey | \o/ | 11:14 |
| dpm | popey, how's the flashing going, have you had the chance to test the weather click? | 11:28 |
| dpm | nik90, updated https://code.launchpad.net/~dpm/ubuntu-calendar-app/fixes-1282500/+merge/207400 - would you mind having another look? | 11:28 |
| popey | not yet.. nearly done | 11:28 |
| nik90 | dpm: sure | 11:29 |
| dpm | nik90, and on https://code.launchpad.net/~dpm/ubuntu-rssreader-app/fixes-1282500/+merge/207401 - the icon is in the code already. These MPs were to fix the icon installation, the icons should have been pushed already in other MPs (except for calendar, where the icon refresh MP failed) | 11:32 |
| dpm | I'm looking at the music app error now | 11:32 |
| popey | dpm: it works, but having trouble with the n7 image | 11:33 |
| nik90 | dpm: ah okay...btw when I do pkill unity8, how long am I supposed to wait for unity8 to restart? | 11:33 |
| dpm | nik90, it should start after a few seconds. Once you see the welcome screen you should be good to go | 11:33 |
| dpm | popey, what trouble? | 11:34 |
| popey | yes, the n7 image I'm using still has sidestage issues | 11:34 |
| popey | lemme get a photo of weather | 11:34 |
| nik90 | dpm: calendar MP didnt work...calendar icon is now missing | 11:36 |
| nik90 | in the dash | 11:36 |
| dpm | nik90, hm, it's in the click package, not sure what could have gone wrong... | 11:38 |
| m-b-o | dpm popey updatting my n7 12 to r194, where can I find the .click package? | 11:40 |
| nik90 | dpm: rss-reader icon worked! I see it in the dash | 11:42 |
| dpm | m-b-o, 1) Click package without footer fix: http://people.canonical.com/~dpm/click/com.ubuntu.weather_1.0.201_all.click | 11:42 |
| dpm | m-b-o 2) Click package with footer fix: http://people.canonical.com/~dpm/click/com.ubuntu.weather_1.0.202_all.click | 11:42 |
| dpm | nik90, nice :) | 11:42 |
| dpm | nik90, I see a fix required in Music's cmake file, but I can't understand why Calendar's icon doesn't work :/ | 11:43 |
| nik90 | dpm: let me try to compare calendar and rssreader folder structure and compare their cmake files | 11:43 |
| dpm | cool, thanks | 11:44 |
| dpm | nik90, on https://code.launchpad.net/~dpm/music-app/fixes-1282500/+merge/207399/comments/486610 - in which step did you get this error? | 11:47 |
| nik90 | dpm: right at click-buddy --dir . | 11:48 |
| dpm | ok, thanks, fixing it. | 11:48 |
| popey | dpm: m-b-o http://imgur.com/WjPEtMU,XutOQ6o | 11:48 |
| dpm | popey, ok, perfect, thanks! Could you now test http://people.canonical.com/~dpm/click/com.ubuntu.weather_1.0.202_all.click - this should fix the footer issue and should be the final weather package (final last words :) | 11:49 |
| popey | k | 11:50 |
| nik90 | dpm: I am unable the error in the calendar cmake file. I am going to try installing it again to make sure | 11:52 |
| nik90 | s/unable the error/unable to identify the error | 11:52 |
| dpm | nik90, ok, thanks a lot. I've also fixed https://code.launchpad.net/~dpm/music-app/fixes-1282500/+merge/207399 and the package should now build. If you could have another look at it, that'd be great | 11:55 |
| popey | dpm: not quite http://imgur.com/4a8bXJk,h3mrXJM | 11:55 |
| nik90 | dpm: on it | 11:55 |
| dpm | popey, that's fine, we cannot easily fix the OWM footer without more intrusive changes. Does the OWM footer look full-width on the N7? | 11:56 |
| m-b-o | dpm popey what's the command to install the click package on the device? | 11:57 |
| popey | dpm: see other image | 11:57 |
| popey | (there's two) | 11:57 |
| dpm | m-b-o, http://pastebin.ubuntu.com/6964813/ - btw, are you testing on a N7 (2013) ? | 11:57 |
| m-b-o | nope 2012 | 11:57 |
| m-b-o | without mir | 11:58 |
| dpm | popey, ah, bummer :( | 11:58 |
| dpm | m-b-o, I think on your N7 it will look different than on popey's N7 (2013) because of the different resolution | 11:59 |
| dpm | popey, ok, so the footer needs fixing. Can you click on the 2 current weather boxes and they do the animation to show 4 boxes? I.e. does that still work as on the phone? | 12:00 |
| nik90 | dpm: music app also works :) | 12:00 |
| popey | dpm: yes, but it's cramped | 12:01 |
| dpm | nik90, cool, only calendar to go, then? | 12:01 |
| nik90 | dpm: yup | 12:01 |
| m-b-o | dpm popey no landscape | 12:01 |
| nik90 | dpm: on installing calendar again, it still didnt work :( | 12:01 |
| dpm | nik90, what do you see, an empty icon in the applications scope? | 12:02 |
| nik90 | dpm: yes..like the clock app icon yesterday | 12:02 |
| popey | m-b-o: it might be possible to make the old n7 go landscape | 12:02 |
| popey | m-b-o: compare (on device) /etc/ubuntu-touch-session.d/grouper.conf with flo.conf | 12:03 |
| popey | NATIVE_ORIENTATION=landscape | 12:03 |
| m-b-o | popey: okay | 12:03 |
| dpm | popey, would you mind sending another screenshot of the 4 boxes where you mean it looks cramped? | 12:03 |
| popey | hang on | 12:04 |
| popey | m-b-o: actually stick those in ~/.bashrc | 12:04 |
| popey | /etc/ubuntu-touch-session.d/grouper.conf will be readonly | 12:04 |
| popey | dpm: some of this may be because my device has the default setting to 21 gu | 12:05 |
| popey | which is wrong for flo, it should be (IMO) 17 | 12:05 |
| dpm | popey, yes, I tend to agree with you after having seen the screenshots. Who do we need to ping to fix this? | 12:06 |
| m-b-o | popey: they are already in .bashrc? I hsoudl use GRID UNIT_PX from grouper.conf or flo.conf? | 12:06 |
| popey | http://imgur.com/j7V0XR3 | 12:06 |
| popey | m-b-o: you can fiddle with those values, but I'm not sure it will make a lot of difference | 12:07 |
| dpm | popey, thanks for the screenshot, that doesn't look good at all :/ | 12:07 |
| dpm | m-b-o, so I see two issues blocking the convergence landing: http://pastebin.ubuntu.com/6965104/ - would you have any ideas on how to fix or work around them? | 12:16 |
| m-b-o | dpm: don't know. is it a problem or on n7? | 12:18 |
| m-b-o | a problem on the app or on n7 | 12:18 |
| m-b-o | dpm: if there's a general problem with the values on the n7, it doubt, you can easily work aorund, since it's borken | 12:22 |
| m-b-o | dpm: in WeatherTemperatureCCOmponent you should use the n7 treshhold too! | 12:26 |
| m-b-o | dpm: there's distinction viewMode | 12:27 |
| dpm | aha | 12:27 |
| dpm | let me have a look | 12:28 |
| m-b-o | dpm: or setting viewMode in CurrentWeather accordingly | 12:30 |
| dpm | nik90, I can see the new calendar icon after killing Unity 8 -> http://imgur.com/wHmynwZ | 12:30 |
| nik90 | dpm: hmm..I rebooted after every click install | 12:30 |
| dpm | nik90, yeah, that should definitely have restarted unity :) | 12:31 |
| nik90 | :) | 12:32 |
| nik90 | ahayzen: if you have a minute do you mind testing https://code.launchpad.net/~dpm/ubuntu-calendar-app/fixes-1282500/+merge/207400 | 12:33 |
| dpm | nik90, can you see the icon listed if you do an adb shell and then ls /opt/click.ubuntu.com/com.ubuntu.calendar/current ? | 12:33 |
| nik90 | dpm: trying now | 12:33 |
| ahayzen | nik90, just reflashing the device then i'll test :) | 12:33 |
| nik90 | dpm: I see the icon in that folder | 12:34 |
| dpm | nik90, can you try removing the battery and inserting it again as a hardcore reboot? | 12:35 |
| dpm | (just kidding :) | 12:35 |
| nik90 | hehe | 12:35 |
| nik90 | either way I have no idea of how to remove the battery in the LG N4 | 12:35 |
| dpm | m-b-o, I think viewMode is already set up correctly to 0 (phone) for the N7, I can't find a way to tweak that, other than adding a special viewMode for the N7 with dedicated gu sizes, which might be a bit of a hack | 12:43 |
| m-b-o | I have a possible solution for the veetcial center on n7 | 12:43 |
| dpm | m-b-o, cool. However, I'm more worried about the box sizes and the footer, I see those as being the blockers | 12:46 |
| m-b-o | dpm: can you give me treshold for height, too? | 12:46 |
| popey | dpm: i think we need clairty from unity people on exactly what size we expect the ui to be | 12:47 |
| dpm | m-b-o, for the N7 (2013) that'd be 57.14 GU height, I'd take the threshold to be 58-60 to be on the safe side | 12:47 |
| dpm | popey, indeed, I just don't know who the best person to ask is for this one | 12:50 |
| popey | Kaleo & Juoni discussed it yesterday, don't know what the decision was | 12:50 |
| Kaleo | popey, we did not discuss it yesterday :) | 12:51 |
| Kaleo | popey, you discussed with jounih :) | 12:51 |
| popey | heh | 12:51 |
| Kaleo | popey, could not reach jounih from here | 12:51 |
| popey | ok. | 12:51 |
| Kaleo | popey, do you see him btw? | 12:52 |
| popey | can you/he make a decision? | 12:52 |
| Kaleo | popey, he can | 12:52 |
| popey | i am not in the office | 12:52 |
| Kaleo | popey, but I cannot | 12:52 |
| Kaleo | popey, I'll find him | 12:52 |
| m-b-o | dpm: on n4 height is > 58? | 12:53 |
| popey | dpm: anything else need testing on n7 | 12:56 |
| popey | ? | 12:56 |
| m-b-o | dpm https://code.launchpad.net/~martin-borho/ubuntu-weather-app/n7-tweaks perhaps a possible fix for the shapes, when there's a small height | 12:57 |
| dpm | popey, not really, weather is the most pressing one. We need to upload Music, Shorts and Calendar to the store to ensure they don't open in sidestage | 12:57 |
| ahayzen | nik90, calendar patch appears to show the new icon for me | 12:57 |
| nik90 | ahayzen: thnx for the confirmation | 13:00 |
| nik90 | dpm: ^^ | 13:00 |
| ahayzen | nik90, commented on the merge :) | 13:00 |
| dpm | ahayzen, cool, could you top-approve if it works for you? | 13:01 |
| dpm | thanks nik90 | 13:01 |
| dpm | m-b-o, here are the sizes: http://pastebin.ubuntu.com/6965282/ | 13:01 |
| ahayzen | dpm, i can't, don't have permission to tht | 13:01 |
| dpm | popey, can you test this branch on the N7? Otherwise I can send you a click package -> https://code.launchpad.net/~martin-borho/ubuntu-weather-app/n7-tweaks | 13:02 |
| popey | yeah | 13:02 |
| m-b-o | popey: one second please | 13:03 |
| popey | standing by | 13:03 |
| m-b-o | jave another tweak | 13:03 |
| popey | kk | 13:03 |
| ahayzen | dpm, need someone in the 'calendar developers' to top approve | 13:03 |
| popey | I'll get coffee | 13:03 |
| m-b-o | popey: pushed | 13:04 |
| popey | k | 13:04 |
| dpm | thanks m-b-o | 13:04 |
| popey | is that key okay in that branch? | 13:04 |
| dpm | popey, you should add the key to key.js | 13:05 |
| popey | its in the branch | 13:05 |
| m-b-o | nope | 13:05 |
| m-b-o | key misses | 13:05 |
| m-b-o | ouch | 13:05 |
| m-b-o | key inside | 13:06 |
| m-b-o | ... | 13:06 |
| m-b-o | popey I'll remove it, slipped in... sorry | 13:06 |
| popey | np | 13:07 |
| popey | it happens ☻ | 13:07 |
| popey | m-b-o: what version are you running on the nexus 7 2012? Is that trusty? | 13:08 |
| m-b-o | popey r194 | 13:09 |
| m-b-o | popey but no luck with getting intp landscape | 13:09 |
| m-b-o | poepy pushed clean key.js.. | 13:10 |
| dpm | m-b-o, with that branch on the N4, I get a flicker in the animation when displaying the 4 extra data boxes. It seems it's repositioning them vertically after the animation has finished | 13:10 |
| === gatox is now known as gatox_away | ||
| popey | i see that too | 13:13 |
| popey | its like the moving ones overshoot slightly | 13:13 |
| m-b-o | dpm popey is there no way anymore to start the app on dvice from qtcreator? | 13:15 |
| dpm | m-b-o, do a 'wget http://people.canonical.com/~dpm/click/ubuntu-weather-app.desktop' to put a dummy .desktop file on the branch's directory | 13:16 |
| dpm | m-b-o, that should get Ctrl+F12 running again | 13:16 |
| m-b-o | thanks | 13:16 |
| popey | really, we can't just run from qtc? | 13:16 |
| popey | m-b-o: dpm https://www.youtube.com/watch?v=aAGQjYJRJh8 | 13:17 |
| dpm | popey, that's that thread about cmake breakage on the core apps mailing list. I suggest until we have a fix we just commit dummy .desktop files to all apps, otherwise it's a big pain | 13:17 |
| dpm | the size looks now great on the device, it's just the flicker | 13:18 |
| dpm | or jitter, rather | 13:18 |
| m-b-o | dpm: I know where to screw | 13:18 |
| dpm | rock on | 13:18 |
| m-b-o | dpm doesn't work with only addin gthe desktop file :( | 13:21 |
| dpm | m-b-o, oh, it works for me, and it worked for neokore last night. What's the error you're getting? | 13:21 |
| m-b-o | p, li { white-space: pre-wrap; } [14:21:05] sed: can't read /home/phablet/dev_tmp/ubuntu-weather-app/conditional-weather/ubuntu-weather-app.desktop: No such file or directory | 13:22 |
| m-b-o | damn | 13:22 |
| m-b-o | in the wrong branch | 13:22 |
| dpm | ah, ok | 13:22 |
| popey | heh | 13:23 |
| m-b-o | dpm popey having only portait on the n7, it's even more broken | 13:24 |
| dpm | bummer :( | 13:26 |
| dpm | fginther, could we trigger a click package build for Music? | 13:34 |
| m-b-o | dpm popey sorry, I think there's a bug in n7, so trying to work around will disimprove the things on the other devixves | 13:34 |
| m-b-o | devices | 13:34 |
| === _salem is now known as salem_ | ||
| dpm | ok, m-b-o, thanks a lot for all the effort, you guys have been awesome. Let's leave it at here, then. We'll upload the click package with the TWC backend to the store, and then we'll assess if we can use the convergent revision and show only on N10 | 13:37 |
| m-b-o | dpm ok. I'm sorry, but I guess we shold have had more time to get it bullet proofed | 13:43 |
| dpm | m-b-o, no need to be sorry when you guys have been above the call of duty! I wasn't expecting the troubles on the N7, I thought grid units would just work... | 13:43 |
| m-b-o | dpm: ok. I think we have to refactor the whole shapes thing in the next time | 13:46 |
| === gatox_away is now known as gatox | ||
| fginther` | dpm, https://jenkins.qa.ubuntu.com/job/music-app-click/146/ | 14:09 |
| dpm | fginther`, perfect, thanks. Next, can I request rssreader and weather builds? | 14:11 |
| === ken_ is now known as kenvandine | ||
| fginther` | dpm, https://jenkins.qa.ubuntu.com/job/weather-app-click/116/ | 14:45 |
| fginther` | dpm, https://jenkins.qa.ubuntu.com/job/rssreader-app-click/101/ | 14:45 |
| dpm | awesome, thanks fginther` | 14:46 |
| === snwh__ is now known as snwh | ||
| popey | dholbach: beuno click reviewers tools are crashing for me | 15:53 |
| beuno | popey, traceback? | 15:53 |
| popey | http://paste.ubuntu.com/6966104/ | 15:54 |
| popey | I pull from bzr | 15:54 |
| popey | so i guess it's because something has been split out and requires being installed in some python path? | 15:55 |
| beuno | not sure, sounds like something dholbach would break | 15:56 |
| dholbach | beuno, popey: looks like my fix in r148/r149 didn't entirely fix the issue | 15:57 |
| dholbach | popey, it should have no impact on the functionality, although I agree we should fix it | 15:58 |
| dholbach | popey, it basically explodes while cleaning up after the tests are run | 15:58 |
| popey | ah | 15:58 |
| dholbach | I'm going to need some help fixing this | 15:58 |
| dholbach | and I won't have time until next week I think | 15:58 |
| dholbach | https://bugs.launchpad.net/click-reviewers-tools/+bug/1282652 | 15:59 |
| ubot2` | Launchpad bug 1282652 in Canonical Click Reviewers tools "TypeError: 'NoneType' object is not callable" [Undecided,New] | 15:59 |
| dholbach | thanks popey | 15:59 |
| popey | np | 15:59 |
| nik90 | dpm: isn't there anybody with privileges to top-approve https://code.launchpad.net/~dpm/ubuntu-calendar-app/fixes-1282500/+merge/207400 ? | 17:24 |
| dpm | nik90, yes, I didn't top-approve because it's blocked on an eds bug that's making the tests fail | 17:29 |
| renato_ | balloons, ping | 18:13 |
| renato_ | dpm, hi, I am trying to reproduce this bug: https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds/+bug/1282129 | 18:14 |
| ubot2` | Launchpad bug 1282129 in qtorganizer5-eds (Ubuntu) "Clock and calendar tests fail with static void QOrganizerEDSEngine::itemsAsyncListed(ECalComponent*, time_t, time_t, FetchRequestData*) " [High,Triaged] | 18:14 |
| balloons | renato_: :-) sure, I think the new clock has been pushed to the store | 18:16 |
| balloons | it should be in new images, and if you update click apps, you should also get it | 18:17 |
| renato_ | nik90, lets talk here | 18:17 |
| nik90 | renato_: ok | 18:17 |
| renato_ | nik90, as I am saying , the problem is that | 18:17 |
| nik90 | balloons: yes the clock app has been updated | 18:17 |
| renato_ | nik90, balloons, in the clock the alarm api does not filter the events and ask for a undefined date interval | 18:18 |
| renato_ | this cause a lot of events to be returned | 18:18 |
| renato_ | imagine a daily recurrence event | 18:18 |
| renato_ | without a date interval will be infinite | 18:18 |
| nik90 | renato_: yes I have noticed that the console output is a lot during the process | 18:18 |
| renato_ | what I can do until the guys fix the alarm api is return a limited number of events | 18:19 |
| renato_ | for example only the 100 first event | 18:19 |
| popey | beuno: i am trying to download an app to review but it won't let me | 18:19 |
| nik90 | renato_: hmm that might make sense | 18:19 |
| renato_ | but this can cause some problem problems, since I do not have any start date | 18:20 |
| renato_ | since when I will return events? | 18:20 |
| nik90 | renato_: why cant you take the start date as today | 18:21 |
| renato_ | another option is if the developer does not specify any date I will return only the main events without the recurrence ones | 18:21 |
| nik90 | renato_: then the clock app won't list recurrent alarms | 18:22 |
| renato_ | but I am not sure if the alarm will works correct in this way | 18:22 |
| renato_ | nik90, yes | 18:22 |
| nik90 | renato_: that's a serious regression then | 18:22 |
| renato_ | nik90, is not a regression, is a new functionality that the app was not ready for that :D | 18:22 |
| nik90 | lol | 18:23 |
| nik90 | renato_: Isn't it possible to revert the offending patch in EDS until we get a fix in the alarms API? | 18:24 |
| renato_ | nik90, without this patch the recurrence events will not work on calendar | 18:26 |
| balloons | renato_: I'm not so sure calendar works well with the change.. it too seemed to have trouble in tests, but I focused more on clock | 18:26 |
| nik90 | renato_: caught you :P .. so it is a trade of clock app vs calendar app | 18:27 |
| renato_ | balloons, let me try the calendar autopilot tests here | 18:28 |
| === sarnold_ is now known as sarnold | ||
| renato_ | balloons, yes there is no test for recurrence all tests works, but as I told you my calendar is empty, the error should happen after add a recurrence event | 18:30 |
| renato_ | nik90, you can disable the alarms this should make you app works | 18:30 |
| balloons | renato_: are you saying calendar is missing a test for this? if so, let's file a bug and get one added | 18:30 |
| balloons | getting tests is (almost) as simple as saking | 18:31 |
| renato_ | since the alarms does not works with the previous version of eds plugin | 18:31 |
| renato_ | balloons, yes I need a test that reproduce the bug | 18:31 |
| balloons | renato_: https://bugs.launchpad.net/ubuntu-calendar-app/+filebug. I think you understand it best to file, I'll have a look after | 18:32 |
| renato_ | balloons, is the calendar crashing in your device or desktop? | 18:32 |
| balloons | renato_: I'm away @ a sprint, so I'm a bit hampered.. That said, when I first investigated this it worked for me on my desktop | 18:33 |
| renato_ | yeah it depends how many recurrence events do you have | 18:34 |
| balloons | yea, likely I saw it running ok on the images too because this condition wasn't met | 18:35 |
| nik90 | renato_: disabled recurring alarms or the entire alarms feature? | 18:35 |
| renato_ | nik90, the alarms is not working correct? there is not indicator integrations right now | 18:36 |
| renato_ | you can create but you can not use that | 18:36 |
| balloons | so what's the best way to move forward? Reverting is not a simple task, so I assume it's not really an option. Which means we need a fix, and we should talk about workarounds until it lands? | 18:36 |
| nik90 | renato_: charles MP to provide indicator integration is ready. We are just waiting on it to be pushed to the archive | 18:37 |
| nik90 | renato_: this would be a bad time to revert alarms when the indicator support is ready | 18:37 |
| renato_ | nik90, where is that? did you test it? | 18:37 |
| nik90 | renato_: https://code.launchpad.net/~charlesk/indicator-datetime/lp-1233176/+merge/190009 | 18:38 |
| nik90 | renato_: actually it has already beeen merged into trunk | 18:38 |
| renato_ | nik90, this is good, but I am not sure the alarm api is ready for that :D | 18:39 |
| nik90 | renato_: ignore my last 2 statements...I swear I saw his most recent branch which has been reviewed and ready to go | 18:40 |
| nik90 | renato_: I even saw a screenshot of the notification on the device | 18:40 |
| balloons | nik90 dreams vividly | 18:40 |
| nik90 | renato_, balloons: Here you go https://code.launchpad.net/~charlesk/indicator-datetime/alarms/+merge/204420 | 18:41 |
| renato_ | nik90, balloons, ok quick solution, limit the number of events returned by eds when no date interval is passed | 18:41 |
| dpm | ahayzen, around? | 18:41 |
| renato_ | this is a workaround, in my opinion the eds should not return any event if the date interval is invalid | 18:42 |
| renato_ | but since both apps are not using a date interval, we should keep that for a while | 18:43 |
| nik90 | renato_: okay | 18:43 |
| nik90 | renato_: we just need this quick hack for the MWC | 18:43 |
| renato_ | nik90, how to test if this works? | 18:43 |
| renato_ | I am not able to reproduce the bug | 18:43 |
| renato_ | are you? | 18:43 |
| balloons | ^^ we need a test to reproduce | 18:43 |
| nik90 | renato_: we can handle this post MWC properly | 18:44 |
| nik90 | renato_: test what? the notifications? | 18:44 |
| renato_ | nik90, the current bug | 18:44 |
| nik90 | renato_: I cannot test it since I am on 13.10 | 18:44 |
| renato_ | https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds/+bug/1282129 | 18:44 |
| ubot2` | Launchpad bug 1282129 in qtorganizer5-eds (Ubuntu) "Clock and calendar tests fail with static void QOrganizerEDSEngine::itemsAsyncListed(ECalComponent*, time_t, time_t, FetchRequestData*) " [High,Triaged] | 18:44 |
| nik90 | renato_: installing the latest EDS package causes unmet dependencies for me | 18:45 |
| renato_ | nik90, balloons , could you guys test this? https://code.launchpad.net/~renatofilho/qtorganizer5-eds/limit-number-of-events/+merge/207542 | 19:29 |
| renato_ | this will return only events for the current year | 19:30 |
| balloons | renato_: I'll have a look | 19:35 |
| balloons | so i think we simply need a build of qtorganizer5 with this change; we'll install and run | 19:36 |
| renato_ | balloons, yes | 19:37 |
| balloons | clock/calendar tests in theory should run | 19:37 |
| renato_ | balloons, jenkins will build for you | 19:37 |
| balloons | yep, I'll await :-) | 19:37 |
| popey | nice one renato_ | 19:48 |
| fginther | dpm, are you all done with builds for the day? | 20:03 |
| dpm | fginther, we're trying to fix weather for the N7, but we're not making much progress, so we might not be at a point to release a package. Then there's music, which has an issue with its cmake (needs to include the grilo plugin, which it doesn't) and creates a .click that does not work. So depending on how these two go, we might well be done with builds for the day, unfortunately :( | 20:06 |
| fginther | dpm, ack, I wanted to make sure I didn't miss any requests | 20:06 |
| dpm | fginther, thanks for the follow up, you didn't, so far we got all the builds we requested, which is great | 20:07 |
| szymon_w | Hello! I've been playing around with QtMultimedia 5.0 and all works nice when running on desktop but when I try my app on device I can not reverse or rewind. function seek(position) not working on device. here is example code: https://code.launchpad.net/~majster-pl/+junk/audio-bug-example if anyone can help me with this that would be cool :) | 20:33 |
| szymon_w | I have to add that it all works well for Video on device... position can be changed and it all works, but its not the case in Audio component. | 20:34 |
| === fginther` is now known as fginther | ||
| balloons | renato_: jenkins doesn't like your mp.. ping if you get a binary | 21:40 |
| === salem_` is now known as _salem | ||
| renato_ | balloons, we have the debian, https://code.launchpad.net/~renatofilho/qtorganizer5-eds/limit-number-of-events/+merge/207542 | 22:25 |
| balloons | renato_: testing things now on my device | 23:08 |
| balloons | renato_: for clock, the issue of failing tests remains | 23:22 |
| balloons | the output looks the same, I will confirm I'm not crazy | 23:23 |
| balloons | renato_: I'm running ubuntu_clock_app.tests.test_alarm.TestAlarm.test_delete_alarm_must_delete_from_alarm_list | 23:23 |
| === chriadam|away is now known as chriadam | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!