=== _salem is now known as salem_ | ||
=== salem_ is now known as _salem | ||
=== karni-away is now known as karni | ||
karni | dang. some tiles have suspiciously large padding/take a lot of space. (FYI ssweeny, I'm aware of this, just noticed) | 11:03 |
---|---|---|
karni | Saviq: damn. FilterGrid doesn't collapse back when you expand and shrink a category. | 11:13 |
Saviq | karni, it's the damn childrenRect :/ | 11:14 |
karni | yeah. I'm looking into it. It's still there, I was wondering if I touched it. | 11:14 |
Saviq | karni, you didn't in the end | 11:14 |
Saviq | karni, I've a partial fix | 11:14 |
karni | I'm here if you need me. | 11:15 |
karni | everything looks fantastic, but this is UI show stopper | 11:15 |
Saviq | karni, http://paste.ubuntu.com/6975701/ | 11:15 |
Saviq | karni, that has two results: a) everything looks better again, but b) everything goes under section headers | 11:16 |
* karni tries | 11:16 | |
karni | Saviq: I'm afraid your fix breaks at least some layouts. I'll send a screenshot | 11:18 |
Saviq | karni, yeah, I said it's a partial one... | 11:18 |
karni | ah, that's the "under section headers" part | 11:18 |
Saviq | karni, what I don't understand is why we didn't see that before :/ | 11:19 |
karni | Saviq: I agree :/ | 11:19 |
Saviq | something must've changed | 11:19 |
karni | This appeared since yesterday, right? | 11:19 |
karni | I mean, it wasn't there before. Obviously. | 11:20 |
Saviq | karni, I wonder if the gradients cause it... | 11:20 |
karni | also crossed my mind | 11:20 |
* karni tries disabling | 11:20 | |
Saviq | karni, I think I understand what's happening | 11:25 |
Saviq | karni, and think I've a fix | 11:25 |
karni | Saviq: gradients do make stuff worse. if they're not othe root cause themselve. | 11:25 |
Saviq | karni, yes they are | 11:25 |
Saviq | karni, think about it | 11:25 |
karni | then I dropped the ball | 11:25 |
Saviq | karni, no you didn't | 11:25 |
Saviq | karni, it's just something we didn't think of | 11:25 |
Saviq | karni, with childrenRect, the thing grows to accomodate the expanded FilterGrid | 11:26 |
Saviq | karni, but when FilterGrid collapses | 11:26 |
karni | if you think you have a fix, I'll let you focus. please get back to me. | 11:26 |
Saviq | karni, the gradients are still there | 11:26 |
karni | then gradients stay in place? | 11:26 |
karni | meeeeh | 11:26 |
karni | of course.. | 11:26 |
Saviq | and childrenRect does not go back | 11:26 |
karni | Saviq: you're definitely right | 11:26 |
Saviq | karni, should be enough to move the gradients inside the Loader | 11:26 |
karni | still, I dropped the ball there. | 11:26 |
karni | Saviq: want me to do that? | 11:26 |
Saviq | karni, doing | 11:27 |
karni | ack | 11:27 |
karni | consider pushing that to lp:~unity-team/unity8/unity8-category-gradients so we don't let that MP regress later | 11:28 |
Saviq | karni, try http://paste.ubuntu.com/6975767/ | 11:32 |
karni | ack | 11:32 |
karni | download as text -> sign in. this is rubbish | 11:33 |
Saviq | karni, copy/paste | 11:33 |
Saviq | karni, https://bugs.launchpad.net/ubuntu-website-content/+bug/784485 | 11:33 |
ubot5 | Launchpad bug 784485 in ubuntu-website-content "Ubuntu pastebin requires Launchpad credentials for getting the plaintext version of a paste" [Undecided,Won't fix] | 11:33 |
karni | Saviq: :D | 11:33 |
karni | nah, signed in. but thanks for the bug haha | 11:33 |
Saviq | karni, it's because of abuse | 11:34 |
karni | hrm | 11:34 |
karni | Saviq: +1 | 11:35 |
karni | Saviq: Is it just me, or the carousel has quite large padding at the top? This might not be related, though | 11:36 |
* karni pushes to phone and tries there, too, just double checking | 11:36 | |
Saviq | karni, it's even more visible on tablet, I'll do testing there, too | 11:36 |
Saviq | karni, please push to your branch yourself | 11:37 |
karni | ok | 11:37 |
Saviq | karni, but actually let me have a quick look still | 11:37 |
karni | sure, take your time | 11:37 |
Saviq | karni, index is reaching out of scope | 11:37 |
karni | Saviq: your fix works well. the only (possibly unrelated) thing I noticed is large top/bottom carousel padding. everything else looks great overall. | 11:39 |
Saviq | karni, yeah unrelated | 11:39 |
Saviq | karni, to fix in Carousel.qml most probably | 11:39 |
Saviq | karni, http://paste.ubuntu.com/6975798/ | 11:44 |
karni | ack, will test | 11:45 |
karni | unnecessarily I pushed the other fix like 5 seconds ago, I'll overwrite, so ignore that | 11:45 |
Saviq | karni, k | 11:46 |
Saviq | karni, so yeah, if ok, push to your branch and I'll merge that again | 11:49 |
karni | Saviq: tested, pushed. https://code.launchpad.net/~unity-team/unity8/unity8-category-gradients/+merge/207718 | 11:49 |
* Saviq remembers to think/talk to folks about childrenRect | 11:49 | |
karni | I've learned my lession, one has to be careful with childrenRect | 11:50 |
karni | ssweeny: The problem I mentioned above has been fixed. | 11:51 |
Saviq | karni, /me too, don't worry, I saw that yesterday night and tried to fix, but sleeping apparently helps | 11:52 |
karni | oh yes, gotta sleep to think clearly | 11:52 |
Saviq | now, if only LP wouldn't timeout 99% of the time on recipes ;( | 11:53 |
karni | gaaaah I have that | 11:53 |
Saviq | and apparently there's some quota I'm going over ¿?¿?¿?¿?¿?¿?¿? | 11:54 |
karni | ????????? | 11:54 |
Saviq | ok, kicked | 11:54 |
karni | \m/ | 11:54 |
* Saviq thinks that's all fires extinguished, will try to look at the disproportioned recent apps later | 12:08 | |
karni | \o/ | 12:12 |
* karni noticed small visual stutter when switching screens/scopes/swipe left|right, after opening i.e. grooveshark scope from Scopes scope. | 14:06 | |
karni | if you swipe left/right after rebooting the phone, there's no stutter, all's fluent. when you open a scope from scopes scope (I tested with Grooveshark), go back, and then switch screens/scopes, there's small sutter around the middle phrase of the screen switch. | 14:07 |
* karni afk | 14:07 | |
=== balloons_ is now known as balloons | ||
=== Pici` is now known as Guest7580 | ||
=== Cimi_ is now known as Cimi | ||
=== Debolaz is now known as Guest7218 | ||
=== kklimonda is now known as Guest77944 | ||
=== fginther` is now known as fginther | ||
=== redj is now known as 6JTABBIDI | ||
=== Debolaz is now known as Guest8598 | ||
=== jasoncwarner___ is now known as jasoncwarner__ | ||
=== Debolaz is now known as Guest66097 | ||
=== rpadovani is now known as WebbyIT | ||
=== shiznix is now known as Guest47244 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!