=== duflu_ is now known as duflu === Zachary_DuBois|A is now known as Zachary_DuBois === Zachary_DuBois is now known as Zachary_DuBois|A === thumper is now known as thumper-afk [07:01] Good morning [07:06] hi pitti! [07:06] happy Monday [07:06] hey larsu, wie gehts? Dir auch! [07:06] * pitti tries to readjust to CET [07:07] sehr gut danke :) [07:07] how was your sprint? [07:07] larsu: long and intense, but I really enjoyed it [07:07] the way sprints are supposed to be ;) [07:08] working with jibel to solve a lot of autopkgtest issues, and with thomi to figure out the py3 test migration, and others [07:10] larsu: jibel and I were actually sprinting in the morning, to Lake Merritt :) [07:11] pitti: nice! I did that last time I was there as well. It's quite nice there [07:11] larsu: yes, I still remember your "running barefeet" attempt :) [07:11] that was before [07:11] last time I had shoes ;) [07:12] imagine that! [07:12] (still only 3mm soles though) [07:12] yeah, me too, my Vibram five-fingers [07:12] but with them it's excellent [07:12] I didn't see any glass splinters or similar anywhere, it's fairly clean [07:13] did you go around the lake? [07:13] no, we didn't have enough time for that, we started at 8 already [07:14] crazy! [07:19] larsu: did you ever go around? it looks like a total of 8 to 10 km [07:19] we usually ran about 30 to 40 mins, up to ~ 6 km [07:21] pitti: I did, but didn't plan to (it was just very nice weather that morning and I had time) [07:22] but yeah, 10k is a bit much for a morning run :) === e11bits_ is now known as e11bits [09:00] good morning desktopers, happy monday! [09:01] bonjour seb128, hereux lundi ! [09:01] pitti, salut, ça va ? bien rentré ? [09:01] seb128: oui, le voyage était bien [09:02] seb128: still feeling a bit zombie-like today, though :) [09:02] jetlag for the loose [09:02] morning! [09:02] how was the QA week otherwise? [09:02] Laney, hey, how are you?* [09:02] seb128: well, not that bad this time; I didn't get a cold, that makes it much easier to bear [09:02] hey Laney, how are you? [09:03] good [09:03] seb128: intense, but productive; I really enjoyed being able to work hand in hand with jibel to fix a lot of britney/autopkgtest things, and with thomi to further the py3 test story [09:03] hey seb128 & pitti [09:04] i'm good thanks, fun weekend beer festivalling [09:05] they were selling off cheap pies at the end which we ended up sharing with drunk people on the train back [09:05] was funny [09:05] nice [09:05] hah [09:06] did you have some nice weather for the festival? [09:09] hum, u-c-c is blocked in trusty-proposed because indicator-sound is not available on all archs [09:09] * seb128 demotes that depends to a recommends [09:09] yeah, but it was inside anyway (mostly) [09:09] I start thinking we should put that gsettings key in the shared schemas rather than indicator-sound [09:11] seb128: I agree [09:11] robert_ancell seems to dislike putting the key in indicatr-sound as well [09:11] (judging by his comment on yesterday's MR) [09:12] what mr? [09:12] * seb128 didn't see that one [09:12] oh, your fix scaling [09:12] no :p [09:13] nice done on that one btw, thanks for fixing it ;-) [09:13] did you figure out how you ended up on a different version of the code? [09:14] seb128: I meant the one for u-s-d [09:14] seb128: no, I didn't figure that out - but fixing it this way was easier than rebasing (which I tried before and was a mess) [09:15] larsu, I just saw that, stop working during W.E! ;-) [09:15] https://code.launchpad.net/~larsu/unity-settings-daemon/support-allow-amplified-volume/+merge/207838/comments/487783 [09:16] yeah, I just saw that [09:16] seb128: I had kind of a late start on Friday and even though I worked later, too, I was missing some hours [09:16] so yesterday I thought I might as well do it now :) [09:16] larsu, ok, your call, just saying ;-) [09:17] (I did some hacking as well to be honest, I looked at the users panel history issue yesterday evening :p) [09:17] ts ts [09:17] ;-) [09:17] larsu, I found new bugs for you btw! [09:17] :'( [09:17] but I'm not going to distract your from nautilus yet [09:17] btw how reasonable does nautilus/menu look like? [09:17] did you have time to look properly at it yet? [09:18] yes, and I have half a patch already [09:18] it seems very doable, but ask me again in a couple of hours [09:18] ok [09:19] building gnome apps is a huge warning-fest these days [09:19] larsu, just for the record the other bugs I have for you are file-roller only starting one instance (e.g you can't open 2 archives from nautilus), seems like GTKish [09:19] thanks to all the deprecations [09:19] larsu, the other one is evince missing its context menu, which I guess has to do with your menu work [09:19] yeah :/ [09:21] seb128: noted. [09:21] hm, context menus work on links and such [09:21] but are empty everywhere else [09:21] same here [09:21] are you sure they worked before? [09:21] hm, probably... I'll investigate later [09:29] larsu, yeah, just downgraded to the version before the gmenu patch, the context menu has preview/next/refresh/... items [09:29] larsu, but yeah, no hurry, nautilus first, then bugfixes ;-) [09:36] Laney, can you try the update on lp:~seb128/unity-control-center/users-backport-commits and tell me if you get a proper history? [09:37] yep, give me a minute to send this email [09:38] sure, thanks [09:47] Laney, shrug I had a typo, if you already pulled please do it again, I've added an extra revision [09:47] didn't yet [09:47] good [10:18] seb128: yay, looks good now [10:19] Laney, \o/ [10:19] be nice to send that upstream [10:20] right, I'm going to do that [10:20] though https://bugzilla.gnome.org/show_bug.cgi?id=692253 suggest they would prefer to have lightdm changed [10:20] Gnome bug 692253 in User Accounts "user-accounts: empty login history window" [Normal,Resolved: fixed] [10:20] I emailed robert_ancell about that, he replied [10:20] "I have no idea about wtmp. I couldn't find any real spec for it." [10:21] heh [10:21] let's see if they are any details on why they don't like "pts" if they don't [11:02] Laney doesn't like hacks/workarounds :p [11:03] Laney, would you prefer if I build-depends on indicator-sound to make it depwait on those archs? [11:07] that wouldn't fix the migration problem [11:07] then you'd get out-of-date [11:08] I would /maybe/ be okay if you arch-qualify the dependency, if it's for a realllllly short amount of time [11:09] oh, just saw the mail - if you're fixing it today anyway then why not just do it like that the first time? === alan_g_ is now known as alan_g [11:20] shrug, wifi stopped transferring again and I didn't notice before IRC timeout [11:21] Laney, not sure if my reply went through, I basically didn't want to mix landing of the fixes and of the schemas transition, but I'm going to reverse the order and start with the schemas [11:21] nope, didn't get any message from you [11:22] Laney, https://bugzilla.gnome.org/show_bug.cgi?id=725053 btw [11:22] Gnome bug 725053 in User Accounts "History login empty on Ubuntu (doesn't list "pts" type sessions)" [Normal,New] === davmor2_ is now known as davmor2 [11:22] seb128: nice, thanks === Sweetsha1k is now known as Sweetshark [11:28] Laney, do you feel like audio is part of "user-interface", or do we need a new schemas? [11:29] let's do a "com.ubuntu.sound" [11:30] I don't have a very good intuition for schema layouts [11:30] GNOME has a "sound", doing the same [11:30] we'll have the 'touch' versions too [11:30] grr [11:30] those are going to be deprecated though? [11:31] that'd be nice [11:31] oh, you mean the sound ones specifically [11:31] yes [11:31] right === MacSlow is now known as MacSlow|lunch [12:02] Laney, larsu: https://code.launchpad.net/~seb128/gsettings-ubuntu-touch-schemas/shared-sound-setting/+merge/207900 [12:02] https://code.launchpad.net/~seb128/unity-control-center/rename-sound-key/+merge/207905 [12:02] https://code.launchpad.net/~seb128/indicator-sound/use-shared-key/+merge/207909 [12:03] Laney, I didn't add packaging transition for the key move since u-c-c had a version using the key out of trusty-proposed [12:03] u-c-c *never* had* [12:04] why would you need that? [12:04] some transition? [12:04] because I dropped the key for indicator-sound [12:04] seb128: awesome, thanks! [12:04] so if u-c-c had been using it and you updated the indicator u-c-c wouldn't be happy [12:05] larsu, please update your u-s-d branche to depends on "gsettings-ubuntu-schemas (>= 0.0.1+14.04.20140224)," [12:05] oh like a Breaks [12:05] rather than indicator-sound [12:05] seems okay to me [12:05] Laney, right [12:05] you added a blank line in POTFILES.skip :P [12:05] Laney, shrug, blame my editor [12:06] :p [12:06] will do [12:06] danke [12:07] should I wait to top-approve i-sound until gsettings-ubuntu-touch lands? [12:07] *-schemas [12:07] it should be silo'd in together [12:08] so doesn't matter [12:08] what Laney says [12:08] I'm going to put those 3 in a silo (once you acked them) [12:09] chrisccoulson: hey, are there plans to merge enigmail from debian at some point? [12:10] what's the best way to see what keeps something in main? [12:10] sorry, was meant for -devel [12:10] (re-asking there) [12:12] seb128: hm, u-s-d doesn't have auto-landing? [12:12] I guess I can just reuse the MR from yesterday [12:12] larsu, no, it's under CI train, the lander just need to list vcses [12:13] larsu, yeah, just do another commit in the branch robert_ancell approved [12:13] I'm going to land it later [12:13] * larsu is totally confused by the new process [12:13] mostly because I didn't really look into it yet [12:14] larsu, basically things stopped being merged to trunk automatically [12:14] larsu, the "lander" needs to list the merge requests that he/she wants to land, the system give you a ppa with that set (to test), then you press buttons for distro upload and once it's in distro it's merged back to trunk [12:15] it just puts the distro/product upfront [12:19] seb128: thanks :) [12:19] that sounds like a good system actually [12:20] it's quite nice indeed [12:20] especially getting a ppa with all your changes [12:20] ya [12:20] like in that case I get all 3 sources, so I can test a real dist-upgrade [12:21] MR is updated [12:22] danke [12:23] Laney, btw, I looked at doing proper commit backports for u-c-c, turns out bzr doesn't do real cherry-picks, it basically commit the diff of the change you merge [12:23] yep [12:24] so I can as well keep doing it the way I was doing it, copying diffs from the webui, it's more efficient :p [12:24] you could use git-bzr to do nice cherry-picks :-) [12:25] haha [12:25] Laney: we're getting the new gtk sooner than you convince seb128 to use git :P [12:25] I guess I could, or at least I should look at that when things are more quiet [12:25] for now I'm sticking to my efficient workflow :p [12:25] larsu, lol === alan_g is now known as alan_g|lunch === Trevinho__ is now known as Trevinho === MacSlow|lunch is now known as MacSlow [13:04] what do i need to do to make print-screen button work with unity-*-* ? [13:04] well, it works as an audio bell at the moment =) [13:06] are you *running* the latest unity-settings-daemon? [13:16] Laney: you sound like apport "Unreportable error due to out of date packages" [13:16] Laney: let's say i did reboot my machine in a week =) [13:17] we uploaded a new one which fixed print screen being broken on friday (I think) [13:17] (correct) [13:19] xnox: unity-settings-daemon --replace [13:20] Laney: hm, restart unity-settings-deamon would not work? [13:20] that's what the command he gave is doing? [13:20] (note that some apps don't pick up the correct theme again when you do that) [13:20] seb128: yeah, xchat went all window95 on me =) [13:21] right, xchat-gnome does the same [13:21] however printscreen did work =) [13:21] ;-) [13:21] note that next time the key doesn't work, you can run gnome-screenshot from the dash [13:21] it has an UI that let you capture the active win/screen/selection/after timeout [13:22] mmm, I've not restarted u-s-d like that before [13:22] try it [13:22] it's nothing with the way it restarts [13:22] it's just that some apps don't seem to pick up again theme, same thing happen in g-s-d segfaults and respawn [13:24] wasn't talking about that issue [13:24] oh ok === mhall119_ is now known as mhall119 [13:29] Laney: restart unity-settings-daemon, mostly worked. [13:29] I was scared it would restart some other things, but I haven't actually checked if that is true [13:35] Laney: but since "stopped" is not emitted nothing should be torn-down, and some things might see "started" again, but that will not launch/relauch things that are already running anyway. [13:37] larsu: but it means you know how to launch a session upstart job with an env variable, right? :) [13:37] didrocks, larsu and upstart? you must be confused :p [13:37] hahahahah [13:37] no, I don't [13:37] it's like me and git [13:37] :p [13:37] didrocks: but aren't they already doing that with current unity8? [13:37] seb128: "launch a session upstart job with an env variable", I didn't see any larsu there :p [13:37] larsu: no, there is no env variable for that [13:38] seb128: do you have a phone which isn't fully updated? [13:38] Laney, I probably do, I updated on friday morning and follow the proposed channel [13:39] Laney, why? [13:39] willing to test the updates panel fix? [13:39] I want to add https://code.launchpad.net/~diegosarmentero/ubuntu-system-settings/concurrent-check/+merge/207525 to it [13:39] but I just updated [13:39] sure [13:39] for me it downloaded and prompted me to install [13:39] but in the updates panel it span "Checking for updates" the whole time [13:39] instead of showing the progress [13:40] I'm wondering if this branch would fix that [13:40] weird [13:40] what should I test exactly? [13:40] stock image + what? [13:40] wait until I get this approved / reconfigured / built === BigW is now known as BigWhale [13:41] then add the PPA for the landing, upgrade to it, go into u-s-s, wait for "updates available" to show, click it and see if you see the download's progress and/or get prompted to install the update [13:41] you need to be on automatically download on wifi [13:42] ok [13:42] just give me a ping with what you need to be tested, I'm keeping outdated until then [13:43] if not, well, it didn't give me a corrupt download so it's way less broken than it was already [13:43] would just be nice for the ui to work properly too [13:44] k [13:47] Laney: sorry for the (probably silly) question, but you mentioned that light-locker-settings had been uploaded, still i can't find it in the trusty repos (https://bugs.launchpad.net/light-locker-settings/+bug/1281536) [13:47] Launchpad bug 1281536 in light-locker-settings "[needs-packaging] light-locker-settings" [Wishlist,Fix committed] [13:47] ochosi: https://launchpad.net/ubuntu/trusty/+queue [13:47] it needs to be reviewed by an archive administrator [13:47] oh [13:47] thanks! [13:47] * ochosi bookmarks the page === e11bits_ is now known as e11bits === attente_ is now known as attente === alan_g_ is now known as alan_g [14:02] mpt, hey, could you review/comment on https://bugs.launchpad.net/ubuntu/+source/unity-control-center/+bug/1283150? (it's a string suggestion) [14:02] Launchpad bug 1283150 in unity-control-center (Ubuntu) "Missing article in the new LIM option dialog" [Low,Triaged] [14:05] bregma, since when do we have a "no commit without bug reference" for unity? [14:06] seb128, since I have to personally manually approve every single commit that goes in [14:07] seb128: http://162.213.34.102/job/landing-010-1-build/18/console when you get the new u-s-s, please try ^^^ steps [14:07] * Laney lunches [14:07] bregma, hum, k, I've the feeling that's not a discussion I wanted to have ... happy monday anyway then ;-) [14:08] Laney, what should I try exactly? install that ppa and then try to update through system settings with wifi autodownload on? [14:08] seb128, there's a bug that needs fixing, there's a MP that fixes it, what's wrong with requiring we be able to track work and make sure effort is not duplicated? [14:11] bregma, nothing, I just don't like strict rules like that because it goes in the way of easy "just send a patch". If we have a bug about the issue we should link to the commit indeed ;-) [14:13] bregma, btw what is blocking landing/enabling the hi-dpi work? [14:13] * seb128 has been watching the silos/CI train for an unity entry since friday === mjohnson15_2 is now known as mjohnson15 [14:19] Laney, ^ same question here :) [14:20] (when you get back) :) [14:20] same question being [14:20] Laney, i compile system settings and run it on my desktop but its not showing any panels in it. what am i doing wrong ? [14:20] om26er, how did you build it? === psivaa is now known as psivaa-afk-bbl [14:21] seb128, mkdir 'build' outside of u-s-s source, and then in that build dir, cmake ../ubuntu-system-settings;make -j4 [14:23] om26er, that doesn't work [14:24] seb128, do i need to specify some panel path ? [14:24] let me check, I usually bzr bd [14:27] om26er, it's looking into ${CMAKE_INSTALL_PREFIX}/share/ubuntu/settings/system for the .settings [14:27] om26er, you need to define CMAKE_INSTALL_PREFIX I guess then [14:27] e.g "cmake .. -DCMAKE_INSTALL_PREFIX=/usr" [14:28] seb128, and I would have to point that to the local dir, i would assume [14:29] om26er, if you plan to add panels, otherwise getting the list from the system is probably good enoguh [14:29] but we don't really support loading local panels (yeah, that's suboptimal), we usually test by copying over the system .so [14:30] seb128, i am actually changing the autopilot tests to load everything from local dir if i am running tests locally and only use anything from the system if tests are running from outside of the source [14:30] there can be cases where ubuntu-system-settings is not installed on the system [14:31] good luck, we would welcome patches to load local plugins for sure [14:31] but we don't have support in our cmake/plugin loader for that atm [14:31] seb128, i would like to learn cmake better, so that's my chance there ;) [14:32] seems so ;-) === alan_g is now known as alan_g|vt [14:35] seb128: Bon jour! [14:35] GunnarHj, hey, how are you? [14:36] seb128: I'm fine, thanks. Hope you are as well. [14:36] seb128: We are talking on bug #1164252 about seeding a few IM engines. The question is what would be possible considering the ISO size restrictions. [14:36] Launchpad bug 1164252 in ubuntu-meta (Ubuntu) "Improve default selection of IBus related packages" [Low,In progress] https://launchpad.net/bugs/1164252 [14:41] GunnarHj, I'm good thanks [14:41] GunnarHj, can't we just make language-selector install those where it makes sense? [14:42] seb128: That's basically how it's done already. The point with seeding a few engines for a few big languages would be to make it possible to input 'funny characters' without installing respective language. A matter of convenience. [14:44] you are also going to miss e.g fonts for that no? [14:44] I think that if you want to type into e.g Japanese, you should install the language support for it [14:44] seb128: Fons are already seeded. [14:44] fonts [14:44] k [14:45] well, same issue as always [14:45] seb128: Guess so. ;-) [14:45] we could pre-install everything in the archive in case somebody needs it [14:45] but then you have big images and that has a cost on infra, download time, install time, etc [14:46] not easy to make the cut on what is really useful or not [14:46] you should maybe email ubuntu-devel@ about thaty [14:46] seb128: Ok, I can do that, so we get input from a few others. [14:46] right [14:47] but things like [14:47] "ibus-sunpinyin [14:47] - pulls: libglade2-0 libsunpinyin3 python-glade2 sunpinyin-data [14:47] - would need 25.5 MB" [14:47] that seems a no go to me [14:47] we don't want old unmaintained libs back on the iso [14:47] 25MB is too much overhead as well [14:47] the other ones seems more reasonable [14:48] seb128: OTOH, ibus-sunpinyin seems to be one of the most desired (according to happyaron and damage3025). [14:49] seb128: FWIW, I digged out openoffice.org-dictionaries (which are still at the state of go-oo 3.3) and updated them to libreoffice-dictionaries on libreoffice 4.2.1. Also killed dpatch, bumped dephelper and standards-version and made lintian happy. Would you review that? Its currently in a git repo as I hope Rene will take that to debian (after removing the slight ubuntufication). [14:49] Sweetshark, I can review that, probably tomorrow rather than today though [14:49] Sweetshark, can you drop me an email as reminder? [14:50] seb128: sure, that was kinda the timeline I was looking for ;) [14:50] Sweetshark, I still have nlpsolver on my list as well (just letting you know I didn't forget about it;-) === vrruiz_ is now known as rvr [15:01] seb128, any idea what's causing this? seems like a recent trusty change (bug 1278062) [15:01] Launchpad bug 1278062 in firefox (Ubuntu) "firefox crashes on startup (but apparently layunched properly to enable me to post this)" [Medium,Confirmed] https://launchpad.net/bugs/1278062 [15:02] chrisccoulson, hey [15:02] chrisccoulson, no, is that a one user thing? we didn't change gtk+2 recently... [15:03] seb128, no, there's quite a few [15:03] weird [15:03] buggy theme? [15:05] what should I try exactly> [15:05] 24/02 13:40:32 wait until I get this approved / reconfigured / built [15:05] 24/02 13:41:10 then add the PPA for the landing, upgrade to it, go into u-s-s, wait for "updates available" to show, click it and see if you see the download's progress and/or get prompted to install the update [15:05] 24/02 13:41:21 you need to be on automatically download on wifi [15:07] Laney, right, testing that in a bit [15:07] merci [15:07] de rien [15:10] hello :) [15:10] 1 question: I'd like to be sure that I have deleted all the cached gsettings (to have the default values) [15:11] which directories do I have to check? [15:11] .config/dconf/user i think [15:13] I ve tried this mmm yes but maybe I re-set some accidentally :p [15:13] thank you attente :) [15:13] hikiko, just "gsettings reset "? [15:13] :D [15:14] thanks seb128 [15:14] yw [15:14] or what seb128 said :P === alan_g|vt is now known as alan_g|tea [15:33] Laney, I get a "checking for update" that never stops spinning (or it's very slow to check) [15:33] same [15:33] so it didn't fix that [15:33] wait a bit and see if you get the popover to actually install the update [15:33] don't let the screen blank in case that bug still exists === alan_g|tea is now known as alan_g [15:35] it seems to be download, seeing the latency increase on my IRC [15:35] downloading even [15:37] ya [15:37] not sure if we should have this fixed before landing stuff? [15:37] yeah, trying to :p [15:37] does Diego irc? [15:39] shrug, I wonder what it's doing, the update shouldn't be that much data!? [15:39] is that a regression? [15:40] mine was 230M or so [15:40] he's "gatox" [15:41] Laney, ok, got the popover "install&restart" screen [15:41] what do you want me to do from there? [15:41] decline so I keep in a state where I can test new changes? [15:41] though I guess they are going to keep generating images, we should have a newer one with small delta soon [15:41] (wth with the lag?) [15:42] yeah [15:42] gatox: hey ;-) [15:42] Laney, I think I should be over the lag [15:42] second..... meeting [15:42] Can you read the previous few minutes ↑? [15:42] There's a problem with the update panel in system-settings if you enter it while a download is already in progress [15:43] it spins 'checking for updates' and doesn't clear that [15:43] seb128: you need some QoS man [15:43] it's never an issue on my laptop with dist-upgrade, I don't know how the phone download manage to DoS [15:43] one big thing vs many smaller ones I guess [15:43] I wonder if they do uploads as well, that's usually what creates latency for me [15:43] able to saturate your connection more [15:44] likely [15:44] so, should I apply the update? [15:44] ogra, didrocks: when are you guys rolling a new image? ;-) [15:45] lemme see if I can get this with --testing=update-manual-success [15:45] seb128, latest at 3am UTC [15:45] seb128, we have issues that we need to identify first [15:45] ok [15:45] (android 4.4 switch was on the weekend) [15:45] let me decly that upgrade then [15:45] decline even [15:46] I need to be outdated to be able to test the upgrade panel [15:46] ogra, thanks [15:46] seb128, I didn't manage to reproduce this bug: #1283297 but from what I see in the backlog, his key (monitor_name) was empty, so I've fixed the race condition where we have an empty monitor_name, so, if you have a moment, could you verify that you don't get a seg fault before I do the MP? [15:46] Launchpad bug 1283297 in unity-control-center (Ubuntu) "unity-control-center crashed with SIGSEGV in g_variant_lookup_value()" [High,New] https://launchpad.net/bugs/1283297 [15:46] :) [15:48] hikiko, ok, testing that in a bit === psivaa-afk-bbl is now known as psivaa [15:50] thanks a lot seb128 === charles_ is now known as charles [16:00] Laney, seb128 i'm back.... which seems to be the problem with updates?? i didn't follow [16:02] gatox, if you have "download auto on wifi" and do "system-settings -> wait to see the banner with update available -> click on it", the updates panel has the "check fo update with spinner" displayed for the whole download time [16:03] seb128, can you file a bug and assign that to me? I'll try to take a look at that today or tomorrow [16:03] Laney, ^ do we have one already? [16:05] No, because it's caught up with all the stuff being tested for the other updates problem [16:12] seb128: Hopefully some CJK users add their views on the list. I'm just a 'middle man'. ;-) [16:13] GunnarHj, yeah, let's see [16:13] GunnarHj, thanks for stepping up for those users ;-) [16:14] seb128: No problem. I tend to jump at everything i18n... [16:19] gatox: I'm thinking we should hold back on releasing this batch of updates (re-enabling the main screen check) until this problem is fixed [16:22] Laney, the "displays spinner rather than the download bar" is a regression from the silo? in which case, yes please [16:22] yeah [16:22] like it's better than it was when we had the first bug [16:22] but worse than just not having the two checks [16:38] hikiko, the commit looks fine, why did you move the adj line though? also please use g_warning() rather than fprintf(stderr...) [16:39] ok :) [16:39] which adj line? [16:39] I guess accidentally [16:39] * desrt raises an eyebrow [16:39] I'll put it back [16:39] hikiko, http://bazaar.launchpad.net/~hikiko/unity-control-center/unity-control-center.race-cond-empty-monitor-name/revision/12728 [16:39] it just seems and unecessary change [16:39] thanks [16:39] I wanted to move it [16:39] desrt, good morning, how are you? [16:40] because it's C and you have to put the decl on top [16:40] seb128: good. just wondering what gvariant abuse is going on today :) [16:40] but forgot to paste the line :s [16:40] fail :/// [16:40] oh no, it's not a fail I moved it [16:40] desrt, haha [16:40] seb128, it's just 2 lines above [16:41] hikiko, right, I was just wondering "why" you moved it ... the declaration makes sense ;-) [16:41] hikiko, so please change the fprintf to a g_warning (no need of the "\n" in the string) [16:41] hikiko, looks fine to submit then ;-) [16:42] yes I ll push that and do an mp in a moment thanks a lot for the review :) [16:42] thanks for the work [16:42] hikiko: did you know of https://developer.gnome.org/glib/unstable/glib-GVariant.html#g-variant-dict-init ? [16:42] it seems a bit weird that we get a null monitor in some cases, but that's not your fault [16:43] this is in the distro at this point, so usable for this release, i think... [16:43] indeed [16:47] http://bazaar.launchpad.net/~unity-control-center-team/unity-control-center/trunk/view/head:/panels/display/cc-display-panel.c#L566 is a bit scary :) [16:48] another fprintf(stderr, ...) there as well -- but that one should just be removed entirely. it's not possible for str to be NULL there. [16:49] Sweetshark, hi, https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1200277 [16:49] Launchpad bug 1200277 in libreoffice (Ubuntu) "[LibreOffice] - libreoffice-writer.desktop when drag/drop to desktop, 100% broken. " [Low,Confirmed] [16:49] what is the probability of including this fix in precise [16:55] this function also calls malloc() instead of g_new() and then leaks the result [16:56] seb128, [17:04] hikiko: did you write the add_dict_entry() stuff? [17:04] http://paste.fedoraproject.org/79876/61464139/ should do the same, a lot easier [17:06] also: it's better to use g_settings_get_value() and g_settings_set_value() instead of the varargs API when dealing with a GVariant* [17:07] gatox: https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1284217 --- will you have time to work on this quite soon? [17:07] Launchpad bug 1284217 in ubuntu-system-settings (Ubuntu) "[updates] Displays a spinner indefinitely when an update download was started externally" [Critical,Triaged] [17:09] Laney, could you add a screenshot, so i'm sure i understood that correctly? [17:09] Not really, but imagine a spinner that says "Checking for updates" [17:10] Tell me what you don't think is clear and I will see if I can improve it [17:11] yes [17:11] yes desrt [17:12] hikiko: it takes a bit of time to 'get used to' gvariant :) [17:12] true :) I didn't know there's such a tool (GVariantBuilder) [17:12] in general i recommend using the iter/builder interfaces where possible -- they make things a lot easier [17:12] I was not familiar with gvariants desrt and since the iterator was very well documented I used that [17:12] I'll have these in mind [17:13] hikiko: the code i pasted should work as a drop-in replacement for the add_dict_entry() you had before but i didn't test it or anything [17:13] hikiko, let's maybe land the fix and default position on the slider in that mp and do another one tomorrow for cleaning the code a bit/addressing desrt's comments? [17:13] should I change it in the unity-control-center desrt ? [17:13] who killed freenode? [17:13] hikiko: i think seb has the right idea... [17:14] Laney, ah, i understand the problem now.... to be honest, i think i can start working on that maybe on thursday, but probably not before [17:14] hikiko: there are memory leaks and unnecessary checks in the old code (gvariant and gsettings are both quite strict about things never being NULL, so these checks are not necessary)... but this can wait until tomorrow [17:15] desrt, thanks for the review btw ;-) [17:15] desrt, did you see my ping for the one from attente btw? === seb128_ is now known as seb128 [17:15] seems like there was a split [17:15] not sure what went through [17:15] sure desrt and seb128_ [17:16] hikiko, thanks [17:16] thanks for the reviews/help :) [17:16] seb128: i think i reviewed the attente one already? [17:16] unless there is a new one [17:16] hikiko: np :) [17:17] desrt, that one is the mnemonic for u-g-m, I don't see a comment from you on https://code.launchpad.net/~attente/unity-gtk-module/gtk-enable-mnemonics/+merge/207752 [17:17] seb128: indeed i didn't see this one [17:17] k [17:17] it would be nice if you could review it [17:18] no hurry, that doesn't need to be today [17:18] i already don't like it :p [17:18] haha [17:18] attente, hide from desrt :p [17:18] + gulong settings_notify_handler_id; [17:18] 'oh my....' [17:18] lol [17:18] this is a double whammy [17:18] first of all... handler IDs are not cool... second of all... you're trying to dynamically deal with this being changed at runtime.... that should be fun :) [17:18] * desrt digs in for a fun review [17:19] have a good evening everyone :) [17:31] bah, I can't reproduce that bug on the desktop [17:32] Laney, the system-update one? [17:32] ya [17:32] attente: commented. [17:32] :-( [17:33] testing=update-auto-success actually does a long running download [17:33] desrt, thanks [17:36] ok, time to get ready for sport, have a good evening everyone! [17:37] seb128: did you join a curling club? [17:37] 3GRR [17:37] desrt, lol, no, I'm not sure we have any of those ;-) [17:37] "just" tennis so far, that's enough for me [17:37] it works on the phone with --testing too [17:37] seb128: oh. what sport then? ;) [17:37] indoors, i hope :) [17:37] desrt, ^ [17:37] yeah [17:37] they have indoor and outdoor [17:38] we play indoor during winter [17:38] (even when used for actual sports, this sentence sounds weird) :) [17:38] on that note, time to pack my stuff and go,see you tomorrow [17:39] enjoy :) === alan_g is now known as alan_g|EOD === gatox is now known as gatox_lunch === gatox_lunch is now known as gatox === CardinalFang is now known as qengho [20:19] Laney, I finally got around to looking at your as-ringtone branch [20:19] old skool [20:19] Laney, after a merge from trunk, it works fine. Was about to approve, but what is the story with the SecurityPrivacy changes in that branch? [20:19] Just some old cleanup? [20:19] mterry: the AS schemas all move to a separate package [20:20] Laney, and the names have changed, so we don't have a conflict currently? i.e. these are just old files sitting around? [20:22] actually it's already in distro [20:22] I should have set a prereq branch / merged trunk into that one [20:23] Laney, ah. Can you fill out the new checklist stuff for that branch? [20:25] woah [20:25] what checklist? [20:35] Laney, https://wiki.ubuntu.com/Process/Merges/Checklists/ubuntu-system-settings [20:37] haha [20:38] desrt, in the lightdm tests, sometimes lightdm blocks on shutdown in g_bus_unown_name. Is there any reason that you can think of why that might happen? [20:38] robert_ancell: blocks for how long? forever? [20:38] desrt, it seems to be so [20:38] any fork() in that process? [20:39] the usuals, yes [20:39] as in, fork() only if immediately followed by exec()? [20:39] they should be, but that's where I'm going to look next [20:40] could be a weird bug in the worker or something... does your testing involve a virtual dbus environment? [20:40] we have some issues with test busses disappearing.... [20:40] desrt, it has it's own test bus, but it's run in a parent process so it shouldn't disappear [20:40] desrt, yeah, I think it might be some dodgy forking, I'll work on that [20:41] robert_ancell: does the backtrace show blocking on a mutex, a cond, a poll() or what? [20:41] ah... well, let me know if you fail to find fork issues [20:41] desrt, I haven't got a backtrace because the harness makes it a bit hard to get one [20:41] will do [20:43] desrt, where is that list of fork safe functions? [20:45] robert_ancell: it' [20:45] robert_ancell: there is none because it's highly contextual, but in general the list in signal(7) should all be safe [20:45] that's the one I was thinking of [20:47] Laney, did you have a branch prepared to use these settings in telephony-service or shall I go and do that? [20:49] Laney, oh also, I recall there was a trivial conflict with trunk for your as-branch. So it'll need an update before merging [20:49] mterry: There is one (how did you test it without that?) [20:49] Ah, I found https://code.launchpad.net/~laney/telephony-service/accountsservice/+merge/201630 [20:49] Laney, I tested it manually by poking AS [20:50] nod [20:50] I'll merge trunk now [20:51] Laney, those gross gdbus lines are second nature to me now :) [20:51] I'm getting pretty good at them too [20:51] the variant syntax confused me at first [20:52] yeah [20:53] there we go, merged trunk [20:53] did you check that the migration worked? [20:54] Laney, yup [20:54] Laney, like a charm [20:54] great [21:13] Laney, also... Is volume a shared setting yet? [21:14] * mterry looks at code [21:17] OK, it isn't. Hm [21:17] * mterry looks into making that happen [21:50] Isn't that pulse? [22:01] it's not handled by system-settings, and it would feel weird to me to put it into either gsettings or AS [22:23] Laney, what about having indicator-sound sync from pulse to AS? Pulse doesn't have a native way for the greeter to see each user's volume, I assume [22:25] doesn't pulseaudio stop playing sound after switching to the greeter? [22:26] Laney, it wouldn't be the authoritative storage place for it, just a synced value [22:26] brainwash, this is more about the greeter being able to play some sounds like incoming text or call ringtone [22:26] (at the right volume) [22:26] ah, ok [23:15] * robert_ancell -> lunch