[08:24] <dholbach> good morning
[16:05] <trijntje> Hi all, do I need to submit a feature freeze request for bug  1280332
[16:05] <trijntje> to get the package into trusty
[16:10] <trijntje> ping dholbach, you replied to my bug earlier, can you give me some advice on how to proceed?
[16:14] <dholbach> hi trijntje - I'm a bit busy right now - I was sort of hoping that another reviewer (who's part of 'ubuntu-sponsors') could take care of it
[16:16] <dholbach> can somebody help trijntje with bug 1280332?
[16:16] <trijntje> dholbach: no problem, thanks for your time.
[16:17] <trijntje> to everybody else: this is my first time going through this procedure, so please let me know if I made a mistake or need to take additional steps
[16:18] <mitya57> trijntje: Yes, you need a FFe request as described in https://wiki.ubuntu.com/FreezeExceptionProcess#FeatureFreeze_for_new_packages
[16:21] <trijntje> mitya57: an earlier version of the package is already in the repository
[16:21] <trijntje> so I probably have to follow the steps for an exception for new upstream versions?
[16:21]  * mitya57 looks
[16:22] <mitya57> trijntje: Ah, I see. Then the bug shouldn't have [needs-packaging] in the subject, which is confusing.
[16:22] <mitya57> trijntje: Do you have a diff between current and new versions somewhere?
[16:26] <trijntje> mitya57: ill have to check the bzr of the project for that, hold on
[16:27] <mitya57> Is it https://bazaar.launchpad.net/~ubuntu-defaults-nl-team/ubuntu-defaults-nl/ubuntu-defaults-nl/revision/12?remember=5&compare_revid=5 ?
[16:29] <trijntje> yes
[16:30] <trijntje> the main difference with the current version is that some of the dutch radiostations changed their stream url
[16:31] <trijntje> current = currently in the repository
[16:33] <mitya57> Then you don't need an FFe I think
[16:33] <mitya57> Maybe I will sponsor it right now, even
[16:36] <trijntje> that would be great, thanks for helping me out
[16:51] <mitya57> trijntje: Can I use version number 6 instead of 12+6~ubuntu14.04.1 ?
[16:52] <mitya57> Also, do you have a changelog entry somewhere, or should I write one for you?
[16:52] <trijntje> mitya57: version number 6 is fine, the one in the repo now has 5
[16:53] <trijntje> I'm afraid I haven't kept a changelog in the package
[16:54] <trijntje> the main changes from the bzr log are
[16:54] <mitya57> OK, so I'll build it myself :)
[16:54] <trijntje>   Added COPYING file with GPL 3
[16:54] <trijntje>   Removed empty background.jpg
[16:54] <trijntje>   Updated changed urls for radiostations, added ClassicFM
[16:55] <mitya57> trijntje: Oh, did you drop ubuntu-defaults-nl binary package?
[16:55] <mitya57> Also launchers.txt was updated
[16:56] <trijntje> mitya57: yes, defaults-nl was for compatibility with a ppa I had for 12.04, and it's no longer needed
[16:56] <trijntje> and I also added a launcher for ubuntu-docs to the launchers.txt file
[16:57] <mitya57> I'm afraid we still need to keep it, as a transitional package
[16:57] <mitya57> I.e. it should be priority: extra and section: oldlibs
[16:57] <mitya57> and depend on new package
[16:58] <trijntje> for how long should it be kept?
[16:58] <mitya57> You will be able to drop it after trusty release
[16:58] <mitya57> I.e. for 2 months L)
[16:59] <mitya57> That was ":)"
[17:00] <trijntje> mitya57: ok, I'll add it back and commit it to launchpad
[17:00] <mitya57> Don't worry, I will do that myself
[17:01] <mitya57> trijntje: Wh are you overriding dh_install, instead of passing --with ubuntu_defaults to dh sequencer?
[17:02] <mitya57> *Why
[17:04] <trijntje> mitya57: I'm not sure, I think that was part of the boilerplate I used
[17:04] <mitya57> Ah, ignore that, it doesn't have a .pm file so that won't work
[17:05] <mitya57> trijntje: last question: why did you drop the -nl package and not -nl-nl? The name with one -nl looks much better to me...
[17:06] <trijntje> it has to do with the way languae codes work, in theory someone else could create a similar package for belgium, which would be nl-be
[17:06] <trijntje> (both countries have a duch speaking population)
[17:06] <mitya57> OK
[17:07] <trijntje> I agree it doesn't look very nice, but the main purpose of the package is to enable the creation of custom duch ubuntu images, so it will be rare for users to install the package manually
[17:15] <mitya57> trijntje: One more question: you added some .desktop files to launchers list, but didn't add the relevant packages dependencies
[17:16] <mitya57> That sounds like a bug
[17:17] <trijntje> yeah, I should have removed 'gemeenschap', since adding custom launchers is not allowed
[17:17] <trijntje> I did not add a dependency for yelp, since thats installed by default on ubuntu (thats the 'help' application)
[17:17] <mitya57> Mmh, maybe
[17:18] <trijntje> I do know it fails gracefully, since I completely forgot to remove the entry for gemeenchap after I removed the gemeenschap.desktop file
[17:19] <trijntje> and I didn't end up with a 'missing icon' on the launcher or something like that, so the package still 'works' without yelp, maybe it should recommend it?
[17:20] <mitya57> Not sure,  I think relying on default install is fine
[17:22] <mitya57> trijntje: Uploaded!
[17:25] <trijntje> mitya57: awesome, thanks a lot! Is there like an upload queue I can monitor to see when it will be available
[17:26] <mitya57> trijntje: you'll get an email when it migrates, usually takes ~an hour
[17:28] <trijntje> mitya57: ok, thanks again for helping me out, I'll be waiting for that email ;)
[17:29] <mitya57> You are welcome :)