[04:38] <wgrant> jtv: Do you happen to recall the purpose of the weird URL generation around POTemplate and POTemplateSubset? https://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/view/head:/lib/lp/translations/browser/potemplate.py#L745 is the relevant code. POTemplateURL links back to POTemplateSubsetURL, but that then links straight back up to the DistroSeries, constructing the SourcePackage URL manually, rather than linking back up to a ...
[04:38] <wgrant> ... SourcePackage. I can't see why it doesn't just return the SourcePackage in the inside property.
[04:38] <wgrant> I suspect there's no good reason for that, and I intend to fix it, but maybe there's something lurking in the depths of your memory.
[04:39] <wgrant> (there are custom IFacetMenu adapters in place for IPOTemplate and IPOFile to make things look correct despite the weird URL generation, and I discovered this madness when I removed them and tests failed)
[04:49] <wgrant> OK, that was added almost 9 years ago by SteveA, and I guess someone decided to add hundreds of lines of workarounds in the ensuing years rather than just fixing it..
[04:49]  * wgrant fixes.
[04:57] <jtv> wgrant: let me look...
[04:58] <jtv> That would have been before I got in on the game, and yes there were plenty of times when we didn't dare change things that were done for Reasons Unknown.
[04:59] <wgrant> Heh
[04:59] <wgrant> Yeah, it's moved around a bit, so it took a while to annotate it past the apocalypse etc. and work out just how ancient it was.
[05:00] <wgrant> Thanks for looking
[05:00] <wgrant> I think I'll just kill it and hope nothing breaks.
[05:04] <jtv> Yes, be bold.  Far too much better-keep-it in there.
[05:05] <jtv> I do recall we had some problems with the weird breadcrumb chains for POTemplates and POFiles.
[05:06] <wgrant> Yeah, I saw the weird overridey bits in my travels yesterday and deleted them, because the defaults should have worked fine
[05:06] <jtv> Because a POTemplate nests in either a ProductSeries, or a combination of a SourcePackageName and a DistroSeries (there was no direct representation of that in the DB at the time)
[05:06] <wgrant> But then that broke buildbot because it went POTemplate -> POTemplateSubset -> DistroSeries rather than the expected POTemplate -> SourcePackage -> DistroSeries
[05:06] <wgrant> Right
[05:07] <jtv> And then a POFile happens at the crossroads of a POTemplate and a Language, so again there is no good natural breadcrumbs chain.
[05:08] <wgrant> Yep