| === iahmad is now known as iahmad|afk | ||
| davmor2 | Morning all | 11:06 |
|---|---|---|
| === vrruiz_ is now known as rvr | ||
| === psivaa is now known as psivaa-lunch | ||
| asac | anyone can run the http://q-jenkins:8080/job/autopilot-release-gatekeeper/ job | 13:55 |
| asac | for qt5 edgers? | 13:55 |
| asac | elopio: ^^ | 13:55 |
| elopio | good morning! | 14:24 |
| davmor2 | morning elopio | 14:28 |
| === psivaa-lunch is now known as psivaa | ||
| senan | DanChapman,balloons : Hello | 15:38 |
| balloons | senan, hello | 15:55 |
| senan | balloons, do I need to change anything in that test ? | 15:58 |
| elfy | balloons: you a moderator on the quality mailig list - I've got a held message | 16:00 |
| elfy | balloons: also - you syncing that mp - or shall I do it | 16:00 |
| balloons | elfy, I was planning on doing it now, but you can if you want it sooner, dragged into a meeting :-) | 16:03 |
| balloons | senan, I've not had a chance to review after your changes. do the tests run successfully? | 16:04 |
| elfy | balloons: ok - leave it with me :) | 16:05 |
| balloons | elfy, :-) thanks mate | 16:06 |
| senan | balloons, yes | 16:06 |
| elfy | balloons: but I can't moderate my post on the list :p | 16:06 |
| cgoldberg | elopio, got any time for a quick code review? nobody from my team is currently online and I don't wanna wait for NZ to wake :) | 16:06 |
| balloons | elfy, knome I saw you inquired about the sync tool. I can share it; it's a hacky perl script, and by hacky I mean loads of fun. But it works. I always thought we'd have cleaned it up by now and had something but ;-) | 16:07 |
| elopio | cgoldberg: sure. I'm not sure if I know the part of autopilot where you are working, but I can take a look. | 16:07 |
| knome | balloons, please do that | 16:07 |
| cgoldberg | elopio, it's familiar territory... I'm updating the runner/result to act unittest and print the dots/flags as tests run. so it's not just silent when running in normal (non-verbose )mode | 16:10 |
| cgoldberg | we've been down this rode in SST a while back | 16:10 |
| cgoldberg | elopio: https://code.launchpad.net/~coreygoldberg/autopilot/texttest-run/+merge/209089 | 16:10 |
| elopio | that's nice, yeah | 16:11 |
| elopio | cgoldberg: isn't this a feature from TextTestResult? On SST we didn't have to implement the dots | 16:12 |
| cgoldberg | elopio, actually we did :) it's a feature of unittest's TextTestResult ... but not of testtools TextTestResult | 16:13 |
| cgoldberg | lifeless doesn't like the output.. I personally do | 16:14 |
| elopio | ok, then it looks good. | 16:14 |
| elopio | I also like it. But you are missing the tests. | 16:14 |
| cgoldberg | WIP ;) | 16:14 |
| elopio | on SST we have some nice ways to test testresults and testcases, I've been copying that stuff all over :) | 16:14 |
| cgoldberg | elopio, yea, I've grabbed some snippets from SST also | 16:15 |
| elfy | balloons: all done | 16:18 |
| balloons | elfy, I'll let your post through one sec | 16:29 |
| elfy | ok cheers | 16:29 |
| elfy | I don't often attach images ... | 16:29 |
| balloons | senan, I'll have a look now | 16:30 |
| balloons | elfy, ahh.. I hadn't seen the thread; all makes sense. | 16:31 |
| elfy | ;) | 16:31 |
| elfy | drives me insane lol | 16:31 |
| === qwebirc173872 is now known as slickymasterWork | ||
| balloons | elfy, since you are about; what do you think of https://code.launchpad.net/~rohangarg/ubuntu-manual-tests/ubuntu-manual-tests/+merge/207882? | 16:35 |
| elfy | balloons: I was looking at that earlier actually - but I couldn't work out what the original testcase was | 16:36 |
| balloons | senan, ok while you are still here, there are a couple minor layout things I would still do. Ready? | 16:37 |
| balloons | elfy, it was originally an non-english install testcase | 16:37 |
| elfy | but then it was first cuppa time | 16:37 |
| balloons | with everything you see tacked onto the end | 16:37 |
| elfy | yep | 16:37 |
| elfy | commenting now | 16:38 |
| senan | balloons, ready :D | 16:38 |
| balloons | senan, run pep8 and pyflakes on the code and fix any errors. | 16:40 |
| elfy | balloons: done | 16:40 |
| balloons | senan, I was thinking I would change the name of the non-test functions as well, or move some of the utility functions to the emulator, but I'm reconsidering | 16:41 |
| balloons | I think I might be ok with everything on that front | 16:41 |
| balloons | senan, I suppose the other thing I would like to see is removing an commented out code, and add some inline coding comments to follow along (docstrings you added are wonderful thank you) | 16:42 |
| balloons | I'll have to run and verify it works and we can merge | 16:43 |
| balloons | you've come a long way on this ;-) | 16:43 |
| senan | balloons, I ran pyflakes and got two information | 16:43 |
| balloons | elfy, ty.. He did the changes to make it a kubuntu only testcase; how / where should this live on the tracker? He didn't change the filename, but we can ask him to do that | 16:44 |
| elfy | we can do that when we merge/sync it can't we | 16:45 |
| balloons | elfy, yes, I generally do renames as part of merge | 16:45 |
| elfy | yea - same | 16:45 |
| elfy | mmm | 16:46 |
| elfy | I'd guess it should live in images really | 16:46 |
| elfy | just be a new one in there | 16:46 |
| senan | balloons, pyflakes error corrected | 16:47 |
| elfy | balloons: something like Kubuntu Localisation Support | 16:47 |
| balloons | ok, so if we are ok with that, I suppose we can merge it? | 16:48 |
| senan | balloons, I didnt understand the commenting part | 16:48 |
| balloons | senan, ahh.. I was hoping to see some more comments in the code itself of what's going on during the tests | 16:49 |
| senan | balloons, ok.. let me check | 16:49 |
| balloons | senan, also you have code like #self.keyboard.focused_type(editBox) which is commented out. Remove it if it's not needed | 16:49 |
| senan | balloons, some codes are not working in autopilot3 thats why they are commented out | 16:50 |
| balloons | senan,ok, do we have a bug filed for them? | 16:51 |
| senan | balloons, I think DanChapman filed a bug | 16:51 |
| senan | I'm not sure | 16:51 |
| balloons | senan, ok.. I like to see a bug # or link even left there so it can be referenced later on | 16:52 |
| senan | balloons, I need to check with dan, but he is busy it seems :( | 16:52 |
| balloons | senan, we can look for it | 16:53 |
| balloons | senan, is it in here? https://bugs.launchpad.net/ubuntu/+source/autopilot-gtk | 16:53 |
| balloons | senan, you can see what he reported: https://bugs.launchpad.net/~dpniel/?orderby=-datecreated&start=0 | 16:54 |
| balloons | I don't see anything.. I think you can report i | 16:55 |
| balloons | *it | 16:55 |
| DanChapman | balloons, senan what bug we talking about? | 16:56 |
| senan | DanChapman, while opening the scan folder dialog, we faced some issue in using select_single | 16:57 |
| senan | identifying the object | 16:57 |
| elfy | balloons: do you want me to rename/merge/sync this kubuntu testcase? is that what you meant? | 16:58 |
| senan | danchapman, it was working fine in autiopilot and its broken in autopilot3 | 16:58 |
| senan | danchapman, do you remember ? | 16:58 |
| DanChapman | senan, let me just look and refresh my memory | 16:58 |
| balloons | elfy, ohh, if you'd like. I just wanted someone else's opinion on the matter before I did anything further with it | 16:59 |
| elfy | oh - fine with me :) | 16:59 |
| balloons | It is a very kubuntu specific testcase, which is ok. I'm happy to merge at this point I think | 16:59 |
| balloons | after our conversation | 16:59 |
| senan | DanChapman, http://paste.ubuntu.com/7028547/ | 16:59 |
| balloons | Just need to check formatting then I would approve | 16:59 |
| elfy | ok - I'm on it then | 17:00 |
| balloons | elfy, you rock! | 17:00 |
| balloons | DanChapman, I'd like to talk semantics about layout, etc with senan's testcase as the example after e solve this issue ;-) | 17:01 |
| DanChapman | senan ahh yes the '...' \u2026 issue? I think i forgot to file a bug for that against autopilot. Let me check | 17:02 |
| senan | DanChapman, yep | 17:03 |
| senan | :D | 17:03 |
| DanChapman | senan, can you create a simple testcase to reproduce the bug? | 17:03 |
| elfy | balloons: ok - thanks for the compliment - but as much as I'd like to do it for you - when I try and add a testcase in iso.qa - it gives me the edit a testcase page | 17:03 |
| elfy | url says /add - but there's nowhere to give it a number | 17:04 |
| senan | DanChapman, same DiskusageAnalyzer tc ? | 17:04 |
| DanChapman | balloons, sure :-) | 17:04 |
| balloons | elfy, using the script or ? | 17:04 |
| elfy | no - manually :) | 17:04 |
| DanChapman | senan yes something simple that works with autopilot but not autopilot3 | 17:04 |
| balloons | elfy, with the script, you leave off the number part and it will assign and rename | 17:05 |
| elfy | or is the iso tracker slightly different from the package one - and the thing numbers automatically? | 17:05 |
| balloons | elfy, otherwise, I think that is correct | 17:05 |
| balloons | elfy, you don't get to assign the number :) | 17:05 |
| senan | DanChapman, yea sure.. shall I do it tomorrow | 17:05 |
| elfy | aaah - ok so it is different :) | 17:05 |
| balloons | DanChapman, so for these gtk apps, what do you think of the utility functions inside the main testcase.py file? | 17:06 |
| elfy | ok - thanks balloons - rolling along now :) | 17:07 |
| DanChapman | senan, when ever you have time. It's not a blocking bug but it does need fixing, so if you could file the bug against autopilot and provide the simple testcase to reproduce the bug | 17:07 |
| senan | DanChapman, sure.. I'll take care | 17:08 |
| balloons | senan, I would like to hold off on merging until we have the bug number if that's alright? | 17:08 |
| senan | balloons, Its ok | 17:08 |
| senan | balloon, you want to make sure that I'll file a bug right ;) he he | 17:09 |
| senan | balloons, DanChapman : Thanks for the comments and review, going to sleep now...see you tomorrow | 17:10 |
| teward|phone | elfy: balloons: before I go absolutely bonkers and do the email equivalent of yelling at someone, would either of you like to calmly but sternly talk to Alberto before I do? | 17:11 |
| balloons | senan, have a pleasant evening! | 17:12 |
| senan | balloons, DanChapman : Goooood Night :) | 17:13 |
| balloons | teward|phone, let's not go bonkers. I'll have a chat with him | 17:13 |
| DanChapman | balloons, I personally don't like it, it makes messy reading to my eyes as long as the utility functions name is clear on it's intent. Whats your thoughts | 17:14 |
| elfy | not going bonkers is a plan | 17:14 |
| elfy | balloons: ok - manually ;) merged and synced it | 17:15 |
| balloons | DanChapman, I guess I'm confused by your sentence :-) | 17:15 |
| balloons | do you like the mp as-is or would you change it? | 17:15 |
| balloons | elfy, :-) | 17:15 |
| DanChapman | balloons, sorry that is kind of confusing now i've read it back. Mind is elsewhere atm. ;-) I'll take a look at it now | 17:22 |
| balloons | DanChapman, :-) Basically we are starting to push tests to be written in a page object model. I've got a post in draft where I want to talk about it more and so off some examples; namely ubuntu-clock which leo and nekelesh have been tweaking to fit the model quite nicely | 17:24 |
| DanChapman | balloons, sounds interesting i would like to read it :-D | 17:25 |
| balloons | DanChapman, the idea was proposed by elopio and stems from this: http://code.google.com/p/selenium/wiki/PageObjects | 17:26 |
| balloons | Anyways, for gtk apps I'm not sure how I want things to look.. But I don't think I'm a big fan of having the utility functions inside the tests | 17:26 |
| balloons | I'm asking because I think senan's mp is otherwise pretty much ready to merge. But we should make sure the format is one that is maintainable and makes sense | 17:27 |
| balloons | DanChapman, so for example for the disk usage analyzer app I would imagine an object for each dialog being tested. The test then get very very simple. a few lines, which read very nicely | 17:32 |
| balloons | but it's hard to say if that's desirable or the way to go for these apps/tests | 17:35 |
| DanChapman | balloons, yes i agree I like the idea of breaking it out into objects :-) | 17:36 |
| elfy | I'd love to have an opinion - but it's all stuck in the wall above my head :p | 17:36 |
| elfy | hi DanChapman | 17:36 |
| balloons | DanChapman, so should we merge his MP hen have him refactor it? I'm leaning towards that option as it's been in process for so long | 17:38 |
| DanChapman | balloons, yes i would merge it. I'm going to give the page object style a go on the eog test seeing as thats completely borked atm. Then we can see how it turns out | 17:39 |
| DanChapman | elfy hey there :-) | 17:39 |
| balloons | DanChapman, ok, perfect ;-) | 17:42 |
| elfy | balloons: so why if you add a testcase in packages does it let you give them a number - wouldn't it be better if it didn't? | 17:55 |
| elfy | just a thought | 17:55 |
| balloons | elfy, I'm not sure actually.. | 17:55 |
| * balloons goes to look | 17:55 | |
| balloons | elfy, at one point someone had a purpose for it.. I remember issues with UTAH wanting to specify things | 17:57 |
| balloons | it might be leftover from that. If you don't fill in the field, it autoassigns | 17:57 |
| elfy | oh does it - useful to know that | 17:57 |
| balloons | it's interesting it only shows on packages.qa.u.c | 17:57 |
| balloons | elfy, right, title and testcase is the only required fields | 17:58 |
| elfy | didn't know that :) | 18:00 |
| phillw | elfy: balloons I stepped back to get de-stressed... the user | 18:38 |
| phillw | Alberto Salvia Novella us that disruptive. I am ceasing my following of ubuntu-quality@lists.ubuntu.com | 18:38 |
| phillw | sorry folks... I just don't need this crap. | 18:38 |
| balloons | phillw, I've spoken to Alberto about it. If there is another lapse I'll simple remove him from the list and moderate any mails he may decide to post | 18:58 |
| phillw | balloons: I've re-joined but different email addy... can you have a quick check to see my old one expired (a legacy one xxxxxx@ubuntu.com and xxxxxx@uk.voplink.com) and the new one xxxxx@phillw.net is being used. Thanks. | 19:03 |
| balloons | phillw, sure, just a moment | 19:04 |
| balloons | phillw, I only see the new addy | 19:14 |
| phillw | okies :) | 19:15 |
| phillw | thnx | 19:15 |
| phillw | sorry for pauses, just installing a centos 6.5 VM for a student | 19:16 |
| letozaf | balloons, elopio hello | 19:56 |
| balloons | letozaf, hello | 20:07 |
| letozaf | balloons, about rssreader-app I saw elopio's refactoring of one test, whats next now ? | 20:12 |
| letozaf | balloons, and about reminders app, if qmlscene is not supported anymore how is autopilot vis going to work ? | 20:19 |
| balloons | letozaf, yes I saw michael's response. Since the binary launches again, we can just use vis against that | 20:20 |
| balloons | letozaf, like so: autopilot launch -i Qt reminders | 20:20 |
| * balloons tries and doesn't see anything, heh | 20:21 | |
| letozaf | balloons, ah ok thanks I will try this | 20:21 |
| letozaf | balloons, oh wait... :P | 20:21 |
| letozaf | balloons, it works for me :) | 20:22 |
| balloons | letozaf, perfect.. it shoudl | 20:22 |
| letozaf | balloons, no, I was wrong, thers is nothing in vis :P | 20:23 |
| balloons | letozaf, hmm | 20:38 |
| letozaf | balloons, :) | 20:39 |
| balloons | letozaf, on the rssreader, I'm not sure of the status for elopio. | 20:41 |
| balloons | I see https://code.launchpad.net/~elopio/ubuntu-rssreader-app/refactor_tests/+merge/208517 | 20:42 |
| letozaf | balloons, ok I will wait | 20:42 |
| balloons | letozaf, ohh yea, looks all done. So do you see how the refactoring happened? | 20:43 |
| balloons | essentially each page is an object | 20:43 |
| letozaf | balloons, yes I had a look at it | 20:43 |
| balloons | so you can continue to mold the tests in this way | 20:44 |
| balloons | and of course, work on getting all the tests running :-) | 20:44 |
| balloons | on reminders, that's quite annoying. Assuming you can't use vis, what do you need to understand? We can use print_tree and look at the qml for objects as needed | 20:44 |
| letozaf | balloons, ok for rssreader app I will give it a try | 20:47 |
| letozaf | balloons, for reminders app I will have to see what happens when I try to write the tests, whats print_tree | 20:47 |
| * letozaf is looking for print_tree | 20:47 | |
| balloons | letozaf, http://unity.ubuntu.com/autopilot/api/introspection.html?highlight=print_tree#autopilot.introspection.dbus.DBusIntrospectionObject.print_tree | 20:48 |
| balloons | letozaf, basically you can print an entire tree of any object | 20:49 |
| balloons | letozaf, so you can grab the main_view for reminders, then call print_tree and get a vis dump more or less you can browser | 20:50 |
| balloons | *browse | 20:50 |
| letozaf | balloons, just found it, thanks I will try to use this | 20:50 |
| elopio | letozaf: oh, hi. | 20:51 |
| elopio | yes, can you please review that branch? https://code.launchpad.net/~elopio/ubuntu-rssreader-app/refactor_tests/+merge/208517 | 20:51 |
| letozaf | elopio, hi :) | 20:51 |
| elopio | I broke one test, so I need a little small fix on it, and it would be good to go, if you like it. | 20:51 |
| letozaf | elopio, already done it :) | 20:51 |
| elopio | letozaf: thanks! | 20:51 |
| elopio | I'll fix it after lunch. | 20:51 |
| letozaf | elopio, ok | 20:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!