/srv/irclogs.ubuntu.com/2014/03/04/#juju-dev.txt

waiganiwallyworld_: I forgot to grab that example before leaving the standup. Can I grab it again please?02:19
wallyworld_for loop starts at line 548 in state.go02:19
waiganiwallyworld_: cheers02:23
wallyworld_np02:23
axwwallyworld_: you did a fix to the unit upgrader... did it fix https://bugs.launchpad.net/juju-core/+bug/1284502?02:33
_mup_Bug #1284502: upgrader: cannot read tools metadata (in unit agent) <local-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1284502>02:33
wallyworld_axw: i think so02:36
wallyworld_yes02:36
wallyworld_that branch is in the queue to land02:36
axwok02:37
wallyworld_thumper: so i can't push to lp:~go-bot/juju-core/trunk. says it's read only02:41
thumperah...02:41
* thumper thinks02:41
thumperwallyworld_: you need to do this:02:42
thumperbzr push bzr+ssh://go-bot@bazaar.launchpad.net/~go-bot/juju-core/trunk02:42
thumperyour ssh key is loaded against the go-bot user02:42
wallyworld_ah ffs. i tried that but forgot the go-bot@ bit02:42
thumper:)02:43
thumperwallyworld_: are you setting the author on the merge?02:43
wallyworld_what's the way to do that?02:43
thumperwhen you have a merge02:43
thumperrun the tests02:43
wallyworld_yep02:43
thumperbzr commit -m "blah blah" --author "Firsrt Last <email addr>"02:44
wallyworld_ah --author, ok02:44
axwthumper: https://codereview.appspot.com/67870045/    -- the change in AddScripts fixes the log dir permissions. Did this as a drive-by in a larger fix02:49
thumperok02:50
thumperhmm...02:51
thumperaxw: actually I ment to ask you earlier today02:52
thumperhow the juju-db upstart job was getting removed02:52
axwthumper: the machine agent removes it on tear down02:55
axwpkill -SIGABRT kills the machine agent, which stops and removes the jobs02:55
thumperaxw: so the machine agent also brings down the mongo job?02:56
axwthumper: yep, that bit is now shared between local and manual providers.02:56
axwthumper: see uninstallAgent in cmd/jujud/machine.go if you care to see where02:57
thumperok02:58
thumperwallyworld_: I don't want to see the asserts removed03:11
thumperwallyworld_: just moved to an explicit test03:11
wallyworld_thumper: but it's part of the setup03:11
wallyworld_not prt of what is being tested03:12
thumperwallyworld_: if something from setup is tested in one test, you don't need to do it in every test03:12
thumperI disagree03:12
thumperthe setup it the setup03:12
thumperthe test checks the setup did it right03:12
thumperwhat you have03:12
wallyworld_it is to ensure the setup does what we think03:12
thumperis the test that it worked every time done every time03:12
thumperIMO this is overkill03:12
wallyworld_i've seen tests before where setup was faulty and we didn't know it03:12
thumperjust what I was brought up with, blame mwhudson03:12
thumperwallyworld_: I'm not saying don't test that setup did it right03:13
thumperwhat I am saying is don't do that assertion *in* setup03:13
wallyworld_so you want a TestSetuptest()03:13
thumperhave a test for the purpose of making sure that setup did it right03:13
thumperFFS, do what you like03:14
* thumper gives up03:14
wallyworld_no, it's ok, i'll change it03:14
wallyworld_just trying to understand yout pov03:14
axwI don't know the context, but that sounds like a recipe for difficult to debug test errors when TestSetuptest doesn't run before the other tests03:14
wallyworld_there isn't a TestSetuptest yet03:14
wallyworld_i was doing asserts in Setup() to ensure that the test setup was done right03:15
wallyworld_or more to the point, did what we thought it did so that subsequent tests could be assured of testing the right thing03:15
wallyworld_but i can add an explicit test to check the behaviour of SetUp()03:16
* wallyworld_ -> lunch03:16
thumperI guess this is why having lots of setup in setup is not good03:16
thumperwallyworld_: look, the overhead of running it every time is insignificant03:17
axwhmm, I don't see the need for the assertions at all really. this is testing that SetEnvironConfig does its job03:17
thumperjust keep them in setup03:17
axwthat should be done in state03:17
* axw shrugs03:17
thumperaxw: what was the failure here: https://code.launchpad.net/~axwalk/juju-core/local-prereq-rsyslog-gnutls/+merge/20854503:31
thumperintermittant?03:31
axwthumper: pretty sure it's because the bot was in a bad way03:31
* thumper nods03:32
=== edamato is now known as edu-afk
mwhudsonthumper: wat03:49
wallyworld_axw: the assertions were not to check that SetEnvironConfig did it's job, but that there weren't typos in hgow it was invoked such the the expected config attrs were set, since the test checks for their removal03:55
axwwallyworld_: if you're making assertions about how the tests work, then when do you stop?03:56
wallyworld_i only do it for selected cases03:56
wallyworld_on a subjectively as needed basis where there's some risk03:56
thumpermwhudson: oh hai04:02
thumpermwhudson: just taking your name in vain04:02
mwhudsonthumper: cool04:02
mwhudson:)04:02
thumpermwhudson: for teaching me about tests04:02
thumperin a good way04:03
wallyworld_waigani: tests on your branch fail so i can't land it for you:  policy-based-config-validation04:05
waiganiwallyworld_: doh04:05
waiganiokay, I'll check04:05
wallyworld_ok, ta04:06
wallyworld_axw: i get test failures in ~axwalk/juju-core/local-prereq-rsyslog-gnutls04:13
wallyworld_ah04:13
wallyworld_cause i don't have syslog-gnutls installed04:14
wallyworld_let me install that and retry04:14
wallyworld_right, that's much better04:19
axwwallyworld_: hrm, that's actually a problem :)04:24
axwtests shouldn't rely on the package being there04:24
wallyworld_i guess we need to add it to the packaging stuff04:24
wallyworld_i think it's reasonable the deps are expected04:24
wallyworld_eg tests will fail if no mongo04:24
axwtrue04:25
wallyworld_i'd send an email to the list to let people know they need to install it04:25
axwwallyworld_: I actually thought I had isolated this one, so I'll see if it's easy to fix... otherwise I will email the list04:25
wallyworld_and let curtis know so he can get the ppa sorted04:25
axwjuju-local should be updated tho, there's a bug for that04:26
wallyworld_regardless for the next release the packaging needs to be changed04:26
axwwallyworld_: what do you mean by the packaging?04:27
wallyworld_that fact that juju-core depends on this new package04:27
axwwallyworld_: the client doesn't need rsyslog-gnutls, and it will be installed by bootstrap04:27
axwno, only local requires it to be pre-existing04:27
wallyworld_oh ok04:27
wallyworld_but that's still juju-core04:27
axwthere's a meta package for the prereqs04:28
wallyworld_so if one installs juju-core, it should pull down this new dep04:28
wallyworld_sure, the dependencies need to be updated04:28
axwyep, there's a bug for it against 1.1804:28
wallyworld_ok, that's great04:29
wallyworld_just wanted to double check04:29
axwwallyworld_: when you have a moment, can you please review https://codereview.appspot.com/71050043?04:46
wallyworld_sure04:46
wallyworld_just landing the rsyslog port branch04:47
wallyworld_axw: all approved mps landed \o/05:03
axwthanks wallyworld_  :)05:03
wallyworld_i'm pleased too05:03
bloodearnesthazmat: re install.sh, sure, I didn't exec it, but it was useful as a crib sheet for set up steps09:41
natefinchmgz, rogpeppe, dimitern: o/09:54
dimiternnatefinch, morning!09:55
natefinchdimitern:  morning :)09:55
mgznatefinch: we're getting wwitzel3 to g+ you now for the hangout09:57
natefinchmgz: cool09:57
natefinchjam: https://plus.google.com/hangouts/_/76cpirbanp35boic60gobgfltc?authuser=1&hl=en10:48
mgzhttp://en.wikipedia.org/wiki/Shrove_Tuesday10:51
natefinchmgz: I didn't know they had a whole week of this stuff.10:54
mgzthe feasting bit is only today, the following period is fasting10:59
wallyworld_mgz: from what i can tell, juju trunk  canonistack don't like each other because port 17070 can't get routed via chinstrap like port 22 can for ssh11:08
wallyworld_or am i missing something?11:09
wallyworld_i was hoping to try and get the landing bot running11:09
wallyworld_but i ended up testing a bunch of branches and landing manually11:09
wallyworld_at least the backlog of approved mps is now in trunk11:10
mgzwallyworld_: you can always route via sshuttle to the bootstrap node, but I think going via chinstrap should be fine11:33
mgzwallyworld_: I saw you'd landed a bunch of branches, thanks11:33
wallyworld_mgz: i tried using shuttle, no good11:33
wallyworld_i must have been doing it wrong11:33
mgzthe main issue is lcy02 is just hosed, but I will probably try bring up a new bot on lcy0111:33
wallyworld_ok11:34
mgzor fall back to ec2 if needed11:34
wallyworld_previously lyc02 was better11:34
dimiternLXC is now fixed on trusty for me - local provider works again! \o/11:34
wallyworld_dimitern: yeah, i landed a fix today11:34
wallyworld_it was broken for trusty host and precise charms11:35
wallyworld_but worked if host and charms were the same11:35
wallyworld_well, the upgrader bounced anyway11:35
bloodearnestwallyworld_: huh, that explains this mornings issues, thanks :)11:37
wallyworld_bloodearnest: ah, sorry about that. fixed now :-) a fix for one problem broken something else so needed a second fix :-/11:37
bloodearnestwallyworld_: no worries, seems good now. I thought I'd broken things by having 4 active local envs at once11:39
wallyworld_nah :-)11:40
bloodearnestI get warnings for shared-storage-port env config - can I just drop that now?11:42
wallyworld_not sure about that one off hand, let me check11:43
wallyworld_bloodearnest: i think you can delete that one11:45
bloodearnestwallyworld_: great - the warnings interfere with my bash auto-completion11:46
dimiternwallyworld_, awesome! 10x12:08
ahasenackdoes anyone know what the hook behavior is when a unit is rebooted?13:17
ahasenackI'm seeing that in 1.16.6 the config-changed hook is run, for example. Is that expected?13:17
natefinchdimitern, rogpeppe:  I think john dropped out of the hangout btw13:47
evhi guys. Is anyone working on https://bugs.launchpad.net/juju-core/+bug/1284183? It's causing us a lot of pain as we try to deliver some customer work and we've got a big deadline coming up in a couple of weeks13:55
_mup_Bug #1284183: jujuclient.EnvError: <Env Error - Details:  {   u'Error': u'watcher was stopped', u'RequestId': 9, u'Response': {   }} <api> <status> <juju-core:Triaged> <https://launchpad.net/bugs/1284183>13:55
natefinchev: we're actually triaging bugs today, so we can look at that one and see what's up with it. Roger knows the most about it, but is out to lunch, he should be back shortly, however13:57
evcool, thanks natefinch13:58
mgzbug 1287147 for the FFE14:38
_mup_Bug #1287147: [FFe] juju-core 1.18/2.0 <juju-core (Ubuntu):New> <https://launchpad.net/bugs/1287147>14:38
natefinchrogpeppe: when you get a chance, I committed fixes for the issues you brought up in the code review: https://codereview.appspot.com/69600043/14:42
rogpeppenatefinch: will look in a mo14:43
evrogpeppe: also if you could have a look at bug 1284183 whenever you get a chance, I'd greatly appreciate it. My team at Canonical keeps hitting it and its killing our velocity as we try to deliver a contract over the next two weeks15:17
_mup_Bug #1284183: jujuclient.EnvError: <Env Error - Details:  {   u'Error': u'watcher was stopped', u'RequestId': 9, u'Response': {   }} <api> <status> <juju-core:Triaged> <https://launchpad.net/bugs/1284183>15:17
natefinchjam: https://plus.google.com/hangouts/_/76cpirbanp35boic60gobgfltc?authuser=1&hl=en16:10
=== jam is now known as Guest22354
=== Guest22354 is now known as jam1
rogpeppeev: i've just been looking at that bug with a view to trying to repro it16:38
evrogpeppe: yay! cjohnston can probably help get logs and things if you need them16:39
rogpeppeev: the repro instructions don't seem to work for me16:39
evhe experiences it quite often16:39
evdoanac and urshina as well, who I'll tell to join this channel16:39
rogpeppecjohnston: you've got a bare "sshuttle" line there, but sshuttle just gives me a usage message there16:39
cjohnstonrogpeppe: you will need to do sshuttle for an instance you have.. I couldn't give you the exact command I use because it wont work for you16:40
rogpeppecjohnston: a sample command line? (i haven't used sshuttle before)16:40
rogpeppecjohnston: (and i'm not sure what you wanted it to do here)16:41
evUrsinha: just reproduced it16:41
cjohnstonrogpeppe: sshuttle -r ubuntu@10.55.60.216 10.55.0.0/1616:41
cjohnstonrogpeppe: when using something like HP cloud you don't need it.. but you need it to use canonistack16:41
rogpeppecjohnston: i'm using ec216:41
cjohnstonrogpeppe: we dont use ec2 because of the api16:41
rogpeppecjohnston: or the local provider16:41
rogpeppecjohnston: which api?16:42
cjohnstonthe ec2 api is different from hp/canonistack16:42
ev(openstack API - we use glance and swift)16:43
Ursinhaev: it seems I hit the watcher bug every time I try to deploy using a fresh bootstrapped environment16:43
natefinchmgz, jam1, fwereade: is the bot working yet?  Just realized I marked stuff for merge, but there may be no bot to merge it17:14
mgznatefinch: nope17:29
mgzwas going to fix today but have been under the weather17:29
natefinchmgz: ok, no problem, just wanted to know what the plan was.17:30
mgzyou can manually land things if needed urgently17:30
hazmatahasenack, no config-changed hook was being executed gratitiously.. there's a bug against that, i think its fixed in trunk17:31
hazmater. 1.1717:31
natefinchmgz: nothing's terribly urgent, it just would be nice, since I have other stuff that depends on it.17:31
hazmatbloodearnest, the other crib sheet item is using the lxc stable ppa if not on trusty for aufs17:31
bloodearnesthazmat: yeah, am on trusty so skipped17:34
hazmatbloodearnest, so it worked out for you?17:35
bloodearnesthazmat: I needed jujuclient 0.17 from PyPI (0.15 in trusty seems to have bug)17:35
bloodearnesthazmat: and I could jlxc-add machines, buit the didn't come up properly - I think I may have encountered an issue in trust with local provider that was fixed today17:36
bloodearnesthazmat: I will try again tomorrow sometime17:36
hazmatbloodearnest, this doesn't use local provider17:36
hazmatbloodearnest, jlxc that is17:37
bloodearnesthazmat: good point, not sure why it didn't work then17:37
hazmatbloodearnest, probably missing packages in your base snapshot17:37
hazmatbloodearnest, needs git, cpu-checker at min17:38
ahasenackhazmat: it highlighted a bug in our charm anyway, someone rebooted a node and config-changed ran and highlighted an issue17:38
ahasenacksame thing happens with a juju set, just turns out a reboot triggered it :)17:38
hazmatfuzz testing17:39
mgzhttp://godoc.org/github.com/loggo/loggo#Formatter17:52
bloodearnesthazmat - makes sense - will try again later18:09
hazmathalf of all open bugs marked high18:15
hazmathmm18:15
natefinchhazmat: if they weren't important bugs, they wouldn't have bothered to log them18:24
natefinchhazmat: I wonder what portion of the non-high bugs were created as high18:24
hazmatnatefinch, almost zero18:29
hazmatsinzui, https://bugs.launchpad.net/juju-core/+bug/1219441 is fix committed or released (dev version) afaik18:29
_mup_Bug #1219441: juju cli should cache api endpoint, saves up to 75% of run time <papercut> <performance> <juju-core:Triaged by rogpeppe> <https://launchpad.net/bugs/1219441>18:29
* hazmat goes bug weeding18:29
sinzuihazmat, thank you very much! I too and looking for fixed or now wint fix bugs18:30
hazmatsinzui, re high philosophy. are you abiding by lp severity help/description guidelines? or something else18:31
hazmatie. high for next release?18:31
sinzuihigh is fix in the next 6 months18:31
sinzuihazmat, If we want it fixed for 14.04, we should target to 2.018:31
evdoes juju work on rackspace? I can't find any documentation for it18:32
evor are my options HP and AWS18:32
hazmatev no18:32
hazmatev or digitalocean ;-) .. ie manual provider works everywhere.18:32
evhazmat: we need openstack APIs as we use glance and swift as part of this project18:33
evotherwise I'd be all over the AWS goodness18:33
hazmatev, there are some issues with rackspace and openstack provider due to lack of images, lack of security groups, etc.18:33
evick, I'll cancel the account then18:34
evI wonder why there are other accounts inside canonical then?18:34
* hazmat draws blanks18:34
hazmatthey gave some freebie accounts for ostack devs18:34
ev^ cjohnston don't bother with rackspace18:35
cjohnstonev: I saw18:35
evcool18:36
waiganiwallyworld_: thanks for landing the branches yesterday19:07
thumpergah20:46
thumperniemeyer: do you know why this fails? args = append(args, "--", templateArgs...)20:48
thumperboth args and templateArgs are []string20:48
niemeyerthumper: The variadic parameter must match the variadic parameter of the function20:48
thumperI would have thought that would work20:49
thumperso it isn't unpacking and repacking20:49
thumperjust passing throughj20:49
niemeyerthumper: Right20:49
thumperhmm...20:49
thumperok20:49
niemeyerthumper: I'm not sure if that's a good thing or not, or if eventually it'll just be more flexible20:49
niemeyerthumper: I suspect it's one of these "let's see how it goes" cases20:49
thumperit is just one of those "I would expect this to work and it doesn't" moments20:50
niemeyerthumper: I agree20:50
* thumper falls foul of the fix bug and try again without rebuilding issue21:03
thumperok, that isn't too crazy21:15
waiganithumper: go newbie question?22:30
thumpershoot22:31
waiganihttp://paste.ubuntu.com/7035472/ I'm getting the error: newConfig declared and not used on line 1622:31
waiganiAt first, I thought block scope was stopping me from conditionally setting the variable.22:31
waiganiBut as long as I declare the var in the parent scope, it should work. I did a simple test in the playground: http://play.golang.org/p/rhxBZjqexA22:31
waiganiSo I'm stumped.22:31
* thumper thinks he knows without looking22:32
thumperbut looks anyway22:32
thumperright22:32
thumperyou hit the same issue as wallyworld yesterday22:32
waiganinewConfig should be used on line 38?22:32
thumpersince you are using := it creates a new one22:32
thumperin that scope22:32
thumperyou need to use =22:32
waiganiaahhh22:32
thumperwhich may mean you need to declare22:32
waiganithanks22:32
thumpervar err error22:32
waiganiyep22:33
waiganicheers22:33
thumpernp22:33
=== thumper is now known as thumper-gym
waiganiwallyworld: I'm getting the following test failure:23:16
waigani# launchpad.net/juju-core/worker/rsyslog23:17
waiganiworker/rsyslog/worker.go:19: import ...go/pkg/linux_amd64/launchpad.net/juju-core/log/syslog.a: object is [linux amd64 go1.1.2 X:none] expected [linux amd64 go1.2 X:none]23:17
waiganiyet go version returns: go version go1.2 linux/amd6423:17
waiganiAny hints, off the top of your head?23:17
wallyworldtry deleting your pkg directory to force it to recompile everything. i think you must have upgraded your go version and have old compiled artefacts hanging around23:18
waiganiwallyworld: will do, thanks23:18
waiganiwallyworld: 5min hangout?23:34
wallyworldwaigani: i'm sitting in the tyre shop getting some tyres fitted. so i can't really do it now sorry23:35
waiganinp23:35
wallyworldhopefully it will be finished soon23:35
waiganiso I rm -rf pkg23:35
wallyworldit's quite an open office so i can't reslly talk23:35
waiganisure23:36
waiganinow when I make check I get a LOT of those wrong go version errors23:36
wallyworldwhich pkg dir did you remove23:36
waigani~/go/pkg23:37
wallyworldso your juju src lives under ~/go/src23:37
waiganiyep23:37
wallyworldand if you go build ./... it fails?23:38
wallyworlddid you recently install a new version of go23:38
waiganiyes23:38
waiganiwell, a few weeks ago23:38
waiganithis is the first time I've seen this error though23:38
wallyworldhmmm. it should have shown up immediately so there's something else at play23:39
wallyworldwhat else has changed?23:39
waiganihmmm...23:39
waiganiwallyworld: go build ./... throws a whole bunch of the same errors23:41
waiganihttp://pastebin.ubuntu.com/7035788/23:41
waigania path problem maybe?23:42
waiganii.e. two different go excs running?23:42
wallyworldseems like it what does "which go" say23:42
waigani/home/jesse/go/src/code.google.com/p/go/bin/go23:43
wallyworldand that's where you installed go 1.2 to?23:43
waiganii think so, go I'll retrace my steps23:43
wallyworldwhat version does that report?23:44
waigani1.223:44
wallyworldcause there will also be a /usr/bin/go23:44
waiganiah23:44
wallyworldwhy didn't you install to /usr/bin?23:45
waigani/usr/bin/go = 1.1.223:45
waiganiwallyworld: good question!23:45
wallyworldthere should be a ubuntu package for it23:45
waiganiI'll do that now and see if it fixes it23:45
wallyworldthere's something hppening i don't fully understand23:45
wallyworldbut yeah, try and get only one version installed and see if tha helps23:46
wallyworld"go build -a" could also be tried23:46
waiganiwhat does that do?23:47
waiganiit just returned without output23:47
wallyworldyou still need to tell it what to build23:49
wallyworldi was just saying use the -a param to force a rebuild of everything even if it thinks it's not out of date23:50
wallyworldiow go build -a ./...23:50

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!