frankban | guihelp: I need two reviews (no QA) for https://github.com/juju/juju-gui/pull/163 . Anyone available? thanks! | 12:52 |
---|---|---|
rick_h_ | frankban: looking | 12:53 |
frankban | rick_h_: thanks | 12:53 |
bac | frankban: sure | 12:58 |
frankban | thanks bac | 12:58 |
frankban | bac, rick_h_: thanks for the reviews | 14:26 |
frankban | rick_h_: re machineUnitsMap, the idea is to call filterUnits only once, avoiding multiple modelList cycles for each machine | 14:27 |
rick_h_ | frankban: ah, that makes sense then | 14:27 |
frankban | rick_h_: cool | 14:27 |
rick_h_ | heh, not enough sleep last night to see it | 14:27 |
rick_h_ | hatch: no luck with upstream kernel | 14:32 |
rick_h_ | and man, kill a cpu makes for crappy performance | 14:32 |
hatch | :/ | 14:32 |
hatch | guess no 14.04 for me yet then either | 14:33 |
hatch | :( | 14:33 |
rick_h_ | nope | 14:33 |
hatch | darn I was really looking forward to it | 14:33 |
hatch | think they will get it in before release? | 14:33 |
rick_h_ | well, there's a bug. Let's see if it gets fixed. | 14:33 |
rick_h_ | no idea, I'm guessing it's a matter of seeing if it works upstream | 14:33 |
hatch | can you link the bug so I can mark myself on it? | 14:34 |
rick_h_ | https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1284085 | 14:34 |
hatch | ok I guess I can't add myself to it | 14:39 |
hatch | 'affects you' doesn't send emails and I can't add myself to the subscribers list | 14:39 |
rick_h_ | hatch: hmm, you're listed as subscribed | 14:39 |
rick_h_ | Notified of all changes | 14:39 |
rick_h_ | Jeff Pihach | 14:39 |
hatch | ok maybe lp is just being busted | 14:40 |
hatch | thx | 14:40 |
bac | rick_h_: hangout? | 15:01 |
rick_h_ | bac or benji can one of you please QA the change from Makyo? My machine just went boom and I need to get it back up. https://codereview.appspot.com/71070051/ | 15:22 |
benji | rick_h_: I'll take a look. | 15:22 |
rick_h_ | thanks | 15:22 |
hatch | I'm trying to decide if I should land a branch which breaks things or make it even bigger | 15:47 |
rick_h_ | what does it break and what are you doing that's so large? | 15:48 |
hatch | well stuff that was in the 'inspector.js' file | 15:48 |
hatch | has been moved to mixins | 15:48 |
hatch | which can't be mixed into viewlets | 15:48 |
hatch | https://github.com/hatched/juju-gui/compare/juju:develop...hatched:service-config-view?expand=1 | 15:49 |
rick_h_ | hatch: on a call but let's chat after the standup? | 15:49 |
hatch | current diff | 15:49 |
hatch | sure | 15:49 |
rick_h_ | jujugui call in 10 | 15:50 |
hatch | jujugui call in 2 | 15:58 |
Makyo | One of these days, I'll be able to sign into RV... | 16:09 |
Makyo | Actually, let me see about making a chrome profile with just canonical address. | 16:09 |
Makyo | That worked, whew. | 16:13 |
hatch | lol | 16:13 |
rick_h_ | browser wars! fight the browser | 16:14 |
rick_h_ | yay calls done! /me sends blood back to his ears | 16:15 |
hatch | rick_h_ there is another approach - I keep working on this branch making logical commits then when it's done it can be reviewed one commit at a time? | 16:26 |
rick_h_ | hatch: I like the dupe code. We've got a history around that I think. | 16:32 |
rick_h_ | I don't know I want to go through it one commit at at time | 16:32 |
rick_h_ | thought I guess that's something that might help in review | 16:33 |
hatch | yeah just an idea | 16:38 |
hatch | has anyone ever had mocha just bail after 3 failures? I'm getting 3 failures, fixing them, get three more.... repeat | 16:46 |
benji | bac: have you build charmworld from scratch lately? | 16:49 |
benji | I'm getting this: | 16:50 |
benji | Could not find a version that satisfies the requirement charmworldlib==0.1.4 (from -r requirements.txt (line 7)) (from versions: 0.3.0) | 16:50 |
rick_h_ | benji: hmm is that not in the download-cache? | 16:51 |
rick_h_ | benji: maybe a recent update missed the cache | 16:51 |
benji | rick_h_: nope, 0.3.0 is the only version of charmworldlib in there, I assume the requirement for 0.1.4 is wrong (since 0.3.0 exists) | 16:53 |
rick_h_ | benji: gotcha, in setup.py ? | 16:53 |
benji | requirements.txt | 16:53 |
rick_h_ | has the 0.1.4? | 16:53 |
benji | yep | 16:54 |
rick_h_ | hmm, must be a missed update then during bac's recent upgrade. | 16:55 |
benji | Makyo: when the QA instructions say "Get bac's bundle wiki:wiki" what do you mean exactly? | 17:12 |
Makyo | benji, sorry, one sec. I got it through pdb, but there's an easier way. | 17:13 |
Makyo | benji, /api/3/bundle/~bac/wiki/3 | 17:14 |
benji | k | 17:15 |
Makyo | data.services.db.charm should be cs:precise/mysql | 17:15 |
benji | Makyo: Internal Server Error | 17:15 |
Makyo | Erk | 17:15 |
benji | { | 17:16 |
benji | "bundle_id": "~bac/wiki/0", | 17:16 |
benji | "type": "no_such_bundle" | 17:16 |
benji | } | 17:16 |
benji | I don't think the ingest worked. Most, if not all, of the bundles were rejected by proof | 17:16 |
Makyo | Oh, hmm.. | 17:16 |
Makyo | Wonder if mine was out of date. Let me check. | 17:16 |
rick_h_ | in order for the bundles to ingest the charms involved must be loaded | 17:17 |
rick_h_ | so you have to make sure to get the charms that the bundle references ingested first | 17:17 |
hatch | jujugui I need a review on https://github.com/juju/juju-gui/pull/164 (big diff, big qa) | 17:17 |
rick_h_ | hatch: so you need two reviews then? | 17:18 |
Makyo | Oh, right, hmm. I guess I already had those loaded. | 17:18 |
hatch | rick_h_ well....it's so much in flux still that I think I'll hold off on two until it's all done | 17:18 |
hatch | but I definitely want to make sure I didn't introduce a regression on the service config view | 17:18 |
hatch | I also moved the pt1 card to the review lane | 17:18 |
rick_h_ | hatch: huh? if it's over 400 lines it's a two review branch. How's it 'hold off on two reviews'? | 17:19 |
Makyo | Amended QA: run enque with --prefix=~charmers/charms/precise --limit=100 first | 17:19 |
Makyo | That should get charms enough for at least those bundles. | 17:19 |
hatch | well it's mostly mechanical moves | 17:19 |
hatch | but sure if I can get two | 17:19 |
hatch | :) | 17:19 |
hatch | I'm held up from continuing on until this review is done though | 17:19 |
Makyo | I can review now | 17:20 |
hatch | oh ok cool | 17:20 |
hatch | thanks | 17:20 |
Makyo | That's a big diff :P | 17:25 |
Makyo | I must fortify myself with more tea. | 17:25 |
hatch | haha sorry | 17:25 |
hatch | there is a lot of mechanical changes | 17:25 |
Makyo | I do like this better, though. | 17:32 |
Makyo | Views are cleaner. | 17:32 |
hatch | much | 17:32 |
hatch | trying to wrap your head around viewlet > view databinding however.....not so clean | 17:32 |
hatch | :) | 17:32 |
hatch | there are considerable improvements we can make to databinding now that we are using views | 17:33 |
hatch | eta on that? never | 17:33 |
hatch | lol | 17:33 |
rick_h_ | :P | 17:33 |
hatch | haha | 17:37 |
hatch | anyone else use evernote on android? their new 'handwriting' thing is pretty cool - now if I Could only find a quality pen/screen-pen combo | 17:38 |
=== lazyPower_ is now known as lazyPower | ||
hatch | uh oh, I've now sent 666 tweets | 17:50 |
benji | Makyo: still ingesting charms/bundles | 17:58 |
Makyo | benji, Alright. No rush, I have another card in the mean time. | 17:59 |
bac | hatch: well i hope you take a screenshot before you tweet again | 18:03 |
hatch | should I? | 18:04 |
bac | benji or Makyo (now that we've claimed you as a charmworld dev), would one of you review https://codereview.appspot.com/69980054/ ? it started out simple in scope and then i got annoyed and did a bunch of drive-bys. | 18:04 |
Makyo | bac, sure | 18:04 |
hatch | that's just under 200 tweets per year....That's actually quite a bit for me, I didn't think I tweetered that much | 18:06 |
Makyo | *cough*35,983*cough* | 18:06 |
Makyo | Getting an intelligent telephone was the worst thing for me. :P | 18:07 |
Makyo | Never realized how much I missed Rietveld. | 18:08 |
hatch | Makyo twitter says "You follow each other" about us.....that's a little creepy | 18:10 |
Makyo | Haha | 18:10 |
hatch | you must have two twitter accounts? | 18:11 |
Makyo | I have or help manage 14 :P | 18:13 |
hatch | lol | 18:13 |
hatch | I unfollow people who tweet more than a couple times a day haha | 18:14 |
Makyo | That's fair :) | 18:14 |
hatch | which is kind of unfortunate because there is usually some gems but moreoften than not it just clutters up the feed | 18:14 |
hatch | maybe one of these days I'll setup tweetdeck or the like | 18:14 |
rick_h_ | hatch: heh, you need to follow some more python folks to get these gems https://twitter.com/zzzeek/status/441637489640747008 | 18:17 |
hatch | rofl | 18:17 |
hatch | love it | 18:17 |
hatch | rick_h_ I didn't get a +1 from you on the review. I've made the requested changes and pushed them up....is it A O K? | 18:21 |
rick_h_ | hatch: sorry, got sidetracked +1 | 18:22 |
hatch | haha ok thanks | 18:22 |
hatch | does anyone have any ideas for cool hardware hacking stuff? I was thinking quadcopter but also looking for other ideas | 18:23 |
hatch | leap motion and quad copter would be cool | 18:24 |
hatch | going all minority report flying a camo'd ar drone around the block | 18:26 |
hatch | lol | 18:27 |
bac | thanks Makyo. glad i could let you relive your rietveld days. | 18:47 |
rick_h_ | jujugui added a bug card to critical. It looks like we've got a series regression in charm search causing it to send multiple versions of the same charm overloading the db, front end, etc | 18:49 |
rick_h_ | series/serious | 18:49 |
rick_h_ | bah | 18:49 |
bac | rick_h_: a charmworld problem? | 18:49 |
rick_h_ | bac: yes, the search api is sending back waaaay too much data | 18:50 |
bac | better safe than sorry? | 18:51 |
rick_h_ | :) | 18:51 |
rick_h_ | "we didn't know if you wanted cinder r15, r16, r17, r18..have them all! | 18:51 |
bac | rick_h_: i need to add a new card for the charm-proof change. it was tiny and i'm ready to propose it. | 18:53 |
hatch | rick_h_ this is re the bug I filed about a 5.4MB response? | 18:53 |
hatch | :D | 18:53 |
rick_h_ | hatch: yep | 18:53 |
rick_h_ | hatch: finally got around to looking and prioritizing them | 18:54 |
rick_h_ | bac: ok cool | 18:54 |
rick_h_ | hatch: and yea, it's not good | 18:54 |
hatch | haha no no it is not | 18:54 |
bac | hey if you add a card directly into a full lane it doesn't ask you for justification! | 18:54 |
hatch | looking for a <1s response time....got a 20s response time lol | 18:54 |
bac | marcoceppi: could you look at this simple change to charm-tools for 'charm proof'? https://code.launchpad.net/~bac/charm-tools/bundle-proof-warnings/+merge/209754 | 19:10 |
benji | Makyo: the ingest is still running; did yours take this long? | 19:11 |
Makyo | benji, no, don't think so. Can you check if you have mysql and mediawiki yet? | 19:12 |
benji | charms or bundles? | 19:12 |
Makyo | If so, you can kill, bin/dequeue, run the enqueue in the qa instructions, then ingest again and it'll only ingest the bundles./ | 19:12 |
Makyo | Charms. | 19:12 |
benji | I have both. | 19:13 |
Makyo | Should be able to just load bac's bundles, then. | 19:13 |
benji | the API URL for the bundle still 404s though because the ingest hasn't gotten to the bundles yet | 19:13 |
benji | what do you mean by "load bac's bundles"? | 19:14 |
hatch | rick_h_ thanks for the mention on discourse re the power button lol | 19:14 |
rick_h_ | hatch: :) | 19:14 |
Makyo | benji, the commands in the QA instructions. If you empty the ingest queue with dequeue, then enqueue only his bundles with the enqueue command given, it should only ingest those. | 19:14 |
hatch | lately no powerdowns because I'm using an external keyboard haha | 19:15 |
benji | I think that's what I did. I'll try again. | 19:15 |
marcoceppi | bac lgtm | 19:29 |
benji | Makyo: when I view /api/3/bundle/~bac/wiki/3 I still get the internal error, when I view /api/3/bundle/~bac/wiki/0 I still get the "no_such_bundle" message, however when I fetch http://10.0.3.149:2464/api/3/bundle/~bac/wiki/3/wiki/file/bundles.yaml I see a bundle definition with non-fully-specified charm URLs | 19:32 |
rick_h_ | benji: it needs to be ~bac/wiki/3/wiki I thought | 19:33 |
rick_h_ | benji: ending an api call in the revision isn't a legit api endpoing I didn't think | 19:33 |
benji | rick_h_: that's what I'm saying | 19:34 |
rick_h_ | what does http://10.0.3.149:2464/api/3/bundle/~bac/wiki/3/wiki return? | 19:34 |
rick_h_ | and what are the charm definitions in ^ (if it loads) | 19:34 |
rick_h_ | in the data: key | 19:34 |
benji | rick_h_: http://paste.ubuntu.com/7045935/ | 19:35 |
benji | no "data" key | 19:35 |
rick_h_ | sorry, services | 19:36 |
rick_h_ | and that's perfect I think. Makyo confirm? ^ | 19:36 |
rick_h_ | benji: line 1113 | 19:36 |
Makyo | Yeah, that looks good. | 19:37 |
benji | heh, darn I searched for "data:" not '"data":' | 19:37 |
Makyo | Oh, yeah, boo JSON! | 19:37 |
rick_h_ | yea, it's json, must be quoted sorry I wasn't more explicit | 19:37 |
benji | QA passed then | 19:37 |
rick_h_ | but yea, all the services are legic cs: urls so yay! | 19:37 |
rick_h_ | land that branch and bury it please! :) | 19:38 |
Makyo | Okay! | 19:38 |
rick_h_ | Makyo: please make sure to update the bug if there's one on that. I don't see one associated but thuoght there was a bug | 19:38 |
rick_h_ | Makyo: maybe it was on the investigate card | 19:39 |
hatch | jujugui lf a review/qa on the constraints viewlet to view changeover https://github.com/juju/juju-gui/pull/165 | 19:39 |
rick_h_ | hatch: what's lf? | 19:41 |
hatch | looking for | 19:41 |
hatch | sheesh, when did you grow up? that's in the same tmeframe as asl | 19:41 |
hatch | :P | 19:41 |
rick_h_ | heh, yea I avoided all that | 19:42 |
hatch | I often had to google the ones gary used | 19:42 |
hatch | :) | 19:42 |
hatch | YMMV was a new one for me | 19:42 |
rick_h_ | oh <3 that one. I learned and like WCPGW | 19:43 |
rick_h_ | when I joined launchpad | 19:43 |
hatch | lolwhat's that one? | 19:43 |
rick_h_ | "what could possibly go wrong?" | 19:44 |
rick_h_ | "change all those viewlets to Views, WCPGW" | 19:44 |
hatch | lol | 19:44 |
hatch | truth! | 19:44 |
Makyo | jujugui it's lbox submit to land a charmworld branch, correct? Or is there a different step? | 20:17 |
* Makyo can't remember | 20:17 | |
bac | Makyo: bzr rv-submit | 20:17 |
Makyo | Ah, thanks | 20:17 |
bac | using the rvsubmit plugin | 20:17 |
bac | Makyo: you can't mess up. if you try 'lbox submit' it will fail due to permissions. yay. | 20:18 |
Makyo | Oh, good. | 20:18 |
bac | yeah, unless you fire-n-forget only to discover much later it errored | 20:18 |
Makyo | Whoops, conflict anyway. | 20:22 |
Makyo | Something keeps revving up my fans. Switched back over to chrome to a notice that "Google talk plugin has crash." Promising. | 21:07 |
hatch | yeah that thing is a huge battery hog | 21:16 |
hatch | sometimes it'll just sit in the background burning cycles for fun | 21:16 |
* hatch grumbles about cascading test failures | 21:43 | |
rick_h_ | no grumbling | 21:45 |
hatch | I'm pretty sure it's ok to grumble about this | 21:46 |
rick_h_ | come on, close to EOD, no grumbling :) | 21:47 |
hatch | I supppooooose | 21:47 |
hatch | well I gots no idears why this one is causing the failure | 21:51 |
hatch | well THAT was a stupid mistake | 21:58 |
* hatch blames my qa'er for missing it | 21:58 | |
rick_h_ | what did I miss? | 21:58 |
rick_h_ | I even found a bug in the last qa | 21:58 |
rick_h_ | I was feeling good | 21:58 |
hatch | in the viewlet base view extension I had the _eventHandles and changedValues property as prototype properties so they were shared across every viewlet | 21:59 |
hatch | where they should have been instance level properties | 21:59 |
rick_h_ | oh...hmm guess I didn't test out multiple inpsectors/ghosts and noticed | 21:59 |
hatch | it's ok I missed it and I've done 3 branches since then lol | 22:00 |
rick_h_ | heh, better now than figuring it out later I guess | 22:01 |
hatch | yeah that would have been a tough one to find | 22:02 |
hatch | so in this case....cascading test failures was a GOOD thing | 22:02 |
hatch | lol | 22:02 |
rick_h_ | wheeee! | 22:02 |
hatch | I also found out why my wifi sucked so bad sometimes (even after the new router) | 22:03 |
hatch | the wifi antenna must be in the screen of MBP's and when the screen is closed the reception is crap (even though it shows full bars) | 22:03 |
rick_h_ | ? | 22:03 |
rick_h_ | oh, interesting | 22:03 |
rick_h_ | I think it just sucks myself. Every time I wake it up it takes so long | 22:03 |
hatch | I'll test it over the next couple days to see if the slow internet issue comes back after opening the lid | 22:04 |
rick_h_ | I was really hoping I'd fall in love with this air because of the lennovo issues but :( | 22:04 |
hatch | oh yeah - if it's in sleep mode half the time it won't come back hah | 22:04 |
hatch | the good news is that it's a software issue - people who install windows don't have that issue | 22:04 |
hatch | so a on-metal install of Ubuntu may also solve the issues | 22:04 |
rick_h_ | yea, I'm hoping to compare linux on it | 22:04 |
rick_h_ | yea, we'll see :/ | 22:04 |
rick_h_ | but the keyboard and wifi issues on the air really lose it poits | 22:05 |
hatch | I really hope someone fixes that kernel bug | 22:05 |
rick_h_ | points | 22:05 |
hatch | oh yeah - and the new MBP has the same keyboard - I thought it was the same as the old MBP keyboards....but I was wrong :( | 22:05 |
hatch | I was hoping for a little more concave keys with some more travel | 22:05 |
rick_h_ | exactly, they're too soft and mushy | 22:06 |
rick_h_ | and the travel definitely needs a bit more | 22:06 |
rick_h_ | after a few days I go "oh, it's not so bad" | 22:06 |
rick_h_ | then I pull out my x230 and start typing "whoa, this is so great" | 22:06 |
rick_h_ | I do love the air size though. In the backpack, carrying around the house | 22:07 |
rick_h_ | makes me ponder that 13" xps more | 22:07 |
hatch | yeah - it's a little sharp to carry around a conference lol | 22:07 |
rick_h_ | but I hear the keyboard there isn't great either | 22:07 |
rick_h_ | if the wifi would come back up faster it'd be a great conference machine | 22:08 |
rick_h_ | but you close it, go to the next room, and open it and hang for 5min before you can get into your google doc | 22:08 |
hatch | oh mine isn't THAT bad | 22:08 |
hatch | it just sometimes never comes up | 22:08 |
hatch | else it's about 30s to a min | 22:09 |
rick_h_ | it comes up eventually, but only after it hangs and shows that 'finding signal' animation for minutes | 22:09 |
hatch | interesting... | 22:11 |
hatch | I wonder if that's because it's a referb? | 22:11 |
hatch | jujugui lf a review on the ghost inspector viewlet to view conversion https://github.com/juju/juju-gui/pull/166 | 22:11 |
rick_h_ | hatch: will look tonight sometime and try to qa better. | 22:12 |
hatch | oh poop | 22:12 |
hatch | I think I screwed up the commits | 22:12 |
hatch | sec | 22:12 |
hatch | ok fixed | 22:13 |
hatch | rick_h_ you know your email is the jujugui bot email :) | 22:13 |
rick_h_ | yea, someone had to sign up | 22:13 |
hatch | ohh ok I thought that was by accident instead of some secondary email | 22:13 |
rick_h_ | hmm, does everyone else not get the pull request messages? | 22:13 |
hatch | nope | 22:14 |
hatch | well.. | 22:14 |
rick_h_ | oh, hmm. Maybe I should try to change that then | 22:14 |
hatch | ok no we do | 22:14 |
hatch | sorry I just always miss them heh | 22:14 |
hatch | rick_h_ I don't think CI is being run anymore on new PR's | 23:38 |
hatch | https://github.com/juju/juju-gui/pull/166 this is still showing 'Waiting to hear...' | 23:39 |
hatch | ohh | 23:39 |
hatch | CI is hung | 23:39 |
hatch | heh | 23:39 |
hatch | Started 10 hr ago | 23:39 |
hatch | Build has been executing for 10 hr | 23:39 |
hatch | killed that one....now lets see if it catches up over the next couple hours :) | 23:40 |
rick_h_ | hatch: cool yea. It did that the other day. There was a nework issue between CI and saucelabs and it just hung | 23:43 |
hatch | ohh, are we being throttled by sauce labs maybe? | 23:44 |
hatch | too many runs on an oss account | 23:44 |
hatch | maybe we can get the juju logo on https://saucelabs.com/opensauce :) | 23:45 |
hatch | ohhh https://saucelabs.com/docs/status-images | 23:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!