| === OutOfControl is now known as benonsoftware | ||
| frankban | rogpeppe: ping. any chance to get my branch reviewed soon? That's blocking some tasks on our side, and it would be nice to know if it's in the queue (sorry to bother you). | 10:08 |
|---|---|---|
| rogpeppe | frankban: sorry, i will do - i've been concentrating on moving HA forward | 10:09 |
| frankban | rogpeppe: thanks! | 10:10 |
| rogpeppe | frankban: link? | 10:11 |
| frankban | rogpeppe: https://codereview.appspot.com/77420043 | 10:11 |
| frankban | rick_h_: bug 1210035 describes our exact issue | 11:03 |
| _mup_ | Bug #1210035: event stream from watcher should have logical ordering. <juju-core:Triaged> <juju-gui:Triaged> <https://launchpad.net/bugs/1210035> | 11:04 |
| rick_h_ | frankban: ah nice | 11:35 |
| marco-traveling | rick_h_: is there a way to show icons for non promulgated charms in the gui? Got a demo today | 11:36 |
| rick_h_ | marco-traveling: no, it's not working yet. There's a bug in it that I've not gotten a chance to look into | 11:36 |
| * marco-traveling considers shot-gun promulgation and unpromulgation shortly after | 11:36 | |
| * marco-traveling reconsiders and wont' be dumb | 11:37 | |
| * frankban lunches | 12:14 | |
| bac | rick_h_: 1:1? | 13:00 |
| rick_h_ | bac: yea, did I join the wrong room? | 13:00 |
| bac | no, i'm just joining now | 13:01 |
| rick_h_ | bac: ah gotcha | 13:01 |
| hatch | relocating | 14:10 |
| hatch | it's sure quiet out there | 14:20 |
| rick_h_ | sshhhhh | 14:21 |
| rick_h_ | frankban: found out 1.17.5 isn't going into trusty due to juju-mongodb breakage. We need to wait/watch for 1.17.6 and sinzui is looking at getting that out asap | 14:33 |
| frankban | rick_h_: ack, thanks | 14:34 |
| frankban | rick_h_: is Matthew out today? | 14:36 |
| rick_h_ | frankban: not that I know of, /me looks | 14:36 |
| rick_h_ | frankban: not that I know | 14:38 |
| frankban | rick_h_: ok thanks | 14:38 |
| frankban | rick_h_: I'd be inclined to land https://github.com/juju/juju-gui/pull/186 if the test passes, it's difficult to QA because the bug can be intermittent, but I duped that several times | 14:39 |
| rick_h_ | frankban: looking | 14:40 |
| rick_h_ | frankban: k, if you're confident go ahead. | 14:41 |
| frankban | rick_h_: cool | 14:41 |
| Makyo | frankban, rick_h_ I wasn't able to dupe when I tried, but the code LGTM. Sorry frankban | 14:43 |
| rick_h_ | Makyo: thanks for the +1 | 14:43 |
| frankban | Makyo: ack, thanks | 14:44 |
| Makyo | jujugui call in 10 | 14:50 |
| hatch | hm hmm hhmm hhmmm hhhmmm | 14:53 |
| bac | benji or rick_h_: could you review my branch when you get a chance? it's almost 800 lines so maybe two reviews would be good. https://codereview.appspot.com/78220043/ | 14:55 |
| bac | note there are reviewer notes, but they only show for patch set 1 | 14:55 |
| benji | bac: sure; I'll do it after the call | 14:55 |
| rick_h_ | bac: k, will do. Will be a few I've got a call after the standup and then can look | 14:55 |
| bac | thanks | 14:56 |
| Makyo | jujugui call in 2 | 14:58 |
| rick_h_ | kadams54: found his way back today? | 14:58 |
| hatch | https://plus.google.com/hangouts/_/72cpiitf46rduhiu3ruoe0jl0c?hl=en | 15:08 |
| hatch | ^ rick_h_ | 15:09 |
| kadams54 | jujuhelp any volunteers for a pre-implementation chat on https://bugs.launchpad.net/juju-gui/+bug/1269381 ? | 15:11 |
| _mup_ | Bug #1269381: keybinding for centering canvas is actually S-) <bitesize> <juju-gui:In Progress by kadams54> <https://launchpad.net/bugs/1269381> | 15:11 |
| kadams54 | Bah | 15:11 |
| kadams54 | guihelp any volunteers for ^^^ | 15:11 |
| Makyo | kadams54, sure. | 15:12 |
| hatch | relocating | 15:35 |
| hatch | man chrome is a power hog | 15:46 |
| hatch | who still needs a roomie for the sprint? | 16:15 |
| Makyo | I'm free, if you're game again. | 16:34 |
| hatch | added! | 16:43 |
| rick_h_ | ruh roh | 16:49 |
| rick_h_ | Makyo: will be asking for a new room by Tues night :P | 16:49 |
| rick_h_ | those canadians | 16:50 |
| Makyo | I'm just curious to see what the topic of late-night research will be this time. | 16:50 |
| rick_h_ | lol | 16:50 |
| Makyo | Last time it was "Which MacBook should I get?" | 16:50 |
| hatch | lol | 16:51 |
| hatch | that's a whole month away now | 16:52 |
| hatch | who knows what's going to happen by then | 16:52 |
| hatch | atm I'm trying to find a solution to hosting a bunch of basic websites with having to get a vps with cpanel | 16:52 |
| hatch | 'a bunch' being ~5 :) | 16:53 |
| Makyo | I use Linode and DreamHost (the latter mostly for a crapload of cheap wordpress sites) | 16:54 |
| hatch | yeah that's basically what these are | 16:55 |
| hatch | dreamhost hey.... | 16:55 |
| hatch | $9/mo.....too much :P | 16:56 |
| hatch | ohh that is for unlimited domains | 16:56 |
| hatch | ok now we are talkin | 16:56 |
| hatch | all of these sites maybe get 500 views per month so we aren't talking big load here lol | 16:56 |
| rick_h_ | s3 | 16:57 |
| hatch | views per month....combined :) | 16:57 |
| Makyo | Reasonable uptime, cheap, nice enough panel, unlimited DBs/domains/subdomains, django/rails-able... that's about it, granted. I wouldn't host anything too crazy there. | 16:57 |
| rick_h_ | http://docs.aws.amazon.com/AmazonS3/latest/dev/WebsiteHosting.html | 16:57 |
| hatch | innnteresting | 16:57 |
| Makyo | I'd use S3 for static sites, though. | 16:58 |
| rick_h_ | or at that rate, put them in github projects and let them host it | 16:58 |
| rick_h_ | if it's static that is | 16:58 |
| hatch | they have real domains though | 16:58 |
| Makyo | Well, you can do that with S3 too. | 16:58 |
| rick_h_ | but yea, I've used s3 for hosting static docs and it's about as cheap as you can get | 16:58 |
| Makyo | And GH Pages, for sure. | 16:58 |
| rick_h_ | and no server maint overhead | 16:58 |
| hatch | GH pages doesn't allow real domain names though | 16:58 |
| hatch | or do they now? | 16:58 |
| rick_h_ | s3 does | 16:58 |
| Makyo | They do now, I believe. | 16:59 |
| Makyo | But yeah, that or S3 for static. DH for cheap one-offs like WP or ZenPhoto or something, Linode or EC2 for other things. | 16:59 |
| hatch | interesting, I'll have a look at both those options | 16:59 |
| hatch | heh yeah S3 does look pretty cheap for static sites | 17:00 |
| rick_h_ | bac: did you have routes updates for the delete urls? Or am I blind to them atm? | 17:01 |
| rick_h_ | benji: are you looking into QA on it? | 17:02 |
| benji | I am not doing QA. I can though. | 17:02 |
| rick_h_ | benji: that'd be great if you get a few min to qa please. | 17:03 |
| benji | rick_h_: sure. I'll have to be after lunch though (which I am just about to start). Is that ok bac? | 17:04 |
| rick_h_ | benji: ty much | 17:04 |
| bac | sure benji | 17:25 |
| bac | rick_h_: yes, routes.py changed. do you not see it? | 17:25 |
| rick_h_ | bac: sorry I do see it. Must have just been blind sorry | 17:26 |
| rick_h_ | wow, /me rubs eyes | 17:26 |
| bac | rick_h_: what do you mean by "The links and bundle warning"? | 17:34 |
| rick_h_ | bac: sorry, in my other comment I replied to your last minute question on removing charms that a bundle depends on | 17:36 |
| rick_h_ | bac: so I was saying that a warning in the charm delete confirmation that these bundles will be affected would be cool imo. What did you think? Those could be links to the bundles if you wanted to remove them as well | 17:37 |
| bac | rick_h_: oh, ok. that might make a good follow on branch. | 17:38 |
| rick_h_ | bac: right, that's what I was trying to say poorly | 17:38 |
| bac | okey doke | 17:39 |
| rick_h_ | jujugui the evening AU call will likely be pushed back 30min. If anyone want to join feel free but it'll be after I kick someone out of the house vs right at 6:30 | 17:51 |
| kadams54 | AU call? | 17:51 |
| hatch | I'll try and make it | 17:51 |
| rick_h_ | australia sorry | 17:52 |
| hatch | Huw lives in Australia | 17:52 |
| hatch | huwshimi | 17:52 |
| rick_h_ | kadams54: I'll mention it on our 1-1 | 17:52 |
| rick_h_ | optional call every week | 17:52 |
| kadams54 | Got it | 17:52 |
| kadams54 | Getting re-acquainted with YUI here; been 5 years since I last used it. If I have a NodeList, what's the best way to check for a string within each Node.text? myList.each() with a function that sets a found flag? | 17:59 |
| hatch | kadams54 5 years...so that would have been YUI2 :) | 18:00 |
| kadams54 | Yeah | 18:00 |
| kadams54 | 3 was just on its way out | 18:00 |
| kadams54 | I read through a lot of the docs and was familiar with the big changes | 18:00 |
| kadams54 | But never got to write any code with 3 | 18:01 |
| kadams54 | It looked like a really good overhaul | 18:01 |
| hatch | list.each(function(node) { if (node.get('text') === 'foo') { ... } }); | 18:01 |
| hatch | yeah it was a complete rewrite | 18:01 |
| kadams54 | Yeah, that's my approach; good to know I didn't miss anything in the docs. | 18:01 |
| rick_h_ | kadams54: in the hangout when you're ready | 18:02 |
| hatch | jujugui looking for a review for https://github.com/juju/juju-gui/pull/188 thanks | 18:06 |
| hatch | stepping away for lunch | 18:16 |
| rick_h_ | hatch: when you get back I'll trade you a review for a look at the new urgent maint card please? | 18:41 |
| rick_h_ | hatch: seems there's a potential error when using our vagrant image to install quickstart per the quickstart docs. I want to see if it's a doc issue or something we need to fix in quickstart please. | 18:41 |
| hatch | rick_h_ back | 18:58 |
| hatch | rick_h_ so you are saying the GUI's vagrant image or the Juju one? | 18:59 |
| rick_h_ | hatch: cool, kadams54 ran into an issue when using quickstart from the vagrant image. You've run the vagrant stuff right? | 18:59 |
| rick_h_ | hatch: the GUI one, but the idea was that quckstart didn't run per docs in that image | 18:59 |
| hatch | yeah but I don't use the GUI's image for anything but the gui | 18:59 |
| hatch | I can look into it though | 18:59 |
| rick_h_ | hatch: and I want to verify if it's something we don't have to worry about because it's vagrant specific, or a real bug to deal with | 19:00 |
| hatch | ok, do we have official quickstart docs somewhere I can follow? | 19:00 |
| rick_h_ | kadams54: can you link hatch the steps you followed please? | 19:00 |
| hatch | preferably the steps kadams54 took | 19:00 |
| hatch | :) | 19:00 |
| rick_h_ | jujugui I'm running out to the dentist...biab | 19:00 |
| kadams54 | hatch: https://launchpad.net/juju-quickstart | 19:01 |
| hatch | ahh ok | 19:01 |
| kadams54 | Specifically, the part that starts: "To install and start Juju Quickstart, run the following:" | 19:01 |
| kadams54 | I ran those in a fresh vagrant image. | 19:02 |
| kadams54 | In the juju-gui code | 19:02 |
| hatch | ok and what was the issue? | 19:02 |
| hatch | ohh i see | 19:03 |
| hatch | it won't run :) | 19:03 |
| kadams54 | Yeah, it was a python error | 19:03 |
| kadams54 | Couldn't find a particular class | 19:03 |
| kadams54 | I can reproduce and get the exact error if needed | 19:03 |
| hatch | nope I got it | 19:04 |
| hatch | I might have a sollution | 19:04 |
| hatch | just trying now | 19:04 |
| hatch | kadams54 ok two things to try | 19:07 |
| hatch | `sudo pip install --upgrade urwid` | 19:07 |
| hatch | and/or `sudo apt-get install python-dev` | 19:08 |
| rick_h_ | hatch: yea, that's a bug then. We can't fetch pip urwid to make it work. Or else we need to make sure we don't support the older ubuntu version | 19:08 |
| * rick_h_ hasn't left yet...boy is brushing teeth wheeee | 19:08 | |
| hatch | rick_h_ why can't we? /me doesn't know much about pip | 19:09 |
| benji | bac: I'm afraid I have to cut bait on the QA: my charmworld LXC is messed up because of my low-disk condition the other day and I've spend an hour trying to fix it | 19:09 |
| hatch | benji sounds like you need a new machine | 19:10 |
| hatch | :) | 19:10 |
| bac | hatch: shh, he's touchy | 19:10 |
| hatch | ohh ok :) | 19:10 |
| benji | I need a linux distribution that doesn't want more than 10 gig. | 19:10 |
| bac | benji: ok. i've discovered my bundle featured link is borked. i'll fix that then land | 19:10 |
| bac | benji: RHEL? | 19:10 |
| hatch | lol | 19:11 |
| * benji installs Puppy Linux | 19:11 | |
| benji | hmm, if OpenBSD will run virtualbox, I might do that (only half kidding) | 19:11 |
| rick_h_ | bac: I can try out QA when I get back | 19:12 |
| hatch | ssd's aren't that expensive anymore :) | 19:12 |
| rick_h_ | hatch: because it should apt-get install without extra things | 19:12 |
| rick_h_ | hatch: can you file a high bug on quickstart and add it to the urgent lane please? | 19:12 |
| rick_h_ | or use that same card | 19:12 |
| hatch | rick_h_ understood, on it | 19:12 |
| bac | rick_h_: you want i should wait for your qa? i'm ok either way. | 19:14 |
| Makyo | I can QA, too, in a pinch. | 19:15 |
| hatch | rick_h_ bug & card created | 19:20 |
| hatch | kadams54 so are you up and running with quickstart now? | 19:28 |
| kadams54 | No | 19:28 |
| hatch | more errors? | 19:29 |
| kadams54 | Haven't tried it yet | 19:29 |
| hatch | ohh hah ok | 19:29 |
| kadams54 | I'll give it a whirl in a bit and let you know how it goes… | 19:29 |
| kadams54 | OK, newb question: how to run a single test? I tried just running mocha straight up and got an error about the GlobalConfig object not being defined. | 19:31 |
| hatch | oh...yeah | 19:32 |
| hatch | sorry our test suite is....odd | 19:32 |
| kadams54 | lol | 19:32 |
| hatch | it.only() vs it() | 19:32 |
| hatch | describe.only() vs describe() | 19:32 |
| hatch | make test-debug | 19:32 |
| hatch | then it'll only run the test with .only | 19:32 |
| kadams54 | The test I modified is not a .only | 19:33 |
| hatch | it will be once you add it :) | 19:33 |
| bac | Makyo: if you are still offering, would you mind doing the QA for https://codereview.appspot.com/78220043/ ? i'd like to get this out of my hair | 19:33 |
| Makyo | bac, sure, on it/. | 19:33 |
| bac | Makyo: it is charmworld and you'll need to ingest some bundles | 19:33 |
| hatch | it.only('this test does something', function() { ... }); for example | 19:33 |
| Makyo | Can do. | 19:33 |
| hatch | kadams54 if you are running a single test/suite a number of times, it'll be faster to use `make test-server` because the browser will cache the dependencies whereas phantomjs doesn't | 19:34 |
| kadams54 | OK | 19:34 |
| hatch | the url for the test suite in that case is 192.168.33.10:8888/test/index.html | 19:35 |
| bac | Makyo: http://paste.ubuntu.com/7126893/ might be a good minimal set that is not too time consuming | 19:36 |
| Makyo | bac, should have some already ingested from previous work, but thanks, will do that if not. | 19:36 |
| hatch | rick_h_ I looked at huw's branch and it'll be easier for him to fix it in his fork than us try to do it externally so I can help him when he gets him | 19:36 |
| hatch | kadams54 if you can't get it we can have a hangout and I can guide you through it | 19:37 |
| kadams54 | I got it - my test is failing :-) | 19:37 |
| hatch | awesome - at least you know it fails :) | 19:37 |
| kadams54 | Out of curiosity, has anyone looked at getting a test runner like testem or karma working with the code? | 19:38 |
| hatch | kadams54 yes but priorities.... | 19:38 |
| hatch | :( | 19:38 |
| kadams54 | Yup, I understand… | 19:39 |
| hatch | it's very legacy, the suite was setup well before i started | 19:39 |
| kadams54 | I like that JS test code written in Mocha is "legacy" :-) | 19:39 |
| hatch | lol | 19:39 |
| hatch | it's over a year old....it's legacy | 19:39 |
| hatch | haha | 19:39 |
| kadams54 | totally | 19:39 |
| kadams54 | Sometimes the JS world is like that | 19:40 |
| hatch | we really want to get code coverage up and running as well | 19:40 |
| Makyo | Yes. Good. https://jujucharms.com/sidebar/search/precise/nyancat-3/?text=nyancat | 19:40 |
| Makyo | Just what we needed. | 19:40 |
| hatch | Makyo rofl | 19:40 |
| kadams54 | I only just found out that Grunt is now old school. | 19:40 |
| hatch | lol yeah the hype machine moved to Gulp | 19:41 |
| Makyo | Scalable cloud-based Nyancat telnet server, ready for EC2 and HP Cloud. | 19:41 |
| hatch | kadams54 although I think Gulp and Grunt serve two different purposes....the hype machine don't care :P | 19:41 |
| hatch | Makyo somehow it got recommended without an icon *gasp* | 19:42 |
| Makyo | Haha | 19:42 |
| Makyo | Well, bit of a bug. Lemme see if I can get it on vine or something. | 19:45 |
| hatch | Makyo do you know anything about moving the inspector into the side panel? | 19:46 |
| hatch | as in, what happens to the url when we render it in there? | 19:46 |
| Makyo | hatch, https://docs.google.com/a/canonical.com/document/d/1QSYjfcAwg54zZMJyGAOo-bqVnnLZJ55dd0UZGMDf9Ig/edit | 19:46 |
| Makyo | EG /inspector/apache2/service | 19:46 |
| hatch | like a boss | 19:47 |
| hatch | oh wait, this card is to update the inspectors to gfit | 19:47 |
| hatch | blarg | 19:47 |
| hatch | ok nm I get it now | 19:48 |
| Makyo | jujugui little silly, but worth mentioning, since it happens at default window height in chrome on a 13" display for me: https://bugs.launchpad.net/juju-gui/+bug/1295341 | 19:54 |
| _mup_ | Bug #1295341: GUI stutters on charm details if window isn't tall enough to scroll very far <juju-gui:New> <https://launchpad.net/bugs/1295341> | 19:54 |
| hatch | Makyo "Could not locate object" in u1 | 19:55 |
| Makyo | Yeah I forgot to make it public, sorry x.x | 19:55 |
| Makyo | http://ubuntuone.com/7eJkrPv3NwWJ609FUuoEsA | 19:56 |
| Makyo | Edited bug to reflect that. | 19:56 |
| Makyo | Nice, it's upside down. | 19:56 |
| hatch | lol | 19:57 |
| hatch | ok I think I know what's happening there | 19:57 |
| hatch | should be easy enough to fix | 19:57 |
| Makyo | Should just be a min-height right? | 19:57 |
| hatch | yep | 19:57 |
| hatch | (famous last words) | 19:57 |
| Makyo | bac, +1 | 20:02 |
| Makyo | hatch, preferably only if it's already scrolling, though, right? | 20:03 |
| bac | Makyo: coolio. could you add to RV? | 20:03 |
| Makyo | Did | 20:03 |
| hatch | Makyo well when the header shrinks it then pulls the scroll away so it expands again | 20:04 |
| bac | Makyo: did i ask you about the github os x tool? do you use it? | 20:04 |
| Makyo | hatch, oh, right. | 20:04 |
| hatch | so either setting the min-height of the content to 'something' or adding to the height when the header gets minimized would work | 20:04 |
| Makyo | bac, I've only used the windows one, which was okay! | 20:05 |
| Makyo | bac, let me try the osx one, might as well. | 20:05 |
| bac | this one looks good. but i'm afraid it'll just be a crutch. | 20:05 |
| bac | but i thought i'd try it since i need to do the vagrant thing | 20:05 |
| Makyo | Yeah. Having learned git on the cli, I found it got in the way more than helped on windows, but that was...a year ago? Maybe better now | 20:06 |
| hatch | I have been trying to use the git/gist plugins in sublime now for my gitting but any real git work still works better in the cli imho | 20:07 |
| hatch | benji I can take over for your card | 20:08 |
| kadams54 | Any particular format for commit messages? | 20:08 |
| benji | hatch: cool | 20:08 |
| kadams54 | Aside from the normal Git conventions… | 20:08 |
| hatch | kadams54 no porn | 20:08 |
| kadams54 | lol | 20:08 |
| Makyo | Pff | 20:08 |
| Makyo | kadams54, nah, no format. | 20:09 |
| hatch | lol | 20:09 |
| Makyo | kadams54, we try to rebase before initial proposal. | 20:09 |
| kadams54 | Yeah, this ticket only has one commit :-) | 20:09 |
| Makyo | Bonus~ | 20:09 |
| hatch | yes rebasing is the git holy war :) we are firmly on the 'rebase out checkpoint commits into logical commits' camp | 20:10 |
| kadams54 | Had a similar workflow on the previous job: task branch, rebase to cleanup commits | 20:10 |
| hatch | awesome | 20:10 |
| Makyo | Yeah. Don't need to go all out (reduces the need for push -f that way, and leaves comments on old commits) | 20:11 |
| hatch | kadams54 I also use a tool called 'grb' but we also have a few aliases in the hacking docs to simplify some things if you prefer | 20:11 |
| hatch | rick_h_ probably mentioned this already though | 20:11 |
| Makyo | Everything git makes for osx is huge. | 20:13 |
| Makyo | Their client is 18MB zipped. | 20:13 |
| Makyo | Atom was 110 or something. | 20:13 |
| hatch | probably all the HIDPI assets? | 20:13 |
| Makyo | Ohhh, right | 20:14 |
| hatch | for us elitist retina people | 20:14 |
| Makyo | Pff | 20:14 |
| kadams54 | I'm a big fan of git_remote_branch | 20:14 |
| Makyo | Oh, by the way, I still have atom.io and keybase.io keys if anyone's interested. | 20:14 |
| hatch | hah suckit people +1 for team grb! | 20:14 |
| hatch | :P | 20:14 |
| hatch | hmm atom doesn't interest me but keybase does | 20:15 |
| Makyo | Email? | 20:15 |
| bac | hatch Makyo: git question. trying to get repo setup on os x. when i run 'git sync-juju' i get queried for github username/password. i enter 'bac' and my password but get auth failure. Q: any idea why? Q: i've got a valid token in my .gitconfig, so why is it asking? | 20:15 |
| kadams54 | Funny story that I probably shouldn't tell on my second day: shortly after I started my last job, we migrated from SVN to git. One day I was assigned to do some branch cleanup work, so I grabbed grb and started to work. | 20:15 |
| hatch | Makyo pm'd | 20:15 |
| bac | Makyo: atom.io pls | 20:15 |
| hatch | bac you need to have your ssh keys setup | 20:16 |
| bac | hatch: done | 20:16 |
| Makyo | bac, Are you checking out using https? Should work with ssh (git@github.com:juju/juju-gui) with ssh keys | 20:16 |
| kadams54 | I figured that "grb delete" would let me specify which branch I wanted to delete, so I switched out of the soon-to-be-deleted branch and back on to master. Then I ran it. | 20:16 |
| kadams54 | And deleted master. | 20:16 |
| hatch | lol ouch! | 20:16 |
| bac | Makyo: i cloned my repo fine. it is the 'git sync-juju' step | 20:16 |
| kadams54 | After that, nobody else on the team ever gave grb a try. | 20:16 |
| kadams54 | ;-) | 20:16 |
| hatch | haha | 20:16 |
| Makyo | bac, Oh, hmm. Is your juju remote https maybe? | 20:16 |
| Makyo | git remote -v | 20:16 |
| kadams54 | Fortunately, since it's version control, I was able to revert the branch deletion. | 20:17 |
| kadams54 | But that's my "screwed production up" story | 20:17 |
| bac | Makyo: yes, https | 20:17 |
| Makyo | bac, git remote set-url juju git@github.com:juju/juju-gui | 20:17 |
| Makyo | bac, invited | 20:18 |
| Makyo | Sent it to work address, hope that works | 20:18 |
| kadams54 | Alright, I'm ready to submit my first pull request… I think? | 20:19 |
| bac | Makyo: https://pastebin.canonical.com/106892/ | 20:19 |
| Makyo | bac, oh, sorry. git remote seturl origin git@github.com:bac/juju-gui.git | 20:20 |
| bac | Makyo: that was it, thanks | 20:21 |
| bac | Makyo: fwiw, i checked out that repo using the github gui tool. | 20:21 |
| Makyo | Oh, boo. Wonder if there's an option to prefer ssh | 20:22 |
| bac | Makyo: no invite yet. assume it'll arrive eventually. thanks, though. | 20:22 |
| Makyo | Oh, says it's "queued" | 20:22 |
| hatch | kadams54 on it | 20:23 |
| hatch | btw typically you would say something like "jujugui looking for a review on <link>" :) | 20:24 |
| kadams54 | Will do | 20:24 |
| hatch | kadams54 and now you would move your card into the "Review List" column | 20:26 |
| BradCrittenden | Makyo: for atom do you just get two invites or do they refill? | 20:32 |
| === BradCrittenden is now known as bac | ||
| Makyo | bac, I had three, when I invited you today, so I'm assuming they refill eventually | 20:32 |
| hatch | kadams54 review done | 20:40 |
| hatch | so basically what these symbols mean is: | 20:40 |
| hatch | :+1: you can land it | 20:40 |
| hatch | QA OK qa was ok | 20:41 |
| hatch | 'with trivials' means that you can land it with the trivial changes made | 20:41 |
| Makyo | Land by using :shipit: in a comment | 20:41 |
| hatch | and then of course answer any lagging questions in the review comments | 20:41 |
| hatch | I usually rebase my changes back into the stack so I don't have a 'review changes commit' but that's personal preference | 20:42 |
| hatch | what's the format of the service config yaml files? is it simply: | 21:04 |
| hatch | name | 21:04 |
| hatch | value | 21:04 |
| hatch | ? | 21:04 |
| bac | hatch: i'm looking at the juju-quickstart /urwid problem | 21:07 |
| hatch | oh kay | 21:07 |
| bac | hatch: it doesn't seem to affect trusty. | 21:07 |
| bac | and i'm unsure what to do for raring. it is a packaging issue. | 21:07 |
| hatch | trusty probably has a more updated version | 21:07 |
| bac | i think we'd have to backport urwid and make a PPA for it | 21:07 |
| hatch | ick | 21:08 |
| hatch | can quickstart run pip install? | 21:08 |
| hatch | well I mean | 21:08 |
| hatch | do we want it to | 21:08 |
| bac | i think not | 21:08 |
| hatch | the odd thing is what I am running quickstart on precise without issue....maybe it's an older version? | 21:08 |
| bac | you don't really want to mix ubuntu packages and pip | 21:08 |
| hatch | yeah true | 21:08 |
| bac | i'm eod, so i'll have a round with fb tomorrow and figure it out | 21:09 |
| hatch | bac what about checking the urwid version, if it's too old then not allow -i ? | 21:09 |
| bac | s/fb/frankban/ | 21:09 |
| bac | the PPA solution is probably not hard | 21:09 |
| bac | anyway, see you all tomorrow | 21:10 |
| hatch | well as long as we can get it into the same juju repo | 21:10 |
| hatch | yep have a good one | 21:10 |
| hatch | now with everyone EOD'ing so early I want to quit earlier hah | 21:11 |
| bac | hatch: well stop sleeping in! | 21:12 |
| rick_h_ | hatch: hah, you must keep going! | 21:12 |
| hatch | haha | 21:12 |
| rick_h_ | bac: thanks for looking. Yep I assume it's packaging and we either need to not support an older release or update a ppa to support it | 21:12 |
| hatch | I'd much rather prefer the latter | 21:13 |
| rick_h_ | hatch: yea, have to figure out what options is available | 21:14 |
| bac | can't we just update our vagrant to be trusty? problem solved! | 21:14 |
| * bac really gone now | 21:14 | |
| hatch | rick_h_ btw I took over benji's card, just finishing up the functionality now then to write tests | 21:14 |
| rick_h_ | bac: :P | 21:14 |
| rick_h_ | hatch: ok awesome thanks | 21:14 |
| rick_h_ | hatch: sorry for quiting mid-review of your branch | 21:14 |
| rick_h_ | I'll try go look here shortly. Past EOD but I've got meetings and interviews tonight so will be in/out | 21:14 |
| hatch | heh np - I also took a look at huw's git issues | 21:15 |
| hatch | he shoudl be able to fix on his side with `git rebase develop` then rebase his commits | 21:15 |
| hatch | but I can guide him through when he gets in | 21:15 |
| rick_h_ | hatch: awesome, yea if you can help with that I'd love to get htat card cleared so he can move on | 21:15 |
| rick_h_ | the help delay is hurting on that a bit | 21:15 |
| hatch | now to figure out what the yaml format is for service configs | 21:15 |
| rick_h_ | look at a config.yaml? | 21:16 |
| hatch | got it | 21:17 |
| hatch | we have a config.yaml? | 21:17 |
| hatch | nice | 21:17 |
| hatch | lol | 21:17 |
| kadams54 | hatch: FWIW, I finally got around to trying the fixes you posted and I can now run juju-quickstart successfully. | 21:18 |
| kadams54 | Had to do both though - got compile errors due to missing Python.h if I didn't have python-dev installed | 21:18 |
| rick_h_ | kadams54: ugh yea that's what we need to avoid | 21:19 |
| rick_h_ | that's ok for a dev env, but not for a production instructions | 21:19 |
| hatch | kadams54 excellent | 21:19 |
| hatch | yeah quickstart probably shouldn't require python-dev :) | 21:19 |
| kadams54 | That's one hell of a dependency :-) | 21:20 |
| kadams54 | Hmm, I spoke too soon. I ran into one other error during provisioning: | 21:24 |
| kadams54 | cp: cannot stat '/usr/lib/locale/locale-archive': No such file or directory; failed to execute template 'ubuntu-cloud'; aborted | 21:24 |
| hatch | kadams54 so now that your branch has passed review and qa and CI you can comment with a message with :shipit: in the PR and CI will land it | 21:27 |
| hatch | kadams54 are you trying to run lxc in vagrant? | 21:27 |
| kadams54 | I suspect so :-) | 21:28 |
| hatch | well typically you thank the reviewer(s) (/me bows) and then :shipit: | 21:28 |
| rick_h_ | hatch: hah! | 21:28 |
| hatch | lol | 21:28 |
| kadams54 | I just went with the default option in the dialog that come up, something about provisioning a new environment | 21:28 |
| rick_h_ | but he's right | 21:28 |
| kadams54 | Which I'm guess goes with lxc? | 21:29 |
| hatch | kadams54 yeah I don't think vagrant images support lxc - you'll probably have to set up an ec2 account | 21:29 |
| rick_h_ | hmm, does the vagrant thing support lxc and the like? I'd assume so | 21:29 |
| hatch | yeah lxc is not installed in my image | 21:30 |
| hatch | but juju is | 21:30 |
| rick_h_ | hatch: yea, you have to install lxc-local which the latest (blocked) quickstart does | 21:30 |
| rick_h_ | sorry | 21:31 |
| rick_h_ | juju-local | 21:31 |
| hatch | ^ kadams54 | 21:31 |
| kadams54 | Shipped… | 21:33 |
| rick_h_ | kadams54: cool, there should be a follow up comment that it's accepted in a minute | 21:34 |
| rick_h_ | kadams54: then it takes about 25min in the jenkins ci run to merge | 21:34 |
| rick_h_ | kadams54: you can follow it at the ci url and should see it get picked up | 21:34 |
| kadams54 | I looked over some of the closed pull requests to get a feel for how things went. | 21:34 |
| kadams54 | I'll keep an eye on it | 21:34 |
| rick_h_ | coolio | 21:34 |
| rick_h_ | congrats on your first landing! | 21:34 |
| kadams54 | Always nice to end the day by landing a ticket | 21:35 |
| rick_h_ | almost...in 25min | 21:35 |
| rick_h_ | :) | 21:35 |
| kadams54 | :-) | 21:35 |
| rick_h_ | kadams54: make sure to move your kanban card and update the bug with 'fix committed' once it merges | 21:35 |
| kadams54 | Will do | 21:35 |
| rick_h_ | remember clikcing on the bug number on the card will take you straight there | 21:35 |
| kadams54 | Taking a break for dinner while I wait on CI | 21:37 |
| rick_h_ | hmm, why for it not pick it up? | 21:37 |
| kadams54 | My squirrel's sitting there, looking dapper in his fedora. | 21:38 |
| rick_h_ | oh! | 21:38 |
| rick_h_ | you've got to make your membership public! | 21:38 |
| hatch | haha | 21:38 |
| * rick_h_ goes to look for the button for that | 21:38 | |
| hatch | oh woops we missed that | 21:39 |
| rick_h_ | kadams54: yea, it checks you're in the right group to land | 21:39 |
| rick_h_ | kadams54: but it uses an api that needs to have your org membership public | 21:39 |
| hatch | not entirely sure why :shipit: is a squirrel in a fedora but I'm not complaining :) | 21:39 |
| kadams54 | Hmm… how do I do that? Not seeing anything on first glace. | 21:40 |
| rick_h_ | kadams54: https://github.com/orgs/juju/members | 21:40 |
| rick_h_ | can you see a link in the column by your name? | 21:40 |
| kadams54 | Alrighty, done. | 21:40 |
| hatch | hmm it's shown as public here | 21:40 |
| kadams54 | No whammie, no whammie, no whammie | 21:40 |
| kadams54 | hatch: I beat you :-) | 21:40 |
| hatch | rick_h_ huw is marked as private | 21:41 |
| hatch | hah | 21:41 |
| rick_h_ | hatch: heh well have to udpate that as well | 21:41 |
| rick_h_ | hatch: noather thing for you to help with | 21:41 |
| rick_h_ | :P | 21:41 |
| hatch | since i"ll be here ALL ALONE! | 21:41 |
| kadams54 | Do I need to post another :shipit: comment, or will CI pick up now that I'm publicly a member? | 21:41 |
| rick_h_ | it should pick it up | 21:42 |
| rick_h_ | there we go | 21:42 |
| rick_h_ | it's started | 21:42 |
| hatch | there it goes | 21:42 |
| rick_h_ | sorry for missing that kadams54, first time kinks and all | 21:42 |
| hatch | http://www.engadget.com/2014/03/20/facebook-hack-programming-language/?ncid=rss_truncated | 21:42 |
| rick_h_ | I'm not looking hatch. I've heard and don't want to know more | 21:42 |
| hatch | lol | 21:42 |
| hatch | apparently the other 100 languages to choose from weren't good enough | 21:43 |
| rick_h_ | k, family dinner time | 21:43 |
| rick_h_ | back later for AU calls | 21:43 |
| hatch | lata | 21:43 |
| kadams54 | LOL: "Essentially, this means you theoretically could have access to websites that are faster and more reliable." | 21:44 |
| kadams54 | All we need to do is sprinkle some Hack magic pixie dust and the site will be faster and more reliable. | 21:47 |
| kadams54 | Essentially. In theory. | 21:47 |
| huwshimi | Morning | 22:00 |
| hatch | hey huwshimi | 22:03 |
| hatch | kadams54 hahaha | 22:03 |
| hatch | huwshimi I can help you get your git issues straightened out | 22:03 |
| hatch | assuming your branch is still the same as your PR | 22:03 |
| huwshimi | hatch: Ah great! | 22:03 |
| hatch | quick hangout? | 22:04 |
| huwshimi | hatch: Sure. | 22:04 |
| hatch | ok one sec hangouts is being slow | 22:05 |
| hatch | huwshimi https://plus.google.com/hangouts/_/72cpi8ni98evoi6l2vif03kk6c?hl=en | 22:05 |
| hatch | huwshimi you can ignore that CI failure email - it was from your previous force push | 22:28 |
| hatch | the 'real' one is running now | 22:28 |
| hatch | http://ci.jujugui.org:8080/job/juju-gui/583/console | 22:28 |
| huwshimi | Ah ok | 22:29 |
| huwshimi | hatch: So now commit and rebase before each time I push? | 22:32 |
| hatch | well you only need to rebase if the commit isn't one which you would be ok with landing on in a bisect :) | 22:33 |
| hatch | the last thing you'd want to do is have to bisect 10 more commits because of lint commits heh | 22:33 |
| lazyPower | dont git-blame me! | 22:33 |
| hatch | lol lazyPower I don't hink you have comitted to the GUI so you're probably safe | 22:34 |
| lazyPower | yeah but i'm all over the other repositories | 22:34 |
| * lazyPower rubs his hands together | 22:34 | |
| hatch | haha | 22:34 |
| hatch | huwshimi if you can ever help it always `git rebase develop` instead of merging develop in (merging in is what causes issues with rebasing) | 22:39 |
| huwshimi | hatch: Ah ok, the hacking instructions have been updated to say that now anyway | 22:39 |
| huwshimi | rick_h_: Are we having a GUI call now? | 22:40 |
| rick_h_ | huwshimi: sorry, told everyone else but you wren't there I guess | 22:42 |
| rick_h_ | huwshimi: yes, starting up now | 22:42 |
| rick_h_ | hatch: if you want to join in there as well, up to you | 22:43 |
| rick_h_ | yay kadams54 thing landed | 22:44 |
| kadams54 | Yeah, I saw. Hoping on to update the board and ticket. | 22:44 |
| kadams54 | Hopping even. | 22:44 |
| rick_h_ | hop hop | 22:44 |
| rick_h_ | darn, huwshimi ran off. Ooops | 22:45 |
| huwshimi | rick_h_: I'm here | 22:45 |
| rick_h_ | huwshimi: oh hey, I'm in the call now :) sorry I told everyone in the stand up it'd be late but...missed you there | 22:46 |
| huwshimi | rick_h_: Oh, I guess we're joining the link in the calendar :) | 22:46 |
| * rick_h_ has to get used to that | 22:46 | |
| hatch | ok joining | 22:46 |
| rick_h_ | huwshimi: yes please | 22:46 |
| hatch | huwshimi https://github.com/orgs/juju/members | 22:57 |
| rick_h_ | hatch: where's the quickstart card? | 23:07 |
| hatch | bac is working on it | 23:08 |
| hatch | he has it in coding | 23:12 |
| hatch | huwshimi looks like your last push passed CI | 23:13 |
| huwshimi | hatch: Yay! | 23:13 |
| huwshimi | Merging! | 23:13 |
| hatch | :shipit: | 23:14 |
| hatch | oops | 23:14 |
| hatch | ur not supposed to do that :) | 23:14 |
| huwshimi | I'm not supposed to do what? | 23:14 |
| hatch | to merge you should type :shipit: in a comment and then CI will land it for you | 23:15 |
| hatch | clicking the merge button skips the final CI run | 23:15 |
| hatch | not a huge deal in this case because there are no other pending merges | 23:15 |
| huwshimi | Oh | 23:15 |
| huwshimi | DON'T PRESS THE GIANT GREEN BUTTON | 23:16 |
| hatch | lol exactly | 23:16 |
| hatch | apparently we can't turn it off | 23:16 |
| hatch | unfortunately | 23:16 |
| huwshimi | That can't possibly be the correct thing to do! | 23:16 |
| hatch | lol | 23:16 |
| hatch | yeah it's not a huge issue in this case, but the CI queues up branches so that they land in order and have the tests run in order | 23:17 |
| hatch | so if there was another branch in the queue then it could have broken something | 23:17 |
| hatch | possibly | 23:17 |
| hatch | :) | 23:17 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!