| davecheney | top - 11:08:40 up 16 days, 1:34, 9 users, load average: 5.09, 2.39, 1.02 | 00:08 |
|---|---|---|
| thumper | davecheney: is it fixed already? | 00:27 |
| davecheney | i have a partial fix that fixes the link error during compilation | 00:44 |
| davecheney | i'm going (20 mins so far ...) | 00:45 |
| davecheney | doing a | 00:45 |
| davecheney | full test run to see where we're at | 00:45 |
| davecheney | the fix isn't suitable for upstream, but it gives me a starting point | 00:45 |
| davecheney | thumper: http://paste.ubuntu.com/7154127/ | 00:45 |
| * thumper nods | 00:45 | |
| davecheney | that isn't looking to bad | 00:46 |
| davecheney | the fix is basically to reverse the order of the .a files presented to the linker | 00:46 |
| davecheney | but a more sophisticated fix will probably be needed | 00:46 |
| thumper | looks like an ordering issue for those failures | 00:46 |
| davecheney | yeah, i suspect that once the tests build | 00:47 |
| davecheney | the fixes to the failed test cases will be fairly straight forward | 00:47 |
| thumper | wallyworld: https://codereview.appspot.com/22320043/ | 00:54 |
| thumper | wallyworld: resurrecting a 4 month old branch | 00:54 |
| wallyworld | ok | 00:54 |
| thumper | because I want it for my plugin | 00:54 |
| thumper | davecheney: agreed | 00:54 |
| davecheney | thumper: email sent | 01:09 |
| thumper | davecheney: oh... kay... | 01:09 |
| davecheney | as i said in there, i'm working on a less horrible fix | 01:09 |
| davecheney | thumper: you'll see, don't panic | 01:10 |
| * thumper isn't panicing | 01:13 | |
| wallyworld | thumper: standup | 01:31 |
| wallyworld | thumper: wallyworld axw alexisb waigani are al waiting for you to grace us with your presence | 01:31 |
| axw | thumper: did you say you don't know what the minimum version of lxc we require is | 02:03 |
| axw | ? | 02:03 |
| thumper | axw: correct... | 02:03 |
| axw | ok | 02:03 |
| thumper | you should ask hallyn | 02:03 |
| axw | mk | 02:04 |
| thumper | really, it is the one that makes lxc-start move the container into the STARTING state | 02:04 |
| axw | wallyworld: so the user has to resolve provisioning errors, the provisioner won't just retry? | 02:21 |
| axw | like resolving charm errors? | 02:21 |
| wallyworld | axw: for now yes. the provisioner can't retry without extra logic, since if it is a rate limit issue, it would just compound the problem | 02:21 |
| wallyworld | we need to add extra logic to be smart about how and when auto retry happens | 02:22 |
| axw | yeah okay. it'd need exponential backoff and so on | 02:22 |
| axw | thanks | 02:22 |
| wallyworld | np | 02:22 |
| wallyworld | so first cut is just to provide the machinery and a manual trigger | 02:22 |
| axw | wallyworld: does it not make sense to have the machine watcher get notified when the machine's status changes? | 02:33 |
| axw | wallyworld: which would make the MachinesWithTransientErrors API redundant I think | 02:34 |
| wallyworld | axw: sorta. but i wanted to keep the implementations separate because 1. we are close to release and i didn't want to dick with that logic too much, 2. we may well want to have separate queues / processing requirements for handling machines with errors | 02:35 |
| axw | ok | 02:36 |
| wallyworld | it's all a a bit rushed sadly | 02:36 |
| axw | well it's not being used, so if it turns out it can be done without the API then we can just not use it. but at least it'll be there if we do need it | 02:37 |
| wallyworld | perhaps we can revert to using the normal machine watcher, but i didn't want to risk breaking existing stuff what was expecting certain semantics for that watcher | 02:37 |
| axw | yep fair call | 02:37 |
| wallyworld | axw: it's used in the branch i'm about to propose | 02:37 |
| axw | wallyworld: ok | 02:37 |
| wallyworld | by the provisioner task | 02:38 |
| axw | it's internal anyway | 02:38 |
| wallyworld | but we can easily change that in future if we want to do it differently as it's an internal api | 02:38 |
| wallyworld | yrp | 02:38 |
| wallyworld | the joys of trying to get stuff into a release | 02:38 |
| wallyworld | maybe i'm being overly cautious, but i do like having this stuff go in as an orthogonal implementation to what's there | 02:39 |
| wallyworld | to reduce risk | 02:39 |
| davecheney | thumper: https://codereview.appspot.com/80300043/ | 02:44 |
| davecheney | fix proposed for the gccgo link order bug | 02:44 |
| davecheney | now to make some spaghetti and see if I can roll a custom version of gccgo-go with that fix | 02:44 |
| thumper | davecheney: ack | 02:45 |
| thumper | davecheney: seems reasonable | 02:47 |
| thumper | davecheney: except for this 'a.p.' malarky | 02:47 |
| thumper | :-) | 02:47 |
| axw | thumper: good question about the race condition - I honestly don't know, but I think you're right and it could race. I'll use locals for those vars updated in the goroutine | 03:01 |
| thumper | axw: ok | 03:15 |
| thumper | wallyworld: got a minute for a hangout? | 03:16 |
| wallyworld | sure | 03:16 |
| wallyworld | thumper: you setting one up or me? | 03:18 |
| thumper | I'll do it | 03:19 |
| thumper | typical of me | 03:19 |
| thumper | ask a question... | 03:19 |
| thumper | then "oh, look, shiney" | 03:19 |
| thumper | https://plus.google.com/hangouts/_/72cpjm79q3a5ke7h17c6in5qas?hl=en | 03:19 |
| thumper | axw: what are you looking at now? | 04:03 |
| thumper | axw: because two things leap to mind... | 04:03 |
| axw | thumper: was going to do some more azure stuff, but I can shelve that again | 04:03 |
| thumper | axw: the more urgent one is "warn about empty .jenv file" as opposed to being too dumb | 04:04 |
| thumper | axw: second one is 'juju unset-env' | 04:04 |
| axw | thumper: warn about empty file and then act as if it didn't exist? | 04:04 |
| thumper | umm... I'm not sure | 04:05 |
| thumper | I'm tempted to just tell them it is there, and stop | 04:05 |
| thumper | the whole reason it is created empty is to grab the namespace | 04:05 |
| thumper | it is only weird edge cases where it would be empty and there | 04:05 |
| axw | yeah true. I guess we'll need a utility to help people clean stuff up when we actually do have the config hosted | 04:06 |
| * thumper nods | 04:06 | |
| axw | I'll just have it exit for now with a message pointing at the location | 04:06 |
| thumper | I think that is reasonable | 04:07 |
| thumper | it should (fingers crossed) no longer happen | 04:08 |
| axw | thumper: was just looking at IRC logs and looks like mgz is still working on it. I'll do unset-env for now, if you have no objections | 04:16 |
| thumper | ok | 04:16 |
| thumper | axw: I've emailed fwereade and jam about it | 04:20 |
| axw | thumper: okey dokey | 04:20 |
| axw | derp | 04:31 |
| axw | thumper: I mucked up the Infof in cmd/juju/common.go | 04:31 |
| axw | it says bootstrap fails even when it doesn't | 04:31 |
| thumper | hmm... | 04:31 |
| * axw fixes | 04:31 | |
| thumper | oops | 04:32 |
| mattyw | davecheney, ping? | 04:34 |
| axw | wallyworld: quick review please? https://codereview.appspot.com/80330043 | 04:41 |
| wallyworld | sure | 04:41 |
| axw | wallyworld: thanks for updating the client thing - will take another look in a bit | 04:41 |
| wallyworld | np, i was glad to get a 2nd opinion | 04:41 |
| davecheney | mattyw: pong | 04:46 |
| axw | wallyworld: reviewed again - sorry, missed something before | 04:57 |
| wallyworld | sure, looking | 04:57 |
| axw | wallyworld: I can't think of a way to solve the attribute error thing without a tonne of extra work, so if you don't mind I'll land this and we can iterate later | 06:38 |
| axw | at least then the API will be in | 06:38 |
| === vladk|offline is now known as vladk | ||
| === vladk is now known as vladk|offline | ||
| axw | jam: the go.crypto/ssh ProxyCommand doesn't shell out to "ssh", it shells out to "juju ssh" | 06:58 |
| axw | so effectively calling back into the same go.crypto/ssh code | 06:58 |
| wallyworld | axw: ok | 07:17 |
| rogpeppe | mornin' all | 07:49 |
| jam | morning rogpeppe | 09:03 |
| rogpeppe | jam: morning | 09:06 |
| rogpeppe | jam: are you around for a quick chat? | 09:07 |
| voidspace | morning all | 09:31 |
| rogpeppe | voidspace: hiya | 09:31 |
| === vladk|offline is now known as vladk | ||
| * fwereade is just about to do some reviews, but would like it if someone would take a quick look at https://codereview.appspot.com/80540043/ | 10:03 | |
| perrito666 | good morning eeryone | 10:05 |
| rogpeppe | fwereade: would you be available for a quick chat? | 10:09 |
| perrito666 | fwereade: looks good altough you might want to have opinion from a more expert dev | 10:12 |
| rogpeppe | fwereade: what problems did the tests find? | 10:22 |
| fwereade | rogpeppe, sure | 10:22 |
| fwereade | rogpeppe, just a couple of things like Checking an error and not returning | 10:23 |
| fwereade | rogpeppe, so a subsequent look at a FileInfo would panic | 10:23 |
| fwereade | rogpeppe, I had it in one place and not another | 10:23 |
| fwereade | rogpeppe, dirs weren't checking perms or something? | 10:23 |
| rogpeppe | https://plus.google.com/hangouts/_/canonical.com/juju-core?authuser=1 | 10:24 |
| perrito666 | if someone has a moment, I would appreciate this to be looked at https://codereview.appspot.com/80560043/patch/1/10002 | 10:33 |
| dimitern | perrito666, looking | 10:36 |
| dimitern | perrito666, reviewed | 10:38 |
| perrito666 | dimitern: thank yu | 10:38 |
| dimitern | perrito666, i forgot to mention that this won't work on windows, but that's ok I guess | 10:46 |
| dimitern | perrito666, or perhaps it will.. not sure (testing needed) | 10:47 |
| perrito666 | dimitern: utils ssh lacks an implementation for windows? (I guess that would depend on cygwin or smth on that area) | 10:47 |
| dimitern | perrito666, no, but on windows because we're not using openssh's scp no extra arguments can be passed to the command (not sure if that's relevant) | 10:48 |
| mgz | call is a bit bad for me this morning... | 10:48 |
| perrito666 | dimitern: fixed | 11:03 |
| dimitern | perrito666, cheers | 11:05 |
| dimitern | fwereade, rogpeppe, mgz, https://codereview.appspot.com/76910044/ is ready to land - want a last look? | 11:05 |
| mgz | dimitern: sure | 11:08 |
| perrito666 | anyone else wants to take a look at? https://codereview.appspot.com/80560043/patch/1/10002 it is fairly short | 11:17 |
| perrito666 | dimitern: extra tx if you paste the links here | 11:21 |
| perrito666 | :) different computer | 11:22 |
| dimitern | perrito666, sure: https://wiki.edubuntu.org/SecurityTeam/TestingMAAS http://marcoceppi.com/2012/05/juju-maas-virtualbox/ | 11:28 |
| perrito666 | dimitern: sory, I use another machine to be able to hold hangouts that long | 11:29 |
| dimitern | perrito666, I should start following your lead in that soon :) | 11:29 |
| perrito666 | I use a mac, which has hardware accel for that, yet it gets kind of hot, I guess I should get an android tablet or similar | 11:30 |
| dimitern | marcoceppi, nice article btw :) ^^ | 11:40 |
| marcoceppi | dimitern: thanks, it's too bad virtualbox and maas don't play together nicely | 11:41 |
| dimitern | marcoceppi, yeah, I tried myself twice before deploying maas + vbox (unsuccessful) | 11:41 |
| marcoceppi | dimitern: it's much better to use maas + qemu/kvm | 11:42 |
| dimitern | marcoceppi, I tried that yesterday and almost got it working - pxe boot working (with both cluster controller vm and a blank node using single NIC bridged to virbr0), but after commissioning the outbound networking on the new node is not working | 11:43 |
| voidspace | brb | 11:43 |
| marcoceppi | dimitern: how is your maas setup? does it own dchp, etc? | 11:44 |
| dimitern | marcoceppi, yeah, it has 2 nic (lo and eth0 - the bridged one; also managed in maas for dhcp + dns) | 11:45 |
| dimitern | marcoceppi, had to set the default domain config from local to "", because it seems avahi boot is not working | 11:45 |
| marcoceppi | dimitern: is ip_forwarding setup properly with the masquard rules, etc? | 11:45 |
| marcoceppi | dimitern: it took me a long time to get maas-master networking configured correctly | 11:46 |
| dimitern | marcoceppi, and I also set the iptables rules according to the TestingMAAS article | 11:46 |
| * marcoceppi reads article | 11:46 | |
| marcoceppi | dimitern: there are some scripts that might help you setup the networking, actually | 11:46 |
| dimitern | marcoceppi, ip_fwd on cluster vm or on the host (the latter is on) | 11:46 |
| marcoceppi | latter | 11:46 |
| dimitern | marcoceppi, so pxe boot works, but as the new node starts apt-getting stuff it fails to resolve archive.ubuntu.com urls | 11:47 |
| marcoceppi | the fact that this is saying cobbler convinces me it's out of date. I don't think maas uses cobbler anymore | 11:47 |
| dimitern | yeah, it doesn't | 11:48 |
| dimitern | but I used the alternative (installing maas-dhcp and configuring it through the web ui) | 11:48 |
| marcoceppi | dimitern: well, there should be a squid-deb-proxy running on maas master, you should be able to set the apt-mirror url in maas to piont to the maas master's internal network ip | 11:48 |
| marcoceppi | but that won't solve needed to resolve addresses outside of the machine | 11:48 |
| dimitern | marcoceppi, so just install squid-deb-proxy on cluster controller, add a new archive from the web ui? | 11:49 |
| marcoceppi | dimitern: also, is it not connecting to the outside or is it a dns lookup issue? | 11:49 |
| dimitern | marcoceppi, not sure if it's just dns resolving issue or outbound networking in general, need to look into it | 11:50 |
| marcoceppi | dimitern: if you can get to a node in maas, you should be able to ping a network address, and if you can, you'll just need to set up the proper DNS forwarding route for the maas dns server | 11:50 |
| dimitern | marcoceppi, the frustrating thing is that the guide wasn't specific on how to setup the new nodes' networking when creating the vm | 11:50 |
| marcoceppi | dimitern: just DHCP should be sufficent | 11:51 |
| dimitern | marcoceppi, but following yours, i decided all vms have nic bridged to the virbr0 | 11:51 |
| wwitzel3 | dimitern: I had to set the external DNS server for my nodes to resolve archive.ubuntu | 11:51 |
| dimitern | marcoceppi, so the node appears and stays in commissioning (in some cases even ready), but the fqdn is something like ";; cannot resolve xyz ;;" | 11:51 |
| dimitern | wwitzel3, with libvirt? | 11:52 |
| perrito666 | well as an alternative, you can use virtulbox in nat mode and then do a reverse ssh tunnel from within the maas machine | 11:52 |
| perrito666 | the master that is | 11:52 |
| wwitzel3 | dimitern: yes, in MAAS/settings | 11:53 |
| wwitzel3 | dimitern: there is an Upstream DNS | 11:53 |
| dimitern | wwitzel3, ah, ok, I'll try that | 11:53 |
| wwitzel3 | dimitern: also, I set the default domain to some fake internal domain, like my.maas and added the maas controller to my resolv.conf as the nameserver for that domain | 11:53 |
| dimitern | wwitzel3, cheers | 11:54 |
| voidspace | rogpeppe: want to rejoin the hangout? | 11:56 |
| voidspace | rogpeppe: it's empty | 11:56 |
| voidspace | well, except for me... | 11:56 |
| rogpeppe | voidspace: will do | 11:57 |
| perrito666 | dimitern: could you ack the chanes, just to be sure? https://codereview.appspot.com/80560043/patch/20001/30002 | 11:59 |
| wwitzel3 | rogpeppe: https://codereview.appspot.com/72500043/ | 11:59 |
| * perrito666 has the button hanging over the submit | 11:59 | |
| rogpeppe | natefinch: would you be able to join us in the hangout? | 12:00 |
| rogpeppe | natefinch: (https://plus.google.com/hangouts/_/canonical.com/juju-core?v=1395698400&authuser=1) | 12:00 |
| bodie_ | morning all | 12:04 |
| dimitern | perrito666, looking | 12:09 |
| dimitern | perrito666, reviewed, just one minor thing | 12:10 |
| perrito666 | wwitzel3: was it you that asked me how to make gofmt go trough vim? | 12:10 |
| dimitern | fwereade, rogpeppe, mgz, poke about https://codereview.appspot.com/76910044/ | 12:10 |
| wwitzel3 | perrito666: well I can make it automatically run, I just can't get it to highlight the lines with errors | 12:11 |
| perrito666 | wwitzel3: ah I got it to jut fix the file :p | 12:11 |
| perrito666 | which is faster | 12:11 |
| wwitzel3 | perrito666: well mine does that too as long as there aren't any synxtax errors | 12:11 |
| wwitzel3 | perrito666: but if there are syntax errors, it just outputs "go fmt returned an error" and doesn't tell me what line, so I have to drop to the command line and run go fmt to see where the error actually is. | 12:12 |
| perrito666 | wwitzel3: i think I can add that to fmt.vim :) ill try on the weekend | 12:13 |
| mgz | dimitern: going over it now | 12:14 |
| mgz | dimitern: lgtm | 12:20 |
| dimitern | mgz, ta! | 12:20 |
| perrito666 | dimitern: fixed, merging then :) | 12:21 |
| perrito666 | dimitern: thank you very much | 12:21 |
| dimitern | perrito666, go for it | 12:21 |
| perrito666 | mm, apparently has a conflict with my other branch, how should I fix that? | 12:26 |
| mgz | pull trunk, merge trunk in to the branch you're trying to land, | 12:29 |
| perrito666 | ack | 12:30 |
| dimitern | perrito666, switch to trunk, pull it in, then switch to your other branch and do "bzr merge :parent" | 12:30 |
| mgz | resolve the conflicts, commit, push, then tell the bot to try again | 12:30 |
| dimitern | :) | 12:30 |
| dimitern | rogpeppe, do you have a minute? | 12:30 |
| dimitern | rogpeppe, I'm wondering why this fails http://play.golang.org/p/VPC3P2nGYQ ? | 12:31 |
| rogpeppe | dimitern: gimme 5 mins | 12:31 |
| dimitern | rogpeppe, sure | 12:31 |
| dimitern | perrito666, ah, one thing you might need - after merging, resolving, committing and pushing, you'll probably need to add a comment on the MP to self-approve the changes | 12:32 |
| perrito666 | after merging and committing I du another propose right? | 12:38 |
| mgz | just the landing step | 12:41 |
| mgz | no really need to lbox | 12:41 |
| mgz | flip the approved on the mp is all you really need | 12:41 |
| perrito666 | ok, I just bzr push then go to the mp in launchpad and hit approved | 12:41 |
| mgz | yup | 12:41 |
| perrito666 | ok, makes sense | 12:42 |
| wallyworld | jam: fwereade: i added support for multiple machines also | 12:46 |
| voidspace | http://en.wikipedia.org/wiki/Toast_sandwich | 12:57 |
| dimitern | rogpeppe, I'm really banging my head here on this one | 13:03 |
| rogpeppe | dimitern: ok, looking | 13:03 |
| rogpeppe | dimitern: what does jc.DeepEquals print? | 13:04 |
| dimitern | rogpeppe, mismatch at ["services"]["network-service"]: validity mismatch; obtained map[interface {}]interface {}{"charm":"cs:quantal/dummy-1", "exposed":false, "networks":map[interface {}]interface {}{"disabled":[]interface {}{"net3", "net4"}, "enabled":[]interface {}{"net1", "net2"}}}; expected <nil> | 13:04 |
| dimitern | rogpeppe, expected is actually not nil, but IsValid == false | 13:04 |
| dimitern | rogpeppe, here's the full output with some added logging: http://paste.ubuntu.com/7156594/ | 13:05 |
| rogpeppe | dimitern: the second one has "networks-service" not "network-service" | 13:05 |
| rogpeppe | dimitern: http://play.golang.org/p/BWtpWAaiEf | 13:05 |
| dimitern | rogpeppe, ah! | 13:06 |
| dimitern | rogpeppe, tyvm | 13:06 |
| rogpeppe | dimitern: np. i've been that same situation *so* many times! | 13:06 |
| rogpeppe | dimitern: it was worse without jc.DeepEquals... | 13:06 |
| dimitern | rogpeppe, indeed :) at least it tell you at which point it fails | 13:07 |
| mgz | darn plurals :) | 13:07 |
| dimitern | fwereade, mgz, updated https://codereview.appspot.com/76400049/ - now we show networks for services, not machines (ignore the branch name, don't know how to rename it) | 13:17 |
| dimitern | fwereade, I'd especially like your comments due to your not lgtm | 13:17 |
| natefinch | wwitzel3, rogpeppe: back in action, going to do some cleanup of the proposal branch | 13:24 |
| rogpeppe | voidspace: http://paste.ubuntu.com/7156661/ | 13:25 |
| rogpeppe | dimitern: are you free for a quick chat? | 13:26 |
| rogpeppe | natefinch: ok, cool. i'm afraid i haven't got any further with my review | 13:26 |
| dimitern | rogpeppe, sure | 13:26 |
| natefinch | rogpeppe: no problem | 13:26 |
| dimitern | rogpeppe, mumble? | 13:26 |
| rogpeppe | dimitern: https://plus.google.com/hangouts/_/canonical.com/juju-core?v=1395698400&authuser=1 ? | 13:27 |
| rogpeppe | dimitern: (i've forgotten how to use mumble...) | 13:27 |
| dimitern | rogpeppe, ok | 13:27 |
| perrito666 | sinzui: hey, with the last landing you should be able to run the test for https://bugs.launchpad.net/juju-core/+bug/1291022 | 13:28 |
| _mup_ | Bug #1291022: Cannot restore a state-server on ec2 and openstack <backup-restore> <ec2-provider> <hp-cloud> <regression> <juju-core:In Progress by hduran-8> <https://launchpad.net/bugs/1291022> | 13:28 |
| sinzui | perrito666, fab, the test is being run with every revision. I will look for a pass with r2488 | 13:29 |
| perrito666 | sinzui: plz keep me posted, I ran it successfully by integrating my branches, but ymmv | 13:33 |
| bodie_ | HA! I love this | 13:33 |
| bodie_ | https://github.com/bradfitz/iter | 13:33 |
| natefinch | bodie_: I just saw that the other day, pretty great | 13:39 |
| wwitzel3 | natefinch: can I call? | 13:41 |
| natefinch | wwitzel3: sure | 13:41 |
| wwitzel3 | perrito666: I ended up using the syntastic bundle for vim and it does proper line highlighting or errors | 14:17 |
| wwitzel3 | of | 14:17 |
| perrito666 | :) that is very good news | 14:17 |
| wwitzel3 | perrito666: yeah, it hilights the offending line and provideds the message | 14:18 |
| bodie_ | looking for a quick leg up understanding /state/api/apiclient.go struct State | 14:20 |
| bodie_ | if anyone has a sec, pm? | 14:20 |
| bodie_ | thanks in advance :) | 14:21 |
| bloodearnest | sigh, *of course* mongodb charm doesn't implement any nagios relations | 14:30 |
| voidspace | alexisb: ping | 14:31 |
| bloodearnest | oops, that was meant for #juju | 14:31 |
| === hatch__ is now known as hatch | ||
| dimitern | bodie_, api.State is the client-facing api facade, i.e. it emulates state.State, but through the api (it contains the underlying api connection as well) | 14:35 |
| bodie_ | yeah, I saw that -- wasn't aware that it is the client frontend for State.state though. (useful!) | 14:36 |
| bodie_ | I was going on the assumption that the API is an http endpoint but I'm thinking that is wrong. correct? | 14:37 |
| marcoceppi | is JUJU_HOME ~user or ~user/.juju ? | 14:42 |
| marcoceppi | it's the latter | 14:42 |
| dimitern | bodie_, strictly speaking it's a front-end of state.State as seen through the API only | 14:46 |
| bodie_ | by API you mean the actual programmatic API, right? Not the HTTP API | 14:47 |
| bodie_ | I was under the impression the gui communicates with the program via HTTP API but now I'm recalling hearing that it uses websockets | 14:48 |
| dimitern | bodie_, the API endpoint itself is either https-based or websocket-based (the former is only used for uploading charms and fetching stuff from charms, the latter exposes the rest of the api) | 14:48 |
| bodie_ | I see | 14:48 |
| bodie_ | so if I want to add verbs to the API, I don't need to define them in the HTTPS frontend | 14:48 |
| dimitern | bodie_, if by verbs you mean api methods that can be used by clients (cli, gui, deployer, etc.), then you need to add them to api.Client as methods which call their apiserver.Client counterparts | 14:49 |
| dimitern | fwereade, rogpeppe, mgz, juju deploy --networks/--no-networks support, PTAL https://codereview.appspot.com/80600044/ | 14:50 |
| bodie_ | OK, I think that makes sense :) we had talked about doing it via hooks but I'm not positive that's the right way | 14:51 |
| bodie_ | or at least, it gives me something to go on | 14:51 |
| bodie_ | thanks for the help | 14:51 |
| dimitern | bodie_, what do you have in mind? | 14:51 |
| === vladk is now known as vladk|offline | ||
| dimitern | bodie_, things hooks can do are very limited compared to the api | 14:52 |
| bodie_ | service actions such as mysql snapshot | 14:52 |
| bodie_ | there are a few of us who got roped in from the outside, trying to put it together over the next few weeks | 14:53 |
| dimitern | bodie_, what will that do? please, expand a bit. | 14:53 |
| bodie_ | I think it's either an experiment to see how frustrating it is for newbies to dive into the deep end unguided, or we're on reality tv | 14:53 |
| bodie_ | but here I am haha | 14:53 |
| dimitern | :) | 14:54 |
| bodie_ | basically, a few Action words added to the command interface | 14:54 |
| bodie_ | juju do, juju queue, juju cancel, and a couple of others | 14:54 |
| bodie_ | the flow is like | 14:54 |
| dimitern | the api code can be daunting at first, but it's really straightforward once you grok the way things pass through client->api->websocket->apiserver->state | 14:55 |
| bodie_ | yeah, I'm kind of briding the first bit of that right now | 14:55 |
| bodie_ | s/briding/bridging/ | 14:55 |
| dimitern | ah, so juju <command> can be added either in cmd/juju or as plugins named "juju-<command>" | 14:55 |
| bodie_ | the flow is like -- juju do <node identifier> <service identifier> <verb as defined in the charm, e.g. snapshot> <arguments> | 14:56 |
| dimitern | sounds like you could use a plugin that calls juju run internally | 14:56 |
| bodie_ | yeah, I think I get how to add a command now, I just want to make sure I understand what needs to happen once it gets triggered | 14:56 |
| bodie_ | hm | 14:56 |
| bodie_ | well juju run gets called by the command line already right? regardless of argument | 14:57 |
| bodie_ | so we would just add a file to /cmd/juju/ | 14:57 |
| dimitern | juju run allows you to run scripts remotely on a unit or all machines inside the same context (env vars etc.) that a hook runs | 14:57 |
| bodie_ | okay | 14:57 |
| bodie_ | yeah, that's what I've been digging through over the last two days | 14:57 |
| dimitern | either in cmd/juju/mycmd.go (for example) or as an executable juju-mycmd in $PATH - both will give you the ability to do "juju mycmd" | 14:58 |
| bodie_ | right... and then I'll have to --upload-tools to test it (right?) | 14:59 |
| dimitern | no | 14:59 |
| bodie_ | ok | 14:59 |
| bodie_ | so let's say I want to have arguments to that command trigger stuff on the remote | 14:59 |
| bodie_ | e.g. mysql dump | 14:59 |
| bodie_ | the "run" on the node gets triggered by uh (checks notes0 | 15:00 |
| bodie_ | ) | 15:00 |
| dimitern | --upload-tools is needed in general to have the latest jujud binaries in the cloud; for client-side stuff (on your machine) you just need to rebuild cmd/juju or whatever other plugin/script you're using | 15:00 |
| bodie_ | apiClient in /cmd/juju/run.go Run function | 15:00 |
| bodie_ | triggers execution on the remote via rpc | 15:00 |
| bodie_ | or -- triggers the remote function rather | 15:01 |
| bodie_ | which is in /cmd/juju | 15:01 |
| dimitern | the simplest way to do that is to first check if you can simulate what you need via juju run (or other commands) | 15:01 |
| bodie_ | implementing RunCommand | 15:01 |
| * bodie_ reads | 15:01 | |
| dimitern | if it is sufficient, you can put them in a script and use that | 15:01 |
| dimitern | juju run is quite versatile - check its help | 15:02 |
| bodie_ | ok | 15:02 |
| dimitern | bodie_, juju ssh and juju scp are also useful to run stuff remotely or copy files across local/remote machines (but these do not give you hook contexts like run) | 15:05 |
| bodie_ | OK, so maybe what we're actually doing is trying to make a Run alias that knows how to do certain things based on what's in the respective charm | 15:06 |
| mattyw | rogpeppe, got a moment? | 15:06 |
| rogpeppe | mattyw: sure | 15:06 |
| rogpeppe | mattyw: hangout? | 15:06 |
| mattyw | rogpeppe, we can do - irc is probably fine for this | 15:06 |
| mattyw | unless you want to hear my voice ;) | 15:07 |
| rogpeppe | mattyw: that's cool too, though i ache for the melodious timbre of your voice, obviously | 15:07 |
| mattyw | rogpeppe, you're only human | 15:08 |
| bodie_ | how poetic | 15:08 |
| mattyw | rogpeppe, this review from fwereade https://codereview.appspot.com/75600044/diff/20001/state/user.go#newcode32 | 15:08 |
| mattyw | admin user being allowed an empty password | 15:08 |
| dimitern | bodie_, i wouldn't call it "alias" (in CLI terms only actual commands can have aliases), but I got you - it's just a script that calls one or more times juju run and can take arguments | 15:09 |
| mattyw | I'm sure there was a reason - but can't remember what/ if there was - do you have any wisdom to impart? | 15:09 |
| rogpeppe | mattyw: i'm not really sure why we consider "admin" special in any way actually | 15:10 |
| rogpeppe | mattyw: apart from for mongo access, which isn't relevant to this | 15:10 |
| rogpeppe | mattyw: i'd prefer to avoid any name special-casing | 15:11 |
| mattyw | rogpeppe, I'm starting to wonder if I snuck that code in so I didn't have to change loads of tests | 15:11 |
| rogpeppe | mattyw: ha ha | 15:11 |
| mattyw | rogpeppe, I'll try removing it and see what happens | 15:12 |
| mattyw | rogpeppe, if you don't think it should be there either then I'll just have to bullet the bite | 15:12 |
| rogpeppe | mattyw: looks like there are in fact a fair number of tests that call AddUser with an empty password | 15:12 |
| dimitern | I looking for reviews on https://codereview.appspot.com/76400049/ and https://codereview.appspot.com/80600044/ please | 15:12 |
| rogpeppe | mattyw: why don't we just allow the empty password? | 15:12 |
| mattyw | rogpeppe, I've changed a number of tests in that cl aready - you mean for all users? | 15:13 |
| rogpeppe | mattyw: yeah | 15:13 |
| mattyw | rogpeppe, I suppose so that makes sense | 15:14 |
| rogpeppe | mattyw: given that a user can change a password to "password" or "a", i don't really see what preventing a blank password gives us | 15:14 |
| mattyw | rogpeppe, very true | 15:14 |
| mattyw | rogpeppe, fwereade I'm going to change the mp to allow the empty password for all users for now then if that's ok? | 15:15 |
| fwereade | rogpeppe, mattyw: that sounds fair to me | 15:19 |
| fwereade | rogpeppe, mattyw: state is probably not the place for that sort of policy enforcement anyway | 15:20 |
| rogpeppe | fwereade: +1 | 15:20 |
| mattyw | fwereade, rogpeppe where would be? (out of interest) | 15:22 |
| rogpeppe | mattyw: if we wanted to, probably in the API | 15:22 |
| fwereade | mattyw, rogpeppe: API layer IMO | 15:22 |
| rogpeppe | nice when we concur :) | 15:23 |
| dimitern | fwereade, got some time to review my CLs? | 15:23 |
| fwereade | dimitern, first one LGTM | 15:41 |
| dimitern | fwereade, \o/ | 15:41 |
| hatch | is there a way I can get a list of the charms loaded into the juju env? (uploaded and not necessarily deployed) | 15:46 |
| hatch | maybe poking a db or something? | 15:46 |
| natefinch | rogpeppe: why is go test -c so dang slow? | 15:47 |
| dimitern | hatch, you could check the storage | 15:47 |
| rogpeppe | natefinch: it's quicker if you do go test -i first | 15:47 |
| hatch | dimitern cool thanks | 15:48 |
| fwereade | dimitern, couple of thoughts on the second, let me know when you've read it | 15:48 |
| dimitern | fwereade, cheers | 15:49 |
| natefinch | rogpeppe: that doesn't seem to make a noticeable difference. It's just, I can compile in .2 seconds, but test -c takes 1.2-1.5 seconds for the same package | 15:50 |
| natefinch | rogpeppe: the reason I care is that I want to be able to find compile errors in tests when I make changes to code, and not have to actually run the tests to check. I can recursively call go test -c in all subdirectories, but it takes forever | 15:51 |
| dimitern | fwereade, right now we can't verify if the provider supports networks, but we can do it later if we have a way to introspect the provider capabilities reliably | 15:51 |
| === vladk|offline is now known as vladk | ||
| roaksoax | alexisb: here | 17:55 |
| roaksoax | err | 17:55 |
| roaksoax | sorry | 17:55 |
| roaksoax | allenap: here | 17:55 |
| allenap | mgz: Can I borrow your brain? roaksoax (or one of his team) is seeing http://paste.ubuntu.com/7153235/ with Juju 1.5 but not 1.4. I can see what’s going on in MAAS, but I can’t figure out what has happened to get to this point. | 17:55 |
| allenap | mgz: It’s like Juju is trying to start a node that it doesn’t own. | 17:56 |
| allenap | Or that isn’t allocated. | 17:56 |
| roaksoax | maas 1.5 | 17:57 |
| roaksoax | withjuju 1.6 | 17:57 |
| allenap | roaksoax: Is this after an upgrade from precise to trusty? | 17:57 |
| allenap | Oops, of course. | 17:57 |
| mgz | allenap: looking :0 | 17:57 |
| allenap | mgz: Thanks! | 17:57 |
| roaksoax | allenap: this is maas in trusty | 17:57 |
| perrito666 | rogpeppe: are you around? | 17:58 |
| rogpeppe | perrito666: yup | 17:59 |
| perrito666 | rogpeppe: I have an issue and mgz said youmight have an answer http://pastebin.ubuntu.com/7158113/ | 17:59 |
| perrito666 | I want to do an instance of the struct as marked in the pastebin | 17:59 |
| perrito666 | but GetField returns value, err | 17:59 |
| perrito666 | do you know any elegant way to do it? | 18:00 |
| rogpeppe | perrito666: i might do. what the type that massNet.GetField returns? | 18:00 |
| mgz | allenap: so, is this from nodes/ acquire, or later? | 18:00 |
| perrito666 | string, err | 18:01 |
| mgz | we pretty much just ask maas to give us suitable things, regardless of juju version | 18:01 |
| allenap | roaksoax: ^ | 18:01 |
| mgz | rogpeppe: my python insst | 18:02 |
| mgz | *instinct is to have a map of struct params to values, iterate over and use setattr, but reflection in go is much more heavyweight | 18:03 |
| mgz | allenap: I take it maas isn't logging the actual api call that was the trigger for the eventual perm error? it's a bit hard to see from the traceback, but I assume acquire, as that's when it'd start | 18:04 |
| allenap | mgz: Request logs should show the URL, but not the body. Logging in MAAS is not quite joined-up enough to do this easily. | 18:06 |
| mgz | roaksoax: can you pull out the url of the request from those logs too? | 18:06 |
| roaksoax | mgz: i don't think we can | 18:08 |
| rogpeppe | perrito666: here's one of 3 possibilities: http://play.golang.org/p/fYV5AdaU_P | 18:08 |
| allenap | roaksoax: Are you able to reproduce this and do further diagnosis? | 18:08 |
| roaksoax | mgz: so something I had seen long ago is for example, there are 10 nodes available in MAAS< then when you bootstrap, you have 9 available to use. SO if you add a extra server into MAAS, to have 10 available, juju would only know about 9 free and not 10 | 18:08 |
| rogpeppe | perrito666: well 3 that i could think of straight off | 18:08 |
| roaksoax | could this be somehow related | 18:08 |
| mgz | rogpeppe: that's neat | 18:09 |
| allenap | roaksoax: Woah, that’s weird! | 18:09 |
| perrito666 | rogpeppe: thank you | 18:09 |
| allenap | mgz, roaksoax: I’m really sorry, but I have to go. I’ll be back in <2 hours, once the kids are in bed. | 18:10 |
| roaksoax | rharper: ^^ | 18:10 |
| roaksoax | rharper: mgz is requesting some type of logs for the failures you've seen | 18:10 |
| rharper | sure | 18:11 |
| rharper | so, we saw this in the juju status output: http://paste.ubuntu.com/7153156/ | 18:11 |
| rharper | looking on maas server logs, we saw this: http://paste.ubuntu.com/7153235/ | 18:11 |
| rharper | but the fundamental question is, can we bootstrap in parallel against a maas env; we have 4 jenkins instances, each one will bootstrap potentially in parallel, but never consume more hardware that we have available | 18:12 |
| rogpeppe | perrito666, mgz: here's another, slightly more straightforward approach: http://paste.ubuntu.com/7158165/ | 18:13 |
| rogpeppe | (but somewhat less performant too) | 18:13 |
| mgz | rharper: the short answer is yes, with a current version of maas, provided you're using a seperate user account for each | 18:15 |
| mgz | in older versions, parallel use was borked | 18:15 |
| rharper | mgz: so, we're on precise -- the clients use juju-core from precise, so 1.16 -- | 18:16 |
| rharper | we have separpate maas user for each jenkins slave | 18:16 |
| rharper | so no one is using the same maas user | 18:16 |
| rogpeppe | perrito666, mgz: here's a third possibility: http://paste.ubuntu.com/7158198/ | 18:16 |
| mgz | rharper: then this should certainly work. so you also have four juju users with the different maas user creds? | 18:17 |
| rharper | mgz: yep | 18:17 |
| mgz | and the maas is the one from the precise cloud archive? | 18:18 |
| rharper | FWIW, in practice it runs fine -- I posted above a strange juju status output where we din't have a dns value for one of the nodes; and that 403 error | 18:18 |
| rharper | roaksoax: what's the maas? 1.5 on trusty IIRC | 18:18 |
| roaksoax | yup | 18:19 |
| roaksoax | maas 1.5 on trusty | 18:19 |
| roaksoax | mgz: ^^ | 18:20 |
| mgz | roaksoax: I can't see anything juju specific, though having an older client work when a newer one doesn't my be a helpful clue | 18:23 |
| === vladk is now known as vladk|offline | ||
| rharper | mgz: any idea what that gomaasapi 403 would be about? or the permission stack trace from maas ? is it even related to parallel stuff at all ? | 18:24 |
| * rogpeppe has to run | 18:25 | |
| rogpeppe | natefinch, wwitzel3: perhaps you could push your branch so that i can take a look in the morning | 18:25 |
| rogpeppe | g'night all | 18:26 |
| natefinch | rogpeppe: sure | 18:26 |
| natefinch | rogpeppe: night | 18:26 |
| mgz | rharper: so, the 403 is because of the perm error | 18:28 |
| mgz | why the perm error... is mysterious, it could be some scrambling from the accounts getting mixed somehow, but it could be all kinds of other things as well | 18:28 |
| perrito666 | hey I am suddenly getting error: flag provided but not defined: --instance-id when running bootstrap, I am using trunk and boostraping in amazon | 18:29 |
| rharper | yeah, there was a claim of an edit -- but I can't figure out why anything would be issuing an edit | 18:29 |
| rharper | it's basically a juju-deployer run of an openstack install | 18:29 |
| perrito666 | anyone bumped into thi? | 18:29 |
| wwitzel3 | natefinch: can you hear me? | 18:29 |
| natefinch | nope | 18:29 |
| rharper | mgz: and only this one of the 7 machines that deployed and came up fine | 18:29 |
| rharper | for this juju env | 18:29 |
| voidspace | right, g'night all | 19:15 |
| voidspace | EOD | 19:15 |
| thumper | morning | 20:08 |
| thumper | fwereade: around? | 20:08 |
| fwereade | thumper, heyhey, been a while | 20:08 |
| wwitzel3 | morning thumper | 20:08 |
| thumper | sure has | 20:08 |
| thumper | o/ wwitzel3 | 20:08 |
| thumper | fwereade: got a few minutes for a hangout? | 20:08 |
| thumper | o/ natefinch | 20:08 |
| fwereade | thumper, ofc | 20:08 |
| thumper | fwereade: https://plus.google.com/hangouts/_/7ecpisoldu4ri6vlrus3kt5tu8?hl=en | 20:09 |
| natefinch | morning thumper | 20:09 |
| wwitzel3 | natefinch: you back? | 20:18 |
| natefinch | wwitzel3: not really. It's an online errand ;) | 20:18 |
| wwitzel3 | natefinch: ahh ok :) | 20:18 |
| thumper | wwitzel3: you have set up vmaas, yes? | 20:28 |
| thumper | wwitzel3: can you look at https://bugs.launchpad.net/juju-core/+bug/1297899 ?\ | 20:28 |
| _mup_ | Bug #1297899: Libvirt machines deployed with MAAS and Precise is only able to successfully boot once <maas-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1297899> | 20:28 |
| davecheney | thumper: test's running on ppc!! | 20:34 |
| thumper | \o/ | 20:34 |
| natefinch | thumper: nice! | 20:35 |
| thumper | davecheney: so https://bugs.launchpad.net/juju-core/+bug/1289067 fixed? | 20:35 |
| _mup_ | Bug #1289067: arm64 multiple definition of `launchpad.net_juju_core_cmd._.0 <arm64> <ppc64el> <test-failure> <juju-core:Triaged by dave-cheney> <gccgo-go (Ubuntu):Fix Released by james-page> <gccgo-go (Ubuntu Trusty):Fix Released by james-page> <https://launchpad.net/bugs/1289067> | 20:35 |
| davecheney | thumper: i fixed it upstream yesterday | 20:35 |
| davecheney | make sure you have gccgo-go~1.2.1 | 20:35 |
| davecheney | released 8 hours ago | 20:35 |
| davecheney | thumper: natefinch http://paste.ubuntu.com/7158930/ | 20:40 |
| davecheney | actual ppc test results | 20:40 |
| davecheney | sinzui: http://paste.ubuntu.com/7158930/ | 20:40 |
| davecheney | ^ real honest to god test results on ppc | 20:40 |
| davecheney | just filtering out all the [LOG] lines now | 20:40 |
| natefinch | davecheney: sweeeet | 20:40 |
| natefinch | davecheney: https://github.com/natefinch/nolog | 20:41 |
| sinzui | \o/ | 20:41 |
| davecheney | thumper: a lot of those failures are simple slice ordering issues | 20:42 |
| sinzui | davecheney, I just updated wolfe-02. Just the one lib because eco are working on the machine. | 20:42 |
| davecheney | probably from stuff that is stored in a map | 20:42 |
| davecheney | then we are returning the map keys | 20:42 |
| sinzui | I expect great things in the next CI run | 20:43 |
| davecheney | sinzui: sure, you just need gccgo-go 1.2.1 | 20:43 |
| sinzui | yep, that is what I got | 20:43 |
| davecheney | thumper: what is the 'official' fix to that class of test failures ? | 20:43 |
| davecheney | should I sort the results before comparing | 20:43 |
| natefinch | davecheney: jc.SameContents | 20:43 |
| davecheney | or is there a gocheck Checker for that ? | 20:43 |
| davecheney | natefinch: thanks, that was the tool I was thinking of | 20:43 |
| natefinch | davecheney: welcome | 20:45 |
| sinzui | davecheney, thumper. CI is already running (well walking is a better verb) the arm64 unit tests. We are hours from seeing the result if the instance doesn't die of exhaustion: http://ec2-54-84-137-170.compute-1.amazonaws.com:8080/job/walk-unit-tests-arm64-trusty/51/console | 20:46 |
| davecheney | sinzui: cool | 20:46 |
| thumper | ha | 20:47 |
| davecheney | sinzui: is that qemu, or the fast model simulator ? | 20:47 |
| sinzui | davecheney, I think qemu. It is very slow. | 20:48 |
| sinzui | I haven't been able to keep an instance up for more than 18 hours too | 20:48 |
| natefinch | wwitzel3: So, I don't know that I need to get back into the hangout for the last 12 minutes of the day. Have you made any progress? | 20:49 |
| natefinch | wwitzel3: not sure when your EOD is today | 20:49 |
| davecheney | sinzui: the fast model is an oxymoron | 20:59 |
| davecheney | sinzui: thumper natefinch http://paste.ubuntu.com/7158982/ | 21:00 |
| davecheney | cleaner results | 21:00 |
| davecheney | so there are a bunch of simple problems like using the wrong checker | 21:00 |
| davecheney | there is something in one package that causes a panic on ppc64 | 21:01 |
| davecheney | repo_test.go:237: c.Assert(err, gc.ErrorMatches, expect) | 21:01 |
| davecheney | ... error string = "invalid character '<' looking for beginning of value" | 21:01 |
| davecheney | ... regex string = "Cannot access the charm store. Are you connected to the internet. Error details:.*" | 21:01 |
| davecheney | we have a test that looks like it's not expecting to run behind a firewall | 21:01 |
| davecheney | lots of tool errors | 21:02 |
| natefinch | EOD for me | 21:03 |
| davecheney | Started service at: https://127.0.0.1:33899 | 21:03 |
| davecheney | Set tools-metadata-url="https://127.0.0.1:33899/v1/1/juju-dist-test/tools" | 21:03 |
| davecheney | Set image-metadata-url="https://127.0.0.1:33899/v1/1/juju-dist-test" | 21:03 |
| davecheney | caused by: Resource at https://127.0.0.1:33899/v1/1/juju-dist-test/tools/streams/v1/index.sjson not found | 21:03 |
| davecheney | caused by: request (https://127.0.0.1:33899/v1/1/juju-dist-test/tools/streams/v1/index.sjson) returned unexpected status: 404; error info: 404 Not Found | 21:03 |
| davecheney | The resource could not be found. | 21:03 |
| davecheney | looks like tool error again | 21:03 |
| davecheney | the serious error is in RPC | 21:04 |
| davecheney | which is quiet serious 'cos that is what powers the api | 21:04 |
| davecheney | ok, a binch of errors because i didn't run godeps recently | 21:08 |
| thumper | sinzui: what are your 1.17.7 plans? | 21:08 |
| davecheney | sinzui: do you want | 21:08 |
| davecheney | a. individual bugs for these test faliures | 21:08 |
| davecheney | b. one bigass bug for it all | 21:08 |
| davecheney | c. no bugs, just fixes | 21:09 |
| thumper | wwitzel3: are you still around? | 21:10 |
| sinzui | davecheney, I actually like individual bugs. Each is something valuable to say we fixed | 21:14 |
| davecheney | sinzui: right ok | 21:14 |
| davecheney | i might do it a bit arse backwards and raise a bug when I raise a mp | 21:14 |
| davecheney | i don't think it is super valuable to do a pass of all the things that re not passing | 21:14 |
| davecheney | we have more than enough bugs | 21:14 |
| sinzui | davecheney, I have done the same when my head is working on this fix | 21:15 |
| davecheney | and they will possibly be dupes | 21:15 |
| davecheney | and finally, we have the juju CI for the overall status which is reported to our betters | 21:15 |
| sinzui | davecheney, We can dedupe. We always look better when we can say, we fixed more than we planned | 21:15 |
| davecheney | sinzui: ok, i'll use my judgement | 21:16 |
| davecheney | (everyone backs slowly away) | 21:16 |
| sinzui | thumper I really like the state of Juju. I will release 1.17.7 tomorrow. I will pick a rev that CI likes. Well I will caution that canonistack is sick and I might make those tests optional | 21:17 |
| thumper | sinzui: what's up with canonistack? | 21:17 |
| sinzui | ah, abentley has already made them optional | 21:17 |
| sinzui | thumper, The cloud is suffering very poor performance. Tests that took 5 minutes last month now take 30. I can complete tests in azure fater | 21:18 |
| sinzui | faster | 21:18 |
| thumper | omg | 21:18 |
| thumper | that is terrible | 21:18 |
| davecheney | canonistack, now slower than azure | 21:19 |
| davecheney | not something I want on a bumper sticker | 21:19 |
| thumper | haha | 21:19 |
| sinzui | thumper, The slowness may also be exacerbating issues were juju status returns an error. Aaron is adding a retry to the rules. Retrying status for 10 minutes is faster than starting the test over for 30 minutes | 21:19 |
| davecheney | canonistack, it's got electrolites | 21:19 |
| davecheney | canonistack, shut her down, she's sucking mud! | 21:21 |
| wallyworld | thumper: ffs, lachie has left some school books at home, i need to go and take them to the school, bbiab | 22:52 |
| davecheney | niemeyer: you around ? | 23:23 |
| niemeyer | davecheney: yo | 23:23 |
| davecheney | niemeyer: http://paste.ubuntu.com/7159729/ | 23:23 |
| niemeyer | davecheney: Hmm | 23:23 |
| niemeyer | davecheney: What happened to the entries? | 23:23 |
| davecheney | this is on ppc64 | 23:24 |
| davecheney | built under gccgo | 23:24 |
| davecheney | the syscall pacakge is different there | 23:24 |
| niemeyer | davecheney: Slightly awkward in this case, I suppose | 23:24 |
| davecheney | niemeyer: is there a build tag for the compiler ? | 23:24 |
| niemeyer | davecheney: This is an ioctl for the terminal device | 23:24 |
| davecheney | // +build gc ? | 23:24 |
| davecheney | the constants will be the same, it is linux after all | 23:25 |
| niemeyer | davecheney: It's not clear why gccgo and ppc aren't happy about it | 23:25 |
| niemeyer | davecheney: Right | 23:25 |
| niemeyer | davecheney: Also, FWIW, this is stolen from the stock go.crypto ssh | 23:25 |
| davecheney | niemeyer: yeah, that also doesn't work on ppc :* | 23:26 |
| davecheney | :( | 23:26 |
| niemeyer | davecheney: But it's a pretty minimal part of it | 23:26 |
| davecheney | niemeyer: if I did up a patch that use a build tag on the compiler | 23:26 |
| niemeyer | davecheney: This is just grabbing the username and disabling echo for the password | 23:26 |
| davecheney | to either import the constants frmo syscall if the compiler is gc | 23:26 |
| davecheney | or define them locally if it's gccgo ? | 23:26 |
| niemeyer | davecheney: I suggest just defining them locally all the time.. if that makes ppc happy, we can just put a sad-face comment above it, and ask somebody to fix it for us eventually | 23:27 |
| davecheney | niemeyer: SGTM | 23:27 |
| davecheney | this is in the _linux.go file | 23:28 |
| davecheney | and those constants do not change | 23:28 |
| davecheney | niemeyer: will propose a patch real soon | 23:28 |
| niemeyer | Thanks! | 23:28 |
| davecheney | niemeyer: https://code.launchpad.net/~dave-cheney/goetveld/003-fix-syscall-constants-for-gccgo/+merge/212961 | 23:39 |
| davecheney | did this on my local machine | 23:39 |
| davecheney | as lbox isn't working on ppc | 23:39 |
| davecheney | testing on there now | 23:39 |
| davecheney | ubuntu@winton-02:~/src/launchpad.net/lbox$ lbox | 23:41 |
| davecheney | Usage: lbox <command> [options] | 23:41 |
| davecheney | yup, now it works | 23:41 |
| niemeyer | davecheney: Have you tried an interaction that requires the terminal stuff? | 23:50 |
| davecheney | niemeyer: yup, works fine | 23:54 |
| davecheney | axw https://bugs.launchpad.net/juju-core/+bug/1298115 | 23:54 |
| _mup_ | Bug #1298115: utils/ssh: test failures <ppc64el> <juju-core:Triaged> <https://launchpad.net/bugs/1298115> | 23:54 |
| davecheney | niemeyer: thanks! | 23:58 |
| niemeyer | davecheney: No problem, and thanks for the fx | 23:59 |
| niemeyer | fx | 23:59 |
| niemeyer | fix | 23:59 |
| niemeyer | Thinkpad's are not the same anymore | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!